Brian Gough
503822deb0
avoid possible exception if selection is undefined
...
defensive programming only
2017-06-15 14:32:00 +01:00
Brian Gough
b9804823f3
handle off-screen selection
...
when toggling the logs button the selection is off-screen and
selection.toString() is empty even when there is a selected range. Can
check for selection.type being "Range" instead.
2017-06-15 14:21:42 +01:00
Brian Gough
b04288ed44
avoid getting duplicate handlers for mouseup
2017-06-15 14:21:42 +01:00
Shane Kilkelly
403d822174
Alter labels debouncer to handle transitions between docs
2017-06-15 14:09:49 +01:00
Brian Gough
76dcde4dae
hide the text layer on reload
2017-06-15 13:42:19 +01:00
Paulo Reis
fbaa918927
Do not show the text layer when the user clicks outside pages. Remove some debug statements.
2017-06-15 12:32:04 +01:00
Paulo Reis
4985f7ca1c
Different approach: render all text layers while selecting (WIP).
2017-06-15 12:32:04 +01:00
Paulo Reis
786659dc1b
Render text layer on hovered pages (and adjacent ones).
2017-06-15 12:32:04 +01:00
Paulo Reis
1b07dda1b9
Use less specific (i.e. faster) selectors.
2017-06-15 12:32:04 +01:00
Paulo Reis
f0a940df35
Make the PDF text layer non-renderable by default.
2017-06-15 12:32:04 +01:00
Brian Gough
cb1cacebb5
set text layer to display:none for faster scroll
2017-06-15 12:32:03 +01:00
Brian Gough
1ecabaa611
Revert "update pdfjs to v1.8.188"
...
This reverts commit 189e48dcc00f530eff674cc4a2b87c06814d45ff.
2017-06-15 11:14:01 +01:00
Shane Kilkelly
69471c4f74
Remove old references to services/labels
2017-06-15 09:27:00 +01:00
Shane Kilkelly
b0bb4b3e47
Merge branch 'sk-ref-variants'
2017-06-15 09:17:48 +01:00
Shane Kilkelly
5a6415d3f8
Add logging for Labels http actions
2017-06-15 08:56:48 +01:00
Shane Kilkelly
9607174b64
Merge branch 'master' into sk-server-side-labels-loading
2017-06-15 08:49:14 +01:00
Shane Kilkelly
3f1a440d66
Support variations of \ref{}
, such as \cref{}
, \eqref{}
, etc..
2017-06-14 15:15:07 +01:00
Shane Kilkelly
b0ff8e0745
Fix a typo: prefxi
=> prefix
2017-06-14 15:14:38 +01:00
Shane Kilkelly
5e37b1dac1
Move logic for selectively loading labels.
...
Only load labels if the user has write permission
2017-06-14 13:26:02 +01:00
Brian Gough
e1efc3a7b5
Merge pull request #521 from sharelatex/bg-reduce-pdf-memory-usage
...
Revert "use a single pdfjs worker, rotated to avoid leaks"
2017-06-13 16:46:58 +01:00
Brian Gough
9687daf97f
Merge pull request #520 from sharelatex/bg-upgrade-pdfjs-1.8.188
...
upgrade pdfjs 1.8.188
2017-06-13 16:46:10 +01:00
Brian Gough
b123b033ab
Merge pull request #519 from sharelatex/bg-remove-pdfjs-1.6.210p2
...
remove old version of pdfjs
2017-06-13 16:45:25 +01:00
Shane Kilkelly
3b066758bb
Don't load labels for anonymous/read-only users
2017-06-13 14:06:00 +01:00
Shane Kilkelly
954c53aec6
Move the labels event logic into ide/labels/LabelsManager
2017-06-13 13:29:03 +01:00
Shane Kilkelly
a04eb1197d
Move labels service to /ide/labels/services/labels
2017-06-13 11:43:25 +01:00
Shane Kilkelly
b97becc7a2
Change getLabelsForDoc
to broadcastLabelsForDoc
2017-06-13 11:38:15 +01:00
Shane Kilkelly
a3dbb16e50
Flush project before getting all project labels
2017-06-13 11:15:26 +01:00
Shane Kilkelly
bd6133aadb
Remove callback-pattern from label parsers
2017-06-13 11:10:21 +01:00
Shane Kilkelly
c25b6b792d
Namespace the document route under /doc/
2017-06-13 10:57:51 +01:00
Shane Kilkelly
d1a85304d2
Add comment
2017-06-12 15:47:31 +01:00
Shane Kilkelly
26be4f84d0
Re-use parser
2017-06-12 15:15:14 +01:00
Shane Kilkelly
debb0c06a4
Clearer logic for triggering labels-loading
2017-06-12 14:23:29 +01:00
Shane Kilkelly
0a491a4f13
Add comment, explain flushing of doc to mongo
2017-06-12 13:09:13 +01:00
Shane Kilkelly
ff4991284d
Change docLabelsUpdated
socket event to broadcastDocLabels
2017-06-12 13:06:56 +01:00
Shane Kilkelly
234a2d0e21
Remove cruft
2017-06-12 11:37:34 +01:00
Shane Kilkelly
9f9468d0e0
Use lowercase project_id
2017-06-12 11:37:05 +01:00
Shane Kilkelly
c9432a1238
Fix unit tests
2017-06-12 10:09:33 +01:00
Shane Kilkelly
1bb065344c
Move labels into an Angular Service
2017-06-12 09:44:32 +01:00
Shane Kilkelly
56385a798b
Use ide.$http, rather than jquery
2017-06-09 11:41:35 +01:00
James Allen
7137ab643f
Merge pull request #523 from sharelatex/ja-removing-group-holding-accounts
...
Use an email based invite system for groups, not holding accounts
2017-06-09 11:36:42 +01:00
Shane Kilkelly
5443b92e7d
Move state management into LabelsMaster on the ide
2017-06-09 11:28:27 +01:00
James Allen
ba3822d1ae
Encode email for URL when deleting invited group email
2017-06-09 10:39:48 +01:00
James Allen
69bc6fc8e4
Maintain backwards compatibility with old holding accounts in removal end points
2017-06-08 16:53:22 +01:00
Paulo Reis
cc7f44737e
Tell Angular to avoid parsing the value attribute.
2017-06-08 16:02:28 +01:00
Shane Kilkelly
965a46291b
Only fetch labels for uploaded docs, not files
2017-06-08 15:55:17 +01:00
Shane Kilkelly
ff7955dfdb
Update labels when docs are uploaded or removed
2017-06-08 15:12:18 +01:00
James Allen
4cecbae6b6
Use an email based invite system for groups, not holding accounts
2017-06-08 12:12:08 +01:00
Shane Kilkelly
feb1d87de1
Add test for LablesHandler
2017-06-08 10:25:39 +01:00
Shane Kilkelly
3c4a6f06be
Add unit tests for LabelsController
2017-06-08 09:22:26 +01:00
Shane Kilkelly
c7dbd21cd1
use flag on aceEditor to enable autocomplete features
2017-06-08 09:22:08 +01:00
Paulo Reis
240d6d6f6b
Resolve timing issue when triggering selection-related logic.
2017-06-07 14:21:05 +01:00
Paulo Reis
53b18e041f
Trigger selection-related logic after accepting or rejecting changes.
2017-06-07 14:03:58 +01:00
Brian Gough
aa8974dcd6
Revert "use a single pdfjs worker, rotated to avoid leaks"
...
This reverts commit f270ef54911acd800d2ffd577080b50ea2fe4aff.
Use a new worker on each reload to free up memory.
2017-06-07 13:29:10 +01:00
Paulo Reis
19ecffd654
Merge branch 'master' into pr-aggregate-insert-delete
2017-06-06 17:04:31 +01:00
Paulo Reis
34796b18c5
Add translation keys.
2017-06-06 16:46:36 +01:00
Paulo Reis
afa011c813
Avoid flickering when elements enter the review panel.
2017-06-06 16:11:00 +01:00
Brian Gough
e417a72e0a
remove old version of pdfjs
2017-06-06 15:06:09 +01:00
Paulo Reis
73a67c6617
Add a note on the need of reverse sorting changes when rejecting.
2017-06-06 13:34:48 +01:00
Brian Gough
ecf0857756
update pdfjs to v1.8.188
2017-06-06 12:19:13 +01:00
Brian Gough
ff7e383f08
add compatibility.js from pdfjs repo
2017-06-06 12:18:58 +01:00
Paulo Reis
4504f77aa3
Do bulk rejects in reverse order.
2017-06-06 12:06:43 +01:00
Brian Gough
5aa1e4cc2a
add pdfjs-1.8.188
2017-06-06 11:47:30 +01:00
Paulo Reis
81a5a5311d
Clear selection after bulk actions.
2017-06-06 10:03:33 +01:00
Paulo Reis
af93fc1869
Make aggregate entries work when the review panel is minimised.
2017-06-06 10:00:50 +01:00
Brian Gough
b277ee3254
Merge pull request #511 from sharelatex/bg-handle-web-api-errors
...
use a separate error handler for api router errors
2017-06-06 09:22:28 +01:00
Paulo Reis
5a75663a0c
Do bulk rejects in reverse order.
2017-06-05 17:17:47 +01:00
Paulo Reis
e616a62d68
Save entry ids inside entry object, not only as the key.
2017-06-05 16:29:55 +01:00
Shane Kilkelly
f7ad4a4786
WIP: basically working, with client sync
2017-06-05 14:48:50 +01:00
James Allen
cb1745a1e6
Fix redirect in clone project modal
2017-06-05 13:33:32 +01:00
James Allen
d7981fd2d4
Merge pull request #512 from sharelatex/ja-project-name-validation
...
Refactor project name validation into one place and restrict /s
2017-06-05 11:55:39 +01:00
Shane Kilkelly
51881dbbcc
Only load labels from current doc if change is local
2017-06-05 11:09:58 +01:00
Paulo Reis
d4ac91f75e
Use correct handlers in directives.
2017-06-05 10:52:11 +01:00
Paulo Reis
6c3cdbcc3a
Remove dead code, backend does not send single change events anymore.
2017-06-05 10:43:03 +01:00
Paulo Reis
8d8bcab1e8
Consolidate change accept and reject code.
2017-06-05 10:41:59 +01:00
Shane Kilkelly
f29320dd93
Add ability to load labels from single document
2017-06-05 09:26:13 +01:00
Shane Kilkelly
4cb41a988a
WIP: initial work on server-side labels
2017-06-02 15:12:59 +01:00
Paulo Reis
e2edf4184f
Explicit naming.
2017-06-02 11:43:43 +01:00
Shane Kilkelly
0e498d5e65
Merge branch 'master' of github.com:sharelatex/web-sharelatex
2017-06-02 09:55:30 +01:00
Shane Kilkelly
51e3a6b3a3
Don't use String.startsWith, use slice instead.
...
- String.startsWith is not supported in IE
2017-06-02 09:54:48 +01:00
Paulo Reis
26260fc11f
Prevent aggregation of changes from different users.
2017-06-01 16:33:50 +01:00
Paulo Reis
b2a7686204
DRYness.
2017-06-01 15:28:37 +01:00
Paulo Reis
2a0454f2f1
Integrate aggregate changes with bulk actions.
2017-06-01 15:18:43 +01:00
Paulo Reis
1490ea7b04
Change aggregated change model: the main change is now the insertion, deletion is stored in metadata.
2017-06-01 15:03:37 +01:00
Paulo Reis
11c0644490
Aggregate changes; make accept and reject work.
2017-06-01 11:47:55 +01:00
Shane Kilkelly
6feb6959a3
Merge pull request #517 from sharelatex/pr-fix-error-banner-clicks
...
Make the alert container a zero-height static element, to avoid capt…
2017-06-01 09:15:46 +01:00
Shane Kilkelly
6b746f757e
Merge pull request #514 from sharelatex/ja-update-raven
...
Update Raven (Sentry lib) to 3.15.0 in client
2017-06-01 09:13:40 +01:00
Shane Kilkelly
5847973615
Merge pull request #515 from sharelatex/ja-editable-asy-files
...
Make .asy files editable when uploaded
2017-06-01 09:13:25 +01:00
Shane Kilkelly
9a15420c4e
Merge branch 'master' into sk-labels-autocomplete
2017-06-01 08:34:56 +01:00
Paulo Reis
3cf8f26583
Add collapse and expand behaviour to aggregate change entries.
2017-05-31 16:23:24 +01:00
Paulo Reis
b6cef2e3d7
Include directive; add some styling.
2017-05-31 15:53:14 +01:00
Paulo Reis
a6108480f5
Add directive to show change entries.
2017-05-31 14:47:25 +01:00
Shane Kilkelly
039d18bf8b
Simplify logic for deciding whether to re-scan doc on not
2017-05-26 15:08:38 +01:00
Shane Kilkelly
faf0337ca9
Refactor labels autocomplete
2017-05-26 14:56:38 +01:00
Paulo Reis
17acede8ce
Control visibility when there are no entries.
2017-05-26 09:58:12 +01:00
Paulo Reis
7fbf6d97bd
Merge branch 'master' into pr-hide-review-panel
2017-05-26 09:39:29 +01:00
Paulo Reis
749fc6a425
Make the alerts container a zero-height static element, to avoid capturing clicks.
2017-05-25 16:10:10 +01:00
Shane Kilkelly
7923450e25
Move labelsManager into aceEditor directory
2017-05-25 09:42:07 +01:00
Shane Kilkelly
0543f32ff0
Add comment explaining debounce
2017-05-25 09:35:38 +01:00
Shane Kilkelly
ea9a0dda83
More robust change detection for autocomplete.
...
- accurately detect when labels are involved in 'remove' event
2017-05-25 09:33:15 +01:00
Shane Kilkelly
1ba8b702ad
More robust regex for matching/parsing labels.
...
- limit label name to max 80 characters
- don't use `.*`
- limit total labels per document to 1000
2017-05-25 09:32:10 +01:00
Shane Kilkelly
a363b62f23
Remove periodic polling of document for labels
2017-05-25 09:31:36 +01:00
Shane Kilkelly
d0bf407515
Use coffeescript =>
functions, rather than self=this
.
2017-05-24 15:05:53 +01:00
Shane Kilkelly
efd01081f7
Set up and automatic refresh of labels
2017-05-24 14:28:27 +01:00
Shane Kilkelly
b871cdab4c
Remove debug logs
2017-05-24 14:28:15 +01:00
Shane Kilkelly
1f3a375b4e
Update commentary
2017-05-24 11:42:00 +01:00
Shane Kilkelly
da84b3f31c
WIP: basically working labels/ref autocomplete
2017-05-24 11:40:12 +01:00
Shane Kilkelly
17dd64f48a
Merge pull request #507 from sharelatex/sk-squash-web-errors
...
Squash various web errors
2017-05-24 10:57:18 +01:00
Shane Kilkelly
c43a2087d7
WIP: autocomplete for label/ref
2017-05-24 10:07:14 +01:00
James Allen
e2be4b6293
Make .asy files editable when uploaded
2017-05-22 17:12:01 +01:00
James Allen
32b27766bc
Update Raven (Sentry lib) to 3.15.0 in client
2017-05-22 16:45:50 +01:00
James Allen
59085c1ddd
Add missing require stubs and remove console.logs in unit tests
2017-05-22 15:33:52 +01:00
James Allen
3105c6743e
Fix unit tests
2017-05-22 15:24:52 +01:00
Brian Gough
4b188ce120
support separate processes for web and api
...
via an environment variable WEB_TYPE
2017-05-22 13:31:02 +01:00
Paulo Reis
8dfb91fa6f
Blur toggler after clicking.
2017-05-22 11:11:26 +01:00
Paulo Reis
35c90daa8b
Also show the toggler when the review panel is minimized.
2017-05-22 11:07:57 +01:00
James Allen
ba62206b91
Refactor project name validation into one place and restrict /s
2017-05-19 17:42:24 +01:00
Paulo Reis
0c8cacc222
Highlight review panel splitter when hovered.
2017-05-19 17:08:52 +01:00
Paulo Reis
58ad62c413
Relayout entries when commenting.
2017-05-19 16:57:51 +01:00
Brian Gough
5ac2ed8fc6
use a separate error handler for api router errors
2017-05-19 16:36:29 +01:00
Paulo Reis
914e50f3f6
Add new review-related hotkeys; re-arrange hotkeys modal.
2017-05-19 15:52:04 +01:00
Paulo Reis
75c5bf60a8
Make hotkeys modal larger.
2017-05-19 15:51:32 +01:00
Paulo Reis
15980d5427
Merge branch 'master' into pr-hide-review-panel
2017-05-19 15:31:14 +01:00
Paulo Reis
957b201fc1
Add commenting and track-changes keyboard shortcuts.
2017-05-19 15:28:49 +01:00
James Allen
76b8fecde9
Merge pull request #509 from sharelatex/ja-fix-clsi-cookie-cluster
...
Don't try to set the server id if it isn't returned in the response
2017-05-19 15:00:18 +01:00
James Allen
01548a0216
Don't try to set the server id if it isn't returned in the response
2017-05-19 10:23:01 +01:00
Paulo Reis
b0b75e2ebb
Update docupdaterhandler tests.
2017-05-18 15:04:12 +01:00
Paulo Reis
e532f543a3
Merge branch 'master' into pr-bulk-actions
2017-05-18 14:38:16 +01:00
James Allen
39ca6d1e6c
Merge pull request #508 from sharelatex/ja-fix-clsi-cookie-cluster
...
Check for blank string in clsi cookie caching
2017-05-18 11:12:11 +01:00
James Allen
f708a0cd81
Check for blank string in clsi cookie caching
...
ioredis returns "" for a blank entry, the previous driver returned null,
so also check for a blank string
2017-05-18 11:09:33 +01:00
Paulo Reis
832764dd3d
Add key shortcut to toggle the review panel.
2017-05-18 11:02:50 +01:00
Paulo Reis
7c26628ce0
Improve styling.
2017-05-18 11:02:31 +01:00
Paulo Reis
5a9519d18f
Add a toggler element inside the review panel.
2017-05-17 16:41:53 +01:00
Brian Gough
5237647b8b
Merge pull request #489 from sharelatex/bg-improve-upload-robustness
...
improve stream error handling on upload
2017-05-17 15:26:03 +01:00
Shane Kilkelly
6338835baf
Merge branch 'sk-sudo-mode'
2017-05-17 09:48:22 +01:00
Shane Kilkelly
4e3284cec8
Merge branch 'sk-dont-redirect-to-images'
2017-05-17 09:48:16 +01:00
Paulo Reis
7f3c0ed5ac
Refactor accept and reject methods to support multiple changes; support bulk actions events.
2017-05-16 14:27:06 +01:00
Paulo Reis
36b4a8e6c2
Update ranges tracker.
2017-05-16 14:04:13 +01:00
Paulo Reis
ac99422c26
Update ranges tracker.
2017-05-16 14:04:06 +01:00
Paulo Reis
a3c529d23f
Update range tracker with new bulk method.
2017-05-16 14:03:52 +01:00
Shane Kilkelly
25e0a19350
Make confirm-password routes more restful
2017-05-16 11:51:06 +01:00
Shane Kilkelly
ada614cc69
Check response exists before calling method
2017-05-16 09:20:12 +01:00
Brian Gough
e23871118d
Merge remote-tracking branch 'origin/master' into bg-improve-upload-robustness
2017-05-15 16:01:01 +01:00
Shane Kilkelly
60d3e4a97b
If external auth system is in use, skip sudo-mode checks
2017-05-15 15:46:24 +01:00
Shane Kilkelly
707a81cc2a
Correct title of confirm-password page
2017-05-15 15:46:11 +01:00
James Allen
5aa8b71832
Allow writing of clsi cookie cache to redis cluster secondary
2017-05-15 15:35:01 +01:00
Brian Gough
0908e36fb7
fix unit tests
2017-05-15 13:46:01 +01:00
Shane Kilkelly
1d7d0193fc
Use translations for sudo-mode prompt
2017-05-15 13:37:54 +01:00
Shane Kilkelly
1f7724be68
Merge branch 'sk-sudo-mode' of github.com:sharelatex/web-sharelatex into sk-sudo-mode
2017-05-15 11:54:14 +01:00
Shane Kilkelly
c864288c4e
On logout, clear sudo mode
2017-05-15 11:53:52 +01:00
James Allen
17b064df18
Adjust style of sudo mode prompt
2017-05-15 11:45:41 +01:00
Paulo Reis
f4e46bb2f9
Use new ranges tracker method to get N changes at once; small refactor.
2017-05-15 11:24:40 +01:00
Paulo Reis
7bb5d65b52
Update ranges tracker.
2017-05-15 11:11:28 +01:00
Shane Kilkelly
0f75d9f4d9
Test SudoModeController
2017-05-15 10:56:43 +01:00
Paulo Reis
82a19444b3
Merge branch 'master' into pr-bulk-actions
2017-05-15 10:29:15 +01:00
Shane Kilkelly
76285a1554
Start testing SudoModeController
2017-05-15 10:07:22 +01:00
Shane Kilkelly
8605dc83b4
Merge branch 'master' into sk-sudo-mode
2017-05-15 09:21:13 +01:00
Shane Kilkelly
0e26222551
Don't redirect to images, icons, etc, in login workflow
2017-05-12 15:46:16 +01:00
Paulo Reis
dd85c2fab2
Remove debug line.
2017-05-12 15:44:49 +01:00
Paulo Jorge Reis
d550ede112
Merge pull request #496 from sharelatex/pr-review-panel-relayout
...
Review panel relayout
2017-05-12 13:54:59 +01:00
Shane Kilkelly
1640dfa79a
Merge branch 'sk-fix-cooldown-tpds'
2017-05-12 09:11:23 +01:00
James Allen
3bfd92dd9c
Rename lock to avoid potential conflict with doc updater
2017-05-11 15:27:01 +01:00
Paulo Reis
658e70a772
Update ranges tracker.
2017-05-11 11:32:12 +01:00
Shane Kilkelly
7b0aca7f02
add cooldown to tpds mergeUpdate
path
2017-05-11 11:29:57 +01:00
Paulo Reis
f2dac28a65
Consolidate some watchers.
2017-05-11 10:23:41 +01:00
Paulo Reis
a3ab994ab3
Use the same watcher to control miniRP visibility and trigger Ace resizing.
2017-05-11 10:17:25 +01:00
Shane Kilkelly
a08dd26ef3
Remove CooldownMiddlewear from Tpds routes
2017-05-11 10:07:04 +01:00
Shane Kilkelly
e6286c721d
Merge branch 'master' into sk-fix-large-projects
2017-05-11 08:40:17 +01:00
Shane Kilkelly
01ee104f77
Revert "update to newest mongoose"
...
This reverts commit 7b05891ba0e87e4cf00fd6b1ea87d7406dc70989.
2017-05-10 15:31:17 +01:00
Shane Kilkelly
08567ff220
if projectId is not defined, error out
2017-05-10 15:25:23 +01:00
Shane Kilkelly
b8e4cafd81
Fix log line
2017-05-10 15:16:36 +01:00
Shane Kilkelly
27842996aa
start testing SudoModoController
2017-05-10 15:15:57 +01:00
Shane Kilkelly
4d662f23de
test SudoModeMiddlewear
2017-05-10 14:54:49 +01:00
James Allen
274d6f4ac6
Merge pull request #493 from sharelatex/ja-redis-cluster-refactor
...
Move all redis end points to be cluster compatible
2017-05-10 14:38:37 +01:00
Shane Kilkelly
b09a41c557
Fix acceptance tests
2017-05-10 13:45:53 +01:00
Shane Kilkelly
993c261b10
start testing sudo-mode
2017-05-10 11:37:32 +01:00
Shane Kilkelly
08fd501ce2
Add a hint to the sudo-mode prompt
2017-05-10 11:36:35 +01:00
Shane Kilkelly
16128288a9
Add sudo-mode protection to sessions page
2017-05-10 11:36:19 +01:00
Shane Kilkelly
5a97521b04
Fix typo in log message
2017-05-10 11:36:05 +01:00
Shane Kilkelly
a3a2108526
Increase sudo-mode time to one hour
2017-05-10 11:35:47 +01:00
Shane Kilkelly
094784b6d5
protect settings page with sudo-mode middlewear
2017-05-10 10:25:32 +01:00
Shane Kilkelly
029c96c7cc
Add sudo-mode 'confirm password' prompt
2017-05-10 10:05:48 +01:00
James Allen
e19f5a1a5e
Update redis-sharelatex and shrinkwrap
2017-05-09 17:18:04 +01:00
Paulo Reis
8aee0edfe8
Integrate bulk actions dialog with controller actions.
2017-05-09 16:06:34 +01:00
Paulo Reis
f3e020df7e
Add dialog to confirm bulk actions.
2017-05-09 16:06:19 +01:00
Shane Kilkelly
fd0176c0cf
if project goes over maximum allowed files, put on cooldown
2017-05-09 14:20:29 +01:00
Shane Kilkelly
8e90b7fb9b
Add Cooldown to Tpds routes
2017-05-09 13:54:11 +01:00
Shane Kilkelly
149e38855f
Add a cooldown mechanism for projects which go over limits
2017-05-09 11:40:42 +01:00
Paulo Reis
499272cbb5
Use new range-tracker method.
2017-05-08 16:12:21 +01:00
Paulo Reis
03b8b72520
Update range tracker with new bulk method.
2017-05-08 16:10:08 +01:00
Shane Kilkelly
c5c0364d49
update to newest mongoose
2017-05-08 16:09:59 +01:00
Paulo Reis
3ced808411
Use a single accept changes method.
2017-05-05 15:19:31 +01:00
James Allen
014e3afb36
Don't call sync functions inside async
...
Calling sync functions inside async can trigger the node max stack size.
Instead, build up our unique list of ids in advance, so we only call a
method in async for each user we actually need to look up, asynchronously.
Then use all the cached values synchronously afterwards.
2017-05-04 17:04:20 +01:00
Paulo Reis
f25db3ff64
Reflect accepted changes on the UI layer.
2017-05-04 15:47:25 +01:00
Paulo Reis
19828d3c5b
Basic bulk accept support.
2017-05-04 15:33:47 +01:00
James Allen
3f51911513
Update to latest redis-sharelatex
2017-05-04 15:25:58 +01:00
James Allen
8449b0417c
Move all redis end points to be cluster compatible
2017-05-04 15:22:54 +01:00
Paulo Reis
6662ec34ae
Only show bulk actions when n changes > 1.
2017-05-04 11:30:05 +01:00
Paulo Jorge Reis
20433327b8
Merge pull request #490 from sharelatex/pr-align-pdf-icon
...
Use header button classes in the PDF button.
2017-05-04 09:59:11 +01:00
Paulo Jorge Reis
9d2d217d35
Merge pull request #491 from sharelatex/pr-project-list-improvements
...
Project list improvements
2017-05-04 09:59:02 +01:00
Paulo Reis
8f6d11632b
Add bulk rejection support.
2017-05-03 17:16:41 +01:00
Paulo Reis
dae66d5edf
Add bulk methods in controller.
2017-05-03 17:16:29 +01:00
Paulo Reis
05d9bf47d1
Use entry ids instead.
2017-05-03 16:53:04 +01:00
Paulo Reis
bf7bf701ed
Store selected entries; improve visibility logic.
2017-05-03 16:35:58 +01:00
Paulo Reis
0249a13012
Add bulk actions as in-editor widgets.
2017-05-03 11:41:17 +01:00
Paulo Reis
722d75f6ef
Correctly check if deletions are within selection.
2017-05-02 17:08:41 +01:00
Paulo Reis
3f441ff38c
Count entries within selection; only show bulk actions if there are selected entries.
2017-05-02 17:02:30 +01:00
Paulo Reis
b7d5faed77
Basic bulk actions styling.
2017-05-02 16:15:52 +01:00
Paulo Reis
e2eaf6619e
Bulk actions directive; include it in the review panel.
2017-05-02 16:15:40 +01:00
Paulo Reis
76ea497b33
Use a single entry for bulk actions.
2017-05-02 15:43:45 +01:00
Paulo Reis
d874eb70f8
Add and remove bulk accept and reject entries with selections.
2017-05-02 15:34:05 +01:00
Paulo Reis
bf872dc94f
Vertically center label text and button.
2017-05-02 12:20:28 +01:00
Paulo Reis
d71296da9f
Add row clicking in the projects list.
2017-05-01 17:11:03 +01:00
Paulo Reis
208f021bd0
Actually remove project from tag, inline.
2017-05-01 16:00:25 +01:00
Paulo Reis
2708fdf159
Add a button to allow inline removal of tags.
2017-05-01 15:43:44 +01:00
Paulo Reis
bca916d504
Use header button classes in the PDF button.
2017-05-01 15:04:08 +01:00
Paulo Reis
9fb166d2b3
Style improvements.
2017-04-28 17:09:34 +01:00
Paulo Reis
6e40284099
Add untagged projects counter.
2017-04-28 16:57:37 +01:00
Paulo Reis
2d4c5f012a
Styling for untagged filter.
2017-04-28 16:57:25 +01:00
Brian Gough
679680532f
improve stream error handling on upload
2017-04-28 14:47:18 +01:00
Paulo Reis
84a2658259
Add an untagged filter in the projects list.
2017-04-28 12:11:51 +01:00
Brian Gough
46f693519a
return 404 for api request on missing doc
2017-04-27 16:41:53 +01:00
Paulo Reis
877cd8e018
Apply stored filtering options.
2017-04-27 16:18:16 +01:00
Paulo Reis
884a89893d
Save and read filtering options from local storage.
2017-04-27 16:17:28 +01:00
Henry Oswald
3bdd5a4a2e
Merge pull request #483 from sharelatex/ja-dont-fail-on-tpdsworker-error
...
Continuing flushing document on tpds worker error
2017-04-25 09:19:13 +01:00
Henry Oswald
5d55e383c7
Merge pull request #485 from sharelatex/sk-warn-on-zip-failure
...
when the uploaded file is not a zip, warn instead of error
2017-04-25 09:18:17 +01:00
Henry Oswald
f5267ac6ee
Merge pull request #481 from sharelatex/ja-encode-project-names
...
Error if no project returned from joinProject
2017-04-25 09:17:59 +01:00
Henry Oswald
efe5e9efb0
Merge pull request #484 from sharelatex/ho-rate-limit-compiles
...
added rate limit to compile endpoint
2017-04-25 09:17:27 +01:00
Henry Oswald
79bc4c1d3e
= != == ;)
2017-04-24 16:16:02 +01:00
Henry Oswald
c733925a26
show rate limit message when compiled too much
2017-04-24 15:56:09 +01:00
Paulo Reis
dc4aef71d7
Use new logo in the feature page.
2017-04-19 17:00:43 +01:00
Shane Kilkelly
779336e5b0
when the uploaded file is not a zip, warn instead of error
2017-04-13 15:12:54 +01:00
Shane Kilkelly
8d6370026e
Merge pull request #479 from sharelatex/pr-fix-favicon-path
...
Fetch favicon and related assets from root.
2017-04-13 13:09:29 +01:00
Shane Kilkelly
1e46a5bf7a
update shrinkwrap
2017-04-13 10:12:20 +01:00
Shane Kilkelly
e4e8520f27
Merge branch 'node-6.9'
2017-04-13 10:10:43 +01:00
Henry Oswald
65b83f2c67
added space before email for closed site
2017-04-12 17:04:12 +01:00
Shane Kilkelly
a9b8b864df
Move content-disposition setting into a method on res
2017-04-12 16:00:02 +01:00
Shane Kilkelly
02d75deaa0
when setting content-disposition, uri-encode names
2017-04-12 09:31:59 +01:00
Henry Oswald
0961a034ea
added rate limit to compile endpoint
2017-04-11 16:08:38 +01:00
James Allen
6d2f18016f
Move tpds worker error ignoring logic into tpdsUpdateSender
2017-04-11 15:41:17 +01:00
James Allen
7c8f228f48
Continuing flushing document on tpds worker error
2017-04-11 14:02:08 +01:00
Shane Kilkelly
f398e87e6f
Merge branch 'master' into node-6.9
2017-04-11 11:34:53 +01:00
James Allen
f6bd949f01
Error if no project returned from joinProject
...
socket.io seems to choke on the unicode project name and just return
undefined when it fails to parse the JSON. I've improved the escaping
of the user data on HTML load, but reporting an error is the best we
can easily do on joinProject via websockets.
2017-04-10 12:03:39 +01:00
Paulo Reis
332e4a80b2
Also fix iOS icon path.
2017-04-07 14:43:07 +01:00
Paulo Reis
a7d3721882
Fetch favicon and related assets from root.
2017-04-07 14:31:21 +01:00
James Allen
477278eea5
Merge pull request #476 from sharelatex/ja-use-new-comment-button
...
Fix on the new comment button variation
2017-04-05 11:08:59 +01:00
James Allen
ce59307c91
Merge pull request #475 from sharelatex/ja-scroll-overflow-in-review-panel
...
Allow scrolling in the review panel to extend outside of top of text …
2017-04-05 11:08:49 +01:00
James Allen
7d24fbc225
Merge pull request #477 from sharelatex/ja-encode-project-names
...
Properly pass project data as JSON and then parse it
2017-04-05 11:08:37 +01:00
James Allen
6e7b2aaacb
Merge pull request #478 from sharelatex/pr-fix-safari-accent-handling
...
Fix safari accent handling
2017-04-05 11:08:24 +01:00
Shane Kilkelly
061d2e604f
re-add npm-shrinkwrap.json
2017-04-05 10:17:32 +01:00
Shane Kilkelly
bb65da88fe
Merge branch 'master' into node-6.9
2017-04-05 10:15:51 +01:00
Paulo Reis
2ac6b70a1c
Use workaround from Ace's commits.
2017-04-04 17:08:23 +01:00
Shane Kilkelly
0555154a24
Merge branch 'sk-fix-folder-creation'
2017-04-04 11:01:07 +01:00
Paulo Reis
7855afa0cd
Remove unused scope binding.
2017-04-04 10:48:31 +01:00
James Allen
8d0186532f
Properly pass project data as JSON and then parse it
2017-04-04 10:46:46 +01:00
Paulo Reis
15de552c2c
Make new add comment button styles as the default; removed old add comment button code.
2017-04-04 10:40:53 +01:00
Shane Kilkelly
fc9bf838fc
Merge branch 'sk-upgrade-metrics'
2017-04-04 10:28:58 +01:00
James Allen
567edbfb31
Fix on the new comment button variation
2017-04-03 17:11:33 +01:00
James Allen
2fa909c707
Allow scrolling in the review panel to extend outside of top of text like Ace
2017-04-03 16:46:36 +01:00
Paulo Reis
c2df5dc01c
Apply Chrome's accent input workaround in Safari version 10.1.
2017-04-03 16:26:20 +01:00
Paulo Reis
20732ed571
Add Safari user-agent detection in Ace useragent lib.
2017-04-03 16:24:19 +01:00
Shane Kilkelly
043520fc28
Remove the Metrics module, use metrics-sharelatex
2017-04-03 16:18:30 +01:00
James Allen
335f8f78f0
Merge pull request #445 from sharelatex/pr-new-logo
...
PR New logo
2017-04-03 14:05:51 +01:00
James Allen
6b03e4b2a1
Merge pull request #470 from sharelatex/pr-fix-high-cpu-firefox
...
Set video source only when the onboarding prompt is shown.
2017-04-03 14:04:27 +01:00
James Allen
efac6b70f4
Merge pull request #468 from sharelatex/ja-allow-overlapping-comments
...
Allo overlapping comments
2017-04-03 14:04:14 +01:00
James Allen
1675185f37
Merge pull request #474 from sharelatex/pr-project-name-tooltip
...
Project name tooltip
2017-04-03 14:04:02 +01:00
Paulo Reis
4a86ff4b44
Merge branch 'master' into pr-new-logo
2017-04-03 11:17:39 +01:00
Paulo Reis
6b9b8480a8
Only show the tooltip if the project name is truncated.
2017-03-31 16:36:58 +01:00
Paulo Reis
5b8c36dfc0
Add a project name tooltip.
2017-03-31 16:13:23 +01:00
Shane Kilkelly
49de7bf315
mock out metrics in test
2017-03-31 14:54:20 +01:00
Shane Kilkelly
60b298d9ee
upgrade to latest metrics
2017-03-31 14:43:19 +01:00
Paulo Reis
855d37289b
Use ISO strings instead of of date type in locally resolved comments.
2017-03-31 14:29:28 +01:00
Shane Kilkelly
bee62400a6
Merge branch 'master' into sk-upgrade-metrics
2017-03-31 14:08:12 +01:00
Shane Kilkelly
cc81eca902
Account for error being null
2017-03-31 10:46:13 +01:00
Shane Kilkelly
2c62acee0b
Cleaner error reporting for addFolder
endpoint
2017-03-31 10:31:03 +01:00
Shane Kilkelly
15d0a40f85
When error occurs, unset state.inflight
2017-03-31 10:30:28 +01:00
Shane Kilkelly
49446afb82
Remove duplicate line
2017-03-31 10:30:10 +01:00
Paulo Reis
e9a5c37fb6
Adjust grey tone in error pages.
2017-03-30 16:46:04 +01:00
Paulo Reis
5ae7baccf5
New logo with better spacing.
2017-03-30 16:39:44 +01:00
Paulo Reis
250d19163b
Set video source only when the onboarding prompt is shown.
2017-03-30 10:35:16 +01:00
Brian Gough
13492c7fc4
handle the \feynmandiagram command in code check
...
pulled from our ace repository https://github.com/sharelatex/ace
commit baeb9aff561d048b8a839683261ffdf149ecd4ef
2017-03-29 15:27:10 +01:00
Paulo Reis
f298fac638
Improve wording on error pages.
2017-03-28 16:57:08 +01:00
Paulo Reis
5b69156948
Use slightly lighter gray in headings.
2017-03-28 16:56:46 +01:00
James Allen
4c8ce65ce7
Allo overlapping comments
2017-03-28 16:50:30 +01:00
Paulo Reis
b7040c2aa6
Remove unused assets.
2017-03-28 16:13:50 +01:00
Paulo Reis
307cd8a11b
Update favicon-related assets with new typography.
2017-03-28 16:12:52 +01:00
James Allen
3bf19a38ee
Merge pull request #467 from sharelatex/ja-validate-recurly-subscription-on-creation
...
Handle a 404 from Recurly if account doesn't exist
2017-03-28 16:06:25 +01:00
James Allen
08699d7aa2
Handle a 404 from Recurly if account doesn't exist
2017-03-28 15:46:58 +01:00
Paulo Reis
6d9563e8fb
Try Merriweather as serif font.
2017-03-28 15:18:34 +01:00
Paulo Reis
41a454a955
Update new logo.
2017-03-28 15:18:15 +01:00
James Allen
f53234271f
Merge pull request #465 from sharelatex/sk-hide-email-errors
...
If sending email fails, return a generic error.
2017-03-28 13:16:43 +01:00
James Allen
2e6e51eb6d
Merge pull request #464 from sharelatex/ja-validate-recurly-subscription-on-creation
...
Check Recurly for subscription as well before creating subscription
2017-03-28 13:15:58 +01:00
Brian Gough
835d8d618d
use error handler
2017-03-28 11:33:37 +01:00
Brian Gough
6002fdbad6
return 404 on project details not found
2017-03-28 10:30:53 +01:00
Brian Gough
f433510e61
return NotFound error in ProjectDetailsHandler
2017-03-28 10:12:52 +01:00
Brian Gough
4e66b045e3
fix unhandled exception in ProjectDetailsHandler
2017-03-28 09:44:50 +01:00
Shane Kilkelly
d2e1efe4a9
fix a daft mistake
2017-03-27 17:45:19 +01:00
Shane Kilkelly
69b9b308d4
If sending email fails, return a generic error.
...
This prevents us from leaking juicy details of our aws/ses setup via the
password-reset form.
2017-03-27 16:17:38 +01:00
Shane Kilkelly
30c5bbfdfc
Add a .nvmrc file
2017-03-27 14:45:34 +01:00
Paulo Reis
ebff500c25
Use new assets in the announcements widget.
2017-03-27 13:45:03 +01:00
Paulo Reis
6ac99115a4
Safari pinned tab favicon.
2017-03-27 13:45:03 +01:00
Paulo Reis
73a9732b8e
Favicons for mobile devices.
2017-03-27 13:45:03 +01:00
Paulo Reis
e00de35d24
Replace basic favicon.
2017-03-27 13:45:03 +01:00
Paulo Reis
c9ae114e95
Avoid capturing mouse or pointer events in graphical assets.
2017-03-27 13:45:03 +01:00
Paulo Reis
659028cf0f
Graphically anchor elements of 500 error visual.
2017-03-27 13:45:03 +01:00
Paulo Reis
70863930c3
Split 500 visual into different elements.
2017-03-27 13:45:03 +01:00
Paulo Reis
f5bf310d80
Adapt 500 error page.
2017-03-27 13:45:03 +01:00
Paulo Reis
6d74eeeb64
Improve line-height.
2017-03-27 13:45:03 +01:00
Paulo Reis
d82dc7c1a1
Basic responsive behaviour.
2017-03-27 13:45:03 +01:00
Paulo Reis
e60b1b5922
Bootstrap 404 page; integrate styles.
2017-03-27 13:45:03 +01:00
Paulo Reis
0dcfffc417
Add stylesheets for error pages.
2017-03-27 13:45:03 +01:00
Paulo Reis
34eba78a29
Add error page assets.
2017-03-27 13:33:49 +01:00
Paulo Reis
01df905986
Set new logo defaults, increase width and remove responsive portion (no need with SVG).
2017-03-27 13:33:49 +01:00
Paulo Reis
d84de8ba36
Add horizontal variant of new logo.
2017-03-27 13:33:49 +01:00
Paulo Reis
7a1c06982e
Styling of loading screen.
2017-03-27 13:33:49 +01:00
Paulo Reis
4700fa16d3
Update grey version of new lion.
2017-03-27 13:33:49 +01:00
Paulo Reis
e2755a0c7d
Add new logo assets.
2017-03-27 13:33:49 +01:00
James Allen
7aa4c0c030
Check Recurly for subscription as well before creating subscription
2017-03-27 12:07:43 +01:00
Paulo Reis
e473b5e270
Avoid line breaks in the add comment button.
2017-03-27 10:02:09 +01:00
Henry Oswald
e22da8e530
rename unit test
2017-03-27 09:57:15 +01:00
Henry Oswald
f27dfa54f1
fixup AuthenticationController from missing module after merge
2017-03-27 09:42:49 +01:00
Paulo Jorge Reis
67943a8906
Merge pull request #463 from sharelatex/pr-ab-test-add-comments
...
PR AB test "add comment" button
2017-03-27 09:32:49 +01:00
Paulo Reis
93934b9c8f
Use deploy date.
2017-03-27 09:32:02 +01:00
Henry Oswald
9c7465fd64
Merge pull request #461 from sharelatex/ho-annom-user-events
...
add identify on login
2017-03-27 09:28:34 +01:00
Henry Oswald
aa4f768513
Merge pull request #455 from sharelatex/ho-bug-fix
...
multiple small bug fixes
2017-03-27 09:28:28 +01:00
Henry Oswald
379efcb04a
Merge branch 'master' into ho-annom-user-events
2017-03-27 09:28:03 +01:00
Paulo Reis
78e8a8319d
Put review panel widgets container inside the review panel element; rearrange visibility logic.
2017-03-24 14:04:37 +00:00
Henry Oswald
ed4a321906
remove extra debug route
2017-03-23 15:39:12 +00:00
Paulo Reis
c72ee95177
Refactor AB test participation code; add conversion code.
2017-03-23 15:00:43 +00:00
Paulo Reis
254e4953cb
Wire-up AB test for adding comments.
2017-03-23 12:26:21 +00:00
Henry Oswald
cff922a0f5
idendify -> identify
2017-03-22 16:01:26 +00:00
Henry Oswald
ebdce6169e
idendifyUser on login
2017-03-22 15:50:49 +00:00
Henry Oswald
f910bb58de
add tests for AnalyticsController
2017-03-22 13:11:45 +00:00
Shane Kilkelly
4e6553ebcc
Merge branch 'sk-handle-analytics-absence'
2017-03-22 09:35:16 +00:00
Paulo Reis
d611ccd2cb
Apply z-index rule to container, not to the button.
2017-03-21 14:28:58 +00:00
Shane Kilkelly
ca3497b6f6
Update metrics version to 1.7.0
2017-03-21 13:46:42 +00:00
James Allen
b22ef30876
Merge pull request #456 from sharelatex/ja-show-too-many-track-changes-error
...
Show an explanation error message on too many track changes error
2017-03-21 13:15:14 +00:00
James Allen
e705118dfe
Merge pull request #457 from sharelatex/pr-new-add-comment-btn
...
New "add comment" button
2017-03-21 13:15:03 +00:00
Shane Kilkelly
1663f2a8eb
Use res.send, not next
2017-03-21 11:09:39 +00:00
Shane Kilkelly
1ed1eaaa05
If analytics is not configured, produce a ServiceNotConfiguredError
2017-03-21 10:57:39 +00:00
Shane Kilkelly
8a8a5a7079
Add a 'ServiceNotConfiguredError' to Errors module.
2017-03-21 10:57:09 +00:00
Paulo Reis
a35f2585c7
Remove unused flag.
2017-03-20 14:02:25 +00:00
Paulo Reis
0e24d7118d
Hide new UI behind query string parameter.
2017-03-20 13:56:36 +00:00
James Allen
1d927e5eb1
Merge pull request #454 from sharelatex/ja-show-overlapping-ranges
...
Add opacity to comment and insert ranges so they can be seen overlapping
2017-03-20 13:50:06 +00:00
James Allen
131d710a83
Merge pull request #453 from sharelatex/ja-cut-and-paste-comments
...
Move comments when cutting and pasting
2017-03-20 13:49:51 +00:00
Paulo Reis
8951e91e31
Remove add comment button from the mini review panel.
2017-03-20 11:35:35 +00:00
Paulo Reis
2c2abc3cae
Wire up new button with existing UI for adding comments.
2017-03-20 11:18:29 +00:00
Henry Oswald
ca3849c0c2
jpeg -> json
2017-03-20 11:08:42 +00:00
Paulo Reis
beac43741c
New add comment button.
2017-03-17 17:05:38 +00:00
Paulo Reis
c74449b2e3
Don't show the mini review panel when the only visible entry is the add comment one.
2017-03-17 16:28:21 +00:00
Shane Kilkelly
a64f890ed0
Upgrade metrics api
2017-03-17 14:55:41 +00:00