github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

handle off-screen selection

Browse source 
when toggling the logs button the selection is off-screen and
selection.toString() is empty even when there is a selected range.  Can
check for selection.type being "Range" instead.
This commit is contained in:
Brian Gough 2017-06-15 14:13:15 +01:00
parent b04288ed44
commit b9804823f3
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/public/coffee/ide/pdfng/directives/pdfViewer.coffee
View file

@ -442,7 +442,10 @@ define [
_hasSelection = () ->
selection = window.getSelection()
return _isSelectionWithinPDF(selection) and selection.toString() != ''
# check the selection type in preference to using
# selection.toString() as the latter is "" when the
# selection is hidden (e.g. while viewing logs)
return _isSelectionWithinPDF(selection) and selection.type is 'Range'
_isSelectionWithinPDF = (selection) ->
if selection.rangeCount == 0