Use the same watcher to control miniRP visibility and trigger Ace resizing.

This commit is contained in:
Paulo Reis 2017-05-11 10:17:25 +01:00
parent 274d6f4ac6
commit a3ab994ab3
3 changed files with 8 additions and 1 deletions

View file

@ -16,7 +16,7 @@ div.full-size(
'rp-state-current-file-expanded': (reviewPanel.subView === SubViews.CUR_FILE && ui.reviewPanelOpen),\
'rp-state-current-file-mini': (reviewPanel.subView === SubViews.CUR_FILE && !ui.reviewPanelOpen),\
'rp-state-overview': (reviewPanel.subView === SubViews.OVERVIEW),\
'rp-size-mini': (!ui.reviewPanelOpen && reviewPanel.hasEntries),\
'rp-size-mini': ui.miniReviewPanelVisible,\
'rp-size-expanded': ui.reviewPanelOpen,\
'rp-layout-left': reviewPanel.layoutToLeft,\
'rp-loading-threads': reviewPanel.loadingThreads,\

View file

@ -70,6 +70,7 @@ define [
chatOpen: false
pdfLayout: 'sideBySide'
reviewPanelOpen: localStorage("ui.reviewPanelOpen.#{window.project_id}")
miniReviewPanelVisible: false
}
$scope.user = window.user

View file

@ -126,6 +126,12 @@ define [
else
$reviewPanelEl.css "right", "0"
$scope.$watch "!ui.reviewPanelOpen && reviewPanel.hasEntries", (open, prevVal) ->
return if !open?
$scope.ui.miniReviewPanelVisible = open
if open != prevVal
$timeout () -> $scope.$broadcast "review-panel:toggle"
$scope.$watch "ui.reviewPanelOpen", (open) ->
return if !open?
if !open