github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-12 00:35:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

If analytics is not configured, produce a ServiceNotConfiguredError

Browse source
This commit is contained in:
Shane Kilkelly 2017-03-21 10:57:39 +00:00
parent 8a8a5a7079
commit 1ed1eaaa05
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
services/web/app/coffee/Features/Analytics/AnalyticsController.coffee
View file

@ -1,7 +1,14 @@
AnalyticsManager = require "./AnalyticsManager"
Errors = require "../Errors/Errors"
module.exports = AnalyticsController =
recordEvent: (req, res, next) ->
AnalyticsManager.recordEvent req.session?.user?._id, req.params.event, req.body, (error) ->
return next(error) if error?
if error?
if error instanceof Errors.ServiceNotConfiguredError
# ignore, no-op
return next(204)
else
return next(error)
res.send 204

4
services/web/app/coffee/Features/Analytics/AnalyticsManager.coffee
View file

@ -2,6 +2,7 @@ settings = require "settings-sharelatex"
logger = require "logger-sharelatex"
_ = require "underscore"
request = require "request"
Errors = require '../Errors/Errors'
makeRequest = (opts, callback)->
@ -10,8 +11,7 @@ makeRequest = (opts, callback)->
opts.url = "#{settings.apis.analytics.url}#{urlPath}"
request opts, callback
else
callback()
callback(new Errors.ServiceNotConfiguredError('Analytics service not configured'))
module.exports =