Check for blank string in clsi cookie caching

ioredis returns "" for a blank entry, the previous driver returned null,
so also check for a blank string
This commit is contained in:
James Allen 2017-05-18 11:09:33 +01:00
parent 6338835baf
commit f708a0cd81
2 changed files with 10 additions and 3 deletions

View file

@ -19,10 +19,10 @@ module.exports = ClsiCookieManager =
rclient.get buildKey(project_id), (err, serverId)->
if err?
return callback(err)
if serverId?
return callback(null, serverId)
else
if !serverId? or serverId == ""
return ClsiCookieManager._populateServerIdViaRequest project_id, callback
else
return callback(null, serverId)
_populateServerIdViaRequest :(project_id, callback = (err, serverId)->)->

View file

@ -60,6 +60,13 @@ describe "ClsiCookieManager", ->
@ClsiCookieManager._populateServerIdViaRequest.calledWith(@project_id).should.equal true
done()
it "should _populateServerIdViaRequest if no key is blank", (done)->
@ClsiCookieManager._populateServerIdViaRequest = sinon.stub().callsArgWith(1)
@redis.get.callsArgWith(1, null, "")
@ClsiCookieManager._getServerId @project_id, (err, serverId)=>
@ClsiCookieManager._populateServerIdViaRequest.calledWith(@project_id).should.equal true
done()
describe "_populateServerIdViaRequest", ->