github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
6224 commits 3 branches 7 tags 206 MiB
Commit graph

2217 commits

Author SHA1 Message Date
Brian Gough
6d73c48c36 Merge pull request #596 from sharelatex/bg-suppress-incremental-compile-after-errors 
suppress incremental compile after errors
 2017-09-11 08:15:50 +01:00
Alasdair Smith
38eaf82c65 Ensure that time is monotonic when running autocompile 2017-09-08 11:00:46 +01:00
Alasdair Smith
4a490aafbf Improve UX of triggering autocompile. 
If a user is making infrequent edits (i.e. if reading and making small
changes), then waiting 5 seconds for a recompile is bad. Therefore we track
the time since the last recompile and use this to decide whether a recompile
should be run. This reduces the time to recompile, unless the user is typing
for a significant amount of time.
 2017-09-08 10:42:54 +01:00
Alasdair Smith
e2523c569e Filter linting warnings 2017-09-07 17:45:16 +01:00
Brian Gough
c6d2f0f4e1 skip incremental compile after server error 2017-09-07 15:05:42 +01:00
Alasdair Smith
624802c28e Remove unnecessary parens 2017-09-07 11:30:42 +01:00
Alasdair Smith
b7713439bf Bring back comparsion erroneously removed 2017-09-07 11:30:20 +01:00
Alasdair Smith
9cde236bc8 Add comment explaining lint errors vs compile log errors 2017-09-07 11:28:36 +01:00
Alasdair Smith
a8cdfb7ecc Track autocompile setting change 2017-09-07 11:13:38 +01:00
Alasdair Smith
11386eb817 Add option to autocompile, so can be identified in event tracking 2017-09-07 10:20:21 +01:00
Alasdair Smith
8a8d98935b Remove unnecessary linting check in annotations listener 
When user starts typing, compile log annotations are replaced with linter ones,
so log errrors can be ignored for this purpose. Because we don't try to
autocompile unless the user types something
 2017-09-07 10:04:10 +01:00
Alasdair Smith
0c76b06a97 Increase timeout to 5 seconds 2017-09-07 10:02:48 +01:00
Alasdair Smith
320466a4f7 Catch invalid email address and show specific error message 2017-09-06 13:47:45 +01:00
James Allen
b2257db2c2 Don't get confused by commands in arguments in autocomplete 2017-09-05 19:26:13 +02:00
Alasdair Smith
ca8ba6dabe Fix incorrect checking of contact name 2017-09-05 17:18:26 +01:00
Alasdair Smith
ce630e4971 Extract timeout constant 2017-09-05 14:57:06 +01:00
Alasdair Smith
a9e94f6a6d Unsubscribe autocompile listener if disabled 2017-09-05 14:57:06 +01:00
Alasdair Smith
cca7f55322 Add autocompile setting 2017-09-05 14:57:06 +01:00
Alasdair Smith
64f70942d0 Ensure user is in beta program 2017-09-05 14:57:06 +01:00
Alasdair Smith
fc4a260d95 Ensure error is from linting not compile logs 2017-09-05 14:57:06 +01:00
Alasdair Smith
9f1adfd0c0 Replace separate autocompile ctrl with listener in PdfController 2017-09-05 14:57:06 +01:00
Alasdair Smith
53bb4fdde0 Use var in root scope instead of event to track linting error 2017-09-05 14:57:06 +01:00
Alasdair Smith
dab799a81b First pass at auto compile ctrl 2017-09-05 14:57:06 +01:00
Alasdair Smith
c42b08fcff Dispatch linting error event when changed 2017-09-05 14:57:06 +01:00
Alasdair Smith
65b2c42fad Emit event when op is acknowledged 2017-09-05 14:57:06 +01:00
Nate Stemen
54af7fbdcb adding in a few new commands that appear in SL-CLSI analysis 2017-08-31 10:39:46 +01:00
Alasdair Smith
184c8adb84 Merge pull request #582 from sharelatex/as-pdfjs-cmaps-fix 
Fix Cmaps path for future versions of PDF.js
 2017-08-31 09:36:46 +01:00
Shane Kilkelly
8a612df009 fix use of context helper in onChange 2017-08-31 08:59:38 +01:00
Shane Kilkelly
708afedeb4 Refactor out common code in AutocompleteManager. 
(first pass)
 2017-08-30 14:01:20 +01:00
James Allen
2e005fd39a Merge pull request #572 from sharelatex/ns-autocomplete 
Adding default list of commands to autocomplete
 2017-08-29 15:43:24 +02:00
Alasdair Smith
285c9587e9 Use injected Cmaps path 2017-08-25 15:48:13 +01:00
Brian Gough
f9d1650c6a Merge pull request #569 from sharelatex/bg-compile-from-redis 
compile from redis
 2017-08-25 09:09:52 +01:00
Shane Kilkelly
88923a314d Disallow toggling track-changes via keyboard if not available on project 2017-08-23 15:02:06 +01:00
Nate Stemen
adb26b1b94 forgot meta tag for "thebibiography" 2017-08-18 14:24:44 +01:00
Nate Stemen
fb4182cbb1 Merge branch 'master' into ns-autocomplete 2017-08-18 09:14:06 +01:00
Nate Stemen
42be1164bc fixing environment duplication in autocomplete issue 2017-08-17 14:30:18 +01:00
Nate Stemen
d1b906db43 renaming and organizing 2017-08-16 17:55:43 +01:00
Nate Stemen
f253b7e8cb fixing command duplication issue during suggestion 2017-08-16 17:40:01 +01:00
Nate Stemen
6e9b1c602b fixing spaces vs. tabs issue 2017-08-14 18:02:51 +01:00
Nate Stemen
688f1e9e75 merged staticManager with snippetManager 2017-08-11 09:23:36 +01:00
Brian Gough
e2048e1ed5 use incrementalCompilesEnabled as option name 2017-08-09 16:25:57 +01:00
James Allen
7538c8834f Merge branch 'master' into ja-per-user-track-changes 2017-08-09 14:05:36 +02:00
Brian Gough
97b129cbe3 enable incremental compilation for beta users 2017-08-09 10:57:24 +01:00
James Allen
e5c01df9a8 Merge pull request #544 from sharelatex/ja-update-ace 
Update Ace with new context tracking linter
 2017-08-04 10:46:34 +02:00
James Allen
6c342a6e65 Merge branch 'master' into ja-update-ace 2017-08-04 10:39:53 +02:00
Nate Stemen
769875c5d5 Adding default autocomplete commands w/ argument options 2017-08-03 16:31:46 +01:00
Shane Kilkelly
05c5b4f9c5 Merge branch 'master' into sk-fully-hide-trackchanges 2017-08-03 15:20:20 +01:00
Shane Kilkelly
9cc461605e Prevent track-changes hotkey actions when not enabled. 2017-08-03 15:17:28 +01:00
Shane Kilkelly
670d4438dc If track-changes is not enabled, don't show hotkeys for it. 2017-08-03 15:16:54 +01:00
James Allen
b2e6c028ba Merge pull request #562 from sharelatex/pr-ignore-deleted-projects-uncategorized 
Correct count of uncategorized projects
 2017-08-03 10:36:20 +02:00
James Allen
ef9b3e06ee Merge pull request #568 from sharelatex/ja-validate-contact-form 
Validate and add error status to contact form
 2017-08-03 10:35:48 +02:00
James Allen
2f3c1fae86 Merge pull request #564 from sharelatex/sk-autocomplete-graphics 
Sk autocomplete graphics
 2017-08-03 10:35:27 +02:00
James Allen
66d18bcbcd Validate and add error status to contact form 2017-08-02 14:59:03 +02:00
Shane Kilkelly
8a0f58c63d Use correct character width 2017-08-01 14:28:10 +01:00
Shane Kilkelly
3ffef7fe56 Dynamically adjust the width of autocomplete popup. 2017-08-01 13:40:30 +01:00
Paulo Reis
7b85661035 Re-enable the toggle TC keyboard shortcut. 2017-08-01 11:59:32 +01:00
Paulo Reis
029ab8d2f1 Make sure TC state is applied to all users on load. 2017-08-01 11:30:23 +01:00
Paulo Reis
fbce49f5cd Merge branch 'master' into ja-per-user-track-changes 2017-08-01 10:56:02 +01:00
Shane Kilkelly
9a85e42ddb Remove stray file 2017-08-01 09:53:43 +01:00
Shane Kilkelly
f057f788e3 Autocomplete for graphics 2017-07-31 14:51:22 +01:00
Shane Kilkelly
eeabac7698 Get graphics paths from preamble 2017-07-31 11:28:52 +01:00
Shane Kilkelly
a841646559 Add preamble parser 2017-07-31 11:28:21 +01:00
Shane Kilkelly
eaf9ae5b94 Begin work on autocomplete for includegraphics 2017-07-31 09:34:58 +01:00
Paulo Reis
b44d0bfb85 Ignore deleted projects when determining the number of uncategorized projects. 2017-07-28 14:41:33 +01:00
Shane Kilkelly
0f131d940d Enforce stricter password policy. 
- Check minimum password lengths
- Set default policy to 6-128 chars
 2017-07-24 11:06:47 +01:00
Shane Kilkelly
70e5279ba2 Don't autocomplete for commands like \\, \[, \:, etc 2017-07-14 13:52:18 +01:00
Shane Kilkelly
f66982dd8b Consistently delete back to last backslash 2017-07-13 10:23:45 +01:00
Shane Kilkelly
75b0e0cf51 Don't offer autocomplete for double-backslash 2017-07-13 10:22:51 +01:00
Shane Kilkelly
952a765235 Inteligently rank exact match highest 2017-07-12 11:33:45 +01:00
Shane Kilkelly
c8a21cdcf5 WIP: sort definite real commands from possible incidentals 2017-07-12 09:25:39 +01:00
Shane Kilkelly
1fb036811a Temporarily remove up-ranking of exact match 2017-07-11 11:34:31 +01:00
Paulo Reis
a2e583edb8 Remove debug statement. 2017-07-07 10:38:13 +01:00
Paulo Reis
6cfa10d511 Add a per-user TC notice dialog. 2017-07-07 10:38:13 +01:00
Paulo Reis
8925dc5a78 Revert "Show simpler UI when there is only one user." 
This reverts commit 48300bd5b2ef01651e64dad3183e65d5d5798955.
 2017-07-07 10:38:13 +01:00
Paulo Reis
dae5381af7 Show simpler UI when there is only one user. 2017-07-07 10:38:13 +01:00
Paulo Reis
139c2ab1fd Consolidate members list. 2017-07-07 10:38:13 +01:00
Paulo Reis
e421b6550a Filter out read-only users from TC users list. 2017-07-07 10:38:13 +01:00
Paulo Reis
71e0a6935f Readd feature flag handling. 2017-07-07 10:38:13 +01:00
Paulo Reis
e40b8500d7 Keep user state persistent on the client. 2017-07-07 10:38:13 +01:00
Paulo Reis
c701711eab Support a default value when undefined in the review panel toggles. 2017-07-07 10:38:13 +01:00
Paulo Reis
8e6265e3d2 Enable global setting. 2017-07-07 10:38:13 +01:00
Paulo Reis
1ae53a243a Correctly fetch users from project info. 2017-07-07 10:38:13 +01:00
Paulo Reis
f4bdd5eb2b Control sync state with server. 2017-07-07 10:38:13 +01:00
Paulo Reis
1fa7338baf Wire up TC widget to controller methods. 2017-07-07 10:38:13 +01:00
Paulo Reis
dc2085c6e1 Basic widget for toggling TC state. 2017-07-07 10:38:13 +01:00
James Allen
710c89a629 Support per user track changes (proof of concept) 2017-07-07 10:38:13 +01:00
Shane Kilkelly
04c94760f5 Merge branch 'sk-auto-pair-braces' into sk-ac-improvements-integration 2017-07-06 14:39:28 +01:00
Shane Kilkelly
330e3dccc3 Merge branch 'sk-ac-rank-exact-match-highest' into sk-ac-improvements-integration 2017-07-06 14:39:08 +01:00
Shane Kilkelly
611f8825d7 Merge branch 'sk-ac-prevent-double-insertion' into sk-ac-improvements-integration 2017-07-06 14:39:00 +01:00
Shane Kilkelly
9ac15c9d47 Merge branch 'sk-ac-more-eager-trigger' into sk-ac-improvements-integration 2017-07-06 14:38:44 +01:00
Shane Kilkelly
98f96d6087 Merge branch 'sk-ac-disable-for-existing-environments' into sk-ac-improvements-integration 2017-07-06 14:38:07 +01:00
Shane Kilkelly
c99109751e Merge branch 'sk-ac-ignore-comments' into sk-ac-improvements-integration 2017-07-06 14:37:54 +01:00
James Allen
01d709dff5 Remove latex beta mode 2017-07-06 11:59:44 +01:00
Shane Kilkelly
34b2012727 Enable (optional) auto-pairing for latex mode 2017-07-06 11:06:51 +01:00
Shane Kilkelly
68c942582f Clean up the custom insertMatch function 2017-07-04 08:48:45 +01:00
Shane Kilkelly
08faa64b57 Add comment explaining the custom insertMatch 2017-07-03 15:20:36 +01:00
Shane Kilkelly
96d269e348 Use existential operator to check existence 2017-07-03 15:13:27 +01:00
Shane Kilkelly
415de9e2ec Experimental handling of completion for existing commands 2017-07-03 15:12:15 +01:00
Shane Kilkelly
127d5ded86 Remove erroneous log 2017-07-03 13:37:25 +01:00
Shane Kilkelly
7ecadb14f6 Add a skeleton of a custom insertMatch function 2017-07-03 13:36:24 +01:00
Paulo Reis
a9b104f674 Relocate qProvider setup. 2017-07-03 11:19:13 +01:00
Paulo Reis
55476f1693 Disable erroring behaviour for unhandled rejections. 2017-07-03 10:42:39 +01:00
Paulo Reis
86e66bbed1 Merge branch 'master' into pr-angular-1.6.x 2017-07-03 09:50:01 +01:00
Shane Kilkelly
bb3c5e7a34 Reverse direction, don't ignore commands in comments 2017-06-30 15:05:21 +01:00
Shane Kilkelly
bd88adb621 Account for mid-line comments 2017-06-30 14:03:34 +01:00
Shane Kilkelly
da286438be Don't trigger autocomplete when editing existing environment 2017-06-30 11:22:11 +01:00
Shane Kilkelly
c2fcbbeb72 Fix parsing, so it accurately captures command args 2017-06-30 10:55:10 +01:00
Shane Kilkelly
e2bff06aeb Add comment about ignoring comments 2017-06-30 08:42:03 +01:00
Shane Kilkelly
cfe51089f6 Ignore commands within comments when parsing document 2017-06-29 16:04:52 +01:00
Shane Kilkelly
db80f8ca1c Don't trigger autocomplete if we're on a comment line. 2017-06-29 14:42:08 +01:00
Shane Kilkelly
c9cda16a5e Refactor score calculation 2017-06-29 11:13:59 +01:00
Paulo Reis
699ec419aa Fix bug where announcements were undefined. 2017-06-29 11:04:52 +01:00
Shane Kilkelly
936278b045 Bring score into line with new policy 2017-06-29 10:55:05 +01:00
Shane Kilkelly
cbae1857e7 Allow exact match to be ranked higher than any other result 2017-06-29 10:54:07 +01:00
Shane Kilkelly
3deebc8642 Change the scoring system for autocomplete, scale 0-100 2017-06-29 10:53:52 +01:00
Shane Kilkelly
1490b4a0da Remove Shift-Space autocomplete trigger, far to easy to misfire 2017-06-29 10:02:49 +01:00
Shane Kilkelly
69796bd835 also trigger autocomplete if last character is backslash 2017-06-28 15:48:21 +01:00
Shane Kilkelly
c9678ad699 Trigger autocomplete with Shift-Space, in addition to existing triggers 2017-06-28 15:24:37 +01:00
Paulo Reis
9ffec6eb16 Correctly access response parameters. 2017-06-26 10:00:47 +01:00
Paulo Reis
33be384206 Avoid implicitly returning from a directive controller constructor function. 2017-06-21 16:00:56 +01:00
Paulo Reis
ddee75e479 Use a getterSetter to manage int values in settings. 2017-06-20 17:08:53 +01:00
Paulo Reis
669c705d32 Also refactor signatures from methods wrapping the HTTP service. 2017-06-20 16:27:05 +01:00
Paulo Reis
3dda383d70 Use promise method signatures, instead of old HTTP service ones. 2017-06-20 16:04:06 +01:00
Paulo Jorge Reis
2dda430691 Merge pull request #522 from sharelatex/bg-hide-textlayer-for-performance 
set text layer to display:none for faster scroll
 2017-06-20 13:58:20 +01:00
Shane Kilkelly
8b7a1bd4d9 Merge branch 'sk-labels-ac-debounce' 2017-06-20 13:53:23 +01:00
Paulo Reis
155f515a50 Use standard promises with the http service. 2017-06-20 11:50:23 +01:00
Shane Kilkelly
3d2d7652c6 Simplified and faster blanking 2017-06-20 08:46:47 +01:00
Shane Kilkelly
b4e2dcf7ef Match prefixes of ref and cite up to 16 characters 2017-06-20 08:46:28 +01:00
Shane Kilkelly
a299af12e8 Remove debug helper 2017-06-20 08:46:18 +01:00
Shane Kilkelly
85ddff15cb Move command-matching regex to the class level 2017-06-16 10:20:55 +01:00
Shane Kilkelly
0163ffc4bd Extend, and clean up the command-matching regex 2017-06-16 10:17:30 +01:00
Shane Kilkelly
1d905bd5ff Clean up string replacement 2017-06-16 09:49:16 +01:00
Shane Kilkelly
d9aff3c3f4 Blacklist more commands 2017-06-16 09:41:40 +01:00
Shane Kilkelly
a1d2d5b313 WIP: blank out label commands before running spell-check 2017-06-16 09:20:35 +01:00
Paulo Reis
af2cbf5a51 Force return true on a jquery handler; returning falsy values may have unexpected results. 2017-06-15 16:17:21 +01:00
Paulo Reis
fcf0a96933 Use selection.isCollapsed to check for empty selections. 2017-06-15 16:16:30 +01:00
Brian Gough
503822deb0 avoid possible exception if selection is undefined 
defensive programming only
 2017-06-15 14:32:00 +01:00
Brian Gough
b9804823f3 handle off-screen selection 
when toggling the logs button the selection is off-screen and
selection.toString() is empty even when there is a selected range.  Can
check for selection.type being "Range" instead.
 2017-06-15 14:21:42 +01:00
Brian Gough
b04288ed44 avoid getting duplicate handlers for mouseup 2017-06-15 14:21:42 +01:00
Shane Kilkelly
403d822174 Alter labels debouncer to handle transitions between docs 2017-06-15 14:09:49 +01:00
Brian Gough
76dcde4dae hide the text layer on reload 2017-06-15 13:42:19 +01:00
Paulo Reis
fbaa918927 Do not show the text layer when the user clicks outside pages. Remove some debug statements. 2017-06-15 12:32:04 +01:00
Paulo Reis
4985f7ca1c Different approach: render all text layers while selecting (WIP). 2017-06-15 12:32:04 +01:00
Paulo Reis
786659dc1b Render text layer on hovered pages (and adjacent ones). 2017-06-15 12:32:04 +01:00
Shane Kilkelly
69471c4f74 Remove old references to services/labels 2017-06-15 09:27:00 +01:00
Shane Kilkelly
b0bb4b3e47 Merge branch 'sk-ref-variants' 2017-06-15 09:17:48 +01:00
Shane Kilkelly
9607174b64 Merge branch 'master' into sk-server-side-labels-loading 2017-06-15 08:49:14 +01:00
Shane Kilkelly
3f1a440d66 Support variations of \ref{}, such as \cref{}, \eqref{}, etc.. 2017-06-14 15:15:07 +01:00
Shane Kilkelly
b0ff8e0745 Fix a typo: prefxi => prefix 2017-06-14 15:14:38 +01:00
Shane Kilkelly
5e37b1dac1 Move logic for selectively loading labels. 
Only load labels if the user has write permission
 2017-06-14 13:26:02 +01:00
Brian Gough
e1efc3a7b5 Merge pull request #521 from sharelatex/bg-reduce-pdf-memory-usage 
Revert "use a single pdfjs worker, rotated to avoid leaks"
 2017-06-13 16:46:58 +01:00
Shane Kilkelly
3b066758bb Don't load labels for anonymous/read-only users 2017-06-13 14:06:00 +01:00
Shane Kilkelly
954c53aec6 Move the labels event logic into ide/labels/LabelsManager 2017-06-13 13:29:03 +01:00
Shane Kilkelly
a04eb1197d Move labels service to /ide/labels/services/labels 2017-06-13 11:43:25 +01:00
Shane Kilkelly
b97becc7a2 Change getLabelsForDoc to broadcastLabelsForDoc 2017-06-13 11:38:15 +01:00
Shane Kilkelly
c25b6b792d Namespace the document route under /doc/ 2017-06-13 10:57:51 +01:00
Shane Kilkelly
d1a85304d2 Add comment 2017-06-12 15:47:31 +01:00
Shane Kilkelly
debb0c06a4 Clearer logic for triggering labels-loading 2017-06-12 14:23:29 +01:00
Shane Kilkelly
ff4991284d Change docLabelsUpdated socket event to broadcastDocLabels 2017-06-12 13:06:56 +01:00
Shane Kilkelly
234a2d0e21 Remove cruft 2017-06-12 11:37:34 +01:00
Shane Kilkelly
1bb065344c Move labels into an Angular Service 2017-06-12 09:44:32 +01:00
Shane Kilkelly
56385a798b Use ide.$http, rather than jquery 2017-06-09 11:41:35 +01:00
James Allen
7137ab643f Merge pull request #523 from sharelatex/ja-removing-group-holding-accounts 
Use an email based invite system for groups, not holding accounts
 2017-06-09 11:36:42 +01:00
Shane Kilkelly
5443b92e7d Move state management into LabelsMaster on the ide 2017-06-09 11:28:27 +01:00
James Allen
ba3822d1ae Encode email for URL when deleting invited group email 2017-06-09 10:39:48 +01:00
James Allen
69bc6fc8e4 Maintain backwards compatibility with old holding accounts in removal end points 2017-06-08 16:53:22 +01:00
Shane Kilkelly
965a46291b Only fetch labels for uploaded docs, not files 2017-06-08 15:55:17 +01:00
Shane Kilkelly
ff7955dfdb Update labels when docs are uploaded or removed 2017-06-08 15:12:18 +01:00
James Allen
4cecbae6b6 Use an email based invite system for groups, not holding accounts 2017-06-08 12:12:08 +01:00
Shane Kilkelly
c7dbd21cd1 use flag on aceEditor to enable autocomplete features 2017-06-08 09:22:08 +01:00
Paulo Reis
240d6d6f6b Resolve timing issue when triggering selection-related logic. 2017-06-07 14:21:05 +01:00
Paulo Reis
53b18e041f Trigger selection-related logic after accepting or rejecting changes. 2017-06-07 14:03:58 +01:00
Brian Gough
aa8974dcd6 Revert "use a single pdfjs worker, rotated to avoid leaks" 
This reverts commit f270ef54911acd800d2ffd577080b50ea2fe4aff.

Use a new worker on each reload to free up memory.
 2017-06-07 13:29:10 +01:00
Paulo Reis
19ecffd654 Merge branch 'master' into pr-aggregate-insert-delete 2017-06-06 17:04:31 +01:00
Paulo Reis
34796b18c5 Add translation keys. 2017-06-06 16:46:36 +01:00
Paulo Reis
afa011c813 Avoid flickering when elements enter the review panel. 2017-06-06 16:11:00 +01:00
Paulo Reis
73a67c6617 Add a note on the need of reverse sorting changes when rejecting. 2017-06-06 13:34:48 +01:00
Paulo Reis
4504f77aa3 Do bulk rejects in reverse order. 2017-06-06 12:06:43 +01:00
Paulo Reis
81a5a5311d Clear selection after bulk actions. 2017-06-06 10:03:33 +01:00
Paulo Reis
5a75663a0c Do bulk rejects in reverse order. 2017-06-05 17:17:47 +01:00
Paulo Reis
e616a62d68 Save entry ids inside entry object, not only as the key. 2017-06-05 16:29:55 +01:00
Shane Kilkelly
f7ad4a4786 WIP: basically working, with client sync 2017-06-05 14:48:50 +01:00
James Allen
cb1745a1e6 Fix redirect in clone project modal 2017-06-05 13:33:32 +01:00
James Allen
d7981fd2d4 Merge pull request #512 from sharelatex/ja-project-name-validation 
Refactor project name validation into one place and restrict /s
 2017-06-05 11:55:39 +01:00
Shane Kilkelly
51881dbbcc Only load labels from current doc if change is local 2017-06-05 11:09:58 +01:00
Paulo Reis
6c3cdbcc3a Remove dead code, backend does not send single change events anymore. 2017-06-05 10:43:03 +01:00
Paulo Reis
8d8bcab1e8 Consolidate change accept and reject code. 2017-06-05 10:41:59 +01:00
Shane Kilkelly
4cb41a988a WIP: initial work on server-side labels 2017-06-02 15:12:59 +01:00
Paulo Reis
e2edf4184f Explicit naming. 2017-06-02 11:43:43 +01:00
Shane Kilkelly
51e3a6b3a3 Don't use String.startsWith, use slice instead. 
- String.startsWith is not supported in IE
 2017-06-02 09:54:48 +01:00
Paulo Reis
26260fc11f Prevent aggregation of changes from different users. 2017-06-01 16:33:50 +01:00
Paulo Reis
b2a7686204 DRYness. 2017-06-01 15:28:37 +01:00
Paulo Reis
2a0454f2f1 Integrate aggregate changes with bulk actions. 2017-06-01 15:18:43 +01:00
Paulo Reis
1490ea7b04 Change aggregated change model: the main change is now the insertion, deletion is stored in metadata. 2017-06-01 15:03:37 +01:00
Paulo Reis
11c0644490 Aggregate changes; make accept and reject work. 2017-06-01 11:47:55 +01:00
Shane Kilkelly
9a15420c4e Merge branch 'master' into sk-labels-autocomplete 2017-06-01 08:34:56 +01:00
Paulo Reis
3cf8f26583 Add collapse and expand behaviour to aggregate change entries. 2017-05-31 16:23:24 +01:00
Paulo Reis
a6108480f5 Add directive to show change entries. 2017-05-31 14:47:25 +01:00
Shane Kilkelly
039d18bf8b Simplify logic for deciding whether to re-scan doc on not 2017-05-26 15:08:38 +01:00
Shane Kilkelly
faf0337ca9 Refactor labels autocomplete 2017-05-26 14:56:38 +01:00
Paulo Reis
7fbf6d97bd Merge branch 'master' into pr-hide-review-panel 2017-05-26 09:39:29 +01:00
Shane Kilkelly
7923450e25 Move labelsManager into aceEditor directory 2017-05-25 09:42:07 +01:00
Shane Kilkelly
0543f32ff0 Add comment explaining debounce 2017-05-25 09:35:38 +01:00
Shane Kilkelly
ea9a0dda83 More robust change detection for autocomplete. 
- accurately detect when labels are involved in 'remove' event
 2017-05-25 09:33:15 +01:00
Shane Kilkelly
1ba8b702ad More robust regex for matching/parsing labels. 
- limit label name to max 80 characters
- don't use `.*`
- limit total labels per document to 1000
 2017-05-25 09:32:10 +01:00
Shane Kilkelly
a363b62f23 Remove periodic polling of document for labels 2017-05-25 09:31:36 +01:00
Shane Kilkelly
d0bf407515 Use coffeescript => functions, rather than self=this. 2017-05-24 15:05:53 +01:00
Shane Kilkelly
efd01081f7 Set up and automatic refresh of labels 2017-05-24 14:28:27 +01:00
Shane Kilkelly
b871cdab4c Remove debug logs 2017-05-24 14:28:15 +01:00
Shane Kilkelly
1f3a375b4e Update commentary 2017-05-24 11:42:00 +01:00
Shane Kilkelly
da84b3f31c WIP: basically working labels/ref autocomplete 2017-05-24 11:40:12 +01:00
Shane Kilkelly
17dd64f48a Merge pull request #507 from sharelatex/sk-squash-web-errors 
Squash various web errors
 2017-05-24 10:57:18 +01:00
Shane Kilkelly
c43a2087d7 WIP: autocomplete for label/ref 2017-05-24 10:07:14 +01:00
Paulo Reis
8dfb91fa6f Blur toggler after clicking. 2017-05-22 11:11:26 +01:00
James Allen
ba62206b91 Refactor project name validation into one place and restrict /s 2017-05-19 17:42:24 +01:00
Paulo Reis
58ad62c413 Relayout entries when commenting. 2017-05-19 16:57:51 +01:00
Paulo Reis
75c5bf60a8 Make hotkeys modal larger. 2017-05-19 15:51:32 +01:00
Paulo Reis
15980d5427 Merge branch 'master' into pr-hide-review-panel 2017-05-19 15:31:14 +01:00
Paulo Reis
957b201fc1 Add commenting and track-changes keyboard shortcuts. 2017-05-19 15:28:49 +01:00
Paulo Reis
e532f543a3 Merge branch 'master' into pr-bulk-actions 2017-05-18 14:38:16 +01:00
Paulo Reis
832764dd3d Add key shortcut to toggle the review panel. 2017-05-18 11:02:50 +01:00
Paulo Reis
7f3c0ed5ac Refactor accept and reject methods to support multiple changes; support bulk actions events. 2017-05-16 14:27:06 +01:00
Paulo Reis
36b4a8e6c2 Update ranges tracker. 2017-05-16 14:04:13 +01:00
Paulo Reis
ac99422c26 Update ranges tracker. 2017-05-16 14:04:06 +01:00
Paulo Reis
a3c529d23f Update range tracker with new bulk method. 2017-05-16 14:03:52 +01:00
Shane Kilkelly
ada614cc69 Check response exists before calling method 2017-05-16 09:20:12 +01:00
Paulo Reis
f4e46bb2f9 Use new ranges tracker method to get N changes at once; small refactor. 2017-05-15 11:24:40 +01:00
Paulo Reis
7bb5d65b52 Update ranges tracker. 2017-05-15 11:11:28 +01:00
Paulo Reis
82a19444b3 Merge branch 'master' into pr-bulk-actions 2017-05-15 10:29:15 +01:00
Paulo Reis
dd85c2fab2 Remove debug line. 2017-05-12 15:44:49 +01:00
Paulo Reis
658e70a772 Update ranges tracker. 2017-05-11 11:32:12 +01:00
Paulo Reis
f2dac28a65 Consolidate some watchers. 2017-05-11 10:23:41 +01:00
Paulo Reis
a3ab994ab3 Use the same watcher to control miniRP visibility and trigger Ace resizing. 2017-05-11 10:17:25 +01:00
Paulo Reis
8aee0edfe8 Integrate bulk actions dialog with controller actions. 2017-05-09 16:06:34 +01:00
Paulo Reis
f3e020df7e Add dialog to confirm bulk actions. 2017-05-09 16:06:19 +01:00
Paulo Reis
499272cbb5 Use new range-tracker method. 2017-05-08 16:12:21 +01:00
Paulo Reis
03b8b72520 Update range tracker with new bulk method. 2017-05-08 16:10:08 +01:00
Paulo Reis
3ced808411 Use a single accept changes method. 2017-05-05 15:19:31 +01:00
Paulo Reis
f25db3ff64 Reflect accepted changes on the UI layer. 2017-05-04 15:47:25 +01:00
Paulo Reis
19828d3c5b Basic bulk accept support. 2017-05-04 15:33:47 +01:00
Paulo Reis
8f6d11632b Add bulk rejection support. 2017-05-03 17:16:41 +01:00
Paulo Reis
dae66d5edf Add bulk methods in controller. 2017-05-03 17:16:29 +01:00
Paulo Reis
05d9bf47d1 Use entry ids instead. 2017-05-03 16:53:04 +01:00
Paulo Reis
bf7bf701ed Store selected entries; improve visibility logic. 2017-05-03 16:35:58 +01:00
Paulo Reis
722d75f6ef Correctly check if deletions are within selection. 2017-05-02 17:08:41 +01:00
Paulo Reis
3f441ff38c Count entries within selection; only show bulk actions if there are selected entries. 2017-05-02 17:02:30 +01:00
Paulo Reis
e2eaf6619e Bulk actions directive; include it in the review panel. 2017-05-02 16:15:40 +01:00
Paulo Reis
76ea497b33 Use a single entry for bulk actions. 2017-05-02 15:43:45 +01:00
Paulo Reis
d874eb70f8 Add and remove bulk accept and reject entries with selections. 2017-05-02 15:34:05 +01:00
Paulo Reis
d71296da9f Add row clicking in the projects list. 2017-05-01 17:11:03 +01:00
Paulo Reis
208f021bd0 Actually remove project from tag, inline. 2017-05-01 16:00:25 +01:00
Paulo Reis
6e40284099 Add untagged projects counter. 2017-04-28 16:57:37 +01:00
Paulo Reis
84a2658259 Add an untagged filter in the projects list. 2017-04-28 12:11:51 +01:00
Paulo Reis
877cd8e018 Apply stored filtering options. 2017-04-27 16:18:16 +01:00
Paulo Reis
884a89893d Save and read filtering options from local storage. 2017-04-27 16:17:28 +01:00
Henry Oswald
f5267ac6ee Merge pull request #481 from sharelatex/ja-encode-project-names 
Error if no project returned from joinProject
 2017-04-25 09:17:59 +01:00
Henry Oswald
79bc4c1d3e = != == ;) 2017-04-24 16:16:02 +01:00
Henry Oswald
c733925a26 show rate limit message when compiled too much 2017-04-24 15:56:09 +01:00
James Allen
f6bd949f01 Error if no project returned from joinProject 
socket.io seems to choke on the unicode project name and just return
undefined when it fails to parse the JSON. I've improved the escaping
of the user data on HTML load, but reporting an error is the best we
can easily do on joinProject via websockets.
 2017-04-10 12:03:39 +01:00
James Allen
477278eea5 Merge pull request #476 from sharelatex/ja-use-new-comment-button 
Fix on the new comment button variation
 2017-04-05 11:08:59 +01:00
James Allen
ce59307c91 Merge pull request #475 from sharelatex/ja-scroll-overflow-in-review-panel 
Allow scrolling in the review panel to extend outside of top of text …
 2017-04-05 11:08:49 +01:00
Shane Kilkelly
0555154a24 Merge branch 'sk-fix-folder-creation' 2017-04-04 11:01:07 +01:00
Paulo Reis
7855afa0cd Remove unused scope binding. 2017-04-04 10:48:31 +01:00
Paulo Reis
15de552c2c Make new add comment button styles as the default; removed old add comment button code. 2017-04-04 10:40:53 +01:00
James Allen
567edbfb31 Fix on the new comment button variation 2017-04-03 17:11:33 +01:00
James Allen
2fa909c707 Allow scrolling in the review panel to extend outside of top of text like Ace 2017-04-03 16:46:36 +01:00
James Allen
efac6b70f4 Merge pull request #468 from sharelatex/ja-allow-overlapping-comments 
Allo overlapping comments
 2017-04-03 14:04:14 +01:00
James Allen
1675185f37 Merge pull request #474 from sharelatex/pr-project-name-tooltip 
Project name tooltip
 2017-04-03 14:04:02 +01:00
Paulo Reis
6b9b8480a8 Only show the tooltip if the project name is truncated. 2017-03-31 16:36:58 +01:00
Paulo Reis
855d37289b Use ISO strings instead of of date type in locally resolved comments. 2017-03-31 14:29:28 +01:00
Shane Kilkelly
15d0a40f85 When error occurs, unset state.inflight 2017-03-31 10:30:28 +01:00
Shane Kilkelly
49446afb82 Remove duplicate line 2017-03-31 10:30:10 +01:00
James Allen
4c8ce65ce7 Allo overlapping comments 2017-03-28 16:50:30 +01:00
Paulo Jorge Reis
67943a8906 Merge pull request #463 from sharelatex/pr-ab-test-add-comments 
PR AB test "add comment" button
 2017-03-27 09:32:49 +01:00
Paulo Reis
93934b9c8f Use deploy date. 2017-03-27 09:32:02 +01:00
Henry Oswald
aa4f768513 Merge pull request #455 from sharelatex/ho-bug-fix 
multiple small bug fixes
 2017-03-27 09:28:28 +01:00
Paulo Reis
c72ee95177 Refactor AB test participation code; add conversion code. 2017-03-23 15:00:43 +00:00
Paulo Reis
254e4953cb Wire-up AB test for adding comments. 2017-03-23 12:26:21 +00:00
James Allen
b22ef30876 Merge pull request #456 from sharelatex/ja-show-too-many-track-changes-error 
Show an explanation error message on too many track changes error
 2017-03-21 13:15:14 +00:00
James Allen
e705118dfe Merge pull request #457 from sharelatex/pr-new-add-comment-btn 
New "add comment" button
 2017-03-21 13:15:03 +00:00
Paulo Reis
a35f2585c7 Remove unused flag. 2017-03-20 14:02:25 +00:00
Paulo Reis
0e24d7118d Hide new UI behind query string parameter. 2017-03-20 13:56:36 +00:00
Paulo Reis
8951e91e31 Remove add comment button from the mini review panel. 2017-03-20 11:35:35 +00:00
Paulo Reis
2c2abc3cae Wire up new button with existing UI for adding comments. 2017-03-20 11:18:29 +00:00
Paulo Reis
beac43741c New add comment button. 2017-03-17 17:05:38 +00:00
Paulo Reis
c74449b2e3 Don't show the mini review panel when the only visible entry is the add comment one. 2017-03-17 16:28:21 +00:00
James Allen
3c2f5525a1 Show an explanation error message on too many track changes error 2017-03-17 14:49:32 +00:00
Henry Oswald
9a8ee112a5 null check path.split 
https://sentry.io/sharelatex-1/sl-web-client-prod/issues/202702369/
 2017-03-17 10:35:07 +00:00
James Allen
aa36768d8a Remove debugging line 2017-03-16 16:01:03 +00:00
James Allen
6c1a15a698 Move comments when cutting and pasting 2017-03-16 15:48:57 +00:00
James Allen
fb91219661 Don't submit comment on clicking cancel 2017-03-08 11:38:28 +00:00
James Allen
a6679a1aeb Stop local and remote ops being batched together in the undo manager if they happen in the same flush 2017-03-01 16:33:04 +00:00
James Allen
e1cf6229f7 Merge branch 'master' into ja-use-dirty-state 2017-03-01 10:03:00 +00:00
Paulo Reis
1646496f19 Patch overflow behaviour so that z-index is always higher by 1. 2017-02-24 14:38:46 +00:00
Paulo Reis
3bdbe7e538 Set synctex controls z-index to the minimum working value. 2017-02-24 14:36:08 +00:00
James Allen
dd0271e799 Only cancel deletes with inserts on undo and reject 2017-02-24 14:20:26 +01:00
James Allen
7418d12bf8 Defer updates of remote ops until Ace has been updated 2017-02-23 11:34:58 +01:00
James Allen
f4bbd8ea10 Use dirty state rather events to avoid O(N^2) behaviour 2017-02-23 11:27:19 +01:00
Paulo Reis
96c44eec38 Support values other than objects in the numKeys filter, returning zero if so. 2017-02-21 14:48:21 +00:00
Paulo Reis
7f6941677d Check local storage on load; use explicit condition syntax. 2017-02-21 14:43:05 +00:00
Paulo Reis
2e8f917318 Support initial closed state. 2017-02-21 14:27:57 +00:00
Paulo Reis
5c7fc66964 Merge branch 'pr-collapse-overview-entries' of github.com:sharelatex/web-sharelatex into pr-collapse-overview-entries 2017-02-21 14:21:10 +00:00
Paulo Reis
33c8bc8684 Support saving state to local storage. 2017-02-21 14:20:51 +00:00
James Allen
00fce4d2da Merge branch 'master' into pr-collapse-overview-entries 2017-02-21 14:25:45 +01:00
James Allen
f1baa1b8ad Merge pull request #432 from sharelatex/ja-hide-offscreen-review-panel-entries 
Only render the entries that are visible in the text
 2017-02-21 10:28:45 +01:00
James Allen
f466be96dd Make sure first change isn't hidden under toolbar 2017-02-21 09:58:49 +01:00
James Allen
3af7cdf0a9 Merge branch 'ja-scroll-review-panel-past-ace' into ja-hide-offscreen-review-panel-entries 2017-02-20 16:24:26 +01:00
James Allen
6c21d19894 Increase offscreen lines considered for visibility 2017-02-20 16:24:19 +01:00
James Allen
ad05cc288c Do DOM reads first to prevent thrashing 2017-02-20 16:22:18 +01:00
James Allen
8c5800ceaf Only render the entries that are visible in the text 2017-02-20 16:03:02 +01:00
James Allen
b52e4a5d1c Reset scroll margins when changing document 2017-02-20 15:46:53 +01:00
James Allen
995fa6122b Scroll the review panel past the limits of Ace 2017-02-20 12:56:26 +01:00
Paulo Reis
1e66c46ca7 Add filter to retrieve number of keys in objects. 2017-02-17 14:31:50 +00:00
Paulo Reis
cd2c8e7199 Add directive based on jQuery animation API. 2017-02-17 11:54:33 +00:00
Paulo Reis
0841ab8278 Add directive to collapse elements via height. 2017-02-17 11:24:21 +00:00
James Allen
31ae2e7124 Update RangesTracker 2017-02-17 09:24:25 +01:00
James Allen
c8a6555cb1 Update RangesTracker 2017-02-16 17:07:56 +01:00
James Allen
04b9f8d249 Merge branch 'master' into ja-track-changes 2017-02-16 17:07:12 +01:00
Paulo Reis
a639f13cb6 Bootstrap collapsing behavior in files list. Store state. 2017-02-16 15:48:58 +00:00
Henry Oswald
bb7ededaaf announcementClicked -> logAnnouncementClick 2017-02-15 12:43:13 +00:00
Henry Oswald
8cd3d21792 track read more clicks in announcements 2017-02-15 12:17:10 +00:00
James Allen
d01d6a35cf Only create Controller when showing onboarding 2017-02-15 09:47:37 +01:00
James Allen
bdee15128b Remove click handler on dismiss 2017-02-14 22:31:49 +01:00
Paulo Reis
badc4ecb7a Show add comment tooltip to the left when appropriate. 2017-02-14 14:40:21 +00:00
James Allen
4dbc2c3066 Merge pull request #418 from sharelatex/pr-review-panel-onboarding 
Pr review panel onboarding
 2017-02-14 15:00:39 +01:00
James Allen
b48f57c2cb Submit comment on blur or selection change 2017-02-14 13:41:04 +01:00
Paulo Reis
594f2024d1 Style the onboarding prompt as a modal; close it when clicked outside. 2017-02-14 12:09:05 +00:00
Paulo Reis
1eed10b4e7 Add keyboard navigation 2017-02-14 10:21:45 +00:00
James Allen
c08c8e09ff Only show onboarding for users with track changes enabled 2017-02-14 11:09:37 +01:00
James Allen
03ecf4b4ae Only show track changes onboarding once based on analytics API events 2017-02-14 10:25:46 +01:00
James Allen
61ef158f76 Don't show review panel if user doesn't have track changes 2017-02-14 09:38:58 +01:00
James Allen
c8baae84da Merge branch 'pr-review-panel-onboarding' of github.com:sharelatex/web-sharelatex into pr-review-panel-onboarding 2017-02-13 16:51:16 +01:00
Paulo Reis
7dd9a3fa44 Add a dismiss button. 2017-02-13 15:49:58 +00:00
James Allen
6a4f0ace3b Merge branch 'master' into pr-review-panel-onboarding 2017-02-13 16:19:56 +01:00
James Allen
bf5f5f832d Use correct flag for determining mini panel visibility 2017-02-13 14:39:43 +01:00
James Allen
f840a20f5c Merge pull request #417 from sharelatex/pr-track-changes-upgrade-prompt 
Turn on track changes for beta users with upgrade prompt
 2017-02-13 12:44:04 +01:00
James Allen
3334078fe6 Merge pull request #415 from sharelatex/ja-track-changes 
Don't animate review panel entries on toggle and resize
 2017-02-13 12:17:45 +01:00
James Allen
e99c9a2065 Enable track changes for beta users 2017-02-13 12:09:47 +01:00
James Allen
47a66eed50 Merge branch 'ja-include-track-changes-feature' into pr-track-changes-upgrade-prompt 2017-02-13 11:50:56 +01:00
James Allen
85c2910738 Don't animate review panel entries on toggle and resize 2017-02-13 09:49:51 +01:00
Paulo Reis
1263532271 Add a directive to control the playback state of media elements. 2017-02-09 15:44:15 +00:00
Paulo Reis
1ef5cc97fc Rename stuff to refer to the new onboarding feature. 2017-02-08 17:19:13 +00:00
James Allen
51b76d2cf9 Merge pull request #413 from sharelatex/ja-abort-in-progress-spell-checks 
Abort any inprogress spell checks when switching document
 2017-02-08 11:38:05 +01:00
James Allen
87aea41bed Abort any inprogress spell checks when switching document 2017-02-08 11:32:19 +01:00
James Allen
d44a0ece97 Merge pull request #411 from sharelatex/ja-fix-cursor-on-resize 
Ja fix cursor on resize
 2017-02-08 11:30:37 +01:00
James Allen
123300cdfb Clear highlighted word manager on session change 2017-02-08 11:08:26 +01:00
James Allen
f6743b839f Reflow review panel as editor pane changes size 2017-02-07 16:45:45 +01:00
Paulo Reis
d792230bf0 Basic onboarding tutorial for track-changes. 2017-02-07 15:07:26 +00:00
James Allen
11a104ef96 Move spelling marker to back marker layer where it is updated properly by Ace 2017-02-07 15:55:00 +01:00
James Allen
c1a2779d9e Merge branch 'master' into ja-fix-cursor-on-resize 2017-02-07 15:27:01 +01:00