github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-14 13:23:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Replace separate autocompile ctrl with listener in PdfController

Browse source
This commit is contained in:
Alasdair Smith 2017-09-04 11:41:52 +01:00
parent 53bb4fdde0
commit 9f1adfd0c0
4 changed files with 6 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
services/web/app/views/project/editor/pdf.pug
View file

@ -1,5 +1,4 @@
div.full-size.pdf(ng-controller="PdfController")
.FIXME(ng-controller="AutoCompileController")
.toolbar.toolbar-tall
.btn-group(
dropdown,

3
services/web/public/coffee/ide/pdf/PdfManager.coffee
View file

@ -1,8 +1,7 @@
define [
"ide/pdf/controllers/PdfController"
"ide/pdf/controllers/PdfViewToggleController"
"ide/pdfng/directives/pdfJs",
"ide/pdf/controllers/AutoCompileController"
"ide/pdfng/directives/pdfJs"
], () ->
class PdfManager
constructor: (@ide, @$scope) ->

9
services/web/public/coffee/ide/pdf/controllers/AutoCompileController.coffee
View file

@ -1,9 +0,0 @@
define [
"base"
], (App) ->
App.controller "AutoCompileController", ["$scope", "ide", ($scope, ide) ->
ide.$scope.$on "ide:opAcknowledged", _.debounce(() ->
if (!ide.$scope.hasLintingError)
$scope.recompile()
, 3000)
]

5
services/web/public/coffee/ide/pdf/controllers/PdfController.coffee
View file

@ -73,6 +73,11 @@ define [
$scope.pdf.view = 'errors'
$scope.pdf.renderingError = true
ide.$scope.$on "ide:opAcknowledged", _.debounce(() ->
if (!ide.$scope.hasLintingError)
$scope.recompile()
, 3000)
# abort compile if syntax checks fail
$scope.stop_on_validation_error = localStorage("stop_on_validation_error:#{$scope.project_id}")
$scope.stop_on_validation_error ?= true # turn on for all users by default