Commit graph

21893 commits

Author SHA1 Message Date
Jakob Ackermann
880087945e Merge pull request #16854 from overleaf/jpa-overleaf-integration-core-tests
[web] enable overleaf-integration module when running SaaS tests

GitOrigin-RevId: 36eda6ef448604a55f8dc8daac5ce29af23b6b0b
2024-02-05 09:04:05 +00:00
ilkin-overleaf
640ea9c916 Merge pull request #16806 from overleaf/ii-compile-dir-readonly
[clsi] Use readOnly bind-mounts for synctex and wordcount containers

GitOrigin-RevId: 8de094350604544dba4571aa849ad41a4a4d88d8
2024-02-05 09:03:58 +00:00
Alexandre Bourdin
3437b2c678 Merge pull request #16824 from overleaf/jel-clear-sso
[web] Clear group SSO via Overleaf admin "Clear all SAML data" button

GitOrigin-RevId: e5db107da533679d51d4f05db4e65c3ab51ed1ad
2024-02-05 09:03:53 +00:00
Alexandre Bourdin
2765991fec Merge pull request #16802 from overleaf/ab-show-certificate-status
[web] Show group SSO certificate status in config

GitOrigin-RevId: e0ffe3fad99ef70a752bdd2ca7be1d7d9bcba73c
2024-02-05 09:03:49 +00:00
Jessica Lawshe
596596efb1 Merge pull request #16860 from overleaf/jel-sso-acceptance-tests
[web] Add group SSO helpers for acceptance tests

GitOrigin-RevId: f2cec120582cecb474e705b451d06e9beced7bc9
2024-02-02 09:03:54 +00:00
Jessica Lawshe
3748621bcd Merge pull request #16791 from overleaf/jel-saml-audience
[web] Handle the SAML error of a SP entity ID mismatch in the response

GitOrigin-RevId: d8168d4ce77f4e810df193dae98046da07e6c0ae
2024-02-02 09:03:51 +00:00
Thomas
59d4f0e5a2 Add path attribute to cookie banner cookie attributes (#16783)
GitOrigin-RevId: 4e576bed42bdc053d867fd0a20336166df1de74e
2024-02-02 09:03:43 +00:00
Davinder Singh
341e1433de Website redesign - Space fixing of text with BG (#16846)
* adding space fix

* adding | instead of spaces

GitOrigin-RevId: d80f105c4a6de18d188678b7d3d3a08b8674efa8
2024-02-02 09:03:40 +00:00
Jakob Ackermann
82cde31619 Merge pull request #16808 from overleaf/jpa-wsUrl
[web] move wsUrl into meta tag

GitOrigin-RevId: c94638759b79b8090b8b3cfa81baa718a69839e1
2024-02-02 09:03:35 +00:00
Mathias Jakobsen
63ff16843c [overleaf-editor-core] Introduce ScanOp and subclasses (#16695)
* [overleaf-editor-core] Introduce ScanOp and subclasses

* [overleaf-editor-core] Remove unused methods

* [overleaf-editor-core] Add tests for ScanOps

* [overleaf-editor-core] Simplify merge

* [overleaf-editor-core] Make ApplyContexts mutable

* [overleaf-editor-core] Remove unnecessary containsNonBmpChars check

* [overleaf-editor-core] Revert to using reduce

* [overleaf-editor-core] Modify inputCursor after using it

* [overleaf-editor-core] Rename DeleteOp to RemoveOp

* [overleaf-editor-core] Remove useless constructor

* [overleaf-editor-core] Mutate in mergeWith

* [overleaf-editor-core] Add check for out-of-bounds retain

* [overleaf-editor-core] Move error import

GitOrigin-RevId: d07bd58177579638551257d56f087e8967e5b52f
2024-02-02 09:03:32 +00:00
Domagoj Kriskovic
b87dad77d9 Added applyInsert/applyDelete methods to comments (#16572)
* Add CommentList to StringFileData

* added more types

* use toRaw

* using Map rather than array for comments

* using Range class

* Comment with ranges:Range[]

* Revert "Comment with ranges:Range[]"

This reverts commit 0783b1837562600637db03cc70c620129061c797.

* Comment with ranges:Range[]

* remove isDeleted

* commentList.toRaw()

* using toRaw

* commentId to id

* Revert "using toRaw"

This reverts commit 0c04ca5836f3befd5ec027bad5bf722e8b27f36c.

* fix merge

* make comment map internal to CommentList

* remove unused type

* fix parameter name in StringFileData

* import types more consistently

* more consistent type def

* Added moveOnInsert/moveOnDelete methods to comments

* use range helper methods

* mergeRanges function

* rename isAfter to startsAfter

* added @ts-checks

* using comment.isEmpty

* rename overlaps to covers

* remove ops in applyDelete

* mege, substract, isInRange

* ranges fixes, added tests

* rename to includes

* using pos,length in applyInsert

* simplify

* extendComment option

* check comment edges

* added inclusive option

* more specific touches()

* refactor mergeRanges()

* comment.addRange()

* remove inclusive option

* refactor using more helper methods

* fix typo

* inserting a comment between ranges tests

* test description fixes

* support only range

* more edge case testing

* added more range tests

* renamed to containsExcludingEdges

* endsAt check edge

* using firstIndex, lastIndex

* contains, containsIndex

* raturn -1 for lastIndex for empty ranges

* rename ranges in tests

* indexStartsAfter

* sort comment ranges

* rename to indexIsAfter, fix Range type

* add range if expandComment is true

* split the range when expandComment is false

* added moveBy and extendBy

* added more tests

* added comments

* prettier

* small fixes/typos

* rename indexIsAfter

* merge when deleting with overlaps

* added overlap test

* same range touches test

* test with overlapping comments

* delete duplicate test

* throw on empty range

GitOrigin-RevId: 1252e3d01f2f5dc1d00ce681c579506038e4d121
2024-02-02 09:03:28 +00:00
Alf Eaton
cac1ab1259 Add tags to Sentry error reports (#16465)
GitOrigin-RevId: 1d014e8cc9f87d249a285b247c35f12465ecb93a
2024-02-02 09:03:23 +00:00
Alf Eaton
614d1d05cc Maintain the current scroll position when applying remote changes (#16777)
GitOrigin-RevId: 5d2d0fd5aaefcc6b1e7f4dbd2ce29287cf8dbbdb
2024-02-02 09:03:20 +00:00
Alf Eaton
efe44f08b8 Only log unknown file upload errors (#16739)
GitOrigin-RevId: a6129e622ce32ea227f575b6d93616a7411391ed
2024-02-02 09:03:17 +00:00
Alf Eaton
6976e02a38 Store the current value of openDocId in a ref for use in openDoc (#16853)
GitOrigin-RevId: 853a857eed832fde0be05fef3e149c875fd0c940
2024-02-02 09:03:14 +00:00
Alf Eaton
373c4736e8 Wrap the useCodeMirrorMeasurement state setter in a timeout (#16818)
GitOrigin-RevId: 9f7c12f679ab3947724cc52c63fcee198c73ae87
2024-02-02 09:03:11 +00:00
Alf Eaton
c443322a41 Memoize FileTree and outline toggle button components (#16776)
GitOrigin-RevId: 299ed9d568650ce37edba87643112d1cd6d12fd4
2024-02-02 09:03:08 +00:00
Alf Eaton
f06f2ef99e Set EditorState.readOnly on DocumentDiffViewer (#16756)
GitOrigin-RevId: 4c38441c3ca3010bf28544e237a5b76f7a26b000
2024-02-02 09:03:05 +00:00
Eric Mc Sween
d0a9f8c2cb Merge pull request #15748 from overleaf/em-drop-docops-collection
Drop the docOps collection

GitOrigin-RevId: 8ffa0570ae58b6a00412d8953d3ea0fbb1869b69
2024-02-01 09:03:46 +00:00
Christopher Hoskin
af32433bfa Merge pull request #16845 from overleaf/csh-docker-compose
Replace legacy `docker-compose` with `docker compose`

GitOrigin-RevId: 1a876a5870be55dceecdff9cd1284235840e908f
2024-02-01 09:03:43 +00:00
Thomas
2a7e06ea07 Merge pull request #16839 from overleaf/tm-website-redesign-suppress-alternate
Suppress rel=alternate hreflang links on website redesign variant pages

GitOrigin-RevId: ff53adbaf9aadd261427157a8b60bafe55d6ce36
2024-02-01 09:03:37 +00:00
Jakob Ackermann
783008b05f Merge pull request #16804 from overleaf/jpa-code-cleanup
[misc] ShareLaTeX code cleanup - low impact

GitOrigin-RevId: 4b4a958af133efdb81196967adb66c97420c4861
2024-02-01 09:03:34 +00:00
Brian Gough
f9db088d57 Merge pull request #16835 from overleaf/bg-google-spam-temporarily-disable-emails
Temporarily disable onboarding emails

GitOrigin-RevId: a1967bc793fcd7b3b90f812fb8c9b9d83f704093
2024-02-01 09:03:30 +00:00
Brian Gough
9702b36c64 Merge pull request #16833 from overleaf/bg-google-spam-add-email-metrics
Include email type and rate-limit status in metrics

GitOrigin-RevId: eb5645e68d9ee3571d04b87b2c0fc09f9caa126a
2024-02-01 09:03:27 +00:00
Christopher Hoskin
f6a693c1f5 Merge pull request #16831 from overleaf/csh-issue-15655-fix-ce-build
Fix CE build by using overleaf image

GitOrigin-RevId: 302d7a69fa210548fd0845b2d55d80398c0c6001
2024-02-01 09:03:21 +00:00
CloudBuild
2c49c691c3 auto update translation
GitOrigin-RevId: 8bfacb662456a02519fb4a4e8e13e528ebe2fa2a
2024-01-31 09:04:32 +00:00
Christopher Hoskin
660c5abb3d Merge pull request #16823 from overleaf/csh-issue-15655-sp3
Update CE/SP builds

GitOrigin-RevId: b5a0c4842d17a7a869b6e2f4c364bafb825a4fe5
2024-01-31 09:04:27 +00:00
Miguel Serrano
26ee64fe62 Replace logger with console in frontend macro (#16816)
* Replace `logger` with `console` in frontend macro

logger import is causing problems cleaning node_modules/.cache after webpack builds.
Since macros are used at build time we can use console statements.

GitOrigin-RevId: 22bbbb34391334ec8f8ec256a3a8a72e5fe91588
2024-01-30 16:49:46 +00:00
M Fahru
93976a2748 Merge pull request #16805 from overleaf/tm-website-redesign-ios-video-tweaks
Website redesign - video autoplay tweaks primarily to fix playback on iOS

GitOrigin-RevId: ba2844b8af64627512470d0f27ec450ee2d86b09
2024-01-30 16:49:37 +00:00
Alf Eaton
7f9d105d8c Ensure FileTreeProvider stubbed props don't change in Cypress tests (#16758)
GitOrigin-RevId: 01c7fefdef8b28af0b52007209785b478e5d8600
2024-01-30 16:49:27 +00:00
Eric Mc Sween
8136036c33 Merge pull request #16644 from overleaf/em-promisify-update-manager
Promisify UpdateManager

GitOrigin-RevId: 2c3e21ee6ef2454f79695ca8623c3d38720ff6bf
2024-01-30 16:49:23 +00:00
Jakob Ackermann
14bb3d7114 Merge pull request #16800 from overleaf/jpa-fix-double-loaded
[web] fix detection of writefull extension

GitOrigin-RevId: 2bfad36ec14edf4d95acfcdfd8094f3769871d44
2024-01-30 16:49:14 +00:00
CloudBuild
d644180ce4 auto update translation
GitOrigin-RevId: 230d16e68562e353f61c7f4782a739364950b10a
2024-01-30 09:04:43 +00:00
M Fahru
f0247a3311 Merge pull request #15302 from overleaf/mf-fix-unlink-github-sync-behaviour
[web] Unlink github from collaborators when project owner unsubcribes and github feature was lost

GitOrigin-RevId: 81b81cfb75e3a3684e185ef13d8c0aca19d5699d
2024-01-30 09:04:39 +00:00
Jessica Lawshe
00d66a1b81 Merge pull request #16713 from overleaf/jel-sso-already-linked
[web] When user is already linked to Group SSO

GitOrigin-RevId: 7cee60370c7329a0ed8fd621600d30546f1c8942
2024-01-30 09:04:28 +00:00
Jessica Lawshe
33c5f684c3 Merge pull request #16765 from overleaf/jel-sso-metadata-error
[web] Show errors when unable to import SAML XML metadata

GitOrigin-RevId: 230700038bf692c1da02e8fd509c119e28a68598
2024-01-30 09:04:24 +00:00
Jessica Lawshe
f79f534d9f Merge pull request #16769 from overleaf/jel-scroll-to-notification
[web] Add scroll to notification component

GitOrigin-RevId: 096f9f42344729464e7fb38e4f6542cb2e891918
2024-01-30 09:04:19 +00:00
Jessica Lawshe
71ca6f05b7 Merge pull request #16737 from overleaf/jel-sso-file
[web] Get SSO import data from File rather than FileReader

GitOrigin-RevId: 89de9c614024ab6a310a6226f59c5aa8c82c64e4
2024-01-30 09:04:15 +00:00
M Fahru
6f3402e0e8 [website-redesign] Change all website-redesign CTA button color to our new green: "emerald-green" (#16711)
* Change all website-redesign CTA button color to our new green: "emerald-green"

* Change `inline-green-link` color to `emerald-green`, also change the hover of `green-link` to `emerald-green-dark`

* reuse the `btn-primary` class for website-redesign pages with the new green primary color

GitOrigin-RevId: 63ba76efbb7e7e9d1a99ff9f6b426e94d86bbdf0
2024-01-30 09:04:08 +00:00
Thomas
a1046a7e6f Merge pull request #16766 from overleaf/mf-reduce-rocket-sticker-size-mobile
Reduce rocket sticker size on mobile to 70%

GitOrigin-RevId: 34e2ef290399ad284af0a85b480b884cd49d92de
2024-01-30 09:04:03 +00:00
Thomas
10b6c63d38 Merge pull request #16764 from overleaf/tm-website-redesign-org-logo-overflow
Set logo sizes to match design and fix overflowing, use flex-basis instead of grid

GitOrigin-RevId: dee9427f72502628d02210a3a75e028cda1b2905
2024-01-30 09:03:59 +00:00
Thomas
98f56f8adc Merge pull request #16773 from overleaf/tm-website-redesign-minor-launch-fix
Fix template card hover hint and overleaf sticker size at lower breakpoints

GitOrigin-RevId: 6aefdb1a1a0c58ca5c481fea692b8c19579c8e0d
2024-01-30 09:03:54 +00:00
CloudBuild
90cda11550 auto update translation
GitOrigin-RevId: a39aa8b8fae8f7a02daaa8ee9a0d5ec83c3a7685
2024-01-29 09:04:16 +00:00
Jakob Ackermann
a3dc24a46e Merge pull request #16752 from overleaf/jpa-format-fix
[terraform] cloud-build: add missing triggers for libraries

GitOrigin-RevId: 3047b85550f9c2e51460509b9c1df7c414b901eb
2024-01-29 09:04:05 +00:00
Thomas
faa9109002 Merge pull request #16732 from overleaf/tm-website-redesign-small-fixes
Website redesign implementing small fixes based on Markup feedback

GitOrigin-RevId: 02a4b2de03b4afdab00b67448534e685d44d9f49
2024-01-29 09:04:02 +00:00
Thomas
cd38f6df86 Merge pull request #16750 from overleaf/ds-home-page-premium-tag
Website Redesign - Premium badges on home page

GitOrigin-RevId: a3e5d52d1ec119d171e7f5c85a67c3661ae469af
2024-01-29 09:03:59 +00:00
Thomas
17e4c776c1 Place redesign pages on seperate urls with redirects (#16724)
* Place redesign pages on seperate urls with redirects, refactor into StaticPageController

* Add page titles to variant pages (#16710)

* Add features-page-view event (#14911)

* Add canonical URLs to variant marketing pages

GitOrigin-RevId: 3f65f53d856a063dde1e9d60fd3cc327437294f6
2024-01-29 09:03:54 +00:00
M Fahru
4f901caa2d [website-redesign] Set autoplay video configuration according to specification (#16683)
* Set autoplay video configuration according to specification:

- Do not autoplay video initially
- If the video is visible on the viewport (with a threshold of 80% of the video is visible), autoplay video, and everytime it autoplays, set the video starting point to 0
- If the video is not visible on the viewport (with a threshold of 80% of the video is not visible), pause the video
- If user screen stops at video that's currently in autoplay, the autoplay will stop after it endedand replay every 15 seconds.
- For user with reduced motion preference, show video controls.

* Add a comment explaining error in firefox if user is pressing the seek bar relatively fast.

It seems to be a bug specific to firefox.

* Reduce the threshold to 70% of the visible video on the screen.

0.7 value will make the video autoplays instantly for the `new-design-registration` variant since the video on that variant will not be shown fully on the screen at initial homepage load (in desktop screen).

* Set attribute without empty string, fix video that lacked data attribute

* Remove duplicated autoplay video setup on homepage

* Remove autoplay pause/reset on scroll away, don't play if not visible

Refactors the autoplay-video code and removes the pause/reset on scroll
away while also keeping track of the video elements visibility so that
the video doesn't immediately start playing after 15s if not visible.

We also prevent trying to call .play() before the video is in a
"canplay" state. If the video is not ready, then add an event listener
for the "canplay" event and only play() once this is fired. We only do
this once to avoid adding duplicate listeners.

We also check that the video is not playing before calling play(),
because it could still be in playback if we scroll out of view and then
back into view.

* Refactor autoplay-video to match style of similar JS enhancement implementations

* Move autoplay-video from shared/utils to features/

---------

Co-authored-by: Thomas Mees <thomas.mees@overleaf.com>
Co-authored-by: Thomas <thomas-@users.noreply.github.com>
GitOrigin-RevId: 13011af04baaeba4b8053478a09e3e4d7c960d5c
2024-01-29 09:03:51 +00:00
Thomas
19c6c31e87 Improve organization logos (update assets and refactored styling) (#16730)
* Fix organization logos styling:

- stop forcing explicit height to the image itself, this will remove any visible stretching.
- Force 2 column for screen size < 1200px (and remove flex-wrap) to make sure no single logo that wraps to the next line.

* Update crest images with higher resolution assets

---------

Co-authored-by: M Fahru <m.fahru@overleaf.com>
GitOrigin-RevId: c463d207fdbd750cdbfe6666bb79f69dfd85c673
2024-01-29 09:03:48 +00:00
Davinder Singh
f09d481eea Website redesign - Fixing premium badges and buttons on mobile design (#16718)
* fixing premium badge display on every page

* Aligning header sections and fixing buttons

This aligns the header section to the left on mobile layouts
This also fixes the buttons width on mobile layouts

GitOrigin-RevId: 795af064989272969a5707c086b422b4be58ec25
2024-01-29 09:03:45 +00:00