github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Store the current value of openDocId in a ref for use in openDoc (#16853)

Browse source 
GitOrigin-RevId: 853a857eed832fde0be05fef3e149c875fd0c940
This commit is contained in:
Alf Eaton 2024-02-01 09:44:19 +00:00 committed by Copybot
parent 373c4736e8
commit 6976e02a38
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
services/web/frontend/js/features/ide-react/context/editor-manager-context.tsx
View file

@ -390,6 +390,11 @@ export const EditorManagerProvider: FC = ({ children }) => {
[attachErrorHandlerToDocument, doOpenNewDocument, currentDocument]
)
const openDocIdRef = useRef(openDocId)
useEffect(() => {
openDocIdRef.current = openDocId
}, [openDocId])
const openDoc = useCallback(
async (doc: Doc, options: OpenDocOptions = {}) => {
debugConsole.log(`[openDoc] Opening ${doc._id}`)
@ -421,15 +426,16 @@ export const EditorManagerProvider: FC = ({ children }) => {
}
}
// If we already have the document open we can return at this point.
// If we already have the document open, or are opening the document, we can return at this point.
// Note: only use forceReopen:true to override this when the document is
// out of sync and needs to be reloaded from the server.
if (doc._id === openDocId && !options.forceReopen) {
if (doc._id === openDocIdRef.current && !options.forceReopen) {
done(false)
return
}
// We're now either opening a new document or reloading a broken one.
openDocIdRef.current = doc._id as DocId
setOpenDocId(doc._id as DocId)
setOpenDocName(doc.name)
setOpening(true)
@ -458,7 +464,6 @@ export const EditorManagerProvider: FC = ({ children }) => {
[
eventEmitter,
jumpToLine,
openDocId,
openNewDocument,
setCurrentDocument,
setOpenDocId,