github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-15 18:47:53 +00:00
Code Issues Projects Releases Packages Wiki Activity

Only log unknown file upload errors (#16739)

Browse source 
GitOrigin-RevId: a6129e622ce32ea227f575b6d93616a7411391ed
This commit is contained in:
Alf Eaton 2024-02-01 09:44:36 +00:00 • committed by Copybot
parent 6976e02a38
commit efe44f08b8
1 changed files with 10 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
services/web/app/src/Features/Uploads/ProjectUploadController.js
View file

@ -78,10 +78,6 @@ module.exports = ProjectUploadController = {
const projectId = req.params.Project_id
const { folder_id: folderId } = req.query
if (name == null || name.length === 0 || name.length > 150) {
logger.err(
{ projectId, fileName: name },
'bad name when trying to upload file'
)
return res.status(422).json({
success: false,
error: 'invalid_filename',
@ -100,16 +96,6 @@ module.exports = ProjectUploadController = {
fs.unlink(path, function () {})
timer.done()
if (error != null) {
logger.error(
{
err: error,
projectId,
filePath: path,
fileName: name,
folderId,
},
'error uploading file'
)
if (error.name === 'InvalidNameError') {
return res.status(422).json({
success: false,
@ -126,6 +112,16 @@ module.exports = ProjectUploadController = {
error: 'folder_not_found',
})
} else {
logger.error(
{
err: error,
projectId,
filePath: path,
fileName: name,
folderId,
},
'error uploading file'
)
return res.status(422).json({ success: false })
}
} else {