From efe44f08b8a69117e33ad4e2b44bd20896dc0181 Mon Sep 17 00:00:00 2001
From: Alf Eaton <alf.eaton@overleaf.com>
Date: Thu, 1 Feb 2024 09:44:36 +0000
Subject: [PATCH] Only log unknown file upload errors (#16739)

GitOrigin-RevId: a6129e622ce32ea227f575b6d93616a7411391ed
---
 .../Uploads/ProjectUploadController.js        | 24 ++++++++-----------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/services/web/app/src/Features/Uploads/ProjectUploadController.js b/services/web/app/src/Features/Uploads/ProjectUploadController.js
index 0038a92cf0..228123daa1 100644
--- a/services/web/app/src/Features/Uploads/ProjectUploadController.js
+++ b/services/web/app/src/Features/Uploads/ProjectUploadController.js
@@ -78,10 +78,6 @@ module.exports = ProjectUploadController = {
     const projectId = req.params.Project_id
     const { folder_id: folderId } = req.query
     if (name == null || name.length === 0 || name.length > 150) {
-      logger.err(
-        { projectId, fileName: name },
-        'bad name when trying to upload file'
-      )
       return res.status(422).json({
         success: false,
         error: 'invalid_filename',
@@ -100,16 +96,6 @@ module.exports = ProjectUploadController = {
         fs.unlink(path, function () {})
         timer.done()
         if (error != null) {
-          logger.error(
-            {
-              err: error,
-              projectId,
-              filePath: path,
-              fileName: name,
-              folderId,
-            },
-            'error uploading file'
-          )
           if (error.name === 'InvalidNameError') {
             return res.status(422).json({
               success: false,
@@ -126,6 +112,16 @@ module.exports = ProjectUploadController = {
               error: 'folder_not_found',
             })
           } else {
+            logger.error(
+              {
+                err: error,
+                projectId,
+                filePath: path,
+                fileName: name,
+                folderId,
+              },
+              'error uploading file'
+            )
             return res.status(422).json({ success: false })
           }
         } else {