github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
7035 commits 3 branches 7 tags 206 MiB
Commit graph

1613 commits

Author SHA1 Message Date
Brian Gough
029e3b1557 fix the cancellation of spelling requests 2017-11-20 12:25:09 +00:00
Nate Stemen
f00dbf3d56 fixing popup and code folding issues 2017-11-17 16:25:45 -05:00
Alasdair Smith
154943ba68 Don't check for linting errors if code check is disabled 
There are a couple of reasons for this:

1. Some linting errors are returned from the server after a compile is run,
replacing client-side linting errors. If code check is disabled this does not
happen, and therefore linting errors persist until the next compile. This makes
it appear as though autocompile is not running

2. It is likely that if code check is disabled, the user is deliberately
ignoring linting errors and therefore the linting check is pointless
 2017-11-17 16:38:44 +00:00
Nate Stemen
00e3e8da9f adding last labels configuration 2017-11-16 14:59:04 -05:00
Nate Stemen
c78a0ae209 removing comment 2017-11-16 14:49:29 -05:00
Nate Stemen
c051316aac adding deleted file 2017-11-16 14:45:20 -05:00
Brian Gough
bd09ef81f2 added comments 2017-11-16 15:41:16 +00:00
Brian Gough
dc6110db8d put ace in readonly mode when changing session 
if the session fails to attach successfully (e.g due to an exception in
the changeSession event handler) the editor will be left in a state
where the user will not be able to enter any text.  This should at least
cause them to reload the editor.
 2017-11-16 11:32:08 +00:00
Brian Gough
125a5ec606 temporarily avoid exception in ace event handler 
full fix will be to use the angular $http cancellation mechanism
 2017-11-15 16:28:31 +00:00
Nate Stemen
a78330877b fixing services call 2017-11-15 10:14:31 -05:00
Nate Stemen
428ae3aa53 adding labels service back 2017-11-15 09:27:46 -05:00
Shane Kilkelly
aea8e77f8a Merge branch 'as-fix-rollout-2' 2017-11-13 09:50:46 +00:00
Shane Kilkelly
8ba9073606 Merge branch 'sk-link-sharing-onboarding' 2017-11-13 09:31:44 +00:00
Brian Gough
fe12a341e1 Merge pull request #89 from sharelatex/bg-slow-connection-fix 
increase allowed op backlog and flush tolerance
 2017-11-13 09:22:18 +00:00
Shane Kilkelly
42c0974671 Place the linksharing popover from the right, not the left. 
This ensures the popover reflows properly with window resize.
 2017-11-10 12:05:12 +00:00
Shane Kilkelly
666ee0669a Alter position of link-sharing popover, and better image 2017-11-10 10:24:36 +00:00
Shane Kilkelly
44420b41d6 Remove stray console log 2017-11-09 15:13:58 +00:00
Shane Kilkelly
766c8d6f0f Add a general 'ide:loaded' event, to init popover 2017-11-09 15:12:55 +00:00
Shane Kilkelly
470ad36218 Add onboarding popup for link-sharing 2017-11-09 14:28:11 +00:00
Alasdair Smith
8174a849a1 Reset to new analytics key 2017-11-08 11:01:36 +00:00
Alasdair Smith
15d3e5eb6e Fix triggering autocompile in rollout 2017-11-08 10:31:41 +00:00
Shane Kilkelly
484cad2ef0 Render anonymous users as '?' in top bar 2017-11-07 14:20:08 +00:00
Shane Kilkelly
3cafd0ac8f Refine deactivate logic, only if member via token and not otherwise 2017-11-03 11:46:00 +00:00
Shane Kilkelly
3360688752 Separate cases of setting Guest TC in general, and for this user 2017-11-03 11:11:04 +00:00
Shane Kilkelly
1cedfed1e4 Merge branch 'master' into sk-unlisted-projects 2017-11-02 10:10:09 +00:00
Brian Gough
15997ea782 increase allowed op backlog and flush tolerance 2017-11-01 14:20:07 +00:00
Shane Kilkelly
030ffbe231 Add event-tracking to the make-token-based action 2017-10-31 14:23:05 +00:00
Shane Kilkelly
a3e5788b97 Move the __enableTokenAccessUI state to top level 2017-10-30 13:58:22 +00:00
Shane Kilkelly
5fe5125a5c Add ability to show/hide the new token-access ui 2017-10-30 13:48:25 +00:00
Shane Kilkelly
a57827458d Fix guest state sync 2017-10-27 14:41:48 +01:00
Shane Kilkelly
8a2acd7138 Only turn on guest track-changes if available 2017-10-26 13:48:02 +01:00
Shane Kilkelly
f9d83c24ef clean-up commented out code 2017-10-26 11:04:59 +01:00
Shane Kilkelly
62d170e7a0 Move the access-level sync out of the share controller. 
This means sync will work even for clients which don't show the share
button in the menu bar.
 2017-10-26 11:04:00 +01:00
Shane Kilkelly
5f6e191c5f Automatically disable guest-track-changes when project made private 2017-10-25 14:48:32 +01:00
Shane Kilkelly
8561b69ee9 Remove tokenMembers sync to clients 2017-10-25 11:29:05 +01:00
Shane Kilkelly
74c231826d WIP: track changes with token-access 2017-10-25 10:34:18 +01:00
Nate Stemen
e8731bc276 allow for capital letters in command name 2017-10-24 16:55:25 +01:00
Nate Stemen
829595777c change regex to match single backslash and command fragment 2017-10-24 16:35:28 +01:00
Nate Stemen
98909026f5 moving data to backend and fixing tests 2017-10-24 10:59:41 +01:00
Shane Kilkelly
b32088ee6b Only add token member if they're not also a collaborator 2017-10-20 13:38:52 +01:00
Nate Stemen
0ebda89efe fixing package manager issues 2017-10-20 12:04:10 +01:00
Shane Kilkelly
0e44b319db Change anonToken and such to anonymousAccessToken 2017-10-20 10:10:21 +01:00
Shane Kilkelly
d8717a06a2 Fix track-changes with token-access 2017-10-19 14:42:17 +01:00
Brian Gough
bf4404b60a handle null values when saving rootDoc_id 2017-10-18 14:19:45 +01:00
Brian Gough
5d116e8ce9 Merge pull request #65 from sharelatex/bg-fix-main-doc-selection 
fix main doc selection (connects to overleaf/sharelatex#222)
 2017-10-18 13:11:10 +01:00
Brian Gough
82b84fd5f4 hide logs when there are validation errors 2017-10-17 15:50:38 +01:00
Henry Oswald
aff5823a2d Revert "Complete 'usepackage' with packages" 2017-10-17 13:30:47 +01:00
Alasdair Smith
bd6bc42a9a Don't Show autocompile on load 2017-10-16 11:42:15 +01:00
Alasdair Smith
5d3371a52c Merge pull request #38 from sharelatex/as-autocompile-rollout 
Rollout for auto compile; Connects to #20
 2017-10-16 10:48:43 +01:00
Nate Stemen
333e411a75 Merge pull request #39 from sharelatex/ns-package-completer 
Complete 'usepackage' with packages
 2017-10-13 17:43:36 +01:00
Nate Stemen
2efb6b69e5 removing comment 2017-10-13 17:42:10 +01:00
Nate Stemen
da07a91229 reformated data files with argument data 2017-10-13 17:24:48 +01:00
Brian Gough
d5fba2cc71 enable incremental compiles for all users 2017-10-13 08:23:16 +01:00
Nate Stemen
f113ba6342 basic package aware autocomplete 2017-10-12 15:33:14 +01:00
Brian Gough
45ed090326 Merge pull request #37 from sharelatex/bg-rate-limit-autocompile 
rate limit autocompile (connects to #18)
 2017-10-12 09:25:59 +01:00
Brian Gough
ea89638010 rename autocompile_disabled to autoCompileDisabled 
for consistency
 2017-10-09 15:21:01 +01:00
Brian Gough
15e2deed73 rename isAutoCompile and isBackgroundAutoCompile 
changed to isAutoCompileOnLoad and isAutoCompileOnChange
 2017-10-09 15:18:55 +01:00
Nate Stemen
cfca4b5d6c modified labels service to include packages aware autocompletion 2017-10-06 17:15:50 +01:00
Nate Stemen
507bb568a3 labels -> metadata 2017-10-05 14:19:30 +01:00
Nate Stemen
e53a24f8f5 starting to generalize from labels to metadata 2017-10-04 17:56:43 +01:00
Shane Kilkelly
6482cd7dd8 Generate tokens on old projects if they're not present 2017-10-04 16:31:24 +01:00
Nate Stemen
64f44ab102 Merge branch 'master' of https://github.com/sharelatex/web-sharelatex-internal into ns-package-completer 2017-10-04 09:53:04 +01:00
Nate Stemen
8b4843cf8b cleaning up usepackage completion 2017-10-03 17:32:34 +01:00
Alasdair Smith
550e7d75ca Check if user is part of autocompile rollout when showing setting or running autocompile 2017-10-03 17:19:51 +01:00
Brian Gough
2723537f82 disable autocompile when rate limit is hit 2017-10-03 16:23:49 +01:00
Paulo Jorge Reis
05f9e9b2c1 Merge pull request #27 from sharelatex/as-autocompile-onboarding 
Autocompile onboarding
 2017-10-03 11:09:51 +01:00
Alasdair Smith
cab3efd77c Merge pull request #25 from sharelatex/hof-history-name 
show user.name in history if available
 2017-10-03 10:57:52 +01:00
Nate Stemen
7d5785b98f adding top 100 packages and package tracking 2017-10-02 18:10:53 +01:00
Shane Kilkelly
9f24f696a5 Use custom header, send anonToken in payload to joinProject 2017-09-29 16:32:07 +01:00
Shane Kilkelly
a66cb15f48 Use angular $http service for spellcheck 2017-09-29 14:55:06 +01:00
Shane Kilkelly
f74da0e6cf Use angular $http service for references 2017-09-29 14:51:00 +01:00
Shane Kilkelly
e04d10d11f Styling of link-share, and fix read-only link 2017-09-29 10:59:30 +01:00
Alasdair Smith
ba6a0b44a9 Fix incorrect selector 2017-09-29 10:53:06 +01:00
Alasdair Smith
dd7e6f0612 Make class names more consistent & switch to JS targeting through id 2017-09-29 10:49:45 +01:00
Shane Kilkelly
df338ebd6d Show tokens in share modal 2017-09-29 10:11:23 +01:00
Shane Kilkelly
9810f63245 Render editor for token access, stub out ui changes 2017-09-28 16:06:08 +01:00
Alasdair Smith
e95778c703 Fix event tracking not being injecting 2017-09-28 13:02:16 +01:00
Alasdair Smith
39c8a6a193 Send analytics data when onboarding dismissed 2017-09-28 12:27:29 +01:00
Alasdair Smith
199e85e4a9 Comment 2017-09-28 12:16:02 +01:00
Alasdair Smith
e78ee69c04 Fix positioning & styling of arrows 2017-09-28 12:03:30 +01:00
Alasdair Smith
2d5a61f5b6 Determine placement of popover based on width of pdf panel 2017-09-28 11:32:38 +01:00
Alasdair Smith
fcc2db9ea7 Use width of button instead of hardcoded 2017-09-28 11:13:49 +01:00
Alasdair Smith
7e407621e9 Position onboarding popover after measuring position 2017-09-28 11:13:49 +01:00
Alasdair Smith
3259b871c0 Dismiss autocompile onboarding 2017-09-28 11:13:49 +01:00
Alasdair Smith
9386ddf4a9 Only show autocompile onboarding when first manual compile is run 2017-09-28 11:13:49 +01:00
Alasdair Smith
316cf07225 Add AutoCompileOnboardingController 2017-09-28 11:13:49 +01:00
Brian Gough
13628f82ec Merge pull request #17 from sharelatex/bg-lock-compiles 
show error for compile in progress
 2017-09-27 13:54:16 +01:00
Hayden Faulds
96a129a860 show user.name in history if available 2017-09-27 10:54:06 +01:00
Brian Gough
0f855689a7 show error for compile in progress 2017-09-26 08:07:35 +01:00
Alasdair Smith
5b3c9f4033 Prevent autocompile if pdf preview is hidden 2017-09-25 15:46:43 +01:00
Alasdair Smith
96d13215e3 Be more defensive when checking encoded text 2017-09-22 09:36:50 +01:00
Alasdair Smith
f8d4923547 Wrap in try/catch 2017-09-21 15:41:24 +01:00
Alasdair Smith
42b604dcda Clean up decoding from websockets 2017-09-21 15:41:24 +01:00
Alasdair Smith
a022f83cce Fix order of args 2017-09-21 15:22:56 +01:00
Alasdair Smith
e2bb6dcecb Pass option to encode range 
To ensure backwards compat with clients not refreshing, pass a flag to enable
encoding.  This way, old client won't receive encoded ranges, but also won't
have decoding logic. The flag can then be removed once all clients are up to
date
 2017-09-21 14:23:39 +01:00
Alasdair Smith
b33929fa83 DRY up 2017-09-21 13:36:31 +01:00
Alasdair Smith
24f44889a7 First pass at decoding changes & comments in ranges 2017-09-21 13:25:19 +01:00
Alasdair Smith
4007fc682b Send JSON in autocompile setting event payload 2017-09-19 15:55:00 +01:00
Alasdair Smith
66bed67270 Merge pull request #4 from sharelatex/as-client-auto-compile 
Client-side auto compile
 2017-09-19 15:20:07 +01:00
Alasdair Smith
963a14b33c Fix incorrectly named var and remove unneccessary semicolon 2017-09-19 14:25:30 +01:00
James Allen
ece7a4cbb7 Merge pull request #601 from sharelatex/ns-raise-safari-regex-count 
Raising the limit on safari regex count
 2017-09-18 11:16:49 +02:00
James Allen
1bafba8992 Merge pull request #586 from sharelatex/ns-add-SL-command-data 
adding commands that appear in top 100 from SL-CLSI analysis
 2017-09-18 11:16:41 +02:00
James Allen
fa13e1051a Merge pull request #585 from sharelatex/sk-ac-refactor-autocompletemanager 
Refactor out common code in AutocompleteManager.
 2017-09-18 11:16:29 +02:00
Nate Stemen
80c00b13f7 Raising the limit on safari regex count 2017-09-11 11:27:03 +01:00
Brian Gough
6d73c48c36 Merge pull request #596 from sharelatex/bg-suppress-incremental-compile-after-errors 
suppress incremental compile after errors
 2017-09-11 08:15:50 +01:00
Alasdair Smith
38eaf82c65 Ensure that time is monotonic when running autocompile 2017-09-08 11:00:46 +01:00
Alasdair Smith
4a490aafbf Improve UX of triggering autocompile. 
If a user is making infrequent edits (i.e. if reading and making small
changes), then waiting 5 seconds for a recompile is bad. Therefore we track
the time since the last recompile and use this to decide whether a recompile
should be run. This reduces the time to recompile, unless the user is typing
for a significant amount of time.
 2017-09-08 10:42:54 +01:00
Alasdair Smith
e2523c569e Filter linting warnings 2017-09-07 17:45:16 +01:00
Brian Gough
c6d2f0f4e1 skip incremental compile after server error 2017-09-07 15:05:42 +01:00
Alasdair Smith
624802c28e Remove unnecessary parens 2017-09-07 11:30:42 +01:00
Alasdair Smith
b7713439bf Bring back comparsion erroneously removed 2017-09-07 11:30:20 +01:00
Alasdair Smith
9cde236bc8 Add comment explaining lint errors vs compile log errors 2017-09-07 11:28:36 +01:00
Alasdair Smith
a8cdfb7ecc Track autocompile setting change 2017-09-07 11:13:38 +01:00
Alasdair Smith
11386eb817 Add option to autocompile, so can be identified in event tracking 2017-09-07 10:20:21 +01:00
Alasdair Smith
8a8d98935b Remove unnecessary linting check in annotations listener 
When user starts typing, compile log annotations are replaced with linter ones,
so log errrors can be ignored for this purpose. Because we don't try to
autocompile unless the user types something
 2017-09-07 10:04:10 +01:00
Alasdair Smith
0c76b06a97 Increase timeout to 5 seconds 2017-09-07 10:02:48 +01:00
Alasdair Smith
320466a4f7 Catch invalid email address and show specific error message 2017-09-06 13:47:45 +01:00
James Allen
b2257db2c2 Don't get confused by commands in arguments in autocomplete 2017-09-05 19:26:13 +02:00
Alasdair Smith
ca8ba6dabe Fix incorrect checking of contact name 2017-09-05 17:18:26 +01:00
Alasdair Smith
ce630e4971 Extract timeout constant 2017-09-05 14:57:06 +01:00
Alasdair Smith
a9e94f6a6d Unsubscribe autocompile listener if disabled 2017-09-05 14:57:06 +01:00
Alasdair Smith
cca7f55322 Add autocompile setting 2017-09-05 14:57:06 +01:00
Alasdair Smith
64f70942d0 Ensure user is in beta program 2017-09-05 14:57:06 +01:00
Alasdair Smith
fc4a260d95 Ensure error is from linting not compile logs 2017-09-05 14:57:06 +01:00
Alasdair Smith
9f1adfd0c0 Replace separate autocompile ctrl with listener in PdfController 2017-09-05 14:57:06 +01:00
Alasdair Smith
53bb4fdde0 Use var in root scope instead of event to track linting error 2017-09-05 14:57:06 +01:00
Alasdair Smith
dab799a81b First pass at auto compile ctrl 2017-09-05 14:57:06 +01:00
Alasdair Smith
c42b08fcff Dispatch linting error event when changed 2017-09-05 14:57:06 +01:00
Alasdair Smith
65b2c42fad Emit event when op is acknowledged 2017-09-05 14:57:06 +01:00
Nate Stemen
54af7fbdcb adding in a few new commands that appear in SL-CLSI analysis 2017-08-31 10:39:46 +01:00
Alasdair Smith
184c8adb84 Merge pull request #582 from sharelatex/as-pdfjs-cmaps-fix 
Fix Cmaps path for future versions of PDF.js
 2017-08-31 09:36:46 +01:00
Shane Kilkelly
8a612df009 fix use of context helper in onChange 2017-08-31 08:59:38 +01:00
Shane Kilkelly
708afedeb4 Refactor out common code in AutocompleteManager. 
(first pass)
 2017-08-30 14:01:20 +01:00
James Allen
2e005fd39a Merge pull request #572 from sharelatex/ns-autocomplete 
Adding default list of commands to autocomplete
 2017-08-29 15:43:24 +02:00
Alasdair Smith
285c9587e9 Use injected Cmaps path 2017-08-25 15:48:13 +01:00
Brian Gough
f9d1650c6a Merge pull request #569 from sharelatex/bg-compile-from-redis 
compile from redis
 2017-08-25 09:09:52 +01:00
Shane Kilkelly
88923a314d Disallow toggling track-changes via keyboard if not available on project 2017-08-23 15:02:06 +01:00
Nate Stemen
adb26b1b94 forgot meta tag for "thebibiography" 2017-08-18 14:24:44 +01:00
Nate Stemen
fb4182cbb1 Merge branch 'master' into ns-autocomplete 2017-08-18 09:14:06 +01:00
Nate Stemen
42be1164bc fixing environment duplication in autocomplete issue 2017-08-17 14:30:18 +01:00
Nate Stemen
d1b906db43 renaming and organizing 2017-08-16 17:55:43 +01:00
Nate Stemen
f253b7e8cb fixing command duplication issue during suggestion 2017-08-16 17:40:01 +01:00
Nate Stemen
6e9b1c602b fixing spaces vs. tabs issue 2017-08-14 18:02:51 +01:00
Nate Stemen
688f1e9e75 merged staticManager with snippetManager 2017-08-11 09:23:36 +01:00
Brian Gough
e2048e1ed5 use incrementalCompilesEnabled as option name 2017-08-09 16:25:57 +01:00
James Allen
7538c8834f Merge branch 'master' into ja-per-user-track-changes 2017-08-09 14:05:36 +02:00
Brian Gough
97b129cbe3 enable incremental compilation for beta users 2017-08-09 10:57:24 +01:00
James Allen
e5c01df9a8 Merge pull request #544 from sharelatex/ja-update-ace 
Update Ace with new context tracking linter
 2017-08-04 10:46:34 +02:00
James Allen
6c342a6e65 Merge branch 'master' into ja-update-ace 2017-08-04 10:39:53 +02:00
Nate Stemen
769875c5d5 Adding default autocomplete commands w/ argument options 2017-08-03 16:31:46 +01:00
Shane Kilkelly
05c5b4f9c5 Merge branch 'master' into sk-fully-hide-trackchanges 2017-08-03 15:20:20 +01:00
Shane Kilkelly
9cc461605e Prevent track-changes hotkey actions when not enabled. 2017-08-03 15:17:28 +01:00
Shane Kilkelly
670d4438dc If track-changes is not enabled, don't show hotkeys for it. 2017-08-03 15:16:54 +01:00
Shane Kilkelly
8a0f58c63d Use correct character width 2017-08-01 14:28:10 +01:00
Shane Kilkelly
3ffef7fe56 Dynamically adjust the width of autocomplete popup. 2017-08-01 13:40:30 +01:00
Paulo Reis
7b85661035 Re-enable the toggle TC keyboard shortcut. 2017-08-01 11:59:32 +01:00
Paulo Reis
029ab8d2f1 Make sure TC state is applied to all users on load. 2017-08-01 11:30:23 +01:00
Paulo Reis
fbce49f5cd Merge branch 'master' into ja-per-user-track-changes 2017-08-01 10:56:02 +01:00
Shane Kilkelly
9a85e42ddb Remove stray file 2017-08-01 09:53:43 +01:00
Shane Kilkelly
f057f788e3 Autocomplete for graphics 2017-07-31 14:51:22 +01:00
Shane Kilkelly
eeabac7698 Get graphics paths from preamble 2017-07-31 11:28:52 +01:00
Shane Kilkelly
a841646559 Add preamble parser 2017-07-31 11:28:21 +01:00
Shane Kilkelly
eaf9ae5b94 Begin work on autocomplete for includegraphics 2017-07-31 09:34:58 +01:00
Shane Kilkelly
70e5279ba2 Don't autocomplete for commands like \\, \[, \:, etc 2017-07-14 13:52:18 +01:00
Shane Kilkelly
f66982dd8b Consistently delete back to last backslash 2017-07-13 10:23:45 +01:00
Shane Kilkelly
75b0e0cf51 Don't offer autocomplete for double-backslash 2017-07-13 10:22:51 +01:00
Shane Kilkelly
952a765235 Inteligently rank exact match highest 2017-07-12 11:33:45 +01:00
Shane Kilkelly
c8a21cdcf5 WIP: sort definite real commands from possible incidentals 2017-07-12 09:25:39 +01:00
Shane Kilkelly
1fb036811a Temporarily remove up-ranking of exact match 2017-07-11 11:34:31 +01:00
Paulo Reis
a2e583edb8 Remove debug statement. 2017-07-07 10:38:13 +01:00
Paulo Reis
6cfa10d511 Add a per-user TC notice dialog. 2017-07-07 10:38:13 +01:00
Paulo Reis
8925dc5a78 Revert "Show simpler UI when there is only one user." 
This reverts commit 48300bd5b2ef01651e64dad3183e65d5d5798955.
 2017-07-07 10:38:13 +01:00
Paulo Reis
dae5381af7 Show simpler UI when there is only one user. 2017-07-07 10:38:13 +01:00
Paulo Reis
139c2ab1fd Consolidate members list. 2017-07-07 10:38:13 +01:00
Paulo Reis
e421b6550a Filter out read-only users from TC users list. 2017-07-07 10:38:13 +01:00
Paulo Reis
71e0a6935f Readd feature flag handling. 2017-07-07 10:38:13 +01:00
Paulo Reis
e40b8500d7 Keep user state persistent on the client. 2017-07-07 10:38:13 +01:00
Paulo Reis
c701711eab Support a default value when undefined in the review panel toggles. 2017-07-07 10:38:13 +01:00
Paulo Reis
8e6265e3d2 Enable global setting. 2017-07-07 10:38:13 +01:00
Paulo Reis
1ae53a243a Correctly fetch users from project info. 2017-07-07 10:38:13 +01:00
Paulo Reis
f4bdd5eb2b Control sync state with server. 2017-07-07 10:38:13 +01:00
Paulo Reis
1fa7338baf Wire up TC widget to controller methods. 2017-07-07 10:38:13 +01:00
Paulo Reis
dc2085c6e1 Basic widget for toggling TC state. 2017-07-07 10:38:13 +01:00
James Allen
710c89a629 Support per user track changes (proof of concept) 2017-07-07 10:38:13 +01:00
Shane Kilkelly
04c94760f5 Merge branch 'sk-auto-pair-braces' into sk-ac-improvements-integration 2017-07-06 14:39:28 +01:00
Shane Kilkelly
330e3dccc3 Merge branch 'sk-ac-rank-exact-match-highest' into sk-ac-improvements-integration 2017-07-06 14:39:08 +01:00
Shane Kilkelly
611f8825d7 Merge branch 'sk-ac-prevent-double-insertion' into sk-ac-improvements-integration 2017-07-06 14:39:00 +01:00
Shane Kilkelly
9ac15c9d47 Merge branch 'sk-ac-more-eager-trigger' into sk-ac-improvements-integration 2017-07-06 14:38:44 +01:00
Shane Kilkelly
98f96d6087 Merge branch 'sk-ac-disable-for-existing-environments' into sk-ac-improvements-integration 2017-07-06 14:38:07 +01:00
Shane Kilkelly
c99109751e Merge branch 'sk-ac-ignore-comments' into sk-ac-improvements-integration 2017-07-06 14:37:54 +01:00
James Allen
01d709dff5 Remove latex beta mode 2017-07-06 11:59:44 +01:00
Shane Kilkelly
34b2012727 Enable (optional) auto-pairing for latex mode 2017-07-06 11:06:51 +01:00
Shane Kilkelly
68c942582f Clean up the custom insertMatch function 2017-07-04 08:48:45 +01:00
Shane Kilkelly
08faa64b57 Add comment explaining the custom insertMatch 2017-07-03 15:20:36 +01:00
Shane Kilkelly
96d269e348 Use existential operator to check existence 2017-07-03 15:13:27 +01:00
Shane Kilkelly
415de9e2ec Experimental handling of completion for existing commands 2017-07-03 15:12:15 +01:00
Shane Kilkelly
127d5ded86 Remove erroneous log 2017-07-03 13:37:25 +01:00
Shane Kilkelly
7ecadb14f6 Add a skeleton of a custom insertMatch function 2017-07-03 13:36:24 +01:00
Paulo Reis
86e66bbed1 Merge branch 'master' into pr-angular-1.6.x 2017-07-03 09:50:01 +01:00
Shane Kilkelly
bb3c5e7a34 Reverse direction, don't ignore commands in comments 2017-06-30 15:05:21 +01:00
Shane Kilkelly
bd88adb621 Account for mid-line comments 2017-06-30 14:03:34 +01:00
Shane Kilkelly
da286438be Don't trigger autocomplete when editing existing environment 2017-06-30 11:22:11 +01:00
Shane Kilkelly
c2fcbbeb72 Fix parsing, so it accurately captures command args 2017-06-30 10:55:10 +01:00
Shane Kilkelly
e2bff06aeb Add comment about ignoring comments 2017-06-30 08:42:03 +01:00
Shane Kilkelly
cfe51089f6 Ignore commands within comments when parsing document 2017-06-29 16:04:52 +01:00
Shane Kilkelly
db80f8ca1c Don't trigger autocomplete if we're on a comment line. 2017-06-29 14:42:08 +01:00
Shane Kilkelly
c9cda16a5e Refactor score calculation 2017-06-29 11:13:59 +01:00
Shane Kilkelly
936278b045 Bring score into line with new policy 2017-06-29 10:55:05 +01:00
Shane Kilkelly
cbae1857e7 Allow exact match to be ranked higher than any other result 2017-06-29 10:54:07 +01:00
Shane Kilkelly
3deebc8642 Change the scoring system for autocomplete, scale 0-100 2017-06-29 10:53:52 +01:00
Shane Kilkelly
1490b4a0da Remove Shift-Space autocomplete trigger, far to easy to misfire 2017-06-29 10:02:49 +01:00
Shane Kilkelly
69796bd835 also trigger autocomplete if last character is backslash 2017-06-28 15:48:21 +01:00
Shane Kilkelly
c9678ad699 Trigger autocomplete with Shift-Space, in addition to existing triggers 2017-06-28 15:24:37 +01:00
Paulo Reis
9ffec6eb16 Correctly access response parameters. 2017-06-26 10:00:47 +01:00
Paulo Reis
ddee75e479 Use a getterSetter to manage int values in settings. 2017-06-20 17:08:53 +01:00
Paulo Reis
669c705d32 Also refactor signatures from methods wrapping the HTTP service. 2017-06-20 16:27:05 +01:00
Paulo Reis
3dda383d70 Use promise method signatures, instead of old HTTP service ones. 2017-06-20 16:04:06 +01:00
Paulo Jorge Reis
2dda430691 Merge pull request #522 from sharelatex/bg-hide-textlayer-for-performance 
set text layer to display:none for faster scroll
 2017-06-20 13:58:20 +01:00
Shane Kilkelly
8b7a1bd4d9 Merge branch 'sk-labels-ac-debounce' 2017-06-20 13:53:23 +01:00
Paulo Reis
155f515a50 Use standard promises with the http service. 2017-06-20 11:50:23 +01:00
Shane Kilkelly
3d2d7652c6 Simplified and faster blanking 2017-06-20 08:46:47 +01:00
Shane Kilkelly
b4e2dcf7ef Match prefixes of ref and cite up to 16 characters 2017-06-20 08:46:28 +01:00
Shane Kilkelly
a299af12e8 Remove debug helper 2017-06-20 08:46:18 +01:00
Shane Kilkelly
85ddff15cb Move command-matching regex to the class level 2017-06-16 10:20:55 +01:00
Shane Kilkelly
0163ffc4bd Extend, and clean up the command-matching regex 2017-06-16 10:17:30 +01:00
Shane Kilkelly
1d905bd5ff Clean up string replacement 2017-06-16 09:49:16 +01:00
Shane Kilkelly
d9aff3c3f4 Blacklist more commands 2017-06-16 09:41:40 +01:00
Shane Kilkelly
a1d2d5b313 WIP: blank out label commands before running spell-check 2017-06-16 09:20:35 +01:00
Paulo Reis
af2cbf5a51 Force return true on a jquery handler; returning falsy values may have unexpected results. 2017-06-15 16:17:21 +01:00
Paulo Reis
fcf0a96933 Use selection.isCollapsed to check for empty selections. 2017-06-15 16:16:30 +01:00
Brian Gough
503822deb0 avoid possible exception if selection is undefined 
defensive programming only
 2017-06-15 14:32:00 +01:00
Brian Gough
b9804823f3 handle off-screen selection 
when toggling the logs button the selection is off-screen and
selection.toString() is empty even when there is a selected range.  Can
check for selection.type being "Range" instead.
 2017-06-15 14:21:42 +01:00
Brian Gough
b04288ed44 avoid getting duplicate handlers for mouseup 2017-06-15 14:21:42 +01:00
Shane Kilkelly
403d822174 Alter labels debouncer to handle transitions between docs 2017-06-15 14:09:49 +01:00
Brian Gough
76dcde4dae hide the text layer on reload 2017-06-15 13:42:19 +01:00
Paulo Reis
fbaa918927 Do not show the text layer when the user clicks outside pages. Remove some debug statements. 2017-06-15 12:32:04 +01:00
Paulo Reis
4985f7ca1c Different approach: render all text layers while selecting (WIP). 2017-06-15 12:32:04 +01:00
Paulo Reis
786659dc1b Render text layer on hovered pages (and adjacent ones). 2017-06-15 12:32:04 +01:00
Shane Kilkelly
b0bb4b3e47 Merge branch 'sk-ref-variants' 2017-06-15 09:17:48 +01:00
Shane Kilkelly
9607174b64 Merge branch 'master' into sk-server-side-labels-loading 2017-06-15 08:49:14 +01:00
Shane Kilkelly
3f1a440d66 Support variations of \ref{}, such as \cref{}, \eqref{}, etc.. 2017-06-14 15:15:07 +01:00
Shane Kilkelly
b0ff8e0745 Fix a typo: prefxi => prefix 2017-06-14 15:14:38 +01:00
Shane Kilkelly
5e37b1dac1 Move logic for selectively loading labels. 
Only load labels if the user has write permission
 2017-06-14 13:26:02 +01:00
Brian Gough
e1efc3a7b5 Merge pull request #521 from sharelatex/bg-reduce-pdf-memory-usage 
Revert "use a single pdfjs worker, rotated to avoid leaks"
 2017-06-13 16:46:58 +01:00
Shane Kilkelly
3b066758bb Don't load labels for anonymous/read-only users 2017-06-13 14:06:00 +01:00
Shane Kilkelly
954c53aec6 Move the labels event logic into ide/labels/LabelsManager 2017-06-13 13:29:03 +01:00
Shane Kilkelly
a04eb1197d Move labels service to /ide/labels/services/labels 2017-06-13 11:43:25 +01:00
Shane Kilkelly
debb0c06a4 Clearer logic for triggering labels-loading 2017-06-12 14:23:29 +01:00
Shane Kilkelly
234a2d0e21 Remove cruft 2017-06-12 11:37:34 +01:00
Shane Kilkelly
1bb065344c Move labels into an Angular Service 2017-06-12 09:44:32 +01:00
Shane Kilkelly
56385a798b Use ide.$http, rather than jquery 2017-06-09 11:41:35 +01:00
Shane Kilkelly
5443b92e7d Move state management into LabelsMaster on the ide 2017-06-09 11:28:27 +01:00
Shane Kilkelly
965a46291b Only fetch labels for uploaded docs, not files 2017-06-08 15:55:17 +01:00
Shane Kilkelly
ff7955dfdb Update labels when docs are uploaded or removed 2017-06-08 15:12:18 +01:00
Shane Kilkelly
c7dbd21cd1 use flag on aceEditor to enable autocomplete features 2017-06-08 09:22:08 +01:00
Paulo Reis
240d6d6f6b Resolve timing issue when triggering selection-related logic. 2017-06-07 14:21:05 +01:00
Paulo Reis
53b18e041f Trigger selection-related logic after accepting or rejecting changes. 2017-06-07 14:03:58 +01:00
Brian Gough
aa8974dcd6 Revert "use a single pdfjs worker, rotated to avoid leaks" 
This reverts commit f270ef54911acd800d2ffd577080b50ea2fe4aff.

Use a new worker on each reload to free up memory.
 2017-06-07 13:29:10 +01:00
Paulo Reis
19ecffd654 Merge branch 'master' into pr-aggregate-insert-delete 2017-06-06 17:04:31 +01:00
Paulo Reis
34796b18c5 Add translation keys. 2017-06-06 16:46:36 +01:00
Paulo Reis
afa011c813 Avoid flickering when elements enter the review panel. 2017-06-06 16:11:00 +01:00
Paulo Reis
73a67c6617 Add a note on the need of reverse sorting changes when rejecting. 2017-06-06 13:34:48 +01:00
Paulo Reis
4504f77aa3 Do bulk rejects in reverse order. 2017-06-06 12:06:43 +01:00
Paulo Reis
81a5a5311d Clear selection after bulk actions. 2017-06-06 10:03:33 +01:00
Paulo Reis
5a75663a0c Do bulk rejects in reverse order. 2017-06-05 17:17:47 +01:00
Paulo Reis
e616a62d68 Save entry ids inside entry object, not only as the key. 2017-06-05 16:29:55 +01:00
Shane Kilkelly
f7ad4a4786 WIP: basically working, with client sync 2017-06-05 14:48:50 +01:00
James Allen
cb1745a1e6 Fix redirect in clone project modal 2017-06-05 13:33:32 +01:00
James Allen
d7981fd2d4 Merge pull request #512 from sharelatex/ja-project-name-validation 
Refactor project name validation into one place and restrict /s
 2017-06-05 11:55:39 +01:00
Shane Kilkelly
51881dbbcc Only load labels from current doc if change is local 2017-06-05 11:09:58 +01:00
Paulo Reis
6c3cdbcc3a Remove dead code, backend does not send single change events anymore. 2017-06-05 10:43:03 +01:00
Paulo Reis
8d8bcab1e8 Consolidate change accept and reject code. 2017-06-05 10:41:59 +01:00
Shane Kilkelly
4cb41a988a WIP: initial work on server-side labels 2017-06-02 15:12:59 +01:00
Paulo Reis
e2edf4184f Explicit naming. 2017-06-02 11:43:43 +01:00
Shane Kilkelly
51e3a6b3a3 Don't use String.startsWith, use slice instead. 
- String.startsWith is not supported in IE
 2017-06-02 09:54:48 +01:00
Paulo Reis
26260fc11f Prevent aggregation of changes from different users. 2017-06-01 16:33:50 +01:00
Paulo Reis
b2a7686204 DRYness. 2017-06-01 15:28:37 +01:00
Paulo Reis
2a0454f2f1 Integrate aggregate changes with bulk actions. 2017-06-01 15:18:43 +01:00
Paulo Reis
1490ea7b04 Change aggregated change model: the main change is now the insertion, deletion is stored in metadata. 2017-06-01 15:03:37 +01:00
Paulo Reis
11c0644490 Aggregate changes; make accept and reject work. 2017-06-01 11:47:55 +01:00
Shane Kilkelly
9a15420c4e Merge branch 'master' into sk-labels-autocomplete 2017-06-01 08:34:56 +01:00
Paulo Reis
3cf8f26583 Add collapse and expand behaviour to aggregate change entries. 2017-05-31 16:23:24 +01:00
Paulo Reis
a6108480f5 Add directive to show change entries. 2017-05-31 14:47:25 +01:00
Shane Kilkelly
039d18bf8b Simplify logic for deciding whether to re-scan doc on not 2017-05-26 15:08:38 +01:00
Shane Kilkelly
faf0337ca9 Refactor labels autocomplete 2017-05-26 14:56:38 +01:00
Paulo Reis
7fbf6d97bd Merge branch 'master' into pr-hide-review-panel 2017-05-26 09:39:29 +01:00
Shane Kilkelly
7923450e25 Move labelsManager into aceEditor directory 2017-05-25 09:42:07 +01:00
Shane Kilkelly
0543f32ff0 Add comment explaining debounce 2017-05-25 09:35:38 +01:00
Shane Kilkelly
ea9a0dda83 More robust change detection for autocomplete. 
- accurately detect when labels are involved in 'remove' event
 2017-05-25 09:33:15 +01:00
Shane Kilkelly
1ba8b702ad More robust regex for matching/parsing labels. 
- limit label name to max 80 characters
- don't use `.*`
- limit total labels per document to 1000
 2017-05-25 09:32:10 +01:00
Shane Kilkelly
a363b62f23 Remove periodic polling of document for labels 2017-05-25 09:31:36 +01:00
Shane Kilkelly
d0bf407515 Use coffeescript => functions, rather than self=this. 2017-05-24 15:05:53 +01:00
Shane Kilkelly
efd01081f7 Set up and automatic refresh of labels 2017-05-24 14:28:27 +01:00
Shane Kilkelly
b871cdab4c Remove debug logs 2017-05-24 14:28:15 +01:00
Shane Kilkelly
1f3a375b4e Update commentary 2017-05-24 11:42:00 +01:00
Shane Kilkelly
da84b3f31c WIP: basically working labels/ref autocomplete 2017-05-24 11:40:12 +01:00
Shane Kilkelly
17dd64f48a Merge pull request #507 from sharelatex/sk-squash-web-errors 
Squash various web errors
 2017-05-24 10:57:18 +01:00
Shane Kilkelly
c43a2087d7 WIP: autocomplete for label/ref 2017-05-24 10:07:14 +01:00
Paulo Reis
8dfb91fa6f Blur toggler after clicking. 2017-05-22 11:11:26 +01:00
James Allen
ba62206b91 Refactor project name validation into one place and restrict /s 2017-05-19 17:42:24 +01:00