Commit graph

1677 commits

Author SHA1 Message Date
Alasdair Smith
5806101bd0 Trigger events instead of calling cursor manager
This improves readability and prevents race conditions in compat
between Ace/CM
2018-07-10 16:05:01 +01:00
Alasdair Smith
da77c06774 Refactor saving cursor position to not use Ace event
This is will help with triggering CM correctly
2018-07-10 16:05:01 +01:00
Alasdair Smith
ba9fa9a0be Store first visible line instead of scrollTop
scrollTop is affected by changing viewport size and switching between
Ace and CM
2018-07-10 16:05:01 +01:00
Alasdair Smith
6c7e942470 Unbind unload listener when destroying editor 2018-07-10 16:05:01 +01:00
Alasdair Smith
e5ad2a8724 Abstract Ace-specific code to adapter 2018-07-10 16:05:01 +01:00
Alasdair Smith
2dc509f43d Fix memory leak setting up spell check
Switching docs would set up event listeners on Ace without tearing down
any old listeners, which could lead to a memory leak. This tears down
old listeners when detaching from the "old" doc
2018-07-10 12:25:13 +01:00
Hayden Faulds
158cb58e29 Merge pull request #734 from sharelatex/sk-handle-403-linked-files
When refreshing or creating linked files, exempt from 403-error-catcher
2018-07-06 15:09:28 +01:00
Shane Kilkelly
b6880550d5 When refreshing or creating linked files, exempt from 403-error-catcher 2018-07-06 11:29:21 +01:00
James Allen
dad4bad9eb Merge pull request #700 from sharelatex/ew-fix-undefined-last-name
fix undefined last name
2018-07-06 11:06:12 +01:00
Alasdair Smith
b2abcfc3f2 Extract debounced load to service, so can be injected 2018-07-04 15:14:29 +01:00
Alasdair Smith
1f9c1ca6c6 Extracts envs to separate file so they can be exported to rich text 2018-07-04 15:14:29 +01:00
Alasdair Smith
33742d447d Move top hundred snippets to snippets directory
Allows for more snippets in future. Also makes file name consistent
2018-07-04 15:14:29 +01:00
Alberto Fernández-Capel
a1c49b0cf9 Merge pull request #694 from sharelatex/sk-linked-files-warning-when-no-projects
Add a warning message when there are no other projects to choose.
2018-07-03 13:38:33 +01:00
Jessica Lawshe
a739348146 Move MathJax directive to a shared directory
MathJax parsing now on learn pages, and soon to be on the blog, so move
out of the `ide/chat` directive.
2018-06-27 17:46:35 -05:00
Jessica Lawshe
3e8168d32f Remove MathJax dependency injection 2018-06-27 17:31:11 -05:00
Ersun Warncke
193d497d66 fix undefined last name 2018-06-26 07:50:31 -04:00
James Allen
80d7c39044 Fix right click new and upload file options 2018-06-25 15:01:27 +01:00
Shane Kilkelly
b3d17fc753 Add a warning message when there are no other projects to choose. 2018-06-25 11:48:05 +01:00
Shane Kilkelly
f6424ada40 Merge pull request #655 from sharelatex/sk-linked-files-output-redux
Linked files from project output
2018-06-25 10:28:29 +01:00
Nate Stemen
e9f8cceabb fix syntax error 2018-06-22 10:23:33 -04:00
Shane Kilkelly
6058f3ef9b Refactor the LinkedFiles/Agent system, and track build_id for output files 2018-06-22 13:09:18 +01:00
Shane Kilkelly
54cdbd738c If selecting 'output.pdf', set the filename to project-name.pdf 2018-06-22 13:09:18 +01:00
Shane Kilkelly
67dcbff450 Remove linked-files items from the left-menu test controls 2018-06-22 13:09:18 +01:00
Shane Kilkelly
2cfc2b4738 Only show output files which are images or pdfs 2018-06-22 13:08:13 +01:00
Shane Kilkelly
6672a20c2b Enable switching between source and output files 2018-06-22 13:08:13 +01:00
Shane Kilkelly
64ec90f34f Move the isOutputFilesMode flag onto the scope 2018-06-22 13:08:13 +01:00
James Allen
5717496685 Create unified new file modal with linked files 2018-06-22 13:08:13 +01:00
Shane Kilkelly
2da1d57948 Clean up logging 2018-06-22 13:08:13 +01:00
Shane Kilkelly
ead245721b Mostly working selection of output files from another project 2018-06-22 13:08:13 +01:00
Shane Kilkelly
60ca298db3 WIP 2018-06-22 13:08:13 +01:00
James Allen
0c86a7dc9b Revert "Simplify package metadata check" 2018-06-19 08:43:27 +01:00
James Allen
b5e976f8a7 Merge pull request #663 from sharelatex/as-simplify-metadata-check
Simplify package metadata check
2018-06-19 08:38:03 +01:00
Nate Stemen
e7038f0a57 remove trailing } for all commands rather than relying on Helpers module 2018-06-18 15:08:25 -04:00
Nate Stemen
9f309e22a7 refactor AutoCompleteManager 2018-06-18 12:26:45 -04:00
Alasdair Smith
f9c074a31e Simplify check for when we are editing lines with metadata commands 2018-06-18 10:52:27 +01:00
Nate Stemen
b1c0552214 add ref command to snippets 2018-06-15 16:59:35 -04:00
Nate Stemen
4b1bc291cb misspelled variable completionAfterCursor 2018-06-15 10:31:51 -04:00
Nate Stemen
b8787e6e68 modify dropdown to trigger on command completion if possible 2018-06-15 08:56:03 -04:00
Henry Oswald
b24b110037 Merge pull request #647 from sharelatex/ho-clsi-domain
PDF download takes optional domain paramater
2018-06-13 11:30:17 +01:00
Henry Oswald
02110064f7 Merge branch 'master' into ho-clsi-domain 2018-06-13 10:32:51 +01:00
Shane Kilkelly
3baf0836bc Support project-linked-files originating from imported v1 projects 2018-06-13 10:02:54 +01:00
Jessica Lawshe
baa321fa1a Merge pull request #628 from sharelatex/ns-only-one-doc-env
only suggest one document environment per project
2018-06-12 08:44:14 -05:00
Henry Oswald
75c9489c06 PDF Downloads work, not tested on large pdf's yet 2018-06-08 17:17:00 +01:00
Nate Stemen
26385718e6 only suggest thebibliography once 2018-06-05 11:02:03 -04:00
Nate Stemen
863128a030 only suggest one document environment in project 2018-06-05 10:08:27 -04:00
Paulo Reis
8e5032fb34 Merge branch 'master' into pr-v2-history-ui 2018-06-05 10:55:42 +01:00
Paulo Reis
f858786f2d Add i18n. 2018-06-05 10:14:16 +01:00
hugh-obrien
063187b5fc add function to check for existance of folders 2018-05-31 17:03:41 +01:00
Shane Kilkelly
d3ae276091 Merge pull request #579 from sharelatex/sk-linked-files-from-project
Linked Files from Project
2018-05-31 11:08:08 +01:00
Paulo Reis
7cb4280a4d Remove commented-out code. 2018-05-30 15:18:15 +01:00
Alasdair Smith
d0b160d9a2 Rename flag for clarity 2018-05-30 11:55:09 +01:00
Paulo Reis
637c492e6e Merge branch 'master' into pr-v2-history-ui 2018-05-30 11:24:33 +01:00
Paulo Reis
8d2189f843 Support using both point-in-time and compare modes. 2018-05-29 16:50:15 +01:00
Shane Kilkelly
9e65e5e813 Fix loading of Rich Text page in Test Controls 2018-05-29 10:46:22 +01:00
Shane Kilkelly
dccac6302e Use a decorateLinkedFileData function on server to add project name 2018-05-29 10:07:31 +01:00
Shane Kilkelly
ce147b012f Cleaner unpacking of data from scope 2018-05-25 16:03:45 +01:00
Shane Kilkelly
105d858155 Move waitFor into an angular service 2018-05-25 13:02:58 +01:00
Shane Kilkelly
cfc17d56e8 Use a promise (with Angular's $q) in waitFor 2018-05-25 11:42:13 +01:00
Shane Kilkelly
8be4279165 Fix a broken if-else-if statement 2018-05-25 10:56:32 +01:00
Shane Kilkelly
e33b7b1a49 Use waitFor when restoring a file in v2 history 2018-05-25 10:37:04 +01:00
Shane Kilkelly
19d8700947 Use waitFor when refreshing the binary file view 2018-05-25 10:36:39 +01:00
Shane Kilkelly
b2a68cb911 Merge pull request #582 from sharelatex/sk-add-test-controls-panel
Add a "Test Controls" section to the left-panel
2018-05-24 11:41:10 +01:00
Shane Kilkelly
73a45b15ce Make string replace op safer 2018-05-24 11:35:55 +01:00
Shane Kilkelly
de1f33a720 Remove 'private' methods from the controller scope 2018-05-24 11:32:44 +01:00
Shane Kilkelly
16419847ae Fix linked-file-types check when opening modal 2018-05-24 11:32:20 +01:00
Shane Kilkelly
656d40ac39 Better view refresh after refreshing linked file 2018-05-24 11:31:50 +01:00
Shane Kilkelly
561b62f7db Add a hidden 'Test Controls' section to the left-menu.
This is to be used for hidden features that are not yet ready to ship,
and would otherwise be hidden behind a console command.
Append `?tc=true` to the project url to reveal this panel.
2018-05-23 12:37:42 +01:00
Paulo Reis
fb33fc6c30 Add loading indicators; handle binary files; keep selected file across points in time. 2018-05-23 12:14:27 +01:00
Shane Kilkelly
f5dd94ca1d Remove test code from FileTreeManager 2018-05-23 11:46:37 +01:00
Paulo Reis
f4f3a4375b Add history toolbar (just scaffolding); show files at point in time. 2018-05-22 15:40:57 +01:00
Shane Kilkelly
691eec48ba Merge branch 'master' into sk-linked-files-from-project 2018-05-22 15:39:09 +01:00
Paulo Reis
81c93e11d0 History file tree integration with the backend. 2018-05-21 15:13:34 +01:00
Paulo Reis
a716f9ccd3 Integrate history file tree in the UI. 2018-05-21 15:12:47 +01:00
Paulo Reis
6701b4413b Add history file tree components. 2018-05-21 15:12:03 +01:00
Shane Kilkelly
1f2ee4e3fc Show error if refresh fails 2018-05-21 11:02:12 +01:00
Alasdair Smith
309792401f Re-focus editor after clicking suggestion 2018-05-21 10:35:43 +01:00
Alasdair Smith
c2d7809e05 Add removeWord so that learning word removes all highlights for given word 2018-05-18 14:23:36 +01:00
Alasdair Smith
a719ac6e6e IE11 doesn't support Array.find so use underscore instead 2018-05-18 13:33:06 +01:00
Alasdair Smith
681e67ecea Be more consistent with naming 2018-05-18 11:29:27 +01:00
Alasdair Smith
846f27f0ad Clear highlights that are "touching" the cursor on change
This means that correcting a mistake won't wait until the request has resolved and that only the word at the end of the line will have it's spelling
highlight removed instead of the entire row
2018-05-18 11:29:27 +01:00
Alasdair Smith
2be023c731 Prevent spell error marker adding newly typed characters 2018-05-18 11:29:27 +01:00
Alasdair Smith
9fa85400b3 HighlightedWordManager is more naive about tracking position
We are relying entirely on Ace's tracking of markers with the anchor trick.
This means that we don't have to apply changes to ensure that the word manager
data structure tracks which row the highlights are on. This is traded off
against slightly less efficient searching/removing
2018-05-18 11:29:27 +01:00
Alasdair Smith
ebf1b7c84c Extract SpellCheckAdapter to separate file 2018-05-18 11:29:27 +01:00
Alasdair Smith
d2bba0eb60 Fix firefox not closing contextmenu correctly 2018-05-18 11:29:27 +01:00
Alasdair Smith
034531d323 Replace word with suggestion and learn word 2018-05-18 11:29:27 +01:00
Alasdair Smith
cf123ce857 Extract spellMenu component and use when showing spell suggestions 2018-05-18 11:29:27 +01:00
Alasdair Smith
e6ffaaa489 Handle contextmenu for spelling 2018-05-18 11:29:27 +01:00
Alasdair Smith
8de2267824 Adapt aceEditor to use new spell check manager with adapter 2018-05-18 11:29:27 +01:00
Alasdair Smith
22e41cdce7 Simplify word manager to use Range + Anchor to automatically keep marker positions up-to-date
Re-implement highlighted word manager to be simpler
2018-05-18 11:29:16 +01:00
Alasdair Smith
37ca7b54a6 Re-implement spell check manager with adapter to abstract away editor 2018-05-18 11:29:16 +01:00
Shane Kilkelly
2b99080ed3 Fix rendering of long previews, stop cutting off last line in short ones 2018-05-18 11:25:01 +01:00
Shane Kilkelly
4acd55b1c6 More tidy unpacking of data 2018-05-18 11:07:59 +01:00
Shane Kilkelly
16106df2f0 Remove obsolete code 2018-05-18 11:05:20 +01:00
Shane Kilkelly
94a599d530 Fix the reloading of file view after refreshing linked file 2018-05-18 10:35:02 +01:00
Shane Kilkelly
9624e2a290 Record the source project display name, to render with the file 2018-05-16 13:44:21 +01:00
Shane Kilkelly
f533674dbd Clean up 2018-05-16 13:26:59 +01:00
Shane Kilkelly
7292602167 More fine-grained loading spinners 2018-05-16 11:49:10 +01:00
Shane Kilkelly
e3bc6cac9e Auto-set filename based on selected file 2018-05-16 11:12:00 +01:00
Shane Kilkelly
103832af7d Functioning project-linked-file importer 2018-05-16 10:29:51 +01:00
Shane Kilkelly
9c33f3f8bc WIP: Project Linked File modal 2018-05-15 16:22:47 +01:00