Move waitFor into an angular service

services/web/public/coffee/ide.coffee

@@ -35,6 +35,7 @@ define [
 	"directives/videoPlayState"
 	"services/queued-http"
 	"services/validateCaptcha"
+	"services/wait-for"
 	"filters/formatDate"
 	"main/event"
 	"main/account-upgrade"
@@ -229,20 +230,4 @@ define [
 				ide.$scope.project.publicAccesLevel = data.newAccessLevel
 				$scope.$digest()
 
-		ide.waitFor = (testFunction, timeout, pollInterval=500) ->
-			iterationLimit = Math.floor(timeout / pollInterval)
-			iterations = 0
-			$q(
-				(resolve, reject) ->
-					do tryIteration = () ->
-						if iterations > iterationLimit
-							return reject(new Error("waiting too long, #{JSON.stringify({timeout, pollInterval})}"))
-						iterations += 1
-						result = testFunction()
-						if result?
-							resolve(result)
-						else
-							setTimeout(tryIteration, pollInterval)
-			)
-
 	angular.bootstrap(document.body, ["SharelatexApp"])

services/web/public/coffee/ide/binary-files/controllers/BinaryFileController.coffee

@@ -2,7 +2,7 @@ define [
 	"base"
 	"moment"
 ], (App, moment) ->
-	App.controller "BinaryFileController", ["$scope", "$rootScope", "$http", "$timeout", "$element", "ide", ($scope, $rootScope, $http, $timeout, $element, ide) ->
+	App.controller "BinaryFileController", ["$scope", "$rootScope", "$http", "$timeout", "$element", "ide", "waitFor", ($scope, $rootScope, $http, $timeout, $element, ide, waitFor) ->
 
 		TWO_MEGABYTES = 2 * 1024 * 1024
 
@@ -56,7 +56,7 @@ define [
 					{ new_file_id } = data
 					$timeout(
 						() ->
-							ide.waitFor(
+							waitFor(
 								() ->
 									ide.fileTreeManager.findEntityById(new_file_id)
 								5000

services/web/public/coffee/ide/history/controllers/HistoryV2DiffController.coffee

@@ -1,7 +1,7 @@
 define [
 	"base"
 ], (App) ->
-	App.controller "HistoryV2DiffController", ($scope, ide, event_tracking) ->
+	App.controller "HistoryV2DiffController", ($scope, ide, event_tracking, waitFor) ->
 		$scope.restoreState =
 			inflight: false
 			error: false
@@ -25,7 +25,7 @@ define [
 
 		openEntity = (data) ->
 			{id, type} = data
-			ide.waitFor(
+			waitFor(
 				() ->
 					ide.fileTreeManager.findEntityById(id)
 				3000

services/web/public/coffee/services/wait-for.coffee

@@ -0,0 +1,20 @@
+define [
+	"base"
+], (App) ->
+	App.factory "waitFor", ($q) ->
+		waitFor = (testFunction, timeout, pollInterval=500) ->
+			iterationLimit = Math.floor(timeout / pollInterval)
+			iterations = 0
+			$q(
+				(resolve, reject) ->
+					do tryIteration = () ->
+						if iterations > iterationLimit
+							return reject(new Error("waiting too long, #{JSON.stringify({timeout, pollInterval})}"))
+						iterations += 1
+						result = testFunction()
+						if result?
+							resolve(result)
+						else
+							setTimeout(tryIteration, pollInterval)
+			)
+		return waitFor