github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-23 02:55:13 -04:00
Code Issues Projects Releases Packages Wiki Activity
10211 commits 3 branches 7 tags 222 MiB
Commit graph

2370 commits

Author SHA1 Message Date
Jakob Ackermann
dc576baa05 Merge pull request #3472 from overleaf/jpa-fix-flaky-assertion 
[HealthCheckControllerTests] harden assertion on timed-out http requests

GitOrigin-RevId: f6e8346b2f9744e7f4d11b8ac6164c236d3d7e74
 2020-12-10 03:04:29 +00:00
Jakob Ackermann
cb9d207ba0 Merge pull request #3427 from overleaf/jpa-rewite-smoke-tests 
[SmokeTests] rewrite

GitOrigin-RevId: eda39db6b339d997f5669cb9bfca2aefe7d96699
 2020-12-10 03:04:18 +00:00
Jakob Ackermann
fae53738f5 Merge pull request #3423 from overleaf/as-ta-sentry-fixes 
Improve loading of Sentry reporter in frontend

GitOrigin-RevId: fc05aa48ad0e816b4ef0f5dafb6cf00525a28223
 2020-12-04 03:05:43 +00:00
Paulo Jorge Reis
34f7c709f0 Merge pull request #3425 from overleaf/jpa-cookie-domain-in-ci 
[misc] setup cookieDomain and siteUrl for acceptance tests

GitOrigin-RevId: a57a9c4f44186848ccda34316071cd65ac387310
 2020-12-03 03:04:33 +00:00
Paulo Jorge Reis
4e74fb2694 Log pane improvements (#3418) 
* Ordering of log entries in the new errors UI

* Don't show the expand-collapse widget when not needed; smaller font size in the raw log output

* Expose log actions in the log pane.

* Use "This project" instead of "Your project" in the new errors UI

* Better handling of long log messages; left-ellipsize the file/line number button

* Make log location more button-like; add tooltip when needed.

* Add a PDF expand button to the toolbar.

* Add a stop compilation button to the new compile UI

* Use aria-label for button accessible text; improve handling of long filenames in the log location button

* Set max-height correctly for the logs pane dropdown

* Avoid changing raw logs sizing when expanded and collapsed

* Add comment on the solution for right-to-left text and ellipsis

* Improve logs pane actions

GitOrigin-RevId: 4098d77a9ee6d333644906876b9ff27035b79319
 2020-12-03 03:04:28 +00:00
Jessica Lawshe
8b4659e700 Merge pull request #3409 from overleaf/jel-inst-leavers-db 
Add reconfirmedAt to UserSchema

GitOrigin-RevId: 543b57236bbf964c72c6587362a6b6d6b7b7caa6
 2020-12-01 03:04:39 +00:00
Jakob Ackermann
3ce57ed442 Merge pull request #3014 from overleaf/ns-delete-project-history-cleanup 
Decaf cleanup HistoryController

GitOrigin-RevId: e5df4cde30d8b9e65062e1484699326e96c4eb92
 2020-12-01 03:04:28 +00:00
Jakob Ackermann
1fe7eaab90 Merge pull request #3417 from overleaf/ta-outline-noinfo 
Remove New Feature Info from Outline

GitOrigin-RevId: 61c737d77ffa020d291da5ab1022dfd2057141f6
 2020-12-01 03:04:23 +00:00
Jakob Ackermann
b1eb510ce0 Merge pull request #3171 from overleaf/bg-end-to-end-check 
add end-to-end check on unacked edits when user is typing

GitOrigin-RevId: 5914eff1f391f18d4e0ab38a39cf284fbdb28480
 2020-12-01 03:04:13 +00:00
Brian Gough
cde6160973 Merge pull request #3421 from overleaf/bg-fix-health-checks-for-web-closed 
fix load balancer health checks for web-closed

GitOrigin-RevId: f46ecec4539740bc4f0324944b2b4d6273025211
 2020-12-01 03:04:08 +00:00
Jakob Ackermann
6eeb7857e3 Merge pull request #3390 from overleaf/jpa-faster-unit-tests 
[perf] faster unit tests

GitOrigin-RevId: 188b8f3752638fde7a27a8d83b416bb9a6e3c95e
 2020-11-28 03:04:01 +00:00
Timothée Alby
420aa4a657 Merge pull request #3232 from overleaf/ta-file-tree-react 
React File Tree

GitOrigin-RevId: fb3141ba8cd9ca0d68e87edb74764a360144c8fe
 2020-11-27 03:05:05 +00:00
Jessica Lawshe
d7f32179e4 Update download dropdown style (#3399) 
* Update translation

* Move dropdown header to top of list

* Do not wrap header in download dropdown

GitOrigin-RevId: 326428272592fc54f9915d5946877e59a60f967e
 2020-11-27 03:04:44 +00:00
Paulo Jorge Reis
081f4212a8 Add error and validation issues (#3400) 
* Remove references to the duplicatePaths validation

* Make the log entries more generic, to support validation and CLSI errors

* Add validation issues to the new logs UI

* Add CLSI errors to the new logs UI

* Update tests; accessibility fixes

* Disable PDF viewing when compile fails; address PR feedback.

* Add accessible description for error and validation failed compiles

GitOrigin-RevId: 8b0597af8857712d47c20e4915470e8e745bb315
 2020-11-27 03:04:38 +00:00
Miguel Serrano
3b1c4e19a4 Merge pull request #3300 from overleaf/msm-chat-react-store 
React chat store

GitOrigin-RevId: 204009eb5798b02a41e621b33b05ef0cb9d10b15
 2020-11-25 03:04:29 +00:00
Paulo Jorge Reis
01cc057f6b Add raw logs to new errors UI (#3378) 
* Add raw logs to new compile UI

* Address feedback

* Update test/frontend/features/preview/components/preview-logs-pane.test.js

Co-authored-by: John Lees-Miller <jdleesmiller@gmail.com>

Co-authored-by: John Lees-Miller <jdleesmiller@gmail.com>
GitOrigin-RevId: af9c653e13d93434467b122f4c388493e786212c
 2020-11-17 03:04:16 +00:00
Paulo Jorge Reis
619ec15309 Add first error popup (#3369) 
* Add first error popup

* Address PR feedback

GitOrigin-RevId: e924b3e6096584de6f363aae70a62328cd3de83d
 2020-11-17 03:04:11 +00:00
Jessica Lawshe
d138837049 Merge pull request #3367 from overleaf/ho-ms-jel-chat-a11y 
Improve chat accessibility

GitOrigin-RevId: 853da57460c7e3a18abbe1130553e34bd661b6b3
 2020-11-10 03:04:40 +00:00
Jessica Lawshe
21ffe27bdd Merge pull request #3330 from overleaf/jel-toolbar-btns 
Hide toolbar text and show tooltip when out of space

GitOrigin-RevId: 5a73b69e7d92695c4f8691a747307908550e3790
 2020-11-10 03:04:35 +00:00
Simon Detheridge
da8663fd0f Merge pull request #3372 from overleaf/jpa-archive-docs-on-soft-delete 
[ProjectDeleter] flush docs out of mongo when soft-deleting a project

GitOrigin-RevId: 52f3e1298af5ca481ba9b27b18c9190063019988
 2020-11-10 03:04:30 +00:00
Simon Detheridge
94092c905b Merge pull request #3370 from overleaf/jpa-replace-count 
[misc] replace mongo .count queries

GitOrigin-RevId: 7963286b4d84d1f03978f3212e92bb491eec6b74
 2020-11-10 03:04:25 +00:00
Simon Detheridge
5201d98752 Merge pull request #3365 from overleaf/sk-dropbox-email-fix 
Conditionally send email in Dropbox unlinkAccount

GitOrigin-RevId: 0f3d2fd34b89aa3f3a96f7ca66fee5d69d07ec2f
 2020-11-08 03:04:33 +00:00
Jakob Ackermann
c6a853c7ed Merge pull request #3332 from overleaf/pr-new-log-entries-ui 
New log entries ui

GitOrigin-RevId: a13ccac04197e7c8f3777750b956d550c95c8f0d
 2020-11-06 03:04:59 +00:00
Jakob Ackermann
0a5cc39671 Merge pull request #3345 from overleaf/jpa-i18n-escape-vars 
[misc] i18n escape vars

GitOrigin-RevId: 5b0a8ca7229f3817c823b126203c8597f7fd0913
 2020-11-06 03:04:54 +00:00
Jakob Ackermann
67b8719bf2 Merge pull request #3354 from overleaf/jpa-fix-clone-invalid-root-doc 
[ProjectDuplicator] silently ignore an invalid rootDoc when duplicating

GitOrigin-RevId: 93b4d4193fab25484525f8ab2c692e047cf0da30
 2020-11-06 03:04:48 +00:00
Eric Mc Sween
d5a49038df Merge pull request #3302 from overleaf/em-analytics-queues 
Send analytics events through a queue

GitOrigin-RevId: b9eb12e469faf16e32aba5fae665c5f85dfbc52c
 2020-11-05 03:05:06 +00:00
Shane Kilkelly
dff706bf67 Merge pull request #3334 from overleaf/jpa-msm-rename-css-class 
[misc] rename avoid-auto-linking class to force-overleaf-style in emails

GitOrigin-RevId: 9111a38afb550f3397555ef68d1e4170208eb121
 2020-11-05 03:04:48 +00:00
Shane Kilkelly
0450c52187 Merge pull request #3335 from overleaf/jpa-cmg-archived-script-logging 
Update archiving script for re-run

GitOrigin-RevId: 0251ca8d6f864f697395deac9470398519b704de
 2020-11-05 03:04:30 +00:00
Shane Kilkelly
405a221187 Merge pull request #3318 from overleaf/sk-remove-events-module 
Re-work unlinking dropbox when subscription ends

GitOrigin-RevId: 92cf5713d57e157cf544d0470d5fdb6e4010d5cd
 2020-11-05 03:04:24 +00:00
Jakob Ackermann
654abb3b47 Merge pull request #3355 from overleaf/jpa-use-count-again 
[misc] mongodb: use deprecated db.collection.count again

GitOrigin-RevId: 93dc05651747ca49b0e26547a330682f85ad9cef
 2020-11-04 03:04:26 +00:00
Jakob Ackermann
87634be542 Merge pull request #3351 from overleaf/revert-3348-revert-3298-jpa-re-land-mongoose-latest 
[misc] re-land: remove mongojs and bump mongoose

GitOrigin-RevId: eba9f80fbd58dbb8aed131fead3ec0b928a555aa
 2020-11-04 03:04:21 +00:00
Jakob Ackermann
e249a2e5be Merge pull request #3348 from overleaf/revert-3298-jpa-re-land-mongoose-latest 
Revert "[misc] re-land: remove mongojs and bump mongoose"

GitOrigin-RevId: 45a284435c88898d96769ab258651fb8d6d20ff5
 2020-11-03 03:05:09 +00:00
Jessica Lawshe
6a837ce457 Merge pull request #3311 from overleaf/jel-button-test 
Add required prop to button test

GitOrigin-RevId: c653b0429e4b9e9921e3e913fc0ff5ea445615a3
 2020-11-03 03:05:03 +00:00
Jessica Lawshe
edd43228a1 Merge pull request #3305 from overleaf/jel-download-dropdown-divider 
Only show header/divider if download list is separated

GitOrigin-RevId: 832c53bf973e6615a5c2ef526a8fad0835913bcc
 2020-11-03 03:04:58 +00:00
Jakob Ackermann
28fe397f38 Merge pull request #3298 from overleaf/jpa-re-land-mongoose-latest 
[misc] re-land: remove mongojs and bump mongoose

GitOrigin-RevId: 02f78d52ffc2d373c8c0bc4860d3b2326a46f5c9
 2020-11-03 03:04:52 +00:00
Jakob Ackermann
15fd090e7a Merge pull request #3325 from overleaf/jpa-session-cleanup 
[UserEmailsController] clear sessions after changing the primary email

GitOrigin-RevId: 319b483a3c2851c37c0a340ba9c43a86225a9246
 2020-10-31 03:05:36 +00:00
Christopher Hoskin
1e8598a8d9 Merge pull request #3331 from overleaf/csh-issue-3661-bump-agents 
Update metrics module

GitOrigin-RevId: bdef141035f277ce4863f14f8a6e166d710b1111
 2020-10-31 03:05:30 +00:00
Eric Mc Sween
14f8a3ca72 Merge pull request #3329 from overleaf/em-fix-smoke-tests 
Fix smoke tests when Settings.web is unset

GitOrigin-RevId: 873ee49a8bd57ed5f4c5bd0a551b724530424711
 2020-10-28 03:05:23 +00:00
Miguel Serrano
df37668180 Merge pull request #3267 from overleaf/msm-react-chat-tests 
React chat tests

GitOrigin-RevId: e3b4d5b7cb2657d9aad7e1006c18db4e6c0d8a3f
 2020-10-28 03:04:53 +00:00
Miguel Serrano
120df0bfa2 Merge pull request #3314 from overleaf/jpa-i18n-safe-html-substitute 
[misc] i18n: safe html substitute

GitOrigin-RevId: be74605d24084b419324509a403933cf71ed1c8a
 2020-10-28 03:04:27 +00:00
Shane Kilkelly
e9f7a17093 Merge pull request #3234 from overleaf/sk-fix-password-validation-email 
Overhaul password validation

GitOrigin-RevId: a591c4e192e30a0ac053eab6f80627543a8a92fe
 2020-10-23 02:04:39 +00:00
Jakob Ackermann
85d37f8990 Merge pull request #3308 from overleaf/revert-3278-as-prop-type-test-fail 
Revert "Make prop-type errors fail the frontend tests"

GitOrigin-RevId: 903fba2a6f22d392ba748ff334db0ddbc63ac896
 2020-10-22 02:04:54 +00:00
Jakob Ackermann
21070a01a8 Merge pull request #3303 from overleaf/jpa-fix-user-model 
[model] User: third-party-references is owner of .refProviders entries

GitOrigin-RevId: 8ac81869657f4fe7615928eae2ad3d93d24cef0f
 2020-10-22 02:04:43 +00:00
Jakob Ackermann
a124c3e4f4 Merge pull request #3278 from overleaf/as-prop-type-test-fail 
Make prop-type errors fail the frontend tests

GitOrigin-RevId: 4676239be8bfc541397740bdbe4044751e088c82
 2020-10-22 02:04:32 +00:00
Jessica Lawshe
5f59437ef9 Merge pull request #3297 from overleaf/jel-unlink-email 
Update unlinked email wording

GitOrigin-RevId: 976349f1003e6b53ab04b27870356d9452464a39
 2020-10-21 02:04:42 +00:00
Jessica Lawshe
6fe36b6acb Merge pull request #3282 from overleaf/jel-download-dropdown-menu 
Add output download dropdown

GitOrigin-RevId: 1f97f0d681679268d28796fbc8251ffbc6e98433
 2020-10-21 02:04:32 +00:00
Jessica Lawshe
f8a8c9bbd6 Merge pull request #3242 from overleaf/jel-add-recompile-from-scratch 
Add recompile from scratch option

GitOrigin-RevId: 59836df9049e307acb11824058024919409ea4a4
 2020-10-21 02:04:27 +00:00
Paulo Reis
4f847b35d3 Fix tests. 
GitOrigin-RevId: 18e4d9e58922aae00e603269c907499da949d27f
 2020-10-16 02:05:06 +00:00
Paulo Reis
876c292d22 Add compile status indicator to new React-based errors UI. 
GitOrigin-RevId: 545953e156d589a56ffd038bb7a40bba97770d06
 2020-10-16 02:04:45 +00:00
Simon Detheridge
c257b9695a Merge pull request #3277 from overleaf/revert-3257-jpa-mongoose-latest 
Revert "[misc] upgrade mongoose to the latest version"

GitOrigin-RevId: d5957fca68be65a08a687476742ffbb9c3cb86e8
 2020-10-13 02:04:31 +00:00
Simon Detheridge
dba5127856 Merge pull request #3257 from overleaf/jpa-mongoose-latest 
[misc] upgrade mongoose to the latest version

GitOrigin-RevId: cc612312e1661a92907dd8d42a32aeccb8cdb62d
 2020-10-13 02:04:26 +00:00
Alasdair Smith
69521047e2 Merge pull request #3275 from overleaf/as-fix-confirmed-emails-query 
Fix slow query for user with confirmed emails

GitOrigin-RevId: aec3429073bf45e192ca8b0b4a2ac90ebf22b510
 2020-10-13 02:04:05 +00:00
Jakob Ackermann
a096d98956 Merge pull request #3193 from overleaf/jpa-mongodb-native-acceptance-tests 
[misc] migrate the acceptance tests to the native mongo driver

GitOrigin-RevId: 5ec8605cafb28cc9cfeb85d7ee0d1b567cfe49ba
 2020-10-09 02:05:03 +00:00
Jessica Lawshe
06316a0f56 Merge pull request #3220 from overleaf/jel-link-ieee 
Move link/unlink SSO audit log entry

GitOrigin-RevId: 1b912cc58957af7e80628f3f955f01c2a641812d
 2020-10-07 02:04:34 +00:00
Jessica Lawshe
1ca50eeb98 Merge pull request #3179 from overleaf/jel-remove-sudo-mode 
Remove SudoMode

GitOrigin-RevId: 9419f9b28e5051a1c5abd29f498f72448d1afd33
 2020-10-07 02:04:29 +00:00
Jakob Ackermann
79bdc60743 Merge pull request #3262 from overleaf/jpa-global-query-normalize-helper 
[misc] add a helper for normalizing queries and detecting ObjectIds

GitOrigin-RevId: 4f0ac53219ab5853b5499447334724c6c39c6303
 2020-10-07 02:04:24 +00:00
Jakob Ackermann
0c6e12a5cb Merge pull request #3189 from overleaf/jpa-mongodb-latest 
[misc] upgrade mongodb package and run codemod for find projections

GitOrigin-RevId: 01291b3095779abe045e39b82f071ac84285a508
 2020-10-06 02:04:39 +00:00
Jakob Ackermann
da9f966ff0 [misc] prepare acceptance tests for mismatching ObjectId types (#3188) 
- helpers/User: UserUpdater cannot handle foreign ObjectIds. Instead use
  `mongoUpdate`, which in turn uses the user id which
  `setExtraAttributes` sets -- hence the reordering of calls.
- CollabratecTests: use chaId for id comparison.
- ProjectStructureMongoLockTest: use chaId for id comparison.
- UserHelper: less generic updateUser -- wrap the passed ObjectId

GitOrigin-RevId: b16e2b66dcb3dd5f0a842ca5e55fa661abe9035f
 2020-10-06 02:04:34 +00:00
Jakob Ackermann
b3197b5f12 [misc] back-fill stubbing of mongodb package in sandboxed-module imports (#3209) 
* [misc] back-fill stubbing of mongodb package in sandboxed-module imports

Unit tests are about 10 percent faster: 9m16s vs 10m8s.

* [misc] stubs: app code should have access to the ObjectId only

GitOrigin-RevId: 9a52186e190863c9463b3aeb98c3db68011926e4
 2020-10-06 02:04:22 +00:00
Jakob Ackermann
e3c6637339 Merge pull request #3187 from overleaf/jpa-mongodb-native 
[misc] migrate the app to the native mongo driver

GitOrigin-RevId: 9030b18c4cf62e3a01d3d8f450bf0e02f9f89c22
 2020-10-02 02:04:18 +00:00
Jessica Lawshe
2a3cb615ee Merge pull request #3241 from overleaf/jpa-speedup-acceptance-tests 
[misc] speedup the ConvertArchivedState test suite

GitOrigin-RevId: e7d6471955aabbc6af76e27fdf23d97e2fd87901
 2020-09-30 02:04:46 +00:00
Jessica Lawshe
562fb35416 Merge pull request #3211 from overleaf/jel-new-cta-email-projectInvite 
Convert projectInvite to new email handling

GitOrigin-RevId: 88b6383832ab12b524890532a120c6f2f0f28c8c
 2020-09-30 02:04:40 +00:00
Jessica Lawshe
a6be3179fd Merge pull request #3215 from overleaf/jel-new-cta-email-registered 
Convert registered email to new email handling

GitOrigin-RevId: a2f99c65bdaee1287a0353e66cfc5a7768fdbcc8
 2020-09-30 02:04:35 +00:00
Jessica Lawshe
35897cf492 Merge pull request #3221 from overleaf/jel-institution-sso-email 
Note which institution email was linked/unlinked in email alert

GitOrigin-RevId: 7e5ef743c8ec8b12c14f833fdd2b01676c95c1b6
 2020-09-30 02:04:28 +00:00
Jessica Lawshe
9d3f2eb7dc Merge pull request #3227 from overleaf/jel-security-email-alerts 
Move security alert handling to private function

GitOrigin-RevId: a59b6b0802986b2caa9e9715d80225eb11b163a9
 2020-09-30 02:04:23 +00:00
Jakob Ackermann
12b407c18b Merge pull request #3186 from overleaf/jpa-mongodb-native-prep 
[misc] mongodb: use findOne and find().toArray()

GitOrigin-RevId: 52457b1a73c1b49ff78ff9b3096dd80e330fcf25
 2020-09-29 02:05:52 +00:00
Simon Detheridge
fdcf327ae7 Merge pull request #3231 from overleaf/jpa-hide-internal-error-messages 
[misc] PasswordResetController: do not expose internal error messages

GitOrigin-RevId: 9eca5e7f5367559d5340363ef859589e218e817f
 2020-09-29 02:05:30 +00:00
Alasdair Smith
394f160679 Merge pull request #2963 from overleaf/cmg-archive-state-script 
Script to convert old archived state into new array state

GitOrigin-RevId: 64cd3a236dc627f922488e1fa9d8aa2e7df1eb15
 2020-09-27 02:05:32 +00:00
Alasdair Smith
0d78719320 Merge pull request #3224 from overleaf/ta-frontend-tests-lint 
Run Lint Test Rules on Frontend Tests

GitOrigin-RevId: 03d3618eab2c6d2822233607da3ffa64ac132cd0
 2020-09-27 02:05:27 +00:00
Jakob Ackermann
9789a158a7 Merge pull request #3183 from overleaf/jpa-add-missing-db-stub 
[misc] unit tests: add missing module stubs for (transient) db imports

GitOrigin-RevId: 9a16f1ab9b42608d839922fb339189697bc9ed22
 2020-09-25 02:04:25 +00:00
Jakob Ackermann
018a44eeb5 Merge pull request #3185 from overleaf/jpa-normalize-mongo-imports 
[misc] normalize mongo imports

GitOrigin-RevId: ac653d9982e0d36736b90f4c03d4c00be88ea76a
 2020-09-25 02:04:20 +00:00
Jessica Lawshe
d87ad11719 Merge pull request #3210 from overleaf/ta-icon-component 
Create Icon Component in React

GitOrigin-RevId: 34161b3afa2c00dbca2423b1e5a42b29846fa6e4
 2020-09-22 02:05:09 +00:00
Jessica Lawshe
739b301419 Merge pull request #3198 from overleaf/jel-new-cta-email-testEmail 
Convert testEmail to new email handling

GitOrigin-RevId: 4230875a360b03de5e5dbaff83fb99187ef745b1
 2020-09-22 02:05:03 +00:00
Jessica Lawshe
dfb58a69c4 Merge pull request #3197 from overleaf/jel-new-cta-email-subscription-alerts 
Convert subscription emails to new email handling

GitOrigin-RevId: bd10389aca073a1a21778af8c362e9254ddc70f1
 2020-09-22 02:04:57 +00:00
Jessica Lawshe
e1bcf93374 Merge pull request #3212 from overleaf/jel-new-cta-email-confirmEmail 
Convert confirmEmail to new email handling

GitOrigin-RevId: 66d1bd7503d36cc74adfadc983003c31c2c57bd1
 2020-09-22 02:04:50 +00:00
Jessica Lawshe
d23df6dd99 Merge pull request #3214 from overleaf/jel-new-cta-email-verifyEmailToJoinTeam 
Convert verifyEmailToJoinTeam to new email handling

GitOrigin-RevId: f4d19aff26c07bb04d8f414805edbf79baec6e0c
 2020-09-22 02:04:45 +00:00
Chrystal Maria Griffiths
512e76ef4e Merge pull request #3195 from overleaf/ta-outline-tests 
More outline tests

GitOrigin-RevId: d0f4d6137cf0bf5f408801983658a79bf230967d
 2020-09-19 02:04:55 +00:00
Chrystal Maria Griffiths
170f996e5f Merge pull request #3199 from overleaf/ta-outline-parser-tests 
Add Outline Parser Tests

GitOrigin-RevId: 2f487c7c70bc7441a828922f8273351bffcdfef2
 2020-09-19 02:04:49 +00:00
Chrystal Maria Griffiths
81ddc5c382 Merge pull request #3205 from overleaf/ta-as-local-storage 
New Custom LocalStorage Implementation

GitOrigin-RevId: f80fd5f9f24af02690a51cf3c57f61f95b90e98e
 2020-09-19 02:04:43 +00:00
Chrystal Maria Griffiths
e6307237e4 Merge pull request #3207 from overleaf/jpa-drop-console-log 
[misc] drop console.log calls in tests

GitOrigin-RevId: 156c94761e55648a92cf98d4c3cce20abb5de623
 2020-09-19 02:04:38 +00:00
Jakob Ackermann
435af75ef7 Merge pull request #3163 from overleaf/as-jpa-i18n-cleanup 
[misc] Translations cleanup

GitOrigin-RevId: 46bf1142bb9415eeebf638c120597996aaa55f8b
 2020-09-18 02:04:41 +00:00
Shane Kilkelly
0642922490 Merge pull request #3190 from overleaf/jel-new-cta-email-body 
New CTA email body

GitOrigin-RevId: 6712980ed8b5dbbddfcf17c4263b13d62aa67ac0
 2020-09-17 02:04:38 +00:00
Shane Kilkelly
df32ea6dca Merge pull request #3112 from overleaf/ew-send-project-owner-id-to-tpds 
add project_owner_user_id to tpds requests

GitOrigin-RevId: 3b83d6dd2eaa00e100e7fa84e403318a44282747
 2020-09-17 02:04:29 +00:00
Timothée Alby
ede3b6a248 Merge pull request #3152 from overleaf/ta-jpa-confirm-entitlement 
Send Entitlement for Affiliations During Domains Confirmation

GitOrigin-RevId: 9d6b41022adfdb5e1a797b9471830014b1ef43e3
 2020-09-16 02:05:03 +00:00
Timothée Alby
3f99a5ca73 Merge pull request #3157 from overleaf/ta-outline-item-tests 
Outline Item Tests

GitOrigin-RevId: fa8c564ce75e3abfa9b977691635392e87cdde81
 2020-09-16 02:04:31 +00:00
Jessica Lawshe
aee83bc0cf Merge pull request #3173 from overleaf/jel-institution-sso-audit-log 
Update audit log when institution SSO is linked/unlinked

GitOrigin-RevId: 264ffbed025dccb4dd202f86afe545c3bf0c1f76
 2020-09-15 02:04:24 +00:00
Timothée Alby
d9c435a77a Merge pull request #2957 from overleaf/ew-validate-saml-email 
Validate saml email before register

GitOrigin-RevId: 6dcf3bccd280abd7bd3ced2d4fd2f69c590f74c1
 2020-09-02 02:05:07 +00:00
Simon Detheridge
4415f77b18 Merge pull request #3140 from overleaf/ho-swallow-deactive-project-err 
if deactivateProject errors, continue the deactivateOldProjects jobs

GitOrigin-RevId: b3c2584e0a042cb3c78e609314c320a9b657640c
 2020-08-27 02:04:13 +00:00
Jessica Lawshe
bde7ef600f Merge pull request #3138 from overleaf/jel-csrf-fix 
Fix validateToken signature

GitOrigin-RevId: fbedaa76ec0fa2134a08aa43c28c3756f8a2afe6
 2020-08-25 02:04:34 +00:00
Timothée Alby
cc218c98c2 Merge pull request #3098 from overleaf/jel-dropbox-tidy 
Tidy DropboxUserController and DropboxHandler

GitOrigin-RevId: f492b35af06d02b6401b99467e887a92d5335b56
 2020-08-25 02:04:23 +00:00
Timothée Alby
1ff2c6ce00 Merge pull request #3117 from overleaf/sk-block-tpds-update-on-archived-project 
Block TPDS update on archived/trashed project

GitOrigin-RevId: 7db41a313b03721b93cbb601add6f91ae31f3f2a
 2020-08-25 02:04:17 +00:00
Jakob Ackermann
674954f96f Merge pull request #3094 from overleaf/sk-restrict-admin-flag 
Check domain of emails on admin users

GitOrigin-RevId: 75de9cff30e3c628249fcd0ea3446a33d51d39b4
 2020-08-20 02:06:19 +00:00
Jakob Ackermann
fa594e575b Merge pull request #3113 from overleaf/jpa-translations-mono-repo 
[misc] mono repo with translations

GitOrigin-RevId: 1ed86d211f6a2031aafc3e7462687af0e957f9fd
 2020-08-19 02:06:08 +00:00
Jessica Lawshe
552fb56b74 Merge pull request #3078 from overleaf/jel-log-password-reset-by-token 
Update audit log when password reset by token

GitOrigin-RevId: 2ae7f59c5cdf2723e541a99c58c36564cc82adbf
 2020-08-13 15:46:10 +00:00
Timothée Alby
bbf3132a16 Merge pull request #3096 from overleaf/jel-security-alert-primary-email 
Send security alert email when primary email changed

GitOrigin-RevId: a01f38a2478dc280261b9a43ef1a01751d4601fb
 2020-08-13 02:06:44 +00:00
Timothée Alby
3babf23444 Merge pull request #3091 from overleaf/jel-log-default-email-change 
Update audit log for default email changes

GitOrigin-RevId: c7b4e4e888aa5ffd976062d72f660ded303f0885
 2020-08-13 02:06:40 +00:00
Timothée Alby
0cec198a08 Merge pull request #3095 from overleaf/hb-last-login-date-groups-csv 
Last login date for groups csv

GitOrigin-RevId: c615db3086ec84f2a33710fc0117d711862b6f6c
 2020-08-13 02:06:35 +00:00
Timothée Alby
d932c153c0 Merge pull request #3090 from overleaf/jel-async-setDefaultEmailAddress 
Convert setDefaultEmailAddress to async

GitOrigin-RevId: 1f915af03c3dbe54b2cce439ecd55eeb3a3f35d3
 2020-08-13 02:06:31 +00:00
Timothée Alby
459904c0ef Merge pull request #2975 from overleaf/cmg-sk-restricted-users-names 
Hide data from restricted users in history, setting history label usernames on server side

GitOrigin-RevId: 820d92064d2c0bc99ba756cca4be1adab0da5753
 2020-08-13 02:06:25 +00:00
Timothée Alby
8cd6e7ccfc Merge pull request #3064 from overleaf/ta-manage-multiple-groups 
Allow Users to Manage Multiple Groups

GitOrigin-RevId: c918da0114cdd1d679223f69d81159b4c2608874
 2020-08-13 02:06:20 +00:00
Simon Detheridge
29f09c50c2 Merge pull request #3071 from overleaf/spd-unhandled-promises-in-tests 
Treat unhandled promise rejections as errors in tests

GitOrigin-RevId: ba9d8fa02e0687c6b2d1d95e495fe0b54bb0cff5
 2020-08-12 02:07:09 +00:00
Miguel Serrano
2e8f66ac6b Merge pull request #3075 from overleaf/msm-codemod-oerror-v3-logging 
Replaced logger.warn statements with OError.tag()

GitOrigin-RevId: 4d821ec48a0006abb1fcffe07dbb5511c88f5b9a
 2020-08-12 02:07:03 +00:00
Miguel Serrano
d2845d9a38 Merge pull request #3074 from overleaf/msm-update-oerror-logger-v3 
Update o-error to v3 and logger-sharelatex to v3

GitOrigin-RevId: 5e6386f65b7893949336aa4ff021212aebd98f4a
 2020-08-12 02:06:58 +00:00
Miguel Serrano
42c917d909 Merge pull request #3046 from overleaf/msm-cleanup-oerror-http 
Finish o-error/http cleanup

GitOrigin-RevId: 1f8cf7f1e0503d1071c51b41ac136f7fb7f38872
 2020-08-12 02:06:53 +00:00
Jessica Lawshe
7eee20f914 Merge pull request #3079 from overleaf/jel-log-password-update 
Update audit log when password updated

GitOrigin-RevId: 3228e39e8a3682d6e77264cd6ee580f3fc40642a
 2020-08-10 15:56:11 +00:00
Jakob Ackermann
a437eb3d59 Merge pull request #2995 from overleaf/jpa-project-download-fix-leaking-upstream-response 
[misc] project download: fix leaking upstream stream from error in pipe

GitOrigin-RevId: cb7db90890853352dc69ea2e46cec7e7ea66e6e9
 2020-08-10 15:55:00 +00:00
Jessica Lawshe
33365e56bc Merge pull request #3061 from overleaf/jel-security-alert-clear-sessions 
Send security alert email when sessions are cleared

GitOrigin-RevId: d1620214e84211edb69d7419ed64cf7618d1b460
 2020-08-10 15:54:51 +00:00
Jessica Lawshe
c3450e4414 Merge pull request #3051 from overleaf/jel-log-when-email-added 
Add entry to auditLog when user adds an email

GitOrigin-RevId: 797c85e18cb2b201e09fd2631b1e5ea066adfc37
 2020-08-10 15:54:42 +00:00
Ersun Warncke
88683e9fec refactor SAMLController to use async throughout 
GitOrigin-RevId: dafd76042f460cd34596c8c9023e2378145105e8
 2020-08-10 15:54:15 +00:00
Jessica Lawshe
305f82459f Merge pull request #3040 from overleaf/jel-email-added-alert 
Secondary email added alert

GitOrigin-RevId: 6bfe8eb54110a522281b32490b0107db8890ab64
 2020-07-28 02:06:48 +00:00
Jessica Lawshe
cbe21d1f77 Merge pull request #3024 from overleaf/jel-log-cleared-sessions 
Log cleared user sessions in user.auditLog

GitOrigin-RevId: 829c4ea037d897689c02c1dfe12d38542a7216c0
 2020-07-28 02:06:43 +00:00
Jakob Ackermann
1f6499b5ea Merge pull request #3053 from overleaf/jpa-spd-accepts 
[misc] reland 3004: unify detection of json requests and skip issuing of redirects

GitOrigin-RevId: fa43b3b4d23deb581496ed70ae8f28b805555d64
 2020-07-28 02:06:27 +00:00
Jakob Ackermann
7847209eaa Merge pull request #3049 from overleaf/jlm-fix-referral-projection 
Fix referral projection

GitOrigin-RevId: 37c68bf6bfa81a694e2f919b262634a9a1b63f8b
 2020-07-28 02:06:20 +00:00
Jakob Ackermann
9d8e20d3d8 Merge pull request #3043 from overleaf/hb-increase-timeout-on-onboarding-email 
Increase timeout on user onboarding email endpoint

GitOrigin-RevId: d7c9aaae407e31ae2e9cfea5a6dce853c2737ab9
 2020-07-25 02:06:37 +00:00
Miguel Serrano
b0dc73a61c Remove HttpErrors.InternalServerError (#3027) 
* Added legacyInternal() 500 to HttpErrorHandler
* replaced HttpErrors.InternalServerError being thrown with calls to HttpHandler.legacyInternal()

GitOrigin-RevId: 0b7086a9693b57cdf93976d4221b90315960e8bb
 2020-07-23 02:06:50 +00:00
Jessica Lawshe
8f773318c1 Merge pull request #3023 from overleaf/jel-add-user-audit-log 
User audit log

GitOrigin-RevId: 687448d5da5d783c6db0fadb53c020cc9c3876b9
 2020-07-22 02:06:16 +00:00
Jessica Lawshe
d8b2537f48 Merge pull request #2983 from overleaf/jel-security-emails 
Add security email template and switch institution SSO alerts to use it

GitOrigin-RevId: c6f07655165e352527a9efbcfffc5bd2f635405c
 2020-07-22 02:06:11 +00:00
Eric Mc Sween
5b0d5447da Merge pull request #2999 from overleaf/as-em-fix-double-updates-load 
Fix history loading updates twice on scroll

GitOrigin-RevId: 964863c7357eef36b2833c7b1e8ebaa07020fb2c
 2020-07-21 02:06:42 +00:00
Eric Mc Sween
c200511f86 Merge pull request #3016 from overleaf/ta-editor-load-events 
Fix Editor Load Events

GitOrigin-RevId: bb23f17ccab2d53933ad9da870f8ce26fdd169df
 2020-07-21 02:06:37 +00:00
Eric Mc Sween
60bdd4641a Merge pull request #3026 from overleaf/bg-fix-size-limit-check 
fix clsi size limit check

GitOrigin-RevId: 1d26ddbe367e8873c57d35056d5b8cbddf614656
 2020-07-21 02:06:29 +00:00
Eric Mc Sween
f251d661ed Merge pull request #3021 from overleaf/msm-oerror-remove-conflict-error 
Replace ConflictError thrown with calls to HttpErrorHandler.conflict()

GitOrigin-RevId: 3b4d98af1b31e49ceab4b1b55b94b8f0323c8a9b
 2020-07-21 02:06:18 +00:00
Miguel Serrano
244709df5e Merge pull request #2988 from overleaf/msm-oerror-remove-not-found-error 
Replace HTTPErrors.NotFoundError with calls to notFound() handler

GitOrigin-RevId: c98582a5bd3d862b3c17fb03d863c75f64851aba
 2020-07-17 02:07:18 +00:00
Miguel Serrano
63503f2079 Merge pull request #2984 from overleaf/msm-oerror-remove-bad-request-error 
Replace HTTPErrors.BadRequestError with calls to badRequest() handler

GitOrigin-RevId: 57a91a13bde942ee373e235ee925f1c76a0f4e88
 2020-07-17 02:07:12 +00:00
Paulo Jorge Reis
ffc5c4be8f Merge pull request #3009 from overleaf/jpa-fix-flaky-locking-in-tests 
[misc] ProjectStructureMongoLockTest: eventually restore locking timeout

GitOrigin-RevId: 6c139edb0f6e37775c459a50a71dd90802e366fc
 2020-07-17 02:06:54 +00:00
Miguel Serrano
79b6f6e473 Merge pull request #2994 from overleaf/msm-add-user-projection-subscription-handler 
Added projection to User.find() queries in SubscriptionHandler

GitOrigin-RevId: f74e3fcd2138306dc35b5c4d0da314046ab48e35
 2020-07-17 02:06:36 +00:00
Miguel Serrano
5b40eca697 Merge pull request #2992 from overleaf/msm-add-user-projection-referal 
Added projection to User.find() queries in Referal feature

GitOrigin-RevId: 4929bcd9c1b242b7e35cc2632bbd8da3f378cd1d
 2020-07-17 02:06:31 +00:00
Miguel Serrano
e692802690 Merge pull request #2991 from overleaf/msm-add-user-projection-project-controller 
Added projection to User.getById() in ProjectController

GitOrigin-RevId: 9233a897414e3cda0b8c91f0b50d4ac422e0ab30
 2020-07-17 02:06:25 +00:00
Miguel Serrano
6562f3003d Merge pull request #2985 from overleaf/msm-oerror-remove-unprocessable-entity-error 
Replace UnprocessableEntityError with calls to unprocessableEntity() handler

GitOrigin-RevId: 4bba389c8cdf87a40137d49db571fa81aaac4239
 2020-07-17 02:06:19 +00:00
Jakob Ackermann
53927bca95 [misc] move /user/activate into a module (#2962) 
* [misc] move /user/activate into a module

Co-Authored-By: Nate Stemen <nate.stemen@overleaf.com>

* [misc] setup copybara for the new user-activate module

* [misc] move the /user/activate route behind a feature flag

...which is by default enabled.

Co-authored-by: Nate Stemen <nate.stemen@overleaf.com>
GitOrigin-RevId: 87fc5ae869a7e282ffdbeea0ff7b7c55b8b9b31b
 2020-07-16 02:06:51 +00:00
Alasdair Smith
2556fded1e Merge pull request #2998 from overleaf/as-beta-page-updates 
Update beta program page to include feedback survey link

GitOrigin-RevId: 549cd2be01b8f64d952d0347c8c102d0d2efae24
 2020-07-15 02:06:35 +00:00
Hugh O'Brien
eaa7491c2b Merge pull request #2948 from overleaf/hb-onboarding-email 
User onboarding email

GitOrigin-RevId: 367fd8b6292024bfcad2139728c16cf00f2fb1cb
 2020-07-14 02:06:47 +00:00
Miguel Serrano
b573374d0e Merge pull request #2950 from overleaf/as-jsdom-tests 
JSDOM tests

GitOrigin-RevId: d9e39c61fb2028c5b5577488d74720ef2985eebc
 2020-07-11 02:04:35 +00:00
Miguel Serrano
8023e48efd Merge pull request #2974 from overleaf/jel-ns-user-projections-beta 
Remove user projections in BetaProgramHandler

GitOrigin-RevId: 88b7bc3b6f11ae9f8314543ee538c84d25cde7cd
 2020-07-11 02:04:30 +00:00
Miguel Serrano
d8d3ac82e9 Replace HTTPErrors.ForbiddenError with calls to forbidden() handler (#2972) 
GitOrigin-RevId: 2a0c8fdaef9ba62b97cebad84603e6f076d770c0
 2020-07-11 02:04:21 +00:00
Eric Mc Sween
42c7fbf38c Merge pull request #2959 from overleaf/em-admin-only-texlive-images 
Admin only TeX Live images

GitOrigin-RevId: 428896c4e5512053bd7fa6c618ff64efd1a6141a
 2020-07-01 02:10:49 +00:00
Jakob Ackermann
153a9c5790 Merge pull request #2953 from overleaf/jpa-nocache 
[misc] Server: invoke the nocache middleware explicitly and add test

GitOrigin-RevId: 3238b07ebf5963ae95ef3f353e4745d283795fba
 2020-06-27 02:10:30 +00:00
Brian Gough
63e8c48c77 Merge pull request #2926 from overleaf/bg-create-alpha-compile-group 
create alpha compile group

GitOrigin-RevId: edc063ef591a1bed20600a9418e2114f8ab0a3df
 2020-06-20 02:10:42 +00:00
Brian Gough
2a6f18b6a0 Merge pull request #2917 from overleaf/bg-send-compile-group-parameter 
send compileGroup parameter in body of clsi request

GitOrigin-RevId: 05e9b24ea15751464104e5b0f6aef17c66a448d2
 2020-06-20 02:10:37 +00:00
Jessica Lawshe
366a925903 Merge pull request #2919 from overleaf/ta-admin-update-empty 
Allow  Empty Strings in Admin Form Updates

GitOrigin-RevId: 79c1315dcb56ebdd82094653c67dcd83b1b53b87
 2020-06-19 02:10:32 +00:00
Ersun Warncke
b335bcb67d ObjectId query args 
GitOrigin-RevId: 04e2258045c2cb4e2f93a24d842e67cb7996b5ce
 2020-06-18 02:10:54 +00:00
Ersun Warncke
d3a30929f7 always send update for project owner, pr fixes 
GitOrigin-RevId: a58ecfb13c25df02ccf79c189903b5a6fcddd835
 2020-06-18 02:10:48 +00:00
Ersun Warncke
5e84d95291 filter tpds users by dropbox 
GitOrigin-RevId: ea1222597a9b3e807100abcc2bea957db7faee5f
 2020-06-18 02:10:43 +00:00
Ersun Warncke
387695c2b1 send tpds updates for all dropbox users 
GitOrigin-RevId: b690693b98b0b6288a4c3a734d4ff2d28901a496
 2020-06-18 02:10:38 +00:00
Brian Gough
a078a34e75 Merge pull request #2902 from overleaf/bg-handle-clsi-503 
handle 503 unavailable from clsi with retry

GitOrigin-RevId: 2b90aadbe93af5007a5a64ff3d2330b2fffbf56f
 2020-06-13 02:11:10 +00:00
Jessica Lawshe
d9e4bda90b Merge pull request #2859 from overleaf/ns-cmg-history-labels-deletion 
Ensure history label dissapears from UI when deleted

GitOrigin-RevId: fe48cbce9fbd70f7008043dc202a5d985bd6c5fb
 2020-06-12 02:10:35 +00:00
Jessica Lawshe
7d98a82208 Merge pull request #2891 from overleaf/jel-remove-unused-feature-flags 
Remove unused redirect-sl feature flag and sharelatex-redirects module

GitOrigin-RevId: a13ae586db3b7ab4440f2e941947be3a28d97741
 2020-06-12 02:10:18 +00:00
Shane Kilkelly
f4950c21bf Merge pull request #2870 from overleaf/sk-restrict-chat 
Block restricted users from Chat endpoints

GitOrigin-RevId: caec8fe2bc93d567dd57f32dc765bd74ba53e933
 2020-06-05 02:09:58 +00:00
Shane Kilkelly
74313e4b82 Merge pull request #2883 from overleaf/ta-email-remove-features-refresh 
Refresh User's Features After Removing Email

GitOrigin-RevId: 0085a5341a806d1d22f4a1fb5bb98c93675e242e
 2020-06-05 02:09:52 +00:00
Miguel Serrano
cab1335371 Removed email lookup on CE user activation (#2879) 
GitOrigin-RevId: 567936295ef3b043adc7bbd735970f5ca6d91b73
 2020-06-03 10:31:27 +00:00
Timothée Alby
c4ec032ffa Merge pull request #2858 from overleaf/sk-make-lock-timeout-configurable 
Make lock timeout configurable

GitOrigin-RevId: c1df72a7cae56db125e090ada75b2c56ca9853bb
 2020-06-03 10:30:33 +00:00
Ersun Warncke
9c87ad9801 convert TpdsUpdateSender to async and cleanup 
GitOrigin-RevId: a19830134a13a23775c604a05a7e093d00bbb2de
 2020-05-28 03:16:26 +00:00
Jakob Ackermann
419100d167 Merge pull request #2860 from overleaf/jpa-socket-io-v2-percentage-rollout 
[misc] prepare for a percentage roll-out of socket.io v2

GitOrigin-RevId: 792eddeb4a9b41aded67fee13faa949122cd0faf
 2020-05-27 03:15:52 +00:00
Simon Detheridge
ca916f0cac Merge pull request #2844 from overleaf/ta-admin-affiliations 
Improve Admin Affiliations UI

GitOrigin-RevId: 1e3bcb425e1cb8463b2c3c7bbc757ab444b391a3
 2020-05-23 03:18:25 +00:00
Jakob Ackermann
2a8e2efe62 Merge pull request #2845 from overleaf/jpa-faster-web-ci 
[misc] faster web ci

GitOrigin-RevId: bbd6b12040956f6b397c6ea4d8144e733299400b
 2020-05-23 03:18:08 +00:00
Eric Mc Sween
00bdc52fab Merge pull request #2840 from overleaf/jel-sso-redundant-subscription-notification 
Redundant subscription notification if entitlement via SSO

GitOrigin-RevId: 8529204e78c3a43d87acbb375fea15c62cad48a3
 2020-05-21 03:22:51 +00:00
Eric Mc Sween
8ba63b0f8e Merge pull request #2849 from overleaf/em-convert-file-to-doc 
Fix update order when converting a file to a doc

GitOrigin-RevId: a0c9488e3870cc972c21b40ff0e2577fcec40ee0
 2020-05-21 03:22:07 +00:00
nate stemen
f5b2640c82 Merge pull request #2817 from overleaf/ns-project-import-deletion-v1-handler 
remove checks if project is in importing state

GitOrigin-RevId: f087cf04436b38b351b6985cecc9182256401cba
 2020-05-21 03:22:02 +00:00
nate stemen
2479cb485a Merge pull request #2826 from overleaf/ns-project-import-flow-deletion 
Project import flow deletion

GitOrigin-RevId: 08ffc156eb158235d4ccacba2b3ed504cd9978f0
 2020-05-21 03:21:56 +00:00
nate stemen
5fca56d4e6 Merge pull request #2807 from overleaf/ns-project-import-deletion-dashboard 
Clean up references to v1 projects on project dashboard

GitOrigin-RevId: e574382fb1747da7a701808148434f4d689cbe33
 2020-05-20 03:21:44 +00:00
Alasdair Smith
8f5270899f Merge pull request #2707 from overleaf/as-transform-esm 
Transform frontend module format from AMD to ESM

GitOrigin-RevId: 9adbcdc95e819a54114010c6fd3521d8f58ef2fe
 2020-05-20 03:21:38 +00:00
Eric Mc Sween
ae82366122 Merge pull request #2827 from overleaf/em-faster-clones 
Make a single Mongo update when cloning projects

GitOrigin-RevId: abd4069bd8854d84c413bc8f890583e647b7c18e
 2020-05-14 03:26:15 +00:00
Jessica Lawshe
4349e85444 Merge pull request #2813 from overleaf/ns-ta-group-account-admin 
Add admin to group account when new group account is created

GitOrigin-RevId: 81c49a0b414896153a85a8ba1afc364164047c1c
 2020-05-07 03:28:28 +00:00
Miguel Serrano
0583f7a667 Merge pull request #2746 from overleaf/ew-jpa-fix-deprecated-express-methods 
[misc] fix express deprecations

GitOrigin-RevId: 78c730578c6a671f142837c98f98d5fd260332a5
 2020-05-07 03:27:56 +00:00
Hugh O'Brien
6d078c4528 Merge pull request #2777 from overleaf/em-promisify-project-duplicator 
Promisify ProjectDuplicator.duplicate()

GitOrigin-RevId: e7cfd8e3a9caca4608d0b57f6978474f3289f49e
 2020-05-02 03:19:36 +00:00
Paulo Jorge Reis
7f13e258bb Merge pull request #2697 from overleaf/pr-add-vat-number 
Add VAT number and company name to the payment form

GitOrigin-RevId: 9ba2d7345f6f3cef1f7372e17c04243ab285e0bd
 2020-04-30 03:19:59 +00:00
Timothée Alby
5d7fd2a9d8 Merge pull request #2751 from overleaf/ta-finish-login-private 
Don't Export `afterLoginSessionSetup`

GitOrigin-RevId: 46818a70566b8ec56e1a40c7f0d9758d2ac2c100
 2020-04-29 03:22:04 +00:00
Alasdair Smith
3a1ab63cce Merge pull request #2724 from overleaf/ns-doc-over-file 
allow upload of doc over existing file

GitOrigin-RevId: 13578bf4ab6d54686077402488399db0379cc761
 2020-04-28 03:21:52 +00:00
Ersun Warncke
a0bb38750a Revert "use user_id for tpds queue name" 
This reverts commit 76d7badd001e0902e55d54efdca53d01124bcc77.

GitOrigin-RevId: 75e480660c6a1682cf20ba9575fd90f0ce726abc
 2020-04-28 03:21:42 +00:00
Ersun Warncke
97ce66a9e7 use user_id for tpds queue name 
GitOrigin-RevId: e61440efd22ef9e858b2862b1a6fd022c6eb70a4
 2020-04-28 03:21:33 +00:00
Ersun Warncke
59c26be6f2 fix tests, and placeholder while loading 
GitOrigin-RevId: c3e4f31179423ed259cc2aab5b053e5c952350ff
 2020-04-28 03:21:24 +00:00
Simon Detheridge
dd59d8c242 Merge pull request #2770 from overleaf/spd-filestore-deletes 
Delete project files in filestore when project is hard-deleted

GitOrigin-RevId: c836f94b2dc1967d84424ff1b65b1025b3499309
 2020-04-25 03:18:55 +00:00
Eric Mc Sween
d8615ddba3 Merge pull request #2761 from overleaf/jpa-user-controller-bail-out-next 
[UserController] updateUserSettings: bail out after calling next(err)

GitOrigin-RevId: f1905c0c54f3feb98836443cbf8e080888d4901c
 2020-04-24 03:31:04 +00:00
Eric Mc Sween
27941dc8af Merge pull request #2760 from overleaf/em-faster-uploads 
Make a single Mongo update when uploading projects

GitOrigin-RevId: de102d3e112c9014ca5885f963e35971e4db6cee
 2020-04-24 03:30:55 +00:00
Eric Mc Sween
1dc325d1c7 Merge pull request #2750 from overleaf/ta-activate-finish-login 
Don't Bypass FinishLogin on Password Reset

GitOrigin-RevId: 92567c893afb4aa64fa045151678d33c877d8f71
 2020-04-24 03:30:45 +00:00
Miguel Serrano
6118a63783 Merge pull request #2712 from overleaf/jel-sso-ui-confirmed-domains 
SSO UI only for confirmed domains

GitOrigin-RevId: cd8d7b93860a45d9527e717c6fc42876e9c9829e
 2020-04-23 03:29:38 +00:00
Miguel Serrano
f39a650823 Merge pull request #2749 from overleaf/ew-ta-google-2fa-error 
fix ERR_HTTP_HEADERS_SENT error with oauth and 2fa

GitOrigin-RevId: b70bd79fb544121337be27349a967d52da115930
 2020-04-23 03:29:21 +00:00
Eric Mc Sween
d063ab2bc5 Merge pull request #2745 from overleaf/em-promisify-project-upload-manager 
Finish promisification of ProjectUploadManager

GitOrigin-RevId: a8550d9decf25af35a2d2f82770cff336a4153cc
 2020-04-17 03:23:30 +00:00
Jakob Ackermann
825d0701e8 Merge pull request #2742 from overleaf/jpa-hotfix-user-lookup 
[UserPagesController] block arbitrary user lookups

GitOrigin-RevId: 4d88abbd0ad14289a73e7f502c0686f206617459
 2020-04-14 03:19:24 +00:00
Simon Detheridge
0586f4d682 Merge pull request #2714 from overleaf/cmg-jpa-call-stack-exceeded 
Stop call stack from being exceeding when adding many files

GitOrigin-RevId: 1983b0c16cb279c6f173f614d541d16852664e24
 2020-04-09 03:21:38 +00:00
Shane Kilkelly
7ec7237f17 Merge pull request #2716 from overleaf/em-promisify 
Promisify FileSystemImportManager

GitOrigin-RevId: 8f89492872c94a596afbfa644e5f2b985eb65a28
 2020-04-09 03:21:09 +00:00
Shane Kilkelly
d6bd911a6e Merge pull request #2720 from overleaf/sk-remove-nodemailer-sendgrid 
Remove nodemailer sendgrid

GitOrigin-RevId: af84dd78291957371d679de43bc4570960a7b635
 2020-04-09 03:20:45 +00:00
Alasdair Smith
bc1b73d74e Merge pull request #2515 from overleaf/as-transform-absolute-paths 
Transform absolute paths in frontend to relative

GitOrigin-RevId: c1914c0fd09d68984ba6c85a1f00aa3e6858d944
 2020-04-07 03:18:45 +00:00
Jakob Ackermann
155b22caf9 Merge pull request #2713 from overleaf/jpa-custom-wsurl-for-beta-users 
[misc] custom wsUrl for beta users

GitOrigin-RevId: e731ae7245e9c5586ae82cbc4c6716a74e56f2c9
 2020-04-03 03:20:47 +00:00
Timothée Alby
be7a1abb13 Merge pull request #2693 from overleaf/ta-acceptance-user-helper 
Improve UserHelper in Acceptance Tests

GitOrigin-RevId: 3dffc789a07197d6cc14715dee89da0feb40b506
 2020-04-02 03:19:44 +00:00
Timothée Alby
35ef98781f Merge pull request #2692 from overleaf/ta-authorization-helper 
Add Authorizationhelper

GitOrigin-RevId: 35fa8d8fc005c9eb171621c872010e6c831ba8f6
 2020-04-02 03:19:40 +00:00
Timothée Alby
1d7b454c96 Merge pull request #2691 from overleaf/ta-4xx-error-page 
Enhance 4xx HTML Response Page

GitOrigin-RevId: 620f84cd6cdc0571bd68bbd2c3164b08f7fe5598
 2020-04-02 03:19:35 +00:00
Timothée Alby
05a2529881 Merge pull request #2689 from overleaf/ta-pre-finish-login-hook 
Add preFinishLogin Hook

GitOrigin-RevId: 8379e0643866feef95c648a2db4d8665420e615b
 2020-04-02 03:19:27 +00:00
nate stemen
797d76f90e Merge pull request #2705 from overleaf/jpa-pub-sub-metrics 
[misc] track redis pub/sub payload sizes on publish

GitOrigin-RevId: 7ef7ada34f9f6376abdd2b0b6aa10a5aac56a62f
 2020-03-31 03:18:59 +00:00
nate stemen
344b2b2395 Merge pull request #2702 from overleaf/ta-subscription-links 
Fix Language Change Links

GitOrigin-RevId: e47f59dfd53102d4569c3ffeb950d3259c65215b
 2020-03-31 03:18:45 +00:00
Shane Kilkelly
b51e3c01e4 Merge pull request #2614 from overleaf/sk-monolithify-tags 
Move 'tags' into web

GitOrigin-RevId: a248d1b2471f0bfa05589df9b7357b4d85793a79
 2020-03-25 04:16:44 +00:00
nate stemen
31b95e8617 Merge pull request #2603 from overleaf/jpa-ns-cmg-binary-upload 
[ProjectEntityUpdateHandler] handle entity changes on upsert

GitOrigin-RevId: 134e2c8909db5a336bce62460e46b3e625463c6f
 2020-03-19 04:17:18 +00:00
nate stemen
3a2bdfe7f1 Merge pull request #2665 from overleaf/pr-fix-spelling-markers-safari 
Spellcheck improvements + fix spelling markers being out of place

GitOrigin-RevId: fa70e257f96f78d3570c86871f85c79daf08014c
 2020-03-19 04:17:09 +00:00
nate stemen
c301d8bc25 Merge pull request #2666 from overleaf/em-max-json-request-size 
Separate max_doc_length from max JSON request size

GitOrigin-RevId: 4c725028111966bf04109080d80d4672273dd697
 2020-03-19 04:17:05 +00:00
Eric Mc Sween
9f3b2d2cdc Merge pull request #2670 from overleaf/em-convert-doc-to-file-rev 
Adjust the file rev when converting a doc to a file

GitOrigin-RevId: 6765bcac1fcd4f4db35f9ce88af1f201f5da509a
 2020-03-17 04:18:15 +00:00
Jessica Lawshe
a433235310 Merge pull request #2643 from overleaf/jel-affiliations-cron-job 
Ensure affiliations cron job

GitOrigin-RevId: 4ac6f8b29b1e1460d627a86172fcdf1fa27a59a8
 2020-03-12 04:18:47 +00:00
Eric Mc Sween
8547bb3c8d Merge pull request #2661 from overleaf/em-convert-doc-to-file-ranges 
Do not convert a doc to file when it has ranges

GitOrigin-RevId: 52f0151e54c426178f80c34c6afac908bbf7b90d
 2020-03-11 04:14:54 +00:00
Timothée Alby
403704710c Merge pull request #2648 from overleaf/msm-fix-multiresult-promisify 
Added multiResult to ProjectEntityHandler.promises.getDoc

GitOrigin-RevId: 6a2807cdae822c188298b48887d0eff57edf12d4
 2020-03-10 04:14:51 +00:00
Timothée Alby
620b95fbe8 Merge pull request #2656 from overleaf/jpa-import-709 
[misc] fileOperationI18nNames: drop blocking DOM access

GitOrigin-RevId: e6aab686fc8d4fe3b5515033b88548278c7bf7c0
 2020-03-10 04:14:42 +00:00
Timothée Alby
fbbb39b0c0 Merge pull request #2620 from overleaf/ta-body-parser-errors 
Convert Errors with Status Code To HTTP Errors

GitOrigin-RevId: 4c7abf4f9164c1a907fbf38c6e440409a616e047
 2020-03-10 04:14:38 +00:00
Eric Mc Sween
58017d4480 Merge pull request #2659 from overleaf/em-binary-file-history-fix 
Fix binary file diffs

GitOrigin-RevId: 1773e8918a0f82a1945470630ca691dfa4b13026
 2020-03-06 04:13:46 +00:00
nate stemen
6379f15815 Merge pull request #2651 from overleaf/ta-missing-return 
Add Missing Return

GitOrigin-RevId: aeb622a6745678eb687217beeb49b5d023168052
 2020-03-06 04:13:42 +00:00
Eric Mc Sween
fbc1136be7 Merge pull request #2649 from overleaf/em-delete-project-history 
Delete project in project history when expiring

GitOrigin-RevId: a6bf44a88de35e777b135d8f84d68e3b0ba8908f
 2020-03-05 04:17:00 +00:00
Eric Mc Sween
2627595040 Merge pull request #2639 from overleaf/em-convert-doc-to-file 
Endpoint for converting a doc to a file

GitOrigin-RevId: 0a3bd46a7a78537b0f64dc577402277cbe81fecb
 2020-03-05 04:16:49 +00:00
Hugh O'Brien
693100358c Merge pull request #2646 from overleaf/as-fix-trashing-old-archived-project 
Fix error thrown when trashing project with legacy boolean archived state

GitOrigin-RevId: 0131a2294767e00d69c4dd80ed86dfd5d77339b8
 2020-03-04 04:21:54 +00:00
Hugh O'Brien
bb958492a9 Merge pull request #2623 from overleaf/hb-third-party-too-many-files 
Third party too many files errors

GitOrigin-RevId: 0a44931b14dd349d9cc4d25a3b51c68f221b8195
 2020-03-04 04:21:43 +00:00
Eric Mc Sween
d8d1bdd461 Merge pull request #2647 from overleaf/em-promisify-history-manager 
Promisify HistoryManager

GitOrigin-RevId: cbf946a7d61f7f57bad03e4c83184c6decd91027
 2020-03-04 04:21:26 +00:00
Eric Mc Sween
b2ee3bf2bb Merge pull request #2634 from overleaf/jel-ensure-affiliations 
Ensure affiliations after loading the settings page

GitOrigin-RevId: bf9982fb436d0e75d6fbd8418ca2d19e00fe3b66
 2020-03-03 04:21:44 +00:00
Eric Mc Sween
864394d4ad Merge pull request #2640 from overleaf/em-promisify-project-deleter 
Finish promisification of ProjectDeleter

GitOrigin-RevId: a426117c9430e2ee66b297b95f67460062a6a809
 2020-03-03 04:21:39 +00:00
Timothée Alby
42aa999af6 Merge pull request #2638 from overleaf/ta-subscription-change-admin-fix 
Change Manager When Changing Admin of Individual Subscriptions

GitOrigin-RevId: 3da53789f4331c4eb8d0a458650ea41f8b2b4f97
 2020-02-29 04:17:31 +00:00
Eric Mc Sween
4e760e276a Merge pull request #2622 from overleaf/em-promisify-editor-http-controller 
Promisify EditorHttpController

GitOrigin-RevId: 938350f21a19c10c6bd4261086265a098e71e932
 2020-02-28 04:18:42 +00:00
Eric Mc Sween
77c75bf223 Merge pull request #2597 from overleaf/as-cleanup-tags-handler 
Clean up tags handler

GitOrigin-RevId: 6e83880d9a38b323470933f6ef01fde187d55161
 2020-02-28 04:18:25 +00:00
Eric Mc Sween
1da929fcdb Merge pull request #2618 from overleaf/ew-clear-root-doc-on-delete 
Clear root doc on delete

GitOrigin-RevId: 4121d198f5253417bca2284c5f750c088debcb8c
 2020-02-28 04:18:17 +00:00
Eric Mc Sween
17969c50ce Merge pull request #2611 from overleaf/ta-cmg-recurly-email-update-test-plus 
Improve Recurly API Acceptance Test

GitOrigin-RevId: 89f4707c9baaa20e59f64821daa36551ad700118
 2020-02-28 04:18:13 +00:00
Eric Mc Sween
174af14d46 Merge pull request #2610 from overleaf/ta-recurly-email-update-auto 
Update Recurly Email on Default Email Change

GitOrigin-RevId: e2821d7bdc4bc6befff2152d92c76952c38694f9
 2020-02-28 04:18:09 +00:00
Eric Mc Sween
403c9ae66b Merge pull request #2627 from overleaf/jel-decaf-cleanup 
Decaf cleanup

GitOrigin-RevId: 9e0770ce6c5362ea288fc1706014aacd45608008
 2020-02-28 04:18:04 +00:00
Brian Gough
509c23def7 Merge pull request #2631 from overleaf/bg-maintenance-messages-in-editor 
display maintenance messages in editor

GitOrigin-RevId: 7d4fda60c5e2bd12d2cead2a9bff326b75e9c4e7
 2020-02-27 04:17:59 +00:00
Shane Kilkelly
2686f5e72a Merge pull request #2630 from overleaf/sk-fix-token-login-redirect 
Remember token page when redirect to login

GitOrigin-RevId: 1c4d7b8ae034ef2d63cc680405c099405024f4d1
 2020-02-26 04:24:06 +00:00
Shane Kilkelly
7cbb00f207 Merge branch 'sk-token-csrf-protection' 
GitOrigin-RevId: e71f7264be45b665502150e9ffbb85b3fc94665e
 2020-02-26 04:24:01 +00:00
Timothée Alby
995dbc514d Merge pull request #2594 from overleaf/jel-flag-affiliation-when-registering 
Flag unchecked affiliation when registering

GitOrigin-RevId: c9da12ceb5a1712c8c477222f967fb54eceef252
 2020-02-21 04:21:16 +00:00
Timothée Alby
f5e2983a6b Merge pull request #2609 from overleaf/ta-cmg-recurly-email-update 
Add UI to Update Recurly Email

GitOrigin-RevId: 920a741fd9b4312f031bdd40e3d6bec48f1bd579
 2020-02-21 04:21:12 +00:00
Timothée Alby
506543d6a0 Merge pull request #2605 from overleaf/jel-sso-registration 
Do not block SSO registration on nonessential errors

GitOrigin-RevId: c9d6a7803aa8a48dbc1a8aae84d6f2588bad654e
 2020-02-21 04:21:07 +00:00
Timothée Alby
98f031e9aa Merge pull request #2619 from overleaf/ta-licence-attribute-fix 
Read Licence Attribute from Affiliation Instead of Institution

GitOrigin-RevId: 2294222e2bd0da473a303d3ffdc5ddb7d856f7f7
 2020-02-21 04:20:59 +00:00
nate stemen
ab5101f189 Merge pull request #2613 from overleaf/spd-tags-timeout 
Use a longer timeout when talking to the tags API

GitOrigin-RevId: 467f981c1818293c28dd288d7223540597a8ca3e
 2020-02-21 04:20:55 +00:00
Simon Detheridge
ab80c72565 Merge pull request #2602 from overleaf/hb-too-many-files-errors 
Too many files errors for new files modal

GitOrigin-RevId: a9e2db2e4d8624de4e062161781067ee0c68c4e0
 2020-02-19 04:20:47 +00:00
Simon Detheridge
b812109cb7 Merge pull request #2593 from overleaf/ta-affiliation-licence-check 
Check Licence on Affiliations Rather Than Institutions

GitOrigin-RevId: 7effe7f564ff953e60ed77bcdf92f3cb177d4aee
 2020-02-19 04:20:39 +00:00
Timothée Alby
cd9a9b43bd Merge pull request #2606 from overleaf/ta-check-sso-users 
Add SSO Users Info on Users Features Check Summary

GitOrigin-RevId: 5c874e1bf50005eb311317b867b17380ca017118
 2020-02-15 04:17:53 +00:00
Brian Gough
69a98355ce Merge pull request #2599 from overleaf/bg-fix-safepath-check 
fix safepath check

GitOrigin-RevId: b5bb636d2bd958ab142fa94683ad9cf58369a77d
 2020-02-14 04:16:44 +00:00
Simon Detheridge
9e6323caeb Merge pull request #2584 from overleaf/spd-duplicate-deleted-things 
Prevent creation of (and clean up) duplicate deletedUsers and deletedProjects

GitOrigin-RevId: 5e52578b514f05779290c61cf7d4e630cc3ba6f7
 2020-02-13 04:20:49 +00:00
Simon Detheridge
73defe82d9 Merge pull request #2561 from overleaf/pr-reduce-spellcheck-initial-req 
Reduce spellcheck initial (and subsequent) requests

GitOrigin-RevId: 81eee359ea1bc740991ba84b0fe121c37cb4c6a2
 2020-02-13 04:20:44 +00:00
Simon Detheridge
96cd1c869e Merge pull request #2583 from overleaf/spd-no-mongoredis-in-unittests 
Clean up attempts to connect to Mongo and Redis in unit tests

GitOrigin-RevId: 396813a04fc2aaf39a07e28613f8f1e0a7a2db8f
 2020-02-13 04:20:35 +00:00
Chrystal Maria Griffiths
4131e5ce7b Merge pull request #2585 from overleaf/cmg-remove-legacy-archive 
Remove legacy project archiving

GitOrigin-RevId: a402cde154cdc2ef5e93661318c5ca86201471b5
 2020-02-13 04:20:26 +00:00
Brian Gough
80e9afe42c Merge pull request #2586 from overleaf/bg-simplify-rate-limit-metrics 
simplify metric for rate limits

GitOrigin-RevId: bba98c7e38846aedcfcf0781003f755e302f7759
 2020-02-13 04:20:17 +00:00
Jessica Lawshe
528b2b5728 Merge pull request #2563 from overleaf/jel-add-affiliation-when-registering 
Add affiliation when registering

GitOrigin-RevId: e1915bbdc0a4fef399ef9b4a2154ede31e282cc3
 2020-02-12 04:21:10 +00:00
Ersun Warncke
ba253bee12 Revert "Revert "Revert "clear rootDoc_id when deleting doc, reset on compiles if invalid""" 
This reverts commit 034ae6fa4d8515944683395ef14d99801829cb6a.

GitOrigin-RevId: 16801e6f35e1ee879d36ca46e262f8bb6e506a54
 2020-02-12 04:20:56 +00:00
Ersun Warncke
b4cdfc43cf Revert "Revert "Revert "format fix""" 
This reverts commit abb3f94c50b94cd87012d9e55c40afd9cbfe97e0.

GitOrigin-RevId: 090e01b96222024341e3c988ec3ba4c9fa1eef11
 2020-02-12 04:20:52 +00:00
Ersun Warncke
9228fbd026 Revert "Revert "Revert "optimize rootDoc_id validation""" 
This reverts commit f015bc2bb54e98d1271bc2417647638aa80ba843.

GitOrigin-RevId: ca8380891a0e71713ed33f200720a9ab92db6ef3
 2020-02-12 04:20:43 +00:00
Ersun Warncke
67e89b9d80 Revert "Revert "Revert "add ensureRootDocumentIsValidForProject method""" 
This reverts commit aced9579ed1f4b0ab1780be0f4f45ae8d6a405a5.

GitOrigin-RevId: 90df39b8b90197c53ee80ffbb9ee61fa3b4ba905
 2020-02-12 04:20:34 +00:00
Ersun Warncke
b1c904f824 Revert "Revert "Revert "use ProjectRootDocManager in ClsiManager""" 
This reverts commit 14c94880804a3567e2b91e314a707a47bb74be2c.

GitOrigin-RevId: 9039335d01e90cf240f627a7c35889c9ab994a63
 2020-02-12 04:20:30 +00:00
Ersun Warncke
b57ee58883 Revert "fix acceptance tests" 
This reverts commit 7e61102f91654431761f5f72b4355c6e5954b0d7.

GitOrigin-RevId: e93c5e079c8b83a77e7a74065c23afb17c9369b3
 2020-02-12 04:20:25 +00:00
Ersun Warncke
a6a624eaa3 Revert "format fix" 
This reverts commit ed06e07c536e3faa984326a02bbc633b7837e859.

GitOrigin-RevId: b4ed8349c9867838442af9c06a2a1a54fe40e57b
 2020-02-12 04:20:21 +00:00
Ersun Warncke
5abb9ab855 format fix 
GitOrigin-RevId: ed06e07c536e3faa984326a02bbc633b7837e859
 2020-02-12 04:20:17 +00:00
Ersun Warncke
b4fbb0c9fc fix acceptance tests 
GitOrigin-RevId: 7e61102f91654431761f5f72b4355c6e5954b0d7
 2020-02-12 04:20:12 +00:00
Ersun Warncke
22fcbe8648 Revert "Revert "use ProjectRootDocManager in ClsiManager"" 
This reverts commit 98c0b9246eb29a9d0bdab14a04d456473a1b4a14.

GitOrigin-RevId: 14c94880804a3567e2b91e314a707a47bb74be2c
 2020-02-12 04:20:08 +00:00
Ersun Warncke
725a3c5282 Revert "Revert "add ensureRootDocumentIsValidForProject method"" 
This reverts commit 80bb46f92f200f48fc39138afb27df729959888c.

GitOrigin-RevId: aced9579ed1f4b0ab1780be0f4f45ae8d6a405a5
 2020-02-12 04:20:03 +00:00
Ersun Warncke
f326d632ab Revert "Revert "optimize rootDoc_id validation"" 
This reverts commit 13e4b22daa99b096cf2a9625212a855be59b1fdc.

GitOrigin-RevId: f015bc2bb54e98d1271bc2417647638aa80ba843
 2020-02-12 04:19:54 +00:00
Ersun Warncke
7e200d2aea Revert "Revert "format fix"" 
This reverts commit 4617b9ec2ed63b14418a8510a214e58397314831.

GitOrigin-RevId: abb3f94c50b94cd87012d9e55c40afd9cbfe97e0
 2020-02-12 04:19:45 +00:00
Ersun Warncke
93bf7cc4db Revert "Revert "clear rootDoc_id when deleting doc, reset on compiles if invalid"" 
This reverts commit 7acba5876581044a08d6deb4767a4a2196dcb765.

GitOrigin-RevId: 034ae6fa4d8515944683395ef14d99801829cb6a
 2020-02-12 04:19:41 +00:00
Jessica Lawshe
f2636e0555 Merge pull request #2572 from overleaf/ta-personal-plan-test 
Personal Plan Filter Test

GitOrigin-RevId: e0e75bdd43b27cda787d039f9cfaad64e96afa67
 2020-02-06 04:20:09 +00:00
Ersun Warncke
76a6c399e3 Revert "clear rootDoc_id when deleting doc, reset on compiles if invalid" 
This reverts commit 539982adbf55014400f4aff94195e7f567cda676.

GitOrigin-RevId: 7acba5876581044a08d6deb4767a4a2196dcb765
 2020-02-06 04:19:46 +00:00
Ersun Warncke
d8b627f59b Revert "format fix" 
This reverts commit 71faf86ccd19dfa6428c2d5bcc8c88ec7f0ee41f.

GitOrigin-RevId: 4617b9ec2ed63b14418a8510a214e58397314831
 2020-02-06 04:19:41 +00:00