github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2651 from overleaf/ta-missing-return

Browse source 
Add Missing Return

GitOrigin-RevId: aeb622a6745678eb687217beeb49b5d023168052
This commit is contained in:
nate stemen 2020-03-05 10:42:19 -05:00 committed by Copybot
parent 818d19bd69
commit 6379f15815
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/src/Features/Subscription/SubscriptionController.js
View file

@ -206,7 +206,7 @@ module.exports = SubscriptionController = {
}
if (hasSubscription) {
logger.warn({ user_id: user._id }, 'user already has subscription')
res.sendStatus(409) // conflict
return res.sendStatus(409) // conflict
}
return SubscriptionHandler.createSubscription(
user,

12
services/web/test/unit/src/Subscription/SubscriptionControllerTests.js
View file

@ -419,6 +419,18 @@ describe('SubscriptionController', function() {
})
describe('createSubscription with errors', function() {
it('should handle users with subscription', function(done) {
this.LimitationsManager.userHasV1OrV2Subscription.yields(null, true)
this.SubscriptionController.createSubscription(this.req, {
sendStatus: status => {
expect(status).to.equal(409)
this.SubscriptionHandler.createSubscription.called.should.equal(false)
done()
}
})
})
it('should handle 3DSecure errors', function(done) {
this.next = sinon.stub()
this.LimitationsManager.userHasV1OrV2Subscription.yields(null, false)