github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-24 03:23:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3016 from overleaf/ta-editor-load-events

Browse source 
Fix Editor Load Events

GitOrigin-RevId: bb23f17ccab2d53933ad9da870f8ce26fdd169df
This commit is contained in:
Eric Mc Sween 2020-07-20 09:23:20 -04:00 committed by Copybot
parent 60bdd4641a
commit c200511f86
3 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/web/app/src/Features/Project/ProjectController.js
View file

@ -35,6 +35,7 @@ const Features = require('../../infrastructure/Features')
const BrandVariationsHandler = require('../BrandVariations/BrandVariationsHandler')
const { getUserAffiliations } = require('../Institutions/InstitutionsAPI')
const UserController = require('../User/UserController')
const AnalyticsManager = require('../Analytics/AnalyticsManager')
const _ssoAvailable = (affiliation, session, linkedInstitutionIds) => {
if (!affiliation.institution) return false
@ -773,6 +774,12 @@ const ProjectController = {
const enableOptimize =
!!Settings.experimentId && !user.features.zotero
if (userId) {
AnalyticsManager.recordEvent(userId, 'project-opened', {
projectId: project._id
})
}
res.render('project/editor', {
title: project.name,
priority_title: true,

5
services/web/frontend/js/ide/settings/controllers/SettingsController.js
View file

@ -192,10 +192,7 @@ export default App.controller('SettingsController', function(
}
// don't save on initialisation, Angular passes oldRootDoc_id as
// undefined in this case.
if (
typeof rootDoc_id === 'undefined' &&
typeof oldRootDoc_id === 'undefined'
) {
if (typeof oldRootDoc_id === 'undefined') {
return
}
// otherwise only save changes, null values are allowed

3
services/web/test/unit/src/Project/ProjectControllerTests.js
View file

@ -178,7 +178,8 @@ describe('ProjectController', function() {
getUserAffiliations: this.getUserAffiliations
},
'../ThirdPartyDataStore/TpdsProjectFlusher': this.TpdsProjectFlusher,
'../../models/Project': {}
'../../models/Project': {},
'../Analytics/AnalyticsManager': { recordEvent: () => {} }
}
})