Commit graph

533 commits

Author SHA1 Message Date
Jimmy Domagala-Tang
17074473a7 Merge pull request #18525 from overleaf/jdt-disable-indenttaion-safari
[Web] Disable indentation markers on Safari

GitOrigin-RevId: 7a62382e6d4a4ecf0bd144ab937f6e197d173bdb
2024-05-31 08:04:56 +00:00
Jimmy Domagala-Tang
81903bb79d Merge pull request #18175 from overleaf/jdt-new-bib-file-prompt
[Web] Add opportunistic prompts for third party references

GitOrigin-RevId: d794df16781d0db707423f23ab12f40a13604907
2024-05-27 10:23:41 +00:00
Alf Eaton
6569f49a92 Set isEvalSupported to false when loading a PDF document (#18444)
GitOrigin-RevId: 394d63571d83302b91b5719389adf49155218bc7
2024-05-27 10:21:55 +00:00
Alf Eaton
e7827fbd57 Validate URL protocol before opening from Visual Editor tooltip (#18393)
GitOrigin-RevId: 1da255d3e8ccd91e8c8774d140ec663906be948f
2024-05-21 08:04:26 +00:00
Alf Eaton
9d6754f546 Add citepalias and citetalias (#18272)
GitOrigin-RevId: 60716cd30141f3079e9402140a5e40665bbe685f
2024-05-17 08:04:20 +00:00
Alf Eaton
c1c098e2f9 Allow files to be dragged from the file tree into the editor (#15028)
GitOrigin-RevId: f926666c032d1398a0e3f72a298116a3c7a9cd75
2024-05-09 08:04:46 +00:00
Alf Eaton
cb297e342a [visual] Improve handling of pasted lists (#14912)
GitOrigin-RevId: 15e91ef6807433c5fb0a9bedbd5fea42ac35a5f0
2024-05-09 08:04:42 +00:00
Alf Eaton
a2ff44d7d4 Merge pull request #18214 from overleaf/ae-visual-underline
[visual] Set text-underline-offset for links

GitOrigin-RevId: c65a92cada0e219bdb72e10d8987dbd5da7cd629
2024-05-09 08:04:38 +00:00
Jimmy Domagala-Tang
72b53fe8db Merge pull request #18173 from overleaf/jdt-container-utils
[Web] Add container based hide utils to our util css

GitOrigin-RevId: 193abf1242ec4a816299fabf486754b3bcbae147
2024-05-08 08:03:51 +00:00
Antoine Clausse
2f99e3ccf1 Add autoComplete="off" to React-controlled checkboxes (#18212)
Fixes https://github.com/overleaf/internal/issues/18144

Browsers use a [bfcache](https://web.dev/articles/bfcache) (Back/forward cache) which restores form data on navigation. Unfortunately, it causes checkbox appearances not to respect our React states.

Setting `autoComplete="off"` on checkboxes mitigates this problem. (From https://stackoverflow.com/questions/299811/why-does-the-checkbox-stay-checked-when-reloading-the-page)

Another solution could be to set a `Cache-Control: no-store` header, but this might additionnal undesired consequences.

GitOrigin-RevId: 7d3cceb1c818ad70de7e806ea6d714ffc8bffb4a
2024-05-06 08:04:39 +00:00
David
0c20c86878 Merge pull request #18178 from overleaf/dp-insert-figure-translations
Add translations for insert figure dropdown

GitOrigin-RevId: 6ffbf0229f7ac222619271688517bc50339c10f6
2024-05-06 08:04:16 +00:00
Alf Eaton
ab5495023a [visual] Add support for description list environments (#13460)
GitOrigin-RevId: d1ddfeed4ba453afa348e57d75fdb3e12d29f5fc
2024-05-03 08:04:53 +00:00
Antoine Clausse
6a6f155029 [web] Use React hooks to get split-test variants instead of getSplitTestVariant (getMeta) (#18133)
* Fix split-tests loading in React component: use `useSplitTestContext` instead of `getSplitTestVariant`

* Replace use of `isSplitTestEnabled` by `useSplitTestContext`

* Add SplitTestProvider to roots, and fix tests

* Create `useFeatureFlag` hook

* Use `useFeatureFlag` where applicable

GitOrigin-RevId: 9ff7bb3975d50bc4d07d74d93c482d56dc96f615
2024-05-01 08:04:55 +00:00
Alf Eaton
9d4340e24a Reapply "Avoid vertical border between editor switch and empty space (#18029)" (#18072)
This reverts commit 9a071e1d02f27bbcaf1d61a9cca577cc6c889abc.

GitOrigin-RevId: 72380a15ccbc4e8d7fddcfdf0a9a48209152b8b9
2024-04-24 08:04:22 +00:00
Alf Eaton
45ee8aca93 [visual] Handle Enter in an empty list item at the end of a nested list (#18034)
GitOrigin-RevId: 4b3f24c7cf18837ba87859340991d9bb2532560a
2024-04-24 08:04:17 +00:00
Jimmy Domagala-Tang
e1ec856650 Merge pull request #18066 from overleaf/ae-revert-toolbar
Revert "Avoid vertical border between editor switch and empty space"

GitOrigin-RevId: eda4deba8eb384cddf2ea9c90edee080ceb6330c
2024-04-23 08:05:45 +00:00
Alf Eaton
92d6966f69 Only display bulk actions for tracked changes when permitted (#18038)
GitOrigin-RevId: a2f4df9c26866aab3eea62c92ce6e1a211e08294
2024-04-23 08:05:31 +00:00
Alf Eaton
315b511666 Avoid vertical border between editor switch and empty space (#18029)
GitOrigin-RevId: 516098061a4d329daf55bb42bcf47a5a412595c1
2024-04-23 08:05:26 +00:00
Jessica Lawshe
f5ac5b0ed3 Merge pull request #17878 from overleaf/mj-keyboard-navigation-firefox-115
[web] Use getAttribute rather than accessing Element.role

GitOrigin-RevId: a6732180d945ccc4ac0300af07e52228e9f2c928
2024-04-12 08:06:27 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540)
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Andrew Rumble
9fda813e20 Merge pull request #17786 from overleaf/ar-select-caption-in-inserted-figures
Select caption text when new figure inserted

GitOrigin-RevId: 443594ff03c5a5cd316623e60b231a6af4390d3c
2024-04-09 08:04:36 +00:00
Miguel Serrano
d7d63e0f51 Merge pull request #17693 from overleaf/msm-hide-grammarly-sp
Prevent grammarly ad from rendering in CE/SP

GitOrigin-RevId: 3ef191f282f2ce682236710df9ca32a087271c4c
2024-04-09 08:03:59 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555)
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
2024-04-03 08:04:16 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Alf Eaton
aeb20340c8 Reduce review panel calls to Trans (#17385)
GitOrigin-RevId: fdc7b3c2cd2506c810a785462fcd120a3a05da78
2024-03-07 16:30:36 +00:00
Alf Eaton
5df35093ea Remove hidden comment button from editor toolbar (#17386)
GitOrigin-RevId: 61b3725a7b2112c6e5abca0349b1be910e97266a
2024-03-07 16:30:28 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383)
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
2024-03-07 16:30:25 +00:00
Alf Eaton
bd2c3a61f3 Merge pull request #17381 from overleaf/ae-firefox-change-callout
Hide comment/change callout line in Firefox

GitOrigin-RevId: fe0803c71beb1073cf6715ff91a68ed39f578af2
2024-03-07 16:30:22 +00:00
Alf Eaton
55da43a6ce Ensure that ol_extensions_writefull Sentry tag is defined (#17366)
GitOrigin-RevId: c1261f780e439852b9a59d8d8a2022c30ff354e1
2024-03-07 16:30:15 +00:00
Miguel Serrano
ac48d81987 Merge pull request #17373 from overleaf/jpa-figure-modal-options
[web] hide figure modal import options as configured server side

GitOrigin-RevId: f8907a33d413fcac238b00328eaba14d64f2f31b
2024-03-06 17:27:32 +00:00
roo hutton
790fc5513b Merge pull request #17392 from overleaf/rh-friendly-readonly
Don't show 'add comment' button if isRestrictedTokenMember

GitOrigin-RevId: da236a4f2fbe0e66a7e5999bd70f7145fd60df20
2024-03-06 09:03:13 +00:00
Mathias Jakobsen
60d38285ea Merge pull request #17393 from overleaf/mj-tikzcd
[cm6] Don't decorate tikzcd environments

GitOrigin-RevId: bf499432d67cefe12576fc135f4564b97a1b2c13
2024-03-05 09:03:31 +00:00
Alf Eaton
3e11ee6e5a Ensure that the editor state is preserved when switching views (#17238)
GitOrigin-RevId: 946b82cb633afbea13a72e30a9ce432aa1a8196d
2024-02-23 09:03:06 +00:00
Alf Eaton
3f29aa2195 Ensure that each editor theme is only created once (#17095)
GitOrigin-RevId: 3551e02fab44fae7fcab5cb12886d45969e3990f
2024-02-16 09:05:03 +00:00
Alf Eaton
00d043cc72 Ensure that the selection layer updates when the review panel is toggled (#17021)
GitOrigin-RevId: e5418ae642e0c46f12c633fc71323bb86018c42a
2024-02-16 09:04:31 +00:00
Alf Eaton
7b3ffb9fae Standardise types for ranges (#16927)
GitOrigin-RevId: 28dd0eb67e1684e6bd0e452d15315ce1f9e3481a
2024-02-09 09:06:51 +00:00
Tim Down
3a88a60e23 Merge pull request #16700 from overleaf/td-scroll-comment-input-into-view
Scroll comment textarea into view after autofocus

GitOrigin-RevId: c8542f40d25772a14e7511702c0e47b7001be275
2024-02-05 09:04:21 +00:00
Alf Eaton
cac1ab1259 Add tags to Sentry error reports (#16465)
GitOrigin-RevId: 1d014e8cc9f87d249a285b247c35f12465ecb93a
2024-02-02 09:03:23 +00:00
Alf Eaton
614d1d05cc Maintain the current scroll position when applying remote changes (#16777)
GitOrigin-RevId: 5d2d0fd5aaefcc6b1e7f4dbd2ce29287cf8dbbdb
2024-02-02 09:03:20 +00:00
Alf Eaton
373c4736e8 Wrap the useCodeMirrorMeasurement state setter in a timeout (#16818)
GitOrigin-RevId: 9f7c12f679ab3947724cc52c63fcee198c73ae87
2024-02-02 09:03:11 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
2024-01-29 09:03:04 +00:00
Alf Eaton
5871978272 Use renderMessage (#16628)
GitOrigin-RevId: 9f627a31d0f8ffce841f04f5a9bfa09f6abcd0a3
2024-01-24 09:04:08 +00:00
Alf Eaton
5e3deba9fe Dispatch 'UNSTABLE_editor:extensions' event on 'editor:extension-loaded' (#16611)
GitOrigin-RevId: a1d93330a7633c6d5870e2c368ab45a4a586db35
2024-01-24 09:03:28 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
2024-01-19 09:05:28 +00:00
Alf Eaton
612c7c28b0 Merge pull request #16511 from overleaf/ae-upgrade-uppy
Upgrade Uppy to v3

GitOrigin-RevId: ca3e366a20ac651a98aafe12bf319b1968ac6ec1
2024-01-19 09:05:05 +00:00
Alf Eaton
4bca3de8d2 Add estimated height to some block widget decorations (#16485)
GitOrigin-RevId: f59da18228e038b1295ccc0128a33acd2de4f9f9
2024-01-19 09:05:01 +00:00
Alf Eaton
22b5828b3d Move Writefull toolbar loading/initialisation into a React component (#16546)
GitOrigin-RevId: 1cb6efa7cab2babb33800fef9469fca3addbdaf5
2024-01-19 09:04:52 +00:00
Mathias Jakobsen
7c3c3047fe Merge pull request #16588 from overleaf/mj-usepackage-fix
[web] Copy single backslash in column width modal

GitOrigin-RevId: ee3e3eadac067dac1d955adc04709e8ab3121a59
2024-01-19 09:04:37 +00:00
Mathias Jakobsen
8d7fbf5a47 Merge pull request #16522 from overleaf/mj-table-generator-cypress-tests
[web] Add cypress tests for table generator

GitOrigin-RevId: c77454763cfc83e4869e75ba247369e6255a0553
2024-01-19 09:04:33 +00:00
Mathias Jakobsen
80a6424343 Merge pull request #16048 from overleaf/mj-table-column-width
[visual] Allow setting column widths in table generator

GitOrigin-RevId: 3bd4bb05dd3b29d0bd62fbc41da45eda282fecf4
2024-01-19 09:04:28 +00:00
David
29bfdae57d Merge pull request #16523 from overleaf/dp-editable-file-extensions-2
Make cfg, ltx, Rnw and inc files editable in the editor

GitOrigin-RevId: 1999c29ea451aa3f362ffa09f6f4d5889beaf404
2024-01-17 09:03:53 +00:00
Thomas
e1c58c2aaf Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions
Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b
2024-01-16 09:04:09 +00:00
Domagoj Kriskovic
21a4e0b6b3 [visual] Skip moving cursor inside argument if there is no decoration (#16365)
* [visual] Skip moving cursor inside argument if there is no decoration

* Refactor skipAtomicRanges function

* rangeSet outside the loop, continue rather than return

* use rangeSet.between

* prettier

GitOrigin-RevId: 85ef817e09ea7eb854cec43cb7866f61b4bfbc21
2024-01-16 09:03:59 +00:00
ilkin-overleaf
f67e19f6d2 Merge pull request #16453 from overleaf/ii-review-panel-dismiss-bulk-actions
[web] Fix bulk actions in review panel

GitOrigin-RevId: c78c99b0a3b005a0a4490ce393eb5d540f23ebc2
2024-01-15 09:04:31 +00:00
Alf Eaton
4a7a24b44d Update the CodeMirror language when the current file is renamed (#16342)
GitOrigin-RevId: 8b51df0d1acfeeb8b0323cebf6de78572c8cb95c
2024-01-15 09:04:27 +00:00
Alf Eaton
ace673b95a [visual] Decorate \ce command (#16459)
GitOrigin-RevId: 0eab030489f97e43874e41d6d4895dc4de46521a
2024-01-15 09:04:08 +00:00
David
a2da947a1f Merge pull request #16437 from overleaf/dp-remove-visual-editor-feedback-icon
Remove visual editor feedback badge

GitOrigin-RevId: c84cc7b6630642853848fad46695bff6ae2a990a
2024-01-12 09:03:19 +00:00
Alf Eaton
fc8892e4fb Expose ScopeValueStore via window.overleaf.unstable.store (#16404)
GitOrigin-RevId: 4b251639296405c0a9487f063e8b049687860004
2024-01-09 09:03:46 +00:00
Domagoj Kriskovic
e27abe56b8 Show argument completions even if it has more than 245 chars (#16352)
* Show argument completions even if it has more than 255 chars

* use tokenBefore for existingKeys

* use 'ShortArg' token so braces are escaped

* refactor argument completion logic

* remove extra filter

* Add makeMultipleArgumentCompletionSource for arguments with multiple keys

* revert makeArgumentCompletionSource

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: f5aa70fe5e58e04efe0c4e8668957f61a7fa7911
2024-01-09 09:03:40 +00:00
Jimmy Domagala-Tang
3617196760 Merge pull request #16419 from overleaf/jdt-fix-grammarly-offer-link
fix the grammarly offer id

GitOrigin-RevId: 996501ebb50b64bd8f9bd46305ba47baa37fee88
2024-01-08 09:05:45 +00:00
Jimmy Domagala-Tang
5f38a930a5 Merge pull request #16319 from overleaf/jdt-grammarly-ad-redesign
Grammarly Ad redesign

GitOrigin-RevId: 28d0ae871b6303b31aadb59abc80b625d529cc9b
2024-01-08 09:05:40 +00:00
Alf Eaton
cf0e260a36 Recalculate toolbar overflow when buttons change (#16350)
GitOrigin-RevId: 70ab356172bc57630b6032a6400fb08e8fd33464
2024-01-08 09:05:17 +00:00
Alf Eaton
84898dca5d Remove margin from table grid popover (#16337)
Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com>
GitOrigin-RevId: 71673d7d9a18baf44027e82cc34058e3db052591
2024-01-08 09:05:12 +00:00
Alf Eaton
84ebb1c8f2 Merge pull request #16378 from overleaf/ae-upgrade-codemirror-3
Upgrade `@codemirror` dependencies

GitOrigin-RevId: 242b1dbcf2878869957f40a5522dabcbcc181b5b
2024-01-08 09:05:02 +00:00
Jimmy Domagala-Tang
21dd23d0e4 Merge pull request #16318 from overleaf/jdt-fix-multiple-popups
Show only one editor notification at a time

GitOrigin-RevId: 88a0309da121e9545136cd718ed24710a9d25363
2024-01-04 09:03:40 +00:00
Alf Eaton
4f5ca6624e Move responsibility for parsing and validating table data out of the tabular widget (#15152)
GitOrigin-RevId: bba823ca036501a527f08746cffb155641d3becf
2024-01-04 09:03:29 +00:00
Alf Eaton
621bae03ca Use collapsePreambleEffect (#15866)
GitOrigin-RevId: e07a48ba5a7ca2ce30aa6933030f8eae970a65b5
2024-01-04 09:03:26 +00:00
Alf Eaton
c84e45bc06 [cm6] Only rebuild changed line indentation decorations (#16126)
GitOrigin-RevId: ba1f29125ab0f40742c57cfb5eae82315ab8629b
2024-01-04 09:03:23 +00:00
Alf Eaton
8feef7bf5e Remove findEffect (#16343)
GitOrigin-RevId: b8472f5128deac5e7f94fb1ec1e64899a8da510a
2024-01-04 09:03:20 +00:00
Alf Eaton
dc962832f0 Ensure that only one toolbar dropdown is open at a time (#16344)
GitOrigin-RevId: db06091ec35886f38de2a320eba9126b35d33064
2024-01-04 09:03:17 +00:00
ilkin-overleaf
20485b886f Merge pull request #16278 from overleaf/ii-ide-page-prototype-review-panel-entry-hover
[web] Remove entry hover from review panel

GitOrigin-RevId: 6bcfb28e20d7a8826301c34499340b6a7d2745db
2024-01-04 09:03:14 +00:00
Jimmy Domagala-Tang
0ac514f81b Merge pull request #16293 from overleaf/jdt-grammarly-perm-advert
Grammarly Permanent Collaboration

GitOrigin-RevId: 0ef47cb7dcb4b175c4d5f3a3c2dbe2e6590a69de
2023-12-18 09:05:12 +00:00
ilkin-overleaf
fbed0cb943 Merge pull request #16268 from overleaf/ii-ide-page-prototype-review-panel-layout-to-left
[web] Review panel popovers

GitOrigin-RevId: 4424abab97b197013063679bd8efcac001f458ad
2023-12-18 09:04:18 +00:00
Alf Eaton
c2b553e915 [ide-react] Improve file tree and outline components in the editor sidebar (#16225)
* Upgrade react-resizable-panels
* Add FileTreeOpenProvider
* Add OutlineProvider and OutlineContainer
* Convert Outline tests to Cypress

GitOrigin-RevId: afd9ae8190edf37642e36a4ffb331f1182c8982d
2023-12-18 09:03:53 +00:00
ilkin-overleaf
5e7665e322 Merge pull request #16162 from overleaf/ii-ide-page-prototype-review-panel-issues-1
[web] Review panel editor widgets fix

GitOrigin-RevId: a762ce3983fd7a3a99b8be5647baea4f8a0bb76c
2023-12-18 09:03:49 +00:00
Alf Eaton
a074054cc9 Add memo to some components (#16094)
GitOrigin-RevId: e4bea140d872ac3f8b2aca7833e658af684a1438
2023-12-15 09:03:22 +00:00
ilkin-overleaf
456d831eab Merge pull request #16188 from overleaf/ii-rp-collapse-height
[web] Review panel comment container fix

GitOrigin-RevId: 0577949e711046303d25ba7e724564227d4a1bc7
2023-12-14 09:03:30 +00:00
Eric Mc Sween
a9d7f99446 Merge pull request #16156 from overleaf/jdt-writefull-notif
Writefull editor notification

GitOrigin-RevId: 1a5077164682dbec67738af0684d364571802816
2023-12-14 09:03:27 +00:00
ilkin-overleaf
989bd87785 Merge pull request #16104 from overleaf/ii-rp-add-comment-when-large-selection-is-made
[web] Review panel add comment when large selection is made

GitOrigin-RevId: 9c73668d6420575a3f2630541ba0c57ff713141a
2023-12-11 09:03:24 +00:00
ilkin-overleaf
b715cb3b16 Merge pull request #16152 from overleaf/ii-ide-page-prototype-review-panel-mini
[web] React ide page mini review panel

GitOrigin-RevId: 4c4ee8095446a2f72371024b93a07dbd1dbd2a63
2023-12-11 09:03:21 +00:00
Alf Eaton
6270dd0e2a [visual] Decorate keywords command (#13724)
GitOrigin-RevId: ffd737705098c8a3eb0de5fe8ffbbc656c30d17c
2023-12-11 09:03:15 +00:00
Jimmy Domagala-Tang
785b35241e Merge pull request #16148 from overleaf/jdt-grammarly-promo-wording
update grammarly promo wording

GitOrigin-RevId: 2c1e57fae0c835da322e61f193467078b950c7f5
2023-12-08 09:04:41 +00:00
ilkin-overleaf
e450b702e8 Merge pull request #16120 from overleaf/ii-rp-track-changes-indicators
[web] Review panel track changes indicators

GitOrigin-RevId: 8911ca1774648ecdde6f0ee173b06f20b1de4e9a
2023-12-08 09:04:24 +00:00
ilkin-overleaf
c3689ca6f3 Merge pull request #16138 from overleaf/ii-ide-page-prototype-review-panel-overview-loading
[web] React ide page overview switch

GitOrigin-RevId: 9a24a8ba9ed8e86d486a12a65259d25c1352c864
2023-12-08 09:04:19 +00:00
ilkin-overleaf
ffb24e061e Merge pull request #16139 from overleaf/ii-ide-page-prototype-review-panel-line-height
[web] React ide page line height

GitOrigin-RevId: da8c9cd178bc089fdc208abd1c453f7666ff58b1
2023-12-08 09:04:15 +00:00
Eric Mc Sween
94b9d1fa48 Merge pull request #16073 from overleaf/em-postpone-tutorials
Support postponing tutorials

GitOrigin-RevId: fe662086c87cc1909d6d9eeac07f85e306d64418
2023-12-06 09:04:58 +00:00
Alf Eaton
d30e876999 Merge pull request #16119 from overleaf/ae-revert-indentation
Revert "Only rebuild changed line indentation decorations (#16092)"

GitOrigin-RevId: 5c4fe9820812551863fc93d74e201bb159e2f14d
2023-12-06 09:04:50 +00:00
Alf Eaton
3f98752986 Avoid using isEqual for outline comparison (#16093)
GitOrigin-RevId: 8901f77eb25295882f6563fa2f1835d18d332c59
2023-12-06 09:04:27 +00:00
Alf Eaton
c4b05f7a73 Only rebuild changed line indentation decorations (#16092)
GitOrigin-RevId: 13855598e2cfc06d2ea2357d1c71875993a106a9
2023-12-06 09:04:23 +00:00
Alf Eaton
18ad44c278 Use permissions.write for editor editable state (#16011)
GitOrigin-RevId: b38ce53fa90a739d9e38ddcc57b01dfa0d9a104c
2023-12-06 09:04:09 +00:00
Jimmy Domagala-Tang
f37cc887e3 Merge pull request #16111 from overleaf/jdt-fix-grammarly-link
fixed grammarly affiliate discount link

GitOrigin-RevId: b57ab79594f75365793fcb991bb6fc69f93b6292
2023-12-05 09:04:36 +00:00
Jimmy Domagala-Tang
e57806b204 Merge pull request #15046 from overleaf/jdt-gramr-ad
creating notification for grammarly collab ad

GitOrigin-RevId: 984869bb561a2b2d3210f1018b93b24aedef9783
2023-12-05 09:04:25 +00:00
ilkin-overleaf
8035241cc0 Merge pull request #16065 from overleaf/ii-ide-page-prototype-review-panel-add-comment
[web] React ide page add comment

GitOrigin-RevId: 4c2442ccc77760d4a27268551c9dd2d73fcdba84
2023-12-05 09:04:06 +00:00
ilkin-overleaf
de945a432d Merge pull request #15999 from overleaf/ii-ide-page-prototype-review-panel-accept-reject-changes
[web] React ide page accept/reject changes

GitOrigin-RevId: 0bb8e3759c7edbef16be04b2f200ae3686c3a53c
2023-11-30 09:03:43 +00:00
Mathias Jakobsen
1e1a6f62a7 Merge pull request #15960 from overleaf/mj-bibtex-field-plus
[lezer] Support plus character in BibTeX field name

GitOrigin-RevId: a8af42fa9c372b36ed2ec0354bafa76154dd8d18
2023-11-30 09:03:23 +00:00
Alf Eaton
d40de2018c Remove Angular/Pug review panel code (#15935)
GitOrigin-RevId: de782d4b47d987f6434a34bea487568b269e8d85
2023-11-29 09:04:13 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Alf Eaton
298acac919 Ensure that codemirror-emacs and codemirror-vim are dynamically imported (#15902)
GitOrigin-RevId: e2425e83a161c11c371246263a07d674e19ec7e7
2023-11-28 09:04:19 +00:00
ilkin-overleaf
81f5a1308e Merge pull request #15909 from overleaf/ii-ide-page-prototype-review-panel-refresh-ranges
[web] React ide page refresh ranges

GitOrigin-RevId: 7f79b8f63869ee39fef9a101e6dcc56c39af8df7
2023-11-27 09:04:26 +00:00
ilkin-overleaf
a75b44a6fc Merge pull request #15861 from overleaf/ii-ide-page-prototype-review-panel-delete-thread
[web] React ide page delete thread

GitOrigin-RevId: 46e93d67d597a2277c771bda2a4837a871339224
2023-11-27 09:04:19 +00:00
ilkin-overleaf
e4f5afc0c0 Merge pull request #15829 from overleaf/ii-ide-page-prototype-permissions
[web] React ide page permissions

GitOrigin-RevId: 727d33e0654d4bfefe5e710e553895f793cacb82
2023-11-24 09:04:27 +00:00
Alf Eaton
604b4e5fdb Ensure that submitOps is called in a timeout (#15840)
GitOrigin-RevId: f4b5f9649a18e5e0ea2332b6e8c90426d7c055d6
2023-11-23 09:03:00 +00:00
Tim Down
9f80dd48e8 Merge pull request #15814 from overleaf/td-review-panel-indicator-hover
Fix review panel comment hover bug

GitOrigin-RevId: ddd6f8f073a2af189c990c8942a388cae412f8c6
2023-11-22 09:04:48 +00:00
Tim Down
38efea39f2 Merge pull request #15707 from overleaf/td-user-settings-context
Move user settings to a context

GitOrigin-RevId: 9a9d55dfee9f71cee323fe64d1442303ac7cfeb2
2023-11-22 09:04:39 +00:00
Tim Down
4f13470345 Merge pull request #15819 from overleaf/td-review-panel-comment-selection
Prevent selection within review panel entry being immediately cleared

GitOrigin-RevId: cca7206a6620bed8cae1bb55a064102204a00751
2023-11-22 09:04:35 +00:00
Tim Down
86c06d8c99 Merge pull request #15815 from overleaf/td-persist-unsaved-comment
Persist unsaved comment in the front end after not submitting

GitOrigin-RevId: a7ffee6f5fbfb7151a2ef7233ba4412d0db33e19
2023-11-22 09:04:21 +00:00
Alf Eaton
cdd9ff9ed0 Migrate extension to @overleaf/codemirror-tree-view (#15769)
GitOrigin-RevId: 8355158040923a55dafc7b1c3f566f7e7703cb02
2023-11-20 09:03:35 +00:00
Alf Eaton
bf6257af80 Exclude "add-comment" and "bulk-entries" from overview entry count (#15718)
GitOrigin-RevId: 0aae510a36aa717b601795eb51d8c97f9309ada2
2023-11-20 09:03:30 +00:00
ilkin-overleaf
7db5d761ea Merge pull request #15557 from overleaf/ii-ide-page-prototype-review-panel-track-changes
Review panel track changes for React IDE page

GitOrigin-RevId: d061596581ff10bd897b286dcd5c280ce79a6384
2023-11-17 09:03:02 +00:00
Tim Down
6f34a84ebd Merge pull request #15684 from overleaf/td-ide-page-main-doc-left-menu
Add docs to FileTreeDataContext to replace 'docs' scope value in React code

GitOrigin-RevId: 430f795eb0cd17f0f4fab9c61e46fb04ff3030b3
2023-11-14 09:04:40 +00:00
Alf Eaton
1819f3e4e7 Only focus the URL input when no URL has been entered (#15673)
GitOrigin-RevId: e89406f5f0921898901c3c0d298e48e345a65621
2023-11-10 09:04:04 +00:00
Alf Eaton
54c55360c4 Remove completion and shortcut event logging (#15633)
GitOrigin-RevId: 35eedb7b18200badef8226eecc58b3c35344f256
2023-11-07 12:34:56 +00:00
ilkin-overleaf
0c403bf8e3 Merge pull request #15397 from overleaf/ii-ide-page-prototype-review-panel
Init review panel for React IDE page

GitOrigin-RevId: fc23201055ae892c5c1d5cb88e472a0bb0cd6c25
2023-11-03 09:00:02 +00:00
Alf Eaton
221d16f4e4 Disable transSupportBasicHtmlNodes in react-i18next config (#15430)
* Set transSupportBasicHtmlNodes to false
* Update ESLint rule
* Convert Trans to t
* Convert shouldUnescape={true}
* Convert some arrays to objects
* Update translations

GitOrigin-RevId: 64a50318388abcada408f72d949de148129a9f63
2023-10-31 09:04:04 +00:00
Alf Eaton
8980666921 [visual] Hide/disable editing features in href tooltip when doc is read-only (#15451)
GitOrigin-RevId: 22f07849c0a09a4536f7bbbe16a43514520cba8b
2023-10-31 09:03:52 +00:00
Tim Down
c34c95b46d Merge pull request #15444 from overleaf/td-remove-root-folder-scope-use
Remove use of root folder scope in figure modal

GitOrigin-RevId: d07247b644d312ef711f5601d3c10a3274e43416
2023-10-27 08:03:13 +00:00
Tim Down
13f246a85e Merge pull request #15342 from overleaf/td-remove-file-tree-manager-in-react
Remove use of FileTreeManager in React code

GitOrigin-RevId: f15bc9b4f84e0f65709b9850ed8cc5d3637efa7f
2023-10-27 08:03:10 +00:00
Tim Down
01439641ca Merge pull request #15376 from overleaf/td-ide-page-working-editor
React IDE page: working editor

GitOrigin-RevId: 3ba8cb787a6f7f8435686d8962adb7444d09acb5
2023-10-27 08:03:07 +00:00
Mathias Jakobsen
7da8e3b646 Merge pull request #15435 from overleaf/mj-scroll-content-width-fix
[web] Fix broken scrolling with table rendering error

GitOrigin-RevId: 425c9ccf2f7f40e0842455eeb40975171c1f0d16
2023-10-26 08:03:35 +00:00
Alf Eaton
e22c1d70f3 [visual] Disable figure and table editing when read-only (#15349)
GitOrigin-RevId: ac0f9eef7bf2d88afd05689fa89b11716747b970
2023-10-26 08:03:08 +00:00
Alf Eaton
9868ce46ec Fix "add new comment" keyboard shortcut (#15404)
GitOrigin-RevId: d675abbf0977d5c60f332136e98c55a765cf87e9
2023-10-25 08:04:37 +00:00
Alf Eaton
43f1a7fd2e Enable editor toolbar for read-only users (#15279)
* Make the editor toolbar available for read-only users
* Hide replace in search form when read-only

GitOrigin-RevId: 2867868d0914da797294084df37163e92578cd57
2023-10-20 08:03:37 +00:00
Alf Eaton
7755203ff7 Enable ESLint rule that enforces t when preferable to Trans (#15253)
GitOrigin-RevId: d11b3f587b462d400a8d68128dc8be342415bf7d
2023-10-20 08:03:34 +00:00
Tim Down
a39a3286b4 Tweak visual editor CSS to prevent excessive padding (#15145)
Use JS to measure editor content width and use it in padding calculation

GitOrigin-RevId: dfc4499aa7762f9f2d7ce5ab9813b698bce0245c
2023-10-19 08:02:56 +00:00
Jakob Ackermann
83cf21d8cf Merge pull request #15271 from overleaf/jpa-lazy-loading
[web] lazy load big optional UI elements

GitOrigin-RevId: 18d723c66834be3984b74c3c89cfb46e2fffbfc1
2023-10-18 08:04:05 +00:00
Jakob Ackermann
6212b352fb Merge pull request #15118 from overleaf/jpa-mj-remove-promise
[web] remove access to uninitialized and unused promise variable

GitOrigin-RevId: a554511dc501f0af936ba0564fded40b62b87660
2023-10-16 08:04:07 +00:00
Jakob Ackermann
d4a271b898 Merge pull request #15062 from overleaf/jpa-worker
[web] bring back file extension for worker entrypoints

GitOrigin-RevId: 93c2a59e5bc867460e82f3e7023d9cbfce1f16e1
2023-10-16 08:03:59 +00:00
Alf Eaton
31033224d5 Improve handling of whitespace in pasted HTML (#15074)
GitOrigin-RevId: 48876707e15e1ccd1bb71ce01121033d0b0dbeaf
2023-10-10 07:57:28 +00:00
Alf Eaton
04a4450341 Avoid auto-closing $ directly before a TeX command (#15039)
GitOrigin-RevId: e620d6b5c82e179c294930801a95fc4c2c77db57
2023-10-05 08:04:46 +00:00
Alf Eaton
6dbb2df5b8 Remove editor split tests (#14985)
* Remove source-editor-toolbar split test
* Remove editor-left-menu split test
* Remove paste-html split test
* Remove figure-modal split test
* Remove rich-text split test
* Remove table-generator split test

GitOrigin-RevId: e3fe415b81ff0135d8764cd3f3c91b1dd4a77cf0
2023-10-04 08:04:34 +00:00
Alf Eaton
b3b31fb052 [cm6] Match uppercase file extensions in the include autocomplete (#14956)
GitOrigin-RevId: eb6898ef031dcc05f9fcb530fd4578ffda234a14
2023-10-03 08:04:09 +00:00
Jakob Ackermann
9daa8f5d98 Merge pull request #15040 from overleaf/jpa-js-to-jsx
[web] rename all the JSX files to .jsx/.tsx

GitOrigin-RevId: 82056ae47e017523722cf258dcc83c8a925a28f7
2023-09-29 08:04:29 +00:00
Alf Eaton
637788076a Allow Ctrl+Enter to start a compile while editing a table cell on macOS (#14940)
GitOrigin-RevId: 513affff5af4af9dd12cdb1d730c978e6bdac303
2023-09-28 08:04:51 +00:00
Alf Eaton
db76d1c316 Disable the "literal" option when regex search is enabled (#14936)
GitOrigin-RevId: 0710c60b517cfda19037215c076878c65c418396
2023-09-28 08:04:40 +00:00
Alf Eaton
d1cfc5a783 Use the scrollToMatch strategy when typing a search query (#14944)
GitOrigin-RevId: e381225b49f36cbf8554fe7deaecef73a8137d66
2023-09-28 08:04:36 +00:00
Alf Eaton
cb1b5b7d54 [cm6] Move figure paste handler to core LaTeX extensions (#14957)
GitOrigin-RevId: 2dd6b036c5e9122a7e7564d4246f10444ba593e3
2023-09-28 08:04:32 +00:00
Mathias Jakobsen
dc86b0285a Merge pull request #14663 from overleaf/mj-table-generator-promo
[cm6] Add promotion popover for table generator and pasting formatted text

GitOrigin-RevId: 9096b36ac4f07d1fc862ecc3bd5df033348950ab
2023-09-28 08:04:21 +00:00
Jakob Ackermann
d76c0e2688 Merge pull request #14991 from overleaf/jpa-log-tree
[web] consolidate logTree helper into scripts folder

GitOrigin-RevId: d98a04f1753ba485f835312198f4c79917f7566d
2023-09-28 08:04:17 +00:00
Jakob Ackermann
1213709578 Merge pull request #14980 from overleaf/jpa-debug-console
[web] migrate frontend logging to debugConsole

GitOrigin-RevId: b03ff9030b03fff059738d2270bc4b4912e79f16
2023-09-28 08:04:12 +00:00
Brian Gough
45ca0f796c Merge pull request #14934 from overleaf/revert-14926-revert-14121-bg-best-allow-underscore-in-hyperref-labels
Revert "Revert "allow underscore in hyperref labels""

GitOrigin-RevId: f7b2dd418fa9c0940b778604ed08eccab78f97d2
2023-09-27 08:04:01 +00:00
Alf Eaton
a2bb8a3ecd Handle pasted HTML from Office even if there's an image file on the clipboard (#14852)
GitOrigin-RevId: f0413391ec421c845b435e1392140d265a528ee7
2023-09-25 08:04:59 +00:00
Mathias Jakobsen
ec563e75e2 Merge pull request #14875 from overleaf/mj-linter-href
[web] Allow url characters in href argument in linter

GitOrigin-RevId: c62ee94003328286d1b1c2b3f9e8ee59f97f8139
2023-09-25 08:04:49 +00:00
Alf Eaton
9313a1fbd1 [visual] Configure italic markup to be placed inside the pasted styled element (#14918)
GitOrigin-RevId: b7038381583a6828a9ab24f6d9608c10cf3e370a
2023-09-25 08:04:45 +00:00
Brian Gough
be8474c18e Revert "allow underscore in hyperref labels" (#14926)
GitOrigin-RevId: 843ac214580c00c4a7593b512cfb27b7bf56717e
2023-09-22 08:03:48 +00:00
Domagoj Kriskovic
f7cf7b9028 [cm6] Include affiliation in document preamble (#14824)
* [cm6] Include affiliation in document preamble

* add affil command

* Add mapping to attributeValue

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 6034e07bc5fec23ea704d820acbbe4e77caba651
2023-09-21 08:04:09 +00:00
Domagoj Kriskovic
20f49ae325 send comment over sharejs after thread is created (#14807)
* send comment over sharejs after thread is created

* only react version

* loading gif

GitOrigin-RevId: a6b16a8cae66faa3219f1c9141ee04e303d9f11b
2023-09-21 08:04:05 +00:00
Brian Gough
1ef6c70258 Merge pull request #14121 from overleaf/bg-best-allow-underscore-in-hyperref-labels
allow underscore in hyperref labels

GitOrigin-RevId: c4e0cfcdef92dec959dceba9a7ae55920812fdb0
2023-09-21 08:03:52 +00:00
Alf Eaton
08d8b40934 [visual] Ignore files on the clipboard if the pasted HTML contains a table (#14817)
GitOrigin-RevId: 608a7a7cbe884243268322582873496bcde63305
2023-09-15 08:05:14 +00:00
Alf Eaton
f6e8f3a2a3 Merge pull request #14830 from overleaf/ae-office-paste
[visual] Improve handling of content pasted from desktop Office applications

GitOrigin-RevId: 10ce77bae008ad078afa22c8fac2cb48af3d9cb4
2023-09-15 08:05:10 +00:00
Alf Eaton
ab47ac2c20 Fix the position of the pasted content menu when scrolling (#14834)
GitOrigin-RevId: df0a8290b7838b83e21676eb69924b11e51b38e6
2023-09-15 08:05:06 +00:00