github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Validate URL protocol before opening from Visual Editor tooltip (#18393)

Browse source 
GitOrigin-RevId: 1da255d3e8ccd91e8c8774d140ec663906be948f
This commit is contained in:
Alf Eaton 2024-05-20 11:29:31 +01:00 committed by Copybot
parent e9d4d26fec
commit e7827fbd57
5 changed files with 23 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/web/frontend/js/features/source-editor/components/command-tooltip/href-tooltip.tsx
View file

@ -17,6 +17,7 @@ import {
import { Button, ControlLabel, FormControl, FormGroup } from 'react-bootstrap'
import Icon from '../../../../shared/components/icon'
import { EditorState } from '@codemirror/state'
import { openURL } from '@/features/source-editor/utils/url'
export const HrefTooltipContent: FC = () => {
const state = useCodeMirrorStateContext()
@ -108,7 +109,7 @@ export const HrefTooltipContent: FC = () => {
className="ol-cm-command-tooltip-link"
onClick={() => {
// TODO: unescape content
window.open(url, '_blank')
openURL(url)
}}
>
<Icon type="external-link" fw />

3
services/web/frontend/js/features/source-editor/components/command-tooltip/url-tooltip.tsx
View file

@ -9,6 +9,7 @@ import {
} from '../../lezer-latex/latex.terms.mjs'
import Icon from '../../../../shared/components/icon'
import { EditorState } from '@codemirror/state'
import { openURL } from '@/features/source-editor/utils/url'
export const UrlTooltipContent: FC = () => {
const { t } = useTranslation()
@ -23,7 +24,7 @@ export const UrlTooltipContent: FC = () => {
onClick={() => {
const url = readUrl(state)
if (url) {
window.open(url, '_blank')
openURL(url)
}
}}
>

11
services/web/frontend/js/features/source-editor/utils/url.ts Normal file
View file

@ -0,0 +1,11 @@
const ALLOWED_PROTOCOLS = ['https:', 'http:']
export const openURL = (content: string) => {
const url = new URL(content, document.location.href)
if (!ALLOWED_PROTOCOLS.includes(url.protocol)) {
throw new Error(`Not opening URL with protocol ${url.protocol}`)
}
window.open(url, '_blank')
}

8
services/web/test/frontend/features/source-editor/components/codemirror-editor-visual-command-tooltip.spec.tsx
View file

@ -54,8 +54,8 @@ describe('<CodeMirrorEditor/> command tooltip in Visual mode', function () {
// open the link
cy.findByRole('button', { name: 'Go to page' }).click()
cy.get('@window-open').should(
'have.been.calledOnceWithExactly',
'https://example.com',
'have.been.calledWithMatch',
Cypress.sinon.match.has('href', 'https://example.com/'),
'_blank'
)
@ -112,8 +112,8 @@ describe('<CodeMirrorEditor/> command tooltip in Visual mode', function () {
// open the link
cy.findByRole('button', { name: 'Go to page' }).click()
cy.get('@window-open').should(
'have.been.calledOnceWithExactly',
'https://example.com',
'have.been.calledWithMatch',
Cypress.sinon.match.has('href', 'https://example.com/'),
'_blank'
)
})

8
services/web/test/frontend/features/source-editor/components/codemirror-editor-visual-tooltips.spec.tsx
View file

@ -42,8 +42,8 @@ describe('<CodeMirrorEditor/> tooltips in Visual mode', function () {
})
cy.findByRole('button', { name: 'Go to page' }).click()
cy.get('@open-window').should(
'have.been.calledOnceWithExactly',
'https://example.com/foo',
'have.been.calledWithMatch',
Cypress.sinon.match.has('href', 'https://example.com/foo'),
'_blank'
)
cy.findByRole('button', { name: 'Remove link' }).click()
@ -62,8 +62,8 @@ describe('<CodeMirrorEditor/> tooltips in Visual mode', function () {
})
cy.findByRole('button', { name: 'Go to page' }).click()
cy.get('@open-window').should(
'have.been.calledOnceWithExactly',
'https://example.com',
'have.been.calledWithMatch',
Cypress.sinon.match.has('href', 'https://example.com/'),
'_blank'
)
})