github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-15 23:37:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

[cm6] Match uppercase file extensions in the include autocomplete (#14956)

Browse source 
GitOrigin-RevId: eb6898ef031dcc05f9fcb530fd4578ffda234a14
This commit is contained in:
Alf Eaton 2023-10-02 11:24:50 +01:00 • committed by Copybot
parent ea1fc5f74e
commit b3b31fb052
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/features/source-editor/languages/latex/completions/include.ts
View file

@ -59,7 +59,7 @@ export function buildIncludeCompletions(
}
// TODO: a better list of graphics extensions?
if (/\.(eps|jpe?g|gif|png|tiff?|pdf|svg)$/.test(path)) {
if (/\.(eps|jpe?g|gif|png|tiff?|pdf|svg)$/i.test(path)) {
// path parameter for \includegraphics{path}
completions.graphics.push({
type: 'file',

8
services/web/test/frontend/features/source-editor/components/codemirror-editor-autocomplete.spec.tsx
View file

@ -54,6 +54,10 @@ describe('autocomplete', { scrollBehavior: false }, function () {
_id: 'test-image-file',
name: 'frog.jpg',
},
{
_id: 'uppercase-extension-image-file',
name: 'frog.JPG',
},
],
},
]
@ -191,8 +195,8 @@ describe('autocomplete', { scrollBehavior: false }, function () {
.type('{ctrl+ }')
cy.findAllByRole('listbox').should('have.length', 1)
cy.findByRole('listbox').contains('frog.jpg').click()
activeEditorLine().should('have.text', '\\includegraphics[]{frog.jpg}')
cy.findByRole('listbox').contains('frog.JPG').click()
activeEditorLine().should('have.text', '\\includegraphics[]{frog.JPG}')
})
it('opens autocomplete on begin environment', function () {