Commit graph

23675 commits

Author SHA1 Message Date
David
d74981775c Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
Add missing keyboard shortcuts to new review panel

GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
c872d97295 Merge pull request #21250 from overleaf/dp-resolved-comments-ui
UI tweaks for resolved comments menu

GitOrigin-RevId: 23df6f9f0374277c315d2fb9c9940dd92ec19f4e
2024-10-24 08:05:12 +00:00
David
1c5f5950fa Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
Add options to accept/reject all changes to review tooltip

GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
Domagoj Kriskovic
c4b23b4d39 Add "usingNewReviewPanel" flag in store (#21279)
* Revert "Add isUsingNewReviewPanel flag for writefull (#21111)"

This reverts commit 3491e93ca70fa1db0c751872e233dfebdbe81423.

* add usingNewReviewPanel in store

* fix lint error

GitOrigin-RevId: 56d90a428a2cc45708b8b483dc60a62aae233a85
2024-10-24 08:05:03 +00:00
Antoine Clausse
b2e7477467 [web] Migrate AI Error Assistant to BS5 (#21129)
* [storybook] Rerender story when switching BS3/BS5

* [storybook] Add SCSS loader to storybook

* [storybook] Add some AI error assistant stories

* Rename ai-error-assistant.less to .scss

* Update less variables to sass

* Remove duplicated selector

* Replace react-bootstrap components by `OL...`

* Update Checkboxes after BS5 update

* Add IDs so clicking on labels work
* Add BS5 class name in SCSS

Note: `answer-not-detailed` is used twice in the Radios. I think it's a mistake: there should be another name for the "ai_feedback_the_suggestion_wasnt_the_best_fix_available" radio

* Rename ID `answer-not-detailed` -> `answer-not-best-fix`

* Pass name and value to BS3Radio/BS3Checkbox

* [storybook] Add delay before AI suggestion (shows the animation)

* Add a number after the checkbox/radio IDs, to allow multiple forms to be displayed

Without this, clicks on second form are updating the first form!

Another solution could be to wrap the input in the label, but it comes with other problems. See https://css-tricks.com/html-inputs-and-labels-a-love-story/

* [storybook] Update `LabsAiPromoBanner`

* Use CSS variables instead of hardcoded values

* Make radio input flex

* Replace `blue-10` by `bg-info-03`

* Fix `SuggestFixButton`

* Fix `AiErrorAssistantCopyCode`

* Fix button loading in BS5

* Use OLBadge

* Fix Button variants

* Update `suggestFixAction`

* Migrate Tooltip and Button to BS5 in LabsExperimentWidget

* Update BS3/BS5 button classname in AiErrorAssistantCopyCode

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [storybook] Allow to choose props of `LabsExperimentWidget`

* Fixup `OLTooltip`: Display the tooltip on disabled button in BS5

* Update Tooltips to BS5

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 08d594e772c0a3b6db1c6081337cc2d079f478a5
2024-10-23 08:06:36 +00:00
Antoine Clausse
30860ae9f9 [web] Migrate PDF Logs to BS5 (#21062)
* [web] Migrate Logs components JSX to Bootstrap 5

* [web] Migrate logs.less to logs.scss

* [web] Remove unused class names

* [storybook] Define default Bootstrap version in Storybook

This prevents some warning in the console

* [storybook] Update pdf-preview.stories.jsx

* [storybook] Add pdf-log-entry.stories.tsx

* [storybook] Force re-renders when switching BS version

* [web] Keep files dropdown menu in bounds

* [web] Make files dropdown items not bold in BS5

* [web] Revert unrelated change

* [web] Fixup PreviewLogsPaneMaxEntries

* [web] Add style for log-entry-content-link

* [web] Replace log-entry by OLNotification in `PdfCodeCheckFailedNotice`

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

* [web] Rename `DropdownBS3` to `BS3Dropdown`

* [web] Reuse variables for `toolbar-height` and `toolbar-small-height`

* [web] Set `id` on `DropdownToggle` not `Dropdown`

* [web] Set `log-entry-btn-expand-collapse` in BS3 only

* [web] Remove `block: true` from StartFreeTrialButton in BS3

* [web] Remove unnecessary CSS in `.log-entry-header-link`

* [web] Use semantic color names

* Migrate the downloadable pdf file list to Bootstrap 5

* Remove nested BootstrapVersionSwitcher, fix "key" prop

* Update roles to: `<li role="menuitem">` `<a role="link">`

* Update `log-entry-header-link`: variant ghost and fix colors

---------

Co-authored-by: Rebeka <o.dekany@gmail.com>
GitOrigin-RevId: 89848970ab5d8a8c135335386caf24363f69a34c
2024-10-23 08:06:32 +00:00
Antoine Clausse
d77ca18b0b [web] Remove dead code: history-content & history-root (#20959)
They are duplicated by:
* services/web/frontend/js/features/ide-react/components/history.tsx
* services/web/frontend/js/features/ide-react/components/history-root.tsx

GitOrigin-RevId: c3f13ea9016530182ae623b06e91a9fdb2be7a87
2024-10-23 08:06:27 +00:00
CloudBuild
388f16169e auto update translation
GitOrigin-RevId: a7a23972ddc8c18eff2e2833ea06572cbce676fc
2024-10-23 08:06:23 +00:00
M Fahru
a0ea00b692 Merge pull request #21108 from overleaf/mf-only-one-container-gallery-redesign
[web] Make sure gallery (tagged and non-tagged) page only have a single `.container` on each page

GitOrigin-RevId: df5272082a7f74dcc4051560692eaf715b49dc37
2024-10-23 08:06:19 +00:00
Andrew Rumble
e75e9c4818 Revert "Send subscription -> salesforce/v1 links to analytics"
This reverts commit 52c02138f9ef8141850e2f8ce16f2bab1e7463b0.

GitOrigin-RevId: 022e828a8e41cc73c4087b94d51fa75dbe6cfdb5
2024-10-23 08:06:11 +00:00
Andrew Rumble
6f3c371435 Revert "Add an endpoint for rails to record salesforce mappings"
This reverts commit fcca974a69217dc885c458543a82b4dcc338d98b.

GitOrigin-RevId: cc7e2561a5f6b4866e5f69f4fb41ffb1bad07bb1
2024-10-23 08:06:06 +00:00
andrew rumble
2486f893eb Add an endpoint for rails to record salesforce mappings
GitOrigin-RevId: fcca974a69217dc885c458543a82b4dcc338d98b
2024-10-23 08:05:54 +00:00
andrew rumble
24b27e3863 Send subscription -> salesforce/v1 links to analytics
GitOrigin-RevId: 52c02138f9ef8141850e2f8ce16f2bab1e7463b0
2024-10-23 08:05:50 +00:00
Jessica Lawshe
2d87fe036d Merge pull request #21272 from overleaf/jel-gallery-categories-images
[web] Update categories images for gallery redesign

GitOrigin-RevId: 4a8afef62af5e873f63ce90f976fe924ba9ecbe9
2024-10-23 08:05:38 +00:00
Rebeka Dekany
200e7a75f0 Merge pull request #21226 from overleaf/rd-history-filetree
Migrate the history file tree to Bootstrap 5

GitOrigin-RevId: bb5443d91992ff7241ed5c8bb467fa553e55bb0f
2024-10-23 08:05:31 +00:00
Alf Eaton
d0b5c2f307 Avoid sending ide-open-view-null-once event (#21247)
GitOrigin-RevId: 2f46fe26561bfa2eca36ad605cdd217514aba09d
2024-10-23 08:05:23 +00:00
Alf Eaton
98bf2ac055 Disable spell check setting when doc is read-only (#21253)
GitOrigin-RevId: 1053fefd953d4f60b1c2aef4170f99c6885c265d
2024-10-23 08:05:18 +00:00
Alf Eaton
baed6cc291 Reapply "Remove spell check languages that are only available on the server (#21056)" (#21257)
* Reapply "Remove spell check languages that are only available on the server (#21056)"

This reverts commit a2273a5ff2eeb5660ae992c41e67b7b936dc4e26.

GitOrigin-RevId: 2dfdf87acdf17db894e921fe754c1520df6f01c1
2024-10-23 08:05:14 +00:00
Mathias Jakobsen
4589a192f6 Merge pull request #20565 from overleaf/mj-zotero-search-groups
[web] Add group searching to Zotero

GitOrigin-RevId: c61994a3d2fd871b644479617921c3282abe07c5
2024-10-23 08:05:06 +00:00
Liangjun Song
902ae750dc Merge pull request #21202 from overleaf/ls-scripts-to-esm-2
Migrate scripts folder to esm 2/x

GitOrigin-RevId: 1698bc4f13e026fa281d37a4914a2f997849c761
2024-10-23 08:04:53 +00:00
M Fahru
f2ec640b06 Merge pull request #21113 from overleaf/mf-gallery-header-text-align-center
Center text for gallery-title, this is useful mainly for mobile view

GitOrigin-RevId: 49db14c627125d2c1e1d1f69173ac918d51f4f91
2024-10-22 08:07:57 +00:00
M Fahru
ca6b5ae4ca Merge pull request #21214 from overleaf/mf-new-gallery-search-result-pagination
[web] Fix pagination in gallery search result

GitOrigin-RevId: 2c34afd7bff2f2a47cc585e68433ac3fa4f16589
2024-10-22 08:07:53 +00:00
M Fahru
0811e46b6c Merge pull request #21067 from overleaf/mf-new-gallery-search-result
[web] Implement new gallery search result

GitOrigin-RevId: afc33a07b5ea533b681acf18bd31112a2f48866a
2024-10-22 08:07:42 +00:00
Jessica Lawshe
c37e6a17fb Merge pull request #21215 from overleaf/jel-redesign-black-links
[web] Consolidate black link CSS on pages using new design

GitOrigin-RevId: cdeccee0586efbf67e656828ed597e4441242edd
2024-10-22 08:07:34 +00:00
Jessica Lawshe
18739d122e Merge pull request #21144 from overleaf/jel-auto-width-mobile
[web] Add options for mobile horizontal column alignment and column gaps on CMS BS5 pages

GitOrigin-RevId: 21cf6e181ea6622b06db73c32a4889327146032c
2024-10-22 08:07:30 +00:00
Jessica Lawshe
96ff76dc43 Merge pull request #21219 from overleaf/jel-tagged-gallery-description
[web] Set a max width for the tag description

GitOrigin-RevId: a1af998ff305805f3e6dfba5ae1b2bff38ab54ba
2024-10-22 08:07:26 +00:00
Jessica Lawshe
620969b606 Merge pull request #21217 from overleaf/jel-title-casing
[web] Use sentence casing on gallery "Templates" filter view header

GitOrigin-RevId: d3926efec4cae91ae86121ef3f6d56bb01799284
2024-10-22 08:07:21 +00:00
Jessica Lawshe
270796ffe8 Merge pull request #21211 from overleaf/jel-cms-remove-deprecated
[web] Removed deprecated CMS list element

GitOrigin-RevId: 9d711a2772b9a179c59ea04d6eaadc2313b8987e
2024-10-22 08:07:13 +00:00
Jessica Lawshe
c00835692b Merge pull request #21148 from overleaf/jel-gallery-categories
[web] Begin "Categories" style update on gallery redesign

GitOrigin-RevId: 4af7da520485c47d54c2a0d004fd53edd7e93cc6
2024-10-22 08:07:09 +00:00
Andrew Rumble
b5cd5bd8fa Revert "[web] Migrate modules/server-ce-scripts to ESM"
GitOrigin-RevId: 61d971396b801e7bb3da1c5af7bd5ea4d91f3c9f
2024-10-22 08:07:04 +00:00
Jessica Lawshe
ab6ee04022 Merge pull request #21102 from overleaf/as-gallery-row-styling
Update Gallery Item styling

GitOrigin-RevId: abe5cc73a3d2ea14bf2e02eefb89ccc4d99c020e
2024-10-22 08:07:00 +00:00
Miguel Serrano
4fd0c41665 Merge pull request #21239 from overleaf/msm-jetty-update
[git-bridge] Update Jetty `9.x` to the latest version

GitOrigin-RevId: b9571ed368c159ee8d7d8f22fefc5c33559f8c6f
2024-10-22 08:06:49 +00:00
Alf Eaton
508ed8ad1d Merge pull request #21251 from overleaf/ae-revert-no-session
Revert "Remove spell check languages that are only available on the server (#21056)"

GitOrigin-RevId: 6f77aa92f1b7d7181cec7d470c8e6604b1e90fe3
2024-10-22 08:06:45 +00:00
ilkin-overleaf
a443713b55 Merge pull request #21230 from overleaf/ii-bs5-review-panel-new-add-comment-button
[web] BS5 new review panel add comment button

GitOrigin-RevId: f08686ca431bac3d3df055afd4468bef94656d9c
2024-10-22 08:06:34 +00:00
Alf Eaton
9fdbd5cfb5 Add state.Prec to editor:extensions export (#21222)
GitOrigin-RevId: b8680926a9885f19ebc9227de678674da1765158
2024-10-22 08:06:29 +00:00
Alf Eaton
6c4fac68ca Use Intl.Segmenter when available for identifying words to spell check (#21225)
GitOrigin-RevId: f261ae331e0b1f87f4e88a512b25c8798f0b02c6
2024-10-22 08:06:25 +00:00
Alf Eaton
04dbb7d2f2 Remove spell check languages that are only available on the server (#21056)
GitOrigin-RevId: cfe10a18af8149327754b3a2e62883c7ebc04bfc
2024-10-22 08:06:20 +00:00
Miguel Serrano
c4edd2fffa Merge pull request #21154 from overleaf/msm-esm-ce-scrits
[web] Migrate `modules/server-ce-scripts` to ESM

GitOrigin-RevId: 8856f83b12d5d092e51e5765763737259c4b3985
2024-10-22 08:05:58 +00:00
David
c7eafd69c2 Merge pull request #21014 from overleaf/dk-review-panel-tc-widget
Add "Track changes is On" button when review panel is closed

GitOrigin-RevId: a165201f611860ba531f2eeb3d89f83a695cd017
2024-10-22 08:05:50 +00:00
Domagoj Kriskovic
64460681b8 Fix delete comment/thread in the new review panel (#21199)
GitOrigin-RevId: 95d4db64d2f837322d84a81cbd129ec02ee135a2
2024-10-22 08:05:46 +00:00
Domagoj Kriskovic
1e16de13bc Fix change and insert range decorations background color (#21131)
GitOrigin-RevId: 4bbc7abdc4c52ea31e26ea3fd8cf43d8c9620d47
2024-10-22 08:05:42 +00:00
Domagoj Kriskovic
c606f04cce Sort track changes and comments in overview mode (#21099)
GitOrigin-RevId: 795d30b56e57970363512170f504ab51bd104c93
2024-10-22 08:05:37 +00:00
Domagoj Kriskovic
332e2a38c9 Fix review panel entry focus handler (#21075)
* Fix review panel entry focus handler

* dont check position

* remove event.target checks

* Revert "remove event.target checks"

This reverts commit 3f511e47b6922260666c6952b692f6f0a29d5912.

GitOrigin-RevId: 9271df9cdb36a040d59a97c88f21d6e923ac0404
2024-10-22 08:05:33 +00:00
Domagoj Kriskovic
94d78e68cd Box shadow on review panel entry hover and focus (#21055)
* Box shadow on review panel entry hover and focus

* fix formatting

* added box-shadow in scss

* css priority

* fix styling lint

GitOrigin-RevId: fdf4ff0fbef6c9a924e83d40703958eb28caaa49
2024-10-22 08:05:29 +00:00
Domagoj Kriskovic
42eea0017d Update track change decoration to be cursor-like (#21047)
* Update track change decoration to be cursor-like

* use red-50 color

GitOrigin-RevId: 8c8a2cb9c6abc99aa1d2dace705dba3feeda07fa
2024-10-22 08:05:24 +00:00
Domagoj Kriskovic
db3c69fbcd Fix review panel header positioning in Firefox and Safari (#20995)
* Fix review panel header positioning in Firefox and Safari

* update scss

GitOrigin-RevId: 5427f91f077104639a72f608c8d7572ab7d08a8c
2024-10-22 08:05:20 +00:00
David
87f714f7c3 Merge pull request #21164 from overleaf/dp-add-comment-keyboard-shortcut
Add keyboard shortcut (cmd+shift+c) for adding a new comment

GitOrigin-RevId: 20359426f45e90b09cbc887bac3096adf1b3141a
2024-10-22 08:05:15 +00:00
David
31154bb9f5 Merge pull request #21065 from overleaf/dp-limit-track-change
Truncate text in a tracked change

GitOrigin-RevId: a3c070f0ca2f51545151934d25a26a10c99b7465
2024-10-22 08:05:11 +00:00
David
efa376f4f4 Merge pull request #21120 from overleaf/dp-overview-entry-gap
Adjust size of gap between review panel entries to 4px

GitOrigin-RevId: a09a6fde0e8eb15e0c753e436a1c09434581d6d8
2024-10-22 08:05:07 +00:00
David
af7e388c41 Merge pull request #21122 from overleaf/dp-rp-hide-edit
Hide edit option for other user's comments

GitOrigin-RevId: 317fa57402dfbe2e949fa7b196cbbe246f88257d
2024-10-22 08:05:02 +00:00