Commit graph

4236 commits

Author SHA1 Message Date
Shane Kilkelly
cc81eca902 Account for error being null 2017-03-31 10:46:13 +01:00
Shane Kilkelly
2c62acee0b Cleaner error reporting for addFolder endpoint 2017-03-31 10:31:03 +01:00
Shane Kilkelly
15d0a40f85 When error occurs, unset state.inflight 2017-03-31 10:30:28 +01:00
Shane Kilkelly
49446afb82 Remove duplicate line 2017-03-31 10:30:10 +01:00
Brian Gough
42009093ef Merge pull request #469 from sharelatex/bg-fix-tikzfeynman-code-check
handle the \feynmandiagram command in code check
2017-03-29 15:57:34 +01:00
Brian Gough
13492c7fc4 handle the \feynmandiagram command in code check
pulled from our ace repository https://github.com/sharelatex/ace
commit baeb9aff561d048b8a839683261ffdf149ecd4ef
2017-03-29 15:27:10 +01:00
James Allen
3bf19a38ee Merge pull request #467 from sharelatex/ja-validate-recurly-subscription-on-creation
Handle a 404 from Recurly if account doesn't exist
2017-03-28 16:06:25 +01:00
James Allen
08699d7aa2 Handle a 404 from Recurly if account doesn't exist 2017-03-28 15:46:58 +01:00
James Allen
f53234271f Merge pull request #465 from sharelatex/sk-hide-email-errors
If sending email fails, return a generic error.
2017-03-28 13:16:43 +01:00
James Allen
2e6e51eb6d Merge pull request #464 from sharelatex/ja-validate-recurly-subscription-on-creation
Check Recurly for subscription as well before creating subscription
2017-03-28 13:15:58 +01:00
Brian Gough
e8039c3204 Merge pull request #466 from sharelatex/bg-prevent-exception-on-nonexistent-project
fix unhandled exception in ProjectDetailsHandler
2017-03-28 11:56:38 +01:00
Brian Gough
835d8d618d use error handler 2017-03-28 11:33:37 +01:00
Brian Gough
6002fdbad6 return 404 on project details not found 2017-03-28 10:30:53 +01:00
Brian Gough
f433510e61 return NotFound error in ProjectDetailsHandler 2017-03-28 10:12:52 +01:00
Brian Gough
4e66b045e3 fix unhandled exception in ProjectDetailsHandler 2017-03-28 09:44:50 +01:00
Shane Kilkelly
d2e1efe4a9 fix a daft mistake 2017-03-27 17:45:19 +01:00
Shane Kilkelly
69b9b308d4 If sending email fails, return a generic error.
This prevents us from leaking juicy details of our aws/ses setup via the
password-reset form.
2017-03-27 16:17:38 +01:00
Shane Kilkelly
30c5bbfdfc Add a .nvmrc file 2017-03-27 14:45:34 +01:00
James Allen
7aa4c0c030 Check Recurly for subscription as well before creating subscription 2017-03-27 12:07:43 +01:00
Paulo Reis
e473b5e270 Avoid line breaks in the add comment button. 2017-03-27 10:02:09 +01:00
Henry Oswald
e22da8e530 rename unit test 2017-03-27 09:57:15 +01:00
Henry Oswald
f27dfa54f1 fixup AuthenticationController from missing module after merge 2017-03-27 09:42:49 +01:00
Paulo Jorge Reis
67943a8906 Merge pull request #463 from sharelatex/pr-ab-test-add-comments
PR AB test "add comment" button
2017-03-27 09:32:49 +01:00
Paulo Reis
93934b9c8f Use deploy date. 2017-03-27 09:32:02 +01:00
Henry Oswald
9c7465fd64 Merge pull request #461 from sharelatex/ho-annom-user-events
add identify on login
2017-03-27 09:28:34 +01:00
Henry Oswald
aa4f768513 Merge pull request #455 from sharelatex/ho-bug-fix
multiple small bug fixes
2017-03-27 09:28:28 +01:00
Henry Oswald
379efcb04a Merge branch 'master' into ho-annom-user-events 2017-03-27 09:28:03 +01:00
Paulo Reis
78e8a8319d Put review panel widgets container inside the review panel element; rearrange visibility logic. 2017-03-24 14:04:37 +00:00
Henry Oswald
ed4a321906 remove extra debug route 2017-03-23 15:39:12 +00:00
Paulo Reis
c72ee95177 Refactor AB test participation code; add conversion code. 2017-03-23 15:00:43 +00:00
Paulo Reis
254e4953cb Wire-up AB test for adding comments. 2017-03-23 12:26:21 +00:00
Henry Oswald
cff922a0f5 idendify -> identify 2017-03-22 16:01:26 +00:00
Henry Oswald
ebdce6169e idendifyUser on login 2017-03-22 15:50:49 +00:00
Henry Oswald
f910bb58de add tests for AnalyticsController 2017-03-22 13:11:45 +00:00
Shane Kilkelly
4e6553ebcc Merge branch 'sk-handle-analytics-absence' 2017-03-22 09:35:16 +00:00
Paulo Reis
d611ccd2cb Apply z-index rule to container, not to the button. 2017-03-21 14:28:58 +00:00
James Allen
b22ef30876 Merge pull request #456 from sharelatex/ja-show-too-many-track-changes-error
Show an explanation error message on too many track changes error
2017-03-21 13:15:14 +00:00
James Allen
e705118dfe Merge pull request #457 from sharelatex/pr-new-add-comment-btn
New "add comment" button
2017-03-21 13:15:03 +00:00
Shane Kilkelly
1663f2a8eb Use res.send, not next 2017-03-21 11:09:39 +00:00
Shane Kilkelly
1ed1eaaa05 If analytics is not configured, produce a ServiceNotConfiguredError 2017-03-21 10:57:39 +00:00
Shane Kilkelly
8a8a5a7079 Add a 'ServiceNotConfiguredError' to Errors module. 2017-03-21 10:57:09 +00:00
Paulo Reis
a35f2585c7 Remove unused flag. 2017-03-20 14:02:25 +00:00
Paulo Reis
0e24d7118d Hide new UI behind query string parameter. 2017-03-20 13:56:36 +00:00
James Allen
1d927e5eb1 Merge pull request #454 from sharelatex/ja-show-overlapping-ranges
Add opacity to comment and insert ranges so they can be seen overlapping
2017-03-20 13:50:06 +00:00
James Allen
131d710a83 Merge pull request #453 from sharelatex/ja-cut-and-paste-comments
Move comments when cutting and pasting
2017-03-20 13:49:51 +00:00
Paulo Reis
8951e91e31 Remove add comment button from the mini review panel. 2017-03-20 11:35:35 +00:00
Paulo Reis
2c2abc3cae Wire up new button with existing UI for adding comments. 2017-03-20 11:18:29 +00:00
Henry Oswald
ca3849c0c2 jpeg -> json 2017-03-20 11:08:42 +00:00
Paulo Reis
beac43741c New add comment button. 2017-03-17 17:05:38 +00:00
Paulo Reis
c74449b2e3 Don't show the mini review panel when the only visible entry is the add comment one. 2017-03-17 16:28:21 +00:00