Commit graph

793 commits

Author SHA1 Message Date
Jessica Lawshe
fe34b650e3 Merge pull request #11132 from overleaf/jel-btn-info
[web] Use new button style for download button in file view in editor

GitOrigin-RevId: 33e8c1aeb21a6ba083a5b9ada3d3135916e64e26
2023-01-12 09:03:43 +00:00
M Fahru
82cd2d2a77 perform null check on the old value instead of the new one since to follow the non-react version behaviour
GitOrigin-RevId: 33ef74e1b1da41db8a86fc79ae04fbe49ed194df
2023-01-11 09:10:00 +00:00
M Fahru
94ab78b427 Log error in a promise catch block
GitOrigin-RevId: 09756d52bd6351c55051a74f22f38c450af9a275
2023-01-11 09:09:51 +00:00
M Fahru
7475237170 Refactor project-wide settings:
- Change api function argument (readability)
- create a new wrapper hooks for saving the project to both server-side and angular scope
- Implement the new save project settings hooks on project-wide settings update
- On spell check language update function, add new comment to give more context about the decision

GitOrigin-RevId: 93d558d1e1d4db265a943eeb4366842430900c43
2023-01-11 09:09:40 +00:00
M Fahru
654144dd40 Refactor saveUserSettings: Move sendMB inside the function and change function from supporting multiple settings to only support single key/value pair.
GitOrigin-RevId: 77b9d8fd5cdcbc78f38fd42329b74cf592615638
2023-01-11 09:09:32 +00:00
M Fahru
4444377b11 fix tsc error by re-creating request body object instead of directly assigning it from function argument
GitOrigin-RevId: b17697c7b52c991a06efcbffa0227b6021c5bc8d
2023-01-11 09:09:25 +00:00
M Fahru
b2cf833e9d Remove scope suffix from variable name in react-related files since it's an angular-specific concept
GitOrigin-RevId: b8eea8c8113a977f6cbe07649e1338eea8281841
2023-01-11 09:09:18 +00:00
M Fahru
03e5614969 Remove _csrf in request body since fetchJSON already have X-Csrf-Token set in request header
GitOrigin-RevId: 9dd2389c47ce3537fc4bb22bd8b6b0b83862c5f4
2023-01-11 09:09:11 +00:00
M Fahru
4548f504f7 standardize the naming for rootDocId.
- Remove the `scope` variable suffix
- change `rootDoc_id` to `rootDocId`

GitOrigin-RevId: d8e646ef5f99ba0dbce84ff63c588e63b956a4ec
2023-01-11 09:09:04 +00:00
M Fahru
bdf3b18d4f Change import to import type for type imports
GitOrigin-RevId: 2061bafeca58d063f83a96650403e5741b863c05
2023-01-11 09:08:57 +00:00
M Fahru
608b75c9db Fix linter error because of wrong variable name and camel case issue
GitOrigin-RevId: a5ea8d6c8332133303fcd8e410cc76ac06c5bb97
2023-01-11 09:08:49 +00:00
M Fahru
e3d0380e6f Remove multiple source of type imports; add type on type imports.
GitOrigin-RevId: a6630bb284c456bfbe61901f7331cdd3c13c7f8b
2023-01-11 09:08:42 +00:00
M Fahru
12f5c845b4 Simplify function by removing generic
GitOrigin-RevId: 7732b6782cd1e0130eb56f6b674c03548b8e8315
2023-01-11 09:08:35 +00:00
M Fahru
10bb724197 Fix wrong hook name
GitOrigin-RevId: 58f98b508cf650a6ecab38772faf9ecd38c9a7bc
2023-01-11 09:08:28 +00:00
M Fahru
f2060b35ad Refactor type by reusing type declaration and avoid multiple source of the same type
GitOrigin-RevId: 492a9a524e566cf70b53158b4e5cc6ad57cb6093
2023-01-11 09:08:21 +00:00
M Fahru
f85d17f894 Remove disabling update while listening on socket (ignoreUpdates state) since the logic is more complicated that was originally thought and it will be tested/revisited on a different PR
GitOrigin-RevId: 70cee2f0fc565aaebfb3ead2dd1a58fc5371c816
2023-01-11 09:08:13 +00:00
M Fahru
677ec173ed Disable updating project-wide settings while socket is currently listening to update project-wide settings in a project.
This may happen if the project is being used by multiple people, and we want to avoid race condition on the update since it's possible for multiple people to update setting value at the same time.

GitOrigin-RevId: cdad6a6456e2d9e4ef1812ebfd6f6ef59f23747f
2023-01-11 09:08:06 +00:00
M Fahru
af01ace5a0 refactor function by simplifying function argument (from two arguments to a single object)
GitOrigin-RevId: e4244a07a4ca196afa226e3fac9de74d30f7d4ea
2023-01-11 09:07:59 +00:00
M Fahru
777beaadc3 Don't send spellCheckLanguage request if the old value is the same as the new one
GitOrigin-RevId: 4ef34be7563ff707b6abd44dc8034293c88d2f72
2023-01-11 09:07:52 +00:00
M Fahru
ae5a08e680 Add 'setting-changed' tracking when user changes user-wide settings
GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b
2023-01-11 09:07:45 +00:00
M Fahru
85cbc5b721 Apply prettier
GitOrigin-RevId: 34c7e3b95d061c270c77337c7c82502af289b556
2023-01-11 09:07:38 +00:00
M Fahru
06b0833e33 Add a comment explaining why user settings may be undefined
GitOrigin-RevId: 4460d4184cde5639d326da07121b2728d444c782
2023-01-11 09:07:30 +00:00
M Fahru
5597736057 Fix numerous test fails because of unitialized user settings scope on the test environment
GitOrigin-RevId: a27454285b0c89c6abef560f05c52d35f81fa570
2023-01-11 09:07:23 +00:00
M Fahru
56395d9a95 Save spellCheckLanguage to both project-wide and user-wide setting
GitOrigin-RevId: 059cc64d0fe2e955814a7192f82d4ff8ea4e2572
2023-01-11 09:07:16 +00:00
M Fahru
4bf09e21de Fix tsc lint error by restricting the generic type
GitOrigin-RevId: 11ef7ab4111c7b312b283283829e9b28a80c475c
2023-01-11 09:07:09 +00:00
M Fahru
98fbd330b2 Add socket listener for compiler, imageName, and spellCheckLanguage
GitOrigin-RevId: b12644152387e479e433a014e1a1041ebae36f12
2023-01-11 09:07:02 +00:00
M Fahru
b6b6b9c4b1 Rename "rootDoc_id" to "rootDocId" before sending it to server
GitOrigin-RevId: fc29e152ffd3bf97c00ee817abb07086f6cdfe17
2023-01-11 09:06:54 +00:00
M Fahru
30c32713c6 Add _csrf to request body
GitOrigin-RevId: 87b5a7299fbb795618143421df79375b41f8f921
2023-01-11 09:06:47 +00:00
M Fahru
132bb40a21 replace save project setting hooks with common function and implement set root doc id change
GitOrigin-RevId: e5b204cd93fc188288def529cb22018b3d4f89b6
2023-01-11 09:06:40 +00:00
M Fahru
8ae9839f79 apply prettier
GitOrigin-RevId: dd750756d2bfc625817760510e9bdbade186aef3
2023-01-11 09:06:33 +00:00
M Fahru
c2b0707c2a Change variable declaration location + apply prettier
GitOrigin-RevId: 3237a417c23d5c66c47385e55f8d3cb68bdfc3ca
2023-01-11 09:06:26 +00:00
M Fahru
414540af5c Reduce save/setScope user setting duplication by introducing a new shared hooks
GitOrigin-RevId: 6054143eb042e4ff336b1f325a8cef693ae8c4bd
2023-01-11 09:06:19 +00:00
M Fahru
09b1974a3d Migrate updating overallTheme to react
GitOrigin-RevId: 024ceb3c32c8d90ac0067fbb72d6e7d327b869f0
2023-01-11 09:06:12 +00:00
M Fahru
6c41a65200 migrate user-wide settings post request from angular controller to react
GitOrigin-RevId: b5440178a11b82c5a5840eb310416f1519f85bae
2023-01-11 09:05:57 +00:00
M Fahru
f01a2920cf Migrate editor settings controller to react (this commit includes project-wide settings)
GitOrigin-RevId: 8c47a2699a2f11fda7fd60c5173bf2e29858e37a
2023-01-11 09:05:50 +00:00
M Fahru
67c8fa560e Fix firefox bug where user can't focus on input while renaming file on editor file tree (#11134)
GitOrigin-RevId: daebbe6df4a3fef41cbf25444a31015d306901b3
2023-01-11 09:05:43 +00:00
M Fahru
5f8e10de86 Conform with new design system by changing btn-default to btn-secondary (#10972)
GitOrigin-RevId: 1fac39d3b1e7e68e6feffe467ac21b4cb3253353
2023-01-11 09:05:36 +00:00
Jessica Lawshe
bd3b9007c8 Merge pull request #11078 from overleaf/jel-features-page-analytics
[web] Add analytics to React dash features link

GitOrigin-RevId: 5f62af1af3854b1443734cda6b97334e6eb42711
2023-01-10 09:06:43 +00:00
Jessica Lawshe
38db8bee30 Merge pull request #10958 from overleaf/jel-features-page-link
[web] Update features page link on dash for split test

GitOrigin-RevId: 5b51700a8a4ca89920288b54e08caf88f29dec96
2023-01-10 09:06:36 +00:00
Jessica Lawshe
4ba2fffdf1 Merge pull request #11092 from overleaf/jel-recompile-btn
[web] Add `data-ol-loading` button style

GitOrigin-RevId: 75230fee0e4c1183f389d08b0253402e4fc375b0
2023-01-10 09:06:28 +00:00
ilkin-overleaf
4f35333a39 Merge pull request #9536 from overleaf/ii-adjustable-project-dashboard-panel
[web] Adjustable project dashboard sidebar

GitOrigin-RevId: 1007ecb896bbe215af28fa92d295201b2457aeef
2023-01-10 09:05:44 +00:00
ilkin-overleaf
0d0e855c96 Merge pull request #11074 from overleaf/ii-tagged-trashed-projects
[web] Project dashboard archived and trashed projects appearing not hiding

GitOrigin-RevId: b323be2a1104af54d3af9c9610b584fc0ab24c10
2023-01-10 09:05:28 +00:00
Mathias Jakobsen
2f5eb9c1d4 Merge pull request #11016 from overleaf/ii-dashboard-wrong-action-buttons
[web] Project dashboard wrong action buttons

GitOrigin-RevId: d76c64616a34c63b60bc499b96c6507c1196e666
2023-01-05 09:04:45 +00:00
Mathias Jakobsen
38cc3394e3 Merge pull request #10793 from overleaf/mj-split-test-cleanup
Split test clean-up

GitOrigin-RevId: 7dd6178487022cbefcbc85797dacc3f3fbfa17e2
2022-12-21 09:04:04 +00:00
Davinder Singh
7b7c85527f Merge pull request #10922 from overleaf/ds-remove-classNames
Removing `classNames` function from setting page widgets component

GitOrigin-RevId: df15640996d0b2dea691cab07ebbfc687b8e3f3f
2022-12-19 09:04:25 +00:00
Davinder Singh
306b2b7727 Merge pull request #10844 from overleaf/ds-editor-btn-info-to-secondary
Replacing `btn-info` with `btn-secondary-info btn-secondary` in the editor

GitOrigin-RevId: 1e348b0b09bfd08508a3dbee7df882f41fdc16eb
2022-12-19 09:04:17 +00:00
M Fahru
bed2596468 Implement groups & enterprise awareness banner on project dashboard (#10818)
- Implement the banner on both react and non-react project dashboard
- Use split test with 4 different variants, `save`, `empower`, `did-you-know`, and `default`, each variant has a different copy, except the `default` which won't show the banner to users

GitOrigin-RevId: ee76769dfd38b8e52de8cc0f201c24e41905d016
2022-12-13 09:05:08 +00:00
Alf Eaton
9f1f62b9be Add rich-text mode to CM6 (#10775)
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
2022-12-13 09:03:54 +00:00
June Kelly
e9965498fc Merge pull request #10675 from overleaf/mj-wiki-search-submit
[web] Ignore submit event on wiki search form

GitOrigin-RevId: aa1bc4898b9656bed9e2aeb4c0deef7e4a36383f
2022-12-12 09:03:38 +00:00
June Kelly
46c3fc7563 Merge pull request #10821 from overleaf/jk-fix-pdfjs-comments
[web] Fix pdfJS `imageResourcesPath`, missing `/` at end of URL

GitOrigin-RevId: a2488f90d89b7693f0ecdd688835e9cac028cc34
2022-12-12 09:03:31 +00:00
Tim Down
d420c247e1 Merge pull request #10785 from overleaf/ae-mathjax-inline-single-dollar
Move MathJax inlineMath configuration from element to page

GitOrigin-RevId: f17af484a0df517d6006ee1d42bde01d9c1fed08
2022-12-09 09:04:25 +00:00
ilkin-overleaf
7650e06074 Merge pull request #10802 from overleaf/ii-dashboard-leave-button
[web] Project dashboard leave button

GitOrigin-RevId: 6c472ffe9b3d07f103f32e07fec9996a6d45caef
2022-12-09 09:04:01 +00:00
Alf Eaton
12af54069c Merge pull request #10787 from overleaf/ae-pdfjs-3
Start upgrading pdf.js to the latest version

GitOrigin-RevId: e7d8c6dedb0fe58ba31626408df81fd42ba1ca3b
2022-12-09 09:03:53 +00:00
Davinder Singh
ac8edba968 Merge pull request #10730 from overleaf/ds-settings-page-disabled-btn-fix
added a new class btn-disabled for pointer-events

GitOrigin-RevId: 334d81f15a7c8446a7ffa16dfbc6f3852b4533a9
2022-12-08 09:03:50 +00:00
Davinder Singh
4adfca52bf Merge pull request #10682 from overleaf/ds-btn-default-to-secondary-in-editor-part-2
Replacing btn-default with btn-secondary in the editor Part-2

GitOrigin-RevId: 708aa29070bb3049afbc8ee1a282eaa1018594a8
2022-12-08 09:03:42 +00:00
Davinder Singh
d6b39c4bb3 Merge pull request #10653 from overleaf/ds-btn-default-to-secondary-in-editor
Replacing `btn-default` with `btn-secondary` in the editor

GitOrigin-RevId: 46aa8c92c9981eb2f253828ee65424bfb7217fb2
2022-12-08 09:03:35 +00:00
Davinder Singh
ec920ade78 Merge pull request #10563 from overleaf/ds-btn-success-to-btn-primary
replacing `btn-success` with `btn-primary`

GitOrigin-RevId: 77b90dbc4470bc059c40294b9764d1184f0b0bb8
2022-12-08 09:03:28 +00:00
Tim Down
08567c290e Add second CM6 switch-away survey (#10789)
Restart CM6 switch-away survey

GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
2022-12-07 09:04:35 +00:00
Tim Down
fa67c3fcff Merge pull request #10797 from overleaf/td-editor-toggle-analytics
Add analytics for switching editor

GitOrigin-RevId: 7b44e53105e8669e97cb9c4821dfbc830faff779
2022-12-07 09:04:06 +00:00
ilkin-overleaf
2675cab92e Merge pull request #10394 from overleaf/ii-password-reset-and-strength-checking
[web] Password reset strength checking and UI updates

GitOrigin-RevId: 442a5c9e7e9d0a61d3ae649f3526bc3c02fd5704
2022-12-07 09:03:36 +00:00
Jessica Lawshe
07a9fa4a72 Merge pull request #10781 from overleaf/jel-upgrade-primary
[web] "Upgrade" button as primary on settings page

GitOrigin-RevId: 10c9d18ee8eca2c72660f2bfe892adf22c7dc982
2022-12-06 09:05:33 +00:00
Jessica Lawshe
a20d102e0a Merge pull request #10778 from overleaf/jel-share-primary-btn
[web] Make the "Share" button primary

GitOrigin-RevId: 11da6826dc0c8d3b660a7ac20dd9cc938c898250
2022-12-06 09:05:19 +00:00
Jessica Lawshe
a206eaa731 Merge pull request #10777 from overleaf/jel-link-accounts-primary
[web] Link accounts as primary button

GitOrigin-RevId: c5b8c7444c354876e368bcc1973c4c44b31494cb
2022-12-06 09:05:11 +00:00
Miguel Serrano
974f16a4f4 Merge pull request #10743 from overleaf/msm-fix-project-invites
[react-dash] Fix accepting invite changes status in all notifications

GitOrigin-RevId: 2f81ab7a93829fc4bf7ecad2f2bfa69559d05fee
2022-12-06 09:04:02 +00:00
June Kelly
4b856dbd70 Merge pull request #10116 from overleaf/jel-dash-action-checked-list
[web] Use other checked list class on dash action modal

GitOrigin-RevId: 22afaf805e57813e243543912811207a74ae85ed
2022-12-02 09:03:42 +00:00
Davinder Singh
e5826446e7 Merge pull request #10582 from overleaf/ds-change-btn-default-to-secondary
`btn-default` to `btn-secondary`

GitOrigin-RevId: 52edf7f5da123e366b027e43e86e81c6260ebff3
2022-12-01 09:04:21 +00:00
June Kelly
3d4f146c97 Merge pull request #10607 from overleaf/dash-delete-btn-danger
Changed delete button from primary to danger

GitOrigin-RevId: 1b3bd036100e8bc39565957ef11d05155b3220ae
2022-12-01 09:03:53 +00:00
M Fahru
f27562eb12 Data handling for settings in editor left menu react migration (#10470)
- Importing SettingsController from the angular code, which enables post requests for every select menu and socket handler for compiler, texlive version, and main document select option
 - New context for the data handling infrastructure between react and angular. The data is still located in the angular version, and I use the context only as a proxy to fetch/post new data.

GitOrigin-RevId: 59009bceb128d82969a2318e90036aacf79f9887
2022-11-30 09:04:32 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
31c503be2d Add 10 seconds delay before showing grammarly warning
GitOrigin-RevId: 11bb3ca5704ef5cc782d14eb6f4f10a1fa2a656e
2022-11-25 09:04:33 +00:00
M Fahru
6dcc22642a Update "go to line" hotkey for cm6 and add new info text in hotkeys modal
* Update "go to line" hotkey for cm6 and add new info text in hotkeys modal

* Differentiate modal title between cm6 and ace hotkeys

* Update test to reflect change in hotkeys modal title

* Add test for hotkeys modal bottom text

* Update test on editor left menu hotkeys button to reflect change in hotkeys modal title

GitOrigin-RevId: 61bae16313ea7a37fa3b9441dbe5a93ab7823d01
2022-11-25 09:04:20 +00:00
ilkin-overleaf
791732005c Merge pull request #10647 from overleaf/ii-dashboard-react-issues-fix
[web] Projects dashboard react bug fixes

GitOrigin-RevId: 4984515de97eb0d7ec50d9d497aff52c6a4a8b7e
2022-11-25 09:03:54 +00:00
Jessica Lawshe
a9741c190c Merge pull request #10471 from overleaf/jel-disabled-btn
[web] Style updates for `btn-danger` and deprecated secondary btns

GitOrigin-RevId: bd121147aa6c7b0a8f6b492b47667adb9369d078
2022-11-18 09:06:28 +00:00
Jessica Lawshe
024f6ee24e Merge pull request #10467 from overleaf/ds-btn-info-new-css-part-2
Updating`btn-info` to `btn-info-secondary` - part 2

GitOrigin-RevId: 934dd633494454277432810c4a1e70bb17829bd7
2022-11-18 09:05:51 +00:00
M Fahru
d70e0b1c0e Implement grammarly warning alert on cm6 users
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
2022-11-16 09:06:39 +00:00
Davinder Singh
09be606a4e Merge pull request #10342 from overleaf/ds-buttons-project-page
New buttons on project dashboard

GitOrigin-RevId: 6e6a93a1ca1264dd214ccaf7976b665e45e7b10b
2022-11-16 09:04:34 +00:00
Davinder Singh
c6f8b17647 Merge pull request #10286 from overleaf/jel-ds-toggle
Fix toggle and  `Switch to PDF` aligment

GitOrigin-RevId: d3c77ff34829af875d2b8b9e3797e0e7db867631
2022-11-16 09:04:26 +00:00
M Fahru
5eff354971 Create settings menu react elements in editor left menu for editor left menu react migration
GitOrigin-RevId: e75581a43a8694398b20bee3dc5ec69b60db86ab
2022-11-15 09:07:01 +00:00
M Fahru
044d6fde65 Fix webpack build failure on server pro/CE:
- Add missing modules for local image dev env
- Use macro import to import modules

GitOrigin-RevId: 403a9950bc74063a9c9d34c9bc912af18f418e85
2022-11-15 09:06:54 +00:00
Jessica Lawshe
62cf8c9d61 Merge pull request #10262 from overleaf/jel-ds-btn-secondary
[web] Buttons for new CSS build

GitOrigin-RevId: 9ae4284ba89296b77c37d61ba9b221bcab2f6458
2022-11-15 09:06:25 +00:00
Mathias Jakobsen
81e2265e72 Merge pull request #10397 from overleaf/td-memoize-file-outline
Memoize file outline

GitOrigin-RevId: cb086bab2b6ead251362180d776e7eaff18fc639
2022-11-15 09:05:12 +00:00
Alf Eaton
28414b118d Merge pull request #10383 from overleaf/jpa-pdf-caching-avoid-cache-for-range-request
[web] pdf-caching: avoid browser cache for range requests on output.pdf

GitOrigin-RevId: 546380cfb24094db0af7de0f47f5a69c60b0586d
2022-11-10 09:04:06 +00:00
Mathias Jakobsen
8ddfd958d2 Merge pull request #10348 from overleaf/mj-outline-fixes-redo
[cm6] File outline improvements

GitOrigin-RevId: 9f4859cb35476d4baf0b3e3c2c2cb5d1678fd4a8
2022-11-09 09:04:08 +00:00
Jakob Ackermann
f803563673 Merge pull request #10376 from overleaf/jpa-pdf-caching-disable-first-error
[web] pdf-caching: disable pdf-caching after the first non-404 error

GitOrigin-RevId: f022e75acd9d5140ae02041b60af9819baa25e62
2022-11-09 09:04:03 +00:00
Jakob Ackermann
aeade59677 Merge pull request #10371 from overleaf/jpa-pdf-caching-disable-in-opera
[web] pdf-caching: disable pdf-caching in Opera browser

GitOrigin-RevId: 8c0cefc4fa4fccd74c58649c000be14643788514
2022-11-09 09:03:57 +00:00
Alf Eaton
381cdf34ce Use imported components directly
GitOrigin-RevId: 4533d7eb59ed543a301d99a9dce4ff54af6cfe6c
2022-11-09 09:03:48 +00:00
M Fahru
7e5ccecc7c Change react key to use unique string with index
GitOrigin-RevId: 591cda98d0a34c777cc8a41b2ec64119a1226dfb
2022-11-09 09:03:13 +00:00
M Fahru
c008a1aece Migrate github-sync menu to react
GitOrigin-RevId: 87e767a064421c7bad6c4fa3c7053959bfdb4cd4
2022-11-09 09:03:08 +00:00
Miguel Serrano
9e50ab8d1e Merge pull request #10350 from overleaf/jpa-pdf-caching-debug-context
[web] pdf-caching: more debug context

GitOrigin-RevId: ef9b20ef8d9a3b0c6b1b8c200eead1c0f8cf6bde
2022-11-09 09:03:00 +00:00
Jakob Ackermann
1c529d5dcf Merge pull request #10339 from overleaf/as-fix-switch-back
Fix bug in CM6 switch away survey where going back from Ace to CM6 will still show the survey

GitOrigin-RevId: 5900fafb1a4a5fab7d949b1c70af31e19a764e6e
2022-11-08 09:04:38 +00:00
Jakob Ackermann
665ab24cbd Merge pull request #10337 from overleaf/jpa-localized-network-error-messages
[web] pdf-caching: handle localize network error messages

GitOrigin-RevId: 41b0b9e87818d87d08c4cf24991751779243ae32
2022-11-08 09:04:18 +00:00
Jakob Ackermann
3db03ef678 Merge pull request #10313 from overleaf/jpa-pdf-caching-ranges-in-sentry
[web] pdf-caching: display ranges in sentry debug context

GitOrigin-RevId: d58e9c5292b1202e629c3b0706ade067c15e08a0
2022-11-08 09:04:11 +00:00
Jakob Ackermann
e9bc195483 Merge pull request #10301 from overleaf/jpa-pdf-caching-ignore-errors-for-stale-output
[web] pdf-caching: flag more errors as expected

GitOrigin-RevId: a5351db16d268bb8d9d67a86c34698c8b04f4f1a
2022-11-08 09:04:04 +00:00
Jakob Ackermann
111cce4ca4 Merge pull request #10299 from overleaf/jpa-nicer-warning-message-for-missing-pdf
[web] show a nicer warning message for missing pdf exceptions

GitOrigin-RevId: f519ec145d7ff4fe725241742fb66a1defdd257e
2022-11-08 09:03:57 +00:00
Miguel Serrano
4a3fb3344b Merge pull request #10323 from overleaf/ae-pdf-dblclick-page
Ensure only one dblclick listener is attached to a PDF page

GitOrigin-RevId: cadaa2f3bbaba8c496a6ece698b2ba7f12f340c4
2022-11-08 09:03:38 +00:00
Brian Gough
782294abae Merge pull request #10212 from overleaf/ii-dashboard-shorten-text-in-dropdowns
[web] Project dashboard add ellipsis to long text in the project filter dropdown on mobile

GitOrigin-RevId: 4b0d4e097ff0f26820c158086d8b089cbf1e364f
2022-11-07 09:03:38 +00:00
Brian Gough
db15c83c35 Merge pull request #10244 from overleaf/ii-jump-to-error
[web] Jump to error on files with double slash

GitOrigin-RevId: eec2ac6ba7a34d32f757f5e3a088e92d0d494422
2022-11-07 09:03:31 +00:00
M Fahru
b593bfa56e Don't show cm6 switch away survey if cm6 is not available
GitOrigin-RevId: e283fc424055f6df85015f02c83ad8314865697d
2022-11-04 09:06:10 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
aac9e6616e Merge pull request #10285 from overleaf/jpa-pdf-caching-ignore-404-from-fallback
[web] pdf-caching: double down on ignoring 404 from output.pdf requests

GitOrigin-RevId: 6b489180c221a29758b862884dae4ed6ed954a23
2022-11-04 09:04:53 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
Jakob Ackermann
986d52b8d4 Merge pull request #10274 from overleaf/jpa-pdf-caching-check-response-size
[web] pdf-caching: bailout early on unexpectedly large response size

GitOrigin-RevId: b2b1cf0abf2367ec7a7f0f5ca7a9f67a03e2fa0d
2022-11-04 09:04:02 +00:00
M Fahru
a30e934692 Migrate "help menu" in editor left menu to react
GitOrigin-RevId: 7ebbfa693205de1f57b1d54e25c46cfb1851acc8
2022-11-03 09:03:49 +00:00
Jakob Ackermann
28c1cc2ea9 Merge pull request #10218 from overleaf/jpa-adjust-prefetching
[web] pdf-caching: try to prefetch other smaller chunks

GitOrigin-RevId: 2bf1d33d48c2026ec3794baaaef8346dc9104db3
2022-11-02 09:05:04 +00:00
Jakob Ackermann
6f00659865 Merge pull request #10246 from overleaf/jpa-pdf-caching-object-id-back-fill
[web] pdf-caching: double down on back-filling of object-id

GitOrigin-RevId: 751392dc5ed59eb621eca3813040c7b92ef1369e
2022-11-02 09:04:57 +00:00
Jakob Ackermann
85547ffe40 Merge pull request #10234 from overleaf/jpa-pdf-caching-ignore-404
[web] pdf-caching: stop counting 404s on the output.pdf as failure

GitOrigin-RevId: eb76570fdce3dd79b8e0ea961722e428446672ac
2022-11-02 09:04:21 +00:00
ilkin-overleaf
641db6b8d9 Merge pull request #10184 from overleaf/ii-ignore-received-chat-messages-test
[web] Outdated chat context tests for receiving messages

GitOrigin-RevId: c91cda5ada1c0ef26d41589cdbee31a8afd1e36a
2022-11-01 09:05:17 +00:00
ilkin-overleaf
feb5ae56f5 Merge pull request #10152 from overleaf/ii-settings-sso-unescape-characters
[web] Settings page incorrect character escaping

GitOrigin-RevId: 3bd27a905394d5476487038b4d30ed208d6901ac
2022-11-01 09:05:09 +00:00
ilkin-overleaf
7180ee8700 Merge pull request #10132 from overleaf/ii-dashboard-are-you-affiliated-migration
[web] Project dashboard are you affiliated migration

GitOrigin-RevId: 455ad915dd023c5fab3ce9a5165aa7e960915f1f
2022-11-01 09:05:02 +00:00
Jakob Ackermann
79e6fecc4a Merge pull request #10231 from overleaf/jpa-pdf-caching-bounds-debug
[web] pdf-caching: debug bounds when reassembling the range from chunks

GitOrigin-RevId: 11871241d07880ebd2659cc5d0feb1f2c29014b6
2022-11-01 09:04:12 +00:00
M Fahru
b85ae6e58e Migrate actions menu in editor left menu to react (#10102)
* Migrate actions menu in editor left menu to react

* Move margin from inline style to css file

* remove focus selector to avoid "highlighting" the button after closing modal and regain focus

* Add disabled state on word count button when the compiling is loading or failed

* Use div instead of button for disabled word count button

* Add accessibility text props when LeftMenuButton is disabled

* Add actions menu test cases and storybook components

* use util assign function and wrap function prop in usecallback

GitOrigin-RevId: 81ab104be21fbcf5dfbc72c07d29eeb32976c61f
2022-10-28 08:05:14 +00:00
Jakob Ackermann
a0c180d133 Merge pull request #10156 from overleaf/jpa-web-disable-prefetch
[web] pdf-caching: double down on disabling of prefetching

GitOrigin-RevId: 60ccea883786bad306a747b5a182982bc648bbbd
2022-10-26 08:04:13 +00:00
Miguel Serrano
c30f887727 Merge pull request #9936 from overleaf/msm-itm-referrer
`itm_referrer` for subscription attribution

GitOrigin-RevId: 2787b55e8b7e9e415e66abef8deb669f3adf0f0d
2022-10-26 08:03:52 +00:00
Jakob Ackermann
956cacaef7 Merge pull request #10139 from overleaf/jpa-split-test-min-chunk-size
[misc] add split test for a per request pdfCachingMinChunkSize

GitOrigin-RevId: 6a8a3c6267501789f2047a67b03db6ac6df427c3
2022-10-26 08:03:39 +00:00
Jakob Ackermann
abaecac268 Merge pull request #10007 from overleaf/jpa-pdf-caching-latency-compute
[web] collect latencyCompute metric from pdf-caching

GitOrigin-RevId: f20fa2b54078a7106b2413432c4f47375878a5d6
2022-10-26 08:03:31 +00:00
M Fahru
797b9b2532 Migrate download menu in editor left menu to react (#10046)
* Initialize left menu react migration and migration download menu UI to react

* Add test case to DownloadMenu react component

* Update test description and add an href check to one of the download link

* Extract storybook document mock to its own fixture file

* Add mockCompileOnLoad config on storybook editor scope
  - if mockCompileOnLoad: true (default), then the default compile mock will be used
  - If mockCompileOnLoad: false, then we have to provide a compile mock on the storybook component

* Create download menu storybook component

* Use a single "editor-left-menu" controller on the editor left menu migrations

* Remove the form import from the react version of the left menu

* Change inline style to utility class name

GitOrigin-RevId: 5357c7bfc78bf40f52b9b308df8f2b60d793fbf7
2022-10-25 08:04:19 +00:00
Jessica Lawshe
58ba814cd1 Merge pull request #10114 from overleaf/jel-dash-survey-container
[web] Fix desktop dash survey container click behavior

GitOrigin-RevId: 9e94ee572e348fca1f950698dd5a7449195a52da
2022-10-25 08:04:12 +00:00
ilkin-overleaf
82c6484ca1 Merge pull request #10089 from overleaf/ii-project-list-provider-effects-refactoring
[web] Projects list provider refactoring

GitOrigin-RevId: e53fcdd32e5493d438d46f4a1bbca049a1967f5c
2022-10-24 08:03:04 +00:00
ilkin-overleaf
f8e98cd5c6 Merge pull request #10030 from overleaf/ii-dashboard-survey-react-mobile-view
[web] Project dashboard survey mobile view

GitOrigin-RevId: 19612f75a9987625f10626f5f9ea9b53321d5fe2
2022-10-24 08:02:59 +00:00
ilkin-overleaf
be000f2572 Merge pull request #10013 from overleaf/ii-dashboard-upgrade-button-tracking-data
[web] Project dashboard upgrade button tracking adjustments

GitOrigin-RevId: 8ec7b1a0914db8e167ec0af49f5d4ebd0e23280f
2022-10-24 08:02:57 +00:00
Alexandre Bourdin
0c170bd4c0 Merge pull request #10028 from overleaf/ab-fix-flaky-fe-tests
[web] Fix flaky project list frontend tests

GitOrigin-RevId: 2b2a90e6a294ec7dd5e7203dadd708f7986a56fc
2022-10-21 08:03:46 +00:00
June Kelly
d71d91e893 Merge pull request #10020 from overleaf/sg-account-delete-case-sensitivity
[web] email in leave modal should be case insensitive

GitOrigin-RevId: 250e867f88dd76769a27a8cd61dd82625c1e151f
2022-10-20 08:04:03 +00:00
Alf Eaton
57fb1545e4 Merge pull request #9980 from overleaf/mj-recompile-button-colour
[web] use bsStyle primary for recompile button group

GitOrigin-RevId: 6876f2bbfae6270d059f15c8b25af866b54d1e61
2022-10-19 08:03:45 +00:00
Jessica Lawshe
8323cb37e8 Merge pull request #9955 from overleaf/jel-actions-list
[web] Maintain project list in actions modal while processing and show processed

GitOrigin-RevId: c671b97646918e185d7989f539b44562a87873ee
2022-10-18 08:03:34 +00:00
Timothée Alby
4af5ed24ad Merge pull request #9866 from overleaf/ta-pdf-detach-safari-no-warnings
Remove PDF Detach Safari Warning

GitOrigin-RevId: 80f17660d81dc3812fab74c5e2ea4ff23cd7f1d0
2022-10-18 08:03:20 +00:00
Timothée Alby
caeeedd764 Merge pull request #9794 from overleaf/ab-endpoint-add-remove-tag-multiple-projects
[web] Handle adding/removing multiple projects from a tag at once

GitOrigin-RevId: 7d052fa9930035286f8ce41433d6c3959817148a
2022-10-18 08:03:17 +00:00
Timothée Alby
1ae3061f16 Merge pull request #9972 from overleaf/jpa-fix-rate-limited-output-download
[server-ce] serve output files via nginx

GitOrigin-RevId: 0ba3b27f85f928b1d95646e663dfa42a22a9f832
2022-10-18 08:03:09 +00:00
Timothée Alby
e699f3ca35 Merge pull request #9007 from overleaf/ta-recompile-event-body
Listen for Recompile Shortcut on Body

GitOrigin-RevId: 1ded1d620b35d25f1dffe27b78d8c866e2bfa1bd
2022-10-18 08:02:57 +00:00
Alf Eaton
6c83939765 Merge pull request #9931 from overleaf/ii-dashboard-table-accessibility
[web] Project dashboard table accessibility improvements

GitOrigin-RevId: ac8202b587c796ad1560e26242c1edca8c72a897
2022-10-17 08:04:28 +00:00
Alexandre Bourdin
7a20e1376d Merge pull request #9882 from overleaf/ii-dashboard-system-message-migration
[web] Project dashboard system & translation message migration

GitOrigin-RevId: 0c723a3b526980e5c749da44ebe8a0a3edcc66ad
2022-10-13 08:05:38 +00:00
Alexandre Bourdin
cdbf8c1831 Merge pull request #9915 from overleaf/jpa-project-list-api-query-optimizations
[web] optimize db queries of project list api endpoint

GitOrigin-RevId: e1e747858e95cf60003d68e6331dc41839389455
2022-10-13 08:05:31 +00:00
Alexandre Bourdin
d553863e3f Merge pull request #9945 from overleaf/ii-last-updated-date-by-translation-unescape-fix
[web] Fix "last updated date by" translation

GitOrigin-RevId: 110974ae69a0471c6988c7dea852fac93ce6bb0d
2022-10-13 08:05:24 +00:00
Alexandre Bourdin
6f88994f24 Merge pull request #9932 from overleaf/ab-react-dash-event
[web] Add loads_v2_dash event to the React dashboard

GitOrigin-RevId: 14fad90bb434b3b3855ed30e0159abb7e7d61c47
2022-10-13 08:04:54 +00:00
Alexandre Bourdin
af90c5adc8 Merge pull request #9912 from overleaf/ab-current-plan-group-tooltip-i18n-fix
[web] Fix translation for group plan tooltip

GitOrigin-RevId: c0a71c0379dea511f68d65b65b1673948b9451e0
2022-10-13 08:04:47 +00:00
Alexandre Bourdin
debe76baa6 Merge pull request #9865 from overleaf/ab-display-notifications-welcome-page
[web] Display notifications on the react dashboard welcome page

GitOrigin-RevId: 29fb08bbac195c2766dd0e94dbe9e9a0c7065e76
2022-10-13 08:04:39 +00:00
Eric Mc Sween
7c812162a1 Merge pull request #9895 from overleaf/jel-react-dash-survey
[web] Fixed position survey at bottom left of viewport on React dash

GitOrigin-RevId: a48c50e0cb90ef7356b461c0a480f7b163692303
2022-10-12 08:04:44 +00:00
Alasdair Smith
8a173a000e Merge pull request #9918 from overleaf/ii-dashboard-prevent-double-escape
[web] Project dashboard prevent double escape of user name

GitOrigin-RevId: be32c185438aabfc96a403e609ee9c612a9e4035
2022-10-12 08:03:51 +00:00
Alf Eaton
b17bcb6838 Merge pull request #9893 from overleaf/ae-upgrade-cypress-2
Upgrade Cypress to 10.9.0

GitOrigin-RevId: 00134da2915c3a35743da3e6eacfeda6f3be6a6a
2022-10-11 08:03:31 +00:00
Jessica Lawshe
0bf147b84c Merge pull request #9842 from overleaf/jel-dash-filter-layout
[web] Dash filter margin handling

GitOrigin-RevId: bfd6b3e43231a28fe76aa5255b97a6e222500d62
2022-10-07 08:04:49 +00:00
Jessica Lawshe
6f007a9703 Merge pull request #9838 from overleaf/jel-dash-scrolling
[web] React dash scrolling

GitOrigin-RevId: 80d8fe8756df717c19c05e6ad848c32d03e487fc
2022-10-07 08:04:42 +00:00
Miguel Serrano
ff3ea11fd6 Merge pull request #9859 from overleaf/ab-restore-tag-names-dropdown
[web] Restore tag names in the tags dropdown

GitOrigin-RevId: eae4368c3726d22c9e6c96dce9e35a6ce1e462fb
2022-10-05 13:26:30 +00:00
June Kelly
01e97a33bc Merge pull request #9862 from overleaf/sg-reword-the-text-in-the-file-upload-modal
[web] Reword the text in the file upload modal

GitOrigin-RevId: a0525e5fa6621b839a3455b1647ac09d65f882a7
2022-10-05 13:25:54 +00:00
Tim Down
e87e164a84 Merge pull request #9829 from overleaf/ds-chat-placeholder-change
Chat Pane-Change Placeholder for message input box

GitOrigin-RevId: 254efa89b883734ad3b7bfeefe625db84d93d579
2022-10-04 08:03:31 +00:00
Tim Down
de7eb43f51 Merge pull request #9792 from overleaf/ds-jpa-remove-stoponfirsterror-split-test
Split Test removal - removed stop-on-first-error split test code

GitOrigin-RevId: 4a5663397d0a967e0fa957453b36d466aa530630
2022-10-04 08:03:24 +00:00
Jessica Lawshe
6095e63c7d Merge pull request #9833 from overleaf/revert-9559-jel-dash-scroll
Revert "[web] Project dashboard scrolling"

GitOrigin-RevId: dc18d2717714b8c044a5c2bd04c3bef0b579663d
2022-10-04 08:03:09 +00:00
Jessica Lawshe
07a68a5a57 Merge pull request #9760 from overleaf/ab-dash-toolbar-tags-dropdown
[web] Add tags dropdown to the React dashboard toolbar

GitOrigin-RevId: 8f949d925e1ba0ef68dde508c0dbbaac5828625e
2022-10-04 08:03:07 +00:00
Jessica Lawshe
fd9c66404a Merge pull request #9809 from overleaf/ii-dashboard-mobile-view-improvements-2
[web] Projects dashboard improvements 2

GitOrigin-RevId: c34e91d55785564638ac1d54412a7e5c350fd410
2022-10-04 08:03:04 +00:00
Jessica Lawshe
94038e1b04 Merge pull request #9748 from overleaf/ii-dashboard-mobile-view-improvements
[web] Projects dashboard improvements

GitOrigin-RevId: 60bf3bd81fbdcb9d43bdb2ab3e2cf77bf02dddc8
2022-10-04 08:03:00 +00:00
Jessica Lawshe
f68d0d1e5f Merge pull request #9784 from overleaf/jel-project-tools-copy
[web] Add copy option to project tools dropdown

GitOrigin-RevId: 028ba62ed858376e472a5e4e5520079cd5f60ec5
2022-10-04 08:02:55 +00:00
Jessica Lawshe
f2748c13d7 Merge pull request #9783 from overleaf/jel-focus-copy-project-input
[web] Add auto focus to clone project input

GitOrigin-RevId: f78313437956d6fb0c3125ca0adf825235c37fa6
2022-10-04 08:02:52 +00:00