github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #10301 from overleaf/jpa-pdf-caching-ignore-errors-for-stale-output

Browse source 
[web] pdf-caching: flag more errors as expected

GitOrigin-RevId: a5351db16d268bb8d9d67a86c34698c8b04f4f1a
This commit is contained in:
Jakob Ackermann 2022-11-07 14:24:17 +00:00 committed by Copybot
parent 111cce4ca4
commit e9bc195483
1 changed files with 23 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
services/web/frontend/js/features/pdf-preview/util/pdf-caching-transport.js
View file

@ -10,6 +10,9 @@ import {
trackPdfDownloadEnabled,
} from './pdf-caching-flags'
// 30 seconds: The shutdown grace period of a clsi pre-emp instance.
const STALE_OUTPUT_REQUEST_THRESHOLD_MS = 30 * 1000
export function generatePdfCachingTransportFactory(PDFJS) {
// NOTE: The custom transport can be used for tracking download volume.
if (!enablePdfCaching && !trackPdfDownloadEnabled) {
@ -47,6 +50,7 @@ export function generatePdfCachingTransportFactory(PDFJS) {
this.pdfFile = pdfFile
this.handleFetchError = handleFetchError
this.abortController = abortController
this.startTime = performance.now()
}
abort() {
@ -62,10 +66,25 @@ export function generatePdfCachingTransportFactory(PDFJS) {
end,
metrics,
}
const is404onOutputPDF = err =>
err.message === 'non successful response status: 404' &&
const isStaleOutputRequest = () =>
performance.now() - this.startTime > STALE_OUTPUT_REQUEST_THRESHOLD_MS
const is404 = err => err.message === 'non successful response status: 404'
const isNetworkError = err => err.message === 'Failed to fetch'
const isFromOutputPDFRequest = err =>
OError.getFullInfo(err).url === this.url
// Do not consider "expected 404s" and network errors as pdf caching
// failures.
// "expected 404s" here include:
// - any stale download request
// Example: The user returns to a browser tab after 1h and scrolls.
// - requests for the main output.pdf file
// A fallback request would not be able to retrieve the PDF either.
const isExpectedError = err =>
(is404(err) || isNetworkError(err)) &&
(isStaleOutputRequest() || isFromOutputPDFRequest(err))
fetchRange({
url: this.url,
start,
@ -82,8 +101,7 @@ export function generatePdfCachingTransportFactory(PDFJS) {
})
.catch(err => {
if (abortSignal.aborted) return
if (is404onOutputPDF(err)) {
// Do not consider a 404 on the main pdf url as pdf caching failure.
if (isExpectedError(err)) {
throw new PDFJS.MissingPDFException()
}
metrics.failedCount++
@ -100,8 +118,7 @@ export function generatePdfCachingTransportFactory(PDFJS) {
end,
abortSignal,
}).catch(err => {
if (is404onOutputPDF(err)) {
// Do not consider a 404 on the main pdf url as pdf caching failure.
if (isExpectedError(err)) {
err = new PDFJS.MissingPDFException()
}
throw err