github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-27 16:22:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #10285 from overleaf/jpa-pdf-caching-ignore-404-from-fallback

Browse source 
[web] pdf-caching: double down on ignoring 404 from output.pdf requests

GitOrigin-RevId: 6b489180c221a29758b862884dae4ed6ed954a23
This commit is contained in:
Mathias Jakobsen 2022-11-03 12:45:11 +00:00 committed by Copybot
parent a54b633726
commit aac9e6616e
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
services/web/frontend/js/features/pdf-preview/util/pdf-caching-transport.js
View file

@ -62,6 +62,10 @@ export function generatePdfCachingTransportFactory(PDFJS) {
end,
metrics,
}
const is404onOutputPDF = err =>
err.message === 'non successful response status: 404' &&
OError.getFullInfo(err).url === this.url
fetchRange({
url: this.url,
start,
@ -78,10 +82,7 @@ export function generatePdfCachingTransportFactory(PDFJS) {
})
.catch(err => {
if (abortSignal.aborted) return
if (
err.message === 'non successful response status: 404' &&
OError.getFullInfo(err).url === this.url
) {
if (is404onOutputPDF(err)) {
// Do not consider a 404 on the main pdf url as pdf caching failure.
throw new PDFJS.MissingPDFException()
}
@ -93,7 +94,18 @@ export function generatePdfCachingTransportFactory(PDFJS) {
err = OError.tag(err, 'optimized pdf download error', errorInfo)
console.error(err)
captureException(err, { tags: { fromPdfCaching: true } })
return fallbackRequest({ url: this.url, start, end, abortSignal })
return fallbackRequest({
url: this.url,
start,
end,
abortSignal,
}).catch(err => {
if (is404onOutputPDF(err)) {
// Do not consider a 404 on the main pdf url as pdf caching failure.
err = new PDFJS.MissingPDFException()
}
throw err
})
})
.then(blob => {
if (abortSignal.aborted) return