Commit graph

17723 commits

Author SHA1 Message Date
Jessica Lawshe
bde7ef600f Merge pull request #3138 from overleaf/jel-csrf-fix
Fix validateToken signature

GitOrigin-RevId: fbedaa76ec0fa2134a08aa43c28c3756f8a2afe6
2020-08-25 02:04:34 +00:00
CloudBuild
2cd5bcca60 auto update translation
GitOrigin-RevId: cea732cc8dd7106771beecc5d30cd4bffe276698
2020-08-25 02:04:28 +00:00
Timothée Alby
cc218c98c2 Merge pull request #3098 from overleaf/jel-dropbox-tidy
Tidy DropboxUserController and DropboxHandler

GitOrigin-RevId: f492b35af06d02b6401b99467e887a92d5335b56
2020-08-25 02:04:23 +00:00
Timothée Alby
1ff2c6ce00 Merge pull request #3117 from overleaf/sk-block-tpds-update-on-archived-project
Block TPDS update on archived/trashed project

GitOrigin-RevId: 7db41a313b03721b93cbb601add6f91ae31f3f2a
2020-08-25 02:04:17 +00:00
Timothée Alby
750a20491d Merge pull request #3131 from overleaf/pr-fix-context-menu-placement-folders
Fix ellipsis icon placement in folders

GitOrigin-RevId: 4004ed43c8dd138e8f774d660e712bc7076e8b62
2020-08-25 02:04:12 +00:00
Timothée Alby
bc90ffb1e8 Merge pull request #3105 from overleaf/ta-outline-go-to-pdf
[Outline] Go To PDF on Double-Click

GitOrigin-RevId: 0be4207eb26d0712814097b71906b3c9c37d4790
2020-08-25 02:04:05 +00:00
Jakob Ackermann
39ea30355e [misc] simplify the naming around waiting for a mongo connection
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
Co-Authored-By: Simon Detheridge <s@sd.ai>
2020-08-24 17:41:03 +01:00
Jakob Ackermann
ee3d3b09ed [misc] wrap redis errors as tagging does not work with them
ioredis may reuse the error instance for multiple callbacks. E.g. when
 the connection to redis fails, the queue is flushed with the same
 MaxRetriesPerRequestError instance.
2020-08-24 10:12:20 +01:00
Jakob Ackermann
537e97be73 [misc] OError.tag all the errors in async contexts
See the docs of OError.tag:
https://github.com/overleaf/o-error#long-stack-traces-with-oerrortag
(currently at 221dd902e7bfa0ee92de1ea5a3cbf3152c3ceeb4)

I am tagging all errors at each async hop. Most of the controller code
 will only ever see already tagged errors -- or new errors created in
 our app code. They should have enough info that we do not need to tag
 them again.
2020-08-24 10:12:06 +01:00
Jakob Ackermann
8e31cc5c23 [Router] _handleError: joinProject error-context may not have project_id
The ol_context patch changed the priority of client context and rpc
 context.
This lead to the (possibly missing) project_id of the client context
 overwriting the project_id of the rpc context.
REF: f1d55c0a5437a518e9f4617473caed9ba928e648
2020-08-21 13:29:28 +01:00
Jakob Ackermann
f935b1881a [Router] leaveDoc: pass the doc_id into the error-context 2020-08-21 12:47:42 +01:00
Jakob Ackermann
fd88819eec [Router] _handleError: ol_context.doc_id does not exist, drop overwrite 2020-08-21 12:47:42 +01:00
Jakob Ackermann
880056d397 [Router] use a new UnexpectedArgumentsError 2020-08-21 12:47:08 +01:00
Jakob Ackermann
50140f785a [WebsocketController] use a new JoinLeaveEpochMismatchError 2020-08-21 12:47:08 +01:00
Jakob Ackermann
0462e3e437 [WebsocketController] use a new NotJoinedError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
4cb8cc4a85 [DocumentUpdaterManager] use a new ClientRequestedMissingOpsError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
8abfdb87ff [DocumentUpdaterManager] use a new DocumentUpdaterRequestFailedError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
02a2382264 [WebApiManager] use a new CorruptedJoinProjectResponseError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
68bc9d0d23 [WebApiManager] use a new WebApiRequestFailedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
59c4c884a5 [WebsocketController] use the new NotAuthorizedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
a8c51de510 [AuthorizationManager] use a new NotAuthorizedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
de518ea4eb [SessionSockets] use a new MissingSessionError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
6828becb46 [DocumentUpdaterManager] use a new NullBytesInOpError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
af50f9b02c [DocumentUpdaterManager] use a new UpdateTooLargeError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
5950b26a42 [SafeJsonParse] migrate to OError and use a new DataTooLargeToParseError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
f82177a46a [Errors] migrate to OError 2020-08-21 12:47:04 +01:00
Jakob Ackermann
c7b9dadd16 [misc] increase the timeout for unit tests -- CI boxes are too slow 2020-08-21 12:45:30 +01:00
dependabot[bot]
851d4bda46 Bump lodash from 4.17.15 to 4.17.20
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20)

Signed-off-by: dependabot[bot] <support@github.com>
2020-08-20 15:07:10 +00:00
Jakob Ackermann
d345911730 Merge pull request #54 from overleaf/jpa-wait-for-mongo
[misc] complete the connection setup before starting the http server
2020-08-20 17:06:12 +02:00
Jakob Ackermann
9693c349b4 Merge pull request #52 from overleaf/jpa-drop-unsafe-buffer-usage
[misc] get rid of unsafe Buffer usage
2020-08-20 17:04:18 +02:00
Christopher Hoskin
5e4decbfff Merge pull request #3125 from overleaf/csh-issue-3437-copybara-ci-fix
Remove Jenkinsfile, fix cloudbuild.yaml in copybarra exclusions

GitOrigin-RevId: d4ad374da44ff218e6068b84371deed45a4cd828
2020-08-20 10:21:59 +00:00
Jakob Ackermann
694a6937c3 Merge pull request #3123 from overleaf/jpa-hotfix-merge
[misc] fix merge of AuthenticationController

GitOrigin-RevId: 7945a6e3b6f0c5e816db2a02745dc75a30928392
2020-08-20 02:06:37 +00:00
Jakob Ackermann
b61ab62efb Merge pull request #3120 from overleaf/jpa-batched-update-continue
[scripts] batchedUpdate: add support for passing in the tail of the log

GitOrigin-RevId: 50b573ec4f90026c3c2c660a5313fdd62817dbd9
2020-08-20 02:06:31 +00:00
Jakob Ackermann
a22e252666 Merge pull request #3114 from overleaf/msm-remove-logger-warn-controllers
Replaced logger statements with error tagging in Controllers

GitOrigin-RevId: c5231913c82f95a325f4c3ab406d89cb534835a4
2020-08-20 02:06:25 +00:00
Jakob Ackermann
674954f96f Merge pull request #3094 from overleaf/sk-restrict-admin-flag
Check domain of emails on admin users

GitOrigin-RevId: 75de9cff30e3c628249fcd0ea3446a33d51d39b4
2020-08-20 02:06:19 +00:00
Jakob Ackermann
959b5853a6 [misc] complete the connection setup before starting the http server 2020-08-19 13:06:22 +01:00
Jakob Ackermann
0c8f04a011 [misc] migrate to native mongo driver 2020-08-19 13:04:47 +01:00
Jakob Ackermann
4b3ed5e9b1 [misc] get rid of unsafe Buffer usage 2020-08-19 12:59:33 +01:00
Eric Mc Sween
2fd9b6c61b Merge pull request #9 from overleaf/em-disable-gcs-decompress
Disable auto-decompression in GCS persistor
2020-08-19 07:42:16 -04:00
Miguel Serrano
3cf929eadb Merge pull request #768 from overleaf/msm-hotfix-2-4-1
Hotfix 2.4.1
2020-08-19 11:00:53 +02:00
Miguel Serrano
fe20868b5a Hotfix 2.4.1 2020-08-19 10:56:03 +02:00
Jakob Ackermann
00e59a9afe Merge pull request #3118 from overleaf/jpa-delay-mongo-connection-use
[scripts] batchedUpdate: try to work around flaky mongo connection setup

GitOrigin-RevId: 2bba7117b8f8892a41703569fef3f97d5e8d6835
2020-08-19 02:06:34 +00:00
Timothée Alby
25b9243b3f Merge pull request #3115 from overleaf/msm-improve-student-subscription-dialog
Improve student subscription dialog

GitOrigin-RevId: 902e76612c5a6a419ca305ae37459438ad7f75eb
2020-08-19 02:06:29 +00:00
Timothée Alby
f5f50188ef Merge pull request #3109 from overleaf/ta-metrics-tooltips
Fix Metrics Tooltips

GitOrigin-RevId: 61bae63b78408132e38e070851a53812bbe6dc6b
2020-08-19 02:06:25 +00:00
Timothée Alby
7fc0f88996 Merge pull request #3111 from overleaf/pr-file-outline-out-of-beta
File outline out of beta

GitOrigin-RevId: 64fa6554813b1d0ceff2b567922651509badecc7
2020-08-19 02:06:20 +00:00
CloudBuild
aec9de8e1b auto update translation
GitOrigin-RevId: cef8f0b5b36fa170431ecd5943ef7463d36b1475
2020-08-19 02:06:15 +00:00
Jakob Ackermann
fa594e575b Merge pull request #3113 from overleaf/jpa-translations-mono-repo
[misc] mono repo with translations

GitOrigin-RevId: 1ed86d211f6a2031aafc3e7462687af0e957f9fd
2020-08-19 02:06:08 +00:00
Eric Mc Sween
967dde280e Disable auto-decompression in GCS persistor
The GCS library automatically decompresses files with Content-encoding:
gzip. This is very useful, but the S3 library doesn't do that, so we
need to disable the feature in GCS so that it behaves the same way other
persistors behave.
2020-08-18 16:04:54 -04:00
Jakob Ackermann
7232fd28ef Merge pull request #3103 from overleaf/pr-fix-messaging-hidden-files
Change hidden files notice messaging.

GitOrigin-RevId: 67dfaddd8e1879aae77840f4f68c5c6598fbe294
2020-08-18 02:06:37 +00:00
Jakob Ackermann
5a8edacbf8 Merge pull request #3097 from overleaf/sk-remove-settings-event-tracking
Remove event tracking from project settings

GitOrigin-RevId: 870568c800e0581a03b70b042bac931e78cea05d
2020-08-18 02:06:32 +00:00