github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #9 from overleaf/em-disable-gcs-decompress

Browse source 
Disable auto-decompression in GCS persistor
This commit is contained in:
Eric Mc Sween 2020-08-19 07:42:16 -04:00 committed by GitHub
commit 2fd9b6c61b
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libraries/object-persistor/src/GcsPersistor.js
View file

@ -102,7 +102,7 @@ module.exports = class GcsPersistor extends AbstractPersistor {
const stream = this.storage
.bucket(bucketName)
.file(key)
.createReadStream(opts)
.createReadStream({ decompress: false, ...opts })
// ingress to us from gcs
const observer = new PersistorHelper.ObserverStream({

7
libraries/object-persistor/test/unit/GcsPersistorTests.js
View file

@ -160,6 +160,12 @@ describe('GcsPersistorTests', function () {
expect(GcsFile.createReadStream).to.have.been.called
})
it('disables automatic decompression', function () {
expect(GcsFile.createReadStream).to.have.been.calledWith({
decompress: false
})
})
it('pipes the stream through the meter', function () {
expect(ReadStream.pipe).to.have.been.calledWith(
sinon.match.instanceOf(Transform)
@ -183,6 +189,7 @@ describe('GcsPersistorTests', function () {
it('passes the byte range on to GCS', function () {
expect(GcsFile.createReadStream).to.have.been.calledWith({
decompress: false,
start: 5,
end: 10
})