github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-23 14:32:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

[Router] use a new UnexpectedArgumentsError

Browse source
This commit is contained in:
Jakob Ackermann 2020-08-20 13:12:56 +01:00
parent 50140f785a
commit 880056d397
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/real-time/app/js/Errors.js
View file

@ -68,6 +68,12 @@ class NullBytesInOpError extends OError {
}
}
class UnexpectedArgumentsError extends OError {
constructor() {
super('unexpected arguments')
}
}
class UpdateTooLargeError extends OError {
constructor(updateSize) {
super('update is too large', { updateSize })
@ -91,6 +97,7 @@ module.exports = {
NotAuthorizedError,
NotJoinedError,
NullBytesInOpError,
UnexpectedArgumentsError,
UpdateTooLargeError,
WebApiRequestFailedError
}

3
services/real-time/app/js/Router.js
View file

@ -9,6 +9,7 @@ const HttpController = require('./HttpController')
const HttpApiController = require('./HttpApiController')
const bodyParser = require('body-parser')
const base64id = require('base64id')
const { UnexpectedArgumentsError } = require('./Errors')
const basicAuth = require('basic-auth-connect')
const httpAuth = basicAuth(function (user, pass) {
@ -64,7 +65,7 @@ module.exports = Router = {
},
_handleInvalidArguments(client, method, args) {
const error = new Error('unexpected arguments')
const error = new UnexpectedArgumentsError()
let callback = args[args.length - 1]
if (typeof callback !== 'function') {
callback = function () {}