Eric Mc Sween
5cd889038e
Use _.once() instead of ad hoc implementation
2020-09-03 15:52:09 -04:00
Eric Mc Sween
a853950a99
Fix container monitor cleanup function
...
The intent here is clearly to clear both the timeout and the interval.
2020-09-03 15:50:45 -04:00
Eric Mc Sween
30a44edded
Decaf cleanup: simplify variable declarations
2020-09-03 15:50:12 -04:00
Eric Mc Sween
a282bccd48
Do not instantiate errors at module load time
...
This prevents the right stack trace from being captured.
2020-09-03 15:34:19 -04:00
Eric Mc Sween
4905e7db2c
Decaf cleanup: unused vars
2020-09-03 15:30:07 -04:00
Eric Mc Sween
44bf38d6db
Decaf cleanup: convert async function to sync
...
The examineOldContainer() function doesn't need to use callbacks since
it only does synchronous work.
2020-09-03 15:13:04 -04:00
Eric Mc Sween
2584586ba2
Decaf cleanup: camel-case variables
2020-09-03 15:13:04 -04:00
Eric Mc Sween
c52d7d8f02
Decaf cleanup: simplify null checks
2020-09-03 15:13:04 -04:00
Eric Mc Sween
ee4c08868c
Decaf cleanup: remove default callbacks
2020-09-03 15:13:04 -04:00
Eric Mc Sween
32f0bbe266
Decaf cleanup: remove IIFEs
2020-09-03 15:13:04 -04:00
Eric Mc Sween
f650da8675
Decaf cleanup: remove __guard__
2020-09-02 17:06:35 -04:00
Eric Mc Sween
99648341e2
Decaf cleanup: remove unnecessary returns
2020-09-02 16:58:41 -04:00
Eric Mc Sween
08be54a43e
Decaf cleanup: remove unnecessary Array.from()
2020-09-02 16:45:49 -04:00
Christopher Hoskin
ca10ff164f
Merge pull request #188 from overleaf/jpa-bump-dev-env-3-3-2-testing
...
[misc] bump the dev-env to 3.3.2
2020-08-13 11:40:36 +01:00
Christopher Hoskin
cbc87c4ce1
Merge pull request #189 from overleaf/csh-issue-1123-bump-logger-220
...
[misc] bump logger-sharelatex to version 2.2.0
2020-08-13 11:28:23 +01:00
Christopher Hoskin
b1b2a1c134
[misc] bump logger-sharelatex to version 2.2.0
2020-08-12 15:11:21 +01:00
Jakob Ackermann
1d1b9ebebc
[misc] bump the dev-env to 3.3.2
2020-08-10 17:01:11 +01:00
Jakob Ackermann
5846ebb367
Merge pull request #182 from overleaf/msm-fix-npe-community-edition
...
Fixed NPE when Settings.clsi is defined but Settings.clsi.docker is not
2020-07-15 11:01:08 +02:00
Jakob Ackermann
0f9d0d9790
Merge pull request #183 from overleaf/jpa-clsi-allowed-image-names
...
[misc] RequestParser: restrict imageName to an allow list and add tests
2020-07-15 10:58:36 +02:00
Jakob Ackermann
4489a080fd
Merge pull request #186 from overleaf/jpa-import-132
...
[LocalCommandRunner] run: block a double call of the callback
2020-07-15 10:57:46 +02:00
Jakob Ackermann
8277623ecc
Merge pull request #185 from overleaf/jpa-import-123
...
[ExampleDocumentTests] drop out in case of an error during compilation
2020-07-15 10:57:34 +02:00
Jakob Ackermann
c3a3ed341b
Merge pull request #132 from das7pad/hotfix-double-call
...
[LocalCommandRunner] run: block a double call of the callback
2020-07-03 12:58:25 +02:00
Jakob Ackermann
cd87d3018e
[misc] fix formatting
2020-07-03 11:47:53 +01:00
Jakob Ackermann
fe7218fefb
Merge pull request #123 from das7pad/hotfix/test-error-handling
...
[ExampleDocumentTests] drop out in case of an error during compilation
2020-07-03 12:40:15 +02:00
Jakob Ackermann
a5c3bad7f1
[ExampleDocumentTests] drop out in case of an error during compilation
...
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
2020-07-03 11:38:12 +01:00
Jakob Ackermann
f703b2ca41
[misc] move the image check prior to the base image override
2020-07-01 10:01:25 +01:00
Jakob Ackermann
aa02df7b81
[misc] apply review feedback
...
- move setting into clsi.docker namespace
- rename the variable for images to allowedImages / ALLOWED_IMAGES
- add an additional check for the image name into the DockerRunner
Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
2020-06-30 12:01:21 +01:00
Jakob Ackermann
c857371fed
[misc] wordcount: restrict image to an allow list and add tests
2020-06-26 13:28:12 +01:00
Jakob Ackermann
8846efe7ce
[misc] RequestParser: restrict imageName to an allow list and add tests
2020-06-26 13:28:09 +01:00
Miguel Serrano
f8ca906393
Fixed NPE when Settings.clsi is defined but Settings.clsi.docker is not
2020-06-25 12:31:10 +02:00
Brian Gough
2b342c6e53
Merge pull request #181 from overleaf/bg-fix-503-response
...
handle EPIPE errors in CompileController
2020-06-22 09:30:35 +01:00
Brian Gough
22480f1a52
handle EPIPE errors in CompileController
2020-06-18 09:54:18 +01:00
Brian Gough
ff2c69272f
Merge pull request #180 from overleaf/bg-add-compile-groups
...
add compile groups support
2020-06-18 08:52:45 +01:00
Brian Gough
bdebef91eb
Merge branch 'master' into bg-add-compile-groups
2020-06-17 11:58:26 +01:00
Brian Gough
f6fddf2944
Merge pull request #179 from overleaf/bg-fix-synctex-error
...
fix synctex error
2020-06-16 08:57:54 +01:00
Brian Gough
8b4869a00c
Merge pull request #178 from overleaf/bg-use-lodash
...
migrate from underscore to lodash
2020-06-16 08:57:14 +01:00
Brian Gough
2eb4327256
fix format
2020-06-16 08:45:53 +01:00
Brian Gough
f41b4daca2
Merge branch 'master' into bg-use-lodash
2020-06-16 08:35:17 +01:00
Brian Gough
634fad8c6e
Merge pull request #176 from overleaf/ta-epipe-retry-revert
...
Remove Retries in EPIPE Errors
2020-06-16 08:33:30 +01:00
Brian Gough
85f4f348dd
add default settings to remove wordcount and synctex containers
2020-06-15 15:49:38 +01:00
Brian Gough
2ce03f0554
add initial compileGroup support
2020-06-15 15:28:53 +01:00
Brian Gough
0914908676
downgrade NotFoundError log-level
2020-06-15 11:06:54 +01:00
Brian Gough
262ea01911
add acceptance test for synctex when project/file does not exist
2020-06-15 10:55:01 +01:00
Brian Gough
ede70b6f99
migrate from underscore to lodash
2020-06-15 09:52:21 +01:00
Brian Gough
f99023320d
use json parsing in request
2020-06-12 15:15:51 +01:00
Brian Gough
5368630754
check output file exists before running synctex
2020-06-12 15:15:27 +01:00
Brian Gough
8fadf9b241
Merge pull request #175 from overleaf/bg-503-on-unavailable
...
send 503 unavailable response on EPIPE
2020-06-12 09:29:04 +01:00
Brian Gough
69b7ecfd2e
Merge pull request #177 from overleaf/bg-add-docker-setting
...
add missing setting for optimiseInDocker
2020-06-12 09:28:31 +01:00
Brian Gough
603d9fdead
Merge pull request #174 from overleaf/bg-error-on-missing-profile
...
error on missing profile
2020-06-12 09:28:06 +01:00
Tim Alby
d3ff214b88
partially revert "[DockerRunner] fix metric incrementing and error logging"
...
This reverts commits:
- 2b2fcca39ce8dee0fdc0c342aa0d6c822592bcec
- 9e82ab0890c5cc8c7fb95362c3f7edbcaad0cf29
- e3da458b376871c3ce72d6984d14bf1ee668b04b
2020-06-11 12:51:26 +02:00