github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-07 07:33:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

Do not instantiate errors at module load time

Browse source 
This prevents the right stack trace from being captured.
This commit is contained in:
Eric Mc Sween 2020-09-03 15:34:19 -04:00
parent 4905e7db2c
commit a282bccd48
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
services/clsi/app/js/DockerRunner.js
View file

@ -22,11 +22,6 @@ let containerMonitorTimeout
let containerMonitorInterval
module.exports = DockerRunner = {
ERR_NOT_DIRECTORY: new Error('not a directory'),
ERR_TERMINATED: new Error('terminated'),
ERR_EXITED: new Error('exited'),
ERR_TIMED_OUT: new Error('container timed out'),
run(
projectId,
command,
@ -190,13 +185,13 @@ module.exports = DockerRunner = {
}
if (exitCode === 137) {
// exit status from kill -9
err = DockerRunner.ERR_TERMINATED
err = new Error('terminated')
err.terminated = true
return callback(err)
}
if (exitCode === 1) {
// exit status from chktex
err = DockerRunner.ERR_EXITED
err = new Error('exited')
err.code = exitCode
return callback(err)
}
@ -353,7 +348,7 @@ module.exports = DockerRunner = {
return cb(err)
}
if (!stats.isDirectory()) {
return cb(DockerRunner.ERR_NOT_DIRECTORY)
return cb(new Error('not a directory'))
}
cb()
})
@ -501,7 +496,7 @@ module.exports = DockerRunner = {
}
if (timedOut) {
logger.log({ containerId }, 'docker container timed out')
error = DockerRunner.ERR_TIMED_OUT
error = new Error('container timed out')
error.timedout = true
callback(error)
} else {