Commit graph

485 commits

Author SHA1 Message Date
Brian Gough
bd09ef81f2 added comments 2017-11-16 15:41:16 +00:00
Brian Gough
dc6110db8d put ace in readonly mode when changing session
if the session fails to attach successfully (e.g due to an exception in
the changeSession event handler) the editor will be left in a state
where the user will not be able to enter any text.  This should at least
cause them to reload the editor.
2017-11-16 11:32:08 +00:00
Brian Gough
125a5ec606 temporarily avoid exception in ace event handler
full fix will be to use the angular $http cancellation mechanism
2017-11-15 16:28:31 +00:00
Nate Stemen
a78330877b fixing services call 2017-11-15 10:14:31 -05:00
Nate Stemen
428ae3aa53 adding labels service back 2017-11-15 09:27:46 -05:00
Brian Gough
fe12a341e1 Merge pull request #89 from sharelatex/bg-slow-connection-fix
increase allowed op backlog and flush tolerance
2017-11-13 09:22:18 +00:00
Shane Kilkelly
1cedfed1e4 Merge branch 'master' into sk-unlisted-projects 2017-11-02 10:10:09 +00:00
Brian Gough
15997ea782 increase allowed op backlog and flush tolerance 2017-11-01 14:20:07 +00:00
Shane Kilkelly
f9d83c24ef clean-up commented out code 2017-10-26 11:04:59 +01:00
Shane Kilkelly
74c231826d WIP: track changes with token-access 2017-10-25 10:34:18 +01:00
Nate Stemen
e8731bc276 allow for capital letters in command name 2017-10-24 16:55:25 +01:00
Nate Stemen
829595777c change regex to match single backslash and command fragment 2017-10-24 16:35:28 +01:00
Nate Stemen
98909026f5 moving data to backend and fixing tests 2017-10-24 10:59:41 +01:00
Nate Stemen
0ebda89efe fixing package manager issues 2017-10-20 12:04:10 +01:00
Henry Oswald
aff5823a2d Revert "Complete 'usepackage' with packages" 2017-10-17 13:30:47 +01:00
Nate Stemen
2efb6b69e5 removing comment 2017-10-13 17:42:10 +01:00
Nate Stemen
da07a91229 reformated data files with argument data 2017-10-13 17:24:48 +01:00
Nate Stemen
f113ba6342 basic package aware autocomplete 2017-10-12 15:33:14 +01:00
Nate Stemen
cfca4b5d6c modified labels service to include packages aware autocompletion 2017-10-06 17:15:50 +01:00
Nate Stemen
507bb568a3 labels -> metadata 2017-10-05 14:19:30 +01:00
Nate Stemen
8b4843cf8b cleaning up usepackage completion 2017-10-03 17:32:34 +01:00
Nate Stemen
7d5785b98f adding top 100 packages and package tracking 2017-10-02 18:10:53 +01:00
Shane Kilkelly
a66cb15f48 Use angular $http service for spellcheck 2017-09-29 14:55:06 +01:00
Alasdair Smith
96d13215e3 Be more defensive when checking encoded text 2017-09-22 09:36:50 +01:00
Alasdair Smith
f8d4923547 Wrap in try/catch 2017-09-21 15:41:24 +01:00
Alasdair Smith
42b604dcda Clean up decoding from websockets 2017-09-21 15:41:24 +01:00
Alasdair Smith
a022f83cce Fix order of args 2017-09-21 15:22:56 +01:00
Alasdair Smith
e2bb6dcecb Pass option to encode range
To ensure backwards compat with clients not refreshing, pass a flag to enable
encoding.  This way, old client won't receive encoded ranges, but also won't
have decoding logic. The flag can then be removed once all clients are up to
date
2017-09-21 14:23:39 +01:00
Alasdair Smith
b33929fa83 DRY up 2017-09-21 13:36:31 +01:00
Alasdair Smith
24f44889a7 First pass at decoding changes & comments in ranges 2017-09-21 13:25:19 +01:00
Alasdair Smith
66bed67270 Merge pull request #4 from sharelatex/as-client-auto-compile
Client-side auto compile
2017-09-19 15:20:07 +01:00
James Allen
ece7a4cbb7 Merge pull request #601 from sharelatex/ns-raise-safari-regex-count
Raising the limit on safari regex count
2017-09-18 11:16:49 +02:00
James Allen
1bafba8992 Merge pull request #586 from sharelatex/ns-add-SL-command-data
adding commands that appear in top 100 from SL-CLSI analysis
2017-09-18 11:16:41 +02:00
Nate Stemen
80c00b13f7 Raising the limit on safari regex count 2017-09-11 11:27:03 +01:00
Alasdair Smith
e2523c569e Filter linting warnings 2017-09-07 17:45:16 +01:00
Alasdair Smith
9cde236bc8 Add comment explaining lint errors vs compile log errors 2017-09-07 11:28:36 +01:00
Alasdair Smith
8a8d98935b Remove unnecessary linting check in annotations listener
When user starts typing, compile log annotations are replaced with linter ones,
so log errrors can be ignored for this purpose. Because we don't try to
autocompile unless the user types something
2017-09-07 10:04:10 +01:00
James Allen
b2257db2c2 Don't get confused by commands in arguments in autocomplete 2017-09-05 19:26:13 +02:00
Alasdair Smith
fc4a260d95 Ensure error is from linting not compile logs 2017-09-05 14:57:06 +01:00
Alasdair Smith
53bb4fdde0 Use var in root scope instead of event to track linting error 2017-09-05 14:57:06 +01:00
Alasdair Smith
c42b08fcff Dispatch linting error event when changed 2017-09-05 14:57:06 +01:00
Alasdair Smith
65b2c42fad Emit event when op is acknowledged 2017-09-05 14:57:06 +01:00
Nate Stemen
54af7fbdcb adding in a few new commands that appear in SL-CLSI analysis 2017-08-31 10:39:46 +01:00
Shane Kilkelly
8a612df009 fix use of context helper in onChange 2017-08-31 08:59:38 +01:00
Shane Kilkelly
708afedeb4 Refactor out common code in AutocompleteManager.
(first pass)
2017-08-30 14:01:20 +01:00
Nate Stemen
adb26b1b94 forgot meta tag for "thebibiography" 2017-08-18 14:24:44 +01:00
Nate Stemen
fb4182cbb1 Merge branch 'master' into ns-autocomplete 2017-08-18 09:14:06 +01:00
Nate Stemen
42be1164bc fixing environment duplication in autocomplete issue 2017-08-17 14:30:18 +01:00
Nate Stemen
d1b906db43 renaming and organizing 2017-08-16 17:55:43 +01:00
Nate Stemen
f253b7e8cb fixing command duplication issue during suggestion 2017-08-16 17:40:01 +01:00
Nate Stemen
6e9b1c602b fixing spaces vs. tabs issue 2017-08-14 18:02:51 +01:00
Nate Stemen
688f1e9e75 merged staticManager with snippetManager 2017-08-11 09:23:36 +01:00
James Allen
7538c8834f Merge branch 'master' into ja-per-user-track-changes 2017-08-09 14:05:36 +02:00
James Allen
6c342a6e65 Merge branch 'master' into ja-update-ace 2017-08-04 10:39:53 +02:00
Nate Stemen
769875c5d5 Adding default autocomplete commands w/ argument options 2017-08-03 16:31:46 +01:00
Shane Kilkelly
8a0f58c63d Use correct character width 2017-08-01 14:28:10 +01:00
Shane Kilkelly
3ffef7fe56 Dynamically adjust the width of autocomplete popup. 2017-08-01 13:40:30 +01:00
Paulo Reis
fbce49f5cd Merge branch 'master' into ja-per-user-track-changes 2017-08-01 10:56:02 +01:00
Shane Kilkelly
f057f788e3 Autocomplete for graphics 2017-07-31 14:51:22 +01:00
Shane Kilkelly
eeabac7698 Get graphics paths from preamble 2017-07-31 11:28:52 +01:00
Shane Kilkelly
eaf9ae5b94 Begin work on autocomplete for includegraphics 2017-07-31 09:34:58 +01:00
Shane Kilkelly
70e5279ba2 Don't autocomplete for commands like \\, \[, \:, etc 2017-07-14 13:52:18 +01:00
Shane Kilkelly
f66982dd8b Consistently delete back to last backslash 2017-07-13 10:23:45 +01:00
Shane Kilkelly
75b0e0cf51 Don't offer autocomplete for double-backslash 2017-07-13 10:22:51 +01:00
Shane Kilkelly
952a765235 Inteligently rank exact match highest 2017-07-12 11:33:45 +01:00
Shane Kilkelly
c8a21cdcf5 WIP: sort definite real commands from possible incidentals 2017-07-12 09:25:39 +01:00
Shane Kilkelly
1fb036811a Temporarily remove up-ranking of exact match 2017-07-11 11:34:31 +01:00
James Allen
710c89a629 Support per user track changes (proof of concept) 2017-07-07 10:38:13 +01:00
Shane Kilkelly
04c94760f5 Merge branch 'sk-auto-pair-braces' into sk-ac-improvements-integration 2017-07-06 14:39:28 +01:00
Shane Kilkelly
330e3dccc3 Merge branch 'sk-ac-rank-exact-match-highest' into sk-ac-improvements-integration 2017-07-06 14:39:08 +01:00
Shane Kilkelly
611f8825d7 Merge branch 'sk-ac-prevent-double-insertion' into sk-ac-improvements-integration 2017-07-06 14:39:00 +01:00
Shane Kilkelly
9ac15c9d47 Merge branch 'sk-ac-more-eager-trigger' into sk-ac-improvements-integration 2017-07-06 14:38:44 +01:00
Shane Kilkelly
98f96d6087 Merge branch 'sk-ac-disable-for-existing-environments' into sk-ac-improvements-integration 2017-07-06 14:38:07 +01:00
James Allen
01d709dff5 Remove latex beta mode 2017-07-06 11:59:44 +01:00
Shane Kilkelly
34b2012727 Enable (optional) auto-pairing for latex mode 2017-07-06 11:06:51 +01:00
Shane Kilkelly
68c942582f Clean up the custom insertMatch function 2017-07-04 08:48:45 +01:00
Shane Kilkelly
08faa64b57 Add comment explaining the custom insertMatch 2017-07-03 15:20:36 +01:00
Shane Kilkelly
96d269e348 Use existential operator to check existence 2017-07-03 15:13:27 +01:00
Shane Kilkelly
415de9e2ec Experimental handling of completion for existing commands 2017-07-03 15:12:15 +01:00
Shane Kilkelly
127d5ded86 Remove erroneous log 2017-07-03 13:37:25 +01:00
Shane Kilkelly
7ecadb14f6 Add a skeleton of a custom insertMatch function 2017-07-03 13:36:24 +01:00
Shane Kilkelly
bb3c5e7a34 Reverse direction, don't ignore commands in comments 2017-06-30 15:05:21 +01:00
Shane Kilkelly
bd88adb621 Account for mid-line comments 2017-06-30 14:03:34 +01:00
Shane Kilkelly
da286438be Don't trigger autocomplete when editing existing environment 2017-06-30 11:22:11 +01:00
Shane Kilkelly
c2fcbbeb72 Fix parsing, so it accurately captures command args 2017-06-30 10:55:10 +01:00
Shane Kilkelly
e2bff06aeb Add comment about ignoring comments 2017-06-30 08:42:03 +01:00
Shane Kilkelly
cfe51089f6 Ignore commands within comments when parsing document 2017-06-29 16:04:52 +01:00
Shane Kilkelly
db80f8ca1c Don't trigger autocomplete if we're on a comment line. 2017-06-29 14:42:08 +01:00
Shane Kilkelly
c9cda16a5e Refactor score calculation 2017-06-29 11:13:59 +01:00
Shane Kilkelly
936278b045 Bring score into line with new policy 2017-06-29 10:55:05 +01:00
Shane Kilkelly
cbae1857e7 Allow exact match to be ranked higher than any other result 2017-06-29 10:54:07 +01:00
Shane Kilkelly
3deebc8642 Change the scoring system for autocomplete, scale 0-100 2017-06-29 10:53:52 +01:00
Shane Kilkelly
1490b4a0da Remove Shift-Space autocomplete trigger, far to easy to misfire 2017-06-29 10:02:49 +01:00
Shane Kilkelly
69796bd835 also trigger autocomplete if last character is backslash 2017-06-28 15:48:21 +01:00
Shane Kilkelly
c9678ad699 Trigger autocomplete with Shift-Space, in addition to existing triggers 2017-06-28 15:24:37 +01:00
Shane Kilkelly
8b7a1bd4d9 Merge branch 'sk-labels-ac-debounce' 2017-06-20 13:53:23 +01:00
Shane Kilkelly
3d2d7652c6 Simplified and faster blanking 2017-06-20 08:46:47 +01:00
Shane Kilkelly
b4e2dcf7ef Match prefixes of ref and cite up to 16 characters 2017-06-20 08:46:28 +01:00
Shane Kilkelly
a299af12e8 Remove debug helper 2017-06-20 08:46:18 +01:00
Shane Kilkelly
85ddff15cb Move command-matching regex to the class level 2017-06-16 10:20:55 +01:00
Shane Kilkelly
0163ffc4bd Extend, and clean up the command-matching regex 2017-06-16 10:17:30 +01:00
Shane Kilkelly
1d905bd5ff Clean up string replacement 2017-06-16 09:49:16 +01:00
Shane Kilkelly
d9aff3c3f4 Blacklist more commands 2017-06-16 09:41:40 +01:00
Shane Kilkelly
a1d2d5b313 WIP: blank out label commands before running spell-check 2017-06-16 09:20:35 +01:00
Shane Kilkelly
403d822174 Alter labels debouncer to handle transitions between docs 2017-06-15 14:09:49 +01:00
Shane Kilkelly
b0bb4b3e47 Merge branch 'sk-ref-variants' 2017-06-15 09:17:48 +01:00
Shane Kilkelly
9607174b64 Merge branch 'master' into sk-server-side-labels-loading 2017-06-15 08:49:14 +01:00
Shane Kilkelly
3f1a440d66 Support variations of \ref{}, such as \cref{}, \eqref{}, etc.. 2017-06-14 15:15:07 +01:00
Shane Kilkelly
b0ff8e0745 Fix a typo: prefxi => prefix 2017-06-14 15:14:38 +01:00
Shane Kilkelly
5e37b1dac1 Move logic for selectively loading labels.
Only load labels if the user has write permission
2017-06-14 13:26:02 +01:00
Shane Kilkelly
3b066758bb Don't load labels for anonymous/read-only users 2017-06-13 14:06:00 +01:00
Shane Kilkelly
a04eb1197d Move labels service to /ide/labels/services/labels 2017-06-13 11:43:25 +01:00
Shane Kilkelly
debb0c06a4 Clearer logic for triggering labels-loading 2017-06-12 14:23:29 +01:00
Shane Kilkelly
234a2d0e21 Remove cruft 2017-06-12 11:37:34 +01:00
Shane Kilkelly
1bb065344c Move labels into an Angular Service 2017-06-12 09:44:32 +01:00
Shane Kilkelly
5443b92e7d Move state management into LabelsMaster on the ide 2017-06-09 11:28:27 +01:00
Shane Kilkelly
965a46291b Only fetch labels for uploaded docs, not files 2017-06-08 15:55:17 +01:00
Shane Kilkelly
ff7955dfdb Update labels when docs are uploaded or removed 2017-06-08 15:12:18 +01:00
Shane Kilkelly
c7dbd21cd1 use flag on aceEditor to enable autocomplete features 2017-06-08 09:22:08 +01:00
Paulo Reis
240d6d6f6b Resolve timing issue when triggering selection-related logic. 2017-06-07 14:21:05 +01:00
Paulo Reis
53b18e041f Trigger selection-related logic after accepting or rejecting changes. 2017-06-07 14:03:58 +01:00
Paulo Reis
19ecffd654 Merge branch 'master' into pr-aggregate-insert-delete 2017-06-06 17:04:31 +01:00
Paulo Reis
73a67c6617 Add a note on the need of reverse sorting changes when rejecting. 2017-06-06 13:34:48 +01:00
Paulo Reis
4504f77aa3 Do bulk rejects in reverse order. 2017-06-06 12:06:43 +01:00
Paulo Reis
5a75663a0c Do bulk rejects in reverse order. 2017-06-05 17:17:47 +01:00
Shane Kilkelly
f7ad4a4786 WIP: basically working, with client sync 2017-06-05 14:48:50 +01:00
Shane Kilkelly
51881dbbcc Only load labels from current doc if change is local 2017-06-05 11:09:58 +01:00
Paulo Reis
8d8bcab1e8 Consolidate change accept and reject code. 2017-06-05 10:41:59 +01:00
Shane Kilkelly
4cb41a988a WIP: initial work on server-side labels 2017-06-02 15:12:59 +01:00
Shane Kilkelly
51e3a6b3a3 Don't use String.startsWith, use slice instead.
- String.startsWith is not supported in IE
2017-06-02 09:54:48 +01:00
Shane Kilkelly
9a15420c4e Merge branch 'master' into sk-labels-autocomplete 2017-06-01 08:34:56 +01:00
Shane Kilkelly
039d18bf8b Simplify logic for deciding whether to re-scan doc on not 2017-05-26 15:08:38 +01:00
Shane Kilkelly
faf0337ca9 Refactor labels autocomplete 2017-05-26 14:56:38 +01:00
Shane Kilkelly
7923450e25 Move labelsManager into aceEditor directory 2017-05-25 09:42:07 +01:00
Shane Kilkelly
ea9a0dda83 More robust change detection for autocomplete.
- accurately detect when labels are involved in 'remove' event
2017-05-25 09:33:15 +01:00
Shane Kilkelly
b871cdab4c Remove debug logs 2017-05-24 14:28:15 +01:00
Shane Kilkelly
1f3a375b4e Update commentary 2017-05-24 11:42:00 +01:00
Shane Kilkelly
da84b3f31c WIP: basically working labels/ref autocomplete 2017-05-24 11:40:12 +01:00
Shane Kilkelly
c43a2087d7 WIP: autocomplete for label/ref 2017-05-24 10:07:14 +01:00
Paulo Reis
58ad62c413 Relayout entries when commenting. 2017-05-19 16:57:51 +01:00
Paulo Reis
957b201fc1 Add commenting and track-changes keyboard shortcuts. 2017-05-19 15:28:49 +01:00
Paulo Reis
832764dd3d Add key shortcut to toggle the review panel. 2017-05-18 11:02:50 +01:00
Paulo Reis
7f3c0ed5ac Refactor accept and reject methods to support multiple changes; support bulk actions events. 2017-05-16 14:27:06 +01:00
James Allen
b22ef30876 Merge pull request #456 from sharelatex/ja-show-too-many-track-changes-error
Show an explanation error message on too many track changes error
2017-03-21 13:15:14 +00:00
James Allen
3c2f5525a1 Show an explanation error message on too many track changes error 2017-03-17 14:49:32 +00:00
James Allen
aa36768d8a Remove debugging line 2017-03-16 16:01:03 +00:00
James Allen
6c1a15a698 Move comments when cutting and pasting 2017-03-16 15:48:57 +00:00
James Allen
a6679a1aeb Stop local and remote ops being batched together in the undo manager if they happen in the same flush 2017-03-01 16:33:04 +00:00
James Allen
dd0271e799 Only cancel deletes with inserts on undo and reject 2017-02-24 14:20:26 +01:00
James Allen
7418d12bf8 Defer updates of remote ops until Ace has been updated 2017-02-23 11:34:58 +01:00