github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity
21716 commits 3 branches 7 tags 206 MiB
Commit graph

499 commits

Author SHA1 Message Date
Mathias Jakobsen
4ed5e01deb Merge pull request #13680 from overleaf/td-review-panel-right-pos 
Remove gap on right-hand side of editor with React review panel

GitOrigin-RevId: 50d4af9419fcaa95aabf609d36ecaeea0ce45bbe
 2023-07-17 10:57:32 +00:00
Tyna William
a16f168e54 Merge pull request #13649 from overleaf/rd-alignment-form-elements 
Improve form elements alignment on homepage

GitOrigin-RevId: b85f3ebbf4e4e67628dceebbcf21afc0c620cdc1
 2023-07-17 10:55:17 +00:00
Rebeka
7f5be3ed04 Make left menu sidebar a Modal 
GitOrigin-RevId: 63630c2a98c3abb5c5ebbde0afe25c0aa981282b
 2023-07-17 10:53:03 +00:00
ilkin-overleaf
936ab81b65 Merge pull request #13641 from overleaf/ii-review-panel-migration-overview-view 
[web] Create overview view shell for review panel

GitOrigin-RevId: 21cc8a744253aec53f089ec6e6c1221d7153f3a4
 2023-07-17 10:50:58 +00:00
Rebeka
8cd9b4051c add split test variant for the registration and login page 
GitOrigin-RevId: bdaab96937b9f3cd53545b4a4eb9a3bd634a056e
 2023-07-17 10:47:18 +00:00
Domagoj Kriskovic
17452b51d7 [cm6] Add toolbar to Source Mode for Beta users (#13429) 
* [cm6] toolbar for source mode

* top:0 for new toolbar

* empty div for extensions

* fix legacy css top pos

* show source toolbar split test

* prettier

* show beta icon in source editor

* dropdown toolbar wip

* fix wrong conflict resolve

* math dropdown, chrome extension fixes

* math dropdown cleanup

* sort en.json

* fix sort en.json

* using isVisual

* getMeta in component, pug update

* using flex grow

* toolbar beta badge

* remove extra whitespace

* has-legacy-toolbar class

* Increase container size

* fix tests

* prettier

* styling fixes, using SplitTestBadge

* only show source toolbar if flag is set

* fix typo

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 34b01a9421f4a0d6defc40925c5092901575946e
 2023-07-17 10:46:26 +00:00
ilkin-overleaf
9e8be31bdf Merge pull request #13573 from overleaf/ii-review-panel-migration-comment-entry 
[web] Create comment entries

GitOrigin-RevId: 7f3fbe672d18d57a0f5e683e5456ea79ed295e2d
 2023-07-17 10:45:32 +00:00
ilkin-overleaf
b61ee4c4d3 Merge pull request #13528 from overleaf/ii-review-panel-migration-current-file-view 
[web] Create initial current file container

GitOrigin-RevId: 81635922bb10b97637af296d987f28d43cf61262
 2023-07-17 10:42:51 +00:00
ilkin-overleaf
423f2604db Merge pull request #13500 from overleaf/ii-review-panel-migration-nav 
[web] Create review panel navigation

GitOrigin-RevId: abed4171e9fd52de2f137a6cf7456791bc2ca161
 2023-07-17 10:39:20 +00:00
M Fahru
542199febb Merge pull request #13419 from overleaf/mf-sync-border-radius-and-border-color-plans-table 
Fix various plans page border-related UI errors

GitOrigin-RevId: 90436bdd3002722e5ce6b08d79d2bf3db1b6c90f
 2023-07-17 10:36:56 +00:00
ilkin-overleaf
15f4e2e5cc Merge pull request #13487 from overleaf/ii-review-panel-migration-create-panel-toggler 
[web] Create review panel toggler

GitOrigin-RevId: f50422b99dbd8bbc2f1fbf323419ee13403c9ba6
 2023-07-17 10:36:11 +00:00
ilkin-overleaf
e514e97305 Merge pull request #13438 from overleaf/ii-review-panel-toolbar-shell 
[web] Create review panel toolbar shell

GitOrigin-RevId: 561fb18e1239c9b96b52944716a83cf3b8606677
 2023-07-17 10:34:04 +00:00
M Fahru
40e27a1636 [web][plans-page] Fix UI bug where some of the plans table cell's child doesn't fill their parent's height (both td and th) (#13391) 
* Fix UI bug where some of the table cell's child doesn't fill their parent's height:

1. On plans-v2-table first row, every `th > div.plans-v2-table-th-content` element need to have a 100% height because they have a white background and their height has to fill the entire `th`.

2. On other rows, every `td > div.plans-v2-table-cell` element needs to have a 100% height with centered content, both vertically and horizontally. This is also because they have a white background and since each row can have a different height, 100% height is needed to make sure the white background is filling the `td` properly.

* Add a comment to explain the explicit `height` rule on `table.plans-v2-table` even though it will be ignored.

GitOrigin-RevId: 1ce059d1e2445213bc911a22dfb0ea984749597d
 2023-07-17 10:32:42 +00:00
M Fahru
d001c89801 [web][plans-page] Reduce font size of table heading for screen size >= 1200px from 20px to 19px for group table (#13373) 
GitOrigin-RevId: 11a3fa60038f5728f369ed9c74a50fd4b7e9f714
 2023-07-17 10:32:33 +00:00
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix 
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
 2023-07-17 10:32:07 +00:00
Davinder Singh
88d0254dde Merge pull request #13390 from overleaf/ab-managers-page-styling 
[web] Full-row links styling for group subscription links in dash

GitOrigin-RevId: f3b2dd67e9c14cf8fde1df41d74d380c06cc3d4c
 2023-07-17 10:31:18 +00:00
Alf Eaton
480ec139ab Merge pull request #13408 from overleaf/ae-revert-resolve-comment 
Revert "create context api for review panel"

GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
 2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767 Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api 
[web] Create context api for review panel

GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
 2023-07-17 10:29:53 +00:00
M Fahru
ed42d0c9ca Make the switch to editor/pdf button to have the same height (#12110) 
GitOrigin-RevId: 5ceaad73c6c6b74ce2b6e8bbc79563bfad6ab34b
 2023-07-17 10:26:34 +00:00
Rebeka
75c5f16114 fix: improve the text contrast ratio of the editor sidebar 
GitOrigin-RevId: 01fb558f3c8b1cff611200b2b309a28c7823305b
 2023-07-17 10:26:25 +00:00
ilkin-overleaf
b3903a6c88 Merge pull request #13364 from overleaf/mf-fix-system-messages-ui-position 
Fix project list translation message UI position

GitOrigin-RevId: 7cef24162134a604031098b27b4d92ccff7a254e
 2023-07-17 10:26:14 +00:00
ilkin-overleaf
2fceaa6085 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag 
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
 2023-07-17 10:26:04 +00:00
Rebeka
a412f3d70e Add error boundary to the project dashboard list 
GitOrigin-RevId: 0f4cc3b4db62efe25ceeff202f305d08ddd73968
 2023-07-17 10:24:38 +00:00
M Fahru
c90fafa8ac Fix plans page mobile header has a bigger z-index than navbar and cause UI bug if mobile navbar is expanded (#13269) 
GitOrigin-RevId: d6fc2727eaa1f66f04217efcb8498a1bf99c9201
 2023-06-02 08:08:16 +00:00
M Fahru
8c549aa0fa Implement new welcome page UI with split test (#11677) 
GitOrigin-RevId: 3028ee5e34802e4f9a29cb752fcfa8ca6d5c284c
 2023-06-01 08:05:01 +00:00
Tim Down
a74eecd110 Merge pull request #13259 from overleaf/td-history-survey-link 
History migration: Add beta badge to history toolbar

GitOrigin-RevId: e5c818953a7d41c31018a2d39c3937d70c057f8c
 2023-06-01 08:04:24 +00:00
Jimmy Domagala-Tang
b6f0b32df5 Merge pull request #13234 from overleaf/jdt-subscriptions-cols-fix 
fix col spacing on subscription page

GitOrigin-RevId: 886274f7b566632ac4f4ca3388d43b1b03575f6f
 2023-05-26 08:05:19 +00:00
M Fahru
c7a80f9228 History migration: Wrap history version item texts in version history list (#12961) 
Texts that need individual wrapping so they won't overflow the history item:

- long file name
- long label name
- long tooltip text
- long user email

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: 3f75c4173dd59524de1148b22bcbc1d856c021eb
 2023-05-26 08:04:53 +00:00
Alf Eaton
ac19140362 Unmask the editor when changing editor theme (#12604) 
GitOrigin-RevId: 633d12c748cfd615fa72698f886a452c5b2fd2bb
 2023-05-25 08:04:57 +00:00
Alf Eaton
142cfb51d9 Merge pull request #13173 from overleaf/td-history-menu-jump 
History migration: Remove initial jump on displaying menu and line up menu items nicely

GitOrigin-RevId: f04c01565aa9ea128e87543fa7108d7fb0ae8657
 2023-05-25 08:04:23 +00:00
Tim Down
fd8557ef39 Merge pull request #13159 from overleaf/td-history-comparison-text-icon-tweaks 
History migration: Icon and text changes to version comparison, switch order of from and to

GitOrigin-RevId: e31db255c55caf15481ed0237875e637c0ac0861
 2023-05-23 08:04:15 +00:00
Mathias Jakobsen
e895208665 Merge pull request #13138 from overleaf/mj-figure-modal-checkbox-color 
[cm6] Use green accent color for checkbox in figure modal

GitOrigin-RevId: 20fe68ee51ff4d97a37690b4dd23905860956ff6
 2023-05-22 08:04:34 +00:00
Mathias Jakobsen
948d56e809 Merge pull request #13136 from overleaf/mj-figure-modal-spacing 
[cm6] Adjust spacing in figure modal

GitOrigin-RevId: dc18186ff422292648d58c6d99718cc33e4d0f84
 2023-05-22 08:04:26 +00:00
Alf Eaton
5c78718729 Fix ordering of PDF preview layers (#13132) 
GitOrigin-RevId: 1f9429f7e760035377990b12ce9ef8c39b3d0534
 2023-05-19 08:04:08 +00:00
Alf Eaton
1f7d317db9 Upgrade pdf.js to 3.6.172 (#13112) 
GitOrigin-RevId: 030528343f271a1fc1e07c3bba358873173bec76
 2023-05-18 08:04:03 +00:00
Miguel Serrano
27c2d1c16e [web] Personal Access Token Settings UI (#13040) 
* [web] Personal Access Token Settings UI

* [web] Add Personal Access Token Settings UI to settings page

* [web] Added `personal-access-token-settings` unit tests

GitOrigin-RevId: 353b2f1a2b57c3292554f129be6cbb4f8f8382f8
 2023-05-17 09:28:01 +00:00
June Kelly
ff4ac0a803 Merge pull request #12851 from overleaf/jk-dashboard-filter-visibility 
[web] Improve filter visibility on project dashboard

GitOrigin-RevId: de7a9f999d6d0164ab3c18c58e305c7c628f946c
 2023-05-17 08:03:39 +00:00
Mathias Jakobsen
31190b967b [cm6] Add figure modal (#12751) 
GitOrigin-RevId: 3043d1369ed85b38b1fec7479385b123a304c05b
 2023-05-16 08:04:02 +00:00
Alf Eaton
0ffa75979f Merge pull request #13001 from overleaf/td-history-version-hover-style 
History migration: Use green selected style when hovering over selected version

GitOrigin-RevId: 7771ce64d719c3d0e5264dfd2fbbf52f5b519213
 2023-05-10 08:05:45 +00:00
Alf Eaton
4e6749966e Add Writefull promo banner to project list (#12843) 
GitOrigin-RevId: a41746a29dfba867ff60401cfce1478812358644
 2023-05-10 08:05:37 +00:00
Tim Down
478b463e5f Merge pull request #12871 from overleaf/td-history-update-button-shadow 
History migration: add shadow to "more updates" buttons

GitOrigin-RevId: e74cd8f8b7cf27393483b7c675f3ed607a5d6b06
 2023-05-10 08:04:10 +00:00
M Fahru
c19fa74aa4 In history react file tree, always show badge (stick to the right side) and truncate long filename with ellipsis (#12897) 
GitOrigin-RevId: 2e982f03b7a60e506f061a2c5bf1ab3d93dfccf5
 2023-05-09 08:05:08 +00:00
Tim Down
76103eb77f Merge pull request #12874 from overleaf/td-history-binary-file 
History migration: Show alert for binary file preview

GitOrigin-RevId: f30e4946ce9f873661055b8a096c6aba7ab08e2d
 2023-05-02 19:45:22 +00:00
Tim Down
1fb921de99 History migration: Add error handling for all history requests (#12872) 
* Add error handling for all history requests

* Remove comment

GitOrigin-RevId: 528dc98a0fc4ab523f8536274996c4166be45064
 2023-05-02 19:44:48 +00:00
Tim Down
70bae34bd8 Add paywall to React history view (#12849) 
* Implement history view paywall

* Add tests and some CSS fallbacks

* Make additional faded version above paywall non-clickable

* Change isFaded to faded for consistency

* Remove unused import

* Add missing attribute

* SHow all labels in free tier

* Address review comments

* Change Boolean conversion

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* Make adding or deleting a label show up in version list again

* Refactor to use visibleUpdateCount rather than maintaining two separate update arrays

* Removed unused import

* Use data-testid instead on class

* Round gradient values

* Correct test selector

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: a2b021f3f4d3b9eb1358edb2ee4aa7db1bc7240e
 2023-05-02 19:44:39 +00:00
M Fahru
0648b8aa6c Implement deleted file restore for history react (#12753) 
* Add strikethrough to deleted file tree item in history file tree

* Add "restore file" button on toolbar if the selected file have a `removed` operation.

* Implement "restore file" functionality on removed file:

- Refactor the `Selection` object in history context value since we need the `deletedAtV` data which currently is not passed through the state.
- Refactor and clean up file tree type system to support passing through the whole `FileDiff` object for getting the `deletedAtV` data which only appear on `removed` operation
- Implement `postJSON` with file restoration API and pass it on restore file onClick handler at toolbar

* Implement loading behaviour while restoring file is inflight:

- Add `loadingRestoreFile` to `LoadingState`
- Change restore file button to `Restoring...` when in loading state.

* Refactor:

- Rename `DiffOperation` to `FileOperation`
- Extract `isFileRemoved` and `isFileRenamed` to its own file
- Extract `Toolbar` components into small files

GitOrigin-RevId: 2e32ebd2165f73fc6533ff282a9c084162efd682
 2023-04-28 08:04:59 +00:00
Domagoj Kriskovic
3d5e8c9877 add 'Ace removal' notification (#12800) 
* add 'Ace removal' notification

* prettier

* add memo, window.clearTimeout

* remove warning for server pro

* added tracking events

* useCallback for onClick

* fix: event rename

GitOrigin-RevId: 70bce8b93bae233e7183a941abaf2ec7a70ddfb6
 2023-04-28 08:04:19 +00:00
ilkin-overleaf
0895e33235 Merge pull request #12773 from overleaf/ii-history-react-changes-list-dropdown 
[web] Actions dropdown history migration

GitOrigin-RevId: 6b7055501c5eb1529b1794db92bb9f5f3faa6648
 2023-04-26 08:05:24 +00:00
June Kelly
f5740e6b17 Merge pull request #12593 from overleaf/jk-remove-plans-split-test 
[web] Remove 'plans-page-layout-v3' split test

GitOrigin-RevId: 91e0d3d8bc40632df630131b2e872fa824015da5
 2023-04-26 08:04:21 +00:00
Tim Down
afd1195902 Add infinite scrolling to history versions list (#12752) 
* Add infinite scrolling to change list, add spinner while doing initial updates load, refactor updates state

* Update type in tests

* Update types

* Using LoadingSpinner component

* Remove redundant imports

GitOrigin-RevId: 98c7eae8edbc4d10d7107d825045edfc4159494f
 2023-04-25 08:06:22 +00:00
Rebeka
b063495200 fix: fit text inside the circle shape 
GitOrigin-RevId: 81167ee6ebc281a7a403ff2fdc3b19f4cc91d6be
 2023-04-24 08:02:42 +00:00
M Fahru
4dec157e08 Implement history react toolbar UI (#12530) 
There are two different UI in this PR: `comparing` and `viewing` mode.

- For `comparing`, the user would be shown two separate date. It uses the `UpdateRange` object and this PR adds a timestamp to both `fromV` and `toV` of the object type.
- For `viewing`, the user would only be shown one date since `viewing` mode means viewing a specific update version.

Some other notable changes:

- Move `diff` state to `diff-view.tsx`, which contains `main.tsx` (main editor history view) and `toolbar.tsx` as its children
- refactor `autoSelectFile` by passing `updateRange.toV` directly
- refactor `updateIsSelected` by passing an object that contains `fromV` and `toV` instead of passing `update

There's also a cypress test for both the `viewing` mode and `comparing` mode in this PR.

GitOrigin-RevId: ba54f073f3479c55a39eb6b2932ea7faff78dddc
 2023-04-21 08:03:39 +00:00
M Fahru
08d2eea47a Decouple history-file-tree styling out of editor file tree: 
- Extract/duplicate the style from editor file tree (only extract styling that's being used in history file tree)
- Change some of the class name to avoid duplicated class name from the editor file tree
- Revert change to editor file tree since it has been moved to history file tree

GitOrigin-RevId: 6c3b20080c9b428363024db622f60e3540d919e6
 2023-04-21 08:03:36 +00:00
Ilkin Ismailov
dd5509b16f add sm size to badge 
GitOrigin-RevId: 4e69d582ce770abcff10f3a6b34662f4873fc224
 2023-04-21 08:03:33 +00:00
M Fahru
8212b686c6 Implement new style for history file tree badge 
GitOrigin-RevId: 6221bc00e5aecf49fd3f2657128d1e9a2d4e648b
 2023-04-21 08:03:30 +00:00
Tim Down
99e1ff0804 Merge pull request #12644 from overleaf/td-history-compare 
Initial implementation of comparing history versions

GitOrigin-RevId: 890e270d6e41856a79689ab41ccfbde25c4703ba
 2023-04-19 08:03:25 +00:00
Jessica Lawshe
6fc5385ca6 Merge pull request #12249 from overleaf/tm-gallery-top-picks 
Implement top picks in template gallery for CVs

GitOrigin-RevId: 22f720582e27fac2b9e454ce4e28bd124de094b7
 2023-04-19 08:03:19 +00:00
Tim Down
38998afa8e Implement history diff viewer buttons (#12439) 
GitOrigin-RevId: 0ed8eb8568783b4938188a86c4ee75c767e6d713
 2023-04-17 08:05:41 +00:00
Jakob Ackermann
3841177931 Merge pull request #12504 from overleaf/jel-cms-card-padding 
[web] Option to set padding on CMS rows

GitOrigin-RevId: 297344c9bf6c04eae630f1ddbed59f9519d4e4c7
 2023-04-14 08:03:19 +00:00
Alexandre Bourdin
481cd14cb1 Merge pull request #12557 from overleaf/ii-history-react-labels-only 
[web] History labels only list

GitOrigin-RevId: 58b8e5a5af0754e32841223f9c478c25900df526
 2023-04-13 08:04:12 +00:00
Alexandre Bourdin
04c204f989 [web] Colour picker for tags (#12255) 
* Base for color picker

* React color picker and updated modals

* Add tag color picker to mobile dashboard

* Update existing tests and fix disable save button condition

* CSS adaptations for desktop modal streched into mobile display

* Update TagsController tests

* Add aria-hidden label on color pickers

* Fix linting

* Fix project list test

* Select random color when creating tag

* Cleanup leftovers in project list context

* Test cleanup

* Pre-select custom color and store local color while picking

* Add type to preset colors

* Add css fix to override disabled button opacity

* Skip redundant check

* Fix linting

* Add back btn-secondary on manage tag modal after rebase

GitOrigin-RevId: a4cf24e85cc0ca01466f4bf9c77482be8360e68e
 2023-04-13 08:04:03 +00:00
ilkin-overleaf
8e0aa685ce Merge pull request #12549 from overleaf/ii-history-react-list-of-all-versions 
[web] All versions of history entries

GitOrigin-RevId: 7365ac4913c115b3b2872a3713d893463719c15e
 2023-04-12 08:03:47 +00:00
M Fahru
17a98d756e Add badges UI to history react file tree (#12479) 
GitOrigin-RevId: 52c45b72110e01bb193139654fa9385cb9b9e489
 2023-04-05 08:03:05 +00:00
Jessica Lawshe
91ec3ca47e Merge pull request #12425 from overleaf/jel-mobile-padding 
[web] Option to add padding for mobile layout on CMS pages

GitOrigin-RevId: 33775905725710d7fc16d84c00af643c4adcc590
 2023-04-04 08:04:46 +00:00
Jessica Lawshe
df8000fa83 Merge pull request #12414 from overleaf/jel-grid-in-card 
[web] Option to render grid in a card on the CMS

GitOrigin-RevId: b65ee396915b4e8622384ab37a453d59b1d18c88
 2023-04-04 08:04:38 +00:00
Tim Down
11f8905be4 Connect up document diff viewer to history state 
GitOrigin-RevId: 610a254ea77c194969033d0791ecf1129e02c4bf
 2023-03-31 08:03:47 +00:00
ilkin-overleaf
867b37b76f Merge pull request #12417 from overleaf/ii-history-react-toggle-switch 
[web] Toggle switch history migration

GitOrigin-RevId: c0812d03d576bc66dd8878fa80d4ac18dd8576d0
 2023-03-30 08:04:22 +00:00
Alf Eaton
4ccf67203b Fix editor switcher colour transition (#12328) 
GitOrigin-RevId: fc8caa34b12b9ef35422766023cdebf4bd36ff75
 2023-03-30 08:03:20 +00:00
Jessica Lawshe
be6b89e9cf Merge pull request #12356 from overleaf/revert-12354-revert-12330-jel-grid-3-and-4-col 
Revert "Revert "[web] Add 3 and 4 column options to Layout | Grid on the CMS""

GitOrigin-RevId: b24230c5f4f34bf2baa01ea82d73af1346ad95c8
 2023-03-30 08:03:00 +00:00
Tim Down
397fbd47c2 Merge pull request #12363 from overleaf/td-history-main-area-shell 
Add CSS for main history view shell

GitOrigin-RevId: 9c455007bf8b177d59ea97cd73b608d48aba3907
 2023-03-30 08:02:54 +00:00
ilkin-overleaf
d1d47b2767 Merge pull request #12339 from overleaf/ii-react-history-editor-and-change-list-init 
[web] History editor and change list initialisation

GitOrigin-RevId: bb7800301d28c296bd524212cd27ddcd8defd149
 2023-03-23 09:06:24 +00:00
Jessica Lawshe
e934e9af3d Merge pull request #12354 from overleaf/revert-12330-jel-grid-3-and-4-col 
Revert "[web] Add 3 and 4 column options to `Layout | Grid` on the CMS"

GitOrigin-RevId: fea5f87e74fe9915f4ee7653ed60ff4261b4d144
 2023-03-23 09:05:48 +00:00
Jessica Lawshe
8a572673c3 Merge pull request #12330 from overleaf/jel-grid-3-and-4-col 
[web] Add 3 and 4 column options to `Layout | Grid` on the CMS

GitOrigin-RevId: 6003907344bb84c16678ff4e4424b9348a4cb0df
 2023-03-23 09:05:40 +00:00
Jakob Ackermann
c9513b79d3 Merge pull request #12155 from overleaf/ii-safari-project-title 
[web] Adjust project checkboxes in project dash

GitOrigin-RevId: 42d40394eb1d933ba3c771ec7f5f873ead8cd770
 2023-03-17 09:04:16 +00:00
Jessica Lawshe
b10b7b1f91 Merge pull request #12042 from overleaf/jel-change-plan 
[web] Change plan UI now in a modal and update the style

GitOrigin-RevId: 1b501b4a972ca676cff32f531862c15c0c8f9e61
 2023-03-09 09:05:05 +00:00
Tim Down
1f2c06b1d0 Position Grammarly button on top of CM6 editor 
GitOrigin-RevId: f96d1897c38e8e14e9247690ee49972a2170f80e
 2023-03-07 09:06:33 +00:00
M Fahru
20f8fc2dc0 Revert "Refactor project list notification by using onDismiss on Alert instead of custom Close component (#12043)" (#12133) 
This reverts commit 9a3f95c322a063b84094452c21cb734a379da978

GitOrigin-RevId: 31fb4b1d429e2e9c611178afc3dc3c662340be44
 2023-03-07 09:06:25 +00:00
M Fahru
06b75ebee2 Refactor project list notification by using onDismiss on Alert instead of custom Close component (#12043) 
* Refactor project list notification by using `onDismiss` on `Alert` and not using the custom `Close` component

* Add dismissible alerts to storybook

GitOrigin-RevId: 9a3f95c322a063b84094452c21cb734a379da978
 2023-03-07 09:05:48 +00:00
Davinder Singh
cc2d1a26e2 Merge pull request #11958 from overleaf/ds-td-documentation-btn-refactor 
Styling and HTML structure of the documentation button

GitOrigin-RevId: e643edbe05579c037ca1ec27fab765974e74d2c5
 2023-02-27 09:03:47 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772) 
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
 2023-02-22 09:04:42 +00:00
Alf Eaton
1807f18b7d Add a tooltip to the disabled Rich Text toggle (#11843) 
GitOrigin-RevId: e7be96c68d87ab1f1ed40c8e9784160689ee8e96
 2023-02-17 09:04:15 +00:00
Davinder Singh
ba2d5db50c Merge pull request #11670 from overleaf/ab-manage-members-back-button 
[web] Add a back button on the members/managers management pages

GitOrigin-RevId: 7a723853683438ebac91eb534f9fb9a445a306c9
 2023-02-15 09:04:46 +00:00
Davinder Singh
de245c288a Merge pull request #11653 from overleaf/ds-documentation-btn-on-editor 
Adding documentation button on the editor

GitOrigin-RevId: e03fd7b931eb0fe7273e6e9d0185c81c384df916
 2023-02-15 09:04:37 +00:00
Eric Mc Sween
204e7a0c87 Merge pull request #11719 from overleaf/em-survey-sidebar 
Make survey notification the width of the dashboard sidebar

GitOrigin-RevId: 754ec21692505107e683369628a2b5481e7cef9a
 2023-02-09 09:06:29 +00:00
June Kelly
035b5cd456 Merge pull request #11263 from overleaf/ae-rich-text-available 
Only enable the Rich Text option for supported file extensions

GitOrigin-RevId: ae67435b50701bb5be71bab94d8c3c4da4129d88
 2023-02-09 09:05:05 +00:00
Thomas
ce79f03b87 Merge pull request #11706 from overleaf/jpa-fix-de-translations 
[web] fix a few German translations

GitOrigin-RevId: a19713144a236e367a28bd443919bd81acbb4656
 2023-02-09 09:03:57 +00:00
M Fahru
5f3ef71e43 Implement 'Add Affiliation' UI on the mobile version of the new react dashboard (#11606) 
* Refactor & change `add-affiliation.tsx` file:
    * Change class from `user-profile` to `add-affiliation`
    * Add new optional `className` props for custom styling

* Show affiliation widget on mobile screen:

* Fix bug on use add affiliation hooks: return type should be `boolean`, not `boolean | 0`

GitOrigin-RevId: 800b951e2a012797266b1780993b4ed9a918d565
 2023-02-08 09:07:23 +00:00
Alf Eaton
85fbded781 Improve the Rich Text toolbar (#11616) 
GitOrigin-RevId: d1999be629ac048058ffd82004865728796a3feb
 2023-02-07 09:04:39 +00:00
ilkin-overleaf
db54475bd0 Merge pull request #11525 from overleaf/ii-payment-page-migration-init 
[web] Payment page migration initialisation

GitOrigin-RevId: f33b73a13b96fad3cddf0c0205d05df678ce5300
 2023-02-02 18:21:52 +00:00
M Fahru
1d04aa0315 Editor file uploader design update (#11447) 
* Redesign the styling of conflict state for file upload in the editor

* Change overwrite button style from primary (green) to danger (red)

* Change the idle state and dragging state styling to match the error state new design:

    *remove the double border; only keep the dashed border
    * on idle state, change border color

* Add hardcoded texts to translation file

* Add padding to prevent text is becoming too near to the border when multiple files appear in the conflict file list

* Apply custom file uploader style to smaller screen

GitOrigin-RevId: 266e60bb8575a02c02c1ed1d7fa04cdb101f3dd1
 2023-02-02 09:03:33 +00:00
M Fahru
781c1c97c7 Implement new three-way split test for the plans page (#11493) 
* Update split test config and infrastructure for plans-page-layout-v3

* Implement view for `old-plans-page-annual` variant of the new split test:
    - Make `annual` the default view for all elements on the old plans page
    - Change the tooltip background to green for monthly/student view

* Implement a new design for the new plans page:
    - switch annual and monthly locations (annual on the left now)
    - change the tooltip background to green color for all choice
    - make the monthly-annual switch has green background if annual is chosen

* Fix mobile view plans page header style

GitOrigin-RevId: b2b3c6ac6adbe26bf6def7e072493f503793cfcb
 2023-01-30 09:02:45 +00:00
Jessica Lawshe
14039c6729 Merge pull request #11129 from overleaf/jel-survey-link-mobile 
[web] Fix line height for survey text on mobile

GitOrigin-RevId: f96e682b8534d7404c89b45ad4264538bf8a0a2e
 2023-01-27 09:05:14 +00:00
Alf Eaton
69fe1749ce [rich-text] Improve toolbar button styles (#11419) 
GitOrigin-RevId: 81def8f65591fe9f8f914384db971238faa4483f
 2023-01-25 09:05:26 +00:00
Mathias Jakobsen
f3dac1aa95 [cm6+rt] Move CM6 formatting toolbar to panel (#11395) 
GitOrigin-RevId: 97036c57d63fb7590dda7c98df3347ee83f41ae5
 2023-01-25 09:05:05 +00:00
Alf Eaton
68a3b93eca Merge pull request #11311 from overleaf/jpa-plans-page-tooltip-width 
[web] plans page: allow tooltips to be slightly larger

GitOrigin-RevId: 17bb0c0a1ae6a88efe5e0d2df284bd28f6e5824b
 2023-01-24 09:04:57 +00:00
Alf Eaton
cf8051dcad Advertise CM6 Rich Text in the CM5 track changes panel (#11361) 
GitOrigin-RevId: 3d2e43263528c64292a01afb3d032e11a6cbbfb9
 2023-01-24 09:04:13 +00:00
M Fahru
29fbc253fd Clean up link sharing upgrade prompt test and keep the default variant 
GitOrigin-RevId: d34ed081bbc61dfc74a7117c0ba633db4b5a0bad
 2023-01-20 14:13:51 +00:00
Tim Down
467936e655 Merge pull request #11285 from overleaf/mf-fix-margin-bottom-dashboard 
Add margin bottom to project dashboard search on mobile view

GitOrigin-RevId: e44d567d2848b23cbffc2b0dc487c468e3313bc4
 2023-01-18 15:08:41 +00:00
Miguel Serrano
ed9bd54836 Merge pull request #11308 from overleaf/revert-11289-mj-right-toolbar 
Revert "[web] Change pdf control toolbar alignment for CM6 RT"

GitOrigin-RevId: 71e7941afbdb3e77186760e3d2a0ce3655bdbc1a
 2023-01-18 15:07:50 +00:00
Alf Eaton
a1aa65724a Merge pull request #11289 from overleaf/mj-right-toolbar 
[web] Change pdf control toolbar alignment for CM6 RT

GitOrigin-RevId: c3906df7ebf8da7097c680cdd58fc4bfb3f75704
 2023-01-18 09:04:23 +00:00
Mathias Jakobsen
778aa45e96 Merge pull request #11247 from overleaf/mj-toolbar-overflow 
[cm6+rt] Wrap formatting buttons if editor is too narrow

GitOrigin-RevId: d1b234c721f4bed67f1da567b90139f0c95895f0
 2023-01-17 09:05:27 +00:00
M Fahru
19e1d50e2e Fix editor overleaf logo on editor disappears if menu button is pressed in light theme 
GitOrigin-RevId: a4f104cf988bfc267ba70cbe546e150bea773691
 2023-01-13 09:05:07 +00:00
ilkin-overleaf
4f35333a39 Merge pull request #9536 from overleaf/ii-adjustable-project-dashboard-panel 
[web] Adjustable project dashboard sidebar

GitOrigin-RevId: 1007ecb896bbe215af28fa92d295201b2457aeef
 2023-01-10 09:05:44 +00:00
Jessica Lawshe
77c0802035 Merge pull request #10925 from overleaf/jel-vertical-align-css 
[web] Better vertically align content in CMS pages

GitOrigin-RevId: 276cd3f4566bfbbc5a79b91d5f1567ae4d618280
 2022-12-20 09:04:59 +00:00
Davinder Singh
306b2b7727 Merge pull request #10844 from overleaf/ds-editor-btn-info-to-secondary 
Replacing `btn-info` with `btn-secondary-info btn-secondary` in the editor

GitOrigin-RevId: 1e348b0b09bfd08508a3dbee7df882f41fdc16eb
 2022-12-19 09:04:17 +00:00
Davinder Singh
e7e1fcef3b Merge pull request #10796 from overleaf/ds-plans-page-btn-tag 
Replaced the a tag with button tag for plans page plans options

GitOrigin-RevId: 4717067ce0fc9209a65c0d323602d834a90951fc
 2022-12-19 09:04:10 +00:00
M Fahru
55375c78bf Fix tooltip and table header appearing on top of the navbar (z-index bug) (#10873) 
GitOrigin-RevId: 88f88ff5b491356df8b34bfaf97ead28da2ff451
 2022-12-13 09:05:01 +00:00
M Fahru
558cf0715a Fix wrong border radius location on new plans page group and student table (#10874) 
GitOrigin-RevId: 744b81b3e5a7b189dc1e86efd00680901a53b494
 2022-12-13 09:04:54 +00:00
Jessica Lawshe
30a47a2bb5 Merge pull request #10872 from overleaf/jel-cms-vertically-center-fix 
[web] Vertically center columns when option selected on CMS

GitOrigin-RevId: 55b4c0d6061dc400167cbbc2e7a7d15b1e40fb43
 2022-12-13 09:04:41 +00:00
Jessica Lawshe
c7a10558bf Merge pull request #10830 from overleaf/jel-remove-test-show-unified-navigation 
[web] Remove `unified-navigation` references in code

GitOrigin-RevId: bbcea3c8013936a8e5eaed18e6121344a3c05e9a
 2022-12-13 09:04:28 +00:00
Alf Eaton
9f1f62b9be Add rich-text mode to CM6 (#10775) 
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
 2022-12-13 09:03:54 +00:00
Davinder Singh
60dc53e685 Merge pull request #10790 from overleaf/ds-history-toggle-bug-fix 
Fixed the bug with 2/3 way segmented control.

GitOrigin-RevId: d2e340c097d60ef47b4cf2817a413cc574a871de
 2022-12-08 09:03:57 +00:00
Davinder Singh
4adfca52bf Merge pull request #10682 from overleaf/ds-btn-default-to-secondary-in-editor-part-2 
Replacing btn-default with btn-secondary in the editor Part-2

GitOrigin-RevId: 708aa29070bb3049afbc8ee1a282eaa1018594a8
 2022-12-08 09:03:42 +00:00
Tim Down
08567c290e Add second CM6 switch-away survey (#10789) 
Restart CM6 switch-away survey

GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
 2022-12-07 09:04:35 +00:00
Jessica Lawshe
34d4987776 Merge pull request #10774 from overleaf/jel-new-page-style 
[web] Updates to new page style

GitOrigin-RevId: 4d29b4642efef608164fb9fc6875c1618565d231
 2022-12-06 09:05:04 +00:00
Jessica Lawshe
3d0d311584 Merge pull request #10754 from overleaf/jel-cms-vertically-center-col 
[web] Only center columns when the vertically centered option selected on CMS grids

GitOrigin-RevId: 7890c870d5058ee927f66d7cd693b3cd35a2e117
 2022-12-06 09:04:43 +00:00
June Kelly
4b856dbd70 Merge pull request #10116 from overleaf/jel-dash-action-checked-list 
[web] Use other checked list class on dash action modal

GitOrigin-RevId: 22afaf805e57813e243543912811207a74ae85ed
 2022-12-02 09:03:42 +00:00
Jessica Lawshe
be520e7bb0 Merge pull request #10744 from overleaf/revert-10726-ds-bug-fix-history-segmented-control 
Revert "Bug fix- Fixed the 2 way segmented control on history panel."

GitOrigin-RevId: 58a2d9ebb1023f76ed87249722b749cc5062b2b9
 2022-12-01 09:05:51 +00:00
Jessica Lawshe
8537a37020 Merge pull request #10726 from overleaf/ds-bug-fix-history-segmented-control 
Bug fix- Fixed the 2 way segmented control on history panel.

GitOrigin-RevId: 6d514ed2f1fd9b8342e918089d3966c1a1a388ba
 2022-12-01 09:05:36 +00:00
Jessica Lawshe
975b0200c3 Merge pull request #10550 from overleaf/jel-cms-btn-color-blocks 
[web] Buttons in CMS color blocks for new CSS

GitOrigin-RevId: 162223c2bde95922c8619eb45b9c5e32d0c4084d
 2022-12-01 09:05:30 +00:00
Jessica Lawshe
542dce8de0 Merge pull request #10573 from overleaf/jel-cms-vertically-center 
[web] Vertically center columns on CMS pages when selected

GitOrigin-RevId: f4b5abd0f8549329bf5d0a6f0f90900b42674763
 2022-12-01 09:05:16 +00:00
Davinder Singh
a5f19e6903 Merge pull request #10633 from overleaf/ds-login-page-css-new-builds 
Add new CSS styling back to `login` and `Home` page

GitOrigin-RevId: da4d9bfd91373de52495e0624ada2a735dca23e4
 2022-12-01 09:04:42 +00:00
Davinder Singh
9bda93fca0 Merge pull request #10616 from overleaf/ds-arrow-cms-btn 
Adding arrow to the CMS buttons

GitOrigin-RevId: 9afc0117b29257f2ede7b973f0aff4e21089f572
 2022-12-01 09:04:28 +00:00
Jessica Lawshe
0bb883a2c5 Merge pull request #10694 from overleaf/jel-link-color 
[web] Remove not pseudo-class

GitOrigin-RevId: 6cb1abc45c01f408808672a47782d0769f442a20
 2022-11-29 09:05:07 +00:00
Eric Mc Sween
d21fd77d54 Merge pull request #10691 from overleaf/jel-cms-style 
[web] Limit to CMS pages

GitOrigin-RevId: e5f3f3cb72264b3ef6f01dbfe8071d8c970dd631
 2022-11-29 09:04:54 +00:00
Davinder Singh
b84824776a Merge pull request #10658 from overleaf/mf-fix-plans-v2-button-hover-color 
Fix specific button color being overridden by default styling

GitOrigin-RevId: 103ae4b99adb5706089b9fd85b73a603be974450
 2022-11-28 09:04:11 +00:00
M Fahru
6dcc22642a Update "go to line" hotkey for cm6 and add new info text in hotkeys modal 
* Update "go to line" hotkey for cm6 and add new info text in hotkeys modal

* Differentiate modal title between cm6 and ace hotkeys

* Update test to reflect change in hotkeys modal title

* Add test for hotkeys modal bottom text

* Update test on editor left menu hotkeys button to reflect change in hotkeys modal title

GitOrigin-RevId: 61bae16313ea7a37fa3b9441dbe5a93ab7823d01
 2022-11-25 09:04:20 +00:00
Jessica Lawshe
22c9eff086 Merge pull request #10552 from overleaf/jel-cms-icon-with-content 
[web] Add "Element | Icon with Content"

GitOrigin-RevId: 5fd2cc16b44612b70e3817c5ad21798ba58422d2
 2022-11-21 09:04:15 +00:00
Jessica Lawshe
854c39d3f5 Merge pull request #10526 from overleaf/jel-btn-recompile 
[web] `btn-recompile` and `log-btn` for new CSS

GitOrigin-RevId: b92724267a87f5dce8ed0e60e926c1939f64c4f9
 2022-11-18 09:05:44 +00:00
Jessica Lawshe
0fe7e74343 Merge pull request #10520 from overleaf/jel-ds-cms-quote 
[web] Add new quote layout option from CMS

GitOrigin-RevId: 63d72f7adf72da231093ab82876173082cd5851c
 2022-11-18 09:05:09 +00:00
Jessica Lawshe
dc9b901508 Merge pull request #10497 from overleaf/jel-cms-new-style 
[web] Add new CMS page style

GitOrigin-RevId: 320e02dc2ccfd211396548d7b813bd4c675e6f84
 2022-11-18 09:05:02 +00:00
M Fahru
d70e0b1c0e Implement grammarly warning alert on cm6 users 
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
 2022-11-16 09:06:39 +00:00
Davinder Singh
f8fc0f5c73 Merge pull request #10484 from overleaf/ds-homepage-css-bug-fix 
fixed the css bug on home page, removed the variable

GitOrigin-RevId: 5a2ca4aa75d15205d56e83d598535128643e6b39
 2022-11-16 09:05:09 +00:00
Davinder Singh
c6f8b17647 Merge pull request #10286 from overleaf/jel-ds-toggle 
Fix toggle and  `Switch to PDF` aligment

GitOrigin-RevId: d3c77ff34829af875d2b8b9e3797e0e7db867631
 2022-11-16 09:04:26 +00:00
Davinder Singh
966a151686 Merge pull request #10270 from overleaf/ds-toolbar-logo-background-color 
Removed the background colour for branded logo in light theme

GitOrigin-RevId: 935fba12d306e55bb994ca1b7a376f11cb0bd5c1
 2022-11-16 09:04:18 +00:00
M Fahru
5eff354971 Create settings menu react elements in editor left menu for editor left menu react migration 
GitOrigin-RevId: e75581a43a8694398b20bee3dc5ec69b60db86ab
 2022-11-15 09:07:01 +00:00
Jessica Lawshe
62cf8c9d61 Merge pull request #10262 from overleaf/jel-ds-btn-secondary 
[web] Buttons for new CSS build

GitOrigin-RevId: 9ae4284ba89296b77c37d61ba9b221bcab2f6458
 2022-11-15 09:06:25 +00:00
Brian Gough
782294abae Merge pull request #10212 from overleaf/ii-dashboard-shorten-text-in-dropdowns 
[web] Project dashboard add ellipsis to long text in the project filter dropdown on mobile

GitOrigin-RevId: 4b0d4e097ff0f26820c158086d8b089cbf1e364f
 2022-11-07 09:03:38 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201) 
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
 2022-11-04 09:05:50 +00:00
Jessica Lawshe
c021b48824 Merge pull request #10073 from overleaf/jel-cleanup-imports 
[web] Design system updates

GitOrigin-RevId: d5a9d8736083b076474e2a43f0200a6419f24a92
 2022-11-02 09:04:29 +00:00
Tim Down
cd60d6719a Merge pull request #10067 from overleaf/ds-design-segmented-control 
Changed the css for segmented toggle switch animation

GitOrigin-RevId: e3c0dc496be9fedea5d9463f57b9844991f0c0eb
 2022-11-02 09:04:14 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component 
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
 2022-11-02 09:04:07 +00:00
M Fahru
b85ae6e58e Migrate actions menu in editor left menu to react (#10102) 
* Migrate actions menu in editor left menu to react

* Move margin from inline style to css file

* remove focus selector to avoid "highlighting" the button after closing modal and regain focus

* Add disabled state on word count button when the compiling is loading or failed

* Use div instead of button for disabled word count button

* Add accessibility text props when LeftMenuButton is disabled

* Add actions menu test cases and storybook components

* use util assign function and wrap function prop in usecallback

GitOrigin-RevId: 81ab104be21fbcf5dfbc72c07d29eeb32976c61f
 2022-10-28 08:05:14 +00:00
M Fahru
d98e32f38a Remove unused class selector. 
This is an artefact and should have been removed when we removed the rich text survey component.

GitOrigin-RevId: cdda625b02328b8c300a91178733321ecfcd7290
 2022-10-28 08:05:07 +00:00
Jessica Lawshe
58ba814cd1 Merge pull request #10114 from overleaf/jel-dash-survey-container 
[web] Fix desktop dash survey container click behavior

GitOrigin-RevId: 9e94ee572e348fca1f950698dd5a7449195a52da
 2022-10-25 08:04:12 +00:00
ilkin-overleaf
f8e98cd5c6 Merge pull request #10030 from overleaf/ii-dashboard-survey-react-mobile-view 
[web] Project dashboard survey mobile view

GitOrigin-RevId: 19612f75a9987625f10626f5f9ea9b53321d5fe2
 2022-10-24 08:02:59 +00:00
Jessica Lawshe
9d31ea62b3 Merge pull request #9992 from overleaf/jel-react-dash-sidebar-buttons 
[web] React dash - wrap text in sidebar buttons

GitOrigin-RevId: 68c037c93049468fd48104a151188fc20a643910
 2022-10-18 08:03:39 +00:00
Jessica Lawshe
8323cb37e8 Merge pull request #9955 from overleaf/jel-actions-list 
[web] Maintain project list in actions modal while processing and show processed

GitOrigin-RevId: c671b97646918e185d7989f539b44562a87873ee
 2022-10-18 08:03:34 +00:00
Timothée Alby
4af5ed24ad Merge pull request #9866 from overleaf/ta-pdf-detach-safari-no-warnings 
Remove PDF Detach Safari Warning

GitOrigin-RevId: 80f17660d81dc3812fab74c5e2ea4ff23cd7f1d0
 2022-10-18 08:03:20 +00:00
Timothée Alby
48310f3715 Merge pull request #9990 from overleaf/jel-react-dash-dropdown 
[web] React dash - Fix project dropdown overflow

GitOrigin-RevId: 30fc7cd270d393856c0f082f4638588260fefc13
 2022-10-18 08:03:14 +00:00