Commit graph

20255 commits

Author SHA1 Message Date
Jimmy Domagala-Tang
86e2abc90b Merge pull request #19106 from overleaf/jdt-center-labels
vertically align text within spans

GitOrigin-RevId: 820313b179751a1a7c538712cf9dfd6b9ce0ff3d
2024-06-26 08:04:52 +00:00
Jimmy Domagala-Tang
b0344ec550 Merge pull request #19132 from overleaf/jdt-ai-policy-migration
feat: add migration for adding new policy to all existing groupPolicies
GitOrigin-RevId: ea3188b6059c2e96afd0058a191d18b26d68adbd
2024-06-26 08:04:48 +00:00
roo hutton
e0c879bd9a Merge pull request #19120 from overleaf/rh-link-share-styles
[web] Fix share modal styling regressions

GitOrigin-RevId: efeffa3d6451ed47137106e0ad296c518a5c0608
2024-06-26 08:04:43 +00:00
roo hutton
bf90932f40 Merge pull request #18936 from overleaf/rh-viewer-no-comment
[web] Remove access to commenting/chat for collaborators with Viewer permission

GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
2024-06-26 08:04:38 +00:00
Jakob Ackermann
ce9b531892 Merge pull request #19098 from overleaf/jpa-graceful-shutdown-tests
[server-ce] add test for graceful shutdown

GitOrigin-RevId: 5e72e0073169009d2e3ece5a79cbd62051f6ad5b
2024-06-25 11:12:43 +00:00
Tim Down
956aad7e43 Merge pull request #18764 from overleaf/td-bs5-dashboard-feature-flag
Create new feature flag for BS5 project dashboard page

GitOrigin-RevId: a523bd7df94c411805ac2f5234135bc7a56d25bb
2024-06-25 11:12:35 +00:00
Tim Down
8897e439ae Merge pull request #18928 from overleaf/td-bs5-nav-admin-missing-href
Bootstrap 5: add missing href to nav admin link

GitOrigin-RevId: 5339fa2ef465a6319d87cba6201e682dea1a98a6
2024-06-25 11:12:31 +00:00
David
62c432b997 Merge pull request #19101 from overleaf/dp-presentation-additional-keys
Add PageUp/PageDown/Backspace options for presentation page navigation

GitOrigin-RevId: 59b8c3b22ff205c8fe1009c120358c913db3cbe5
2024-06-25 11:12:27 +00:00
David
b2e3002992 Merge pull request #19103 from overleaf/dp-presentation-events
Add event for entering presentation mode

GitOrigin-RevId: 6d9006005264f69d1a37baa363b338caf0d29c6c
2024-06-25 11:12:23 +00:00
Mathias Jakobsen
ddfdafd54c Merge pull request #19050 from overleaf/mj-lezer-parse-comments-in-unknown-commands
[lezer] Introduce hasMoreArguments token for argument parsing

GitOrigin-RevId: a5898a2be01c19a39de15c784f184fe61140799a
2024-06-25 11:12:18 +00:00
Mathias Jakobsen
46a160f127 Merge pull request #19072 from overleaf/mj-known-commands-reuse
[web] Parse known commands in math mode

GitOrigin-RevId: e7937fc46320f13c716d1612eca36aa67c8fb967
2024-06-25 11:12:14 +00:00
Mathias Jakobsen
283c972842 Merge pull request #19032 from overleaf/mj-lezer-mathdelim
[lezer] Remove custom tokeniser for MathDelimiter

GitOrigin-RevId: acbbbe439d51a8a9d5b30b91c55c8f8ef8c3b9fb
2024-06-25 11:12:10 +00:00
Mathias Jakobsen
884eebd82d Merge pull request #19102 from overleaf/mj-more-cite-ref
[lezer] Add more cite and ref command variants

GitOrigin-RevId: e402f92d9948eba857dbe0851f039f4d7313df81
2024-06-25 11:12:06 +00:00
Mathias Jakobsen
e48e4293a6 Merge pull request #19090 from overleaf/mj-web-metadata
[web] Ignore commented content when parsing metadata

GitOrigin-RevId: 78f9b0d6549e60fca4ba8929beb677341d885655
2024-06-25 11:12:02 +00:00
roo hutton
64d9792fe3 Merge pull request #18861 from overleaf/rh-editor-limit-exceeded
[web]: Handle exceeded editor limit in share modal

GitOrigin-RevId: 23a15805ca98327ae4a7fc731bbca3982c90bad5
2024-06-25 08:04:46 +00:00
Jimmy Domagala-Tang
04432478e1 Merge pull request #19053 from overleaf/ab-split-tests-first-time-assignments
[web] Return isFirstTimeAssignment flag with split test assignments

GitOrigin-RevId: 70954470fbd9430749d83d8d1e08a3969d4a09e6
2024-06-25 08:04:37 +00:00
Alf Eaton
6db455d63e Show modal for error renaming project (#19040)
GitOrigin-RevId: 229e64775897d646ed8c13f12d3bcc9400f2a3b9
2024-06-24 12:05:59 +00:00
Alf Eaton
bee698c01d Updates to the AI error assistant (#19065)
* Only show the AI error assistant to users with write permission on the project
* Fix line number in searchDocLines
* Abort the request after 60 seconds
* Move comment
* Jump to file + line when suggestion line number is clicked
* Set tool_choice: 'required'
* Fix handling of suggestLineChange
* Tidy up getDocLines
* Avoid showing Suggest Fix button in gutter marker for typesetting warnings
* Log request errors
* Fix prefixed function name
* Update tool description
* Tweak the prompt in an attempt to improve the line number
* Reject if the total message content is too large
* Change the structure of the suggested change
* Reduce line highlight
* Fix change highlighting on deletion

GitOrigin-RevId: afde096e547050b8518195ef51b68983bc3b0be3
2024-06-24 12:05:51 +00:00
Miguel Serrano
1697087425 Merge pull request #18970 from overleaf/msm-clean-features-templates
[web] Cleanup `features.templates`

GitOrigin-RevId: 7c9f7bc827700e4255a5ba8a46de70318afdaae4
2024-06-24 12:05:43 +00:00
David
8d2b006d60 Merge pull request #19070 from overleaf/dp-remove-useWaitForGrammarlyCheck
Remove grammarly check in writefull  promo

GitOrigin-RevId: 30994c1960232afe3bede1fd6649606e191dd3d4
2024-06-24 12:05:35 +00:00
Davinder Singh
c70e676cbc Merge pull request #19035 from overleaf/plans-list-mobile
[web] Begin configured features list for new plans page mobile view

GitOrigin-RevId: ba09f1a2e24f3a2eec4b20e55a0afada9e359264
2024-06-24 12:05:30 +00:00
Mathias Jakobsen
23a7e19e8e Merge pull request #18991 from overleaf/mj-table-generator-promotion-teardown
[web] Tear down table generator promotion

GitOrigin-RevId: 361215bdd792042ae68762fa20ae60286db5bab3
2024-06-24 12:05:18 +00:00
Mathias Jakobsen
bc9bb05c8f Merge pull request #19033 from overleaf/mj-lezer-unused-rule
[lezer] Remove unused rule

GitOrigin-RevId: 53402a3004d0ca781b29f16eaf4e7eae086450d3
2024-06-24 12:05:14 +00:00
Mathias Jakobsen
40bddf72dc Merge pull request #18937 from overleaf/mj-lezer-upgrade
[web] Update lezer packages

GitOrigin-RevId: 349b18e7f03c12aae736c6a8c4d3234c828b14ca
2024-06-24 12:05:09 +00:00
CloudBuild
a0d2d30b48 auto update translation
GitOrigin-RevId: 3c003f3e221c7186d5a944791caae8027d65cd05
2024-06-24 12:05:00 +00:00
Jimmy Domagala-Tang
790f90e97d Merge pull request #19036 from overleaf/jdt-labs-alpha-only
feat: only allow alpha users on labs page currently
GitOrigin-RevId: 5136d77789fa27a0bd9fe6f17c8937998bc74259
2024-06-24 12:04:51 +00:00
Mathias Jakobsen
94694a6385 Merge pull request #19057 from overleaf/mj-benchmark-seed-random
[web] Add quick and dirty PRNG for seeding benchmark runs

GitOrigin-RevId: 079f9b565f17b44d7062f6b93c26f694e486c6b9
2024-06-24 12:04:46 +00:00
David
a8cb423078 Merge pull request #19030 from overleaf/dp-presentation-mode-flag
Add separate feature flag for presentation mode

GitOrigin-RevId: a996fa313c101dd822ad83109ba77fa95f99f644
2024-06-24 12:04:34 +00:00
Antoine Clausse
3d5418611b Add an ESLint rule enforcing kebab-case in URL paths (#18913)
* Add a tsconfig.json to the eslint-plugin folder so it can be linted too

* Create eslint rule `prefer-kebab-url`

* Add prefer-kebab-url to service/web

* Ignore lowercased strings

Prevents from trying to change `v0` to `v-0`

* Ignore parts between brackets or parenthesis

* Record in URL paths by case

lower: 241
kebab: 60
snake: 43
camel: 22
other: 5

* Revert "Record in URL paths by case"

This reverts commit 262f483aafb0daa1a01e9025488cdc33f31ef67c.

* Showcase how the autofix would change the code

* Revert "Showcase how the autofix would change the code"

This reverts commit f045292bf01623de2df5b89fc0d68737a39913dc.

* Add ignored words so we don't have to update old code

* Change the rule so it suggests instead of fixing

This prevents eslint autofix from creating bugs

* Move list of ignored words to its own file

Per https://github.com/overleaf/internal/pull/18913#discussion_r1644204034

* Add comment explaining the ignore list

GitOrigin-RevId: d13918b0bcba9d77120f1b61b354a79dc8fb4b4e
2024-06-24 12:04:26 +00:00
Antoine Clausse
2c7df10b9a [web] Refactor ProjectController.loadEditor p-props promises (#18823)
* Move unawaited promises out of `p-props`: `User.updateOne`

* Move unawaited promises out of `p-props`: `sessionMaintenance`

* Move unawaited promises out of `p-props`: `reactivateProjectIfRequired`

* Move unawaited promises out of `p-props`: `markAsOpened`

* Move unawaited promises out of `p-props`: `flushProjectToTpdsIfNeeded`

This was actually awaited, but is it necessary?

* Use `getUserValues`: `user`

* Use `getUserValues`: `learnedWords`

* Use `getUserValues`: `projectTags`

* Use `getUserValues`: `userHasInstitutionLicence`

* Use `getUserValues`: `subscription`

* Use `getUserValues`: `isTokenMember`

* Use `getUserValues`: `isInvitedMember`

* Update `splitTestAssignments` syntax

* Remove `mapValues` in `pProps`

* Await unused promises again: `flushProjectToTpdsIfNeeded` and `reactivateProjectIfRequired`

* Remove error page file committed by mistake 🤦

GitOrigin-RevId: 6529445c364a6af660bc8ab6dfc836a4ddf7a040
2024-06-24 12:04:18 +00:00
Jimmy Domagala-Tang
271700893a Merge pull request #18784 from overleaf/bg-allow-combined-group-policies
allow combined group policies

GitOrigin-RevId: b23fb0454f794e9094e8e15e732b4322a48ac1ee
2024-06-24 12:04:13 +00:00
Jimmy Domagala-Tang
e5aa917f54 Merge pull request #18682 from overleaf/jdt-ai-labs
Re-Release Labs Page for AI Error-Correction

GitOrigin-RevId: 2eef85dd3b5f86bedcf3339559a5fbbae2d4da87
2024-06-24 12:04:08 +00:00
Jakob Ackermann
ac7916fb29 Merge pull request #19023 from overleaf/jpa-issue-19016
[web] lock down legacy endpoint for creating projects from zip

GitOrigin-RevId: 0c6b29d34c601d316b184d50d93e8e17f59bfcfb
2024-06-24 12:04:00 +00:00
Mathias Jakobsen
922822d487 Merge pull request #18997 from overleaf/mj-fix-uncategorized-title
[web] Correct title when viewing uncategorized projects

GitOrigin-RevId: 6f284c437563f10125974eac7f6da6c92526e436
2024-06-24 12:03:51 +00:00
Mathias Jakobsen
69205629bf Merge pull request #19024 from overleaf/mj-mobile-rename-modal
[web] Update project name in rename modal when project name changes

GitOrigin-RevId: 080d97b4d279fe54cc9530cea3efb1212da3041c
2024-06-24 12:03:47 +00:00
M Fahru
381795c5a2 Create an organizations icon section on the new plans page
GitOrigin-RevId: 9c58fa1dadb66a8ab91102484bc6b937e568c40b
2024-06-24 12:03:42 +00:00
M Fahru
b197aee92e Merge pull request #18879 from overleaf/ds-plans-page-new-design-mobile-plans-2
Website redesign - Plans page new-design mobile screen plans card (2)

GitOrigin-RevId: d74f4d0769ae7a248226d2369a5419e26946e26d
2024-06-24 12:03:37 +00:00
Jessica Lawshe
900f11dae2 Merge pull request #18949 from overleaf/jel-faq-spacing
[web] Add spacing to left of FAQ accordion icon

GitOrigin-RevId: 71004270bbc9725b63c92dfb685b759057049265
2024-06-24 12:03:33 +00:00
Jessica Lawshe
2547294353 Merge pull request #18909 from overleaf/mf-new-plans-page-table-highlighted-column
[web] Implement highlighted column based on hardcoded column id on new plans page table

GitOrigin-RevId: 241913c81670ea158f436c29060bd9e1836ed4fc
2024-06-24 12:03:24 +00:00
Mathias Jakobsen
46d687855e Merge pull request #18981 from overleaf/mj-mobile-dropdown
[web] Add rename button to project list mobile view

GitOrigin-RevId: 4ca3c68dcaf4e0d5e97f501084b9f850f9a4e867
2024-06-24 12:03:20 +00:00
ilkin-overleaf
7b47acc486 Merge pull request #18763 from overleaf/ii-bs5-projects-notifications
[web] BS5 notifications in projects and welcome pages

GitOrigin-RevId: 25780bb64660ef41c41c007f94f70df273cac716
2024-06-24 12:03:15 +00:00
ilkin-overleaf
34311ce0dc Merge pull request #18789 from overleaf/ii-invite-token-lookup-by-hmac-token
[web] Lookup project invitations by HMAC token

GitOrigin-RevId: b631445e18f83ddb5e7708388a57a0fac0f73bd2
2024-06-24 12:03:10 +00:00
David
2a6b84596e Merge pull request #19006 from overleaf/dp-pdf-click
Add click listener to pdf presentation mode to go to next page

GitOrigin-RevId: add7ddb18ef63774bbb78f6337088bd59b087db1
2024-06-24 12:03:06 +00:00
Jakob Ackermann
bd9f3cb07a Merge pull request #19017 from overleaf/jpa-server-pro-footer
[web] fix spacing for thin-footer as used in Server Pro/CE

GitOrigin-RevId: 8a20d93f10c5bce156647f67de991ff41a8a2017
2024-06-24 12:03:01 +00:00
Alf Eaton
b66d45784a Merge pull request #19007 from overleaf/ai-error-assistant-updates
Updates to the AI error assistant

GitOrigin-RevId: 6ca708b97a7eda81618abf3006b4bcc8d46f3dd4
2024-06-24 12:02:56 +00:00
Alf Eaton
3453f4cb94 Remove trailing slash from log hint (#18998)
GitOrigin-RevId: d95ffde59c5a7c58aed14a542b8dad3085405c2d
2024-06-24 12:02:52 +00:00
CloudBuild
c90d01afa2 auto update translation
GitOrigin-RevId: 42dc0835bfeea53ebb45bb58f8ccd6392861ca9c
2024-06-20 08:05:36 +00:00
ilkin-overleaf
ea6f627490 Merge pull request #18912 from overleaf/ii-remove-deleted-users-from-token-access-refs-script-fix
[web] Improve the removal of deleted users from token access refs

GitOrigin-RevId: 7b79e327388e37603a6c4f227f1d4bba743d4730
2024-06-20 08:05:22 +00:00
Eric Mc Sween
8d35177b52 Merge pull request #18985 from overleaf/em-migrate-bulk
Bulk history ranges migration

GitOrigin-RevId: 0d1846b412cfcddead63a7bc15bd06a82fbb47f3
2024-06-20 08:05:05 +00:00
David
8c3c9fe53f Merge pull request #18979 from overleaf/dp-pdf-split-test-badge
Add SplitTestBadge to pdf controls toolbar

GitOrigin-RevId: ebbd2f8983aa2168fe03beb8ce69d7da91871a74
2024-06-20 08:05:01 +00:00
David
a4f398b852 Merge pull request #18975 from overleaf/dp-rename-present-presentation-mode
Rename present button to "Presentation mode"

GitOrigin-RevId: 15bfe5b2f360929b2cc507f0f15342ffdbefe73b
2024-06-20 08:04:57 +00:00
Brian Gough
be23b7e73b Merge pull request #18744 from overleaf/jpa-ce-no-events
[web] avoid sending events in Server Pro/CE

GitOrigin-RevId: 04d2fa7939c448bc00757c5015e22a46b6b07bb5
2024-06-20 08:04:41 +00:00
Brian Gough
d43292cfe6 Merge pull request #18146 from overleaf/ab-one-time-assignments
[web] Handle one-time assignments for split tests

GitOrigin-RevId: 2d7ec2a878055fdc96475db2129aad308abb2fff
2024-06-20 08:04:34 +00:00
Miguel Serrano
f181dfe74f Merge pull request #18549 from overleaf/msm-system-messages-redirect
[web] return redirect on admin actions

GitOrigin-RevId: d6273c01d90230c786cc9d0808f866524e57bc19
2024-06-20 08:04:20 +00:00
Alf Eaton
5e77052b3b Use DOMPurify for AI error assistant output (#18944)
GitOrigin-RevId: 06c5b7720668d77b5750f90daa568bd38d22e150
2024-06-20 08:04:16 +00:00
Alf Eaton
231f7778c3 Update AI error assistant (#18968)
* Update styles to match designs
* Use Notification for errors and update error message
* Add feedback stories and update styles
* Update prompt
* Accept terms after suggest fix started
* Add translations for AI error assistant
* Add tooltips for feedback buttons
* Allow empty file extension
* Handle rate limit response

GitOrigin-RevId: e75c949f3a1b39594e94e300df717de414fdf70c
2024-06-20 08:04:11 +00:00
CloudBuild
6adade191f auto update translation
GitOrigin-RevId: 1d8ec2514af0da765314e63720f22b23cdd6ccd1
2024-06-19 08:05:18 +00:00
M Fahru
34781dce81 Merge pull request #18963 from overleaf/mf-new-plans-page-very-small-screen-fix-tab
[web] Fix new plans page tabs overflow on mobile view

GitOrigin-RevId: f40efa386b15c921a17c7c046866c7f54aee083e
2024-06-19 08:05:10 +00:00
M Fahru
5e560e4376 Merge pull request #18908 from overleaf/mf-fix-spacing-page-new-plans-page
[web] Change new plans page vertical main heading spacing value to 96px

GitOrigin-RevId: c9746446a15bd0dd2e64a76615cd979654c8609e
2024-06-19 08:05:06 +00:00
Eric Mc Sween
e73fdfba63 Merge pull request #18906 from overleaf/em-migrate-existing-histories-2
History ranges migration script - second attempt

GitOrigin-RevId: 60a2c04e2a72e76a58e9e179fefc4186a96fde32
2024-06-19 08:05:02 +00:00
Eric Mc Sween
9f0f42a012 Merge pull request #18930 from overleaf/em-resync-ranges
Fix resyncs when diffs move ranges

GitOrigin-RevId: 121c3a16cf19649538445e6ed8bc0a1129735eb9
2024-06-19 08:04:57 +00:00
David
c342dc70a5 Merge pull request #18927 from overleaf/dp-remove-grammarly-promo
Remove Grammarly advert

GitOrigin-RevId: 6652cfafc47f8a42efc9acc1745a50e4ab8cc208
2024-06-19 08:04:46 +00:00
David
0b4d9aebe4 Merge pull request #18925 from overleaf/dp-pdf-scroll-bars
Remove scroll bar on pdf presentation mode

GitOrigin-RevId: 3d67586859e15a0e3ca77183c9f39bb4ccb38527
2024-06-19 08:04:38 +00:00
David
c16c806002 Merge pull request #18697 from overleaf/dp-ai-rate-limit
Add a rate limiter for the AI Error Assistant

GitOrigin-RevId: d23abc4b3477d13b1bfd4d69db168458ac8c2e51
2024-06-19 08:04:34 +00:00
David
7722c44414 Merge pull request #18918 from overleaf/dp-swap-search-arrows
Swap order of next/previous arrows in editor search

GitOrigin-RevId: 2c402e177fcd679ebff8e96812faf09d493e9726
2024-06-19 08:04:26 +00:00
Jakob Ackermann
aa480a2663 Merge pull request #18898 from overleaf/jpa-no-window
[web] migrate from window attributes to getMeta

GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
2024-06-19 08:04:21 +00:00
Mathias Jakobsen
9b1c703f6b Merge pull request #18901 from overleaf/mj-math-mode-args
[lezer] Parse command arguments in math mode

GitOrigin-RevId: 85a35f412de4c7238d735253c2642066ebffb393
2024-06-19 08:04:16 +00:00
Mathias Jakobsen
d2ae97427d Merge pull request #18782 from overleaf/mj-symbol-palette-inline
[web] Move symbol palette icon inline

GitOrigin-RevId: 8d05cbf5211009870b8107c3c620af0e701a04dd
2024-06-19 08:04:12 +00:00
Jakob Ackermann
4087345a2a Merge pull request #18941 from overleaf/jpa-fix-some-ts-ignore
[web] fix a few ts-ignore statements

GitOrigin-RevId: 447a070a8268cffa6ef298b0fe158232c3f6fe8f
2024-06-19 08:04:07 +00:00
Antoine Clausse
aa7839876a [web] Promisify MetricsEmailController and InstitutionHubsController (attempt 2) (#18805)
* Reapply "[web] Promisify MetricsEmailController and InstitutionHubsController …"

This reverts commit ea14df1395f1dc2fa7d41fc7837849f9686425b5.

* Fix changes to node-fetch: `statusCode` -> `status` (!!)

* Update test

* Handle no-content without throwing (!)

Avoid error `Unexpected end of JSON input` when doing `response.json()` on an empty response when status is 204

Related: https://github.com/node-fetch/node-fetch/issues/165

* Also return `204` when no data in departments_data and roles_data

* Revert "Handle no-content without throwing (!)", and return null instead

This reverts commits 3baa779f7a9e64804e54a276faf865ab9252f336 and 51507a3d763d7006c8b01414a7c79bd3f3b6948b.

* Update tests: `assert_nil`

* Fixup: Update tests: assert null

* Use `fetchJSON` in Institution.fetchV1Data

* Proxy errors from server without throwing 500

GitOrigin-RevId: 9c13e293f3fed3abd2accddd1a9060ed02b96ba2
2024-06-19 08:04:02 +00:00
M Fahru
e549e44ca7 Merge pull request #18889 from overleaf/mf-plans-new-tab-active-green
[web] Change text and icon color to green when new plans page tab is active

GitOrigin-RevId: 745b15538aa89afdb35a642f6927ecce0f1b40ee
2024-06-18 08:05:25 +00:00
M Fahru
bdf8927cdf Fix new plans page table header does not occupy full height for all of its children on Chrome
GitOrigin-RevId: a69c20057ff1563e6f6e93c87e4ac3a0c010885d
2024-06-18 08:05:21 +00:00
M Fahru
9309df9a13 Merge pull request #18870 from overleaf/mf-new-plans-page-table-individual
[web] Create new plans page table for individual plans

GitOrigin-RevId: 82bfcf5a5e7886517bab9b67dfb4a712350f8c33
2024-06-18 08:05:16 +00:00
Jessica Lawshe
c117a64ebb Merge pull request #18902 from overleaf/ar-web-script-for-salesforce-data
[web] Add script for loading v2 salesforce data

GitOrigin-RevId: 15d3c30be166d011702d1a2d4a1d960cd4b2fa8c
2024-06-18 08:05:11 +00:00
Jessica Lawshe
a343ec1578 Merge pull request #18932 from overleaf/jel-rename-css-light-touch
[web] Rename CSS classes for light touch redesign

GitOrigin-RevId: 2e415dcffd04f8783f5b7145827031fdbfc83baf
2024-06-18 08:05:07 +00:00
Jessica Lawshe
1db5593c5a Merge pull request #18931 from overleaf/jel-new-files-for-light-touch
[web] New files for plans light touch redesign

GitOrigin-RevId: beb517543c8341bbd8124fab87b532f62c5a0c11
2024-06-18 08:05:02 +00:00
Jessica Lawshe
a7adfc12da Merge pull request #18907 from overleaf/jel-faq-css
[web] CSS updates to new plans FAQ

GitOrigin-RevId: b00d8b22f62d9a3774eb673501c0b2074dd15d81
2024-06-18 08:04:57 +00:00
Jessica Lawshe
092e49d6ec Merge pull request #18905 from overleaf/jel-plans-faq
[web] Add new plans FAQ to light touch redesign variant

GitOrigin-RevId: a4140a09c94e0374792acb789b4f36ad104841f2
2024-06-18 08:04:53 +00:00
Jessica Lawshe
6e084f389a Merge pull request #18885 from overleaf/jel-plans-page-quotes
[web] Handle hiding/showing quote rows on new plans page variants

GitOrigin-RevId: dd88cce9acdc2ca07d5df1afa7278028820e673d
2024-06-18 08:04:48 +00:00
Domagoj Kriskovic
4aa746a759 [web] show file restored change in history (#18792)
* add RestoreFileOrigin in overleaf-editor-core

* support source to be an object

* use sourceOrOrigin as param

* rename to originOrSource so the priority is more clear

* get timestamp from version

* fix test

* include version and min_count in getUpdatesFromHistory

* extractOriginOrSource util function

* fix RestoreManagerTests

* [web] show restore file change in history

* make sure two restore operations are not merged

* dont summarize updates for different paths

GitOrigin-RevId: d890484760a7379716e8bd65dd28e353d293492f
2024-06-18 08:04:43 +00:00
Alexandre Bourdin
f265797bb1 Sets lastUpdatedBy to null when it is empty on github sync update (#18788)
GitOrigin-RevId: bce67f7d3dbc59facc626cc63af94df46afd8f24
2024-06-18 08:04:39 +00:00
Domagoj Kriskovic
7e8e2b0585 Send origin metadata through docupdater and project-history when restoring files (#18721)
* add RestoreFileOrigin in overleaf-editor-core

* support source to be an object

* use sourceOrOrigin as param

* rename to originOrSource so the priority is more clear

* get timestamp from version

* fix test

* include version and min_count in getUpdatesFromHistory

* extractOriginOrSource util function

* fix RestoreManagerTests

GitOrigin-RevId: 0ace05a6ade2794c753a9d0bffb4f858ecc6899a
2024-06-18 08:04:34 +00:00
Alf Eaton
5a5defee69 Merge pull request #18943 from overleaf/ae-jquery-revert
Revert "Upgrade jQuery to v3 (#18796)"

GitOrigin-RevId: fa7815b7bfe28239c86900b62bdcd3c4dac3a65f
2024-06-18 08:04:29 +00:00
Alf Eaton
9cb313d687 Merge pull request #18847 from overleaf/ls-remove-crypto-js
remove npm package crypto-js

GitOrigin-RevId: c6f3bc2275a4757e6fb17e82f98ee5f8ca119e15
2024-06-18 08:04:19 +00:00
Alf Eaton
46f878c42f Upgrade jQuery to v3 (#18796)
GitOrigin-RevId: c5d1e280784480911de8ec11af618f5eadc6a846
2024-06-18 08:04:14 +00:00
Alf Eaton
b9a8a7f7ec Move AI provider usage to the backend (#18562)
GitOrigin-RevId: 4f66c6576571c4fbb7381d8d0e34f2e468d6f34f
2024-06-18 08:04:09 +00:00
Jakob Ackermann
e36de5a62d Merge pull request #18856 from overleaf/jpa-server-ce-shutdown
[server-ce] improve shutdown procedure

GitOrigin-RevId: 5a99868d17f597c366e42625cd39f05146dcb682
2024-06-18 08:04:04 +00:00
CloudBuild
6980a44f8b auto update translation
GitOrigin-RevId: bae1485e0792582f6a3bee3a791c193c8c7a5bee
2024-06-17 08:04:34 +00:00
David
dcb7944b05 Merge pull request #18895 from overleaf/dp-presentation-mode
Add pdf presentation mode

GitOrigin-RevId: e6ac1ae339e9690a733a110c6f0a33149e869dd6
2024-06-17 08:04:30 +00:00
Rebeka Dekany
805ec8c2e0 Merge pull request #18808 from overleaf/rd-ejs-upgrade
Upgrading ejs package version from 3.1.8 to 3.1.10

GitOrigin-RevId: 2e2ad7c3d74a2c6e929a030ddbc8735235346804
2024-06-17 08:04:26 +00:00
Miguel Serrano
da5846209f Merge pull request #18402 from overleaf/msm-git-bridge-pom
* [git-bridge] Extracted pom versions to properties

Managing versions as properties is a best practice
with pom files. An advantage in our case is ensuring
dependency groups (as simpleclient) are upgraded
together.

* [git-bridge] Remove '_' as keyword

* [git-bridge] Added formatting with 'fmt-maven-plugin'

* Remove java from .editorconfig

No longer needed as a formatter is now available

* Replace javadoc comments with multiline comments

Replaces "/**" with "/*", which then prevents the formatter
from adding HTML elements to comments

* [git-bridge] Formatted .java files

GitOrigin-RevId: 0997b838cee88c290d824a74444295e26392f26b
2024-06-17 08:04:21 +00:00
ilkin-overleaf
b34be6bea4 Merge pull request #18653 from overleaf/ii-invite-token-create-hmac
[web] Add HMAC tokens for project invitations

GitOrigin-RevId: 02fa01e24790c9a87f57ff9346f5346658d4dd46
2024-06-17 08:04:17 +00:00
ilkin-overleaf
bb2a3b091d Merge pull request #18911 from overleaf/ii-new-project-modal-fix
[web] Allow creating new project by submitting the form with keyboard

GitOrigin-RevId: e04e70a0713299d6d8459755359d16ea7755c67e
2024-06-17 08:04:13 +00:00
andrew rumble
81b0eb7eb5 Remove obsolete comment
GitOrigin-RevId: 73da65c200d19ed4b389423e3d9f983c90ea1885
2024-06-17 08:04:09 +00:00
andrew rumble
49b7ebe0d0 Remove instances where async is required but not used
GitOrigin-RevId: a202a2d90c4ce61391aabbde1f24437caef54ff0
2024-06-17 08:04:05 +00:00
andrew rumble
ee31d44f03 Explicitly specify latest version of async
GitOrigin-RevId: 9112007de0f5eb4e75604de9f01c2d77b3b8b980
2024-06-17 08:04:00 +00:00
Alf Eaton
e3fcbb4e79 Unpin async dependency
GitOrigin-RevId: 2fd885030ebda5cd4e1e8faad0ba5f57926e38a3
2024-06-17 08:03:51 +00:00
CloudBuild
658be2e7e1 auto update translation
GitOrigin-RevId: dfd486e1ad6b88c5b9d7b22492563b660c0e0b9a
2024-06-14 08:05:30 +00:00
Davinder Singh
df2898a911 Merge pull request #18868 from overleaf/ds-plans-page-new-design-mobile-plans-1
Website redesign - Plans page `new-design` mobile screen plans card (1)

GitOrigin-RevId: 5a3be0f0a5f0a41b934e0c3489883c65450a0076
2024-06-14 08:05:17 +00:00
M Fahru
a0f90bd971 Merge pull request #18860 from overleaf/mf-new-plans-page-student-desktop-header
[web] Create a table header for student plans with static data

GitOrigin-RevId: 29e787509521b6249a97f858b715b482214a9ab0
2024-06-14 08:05:12 +00:00
M Fahru
65592194ec Merge pull request #18862 from overleaf/mf-simplify-non-discounted-text-new-plans-page
[web] Improve the structure of the price elements on the new plans table by using grid display

GitOrigin-RevId: 08052aec5037432af7ad4d4c554e529582d4acfc
2024-06-14 08:05:07 +00:00
M Fahru
d80046c757 Delete unused code: planFeatures.js, this config should have been deleted on the first plans page redesign.
This config is superseded by `plansFeatures.js` that is imported by `plansConfig.js` which is directly used in the pug template.

GitOrigin-RevId: ae0a0e1ff7c8a64022ab378d17943fe4a7ed3b35
2024-06-14 08:05:03 +00:00
Davinder Singh
05c0cbfd6d Merge pull request #18883 from overleaf/jel-eyebrow-text
[web] Add mixin for eyebrow headline

GitOrigin-RevId: 992acd11e6c22c35499329bb53917a2b1ac79ac5
2024-06-14 08:04:55 +00:00
Davinder Singh
9ff03e9245 Merge pull request #18877 from overleaf/jel-sales-ad
[web] Remove 2 sales ad variants and increase probability of FOMO variant

GitOrigin-RevId: 6045dd4255313ae53f255afa528695583171d55b
2024-06-14 08:04:46 +00:00
Davinder Singh
6f39e41461 Website Redesign - Plans page main heading section (#18837)
* adding the main heading of the plans page

* removing some extra CSS and adding a max-width

GitOrigin-RevId: 78e8ab57826171505bb37e89e950dbd44ea1b3d1
2024-06-14 08:04:42 +00:00
Davinder Singh
8018bc7249 Website redesign - Plans page FQA's tabs Section (new-design) (#18696)
* running git reset head

* renaming the local-mixins file to _plans_faq

* removed js to rotate the icon

* format:fix

* adding aria-hidden for curly braces

* removing extra tab space

* removing .card.card-body extra class

* introducing accordions-container so that we can use the last-child property to remove the border of the last questions

* creating new website-redesign-ol-tabs class and adding new styles in this class

* adding content for managingYourSubscription and overleafIndividualPlans sections

* adding content in overleaf group plans section

* removing extra section

* running make cleanup_unused_locales

* cleaning after rebase

* deleting extra variable projectLimits

* fixing spaces around curly brackets and some additional changes after rebase

GitOrigin-RevId: 3c2267080825d853e680a0a207cb640226262be2
2024-06-14 08:04:37 +00:00
ilkin-overleaf
182e9859ec Merge pull request #18690 from overleaf/ii-bs5-projects-welcome
[web] Welcome page migration

GitOrigin-RevId: 2469786372df24d579d1987cf5bb1113450e9d78
2024-06-14 08:04:32 +00:00
CloudBuild
196cf2f190 auto update translation
GitOrigin-RevId: 9c86718bcd0a64cbe44852344a34e80be794e87a
2024-06-13 08:04:57 +00:00
Jessica Lawshe
87bc0b2aa9 Merge pull request #18857 from overleaf/jel-plans-page-css
[web] Add quotes to new plans page variants

GitOrigin-RevId: 794692730a7a6846bf4e43021c34798e9a2605da
2024-06-13 08:04:45 +00:00
Jessica Lawshe
0361299764 Merge pull request #18859 from overleaf/jel-greens
[web] Update greens across website for new site design

GitOrigin-RevId: ff7ca877f1bcdbd9b5e80a87b48f8d375fd8ea5a
2024-06-13 08:04:41 +00:00
Jessica Lawshe
cd9dc12059 Merge pull request #18683 from overleaf/jel-new-styles-quote
[web] New quote style for plans page and CMS pages using `Element | Quote`

GitOrigin-RevId: c4a089727f023d5d28a036c6babbdc773d7fc06a
2024-06-13 08:04:36 +00:00
Mathias Jakobsen
801a17af27 Merge pull request #18838 from overleaf/mj-history-detached-ranges
[project-history] Handle detached ranges

GitOrigin-RevId: cdbe9b46a03d55fd7b865fdd87092aaad1920c62
2024-06-13 08:04:32 +00:00
Brian Gough
49dc94192a Merge pull request #18848 from overleaf/bg-cookie-session-metrics-for-real-time
add cookie session metrics for real-time

GitOrigin-RevId: 6b482dafc19fca46a375ea00a9b2297e20d915ce
2024-06-13 08:04:24 +00:00
Brian Gough
38ac00ba13 Merge pull request #18775 from overleaf/bg-cookie-session-metrics-middleware
add middleware to record session cookie metrics in web

GitOrigin-RevId: f4404455e219d2071d6f0b39e657e9219b7d1c70
2024-06-13 08:04:16 +00:00
Brian Gough
97956856ca Merge pull request #18741 from overleaf/bg-cookie-session-test-rotation-support
test session key rotation in cookie-session module

GitOrigin-RevId: 57486b3df527a9998da3b93981c9d45f510802b8
2024-06-13 08:04:06 +00:00
M Fahru
c8e8c5213c Merge pull request #18845 from overleaf/mf-line-height-rem
[web] Create a new standardized font-size and line-height and use that in new plans page

GitOrigin-RevId: 7c9c92e58e55dd03d0459f5e7314a2832bc769ce
2024-06-12 08:05:54 +00:00
M Fahru
f8e899b026 Merge pull request #18843 from overleaf/mf-new-plans-page-header-padding-fix
[web] New plans page table spacing issues

GitOrigin-RevId: db36694a76acd1a4fa03c64af90ad6fb90c4705f
2024-06-12 08:05:49 +00:00
M Fahru
17ca5b22c5 Merge pull request #18840 from overleaf/mf-new-plans-page-max-height-th
Make new plans table head row (thead > tr) have a dynamic height depending on the maximum value of one of the `th`

GitOrigin-RevId: 1aad2f023a3e83f3037a41b061d63a9351eb1ae8
2024-06-12 08:05:45 +00:00
M Fahru
17110168e2 Merge pull request #18811 from overleaf/mf-new-plans-page-group-desktop-header
[web] Create table header for group table with static data

GitOrigin-RevId: 42a5bda96b3bb4434b6c39c5b35512550ea7157a
2024-06-12 08:05:41 +00:00
M Fahru
2001146a38 Merge pull request #18783 from overleaf/mf-new-plans-page-individual-desktop-header
[web] Create new plans page table header (individual table with static data)

GitOrigin-RevId: fd831d1546eb561ab150007c72bd3c1ca8afd6db
2024-06-12 08:05:36 +00:00
Jakob Ackermann
fcdae173fb Merge pull request #18765 from overleaf/jpa-upgrade-pug
[web] upgrade pug to latest patch version

GitOrigin-RevId: 9ca79904e3ff746423ce6de0e3ef7d58a3558554
2024-06-12 08:05:23 +00:00
M Fahru
d35e11eaef Merge pull request #18720 from overleaf/jel-begin-light-touch-plans
[web] Begin light touch redesign of plans page

GitOrigin-RevId: dda5ab1c0817371400f30f2e4d230f5c3a5728f4
2024-06-12 08:05:19 +00:00
M Fahru
7f6a1e3bf7 Merge pull request #18814 from overleaf/mf-new-plans-table-fading-border-radius-plans-tab
[web] Implement gradient border on new plans page table

GitOrigin-RevId: 6ce3047fcd54c1aa3776029d82f16b81484fd03b
2024-06-12 08:05:14 +00:00
Davinder Singh
9e0bf6c626 Merge pull request #18597 from overleaf/ds-delete-sales-contact-form-pug
Website redesign - Sales contact form clean up (Removing extra files)

GitOrigin-RevId: 0bc443ec705a749b3dfae330ebec8f7a489ede94
2024-06-12 08:04:40 +00:00
Alf Eaton
826d7822e0 Fix tooltip for last updated date in projects list (#18715)
GitOrigin-RevId: 55feb364a108397a672cb7c118805988f3335e69
2024-06-12 08:04:36 +00:00
Alf Eaton
5f60158e99 Add closing bracket to selector (#18723)
GitOrigin-RevId: ca0966efdd7051d703ab3a6a6eaf6f421f6b7cef
2024-06-12 08:04:31 +00:00
Alf Eaton
af78b914df Merge pull request #18729 from overleaf/ae-ng-non-bindable
Remove unused Angular attributes from Pug templates

GitOrigin-RevId: ab3ed4105ea02994924c6dd190dad65fff106c11
2024-06-12 08:04:27 +00:00
Alf Eaton
1cb5d1ddce Remove Angular CVV tooltip template (#18730)
GitOrigin-RevId: 239a180b1704d5cbd9bac8d1c27147caf1c0e4a5
2024-06-12 08:04:22 +00:00
Alf Eaton
7cb0e8c4ea Remove a few remaining references to the ide-page split test (#18735)
GitOrigin-RevId: 4f1c6332f8bf49ed1c3fcee153590d0acf72b26f
2024-06-12 08:04:18 +00:00
Alf Eaton
4971afd527 Improve MathJax filtering of font-family attribute (#18819)
GitOrigin-RevId: 04460c9549c33dbf76efba0e72bed8694072de9d
2024-06-12 08:04:13 +00:00
Jimmy Domagala-Tang
d3c270369d Merge pull request #18593 from overleaf/jdt-mailchimp-tagging
allow adding and removing tags from users in mailchimp

GitOrigin-RevId: 15e491d3346877e86d55fb6eccb45813daa41e88
2024-06-11 08:05:30 +00:00
M Fahru
49b38c7075 Merge pull request #18750 from overleaf/mf-new-plans-page-content-border
[web] Add border around new plans page main content

GitOrigin-RevId: fb09e8b97b60281d0776f237eec0cf0e3e7c44f4
2024-06-11 08:05:22 +00:00
M Fahru
bdf6820136 Merge pull request #18421 from overleaf/mf-fix-optional-text-form-marketing
Fix "(Optional)" text style in contact form: 14px font size and no bold.

GitOrigin-RevId: 6257136ea3ff74731d6cec6b7a8873128ccd823f
2024-06-11 08:05:17 +00:00
andrew rumble
3311066363 Add new fields to mongoose subscription schema
GitOrigin-RevId: 6b28d7464482a8d5729709f99893b333c3d7f9c2
2024-06-11 08:04:55 +00:00
Mathias Jakobsen
8c6c67564f Merge pull request #18778 from overleaf/mj-web-chat-restore-tests
[chat+web] Add tests for revert functionality

GitOrigin-RevId: f10a5589d8ee1299949ef3decd8325d8fa1f7d41
2024-06-11 08:04:51 +00:00
Liangjun Song
b9b9090155 [web] implement in-house sha1 hash function (#18769)
* Revert "Revert "[web]implement in-house sha1 hash function (#18651)" (#18703)"

This reverts commit b2be3907439525f3ed49baec0b438ba35ea1663c.

* fix bug

* better tests

GitOrigin-RevId: 4b0e0337687eeee3086ba0ec38d9dc7ccb3f30ea
2024-06-11 08:04:39 +00:00
Liangjun Song
0680a91a70 [web] fix incorrect event group-subscription-left (#18757)
GitOrigin-RevId: aa342dc6575eca032834c2b132d4d0144a4faa27
2024-06-11 08:04:35 +00:00
Mathias Jakobsen
0ea04db53b Merge pull request #18818 from overleaf/revert-18816-revert-18815-revert-18671-mj-left-modal
Revert "[web] Make left menu modal show below other modals"

GitOrigin-RevId: 0b48ac1dc7f24986cc665b63eb5fe097e6a7e703
2024-06-11 08:04:30 +00:00
Mathias Jakobsen
e7f429a5c1 Merge pull request #18816 from overleaf/revert-18815-revert-18671-mj-left-modal
Revert "Revert "[web] Make left menu modal show below other modals""

GitOrigin-RevId: aaa51e251826c713ef0f46616ce8780d525d6430
2024-06-11 08:04:26 +00:00
Mathias Jakobsen
8596fa21f2 Merge pull request #18815 from overleaf/revert-18671-mj-left-modal
Revert "[web] Make left menu modal show below other modals"

GitOrigin-RevId: d48649fadd0c0e1694e295d850e4900aaaac38fd
2024-06-11 08:04:22 +00:00
David
eb9044bc9b Merge pull request #18806 from overleaf/dp-revert-18445
Remove workaround for chrome pdf rendering bug that has since been fixed

GitOrigin-RevId: 622f04d6dad848dc725e0f1776ea37436a60dc63
2024-06-11 08:04:17 +00:00
Jakob Ackermann
fb2e3b3a25 Merge pull request #18770 from overleaf/jpa-fph-migration-docs
[web] add documentation for full project history migration check

GitOrigin-RevId: 4a7e5a734d7fd4a2ca0a4315f57929809937e842
2024-06-11 08:04:13 +00:00
Jakob Ackermann
fb27046936 Merge pull request #18767 from overleaf/jpa-fix-frontend-test-split
[web] fix test_frontend_ct_core/editor split when running locally

GitOrigin-RevId: 657542b684a8d24b931fede056e1b7ffd8f07fb8
2024-06-11 08:04:09 +00:00
Antoine Clausse
262a92083a Don't throw cron job when some PayPal collection fails (#18795)
* Don't throw cron job when some PayPal collection fails

Follow-up of https://github.com/overleaf/internal/pull/18414 and https://github.com/overleaf/internal/pull/18572

This was causing `Heartbeat [cron-web-collect-paypal-prod] is expired.`
And the cron to rerun (altogether three times a day, instead of once a day)

https://cloudlogging.app.goo.gl/W4qBPFDeTUkRQ8J27

* Update tests

GitOrigin-RevId: a6a29cc84c0c72fd86b2e3a9739669d3a5fb0be5
2024-06-11 08:04:04 +00:00
Mathias Jakobsen
c29c151c9f Merge pull request #18803 from overleaf/revert-18801-mj-revert-big-deploy
[web+chat] Redo deploy

GitOrigin-RevId: a056bf20d49a39e71e03db740f57e8506dfc6b71
2024-06-11 08:03:59 +00:00
CloudBuild
e67a2b92a8 auto update translation
GitOrigin-RevId: b30c8a6f7a065d3ff719b323cc7827e135cade0d
2024-06-10 08:04:42 +00:00
John Lees-Miller
05ac4b956d Merge pull request #18812 from overleaf/mj-mathjax-unicode
[web] Disable mathjax unicode package

GitOrigin-RevId: 0c42a7a531576af35c31377068763bee4674394d
2024-06-10 08:04:38 +00:00
Mathias Jakobsen
a26e3d3376 Merge pull request #18801 from overleaf/mj-revert-big-deploy
[web+chat] Revert big deploy

GitOrigin-RevId: f4d068cbea7e5f5d59a3d698e2def2f94c9b6322
2024-06-10 08:04:33 +00:00
Mathias Jakobsen
d470093174 Merge pull request #18737 from overleaf/mj-chat-revert-existing-file
[web] Revert existing file by deleting it first

GitOrigin-RevId: ec9ed5c709c2631ff08dbc2e0f3633d303f12836
2024-06-10 08:04:29 +00:00
Mathias Jakobsen
110b83aea0 Merge pull request #18710 from overleaf/mj-web-chat-send-thread-data
[chat+web] Inform frontend when duplicating threads

GitOrigin-RevId: 285afee8f5a016a8e7ac58e9538cc3ec8362681d
2024-06-10 08:04:25 +00:00
Mathias Jakobsen
0f869f9059 Merge pull request #18654 from overleaf/mj-web-duplicate-threads
[web] Ensure single doc pointing to comment when reverting

GitOrigin-RevId: e86e566e1b21eed18bb08b285befcab0e740ec45
2024-06-10 08:04:20 +00:00
Mathias Jakobsen
304f572f9c Merge pull request #18637 from overleaf/mj-chat-duplicate-threads
[chat] Add endpoint for duplicating comment threads

GitOrigin-RevId: 0b3fb1b836150ccb6d213ab2bba6ce7ff6c69b4a
2024-06-10 08:04:16 +00:00
Mathias Jakobsen
f0eba8e742 Merge pull request #18676 from overleaf/mj-web-linter-document-class
[web] Allow underscore in optional argument in \documentclass

GitOrigin-RevId: c6f8716548411ade03814c8123df76fa8aa70ecc
2024-06-10 08:04:11 +00:00
Mathias Jakobsen
2247f02308 Merge pull request #18671 from overleaf/mj-left-modal
[web] Make left menu modal show below other modals

GitOrigin-RevId: 1f3267ef5e0e6d8152dbe1f74218e72053b41360
2024-06-10 08:04:07 +00:00
David
ca41c42288 Merge pull request #18762 from overleaf/dp-pdf-improvements
PDF Toolbar usability improvements

GitOrigin-RevId: 138e42cad0c9c97cfe45eb00fb123084e0228fdd
2024-06-10 08:03:55 +00:00
CloudBuild
249cb69074 auto update translation
GitOrigin-RevId: a253ed0c7e36f3dd23f7353cf907276e0d7de4e6
2024-06-07 08:04:36 +00:00
M Fahru
671b7fd0d9 Merge pull request #18749 from overleaf/mf-render-new-plans-page-based-on-screen-size
[web] Create a configuration to render new plans page content based on screen width

GitOrigin-RevId: 64e1eba3a44665c6f58b432ff46a8b5e5a9f2cfa
2024-06-07 08:04:32 +00:00
M Fahru
0f783a7346 Merge pull request #18652 from overleaf/mf-create-main-tab-new-plans-page
[web] Create new plans page tabs and period switcher

GitOrigin-RevId: 2dfea413fdcbbca8e90c1ab76844f35b2da4bd62
2024-06-07 08:04:28 +00:00
Tim Down
29837ec838 Merge pull request #18733 from overleaf/td-bs5-button-props
Simplify handling of BS3 props in button wrapper component

GitOrigin-RevId: 12a6b1374da5084e075775f3cef23f0b24d098fc
2024-06-07 08:04:24 +00:00
Eric Mc Sween
c070c036af Merge pull request #18747 from overleaf/em-update-compressor-comment-ids
Propagate commentIds in UpdateCompressor

GitOrigin-RevId: 03315146c2dc816d02e69594df44d0d25f7952ca
2024-06-07 08:04:13 +00:00
CloudBuild
a732130633 auto update translation
GitOrigin-RevId: 4846fd5b557342c25025f6c504fbd14641ac85c4
2024-06-06 08:05:15 +00:00
M Fahru
5b29729e9b Merge pull request #18714 from overleaf/mf-fix-group-plan-modal-hash-plans-table
[web] Fix loading plans page with group plan modal hash (#groups) does not enable the group plan table

GitOrigin-RevId: acd2e683d8e8d3f2b3325c3745856fe27c96eed6
2024-06-06 08:05:10 +00:00
Jessica Lawshe
d7b64ef92e Merge pull request #18718 from overleaf/jel-isSplitTestActive-plans-page
[web] New plans page variants only loadable if test is active

GitOrigin-RevId: 2b29dc8a3ecef6dd8f34dd25e59bf48a9724061b
2024-06-06 08:05:05 +00:00
Jessica Lawshe
3948b6ddb3 Merge pull request #18717 from overleaf/jel-isSplitTestActive
[web] Add helper for checking if test is active

GitOrigin-RevId: 1e8987517915e3947812086863da11fad252daf1
2024-06-06 08:05:01 +00:00
Jessica Lawshe
8fe46feffb Merge pull request #18713 from overleaf/jel-group-plan-modal-defaults
[web] Move group modal defaults for plans page to function

GitOrigin-RevId: 0ebce884f9e984b50318742765b7a768f259a8db
2024-06-06 08:04:56 +00:00
Jessica Lawshe
d28e58a2fc Merge pull request #18686 from overleaf/jel-plans-page-currency
[web] Move `currency` check to `_getRecommendedCurrency`

GitOrigin-RevId: afadd492a2e1db9c91fac027eb3c9783194ff169
2024-06-06 08:04:52 +00:00
Eric Mc Sween
6c9d4fb522 Merge pull request #18716 from overleaf/em-tracked-delete-undo
Fix translation of tracked deletes

GitOrigin-RevId: 4124db6953cbed46eea61f62118fc8e1ddfff4a0
2024-06-06 08:04:43 +00:00
ilkin-overleaf
dd7970c11d Merge pull request #18644 from overleaf/ii-delete-with-body-teardown-old-routes
[web] Tear down deprecated routes

GitOrigin-RevId: b86e1d9283a30d36f77148eeb782a7f37987854a
2024-06-06 08:04:31 +00:00
Antoine Clausse
e452f1df5b [web] Promisify LdapController (#18500)
* Promisify LdapController

* Update tests LdapControllerTests.js

* Promisify `AuthenticationController.finishLogin`

* Simplify null checks in LdapController

* Fix: don't use spread operator in module.exports

* Make `AuthenticationController.promises.finishLogin` a promise that resolves

* Fixup: `finishLogin` does not call `next` then the promise finishes, it calls it only on errors

* Use `Modules.promises.hooks.fire`

* Revert `processPassportLogin` callback style

* Update error handling: Use `OError.tag` instead of `logger.err`

* Fix unit tests: Rely on callbacks rather than promises

* Fix: Actually call `passport.authenticate` (!!)

* Update test: fixup `passport.authenticate` mocks

This would have caught the bugs that the previous commit is solving

* Remove `.then(() => next())` in `processPassportLogin`

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>

---------

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: a7eab5f5289956aeb8f2418408958daef3511ab7
2024-06-06 08:04:23 +00:00
Antoine Clausse
258289e65a [web] Promisify LaunchpadController (#18497)
* Remove unused exports and decaffeinate comment

* Update export format

* Make `launchpadPage` async

* Make `_atLeastOneAdminExists` async

* Make `sendTestEmail` async

* Make `registerExternalAuthAdmin` async

* Make `registerAdmin` async

* Update tests LaunchpadControllerTests.js

* Use `expressify(...)`

* Fix unit tests: export `LaunchpadController`

* Fix unit tests by awaiting expressified functions (could include breaking changes!)

* Call `.exec()` after `User.updateOne(...)`

* Revert promisification of `expressify`

* Revert some `return` removal in tests

GitOrigin-RevId: c73a38bf1cf798830df046fe96d3516178655ea6
2024-06-06 08:04:18 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534)
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
2024-06-06 08:04:09 +00:00
Tim Down
b3d33fe813 Merge pull request #18688 from overleaf/td-bs5-dropdown-min-width
Apply min-width rather than width to Bootstrap 5 drop-downs

GitOrigin-RevId: 369b5028fa5c53e7e39986474c27f8b848e70b20
2024-06-05 08:04:05 +00:00
Liangjun Song
432fbd3c40 Revert "[web]implement in-house sha1 hash function (#18651)" (#18703)
This reverts commit aa3f5ab3ff412696c715521381eebf176f503197.

GitOrigin-RevId: b2be3907439525f3ed49baec0b438ba35ea1663c
2024-06-05 08:03:57 +00:00
Eric Mc Sween
55c342134c Merge pull request #18659 from overleaf/em-crop-comments-tracked-deletes
Crop comments when processing tracked deletes

GitOrigin-RevId: 662c9ed86a8ed4959d1671ce466548487f334f45
2024-06-05 08:03:53 +00:00
Liangjun Song
4101f4efeb [web]implement in-house sha1 hash function (#18651)
* implement in-house sha1 hash function

* add comment

* add test description

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>

* add more tests

* dedupe test strings and remove unneeded toString calls

---------

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>
GitOrigin-RevId: aa3f5ab3ff412696c715521381eebf176f503197
2024-06-05 08:03:42 +00:00
CloudBuild
a9cc32e6ed auto update translation
GitOrigin-RevId: 12802865aecee6957eb6b36eafc4500c32512aeb
2024-06-04 08:05:12 +00:00
Tim Down
9f1272d46d Merge pull request #18536 from overleaf/td-bs5-remove-bookmarkable-tab
Move bookmarkable tabs to Bootstrap 3 only

GitOrigin-RevId: 456599e96f6b0ee3862004f74e4b19c5d4d94c93
2024-06-04 08:05:04 +00:00
Jessica Lawshe
22be3928e3 Merge pull request #18614 from overleaf/mf-create-plans-redesign-split-test-config
[web] Create split test configuration for `website-redesign-plans` split test

GitOrigin-RevId: dea88256830897d1ab1f1de64eb21413c823e6ff
2024-06-04 08:04:59 +00:00
Jessica Lawshe
9e99683915 Merge pull request #18568 from overleaf/jel-cms-cards
[web] Add 2 new card style options for CMS

GitOrigin-RevId: d784d3f4860abf9553f1ab68e3edd29b93355a52
2024-06-04 08:04:55 +00:00
Liangjun Song
c22802eac9 implement in-house md5 hash function (#18647)
* implement in-house md5 hash function

* format

* add lisence information

GitOrigin-RevId: 1416654e8c27ec7a0d6ca632e6ece59c830ef561
2024-06-04 08:04:50 +00:00
Tim Down
c0d920f305 Merge pull request #18660 from overleaf/td-rd-bs5-contact-us-modal
Bootstrap 5 contact us modal

GitOrigin-RevId: a4607fab50152109fbe83bc29246b7b4a82539a1
2024-06-04 08:04:46 +00:00
Tim Down
e533bee8a3 Merge pull request #18664 from overleaf/td-bs5-integrations-premium-badge
Position "premium feature" badge correctly on account settings page

GitOrigin-RevId: 82d8a1db739a9836bcfa2c6a56a2bc6198da7f54
2024-06-04 08:04:38 +00:00
Tim Down
7825bb8dd8 Merge pull request #18662 from overleaf/td-bs5-increase-settings-button-sizes
Bootstrap 5: increase size of "Add new email" and institution/role change submit buttons

GitOrigin-RevId: 28756bdfe723a57da9c73f0ab3d852d2f9c3ea5e
2024-06-04 08:04:34 +00:00
Mathias Jakobsen
2180ea0578 Merge pull request #18657 from overleaf/mj-mastersthesis-typo
[web] Fix typo in mastersthesis autocompletion

GitOrigin-RevId: 38c3473c310da071b5293739dc6e74d0263259b9
2024-06-04 08:04:08 +00:00
David
656130b2ed Merge pull request #18655 from overleaf/dp-pdf-viewer-typescript
Convert PdfJsViewer component to typescript

GitOrigin-RevId: 1019b947f3e6869a99495d3de7cd14ebd5007587
2024-06-04 08:04:03 +00:00
David
d652717c5a Merge pull request #18601 from overleaf/dp-pdf
Only set initial pdf page number on first page render

GitOrigin-RevId: f272acb2bce704037079e01dde89e475414e9fea
2024-06-04 08:03:59 +00:00
Jakob Ackermann
167bb66939 Merge pull request #18656 from overleaf/jpa-fix-double-lint
[web] eslint with multiple --ignore-pattern is broken

GitOrigin-RevId: eef4bdd2e43c6f576ee5997f8e9a2bd9f385ab48
2024-06-04 08:03:54 +00:00
CloudBuild
9bed2dc73e auto update translation
GitOrigin-RevId: eb89cf81de994aff77bd8a88748656700dbad86c
2024-06-03 08:04:22 +00:00
Andrew Rumble
d1a58e6b77 Merge pull request #18538 from overleaf/ar-add-download-all-link-in-web
[web] add download all link for output files

GitOrigin-RevId: 3d574d75d53e577cb0f8fd3caa4f757d9e1b7889
2024-06-03 08:04:07 +00:00
David
a70a3fc77e Merge pull request #18514 from overleaf/dp-pdf-toolbar-hover
Add hover state to pdf toolbar buttons

GitOrigin-RevId: d58ad739e6454b9e0cdbdbb93c55e58785a9d672
2024-06-03 08:04:02 +00:00
CloudBuild
f89ee54fdc auto update translation
GitOrigin-RevId: ab2ee1e69de70b797f33fe7d9757444f8fc2f527
2024-05-31 08:05:00 +00:00
Jimmy Domagala-Tang
17074473a7 Merge pull request #18525 from overleaf/jdt-disable-indenttaion-safari
[Web] Disable indentation markers on Safari

GitOrigin-RevId: 7a62382e6d4a4ecf0bd144ab937f6e197d173bdb
2024-05-31 08:04:56 +00:00
Rebeka Dekany
9120afffa5 Merge pull request #18567 from overleaf/rd-bs5-settings-modal
[web] Migrate the Git Integration settings on the Account Settings page to Bootstrap 5

GitOrigin-RevId: bafac941d3afaadaa046de07e18968d8e3692b1c
2024-05-31 08:04:49 +00:00
Tim Down
1b247347e7 Merge pull request #18590 from overleaf/td-ieee-editor-remove-blue
Disable IEEE stylesheet in IEEE editor based on feature flag

GitOrigin-RevId: 09b203e3220a868d5f0a0e413bdc4d3ff7a1792e
2024-05-31 08:04:41 +00:00
Jessica Lawshe
d209c107c5 Merge pull request #18613 from overleaf/dp-pdf-keyboard-scroll
Fix keyboard arrow scrolling on pdf viewer

GitOrigin-RevId: 7c338049f0e5368ee11fdda11198a1f4df2bd49f
2024-05-31 08:04:34 +00:00
Jessica Lawshe
3a59883e7a Merge pull request #18297 from overleaf/jel-remove-angular-group-invite
[web] Remove Angular version of group invite

GitOrigin-RevId: bd31cd2ed3c105c9042ae9c42894cfe960459a46
2024-05-31 08:04:27 +00:00
Jessica Lawshe
cbe5cefb9a Merge pull request #18161 from overleaf/jel-subscription-dash-admin
[web] Subscription dash message when viewing as admin

GitOrigin-RevId: 699a523d7ac8d1a71e9ba14c7b8a66b39142958a
2024-05-31 08:04:23 +00:00
Eric Mc Sween
c85f4ab5e5 Merge pull request #18491 from overleaf/em-filter-summarized-updates
Filter out comment ops from summarized updates

GitOrigin-RevId: 97a44821b6dc001cd1ea84115cf69c8d712e9946
2024-05-31 08:04:18 +00:00
Jakob Ackermann
5a1cff55bc Merge pull request #18543 from overleaf/jpa-server-pro-test-templates
[server-pro] tests: add tests for templates feature

GitOrigin-RevId: b36482af924e306207cbdedc1a8d1d548272ee77
2024-05-30 08:05:30 +00:00
Eric Mc Sween
22257cf037 Merge pull request #18583 from overleaf/em-multi-hash-key
Ensure that MULTI commands always go to a single node

GitOrigin-RevId: 223d29986766577df89c82983126dabca5d16eed
2024-05-30 08:05:17 +00:00
David
55e54ce875 Merge pull request #18435 from overleaf/dp-ae-pdf-viewer-controls
Update PDF viewer controls

GitOrigin-RevId: 4e15b7cbd34e878d0175be635369b8d620188203
2024-05-30 08:05:06 +00:00
Eric Mc Sween
e0f6622519 Merge pull request #18579 from overleaf/em-verbose-multi-error
More verbose error on MULTI

GitOrigin-RevId: c1e194063bfd4b4cc88bfb5775af13e1533100d4
2024-05-30 08:04:52 +00:00
Tim Down
134232a1a6 Merge pull request #18577 from overleaf/td-bs5-nav-dropdown-item-missing-href
Add missing href on Bootstrap 5 nav dropdown items

GitOrigin-RevId: 211a6dbd559ad74a9e49edbace61a51c2cc2f2da
2024-05-30 08:04:48 +00:00
ilkin-overleaf
920bbe4bac Merge pull request #18527 from overleaf/ii-bs5-projects-structure
[web] Create the sidebar and projects columns in dashboard page (BS5)

GitOrigin-RevId: 9096d6932980c10816411fc18570ad88df68a6d6
2024-05-30 08:04:44 +00:00
Mathias Jakobsen
80044b53b4 Merge pull request #18571 from overleaf/mj-error-reporting-more-info
[web] Add frontend release and load time to error reporting

GitOrigin-RevId: f362569d0012131d4538016573d1488b30b5c790
2024-05-30 08:04:40 +00:00
Antoine Clausse
36f0a3e01a [web] Promisify ProjectController (#18477)
* Create `promiseAuto` util to replace `async.auto`

* Promisify `BrandVariationsHandler.getBrandVariationById`

* Promisify `updateProjectSettings`

* Promisify `updateProjectAdminSettings`

* Promisify `newProject`

* Promisify `deleteProject`

* Promisify `loadEditor`

* Fix brandVariation loading in promise auto

* Promisify `_refreshFeatures`

* Promisify `_injectProjectUsers`

* Fix `no-inner-declarations`

* Promisify `cloneProject`

* Promisify `userProjectsJson`

* Promisify `projectEntitiesJson`

* Promisify `restoreProject`

* Promisify `renameProject`

* Additional warning fix

* Update unit tests

* Fixup `updateProjectSettings`: call jobs inside the Promise.all

* Use `expressify(...)` instead of manually call `next(err)`

https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
https://github.com/overleaf/internal/pull/18477#discussion_r1613621146
https://github.com/overleaf/internal/pull/18477#discussion_r1613634000
...

* Replace Promise.all by sequencial awaits

https://github.com/overleaf/internal/pull/18477#discussion_r1613852746
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987

* Remove manual throws of 500. Let the generic error handler catch them.

https://github.com/overleaf/internal/pull/18477#discussion_r1613623446
https://github.com/overleaf/internal/pull/18477#discussion_r1613628955

* Promisify `untrashProject`

https://github.com/overleaf/internal/pull/18477#discussion_r1613627783

* Promisify `expireDeletedProjectsAfterDuration`

* Promisify `archiveProject`

* Promisify `unarchiveProject`

* Promisify `trashProject`

* Promisify `expireDeletedProject`

* Use async `setTimeout` from `timers/promise`

https://github.com/overleaf/internal/pull/18477#discussion_r1613843085

* Remove unused `_injectProjectUsers`

https://github.com/overleaf/internal/pull/18477#discussion_r1613855766

* Add missing exec in queries (?)

Not sure if that makes a real difference but it's more consistent with the rest of the code

* Catch floating promises

https://github.com/overleaf/internal/pull/18477#discussion_r1613868876

* Replace custom `promiseAuto` by `p-props` from NPM

https://github.com/overleaf/internal/pull/18477#discussion_r1613393294

* Downgrade `p-props` to v4. Later versions require ESM

* Simplify code around `splitTestAssignments`

GitOrigin-RevId: 84d37f7aa9227b5b9acf9eeb5db1b78afc01b6ee
2024-05-30 08:04:36 +00:00
Antoine Clausse
01e1286a8b In PayPal collect invoices script: Update throw unsuccessful invoices collections (#18572)
* Remove throw on `INVOICES_COLLECTED_SUCCESS.length === 0`

Effectively reverts 038377b511

See: https://digital-science.slack.com/archives/C20TZCMMF/p1716973110408049

* Update tests so they don't expect rejections

* Reject when some invoice collection failed

GitOrigin-RevId: aa37f7fa37c96b8624e87d94be675d115e3250a9
2024-05-30 08:04:31 +00:00
M Fahru
69871fccbe Fix plans page hash does not get updated if no hash is on the URL
Example case: visit plans page via other pages, the hash will be empty initially, this commit will make sure hash is updated even though no initial hash exists.

GitOrigin-RevId: 411585111e8cf1b3eb803059ad4cf98ae4e69b19
2024-05-30 08:04:27 +00:00
Domagoj Kriskovic
218a4538c1 [web] support for reverting binary files (#18033)
* [web] revert binary file

* use addEntityWithName if file was deleted

* todo comments

* only show Revert file in ui even if deleted

* use _revertBinaryFile function

* emit new ids when reverting

* format:fix

* await emitToRoom calls

* use EditorController.upsertFile

* remove _revertBinaryFile function

* binary file check

* mock importFile method in tests

* move findElementByPath stub

* debug ci error

* resolve with empty object as file

* fix tests

* remove await before expect()

* format:fix

* test when binary file exists and when it does not

* use "file-revert" for source

* [web] revert existing file without ranges support (#18107)

* [web] revert existing file without ranges support

* ignore document_updated_externally if file-revert

* fix test

GitOrigin-RevId: a5e0c83a7635bc7d934dec9debe916bdd4beb51e
2024-05-30 08:04:20 +00:00
Tim Down
3b2e60ece7 Merge pull request #18558 from overleaf/td-bs5-query-string-override
Add a mechanism to hide incomplete Bootstrap 5 pages by default

GitOrigin-RevId: 07cc998bf3a0bed9df2f43d1c04c62d167c9b893
2024-05-30 08:04:15 +00:00
Tim Down
c67e677157 Merge pull request #18389 from overleaf/td-bs5-move-sass-npm-packages
Move Sass and related packages into web

GitOrigin-RevId: 89a58d0caa3261e3fe87292e999d1f6f799b683d
2024-05-30 08:04:11 +00:00
Andrew Rumble
22e0e51796 Merge pull request #18464 from overleaf/ar-pass-analytics-id-to-google-analytics
Add analytics ID to google analytics when configuring

GitOrigin-RevId: e2372f68217583a90df427a853e62513f1535006
2024-05-30 08:04:07 +00:00
Davinder Singh
1664722769 Merge pull request #18110 from overleaf/ds-sales-contact-form-redesign
Website Redesign - Sales Contact form configuration for the new design

GitOrigin-RevId: 51f933a535bfb7e7640a76072acc54bfb5599dc3
2024-05-30 08:04:02 +00:00
Rebeka Dekany
e3ebcb03d9 Merge pull request #18533 from overleaf/rd-bs5-shadow
[web] Import styles for the modal animation

GitOrigin-RevId: d67ba98e003b314ccd4893f17c8fa78187134d20
2024-05-30 08:03:58 +00:00
Thomas
2fa002e7e9 Merge pull request #17454 from overleaf/tm-remove-old-design-system-variables
Remove unused files from old design system

GitOrigin-RevId: 3eca6e9b91484376bde176682bbbecbc6897d1d2
2024-05-29 08:05:18 +00:00
M Fahru
c722dcbc8d Merge pull request #18419 from overleaf/mf-plans-page-permanent-url
[web] Create permanent URL for all plans and switch state in the plans page

GitOrigin-RevId: 5fa0af0e33868f8fa4f6a74627bedb4c22705cb0
2024-05-29 08:05:11 +00:00
M Fahru
97469c9bef Merge pull request #17945 from overleaf/mf-fix-disabled-state-btn-primary
[web] Fix website redesign primary button disabled style not applied properly because of CSS specificity issue

GitOrigin-RevId: 251d1f5b26bfe9a064c9bc7fd4c91fc77d8fbfe0
2024-05-29 08:05:01 +00:00
M Fahru
64e231eae4 Merge pull request #18554 from overleaf/ds-v2-second-test-login-register-page
Website Redesign - Spacing fixes on login and register pages in the new design

GitOrigin-RevId: 2012a0c07ee767b666252be2a1867024848b2879
2024-05-29 08:04:53 +00:00
Mathias Jakobsen
d95910fc71 [web] Enable history ranges support behind feature flag (#18429)
GitOrigin-RevId: 2f3b2352d2c157248da350eaf7b1784a605ebf20
2024-05-29 08:04:33 +00:00
Mathias Jakobsen
f14fdc7b7c Merge pull request #17958 from overleaf/mj-web-revert-file
[web] Initial version of file reverting

GitOrigin-RevId: ef500b2c3ddf21b0acb6650c2526edd10ab2cc18
2024-05-29 08:04:16 +00:00
Tim Down
edaba14ed1 Merge pull request #18420 from overleaf/td-bs5-nav
Bootstrap 5: Navigation

GitOrigin-RevId: d22683d78c8b3bc3f41bbd276c36f47d480e24ff
2024-05-29 08:04:05 +00:00
Eric Mc Sween
8704e430a4 Merge pull request #18468 from overleaf/em-docupdater-resolved-comment-ids
Store resolved comment ids in docupdater

GitOrigin-RevId: 69f09ecf69deedbb9a3682f13356533799025ea8
2024-05-29 08:04:01 +00:00
Jakob Ackermann
a486f7e481 Merge pull request #18537 from overleaf/jpa-cleanup-synctex
[clsi] cleanup unused SYNCTEX_BIN_HOST_PATH

GitOrigin-RevId: 062aed9dceb1388fab0e59770aded5a440eaa3bd
2024-05-29 08:03:57 +00:00
ilkin-overleaf
4e7fbcfe2e Merge pull request #18473 from overleaf/ii-bs5-settings-grid-fix
[web] Adjust column breakpoints in bs5 account settings page

GitOrigin-RevId: 90e7fe7561a75439166472627fdb6189ebcdefa1
2024-05-29 08:03:46 +00:00
ilkin-overleaf
abd57e03cf Merge pull request #17831 from overleaf/msm-filter-saml-error-log
[web] Filter saml error logs by path

GitOrigin-RevId: 4ca9e156657afc893f38fed7ec6b00cbb7a608ef
2024-05-28 08:04:10 +00:00
ilkin-overleaf
fe7de51827 Merge pull request #18338 from overleaf/ii-bs5-split-badges-and-tags
[web] Split badges and tags

GitOrigin-RevId: fce5a93672f431ff74c2b63a67e249f5f7e7fecd
2024-05-28 08:04:05 +00:00
Eric Mc Sween
3a1560894a Merge pull request #18516 from overleaf/em-web-resolved-comment-ids
Reintroduce resolved comment ids in getDocument()

GitOrigin-RevId: 591589efc643c815c40df440d1297158901f7a79
2024-05-28 08:04:01 +00:00
CloudBuild
1889b9a426 auto update translation
GitOrigin-RevId: d3794a68e3d5bc01d1a9ff47d55d644dbd952b1e
2024-05-27 10:24:35 +00:00
Eric Mc Sween
ea8f8d0651 Merge pull request #18506 from overleaf/em-revert-web-resolved-comment-ids
Revert #18398 - return resolved commentIds with getDocument()

GitOrigin-RevId: c5d2dd91d02d88029eb2702d73ac37cb8dbca32c
2024-05-27 10:24:25 +00:00
Eric Mc Sween
92945f504d Merge pull request #18496 from overleaf/rd-pug-warning-attributes
[web] Fix: "You should not have pug tags with multiple attributes" warning

GitOrigin-RevId: 0adfdf6a130c60966eae3c845011975af7eecc44
2024-05-27 10:24:21 +00:00
Eric Mc Sween
83e1452991 Merge pull request #18398 from overleaf/em-web-resolved-comment-ids
Return resolved comment ids with getDocument()

GitOrigin-RevId: 30234f72d52b90b313821290b6c63aa6cc6cb243
2024-05-27 10:24:13 +00:00
Andrew Rumble
80ede301fa Merge pull request #18474 from overleaf/ar-return-build-id-from-clsi-after-compile
[clsi] Return buildId after compiles

GitOrigin-RevId: 872048f4fea8f5a00b817e29bd26a444d179a45f
2024-05-27 10:24:06 +00:00
Alexandre Bourdin
a0c8cf663a Merge pull request #18000 from overleaf/ab-dev-enable-toolbar-default
[web] Enable the dev-toolbar by default in the dev environment

GitOrigin-RevId: 170e59e9b82268e621fe99ffcc82b7d68467e1b3
2024-05-27 10:23:56 +00:00
CloudBuild
418d77522e auto update translation
GitOrigin-RevId: 0a8a59c7cde3120f2cd54660929850a2d67d3e40
2024-05-27 10:23:51 +00:00
Jimmy Domagala-Tang
81903bb79d Merge pull request #18175 from overleaf/jdt-new-bib-file-prompt
[Web] Add opportunistic prompts for third party references

GitOrigin-RevId: d794df16781d0db707423f23ab12f40a13604907
2024-05-27 10:23:41 +00:00
Brian Gough
344b4d0fa0 Merge pull request #18088 from overleaf/ab-session-secret-rotation
[web/realtime/history-v1] Support session secret rotation

GitOrigin-RevId: 3c2fa27b1b3e0a8e0c9d1af2e616ce873d54aedf
2024-05-27 10:23:33 +00:00
Davinder Singh
a4816d6e75 Merge pull request #18396 from overleaf/ds-register-login-split-test-2
Website redesign - New round of split test for Register and login page

GitOrigin-RevId: 69fe41b004eabe3efede27da80b9885b0fc2750b
2024-05-27 10:23:22 +00:00
Antoine Clausse
554be73a36 In collect_paypal_past_due_invoice.js, iterate over each page instead of gathering data from all pages at first (#18414)
* Create `getPaginatedEndpointIterator` to iterate each page

* Create `waitMs` util, it will replace `slowCallback`

* Make `handleAPIError` async

* Make `isAccountUsingPaypal` async

* Make `attemptInvoiceCollection` async

* Make `attemptInvoicesCollection` async

* Use `await` instead of `new Promise`

* Remove unused callbackified `attemptInvoiceCollection`

* Run `attemptInvoiceCollection` for each page instead of gathering all pages in the beginning

* Add test on fetching multiple pages of invoice

GitOrigin-RevId: 2674b18c6ca5732b873fb2bc71b515909006f93d
2024-05-27 10:23:18 +00:00
CloudBuild
71cc62cd50 auto update translation
GitOrigin-RevId: 1809c29cdcc3191f0a5cffa92c2a28edeb37cc72
2024-05-27 10:23:13 +00:00
M Fahru
926218ed1b [web] Add sales-related option in all of our contact forms (#18395)
- in /contact page
- in navbar -> Help
- in the plans page
- in the editor left menu

GitOrigin-RevId: e9cecafe7c16a23155fca083dbb680ad1f6fe407
2024-05-27 10:23:06 +00:00
Eric Mc Sween
6d216d4738 Merge pull request #18355 from overleaf/em-resync-tracked-changes
Handle tracked changes during resyncs

GitOrigin-RevId: 1d5b16a4cb17226da184a5430ebbcfc79ad9c7ce
2024-05-27 10:23:02 +00:00
Rebeka Dekany
a0334898db Merge pull request #18437 from overleaf/rd-bs5-project-dashboard
Enable Bootstrap 5 to load for the project dashboard page

GitOrigin-RevId: 4aa74bd4fde98192b2e5b322bb777a8c8beae237
2024-05-27 10:22:58 +00:00
Rebeka Dekany
8d25fb1131 Merge pull request #18454 from overleaf/rd-managed-account
[web] Use the Notification component for the managed account alert

GitOrigin-RevId: 3839b171348bf0f670b6a033b99078b8543ce2e5
2024-05-27 10:22:53 +00:00
Andrew Rumble
71187a51ba Merge pull request #18289 from overleaf/ac-ar-eslint-return-await
Add ESLint rule @typescript-eslint/return-await to backend services

GitOrigin-RevId: 75e3e32597827fcc852e69d479515fc72e8f45e4
2024-05-27 10:22:49 +00:00
David
029cd4abe7 Merge pull request #18456 from overleaf/dp-fix-main-lint
Fix lint by using recordEventForUserInBackground

GitOrigin-RevId: 3412c9a997ce0921b25408fc584060e528843b88
2024-05-27 10:22:44 +00:00
David
635aae7b1f Merge pull request #18320 from overleaf/dp-add-secondary-prompt-ui
Add secondary email form V2 (with Captcha this time)

GitOrigin-RevId: b06216a2c9cb5b3b09305a17992eca506a0047f5
2024-05-27 10:22:40 +00:00
roo hutton
5aea030184 Merge pull request #18422 from overleaf/rh-managed-acct-delete-email
[web]: Clarify tooltip for managed user attempting to delete email address

GitOrigin-RevId: 82eabc0b9d96773d5d418bec52ea917fd585ec63
2024-05-27 10:22:36 +00:00
CloudBuild
a6d7636a70 auto update translation
GitOrigin-RevId: 52fbd8a23dd32dd7b3141c0ccfd5aabb60807bd8
2024-05-27 10:22:28 +00:00
Eric Mc Sween
a22319fe46 Merge pull request #18453 from overleaf/em-fix-floating-promise
Fix no-floating-promises lint rule

GitOrigin-RevId: 58f89e0078abf72be65552f9468cb225e5758e3e
2024-05-27 10:22:24 +00:00
Eric Mc Sween
876ee4d967 Merge pull request #18225 from overleaf/em-typescript-eslint
Add typescript-eslint rule: no-floating-promises

GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
2024-05-27 10:22:20 +00:00
Eric Mc Sween
814b085b44 Merge pull request #18374 from overleaf/em-chat-resolved-thread-ids
Add resolved-thread-ids endpoint to chat

GitOrigin-RevId: 211dee88707f2d7fb1c0c8805a1f6ac28dca494d
2024-05-27 10:22:15 +00:00
Rebeka Dekany
5af6acde2b Merge pull request #18390 from overleaf/rd-bs5-close-position
[web ] Fix the close button position of modal header

GitOrigin-RevId: 79c6cf272f69446cb5849421445f016ea6d53403
2024-05-27 10:22:08 +00:00
Rebeka Dekany
74f0483157 Merge pull request #18418 from overleaf/rd-bs5-cookie-banner
[web] Migrate the cookie banner to Bootstrap 5

GitOrigin-RevId: 79dd74e2cf09faab381f24101a3633b0377009a0
2024-05-27 10:22:04 +00:00
Alf Eaton
3434d8c908 Trigger PDF.js canvas redraw on document visibility change (#18446)
GitOrigin-RevId: 44b3ce3ebd8b0e48c51451bbfc5c2d54397a9355
2024-05-27 10:21:59 +00:00
Alf Eaton
6569f49a92 Set isEvalSupported to false when loading a PDF document (#18444)
GitOrigin-RevId: 394d63571d83302b91b5719389adf49155218bc7
2024-05-27 10:21:55 +00:00
Alf Eaton
3cb4190ef0 Merge pull request #18223 from overleaf/jpa-lazy-init-matcher
[web] initialize matcher for ignored file paths lazily

GitOrigin-RevId: ed04b286e188ad73e3090822965b19ccf2e7d2b4
2024-05-27 10:21:51 +00:00
Antoine Clausse
3300811d3a [web] Simplify removeSessionsFromRedis signature (#18440)
* Simplify `removeSessionsFromRedis` signature

* Update usage of `removeSessionsFromRedis`

* Fix tests around `removeSessionsFromRedis`

* Add comments "remove all sessions except the current session"

GitOrigin-RevId: 03bf99c14faf2c8e403bc4bcc16463a70e031284
2024-05-27 10:21:30 +00:00
Antoine Clausse
78a0bc2b05 [web] Convert RecurlyWrapper functions to async (#18384)
* Rename `RecurlyWrapper` to `promises`, as it will only contain the promises soon

* Update `apiRequest`

* Update `_parseXml`

* Update `_parseXmlAndGetAttribute`

* Update `_parse*Xml`

* Update `updateAccountEmailAddress`

* Update `checkAccountExists`

* Update `createAccount`

* Update `createBillingInfo`

* Update `setAddressAndCompanyBillingInfo`

* Update `createSubscription`

* Update `_createPaypalSubscription`

* Update `_handle422Response`

* Update `_createCreditCardSubscription`

* Update `createSubscription`

* Update `getSubscriptions`

* Update `getSubscription`

* Update `getPaginatedEndpoint`

* Update `getAccount`

* Update `getAccountActiveCoupons`

* Update `getCoupon`

* Update `getBillingInfo`

* Update `getAccountPastDueInvoices`

* Update `attemptInvoiceCollection`

* Update `updateSubscription`

* Update `createFixedAmmountCoupon`

* Update `lookupCoupon`

* Update `redeemCoupon`

* Update `extendTrial`

* Update `listAccountActiveSubscriptions`

* To find which functions to add as callbackified, I used this Regex:
`RecurlyWrapper\.(?!promises)[^.\s]*`

And after adding callbackified functions, we're left with no results with the Regex:
`RecurlyWrapper\.(?!promises|apiUrl|_buildXml|_parseXml|attemptInvoiceCollection|createFixedAmmountCoupon|getAccountActiveCoupons|getBillingInfo|getPaginatedEndpoint|getSubscription|updateAccountEmailAddress)[^.\s]*`

* Update unit tests

* Test `getSubscription` both as "promise" and as "callback"

I'm not sure if we want to generalize this.

* Fix: add missing `await`s (!!)

* Change `apiRequest` to reject errors instead of resolving it in an object

* Fixup for CollectPayPalPastDueInvoice test

* Fix: callbackify `getSubscriptions` (!!)

* Replace `.then(...)` chain by multiple `await`

* Fixup `attemptInvoicesCollection`: prevent reading length of undefined

* Use `return await` when returning promises

Per https://github.com/overleaf/internal/pull/18384#pullrequestreview-2065738771

GitOrigin-RevId: ceda755b24fd29f97a27e60ac5db9bc7e369f932
2024-05-27 10:21:26 +00:00
ilkin-overleaf
d56f5a3030 Merge pull request #18424 from overleaf/ii-delete-with-body-fe
[web] Replace delete with post requests when having body (FE)

GitOrigin-RevId: df727f35ea77eaa8273687f75aafd9bd983b7f25
2024-05-21 08:04:48 +00:00
ilkin-overleaf
7ca9a5b61b Merge pull request #18415 from overleaf/ii-delete-with-body
[web] Replace delete with post requests when having body

GitOrigin-RevId: b580cfa3bd53c21f46de72f3a36b647fda143b04
2024-05-21 08:04:44 +00:00
ilkin-overleaf
f469d8e5e3 Merge pull request #18369 from overleaf/ii-bs5-downshift
[web] BS5 downshift in account settings page

GitOrigin-RevId: acfbde3ec87ae8038e0b19ddaca35e6c7392743b
2024-05-21 08:04:40 +00:00
Alf Eaton
2d75652f61 Add uppy subdependencies (#18378)
GitOrigin-RevId: 8046821f4ea46e5d414e9d944ad58cc0a0a0857c
2024-05-21 08:04:35 +00:00
Alf Eaton
af721874f1 Set permissionsLevel to readOnly when out of sync (#18391)
GitOrigin-RevId: d495d7ba4d5d0c7db00277538c932a585f6dace0
2024-05-21 08:04:31 +00:00
Alf Eaton
e7827fbd57 Validate URL protocol before opening from Visual Editor tooltip (#18393)
GitOrigin-RevId: 1da255d3e8ccd91e8c8774d140ec663906be948f
2024-05-21 08:04:26 +00:00
CloudBuild
e9d4d26fec auto update translation
GitOrigin-RevId: 27e8955541b4d322e0a5571464e4d6234a638e90
2024-05-20 08:04:36 +00:00
CloudBuild
d0d2850bae auto update translation
GitOrigin-RevId: 356c7f9f2475e4715c99516f581d5aa20aebef70
2024-05-20 08:04:31 +00:00
Rebeka Dekany
1aa5ee7b21 Merge pull request #18404 from overleaf/rd-bs5-dropdown-fix
[web] Fix footer layout on the smallest viewport Bootstrap 5

GitOrigin-RevId: 741540ff5e25fe36021d0a2ef2d433dc63ee3650
2024-05-20 08:04:27 +00:00
Eric Mc Sween
dfd1652c35 Merge pull request #18375 from overleaf/em-promisify-chat-api-handler
Promisify ChatApiHandler

GitOrigin-RevId: 83cedb14b5e2b187fb2cb02fcbf888ada5a599b1
2024-05-20 08:04:22 +00:00
Rebeka Dekany
28c18e2486 Merge pull request #18365 from overleaf/rd-link-color
[web] Fix button links color

GitOrigin-RevId: ea8c1a4424ee85dd91995e45c0ef9a081a74546b
2024-05-20 08:04:17 +00:00
Antoine Clausse
25d8e053be [web] Update revokeAllUserSessions and rename it to removeSessionsFromRedis (#18360)
* Fix `revokeAllUserSessions` call in `_cleanupUser`

The user object should be passed, not the _id

* Change `revokeAllUserSessions` signature, take `req` and `stayLoggedIn` arguments

* Update uses of `revokeAllUserSessions`

* Fix promisified `revokeAllUserSessions` args

* Update tests

* Destroy or Regenerate the session in the end of `revokeAllUserSessions`

Per https://github.com/overleaf/internal/issues/17036#issuecomment-1938398570

* Revert "Destroy or Regenerate the session in the end of `revokeAllUserSessions`"

This reverts commit fe30734dbe45b27d2931d2e43a711d591bb85787.

* Rename `revokeAllUserSessions` to `removeSessionsFromRedis`

* Fixup tests

* Fix: add optional chaining in `req.sessionID` (!!)

GitOrigin-RevId: d41676bf00f463230af495e09c65fb9ee521f49f
2024-05-20 08:04:12 +00:00
Gernot Schulz
e8fe5abc82 Merge pull request #18312 from overleaf/gs-git-bridge-bash
Install bash in git-bridge Docker image

GitOrigin-RevId: 2ed599c3c2a3a1c3e66845d4d17d6ac36d925d70
2024-05-17 08:05:19 +00:00
CloudBuild
43c3c0c22e auto update translation
GitOrigin-RevId: f2b80a461106286993584d5d163053e11fbfbf63
2024-05-17 08:05:15 +00:00
Christopher Hoskin
3342d672c2 Merge pull request #18397 from overleaf/em-revert-download-all-link
Revert "Merge pull request #18190 from overleaf/ar-add-download-all-l…

GitOrigin-RevId: 681eb2734636d76558e682dc85083bfcaa6b7d2d
2024-05-17 08:05:10 +00:00
Antoine Clausse
d7f0c66d86 [web] Rename team name IEEECollabratec to IEEEPublications (#18387)
* Replaces all `IEEECollabratec` by `IEEEPublications`

* Revert change in migration

GitOrigin-RevId: f0445b726abdc5f65b7a0613d9979b081332685e
2024-05-17 08:05:06 +00:00
Rebeka Dekany
f652c49713 Merge pull request #18386 from overleaf/rd-footer-pug
[web] Migrate the language dropdown in footer to Bootstrap 5

GitOrigin-RevId: 07a37f59914c543ae8d33312aa313451145cd220
2024-05-17 08:05:02 +00:00
Brian Gough
598eaf08fd Merge pull request #17816 from overleaf/bg-eslint-rule-for-find-with-await
add eslint rule for find with await

GitOrigin-RevId: 7e78104e610073ff3c151d7314753c8301a8c787
2024-05-17 08:04:58 +00:00
M Fahru
9f86f90a08 Merge pull request #18095 from overleaf/mf-general-contact-form-redesign
[web][website-redesign] General contact form redesign

GitOrigin-RevId: f5f3a37fea69afb48a37b263695c958e6753e095
2024-05-17 08:04:53 +00:00
Eric Mc Sween
5d0190da0f Merge pull request #18342 from overleaf/em-tracking-props-none
Separate handling of "none" tracking type in operations

GitOrigin-RevId: b07ee5320ac1a9c63e3b0059aade1a1564819943
2024-05-17 08:04:46 +00:00
Alf Eaton
f5aa0a7a93 Improve compile assistant components (#18351)
GitOrigin-RevId: e42a37743252f6ddbc7db4e51473addb4be041b0
2024-05-17 08:04:42 +00:00
Alf Eaton
81559967f2 Ensure that onTimeoutHandler is called when there are unacknowledged edits (#18340)
GitOrigin-RevId: aa6430d7e32f6e27b67f92b187dbb13349fc6a40
2024-05-17 08:04:37 +00:00
Alf Eaton
95ab3921d7 Ensure that multiple spaces in file names are visible in the file tree (#18330)
GitOrigin-RevId: 512e89d8afbfccf1c981d4f10df1e5729248f381
2024-05-17 08:04:33 +00:00
Alf Eaton
c8947c781e Call selectEntity directly after a doc is opened (#18329)
GitOrigin-RevId: bf471812bfeb5e394252733a16691430d7d45840
2024-05-17 08:04:29 +00:00
Alf Eaton
e8a5f8f056 Catch failed references index request (#18274)
GitOrigin-RevId: 96063835056a39d85a57a77c0c7f71ce8243e6b9
2024-05-17 08:04:25 +00:00
Alf Eaton
9d6754f546 Add citepalias and citetalias (#18272)
GitOrigin-RevId: 60716cd30141f3079e9402140a5e40665bbe685f
2024-05-17 08:04:20 +00:00
Tim Down
97add91248 Merge pull request #18377 from overleaf/td-metrics-page-fix
Move Bootstrap and jQuery imports into metricsApp

GitOrigin-RevId: 3ec1690ca60928e983211792f6c6b63548dfe62c
2024-05-16 08:05:35 +00:00
Rebeka Dekany
f78e619d87 Merge pull request #18331 from overleaf/rd-bs5-renaming
[web ] Bootstrap 5 - rename the wrapper components and restructure

GitOrigin-RevId: 7a76903df81cd546e9e469f24c4f203ea6a61672
2024-05-16 08:05:31 +00:00
Mathias Jakobsen
2ce41e0ee6 Merge pull request #18323 from overleaf/mj-editor-loss-debug
[web] DEBUG: Calculate diff size when detecting edit-loss

GitOrigin-RevId: 750f7ed91d5ce81beb520e23181a6a8dc22b6078
2024-05-16 08:05:26 +00:00
Brian Gough
c1a4e4a873 Merge pull request #16775 from overleaf/bg-clsi-timeout-use-fetchutils-connect-timeout
Update UrlFetcher to use custom agent with connect timeout

GitOrigin-RevId: c92dc27a0e682b0b79859b3521bf64cbf8485345
2024-05-16 08:05:18 +00:00
David
1367a724a6 Merge pull request #18337 from overleaf/dp-long-words-in-project-titles
Wrap long words in project titles to avoid overflow

GitOrigin-RevId: aef9389f04927e4dafeb192b3275ee85cb10a78a
2024-05-16 08:05:13 +00:00
Jakob Ackermann
dfe587f297 Merge pull request #18294 from overleaf/jpa-td-invite-details
[web] avoid content reflection via query parameter on register page

GitOrigin-RevId: 43e7ba6069e0d9f3f12e5e9e680b5960b0673782
2024-05-16 08:05:09 +00:00
Andrew Rumble
105d67bd04 Merge pull request #18190 from overleaf/ar-add-download-all-link
[web] Add download all link for output files

GitOrigin-RevId: a275f17b6acf3130250d91462ba01588b93b62f5
2024-05-16 08:05:04 +00:00
Tim Down
0886104862 Merge pull request #18276 from overleaf/td-bs5-load-js
Load correct JS for the active Bootstrap version, second attempt

GitOrigin-RevId: ad8748a941691d745db5cd3e986e9c7b188b3ecb
2024-05-16 08:04:59 +00:00
Tim Down
9c1cb419de Merge pull request #18124 from overleaf/td-bs5-upgrade-packages
Upgrade Bootstrap 5 and related packages

GitOrigin-RevId: 9bf0bb957b045b52349abfdfe27fb1c41bebd91e
2024-05-16 08:04:51 +00:00
Mathias Jakobsen
655f9b50ae Merge pull request #18309 from overleaf/mj-add-comment-resolved
[overleaf-editor-core] Omit resolved: false for comments serialisation

GitOrigin-RevId: 909f20efd8f3c3e50d40e09366951d317a4c31bf
2024-05-16 08:04:46 +00:00
Davinder Singh
37bf30be2c Merge pull request #18155 from overleaf/ds-fix-register-form-top-padding
Website redesign- Newly designed register page fixing top padding fix

GitOrigin-RevId: 20277191b64ec20765e8d9e911be00b1dc535603
2024-05-16 08:04:23 +00:00
CloudBuild
424348724d auto update translation
GitOrigin-RevId: 9c3e8b50667df6c99223e7ef4c8eb2f8d4ff7573
2024-05-15 08:05:36 +00:00
Rebeka Dekany
ea826658a0 Merge pull request #18127 from overleaf/rd-bs-modal
[web] - Migrate the Modal to Bootstrap 5 on the Account Settings page

GitOrigin-RevId: 90799125f837742b4887eab762ca9ff84a67e70b
2024-05-15 08:05:32 +00:00
Rebeka Dekany
3ef06d57c6 Merge pull request #18256 from overleaf/rd-a11y-form
[web] Create accessibility survey link on the project dashboard

GitOrigin-RevId: 49503da67347c9e0e15a10f041252f25f0effc15
2024-05-15 08:05:28 +00:00
M Fahru
5c44fb8e9d Merge pull request #18281 from overleaf/mf-decaffeinate-server-admin-controller
[web][admin panel] Decaf cleanup of AdminController

GitOrigin-RevId: fca50565e140435b833c303d2a0dfac7449c3e17
2024-05-15 08:05:24 +00:00
M Fahru
ec1ab82789 Merge pull request #17479 from overleaf/mf-clean-up-plans-styling
[web] Clean up plans page styling

GitOrigin-RevId: fe05e9a1fd6c29c62941c878fe5e676d062c37de
2024-05-15 08:05:20 +00:00