Commit graph

1348 commits

Author SHA1 Message Date
Jakob Ackermann
1c529d5dcf Merge pull request #10339 from overleaf/as-fix-switch-back
Fix bug in CM6 switch away survey where going back from Ace to CM6 will still show the survey

GitOrigin-RevId: 5900fafb1a4a5fab7d949b1c70af31e19a764e6e
2022-11-08 09:04:38 +00:00
Jakob Ackermann
618d41f623 Merge pull request #10316 from overleaf/mj-cm6-outline-debouncing
[cm6] Debounce EditorState in CM6 outline

GitOrigin-RevId: 759748f1d3dabbe22dc0cd2d3d989c973753442a
2022-11-08 09:04:25 +00:00
Jakob Ackermann
665ab24cbd Merge pull request #10337 from overleaf/jpa-localized-network-error-messages
[web] pdf-caching: handle localize network error messages

GitOrigin-RevId: 41b0b9e87818d87d08c4cf24991751779243ae32
2022-11-08 09:04:18 +00:00
Jakob Ackermann
3db03ef678 Merge pull request #10313 from overleaf/jpa-pdf-caching-ranges-in-sentry
[web] pdf-caching: display ranges in sentry debug context

GitOrigin-RevId: d58e9c5292b1202e629c3b0706ade067c15e08a0
2022-11-08 09:04:11 +00:00
Jakob Ackermann
e9bc195483 Merge pull request #10301 from overleaf/jpa-pdf-caching-ignore-errors-for-stale-output
[web] pdf-caching: flag more errors as expected

GitOrigin-RevId: a5351db16d268bb8d9d67a86c34698c8b04f4f1a
2022-11-08 09:04:04 +00:00
Jakob Ackermann
111cce4ca4 Merge pull request #10299 from overleaf/jpa-nicer-warning-message-for-missing-pdf
[web] show a nicer warning message for missing pdf exceptions

GitOrigin-RevId: f519ec145d7ff4fe725241742fb66a1defdd257e
2022-11-08 09:03:57 +00:00
Miguel Serrano
4a3fb3344b Merge pull request #10323 from overleaf/ae-pdf-dblclick-page
Ensure only one dblclick listener is attached to a PDF page

GitOrigin-RevId: cadaa2f3bbaba8c496a6ece698b2ba7f12f340c4
2022-11-08 09:03:38 +00:00
Brian Gough
782294abae Merge pull request #10212 from overleaf/ii-dashboard-shorten-text-in-dropdowns
[web] Project dashboard add ellipsis to long text in the project filter dropdown on mobile

GitOrigin-RevId: 4b0d4e097ff0f26820c158086d8b089cbf1e364f
2022-11-07 09:03:38 +00:00
Brian Gough
db15c83c35 Merge pull request #10244 from overleaf/ii-jump-to-error
[web] Jump to error on files with double slash

GitOrigin-RevId: eec2ac6ba7a34d32f757f5e3a088e92d0d494422
2022-11-07 09:03:31 +00:00
M Fahru
b593bfa56e Don't show cm6 switch away survey if cm6 is not available
GitOrigin-RevId: e283fc424055f6df85015f02c83ad8314865697d
2022-11-04 09:06:10 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
bcad89fd28 Merge pull request #10273 from overleaf/ae-docname-apply
Add a `$scope.$applyAsync` wrapper around the "open a new document" code

GitOrigin-RevId: 7c63338379053d20bd86f10d9db6855cb5c23fc3
2022-11-04 09:05:25 +00:00
Mathias Jakobsen
50b346b4ed Merge pull request #10279 from overleaf/jpa-tracing-optimizations
[misc] do not load the tracing module unless enabled

GitOrigin-RevId: 8a3b9da3e9451e3060b852dd44e078c99cf43cfa
2022-11-04 09:05:00 +00:00
Mathias Jakobsen
aac9e6616e Merge pull request #10285 from overleaf/jpa-pdf-caching-ignore-404-from-fallback
[web] pdf-caching: double down on ignoring 404 from output.pdf requests

GitOrigin-RevId: 6b489180c221a29758b862884dae4ed6ed954a23
2022-11-04 09:04:53 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
Jakob Ackermann
986d52b8d4 Merge pull request #10274 from overleaf/jpa-pdf-caching-check-response-size
[web] pdf-caching: bailout early on unexpectedly large response size

GitOrigin-RevId: b2b1cf0abf2367ec7a7f0f5ca7a9f67a03e2fa0d
2022-11-04 09:04:02 +00:00
M Fahru
867451fa5f Add unit tests and storybook components for help menu
GitOrigin-RevId: d6f17a97d559d698461c77af3273d7d9255cdcc8
2022-11-03 09:03:56 +00:00
M Fahru
a30e934692 Migrate "help menu" in editor left menu to react
GitOrigin-RevId: 7ebbfa693205de1f57b1d54e25c46cfb1851acc8
2022-11-03 09:03:49 +00:00
Jakob Ackermann
28c1cc2ea9 Merge pull request #10218 from overleaf/jpa-adjust-prefetching
[web] pdf-caching: try to prefetch other smaller chunks

GitOrigin-RevId: 2bf1d33d48c2026ec3794baaaef8346dc9104db3
2022-11-02 09:05:04 +00:00
Jakob Ackermann
6f00659865 Merge pull request #10246 from overleaf/jpa-pdf-caching-object-id-back-fill
[web] pdf-caching: double down on back-filling of object-id

GitOrigin-RevId: 751392dc5ed59eb621eca3813040c7b92ef1369e
2022-11-02 09:04:57 +00:00
Jessica Lawshe
24dc307d7c Merge pull request #10248 from overleaf/jel-add-switch-import
[web] Add switch import to new CSS build

GitOrigin-RevId: 800a5305432baf98e29d5c9ecd652e3ce806a79c
2022-11-02 09:04:36 +00:00
Jessica Lawshe
c021b48824 Merge pull request #10073 from overleaf/jel-cleanup-imports
[web] Design system updates

GitOrigin-RevId: d5a9d8736083b076474e2a43f0200a6419f24a92
2022-11-02 09:04:29 +00:00
Jakob Ackermann
85547ffe40 Merge pull request #10234 from overleaf/jpa-pdf-caching-ignore-404
[web] pdf-caching: stop counting 404s on the output.pdf as failure

GitOrigin-RevId: eb76570fdce3dd79b8e0ea961722e428446672ac
2022-11-02 09:04:21 +00:00
Tim Down
cd60d6719a Merge pull request #10067 from overleaf/ds-design-segmented-control
Changed the css for segmented toggle switch animation

GitOrigin-RevId: e3c0dc496be9fedea5d9463f57b9844991f0c0eb
2022-11-02 09:04:14 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
2022-11-02 09:04:07 +00:00
Tim Down
a320982f79 Merge pull request #10235 from overleaf/td-cm6-lag-metrics
Add CM6 typing lag metrics

GitOrigin-RevId: 7068647a28980d888ecb5a0203f0a3563ce4c713
2022-11-02 09:03:59 +00:00
Tim Down
2bb8bd6f14 Merge pull request #10196 from overleaf/ta-galileo-instruction-modal
Add Galileo Instruction Modal

GitOrigin-RevId: c6eb9465c9a90b7b6fb681537bf2851a4570b397
2022-11-02 09:03:46 +00:00
ilkin-overleaf
641db6b8d9 Merge pull request #10184 from overleaf/ii-ignore-received-chat-messages-test
[web] Outdated chat context tests for receiving messages

GitOrigin-RevId: c91cda5ada1c0ef26d41589cdbee31a8afd1e36a
2022-11-01 09:05:17 +00:00
ilkin-overleaf
feb5ae56f5 Merge pull request #10152 from overleaf/ii-settings-sso-unescape-characters
[web] Settings page incorrect character escaping

GitOrigin-RevId: 3bd27a905394d5476487038b4d30ed208d6901ac
2022-11-01 09:05:09 +00:00
ilkin-overleaf
7180ee8700 Merge pull request #10132 from overleaf/ii-dashboard-are-you-affiliated-migration
[web] Project dashboard are you affiliated migration

GitOrigin-RevId: 455ad915dd023c5fab3ce9a5165aa7e960915f1f
2022-11-01 09:05:02 +00:00
Simon Detheridge
3d9c8f80f4 Merge pull request #10227 from overleaf/spd-td-opentelementry
Add opentelemetry to dev environment

GitOrigin-RevId: 31a8234197337a264412b411429692525793c8b0
2022-11-01 09:04:53 +00:00
Alf Eaton
5b9261e13e Dispatch doc:changed and doc:saved events in a debounced timeout (#10024)
GitOrigin-RevId: a55602b448d8b97f224c658fee0a97d2473f8cd1
2022-11-01 09:04:45 +00:00
Jakob Ackermann
79e6fecc4a Merge pull request #10231 from overleaf/jpa-pdf-caching-bounds-debug
[web] pdf-caching: debug bounds when reassembling the range from chunks

GitOrigin-RevId: 11871241d07880ebd2659cc5d0feb1f2c29014b6
2022-11-01 09:04:12 +00:00
Tim Down
3dbcc03db2 Merge pull request #10063 from overleaf/td-extra-editing-session-metrics
Add extra editing session metrics

GitOrigin-RevId: d382719364e9fe029cd664e77608faa50204e0e0
2022-10-31 09:04:04 +00:00
Miguel Serrano
b299ccf139 Merge pull request #10191 from overleaf/msm-new-joiner-survey
Banner to recruit new joiners for survey

GitOrigin-RevId: f901818cb428f0338de55655885eb8b54e702268
2022-10-28 08:05:22 +00:00
M Fahru
b85ae6e58e Migrate actions menu in editor left menu to react (#10102)
* Migrate actions menu in editor left menu to react

* Move margin from inline style to css file

* remove focus selector to avoid "highlighting" the button after closing modal and regain focus

* Add disabled state on word count button when the compiling is loading or failed

* Use div instead of button for disabled word count button

* Add accessibility text props when LeftMenuButton is disabled

* Add actions menu test cases and storybook components

* use util assign function and wrap function prop in usecallback

GitOrigin-RevId: 81ab104be21fbcf5dfbc72c07d29eeb32976c61f
2022-10-28 08:05:14 +00:00
M Fahru
d98e32f38a Remove unused class selector.
This is an artefact and should have been removed when we removed the rich text survey component.

GitOrigin-RevId: cdda625b02328b8c300a91178733321ecfcd7290
2022-10-28 08:05:07 +00:00
Jakob Ackermann
a0c180d133 Merge pull request #10156 from overleaf/jpa-web-disable-prefetch
[web] pdf-caching: double down on disabling of prefetching

GitOrigin-RevId: 60ccea883786bad306a747b5a182982bc648bbbd
2022-10-26 08:04:13 +00:00
Miguel Serrano
c30f887727 Merge pull request #9936 from overleaf/msm-itm-referrer
`itm_referrer` for subscription attribution

GitOrigin-RevId: 2787b55e8b7e9e415e66abef8deb669f3adf0f0d
2022-10-26 08:03:52 +00:00
Jakob Ackermann
956cacaef7 Merge pull request #10139 from overleaf/jpa-split-test-min-chunk-size
[misc] add split test for a per request pdfCachingMinChunkSize

GitOrigin-RevId: 6a8a3c6267501789f2047a67b03db6ac6df427c3
2022-10-26 08:03:39 +00:00
Jakob Ackermann
abaecac268 Merge pull request #10007 from overleaf/jpa-pdf-caching-latency-compute
[web] collect latencyCompute metric from pdf-caching

GitOrigin-RevId: f20fa2b54078a7106b2413432c4f47375878a5d6
2022-10-26 08:03:31 +00:00
M Fahru
797b9b2532 Migrate download menu in editor left menu to react (#10046)
* Initialize left menu react migration and migration download menu UI to react

* Add test case to DownloadMenu react component

* Update test description and add an href check to one of the download link

* Extract storybook document mock to its own fixture file

* Add mockCompileOnLoad config on storybook editor scope
  - if mockCompileOnLoad: true (default), then the default compile mock will be used
  - If mockCompileOnLoad: false, then we have to provide a compile mock on the storybook component

* Create download menu storybook component

* Use a single "editor-left-menu" controller on the editor left menu migrations

* Remove the form import from the react version of the left menu

* Change inline style to utility class name

GitOrigin-RevId: 5357c7bfc78bf40f52b9b308df8f2b60d793fbf7
2022-10-25 08:04:19 +00:00
Jessica Lawshe
58ba814cd1 Merge pull request #10114 from overleaf/jel-dash-survey-container
[web] Fix desktop dash survey container click behavior

GitOrigin-RevId: 9e94ee572e348fca1f950698dd5a7449195a52da
2022-10-25 08:04:12 +00:00
Jessica Lawshe
c110e21abf Merge pull request #10072 from overleaf/jel-start-new-css
[web] Copy variable files for new CSS entrypoints

GitOrigin-RevId: 18cf84b9ddc3ce91ae1cb62b14245f6e0226a70e
2022-10-25 08:04:04 +00:00
Jessica Lawshe
ebed539e6d Merge pull request #10045 from overleaf/jel-new-css
[web] Load new CSS if split test enabled

GitOrigin-RevId: 87ef524affa58d931b622d2f70ca6dcff7adc53c
2022-10-25 08:03:57 +00:00
ilkin-overleaf
3cccec6d48 Merge pull request #10105 from overleaf/ii-rich-text-scroll-bar
[web] Scroll bar invisible in rich text mode

GitOrigin-RevId: 48ffabb207dbecf73eb6b00b2cf5b6047d9539a7
2022-10-24 08:03:07 +00:00
ilkin-overleaf
82c6484ca1 Merge pull request #10089 from overleaf/ii-project-list-provider-effects-refactoring
[web] Projects list provider refactoring

GitOrigin-RevId: e53fcdd32e5493d438d46f4a1bbca049a1967f5c
2022-10-24 08:03:04 +00:00
ilkin-overleaf
f8e98cd5c6 Merge pull request #10030 from overleaf/ii-dashboard-survey-react-mobile-view
[web] Project dashboard survey mobile view

GitOrigin-RevId: 19612f75a9987625f10626f5f9ea9b53321d5fe2
2022-10-24 08:02:59 +00:00
ilkin-overleaf
be000f2572 Merge pull request #10013 from overleaf/ii-dashboard-upgrade-button-tracking-data
[web] Project dashboard upgrade button tracking adjustments

GitOrigin-RevId: 8ec7b1a0914db8e167ec0af49f5d4ebd0e23280f
2022-10-24 08:02:57 +00:00
Tim Down
bfb8aaffdd Merge pull request #10040 from overleaf/td-cm6-count-inputs-between-dom-updates
Record the maximum number of user input events between CM6 DOM updates

GitOrigin-RevId: 1a779a7d8e3675447cf58e2840afd0781bdc6ab9
2022-10-21 08:03:53 +00:00