Commit graph

261 commits

Author SHA1 Message Date
Alf Eaton
139fde750a Add feedback link in spelling suggestion footer (#20867)
GitOrigin-RevId: 3bef428f810b88f56a76e3645cebcf22dd5ad9e3
2024-10-14 11:05:21 +00:00
David
175a4d024d Merge pull request #20805 from overleaf/dk-fix-focus-highlight
Fix focus highlight decoration for new review panel

GitOrigin-RevId: c69ba8dd8527b6c3797b1e986cfd87c1ca87da6d
2024-10-14 11:02:55 +00:00
David
b2dab4b1c0 Merge pull request #20709 from overleaf/dp-search-wrapping
Wrap search controls on small editor widths

GitOrigin-RevId: 513d046ba2951daf13385f48b73704e6feccd7d0
2024-10-14 11:02:40 +00:00
Alf Eaton
df6147bb4d Convert PDF.js code to TypeScript
GitOrigin-RevId: 840bc48816d78497131b927522b4f6f7940bb0c4
2024-10-14 11:00:45 +00:00
David
2117bfe29d Merge pull request #20541 from overleaf/dk-delete-widgets
Handle highlight/focus effects for track deletes in new review panel

GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
David
46198cd780 Merge pull request #20688 from overleaf/dk-fix-wrong-rangesdata
Fix "RangeError" when switching files using new review panel

GitOrigin-RevId: 399c8722584053c62acf5c413572fbbcdd1896cc
2024-10-14 10:59:33 +00:00
David
13545140ee Merge pull request #20681 from overleaf/dp-highlight-height
Add padding to change highlight/focus styles

GitOrigin-RevId: 6543fe6545ff8e7baff23d5262b941a5473be19e
2024-10-14 10:59:25 +00:00
Mathias Jakobsen
aba4694377 [web] Move ARS Write and Cite behind separate feature flag (#20631)
* [web] Move ARS Write and Cite behind separate feature flag

* [web] Use isSplitTestEnabled function

* [web] Only load Write and Cite if project has ARS access

* [web] Enable Write and Cite ARS by default

* [web] Fix condition for loading write and cite ref sources

* [web] Remove references settings button in free projects

GitOrigin-RevId: c4f3b7c60da9864409c788dcf34bdc77347441a8
2024-10-14 10:59:11 +00:00
Alf Eaton
24c8629cd4 Use Hunspell for client-side spellchecking (#20286)
GitOrigin-RevId: c4d0d9e06fe0cc9d7cb7a058fd0768eb024e44f5
2024-10-14 10:58:36 +00:00
ilkin-overleaf
35728d7681 Merge pull request #20436 from overleaf/ii-bs5-editor-toolbar
[web] BS5 editor toolbar

GitOrigin-RevId: a517fd52d648d165e89231d6f5551c026a951c43
2024-10-01 08:04:42 +00:00
David
06e24c9081 Merge pull request #20606 from overleaf/dk-add-comment-on-mouseup
show Add comment button on mouse up event

GitOrigin-RevId: 2c87f11fab9f9fb7e11637bb9eac2ca1ab9b298b
2024-09-27 08:04:39 +00:00
Alf Eaton
6f8a9a0f81 [visual] Improve cursor position in empty list items (#20611)
GitOrigin-RevId: 08a83b509e217573f680ca4a635d9480ade9b1ae
2024-09-26 08:05:32 +00:00
Alf Eaton
53e46632a9 Improve editor focus events (#20263)
GitOrigin-RevId: 710f42eb633289b43858b8f283735ed0aced5c0b
2024-09-26 08:05:25 +00:00
Alf Eaton
ca72351c8e Improve detection of pasted Excel table in Safari (#20374)
GitOrigin-RevId: 92b9c485b57f753f4fe161e582817f72244436e1
2024-09-26 08:05:21 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
David
9cf94e57d3 Include \def, \let, \newenvironment and \renewenvironment commands in the math preview (#20197)
* Include \def commands in command definitions

* Allow command name to be in CtrlSym

* Pull nodeIntersectsChange check out of branches

* Fix \def handling

* Add handling for \newenvironment and \renewenvironment

* Allow \def to have optional arguments

* :x
Revert "Add handling for \newenvironment and \renewenvironment"

This reverts commit a70d3a0a13ed552daf3b761893e3f8609f0b0fc8.

* Add let commands to defintions

* Add environment names to math preview

* Ignore let command definitions in autocomplete

* Move nodeIntersectsChange check back into each block

* Add childOfNodeWithType utility and use to get command names

* commandNameText -> commandName

* Only include environment definitions

* Rename documentEnvironmentNames to documentEnvironments

* EnvironmentName -> Environment

* Format

GitOrigin-RevId: 9c5d701423ae786e5ff91960b4bcd94cd35d21c8
2024-09-17 08:04:53 +00:00
Alf Eaton
0230a296ac Remove underline from lint range highlight (#20243)
GitOrigin-RevId: 29c91fa8297cb92ceba3a088bff22c847b73455d
2024-09-13 08:05:05 +00:00
Alf Eaton
0e40011e14 Remove setTimeout from spell check results dispatch (#20342)
GitOrigin-RevId: 9973b216d60b20c2b6aaf5205c13e2db69cbd589
2024-09-13 08:04:55 +00:00
Alf Eaton
26af3e1ecf Use estimated height of math widget (#20359)
GitOrigin-RevId: b412e429b26ae51c83f84b855084b36a0015838d
2024-09-13 08:04:50 +00:00
David
565514a162 Merge pull request #20269 from overleaf/dp-single-math-tooltip
Only show single math tooltip

GitOrigin-RevId: 85608976f2dc6d15748a1bde24c837d2180d3cbe
2024-09-06 08:05:00 +00:00
David
f4c57fce4c Merge pull request #20246 from overleaf/dp-math-preview-closing-delimiter
Don't show math preview tooltip if the node has a parse error

GitOrigin-RevId: 330ebb945c70da4b5fe9ee4ee2f149a95435899b
2024-09-04 08:05:50 +00:00
David
4802d04fb0 Merge pull request #20198 from overleaf/dp-math-preview-improvements
Remove transition from math-preview tooltip to avoid flashing

GitOrigin-RevId: 004c7eeb6d4421a3d11f175a80d217356dfcb2da
2024-09-04 08:05:46 +00:00
Alf Eaton
abfa29e629 Ensure that the correct lines are spell-checked (#19967)
GitOrigin-RevId: f63601288821d37bddcddc776270263e291d3985
2024-09-04 08:04:53 +00:00
Alf Eaton
607b3e3494 feat: making highlighting of errors more specific (#19963)
GitOrigin-RevId: 63bc147e18e80c1e070722bc70114f8fca8509ae
2024-09-04 08:04:48 +00:00
Eric Mc Sween
8b4b454b97 Merge pull request #20052 from overleaf/em-tracked-deletes-limit
Include tracked deletes when limiting document size

GitOrigin-RevId: 9d7b2870001fb942eaa92db78993fee1ddb3937c
2024-08-27 08:04:31 +00:00
Domagoj Kriskovic
cab58d87dd extracted rejectChanges to a separate file
GitOrigin-RevId: 83c55c4823f6e18f22dbd6bc1fa7ec010c509e30
2024-08-26 08:05:10 +00:00
Domagoj Kriskovic
ea20f82ad6 remove callout widget from ranges extension
GitOrigin-RevId: fa7f36cb0270228b57162404ce5a17523790e396
2024-08-26 08:05:06 +00:00
Domagoj Kriskovic
be47b27d98 remove clearChanges and buildChanges effects from ranges extension
GitOrigin-RevId: 4782725bfaf50153007bbd9ae5c8146cca769cde
2024-08-26 08:05:01 +00:00
Domagoj Kriskovic
dc70054caf trackDetachedComments as separate extension
GitOrigin-RevId: 8039de3f9766b072e9bb2170b50e683073105748
2024-08-26 08:04:56 +00:00
Domagoj Kriskovic
ec6b17eb01 revert trackChanges extension to a version before redesign
GitOrigin-RevId: fc12968a3971cfee7594720076bb4dc271178e73
2024-08-26 08:04:52 +00:00
Domagoj Kriskovic
6547ce6aa1 remove updateRangesEffect and rejectChanges from trackChanges extension
GitOrigin-RevId: b93751421d235fd61a80ce64f47aec7998e4f6cf
2024-08-26 08:04:47 +00:00
Domagoj Kriskovic
3bdfd36613 copied track-changes.ts extension
GitOrigin-RevId: 95e383223c6e4e7a10112ebfaff4d3bda9530a01
2024-08-26 08:04:43 +00:00
David
93ba9fa28a Merge pull request #20001 from overleaf/dp-math-preview-split-test-badge
Add split test badge to math preview tooltip

GitOrigin-RevId: 9dfd30502f4b023bc7f640660904b0d3e7f4ce62
2024-08-20 08:04:31 +00:00
Alf Eaton
acba1b8956 Rebuild review panel entries when the editor viewport changes (#19962)
GitOrigin-RevId: af144a278a3338bffb58e40a91ddbeb204959dee
2024-08-16 08:04:27 +00:00
Jimmy Domagala-Tang
b3d9ea5ad3 Merge pull request #19966 from overleaf/revert-19424-jdt-batch-spelling-line-tracker-updates
Revert "Line changes spread into array (avoiding max call stack)"

GitOrigin-RevId: 5039d4182aeeb5d8c3aed13af45af177755a3823
2024-08-15 08:06:03 +00:00
Jimmy Domagala-Tang
cb6deab3a9 Merge pull request #19424 from overleaf/jdt-batch-spelling-line-tracker-updates
Line changes spread into array (avoiding max call stack)

GitOrigin-RevId: a60520b2aff18603bfe96b92abf305576661223a
2024-08-15 08:05:49 +00:00
Alf Eaton
2304536844 Add review panel context providers and components (#19490)
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
2024-08-13 08:04:20 +00:00
Alf Eaton
6ec26060e4 Move updateListener out of sourceOnly wrapper (#19573)
GitOrigin-RevId: 3633b7c9763eac05793c2099124bd78369f90a73
2024-08-07 08:05:50 +00:00
David
d2289379cd Merge pull request #19633 from overleaf/dp-tooltip-colour
Update styling for math-preview tooltip in dark editor themes

GitOrigin-RevId: bfd02793d1438cfeee173210f57b1fbb4c28ccc3
2024-08-06 08:05:16 +00:00
Alf Eaton
603ff28df0 Add text formatting commands to the LaTeX grammar (#19607)
GitOrigin-RevId: f69cd323992c80de3f0a458a637fa8f160017076
2024-08-02 08:06:11 +00:00
Jimmy Domagala-Tang
91125f8b1c Merge pull request #19639 from overleaf/jdt-line-tracker-max-callstack-event
Adding events to line-tracker

GitOrigin-RevId: 97601af3c332244d10a3e97eb22a80a0eb240ad3
2024-07-31 08:05:41 +00:00
Alf Eaton
e4d971151b [visual] Add coordsAt to decoration widgets (#19577)
GitOrigin-RevId: d445e68a14bbe819e126b6bf6a2328a00520c39a
2024-07-30 08:05:17 +00:00
Alf Eaton
4af10054df Ensure that the visual editor recognises a "drop" event as a "mouseup" (#19560)
GitOrigin-RevId: 967d3c80a1501ffdfe9a7e3e978cba746a54d7b3
2024-07-30 08:05:08 +00:00
David
72c7b946ed Merge pull request #19617 from overleaf/dp-tooltip-alignment
Always render math preview tooltip at start of math content

GitOrigin-RevId: b0af7aa3c0920b2a9b9930f27a580018de1d2f52
2024-07-29 08:04:36 +00:00
David
c07d2f3fa2 Merge pull request #19528 from overleaf/dp-equation-preview
Equation Preview

GitOrigin-RevId: 98e71e5d2c1a83d6c9fa685eeee1f4b93a5a3da1
2024-07-25 08:05:04 +00:00
Mathias Jakobsen
f4896b2152 Merge pull request #19512 from overleaf/mj-def-mathjax
[web] Pass def, let, and (re)newenvironment to mathjax

GitOrigin-RevId: b79b656024bcaddd1bd96a4b9ed297de2de043e3
2024-07-24 08:04:58 +00:00
Alf Eaton
66c55b0647 Streamline the project references context provider (#19387)
GitOrigin-RevId: 9af00459ec121a605b84809b349a0bc258896048
2024-07-16 08:04:30 +00:00
Alf Eaton
2d2746ef24 Streamline the project metadata context provider (#19384)
GitOrigin-RevId: 0b75635cb9141983827dfd0fa6a58b6182d47f22
2024-07-15 09:32:59 +00:00
Mathias Jakobsen
80a6280231 Merge pull request #19253 from overleaf/mj-bibtex-linter
[cm6] Add bibtex linter for missing keys in entries

GitOrigin-RevId: fac79cab6420e10bfb1316262a1d0217515503f4
2024-07-15 09:01:21 +00:00