github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-16 19:51:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #19966 from overleaf/revert-19424-jdt-batch-spelling-line-tracker-updates

Browse source 
Revert "Line changes spread into array (avoiding max call stack)"

GitOrigin-RevId: 5039d4182aeeb5d8c3aed13af45af177755a3823
This commit is contained in:
Jimmy Domagala-Tang 2024-08-14 14:49:40 -04:00 committed by Copybot
parent 5065bb78ea
commit b3d9ea5ad3
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
services/web/frontend/js/features/source-editor/extensions/spelling/line-tracker.ts
View file

@ -113,14 +113,18 @@ export class LineTracker {
*/
const changes = new Array(insertedText.lines).fill(true)
const index = startLine - 1 + lineShift
try {
this._lines.splice(startLine - 1 + lineShift, 1, ...changes)
lineShift += changes.length - 1
} catch (error) {
if (error instanceof RangeError) {
throw new OError(error.message).withInfo({
changesSize: changes.length,
})
}
this._lines = [
...this._lines.slice(0, index),
...changes,
...this._lines.slice(index + 1),
]
lineShift += changes.length - 1
throw error
}
}
}
)