Move updateListener out of sourceOnly wrapper (#19573)

GitOrigin-RevId: 3633b7c9763eac05793c2099124bd78369f90a73

services/web/frontend/js/features/source-editor/extensions/index.ts

@@ -112,7 +112,7 @@ export const createExtensions = (options: Record<string, any>): Extension[] => [
   theme(options.theme),
   realtime(options.currentDoc, options.handleError),
   cursorPosition(options.currentDoc),
-  scrollPosition(options.currentDoc),
+  scrollPosition(options.currentDoc, options.visual),
   cursorHighlights(),
   autoPair(options.settings),
   editable(),

services/web/frontend/js/features/source-editor/extensions/scroll-position.ts

@@ -7,7 +7,7 @@ import {
   Text,
   TransactionSpec,
 } from '@codemirror/state'
-import { toggleVisualEffect } from './visual/visual'
+import { sourceOnly, toggleVisualEffect } from './visual/visual'
 import { debugConsole } from '@/utils/debugging'
 
 const buildStorageKey = (docId: string) => `doc.position.${docId}`
@@ -23,11 +23,14 @@ type LineInfo = {
  *    or the window is closed, or when switching between Source and Rich Text, and
  * b) dispatches the scroll position (middle visible line) when it changes, for use in the outline.
  */
-export const scrollPosition = ({
-  currentDoc: { doc_id: docId },
-}: {
-  currentDoc: { doc_id: string }
-}) => {
+export const scrollPosition = (
+  {
+    currentDoc: { doc_id: docId },
+  }: {
+    currentDoc: { doc_id: string }
+  },
+  { visual }: { visual: boolean }
+) => {
   // store lineInfo for use on unload, when the DOM has already been unmounted
   let lineInfo: LineInfo
 
@@ -90,6 +93,26 @@ export const scrollPosition = ({
         },
       }
     ),
+
+    // restore the scroll position when switching to source mode
+    sourceOnly(
+      visual,
+      EditorView.updateListener.of(update => {
+        for (const tr of update.transactions) {
+          for (const effect of tr.effects) {
+            if (effect.is(toggleVisualEffect)) {
+              if (!effect.value) {
+                // switching to the source editor
+                window.setTimeout(() => {
+                  update.view.dispatch(restoreScrollPosition())
+                  update.view.focus()
+                })
+              }
+            }
+          }
+        }
+      })
+    ),
   ]
 }
 

services/web/frontend/js/features/source-editor/extensions/visual/visual.ts

@@ -85,23 +85,6 @@ export const sourceOnly = (visual: boolean, extension: Extension) => {
       }
       return null
     }),
-
-    // restore the scroll position when switching to source mode
-    EditorView.updateListener.of(update => {
-      for (const tr of update.transactions) {
-        for (const effect of tr.effects) {
-          if (effect.is(toggleVisualEffect)) {
-            if (!effect.value) {
-              // switching to the source editor
-              window.setTimeout(() => {
-                update.view.dispatch(restoreScrollPosition())
-                update.view.focus()
-              })
-            }
-          }
-        }
-      }
-    }),
   ]
 }
 

services/web/test/frontend/features/source-editor/extensions/scroll-position.test.ts

@@ -66,7 +66,7 @@ describe('CodeMirror scroll position extension', function () {
     const view = new EditorView({
       state: EditorState.create({
         doc,
-        extensions: [scrollPosition({ currentDoc })],
+        extensions: [scrollPosition({ currentDoc }, { visual: false })],
       }),
     })
 
@@ -102,7 +102,7 @@ describe('CodeMirror scroll position extension', function () {
     const view = new EditorView({
       state: EditorState.create({
         doc,
-        extensions: [scrollPosition({ currentDoc })],
+        extensions: [scrollPosition({ currentDoc }, { visual: false })],
       }),
     })
     view.dispatch(restoreScrollPosition())