github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-18 00:41:23 -05:00
Code Issues Projects Releases Packages Wiki Activity
4865 commits 3 branches 7 tags 206 MiB
Commit graph

1900 commits

Author SHA1 Message Date
Shane Kilkelly
c9678ad699 Trigger autocomplete with Shift-Space, in addition to existing triggers 2017-06-28 15:24:37 +01:00
Paulo Reis
9ffec6eb16 Correctly access response parameters. 2017-06-26 10:00:47 +01:00
Paulo Reis
33be384206 Avoid implicitly returning from a directive controller constructor function. 2017-06-21 16:00:56 +01:00
Paulo Reis
ddee75e479 Use a getterSetter to manage int values in settings. 2017-06-20 17:08:53 +01:00
Paulo Reis
669c705d32 Also refactor signatures from methods wrapping the HTTP service. 2017-06-20 16:27:05 +01:00
Paulo Reis
3dda383d70 Use promise method signatures, instead of old HTTP service ones. 2017-06-20 16:04:06 +01:00
Paulo Jorge Reis
2dda430691 Merge pull request #522 from sharelatex/bg-hide-textlayer-for-performance 
set text layer to display:none for faster scroll
 2017-06-20 13:58:20 +01:00
Shane Kilkelly
8b7a1bd4d9 Merge branch 'sk-labels-ac-debounce' 2017-06-20 13:53:23 +01:00
Paulo Reis
155f515a50 Use standard promises with the http service. 2017-06-20 11:50:23 +01:00
Shane Kilkelly
3d2d7652c6 Simplified and faster blanking 2017-06-20 08:46:47 +01:00
Shane Kilkelly
b4e2dcf7ef Match prefixes of ref and cite up to 16 characters 2017-06-20 08:46:28 +01:00
Shane Kilkelly
a299af12e8 Remove debug helper 2017-06-20 08:46:18 +01:00
Shane Kilkelly
85ddff15cb Move command-matching regex to the class level 2017-06-16 10:20:55 +01:00
Shane Kilkelly
0163ffc4bd Extend, and clean up the command-matching regex 2017-06-16 10:17:30 +01:00
Shane Kilkelly
1d905bd5ff Clean up string replacement 2017-06-16 09:49:16 +01:00
Shane Kilkelly
d9aff3c3f4 Blacklist more commands 2017-06-16 09:41:40 +01:00
Shane Kilkelly
a1d2d5b313 WIP: blank out label commands before running spell-check 2017-06-16 09:20:35 +01:00
Paulo Reis
af2cbf5a51 Force return true on a jquery handler; returning falsy values may have unexpected results. 2017-06-15 16:17:21 +01:00
Paulo Reis
fcf0a96933 Use selection.isCollapsed to check for empty selections. 2017-06-15 16:16:30 +01:00
Brian Gough
503822deb0 avoid possible exception if selection is undefined 
defensive programming only
 2017-06-15 14:32:00 +01:00
Brian Gough
b9804823f3 handle off-screen selection 
when toggling the logs button the selection is off-screen and
selection.toString() is empty even when there is a selected range.  Can
check for selection.type being "Range" instead.
 2017-06-15 14:21:42 +01:00
Brian Gough
b04288ed44 avoid getting duplicate handlers for mouseup 2017-06-15 14:21:42 +01:00
Shane Kilkelly
403d822174 Alter labels debouncer to handle transitions between docs 2017-06-15 14:09:49 +01:00
Brian Gough
76dcde4dae hide the text layer on reload 2017-06-15 13:42:19 +01:00
Paulo Reis
fbaa918927 Do not show the text layer when the user clicks outside pages. Remove some debug statements. 2017-06-15 12:32:04 +01:00
Paulo Reis
4985f7ca1c Different approach: render all text layers while selecting (WIP). 2017-06-15 12:32:04 +01:00
Paulo Reis
786659dc1b Render text layer on hovered pages (and adjacent ones). 2017-06-15 12:32:04 +01:00
Shane Kilkelly
69471c4f74 Remove old references to services/labels 2017-06-15 09:27:00 +01:00
Shane Kilkelly
b0bb4b3e47 Merge branch 'sk-ref-variants' 2017-06-15 09:17:48 +01:00
Shane Kilkelly
9607174b64 Merge branch 'master' into sk-server-side-labels-loading 2017-06-15 08:49:14 +01:00
Shane Kilkelly
3f1a440d66 Support variations of \ref{}, such as \cref{}, \eqref{}, etc.. 2017-06-14 15:15:07 +01:00
Shane Kilkelly
b0ff8e0745 Fix a typo: prefxi => prefix 2017-06-14 15:14:38 +01:00
Shane Kilkelly
5e37b1dac1 Move logic for selectively loading labels. 
Only load labels if the user has write permission
 2017-06-14 13:26:02 +01:00
Brian Gough
e1efc3a7b5 Merge pull request #521 from sharelatex/bg-reduce-pdf-memory-usage 
Revert "use a single pdfjs worker, rotated to avoid leaks"
 2017-06-13 16:46:58 +01:00
Shane Kilkelly
3b066758bb Don't load labels for anonymous/read-only users 2017-06-13 14:06:00 +01:00
Shane Kilkelly
954c53aec6 Move the labels event logic into ide/labels/LabelsManager 2017-06-13 13:29:03 +01:00
Shane Kilkelly
a04eb1197d Move labels service to /ide/labels/services/labels 2017-06-13 11:43:25 +01:00
Shane Kilkelly
b97becc7a2 Change getLabelsForDoc to broadcastLabelsForDoc 2017-06-13 11:38:15 +01:00
Shane Kilkelly
c25b6b792d Namespace the document route under /doc/ 2017-06-13 10:57:51 +01:00
Shane Kilkelly
d1a85304d2 Add comment 2017-06-12 15:47:31 +01:00
Shane Kilkelly
debb0c06a4 Clearer logic for triggering labels-loading 2017-06-12 14:23:29 +01:00
Shane Kilkelly
ff4991284d Change docLabelsUpdated socket event to broadcastDocLabels 2017-06-12 13:06:56 +01:00
Shane Kilkelly
234a2d0e21 Remove cruft 2017-06-12 11:37:34 +01:00
Shane Kilkelly
1bb065344c Move labels into an Angular Service 2017-06-12 09:44:32 +01:00
Shane Kilkelly
56385a798b Use ide.$http, rather than jquery 2017-06-09 11:41:35 +01:00
James Allen
7137ab643f Merge pull request #523 from sharelatex/ja-removing-group-holding-accounts 
Use an email based invite system for groups, not holding accounts
 2017-06-09 11:36:42 +01:00
Shane Kilkelly
5443b92e7d Move state management into LabelsMaster on the ide 2017-06-09 11:28:27 +01:00
James Allen
ba3822d1ae Encode email for URL when deleting invited group email 2017-06-09 10:39:48 +01:00
James Allen
69bc6fc8e4 Maintain backwards compatibility with old holding accounts in removal end points 2017-06-08 16:53:22 +01:00
Shane Kilkelly
965a46291b Only fetch labels for uploaded docs, not files 2017-06-08 15:55:17 +01:00
Shane Kilkelly
ff7955dfdb Update labels when docs are uploaded or removed 2017-06-08 15:12:18 +01:00
James Allen
4cecbae6b6 Use an email based invite system for groups, not holding accounts 2017-06-08 12:12:08 +01:00
Shane Kilkelly
c7dbd21cd1 use flag on aceEditor to enable autocomplete features 2017-06-08 09:22:08 +01:00
Paulo Reis
240d6d6f6b Resolve timing issue when triggering selection-related logic. 2017-06-07 14:21:05 +01:00
Paulo Reis
53b18e041f Trigger selection-related logic after accepting or rejecting changes. 2017-06-07 14:03:58 +01:00
Brian Gough
aa8974dcd6 Revert "use a single pdfjs worker, rotated to avoid leaks" 
This reverts commit f270ef54911acd800d2ffd577080b50ea2fe4aff.

Use a new worker on each reload to free up memory.
 2017-06-07 13:29:10 +01:00
Paulo Reis
19ecffd654 Merge branch 'master' into pr-aggregate-insert-delete 2017-06-06 17:04:31 +01:00
Paulo Reis
34796b18c5 Add translation keys. 2017-06-06 16:46:36 +01:00
Paulo Reis
afa011c813 Avoid flickering when elements enter the review panel. 2017-06-06 16:11:00 +01:00
Paulo Reis
73a67c6617 Add a note on the need of reverse sorting changes when rejecting. 2017-06-06 13:34:48 +01:00
Paulo Reis
4504f77aa3 Do bulk rejects in reverse order. 2017-06-06 12:06:43 +01:00
Paulo Reis
81a5a5311d Clear selection after bulk actions. 2017-06-06 10:03:33 +01:00
Paulo Reis
5a75663a0c Do bulk rejects in reverse order. 2017-06-05 17:17:47 +01:00
Paulo Reis
e616a62d68 Save entry ids inside entry object, not only as the key. 2017-06-05 16:29:55 +01:00
Shane Kilkelly
f7ad4a4786 WIP: basically working, with client sync 2017-06-05 14:48:50 +01:00
James Allen
cb1745a1e6 Fix redirect in clone project modal 2017-06-05 13:33:32 +01:00
James Allen
d7981fd2d4 Merge pull request #512 from sharelatex/ja-project-name-validation 
Refactor project name validation into one place and restrict /s
 2017-06-05 11:55:39 +01:00
Shane Kilkelly
51881dbbcc Only load labels from current doc if change is local 2017-06-05 11:09:58 +01:00
Paulo Reis
6c3cdbcc3a Remove dead code, backend does not send single change events anymore. 2017-06-05 10:43:03 +01:00
Paulo Reis
8d8bcab1e8 Consolidate change accept and reject code. 2017-06-05 10:41:59 +01:00
Shane Kilkelly
4cb41a988a WIP: initial work on server-side labels 2017-06-02 15:12:59 +01:00
Paulo Reis
e2edf4184f Explicit naming. 2017-06-02 11:43:43 +01:00
Shane Kilkelly
51e3a6b3a3 Don't use String.startsWith, use slice instead. 
- String.startsWith is not supported in IE
 2017-06-02 09:54:48 +01:00
Paulo Reis
26260fc11f Prevent aggregation of changes from different users. 2017-06-01 16:33:50 +01:00
Paulo Reis
b2a7686204 DRYness. 2017-06-01 15:28:37 +01:00
Paulo Reis
2a0454f2f1 Integrate aggregate changes with bulk actions. 2017-06-01 15:18:43 +01:00
Paulo Reis
1490ea7b04 Change aggregated change model: the main change is now the insertion, deletion is stored in metadata. 2017-06-01 15:03:37 +01:00
Paulo Reis
11c0644490 Aggregate changes; make accept and reject work. 2017-06-01 11:47:55 +01:00
Shane Kilkelly
9a15420c4e Merge branch 'master' into sk-labels-autocomplete 2017-06-01 08:34:56 +01:00
Paulo Reis
3cf8f26583 Add collapse and expand behaviour to aggregate change entries. 2017-05-31 16:23:24 +01:00
Paulo Reis
a6108480f5 Add directive to show change entries. 2017-05-31 14:47:25 +01:00
Shane Kilkelly
039d18bf8b Simplify logic for deciding whether to re-scan doc on not 2017-05-26 15:08:38 +01:00
Shane Kilkelly
faf0337ca9 Refactor labels autocomplete 2017-05-26 14:56:38 +01:00
Paulo Reis
7fbf6d97bd Merge branch 'master' into pr-hide-review-panel 2017-05-26 09:39:29 +01:00
Shane Kilkelly
7923450e25 Move labelsManager into aceEditor directory 2017-05-25 09:42:07 +01:00
Shane Kilkelly
0543f32ff0 Add comment explaining debounce 2017-05-25 09:35:38 +01:00
Shane Kilkelly
ea9a0dda83 More robust change detection for autocomplete. 
- accurately detect when labels are involved in 'remove' event
 2017-05-25 09:33:15 +01:00
Shane Kilkelly
1ba8b702ad More robust regex for matching/parsing labels. 
- limit label name to max 80 characters
- don't use `.*`
- limit total labels per document to 1000
 2017-05-25 09:32:10 +01:00
Shane Kilkelly
a363b62f23 Remove periodic polling of document for labels 2017-05-25 09:31:36 +01:00
Shane Kilkelly
d0bf407515 Use coffeescript => functions, rather than self=this. 2017-05-24 15:05:53 +01:00
Shane Kilkelly
efd01081f7 Set up and automatic refresh of labels 2017-05-24 14:28:27 +01:00
Shane Kilkelly
b871cdab4c Remove debug logs 2017-05-24 14:28:15 +01:00
Shane Kilkelly
1f3a375b4e Update commentary 2017-05-24 11:42:00 +01:00
Shane Kilkelly
da84b3f31c WIP: basically working labels/ref autocomplete 2017-05-24 11:40:12 +01:00
Shane Kilkelly
17dd64f48a Merge pull request #507 from sharelatex/sk-squash-web-errors 
Squash various web errors
 2017-05-24 10:57:18 +01:00
Shane Kilkelly
c43a2087d7 WIP: autocomplete for label/ref 2017-05-24 10:07:14 +01:00
Paulo Reis
8dfb91fa6f Blur toggler after clicking. 2017-05-22 11:11:26 +01:00
James Allen
ba62206b91 Refactor project name validation into one place and restrict /s 2017-05-19 17:42:24 +01:00
Paulo Reis
58ad62c413 Relayout entries when commenting. 2017-05-19 16:57:51 +01:00
Paulo Reis
75c5bf60a8 Make hotkeys modal larger. 2017-05-19 15:51:32 +01:00
Paulo Reis
15980d5427 Merge branch 'master' into pr-hide-review-panel 2017-05-19 15:31:14 +01:00
Paulo Reis
957b201fc1 Add commenting and track-changes keyboard shortcuts. 2017-05-19 15:28:49 +01:00
Paulo Reis
e532f543a3 Merge branch 'master' into pr-bulk-actions 2017-05-18 14:38:16 +01:00
Paulo Reis
832764dd3d Add key shortcut to toggle the review panel. 2017-05-18 11:02:50 +01:00
Paulo Reis
7f3c0ed5ac Refactor accept and reject methods to support multiple changes; support bulk actions events. 2017-05-16 14:27:06 +01:00
Paulo Reis
36b4a8e6c2 Update ranges tracker. 2017-05-16 14:04:13 +01:00
Paulo Reis
ac99422c26 Update ranges tracker. 2017-05-16 14:04:06 +01:00
Paulo Reis
a3c529d23f Update range tracker with new bulk method. 2017-05-16 14:03:52 +01:00
Shane Kilkelly
ada614cc69 Check response exists before calling method 2017-05-16 09:20:12 +01:00
Paulo Reis
f4e46bb2f9 Use new ranges tracker method to get N changes at once; small refactor. 2017-05-15 11:24:40 +01:00
Paulo Reis
7bb5d65b52 Update ranges tracker. 2017-05-15 11:11:28 +01:00
Paulo Reis
82a19444b3 Merge branch 'master' into pr-bulk-actions 2017-05-15 10:29:15 +01:00
Paulo Reis
dd85c2fab2 Remove debug line. 2017-05-12 15:44:49 +01:00
Paulo Reis
658e70a772 Update ranges tracker. 2017-05-11 11:32:12 +01:00
Paulo Reis
f2dac28a65 Consolidate some watchers. 2017-05-11 10:23:41 +01:00
Paulo Reis
a3ab994ab3 Use the same watcher to control miniRP visibility and trigger Ace resizing. 2017-05-11 10:17:25 +01:00
Paulo Reis
8aee0edfe8 Integrate bulk actions dialog with controller actions. 2017-05-09 16:06:34 +01:00
Paulo Reis
f3e020df7e Add dialog to confirm bulk actions. 2017-05-09 16:06:19 +01:00
Paulo Reis
499272cbb5 Use new range-tracker method. 2017-05-08 16:12:21 +01:00
Paulo Reis
03b8b72520 Update range tracker with new bulk method. 2017-05-08 16:10:08 +01:00
Paulo Reis
3ced808411 Use a single accept changes method. 2017-05-05 15:19:31 +01:00
Paulo Reis
f25db3ff64 Reflect accepted changes on the UI layer. 2017-05-04 15:47:25 +01:00
Paulo Reis
19828d3c5b Basic bulk accept support. 2017-05-04 15:33:47 +01:00
Paulo Reis
8f6d11632b Add bulk rejection support. 2017-05-03 17:16:41 +01:00
Paulo Reis
dae66d5edf Add bulk methods in controller. 2017-05-03 17:16:29 +01:00
Paulo Reis
05d9bf47d1 Use entry ids instead. 2017-05-03 16:53:04 +01:00
Paulo Reis
bf7bf701ed Store selected entries; improve visibility logic. 2017-05-03 16:35:58 +01:00
Paulo Reis
722d75f6ef Correctly check if deletions are within selection. 2017-05-02 17:08:41 +01:00
Paulo Reis
3f441ff38c Count entries within selection; only show bulk actions if there are selected entries. 2017-05-02 17:02:30 +01:00
Paulo Reis
e2eaf6619e Bulk actions directive; include it in the review panel. 2017-05-02 16:15:40 +01:00
Paulo Reis
76ea497b33 Use a single entry for bulk actions. 2017-05-02 15:43:45 +01:00
Paulo Reis
d874eb70f8 Add and remove bulk accept and reject entries with selections. 2017-05-02 15:34:05 +01:00
Paulo Reis
d71296da9f Add row clicking in the projects list. 2017-05-01 17:11:03 +01:00
Paulo Reis
208f021bd0 Actually remove project from tag, inline. 2017-05-01 16:00:25 +01:00
Paulo Reis
6e40284099 Add untagged projects counter. 2017-04-28 16:57:37 +01:00
Paulo Reis
84a2658259 Add an untagged filter in the projects list. 2017-04-28 12:11:51 +01:00
Paulo Reis
877cd8e018 Apply stored filtering options. 2017-04-27 16:18:16 +01:00
Paulo Reis
884a89893d Save and read filtering options from local storage. 2017-04-27 16:17:28 +01:00
Henry Oswald
f5267ac6ee Merge pull request #481 from sharelatex/ja-encode-project-names 
Error if no project returned from joinProject
 2017-04-25 09:17:59 +01:00
Henry Oswald
79bc4c1d3e = != == ;) 2017-04-24 16:16:02 +01:00
Henry Oswald
c733925a26 show rate limit message when compiled too much 2017-04-24 15:56:09 +01:00
James Allen
f6bd949f01 Error if no project returned from joinProject 
socket.io seems to choke on the unicode project name and just return
undefined when it fails to parse the JSON. I've improved the escaping
of the user data on HTML load, but reporting an error is the best we
can easily do on joinProject via websockets.
 2017-04-10 12:03:39 +01:00
James Allen
477278eea5 Merge pull request #476 from sharelatex/ja-use-new-comment-button 
Fix on the new comment button variation
 2017-04-05 11:08:59 +01:00
James Allen
ce59307c91 Merge pull request #475 from sharelatex/ja-scroll-overflow-in-review-panel 
Allow scrolling in the review panel to extend outside of top of text …
 2017-04-05 11:08:49 +01:00
Shane Kilkelly
0555154a24 Merge branch 'sk-fix-folder-creation' 2017-04-04 11:01:07 +01:00
Paulo Reis
7855afa0cd Remove unused scope binding. 2017-04-04 10:48:31 +01:00
Paulo Reis
15de552c2c Make new add comment button styles as the default; removed old add comment button code. 2017-04-04 10:40:53 +01:00
James Allen
567edbfb31 Fix on the new comment button variation 2017-04-03 17:11:33 +01:00
James Allen
2fa909c707 Allow scrolling in the review panel to extend outside of top of text like Ace 2017-04-03 16:46:36 +01:00
James Allen
efac6b70f4 Merge pull request #468 from sharelatex/ja-allow-overlapping-comments 
Allo overlapping comments
 2017-04-03 14:04:14 +01:00