Commit graph

23137 commits

Author SHA1 Message Date
M Fahru
02adb4077d Merge pull request #19889 from overleaf/mf-group-member-dropdown-update-all
[web][new plans page] Synchronize all group member picker elements with the same plan type

GitOrigin-RevId: 33956784474c25383c66465da8a1025f3fe6131c
2024-08-16 08:04:31 +00:00
Alf Eaton
acba1b8956 Rebuild review panel entries when the editor viewport changes (#19962)
GitOrigin-RevId: af144a278a3338bffb58e40a91ddbeb204959dee
2024-08-16 08:04:27 +00:00
Domagoj Kriskovic
ad7abee39a Remove extra padding for off-screen review panel entries (#19841)
* Remove extra padding for off-screen review panel entries

* use document.activeElement

* cleanup editor padding cases

* using isSelectionWithinOp

* fix formatting

* focusHandler function

* 1px border for focused entry

* use constants

* using isFirstEntry

GitOrigin-RevId: 4509f803b6cb907b40f1745a6fc7f3b1edfe145c
2024-08-16 08:04:22 +00:00
Jimmy Domagala-Tang
b3d9ea5ad3 Merge pull request #19966 from overleaf/revert-19424-jdt-batch-spelling-line-tracker-updates
Revert "Line changes spread into array (avoiding max call stack)"

GitOrigin-RevId: 5039d4182aeeb5d8c3aed13af45af177755a3823
2024-08-15 08:06:03 +00:00
M Fahru
5065bb78ea Merge pull request #19904 from overleaf/ds-plans-page-new-design-adding-geo-banners
Plans page new design - Implement geo banner for India and latin america users

GitOrigin-RevId: 4b0ca2e6e290672c5ae1f41cde904a4d48197a33
2024-08-15 08:05:58 +00:00
M Fahru
50b11da587 Merge pull request #19855 from overleaf/mf-interstitial-new-plans-page-redesign
[web] Implement plans table for the new interstitial payment page

GitOrigin-RevId: 28b6a0c8c42d709d5be067d79f7f852fe188a3cf
2024-08-15 08:05:54 +00:00
Jimmy Domagala-Tang
cb6deab3a9 Merge pull request #19424 from overleaf/jdt-batch-spelling-line-tracker-updates
Line changes spread into array (avoiding max call stack)

GitOrigin-RevId: a60520b2aff18603bfe96b92abf305576661223a
2024-08-15 08:05:49 +00:00
Alf Eaton
806250a30e Refocus the PDF viewer after zooming with a keyboard shortcut (#19959)
GitOrigin-RevId: 61961ca4d5e6362923c7157296308c213649d4f3
2024-08-15 08:05:45 +00:00
Jessica Lawshe
692b3c0a2b Merge pull request #19909 from overleaf/jel-link-icon
[web] Add options for styling `Element | Link`

GitOrigin-RevId: 23db6df3b994f8106872771328b0b674a8fe381c
2024-08-15 08:05:33 +00:00
Jessica Lawshe
4b6872b737 Merge pull request #19935 from overleaf/jel-faq-plans
[web] Remove padding on inline buttons

GitOrigin-RevId: bb2f458b47d4ee48b93048490b1e60a8ff5f1ac0
2024-08-15 08:05:28 +00:00
Jessica Lawshe
ac06b0530c Merge pull request #19937 from overleaf/jel-new-period-toggle
[web] Add space between options in new plans period toggle

GitOrigin-RevId: fee13d4e933a5f2d16f14bbd1fd0b9b130a0084e
2024-08-15 08:05:24 +00:00
Jessica Lawshe
5496e13640 Merge pull request #19886 from overleaf/jel-plans-headers
[web] Separate column header pieces into new rows on new plans page

GitOrigin-RevId: db7f316ce8b7c983e7e000f95eb870962fc0bc9f
2024-08-15 08:05:19 +00:00
Mathias Jakobsen
a46219b055 Merge pull request #19308 from overleaf/mj-mendeley-search
[web+third-party-references] Add Mendeley search to Write & Cite

GitOrigin-RevId: 97c32076a178a71e37b0b57c543e98e44ef84f44
2024-08-15 08:05:11 +00:00
Alf Eaton
654090b1b3 Transpile PDF.js v4 with Babel (#19846)
GitOrigin-RevId: 1338dbae0683d72ab84ee58d1128d22754d14567
2024-08-15 08:05:06 +00:00
M Fahru
dfa8eee981 Merge pull request #19811 from overleaf/mf-group-tab-educational-discount-new-plans-page
[web] Implement educational discount for group plans in new plans page

GitOrigin-RevId: bd8c76c3bbcdad25ac0b1f2353c52b318db55c83
2024-08-15 08:05:02 +00:00
M Fahru
23dbf31a95 Plans page light touch: Remove unused CSS rules about hiding monthly-annual-switch on mobile for group tab.
This is removed because monthly-annual-switch is already hidden on all screen size for group tab.

(in the current plans page, monthly-annual-switch will be disabled on desktop and will be hidden on mobile)

GitOrigin-RevId: bdb682b97844b6e3fb50be3c65eb6bd945d73648
2024-08-15 08:04:57 +00:00
M Fahru
87e3459563 Fix aria-hidden attribute by adding explicit "true" to its value
GitOrigin-RevId: 173f2e2d18a993ee81506d420b120231e4f40574
2024-08-15 08:04:52 +00:00
Antoine Clausse
8e68f10523 [web] In _deleteV1Account: Add response?.statusCode optional chaining, await request before getting response (#19936)
* Add optional chaining in `response.statusCode` in `_deleteV1Account` error handling

Should fix https://overleaf.sentry.io/issues/5708988236/

* Add another `response?.statusCode`

* Await `V1Api.promises.request` before getting the response

GitOrigin-RevId: 52a156680845516357b11943bee8c33a5a023514
2024-08-15 08:04:44 +00:00
andrew rumble
019562cb5a Update promises to use async functions directly
GitOrigin-RevId: f6a5d235ee259a4cf00f1e8d5c089b2d1d24a842
2024-08-15 08:04:39 +00:00
andrew rumble
f13cb88f02 Update unit tests
GitOrigin-RevId: b7a0b6265fefae775f0ce8a61e57e5231930dc50
2024-08-15 08:04:35 +00:00
andrew rumble
7af4980a4d Promisify ProjectEntityUpdateHandler functions
Promisify wrapWithLock

Promisify getDocContext

Promisify updateDocLines

Promisify setRootDoc

Promisify unsetRootDoc

Promisify addDoc and addDocWithRanges

Promisify addFile

Promisify upsertFile

Promisify upsertDocWithPath

Promisify deleteEntity

Promisify deleteEntityWithPath

Promisify mkdirp and mkdirpWithExactCase

Promisify moveEntity

Promisify renameEntity

Promisify addFolder

Promisify convertDocToFile

Promisify resyncProjectHistory

Promisify _addDocAndSendToTpds

Promisify _replaceFile

Promisify _checkFiletree

Promisify _cleanupEntity

Promisify _updateProjectStructureWithDeletedEntity

Promisify _cleanUpDoc and _cleanUpFile

Promisify upsertFileWithPath

Promisify upsertDoc

Promisify _uploadFile

Promisify _addFileAndSendToTpds

GitOrigin-RevId: 56a7de0ae79efedd5ad48abae2db22a4028c0c12
2024-08-15 08:04:30 +00:00
andrew rumble
c4d7da87a6 Move functions to be promisified
Moving these first will make later commits have a cleaner diff. There
are no substantive code changes in the moved functions.

GitOrigin-RevId: 06e0c5bb02f300942c8fbe80e81484c4d717dbc9
2024-08-15 08:04:25 +00:00
Alexandre Bourdin
10ef61a02b Merge pull request #19901 from overleaf/ac-confirm-institution-domain-queue-in-institution-module
[web] Add `start` function to modules. Move `confirm-institution-domain` queue to institution module

GitOrigin-RevId: 0d36ff3dcc529e77c76d72d0a67bbdb9310b42fd
2024-08-14 08:05:39 +00:00
Alexandre Bourdin
0071439866 Merge pull request #19929 from overleaf/ac-test-show-upgrade-prompt
[web] Add acceptance test checking `showUpgradePrompt` in `/project/:id`

GitOrigin-RevId: 825c5c364bea07f9f3886443633f9022413d030f
2024-08-14 08:05:34 +00:00
Alexandre Bourdin
61891e3c80 Merge pull request #19861 from overleaf/ab-overleaf-integration-delete-flow
[web] Remove /user/delete override from overleaf-integration

GitOrigin-RevId: 4f679f6835522c2325fe7b0368f58e7a952ee73d
2024-08-14 08:05:30 +00:00
Brian Gough
cf83990459 add tests for unwanted 500 responses from invalid urls (#19612)
* add acceptance tests for bad urls

* fix 500 from health check when smoke test userId is undefined

* handle exception from invalid urls in ExpressLocals middleware

* Add return statement before `next()`

* Cleaned up list of crash_test_urls.txt

* Return 400 instead of 404 on parsing errors

---------

Co-authored-by: mserranom <mserranom@gmail.com>
GitOrigin-RevId: dac35b07d1f12bd9ceb70e3064ec2ef8393f99b5
2024-08-14 08:05:16 +00:00
ilkin-overleaf
ca802eab82 Merge pull request #19892 from overleaf/ii-bs5-projects-geo-banners
[web] BS5 projects page banners

GitOrigin-RevId: f5ceccbb7009c010f2917e0c34b7d3f02d7511f1
2024-08-14 08:05:11 +00:00
Jessica Lawshe
0f5184ac27 Merge pull request #18986 from overleaf/jel-faq-tabs-match-figma
[web] Style updates to new tab style to match Figma

GitOrigin-RevId: d78101cc53e00f309e52798214b9bc97d047828f
2024-08-14 08:05:07 +00:00
Miguel Serrano
e08057828f [CE/SP] Hotfix 5.1.1 and 4.2.8 (#19771)
* [CE/SP] Hotfix 5.1.1 and 4.2.8

* Add script to build hotfix releases

GitOrigin-RevId: 8ece5e5fd5ec360b66069ce774319511ed82a13a
2024-08-14 08:05:03 +00:00
Eric Mc Sween
c117483761 Merge pull request #19882 from overleaf/mj-tcblisting
[web] Mark tcblisting as verbatim

GitOrigin-RevId: a64602b2b0d41c32e5f8612f190c6f5f8382f94b
2024-08-14 08:04:59 +00:00
Eric Mc Sween
e10478f256 Merge pull request #19867 from overleaf/em-hide-history-resync-details
Hide history resync changes

GitOrigin-RevId: a36876ff637d0a4c34150b21f4b4e623dff0ab03
2024-08-14 08:04:54 +00:00
M Fahru
40f3db3772 Merge pull request #19888 from overleaf/mf-new-plans-page-container-width-1280px
[web] Set new container width (1280px) and new main grid horizontal padding (16px) for all plans page redesign pages

GitOrigin-RevId: d266a8318dd4c2c90d9051bb58cca459799fca44
2024-08-14 08:04:50 +00:00
Davinder Singh
90c32aacee Merge pull request #19869 from overleaf/mf-plans-faq-button-use-material-symbols
[web] Use material symbols on plans FAQ's button

GitOrigin-RevId: 934f3627027a297fa39a835c98ff337f2a93d1d1
2024-08-14 08:04:46 +00:00
Davinder Singh
3a084d9606 Plans Page new design - Implement href for all of the CTA buttons for mobile screen (#19858)
* simplifying the logic of button rendering that matches the desktop version

* removing the plans_page_new_btn_buy_now_free mixin and adding the class .plans-cta-buttons-gap

* adding .plans-cta-buttons-gap to the desktop version

* changing table-header to mobile-card while calling the function

* adding styling into .plans-new-table-cta and removing plans-cta-buttons-gap usage from desktop version

* moving .plans-cta-buttons-gap into  .plans-card-cta-container-monthly-annual

* renaming the gap class to .plans-card-cta-buttons-container and using nth-child approach

* using the nth-child approach in .plans-new-table-cta

GitOrigin-RevId: 692814af8d8cf4dda0ea53dea9a3fe4adcf1dcd3
2024-08-14 08:04:42 +00:00
Tim Down
34fc43d59a Merge pull request #19126 from overleaf/td-bs5-contact-modal-react
React version of Contact Us modal

GitOrigin-RevId: 0bef3095f36daa88afdc6172a5531ed11e892047
2024-08-14 08:04:37 +00:00
Antoine Clausse
fb114a7c44 Merge pull request #19545 from overleaf/ac-remove-login-route-override
[web] Remove `/login` route override from overleaf-integration

GitOrigin-RevId: a22d0698e5039a8e77fb7ebb620500ad40a9a630
2024-08-14 08:04:26 +00:00
Rebeka Dekany
92a2debc9a Merge pull request #19557 from overleaf/rd-left-menu-dropdown
[web] Migrate the left menu on the project dashboard part #2

GitOrigin-RevId: 55b213352dd850650668bb4e507e11607aee0107
2024-08-13 08:04:42 +00:00
Jessica Lawshe
c636089939 Merge pull request #19822 from overleaf/jel-plans-notifications
[web] Show geo banners on light touch redesign of plans page

GitOrigin-RevId: 08ee6827cc16ec9326e5dbb1a165602be9cfe86d
2024-08-13 08:04:38 +00:00
Jessica Lawshe
47ad169781 Merge pull request #19758 from overleaf/jel-modal-light-touch
[web] Update group modal on plans page light touch redesign

GitOrigin-RevId: 26cce2996bed263c46d06b1b1fced8206fc9d8c1
2024-08-13 08:04:33 +00:00
Jessica Lawshe
214f093eb7 Merge pull request #19749 from overleaf/jel-fix-first-feature-row-border
[web] Fix first feature row border radius on light touch plans redesign

GitOrigin-RevId: 2ef5b1cbb13284a95d6c5d9370cd003f4ccf7f48
2024-08-13 08:04:29 +00:00
Jessica Lawshe
c4c36c9cea Merge pull request #19725 from overleaf/jel-interstitial-page-light-touch
[web] Interstitial payment page for light touch redesign

GitOrigin-RevId: ff83df760dd552d001ad8815f0a34cae5e13e6ff
2024-08-13 08:04:25 +00:00
Alf Eaton
2304536844 Add review panel context providers and components (#19490)
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
2024-08-13 08:04:20 +00:00
Antoine Clausse
8736bee460 [web] Move confirm_university_domain to institutions module, and /api/clsi/compile/* to publish-modal module (#19797)
* Move `/api/institutions/confirm_university_domain` to institutions module

* Move `confirmDomain` to institutions module

* Move `/api/clsi/compile/*` endpoints to `publish-modal` module

* Move ApiClsiTests to publish-modal module

* Revert move of MockClsiApi. It's still needed in the main acceptance tests

GitOrigin-RevId: b59c2921e03b94546d72d21e60a688eb1ae1d05e
2024-08-12 08:05:16 +00:00
CloudBuild
4bb4601d9d auto update translation
GitOrigin-RevId: 0e47a561a715d5a12cbffc3b20076cf1c932cfa8
2024-08-12 08:05:08 +00:00
ilkin-overleaf
16cdf5140a Merge pull request #19626 from overleaf/ii-invite-remove-unncecessary-fields
[web] Clean up props exposed to the /invite and /invites endpoints

GitOrigin-RevId: dc4163e04d5785e141d5e322bfb0a626e67d637f
2024-08-12 08:05:04 +00:00
Eric Mc Sween
97b62e01f8 Merge pull request #19851 from overleaf/em-user-content-logging
Avoid logging user content when errors occur in history

GitOrigin-RevId: 0326065a15dfc30155847100bb5a077efea771b5
2024-08-12 08:04:59 +00:00
Rebeka Dekany
57b3871c1c Merge pull request #19823 from overleaf/rd-navbar-pug-a11y
[web] Announce buttons as menu items in the navigation bar and allow tabbing within the menu

GitOrigin-RevId: 138fef3369bf5c89487e673ab42c06b7c13bcf48
2024-08-12 08:04:54 +00:00
Alexandre Bourdin
972fbb7c67 Merge pull request #19818 from overleaf/ab-fix-split-test-archived-notification-comment
[web] Skip sending last versions comment with archived test notification

GitOrigin-RevId: 997111220161eaf7588cac8809024ac4a09bc037
2024-08-09 08:04:38 +00:00
M Fahru
b1cfb00e30 Merge pull request #19760 from overleaf/mf-more-than-50-group-member-picker
[web] Create group member picker footer with a link that opens contact sales modal on new plans page

GitOrigin-RevId: 1dc1dce726cc0222bbbef911a016f1eb6a881aeb
2024-08-09 08:04:34 +00:00
Jakob Ackermann
86f26043d2 Merge pull request #19847 from overleaf/jpa-rename-history-v1
[misc] rename docker compose service history_v1 to history-v1 in dev-env

GitOrigin-RevId: 0991ee4297bae1ed9e9068af1889966ceeeba66d
2024-08-09 08:04:29 +00:00