github/hedgedoc
1
0
Fork 0
mirror of https://github.com/hedgedoc/hedgedoc.git synced 2024-11-27 03:58:02 -05:00
Code Issues Projects Releases Packages Wiki Activity
3660 commits 39 branches 47 tags 112 MiB
Commit graph

3660 commits

This branch
This branch
All branches
Author SHA1 Message Date
David Mehren
0c89d8715e
UsersService: Remove test obsoleted by strict mode 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
ea11fbff12
Ensure optional properties of AuthTokenDto are initialized 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
f0c4fbe371
Disable strict mode for tests 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
d1e352d56c
Add explicit type annotations to nullable columns 
TypeORM can't correctly infer the data type on properties with a `| null` type.
This commit adds explicit type annotations.

See also https://github.com/typeorm/typeorm/issues/2567#issuecomment-408599335

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
f9a0353748
NotesService.toNoteMetadataDto: Handle undefined updateUser 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
f8efb9717e
NotesService: Fix type errors 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
3b0ffaca30
Consistently type properties as optional 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
b3e01fff7f
GroupsService: Remove null from toGroupDto return type 
toGroupDto won't return null, as TS's strict mode
prevents group from being nullish

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
664a64495f
NotesController: Double-check that req.user is defined 
TokenAuthGuard ensures that req.user is always
defined, but thanks to strict mode we have to check again.

In the future, we may add a custom Request type and
a custom param decorator to centralize the check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
6aa1aa229a
NoteEntity: Allow anonymous notes 
Notes created by anonymous users don't have an owner.
This commit updates the entity accordingly.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
b08a314863
MediaUploadDto: Make noteId optional 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
dc7d8ab470
MediaService: Handle unexpected backend type 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
b93f01fe57
Correctly type nullable columns 
TypeORM columns with `nullable: true` can be `null` at runtime.
This commit ensures that the types of the corresponding properties reflect that.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
16ed12bfd7
MediaController: Double-check that req.user is defined 
TokenAuthGuard ensures that req.user is always
defined, but thanks to strict mode we have to check again.

In the future, we may add a custom Request type and
a custom param decorator to centralize the check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
ace1b7fad6
MeController: Double-check that req.user is defined 
TokenAuthGuard ensures that req.user is always
defined, but thanks to strict mode we have to check again.

In the future, we may add a custom Request type and
a custom param decorator to centralize the check.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
e18ee1f0fe
UsersService: Remove null from toUserDto return type 
toUserDto won't return null, as TS's strict mode
prevents user from being nullish

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
96f8284e64
MarkdownBody: Handle error in getOwnPropertyDescriptor 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
a04a111293
Handle config initialisation error on app bootstrap 
Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
994bd7ae64
HistoryService: Throw NotInDBError on empty DB result 
This adds error handling to getEntryByNote, so it throws a
NotInDBError instead of (illegally, according to the type) returning
null.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
0573ce4e08
FrontendConfig DTOs: Make properties consistently optional 
Some properties already have a IsOptional decorator,
this makes the properties themselves also optional

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
99103ad217
ConsoleLoggerService: Fix type of context properties 
Nullish values of functionContext and classContext are handled correctly,
so the type can be adjusted

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
d9799717b5
AuthService: Fix type of toAuthTokenWithSecretDto 
toAuthTokenDto does not return nor accept a nullish value anymore,
so the types can be adjusted.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:31 +02:00
David Mehren
53a0c87a53
AuthService.randomString: Throw Error instead of returning null 
A string with a negative length is invalid, so we should throw here
instead of complicating the type with a possible null return value.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
72b545fec5
AuthTokenDto: Make properties consistently optional 
validUntil and lastUsed already have a IsOptional decorator,
this makes the properties themselves also optional

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
cfaa07806b
AuthService: Throw NotInDBError on empty DB result 
This adds error handling to various functions, so they throw a
NotInDBError instead of a TypeError

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
6fd9d64ad7
Safely parse numbers from environment vars 
This adds the function parseOptionalInt to help parse numbers
from environment variables

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
2da9b76a31
Config Utils: Fix type of toArrayConfig 
configValue is checked for a nullish value,
the type should reflect that.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
74bc9612cc
AuthService: Remove null from toAuthTokenDto return type 
toAuthTokenDto won't return null, as TS's strict mode
prevents authToken from being nullish

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
a6e245c551
RevisionsService: Throw NotInDBError on empty DB result 
This adds error handling to various getters, so they throw a
NotInDBError instead of (illegally, according to the type) returning
null.

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 20:59:30 +02:00
David Mehren
3861d4beb4
Enable TypeScript strict mode 
This enables strict mode, but sets strictPropertyInitialization to false,
as "the class-validator DTO pattern described in the documentation is
not compatible with strict property initialization" according to
https://github.com/nestjs/typescript-starter/pull/192

Signed-off-by: David Mehren <git@herrmehren.de>
 2021-05-09 17:44:20 +02:00
David Mehren
0334014f7e
Merge pull request #1248 from hedgedoc/renovate/develop-linters 
Update dependency eslint to v7.26.0 (develop)
 2021-05-09 14:45:42 +02:00
David Mehren
be25f32f53
Merge pull request #1235 from hedgedoc/renovate/develop-ts-loader-9.x 
Update dependency ts-loader to v9.1.2 (develop)
 2021-05-09 14:45:09 +02:00
Renovate Bot
89b9160787
Update dependency eslint to v7.26.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-09 12:41:30 +00:00
Renovate Bot
84cb34eef3
Update dependency ts-loader to v9.1.2 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-09 12:41:15 +00:00
David Mehren
b1c9a4430d
Merge pull request #1251 from hedgedoc/renovate/develop-pymdown-extensions-8.x 
Update dependency pymdown-extensions to v8.2 (develop)
 2021-05-09 14:39:57 +02:00
Renovate Bot
6af90b9555
Update dependency pymdown-extensions to v8.2 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-08 19:43:43 +00:00
Yannick Bungers
0db8a31e3f
Merge pull request #1238 from hedgedoc/renovate/develop-mkdocs-material-7.x 
Update dependency mkdocs-material to v7.1.4 (develop)
 2021-05-08 21:41:29 +02:00
Renovate Bot
b38b2b12f0
Update dependency mkdocs-material to v7.1.4 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-07 09:51:32 +00:00
Yannick Bungers
77b7f30eb8
Merge pull request #1224 from hedgedoc/renovate/develop-linters 
Update linters to v4.22.1 (develop)
 2021-05-07 11:48:43 +02:00
Yannick Bungers
f55ebc5bcf
Merge pull request #1229 from hedgedoc/renovate/develop-file-type-16.x 
Update dependency file-type to v16.4.0 (develop)
 2021-05-07 11:48:28 +02:00
Renovate Bot
041574bd07
Update linters to v4.22.1 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-05 20:27:14 +00:00
Renovate Bot
7d6596b822
Update dependency file-type to v16.4.0 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-05 20:26:59 +00:00
Yannick Bungers
edaeb6ae46
Merge pull request #1230 from hedgedoc/renovate/develop-ts-jest-26.x 
Update dependency ts-jest to v26.5.6 (develop)
 2021-05-05 22:25:41 +02:00
Renovate Bot
23640dc1ab
Update dependency ts-jest to v26.5.6 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-05 16:10:56 +00:00
Yannick Bungers
80adde6c44
Merge pull request #1214 from hedgedoc/renovate/develop-lock-file-maintenance 
Lock file maintenance (develop)
 2021-05-03 21:29:53 +02:00
Renovate Bot
5f8c108868
Lock file maintenance 
Signed-off-by: Renovate Bot <bot@renovateapp.com>
 2021-05-03 01:12:21 +00:00
David Mehren
7adbc72a5f
Merge pull request #1130 from hedgedoc/history/transaction 2021-05-02 18:15:05 +02:00
Philip Molares
2ba1be6ea3 PrivateHistoryE2E: Extend POST /me/history 
Test the correct behaviour in error cases

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-02 18:09:16 +02:00
Philip Molares
f967b34018 ControllerTests: Add connection to controller tests 
Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-02 18:09:16 +02:00
Philip Molares
f7e483da81 ESLint: Add extra rules for tests 
Add afterEach and beforeAll as additional additionalTestBlockFunctions for jest/no-standalone-expect. This is necessary, because we use expects in those functions for the history service unit tests.

Signed-off-by: Philip Molares <philip.molares@udo.edu>
 2021-05-02 18:09:16 +02:00