Correctly type nullable columns

TypeORM columns with `nullable: true` can be `null` at runtime.
This commit ensures that the types of the corresponding properties reflect that.

Signed-off-by: David Mehren <git@herrmehren.de>

src/auth/auth-token.entity.ts

@@ -38,12 +38,12 @@ export class AuthToken {
   @Column({
     nullable: true,
   })
-  validUntil: Date;
+  validUntil: Date | null;
 
   @Column({
     nullable: true,
   })
-  lastUsed: Date;
+  lastUsed: Date | null;
 
   public static create(
     user: User,

src/media/media-upload.entity.ts

@@ -26,7 +26,7 @@ export class MediaUpload {
   @ManyToOne((_) => Note, (note) => note.mediaUploads, {
     nullable: true,
   })
-  note: Note;
+  note: Note | null;
 
   @ManyToOne((_) => User, (user) => user.mediaUploads, {
     nullable: false,
@@ -44,7 +44,7 @@ export class MediaUpload {
   @Column({
     nullable: true,
   })
-  backendData: BackendData;
+  backendData: BackendData | null;
 
   @CreateDateColumn()
   createdAt: Date;

src/notes/note.entity.ts

@@ -36,7 +36,7 @@ export class Note {
     unique: true,
     nullable: true,
   })
-  alias?: string;
+  alias: string | null;
   @OneToMany(
     (_) => NoteGroupPermission,
     (groupPermission) => groupPermission.note,
@@ -70,11 +70,11 @@ export class Note {
   @Column({
     nullable: true,
   })
-  description?: string;
+  description: string | null;
   @Column({
     nullable: true,
   })
-  title?: string;
+  title: string | null;
 
   @ManyToMany((_) => Tag, (tag) => tag.notes, { eager: true, cascade: true })
   @JoinTable()

src/notes/notes.service.spec.ts

@@ -153,7 +153,7 @@ describe('NotesService', () => {
         expect(newNote.groupPermissions).toHaveLength(0);
         expect(newNote.tags).toHaveLength(0);
         expect(newNote.owner).toBeUndefined();
-        expect(newNote.alias).toBeUndefined();
+        expect(newNote.alias).toBeNull();
       });
       it('without alias, with owner', async () => {
         const newNote = await service.createNote(content, undefined, user);
@@ -166,7 +166,7 @@ describe('NotesService', () => {
         expect(newNote.groupPermissions).toHaveLength(0);
         expect(newNote.tags).toHaveLength(0);
         expect(newNote.owner).toEqual(user);
-        expect(newNote.alias).toBeUndefined();
+        expect(newNote.alias).toBeNull();
       });
       it('with alias, without owner', async () => {
         const newNote = await service.createNote(content, alias);

src/users/identity.entity.ts

@@ -39,15 +39,15 @@ export class Identity {
   @Column({
     nullable: true,
   })
-  providerUserId?: string;
+  providerUserId: string | null;
 
   @Column({
     nullable: true,
   })
-  oAuthAccessToken?: string;
+  oAuthAccessToken: string | null;
 
   @Column({
     nullable: true,
   })
-  passwordHash?: string;
+  passwordHash: string | null;
 }

src/users/user.entity.ts

@@ -41,12 +41,12 @@ export class User {
   @Column({
     nullable: true,
   })
-  photo?: string;
+  photo: string | null;
 
   @Column({
     nullable: true,
   })
-  email?: string;
+  email: string | null;
 
   @OneToMany((_) => Note, (note) => note.owner)
   ownedNotes: Note[];