Paulo Reis
fcf0a96933
Use selection.isCollapsed to check for empty selections.
2017-06-15 16:16:30 +01:00
Brian Gough
503822deb0
avoid possible exception if selection is undefined
...
defensive programming only
2017-06-15 14:32:00 +01:00
Brian Gough
b9804823f3
handle off-screen selection
...
when toggling the logs button the selection is off-screen and
selection.toString() is empty even when there is a selected range. Can
check for selection.type being "Range" instead.
2017-06-15 14:21:42 +01:00
Brian Gough
b04288ed44
avoid getting duplicate handlers for mouseup
2017-06-15 14:21:42 +01:00
Brian Gough
76dcde4dae
hide the text layer on reload
2017-06-15 13:42:19 +01:00
Paulo Reis
fbaa918927
Do not show the text layer when the user clicks outside pages. Remove some debug statements.
2017-06-15 12:32:04 +01:00
Paulo Reis
4985f7ca1c
Different approach: render all text layers while selecting (WIP).
2017-06-15 12:32:04 +01:00
Paulo Reis
786659dc1b
Render text layer on hovered pages (and adjacent ones).
2017-06-15 12:32:04 +01:00
Shane Kilkelly
b0bb4b3e47
Merge branch 'sk-ref-variants'
2017-06-15 09:17:48 +01:00
Shane Kilkelly
9607174b64
Merge branch 'master' into sk-server-side-labels-loading
2017-06-15 08:49:14 +01:00
Shane Kilkelly
3f1a440d66
Support variations of \ref{}
, such as \cref{}
, \eqref{}
, etc..
2017-06-14 15:15:07 +01:00
Shane Kilkelly
b0ff8e0745
Fix a typo: prefxi
=> prefix
2017-06-14 15:14:38 +01:00
Shane Kilkelly
5e37b1dac1
Move logic for selectively loading labels.
...
Only load labels if the user has write permission
2017-06-14 13:26:02 +01:00
Brian Gough
e1efc3a7b5
Merge pull request #521 from sharelatex/bg-reduce-pdf-memory-usage
...
Revert "use a single pdfjs worker, rotated to avoid leaks"
2017-06-13 16:46:58 +01:00
Shane Kilkelly
3b066758bb
Don't load labels for anonymous/read-only users
2017-06-13 14:06:00 +01:00
Shane Kilkelly
954c53aec6
Move the labels event logic into ide/labels/LabelsManager
2017-06-13 13:29:03 +01:00
Shane Kilkelly
a04eb1197d
Move labels service to /ide/labels/services/labels
2017-06-13 11:43:25 +01:00
Shane Kilkelly
debb0c06a4
Clearer logic for triggering labels-loading
2017-06-12 14:23:29 +01:00
Shane Kilkelly
234a2d0e21
Remove cruft
2017-06-12 11:37:34 +01:00
Shane Kilkelly
1bb065344c
Move labels into an Angular Service
2017-06-12 09:44:32 +01:00
Shane Kilkelly
56385a798b
Use ide.$http, rather than jquery
2017-06-09 11:41:35 +01:00
Shane Kilkelly
5443b92e7d
Move state management into LabelsMaster on the ide
2017-06-09 11:28:27 +01:00
Shane Kilkelly
965a46291b
Only fetch labels for uploaded docs, not files
2017-06-08 15:55:17 +01:00
Shane Kilkelly
ff7955dfdb
Update labels when docs are uploaded or removed
2017-06-08 15:12:18 +01:00
Shane Kilkelly
c7dbd21cd1
use flag on aceEditor to enable autocomplete features
2017-06-08 09:22:08 +01:00
Paulo Reis
240d6d6f6b
Resolve timing issue when triggering selection-related logic.
2017-06-07 14:21:05 +01:00
Paulo Reis
53b18e041f
Trigger selection-related logic after accepting or rejecting changes.
2017-06-07 14:03:58 +01:00
Brian Gough
aa8974dcd6
Revert "use a single pdfjs worker, rotated to avoid leaks"
...
This reverts commit f270ef54911acd800d2ffd577080b50ea2fe4aff.
Use a new worker on each reload to free up memory.
2017-06-07 13:29:10 +01:00
Paulo Reis
19ecffd654
Merge branch 'master' into pr-aggregate-insert-delete
2017-06-06 17:04:31 +01:00
Paulo Reis
34796b18c5
Add translation keys.
2017-06-06 16:46:36 +01:00
Paulo Reis
afa011c813
Avoid flickering when elements enter the review panel.
2017-06-06 16:11:00 +01:00
Paulo Reis
73a67c6617
Add a note on the need of reverse sorting changes when rejecting.
2017-06-06 13:34:48 +01:00
Paulo Reis
4504f77aa3
Do bulk rejects in reverse order.
2017-06-06 12:06:43 +01:00
Paulo Reis
81a5a5311d
Clear selection after bulk actions.
2017-06-06 10:03:33 +01:00
Paulo Reis
5a75663a0c
Do bulk rejects in reverse order.
2017-06-05 17:17:47 +01:00
Paulo Reis
e616a62d68
Save entry ids inside entry object, not only as the key.
2017-06-05 16:29:55 +01:00
Shane Kilkelly
f7ad4a4786
WIP: basically working, with client sync
2017-06-05 14:48:50 +01:00
James Allen
cb1745a1e6
Fix redirect in clone project modal
2017-06-05 13:33:32 +01:00
James Allen
d7981fd2d4
Merge pull request #512 from sharelatex/ja-project-name-validation
...
Refactor project name validation into one place and restrict /s
2017-06-05 11:55:39 +01:00
Shane Kilkelly
51881dbbcc
Only load labels from current doc if change is local
2017-06-05 11:09:58 +01:00
Paulo Reis
6c3cdbcc3a
Remove dead code, backend does not send single change events anymore.
2017-06-05 10:43:03 +01:00
Paulo Reis
8d8bcab1e8
Consolidate change accept and reject code.
2017-06-05 10:41:59 +01:00
Shane Kilkelly
4cb41a988a
WIP: initial work on server-side labels
2017-06-02 15:12:59 +01:00
Paulo Reis
e2edf4184f
Explicit naming.
2017-06-02 11:43:43 +01:00
Shane Kilkelly
51e3a6b3a3
Don't use String.startsWith, use slice instead.
...
- String.startsWith is not supported in IE
2017-06-02 09:54:48 +01:00
Paulo Reis
26260fc11f
Prevent aggregation of changes from different users.
2017-06-01 16:33:50 +01:00
Paulo Reis
b2a7686204
DRYness.
2017-06-01 15:28:37 +01:00
Paulo Reis
2a0454f2f1
Integrate aggregate changes with bulk actions.
2017-06-01 15:18:43 +01:00
Paulo Reis
1490ea7b04
Change aggregated change model: the main change is now the insertion, deletion is stored in metadata.
2017-06-01 15:03:37 +01:00
Paulo Reis
11c0644490
Aggregate changes; make accept and reject work.
2017-06-01 11:47:55 +01:00