Commit graph

2049 commits

Author SHA1 Message Date
Brian Gough
558992d947 Merge pull request #13916 from overleaf/bg-managed-users-hide-leave-group-action
managed users hide leave group action

GitOrigin-RevId: 160e31e6935cd3737356714020e057f8c1acc5b8
2023-07-21 08:04:36 +00:00
Brian Gough
d298a258e0 Merge pull request #13932 from overleaf/bg-managed-users-hide-reactivate-button
hide button to reactivate subscription for managed users

GitOrigin-RevId: 3632c5ffdee68eb5e0aed1479f3b7ffb45e3aa4a
2023-07-21 08:04:31 +00:00
Jakob Ackermann
37b42fc20b Merge pull request #13977 from overleaf/jpa-translations-fixes
[web] translations fixes

GitOrigin-RevId: 526560b35fad6e005ab653b5b45cdf84255af686
2023-07-21 08:04:27 +00:00
Domagoj Kriskovic
96e7c019bd [cm6] remove badge icon for toolbar in code editor (#13959)
GitOrigin-RevId: 33813eb1c22d651cf3ea599f30b626f93f8ef8ef
2023-07-20 08:04:50 +00:00
Alf Eaton
a9177abe5a [visual] Provide command definitions to MathJax (#13761)
GitOrigin-RevId: 845921df363f61d2333c1305b0b3edb86501c296
2023-07-19 08:05:00 +00:00
Alf Eaton
08c82a24a9 [visual] Apply style to the content of color commands (#13726)
GitOrigin-RevId: 4ae8b745618e91b487d17c357cdb0e697038b3a3
2023-07-19 08:04:56 +00:00
Alf Eaton
ca9593e74c [visual] Decorate quotation environments (#13728)
GitOrigin-RevId: 65c4bb8b4695d0698120936d3b2fb8ec6fa402dc
2023-07-19 08:04:52 +00:00
Domagoj Kriskovic
9c185d6f35 [cm6] fix toolbar overflow menu alignment (#13873)
GitOrigin-RevId: a70cf3fa37d49b9ed52fea4b928d52ffc2dbf136
2023-07-19 08:04:48 +00:00
Alf Eaton
05165682ba Update "Visual Editor not available" message (#13874)
GitOrigin-RevId: 5516bf74d1fa9046f4ca4b5d6c23d3a3b8e468f5
2023-07-19 08:04:44 +00:00
Alf Eaton
9f719c572d [cm6] Add offset to review panel entry positions when needed (#13912)
* Add offset to review panel entry positions when needed
* Fix useResizeObserver usage

GitOrigin-RevId: e220ce94e13c3a2347fc72654de747356eb1e658
2023-07-19 08:04:40 +00:00
Domagoj Kriskovic
4d3c4c6ae9 [cm6] add tracking to figure modal submit events (#13917)
GitOrigin-RevId: f0c755e2f336b5f0c6caf283bed69db65a0c3c92
2023-07-19 08:04:36 +00:00
Domagoj Kriskovic
79f07e5626 [cm6] dark mode for toolbar dropdowns (#13870)
GitOrigin-RevId: e220edddc678dd05c4c5d1927a5fcac379cd6ed5
2023-07-19 08:04:32 +00:00
Domagoj Kriskovic
c21b8e31fd [visual] suport for \texttt command in maketitle (#13824)
GitOrigin-RevId: 712eb8fb4fc0f2cbc5cd3c2e39ff6b8af39c0a49
2023-07-19 08:04:28 +00:00
Alf Eaton
ff7eec48de [cm6] Improve performance of the editor toolbar (#13915)
* Memoize figure and math dropdowns
* Only build section heading overlay when open
* Memoise currentLevel
* Remove memo from ToolbarOverflow
* Calculate listDepth in the container component
* Avoid using document.querySelector

GitOrigin-RevId: d5ec8817d35d04e0e2c60c8eecc8678ede69f82a
2023-07-19 08:04:24 +00:00
Alf Eaton
930cec2189 Calculate overflow when languageName or visual change (#13872)
GitOrigin-RevId: f2d200d0d34e810688defe78b8143829f095df9f
2023-07-19 08:04:20 +00:00
Alf Eaton
b284434ad2 [visual] Move the cursor after leading whitespace when creating a new list item on Enter (#13828)
GitOrigin-RevId: 2f5941627b64fb53efce0bdd6f2d888986f45a9d
2023-07-19 08:04:16 +00:00
Alf Eaton
05adb9d14d [visual] Add decorations for theorem environments (#13708)
GitOrigin-RevId: ba78be534fd7efba7d8722a214d69b21b0e3917c
2023-07-19 08:04:12 +00:00
Jakob Ackermann
d212be408f Merge pull request #13337 from overleaf/jpa-translate-plans-page
[web] translate all the things on the plans page (to German)

GitOrigin-RevId: cbd812a4eca41573986c2d9e4f5e37b3d5a49e4f
2023-07-19 08:03:57 +00:00
Tim Down
38c673d057 Merge pull request #13720 from overleaf/td-review-panel-entry-pos
React review panel entry positioning

GitOrigin-RevId: c22617b1d3243b7d54b093426358aeb291421b9e
2023-07-19 08:03:52 +00:00
Eric Mc Sween
cce1a91205 Merge pull request #13897 from overleaf/ae-completion-event
Fix regular expression for completion event logging

GitOrigin-RevId: fbe3b91722fe40d4bb1116f23a78ebcebbd02b37
2023-07-17 11:13:27 +00:00
Rebeka
38d1e749fb Update translation for the annual plan
GitOrigin-RevId: 3a7e42f61f7820221df3be3c8bd4cd1738b5cb46
2023-07-17 11:12:17 +00:00
June Kelly
5dfe026123 Merge pull request #13864 from overleaf/bg-bugfix-admin-add-managers-copy
fix copy on group admin page

GitOrigin-RevId: 79ce52c36f4bc15663bae5ca914c2c693a28ee1c
2023-07-17 11:11:06 +00:00
June Kelly
bf92436e6f Merge pull request #13505 from overleaf/bg-group-policy-meta-tags
hide restricted elements for managed users on settings page

GitOrigin-RevId: be8679957eb5185d8b91d29e5a787c837684c314
2023-07-17 11:10:46 +00:00
June Kelly
4f8852feaa Merge pull request #13850 from overleaf/ab-invite-enrollment
[web] Managed users - combined invite/surrender flow

GitOrigin-RevId: 70cb0d81e0019eac69a4a565377447bb6d1a1823
2023-07-17 11:10:37 +00:00
Thomas
e704afdcca Merge pull request #13804 from overleaf/tm-geopricing-inr-banners
Implement split test for new INR geo-pricing banners/modal

GitOrigin-RevId: 06fbcf70b7ee90b9b365ac96c1fa0373cbe60847
2023-07-17 11:09:44 +00:00
Tim Down
49eafa2712 Merge pull request #13604 from overleaf/jk-managed-users-offboarding-ui
[web] Managed Users offboarding UI

GitOrigin-RevId: ee4a1ae7cdb0022839ef232836ef6933443400fc
2023-07-17 11:08:52 +00:00
M Fahru
c8b13102c8 Revert Tw reference manager access (#13854)
This reverts commit 85232c1559c6d2068effec50e31b8fa30bf53c89.

GitOrigin-RevId: 32475f6aabaa4f8f2f8e042d62ff07420fb32c9f
2023-07-17 11:07:45 +00:00
ilkin-overleaf
66f540c6eb Merge pull request #13845 from overleaf/ii-rp-incorrect-date
[web] Fix date issues in review panel

GitOrigin-RevId: 447185cc97aae5a2e6d8944be578fa103b39325b
2023-07-17 11:07:35 +00:00
ilkin-overleaf
680d5e0a6f Merge pull request #13839 from overleaf/ii-rp-word-break
[web] Break long text to new line in change entry

GitOrigin-RevId: e0effb86b08e7fe04b25040a8f3775c047203828
2023-07-17 11:07:26 +00:00
ilkin-overleaf
dbef201e3f Merge pull request #13801 from overleaf/ii-review-panel-migration-upgrade-track-changes-modal
[web] Create upgrade track changes modal

GitOrigin-RevId: 704ddef862ea9a2f8ca2bf63880da6e88f783724
2023-07-17 11:07:16 +00:00
ilkin-overleaf
84bbdf9772 Merge pull request #13767 from overleaf/ii-review-panel-migration-in-editor-widgets
[web] Create in editor widgets

GitOrigin-RevId: 53dfb9935ee59bbdedc353aad5e5b19f389a513c
2023-07-17 11:07:06 +00:00
Tyna William
3297506021 Revert "Revert "Tw reference manager access"" (#13825)
* Revert "Revert "Tw reference manager access""

This reverts commit 55f3512f254e136d8a239bb5d9ca39f0d04720fd.

* added conditional to check whether file linked data exists

* created new translation key for refresh error

* Fix for misleading reference manager access error to ensure users are aware only original importer of reference file can refresh it. If original importer, then user is prompted to relink provider account. Previous PR and conversation #13618.

GitOrigin-RevId: 85232c1559c6d2068effec50e31b8fa30bf53c89
2023-07-17 11:06:48 +00:00
Mathias Jakobsen
b008c19dc3 Merge pull request #13836 from overleaf/mj-bibtex-identifier
[lezer] Change bibtex identifier to deny-list

GitOrigin-RevId: 005b256a22acbafbeefd641cec82460f603fbc7a
2023-07-17 11:06:22 +00:00
Davinder Singh
75dc1dd2a1 Admin Panel- Removing view project graph button from project list page (#13803)
* removed the files related to angular code

* removed the controller files related to graph page

* removed two files related to sigmaJsGraph

* removed sigma-master folder

* removed copyPlugin configuration for sigma from webpack.config.js

GitOrigin-RevId: 1322a69917c0baf6fdbfa52da8e9830b548d7b7b
2023-07-17 11:06:03 +00:00
Mathias Jakobsen
37582f7b72 Merge pull request #13805 from overleaf/mj-bibtex-content-outside
[lezer] Allow content outside declarations in bibtex

GitOrigin-RevId: 8051db5567eeb52c3b12f63afafe07a7a97df650
2023-07-17 11:05:37 +00:00
Alf Eaton
bbbf38d76b Add decorations for textmd and textsf (#13716)
GitOrigin-RevId: c5bedf2260c4e075e458ac38f90e5746dccdde81
2023-07-17 11:04:50 +00:00
Alf Eaton
809172d531 Decorate verbatim and lstlisting environments (#13722)
GitOrigin-RevId: 2e5af20bf2fe0c7769011ecd26797e93290b4fdb
2023-07-17 11:04:40 +00:00
Alf Eaton
b0b829f69b Add syntax highlighting for Ampersand nodes (#13737)
GitOrigin-RevId: 39c81ecb765adc4b33244b5f0f1eab81594dcba1
2023-07-17 11:04:30 +00:00
Alf Eaton
e7d36903bb [cm6] Add Tilde to the LaTeX grammar (#13740)
GitOrigin-RevId: 98a2e968056ba4d6e36310d4ea0f7ff2f25e373a
2023-07-17 11:04:21 +00:00
Alf Eaton
faff4a87b4 Never decorate inside math (#13810)
GitOrigin-RevId: c28d0aaa3ce267d989db779c13f6b3e91f376686
2023-07-17 11:04:11 +00:00
Alf Eaton
e86c5dc137 [cm6] Add analytics for bold and italic shortcuts (#13785)
GitOrigin-RevId: 62f2f9976778083b7ca6566f79e3d055585e7bb7
2023-07-17 11:04:01 +00:00
Alf Eaton
48e758a5fe Record each completion selection for analytics (#13665)
GitOrigin-RevId: bc8e92ceca51f6365c4311204a35fc85914969b0
2023-07-17 11:03:43 +00:00
Alf Eaton
5a786029a3 [cm6] Hide list indentation shortcuts in button tooltips in Code Editor (#13797)
GitOrigin-RevId: d5184310d81953d9765f6e1ae2343fdeb824ae01
2023-07-17 11:03:34 +00:00
Alf Eaton
34fa28c90b Hide most toolbar buttons for non-latex documents (#13725)
GitOrigin-RevId: 3bf487d86d1a465a1653b40891277380270ea7ff
2023-07-17 11:03:16 +00:00
Domagoj Kriskovic
8ab6239a24 [cm6] support \emph and \textbf in maketitle (#13703)
* [cm6] support \textbf in maketitle

* support for emph

* added support for \\textbf

* fix overlapping ignored ranges

* fix overlapping fn, added test

* multiple maketitle cases in the same test

* prettier

* simplify from calculation

* added test cases from #13736

GitOrigin-RevId: 00dcf15d6d62903ae30b387a16929e68dde8ca1b
2023-07-17 11:02:11 +00:00
Thomas
c1ec3044d7 Add geo-pricing split test for enabling LATAM currencies (#13663)
* Implement LATAM geo-pricing split test

* Hide Paypal if currency is one of INR, COP, CLP, PEN

* Only send the LATAM/INR banner events when banner is rendered

* Workaround in Subscription dashboard for CLP not having minor units

GitOrigin-RevId: a677086a7762900563558126d2f81a4c57bbe9d7
2023-07-17 11:01:10 +00:00
Thomas
8efac32c8a Add LATAM currencies/prices to plan and group settings/scripts (#13661)
* Add LATAM currencies to plan-prices generator script

* Add LATAM prices to web configs

* Add LATAM currencies to group plan price formatting

* Use toLocaleString to format currencies for LATAM regions

GitOrigin-RevId: ce672043bef16298c87efa007eac23b004be8205
2023-07-17 11:01:00 +00:00
Domagoj Kriskovic
9cb0122ea3 [visual] support for multiple authors in /maketitle (#13713)
* [visual] support for multiple titles in /maketitle

* support \and in author name

* using isMatchWith

* fix isMatchWith check

* fix isMatchWith... again

* add tests

* test author text replace and mouse events

* prettier

* don't handle updating node events

* use the arguments order as before

GitOrigin-RevId: 99b3d1c22a2dc1258a5cdf95738852028895f54a
2023-07-17 11:00:07 +00:00
Domagoj Kriskovic
7487f37bc1 [cm6] use tooltips on disabled toolbar buttons (#13678)
* [cm6] use tooltips on disabled toolbar buttons

* not-allowed cursor

* prettier

* fix css selector

GitOrigin-RevId: f9c61fdabb1141daa2bde76aa4e3cd4da60e029e
2023-07-17 10:59:58 +00:00
Domagoj Kriskovic
b0d994575d [visual] fix styling for showing authors (#13772)
* [visual] fix styling for showing authors

* add horizontal padding

* use gap

* prettier

* maxWidth and flex wrap

* min-width

* use only min-width

GitOrigin-RevId: 1fdc1baac6fd98ee909f847716f6aedf88e96aec
2023-07-17 10:59:49 +00:00
ilkin-overleaf
13a7e752d5 Merge pull request #13710 from overleaf/ii-review-panel-migration-bulk-actions-entry
[web] Create bulk actions entry and bulk actions modal

GitOrigin-RevId: c88ce6213304a110ee7410529813310b863178c1
2023-07-17 10:59:19 +00:00
Davinder Singh
9e8e124113 Merge pull request #13591 from overleaf/ab-account-enrollment
[web] Managed users - account enrollment

GitOrigin-RevId: 6fc9ef8c44394eb92d3afd2022433b0b6d508503
2023-07-17 10:59:02 +00:00
Mathias Jakobsen
e0a3dfec36 [lezer] Allow slash in bibtex identifier
GitOrigin-RevId: 88f5cf069563940b1e42763babdc1e58d65c1d31
2023-07-17 10:58:05 +00:00
Mathias Jakobsen
6aa4435fc3 Merge pull request #13769 from overleaf/mj-bibtex-enter
[lezer] Fix bug with bracket matching for bibtex

GitOrigin-RevId: 2570bab50b73f05508af1bdeef0eab6aee4e02a9
2023-07-17 10:57:12 +00:00
ilkin-overleaf
debb438128 Merge pull request #13691 from overleaf/mj-linter-error
[cm6] Fix error in linter on input command

GitOrigin-RevId: 87c640ec6bd0e9d5942e6348616e0858d5bb07be
2023-07-17 10:57:02 +00:00
ilkin-overleaf
12bcdad850 Merge pull request #13744 from overleaf/mj-big-projects
[cm6] Optimise getUpdatedProjection

GitOrigin-RevId: af321d3828185b245f557ab0e046851192c97296
2023-07-17 10:56:52 +00:00
ilkin-overleaf
225de683c7 Merge pull request #13687 from overleaf/ii-review-panel-migration-add-comment-entry
[web] Create add comment entry

GitOrigin-RevId: 019f508eeb3982fce082df153e56d6c3c3e3bae5
2023-07-17 10:56:42 +00:00
Alf Eaton
0dc9aa3d21 Improve CM6 dev tools extension (#13712)
GitOrigin-RevId: 3af5e051cb3fed322d980ba71d3ec1fc9817f8e3
2023-07-17 10:56:23 +00:00
Alf Eaton
b63cb6e029 Merge pull request #13623 from overleaf/ae-symbol-palette-toolbar
[cm6] Only show symbol palette toolbar button when available

GitOrigin-RevId: 34e2c4e8ac1077a4da15277188ea0456db26e0af
2023-07-17 10:55:45 +00:00
Alf Eaton
d044899a28 Merge pull request #13763 from overleaf/revert-13618-tw-reference-manager-access
Revert "Tw reference manager access"

GitOrigin-RevId: d520234bd125f734037afa5208b4ad09e8f6e124
2023-07-17 10:55:36 +00:00
Tyna William
840f56f330 Merge pull request #13618 from overleaf/tw-reference-manager-access
Tw reference manager access

GitOrigin-RevId: e4554f2fcfd0aa9193497daae3ac1da18629d0de
2023-07-17 10:55:26 +00:00
Eric Mc Sween
d89b62e965 Merge pull request #13671 from overleaf/ii-review-panel-migration-aggregate-change-entry
[web] Create aggregate change entries

GitOrigin-RevId: 685ac40739f3c39665d84bd402ada21e00db5146
2023-07-17 10:54:50 +00:00
Davinder Singh
b1f246b9ba Merge pull request #13658 from overleaf/ii-review-panel-migration-change-entry
[web] Create change entries

GitOrigin-RevId: 4d49f8b02b9bfcfe470f6db21f5347080ff47562
2023-07-17 10:53:56 +00:00
Jimmy Domagala-Tang
718189bb07 Merge pull request #13527 from overleaf/jdt-upload-zip-error-handling
Upload zip error handling and retries

GitOrigin-RevId: 583fb57685e4957be325ab656443b884b854797d
2023-07-17 10:53:12 +00:00
Rebeka
7f5be3ed04 Make left menu sidebar a Modal
GitOrigin-RevId: 63630c2a98c3abb5c5ebbde0afe25c0aa981282b
2023-07-17 10:53:03 +00:00
Alf Eaton
b2014601b2 Remove Fine Uploader (#13637)
GitOrigin-RevId: e1e65160ad4a9c1d45a8f4a4a2e4c17730f9dda3
2023-07-17 10:51:33 +00:00
ilkin-overleaf
936ab81b65 Merge pull request #13641 from overleaf/ii-review-panel-migration-overview-view
[web] Create overview view shell for review panel

GitOrigin-RevId: 21cc8a744253aec53f089ec6e6c1221d7153f3a4
2023-07-17 10:50:58 +00:00
Alf Eaton
87013d20f8 Revert "[cm6] Show "move" cursor when the selection is ready to be dragged (#13532)" (#13673)
This reverts commit 1a89abceeadb6e1c53b4bc779df19b6723eab738.

GitOrigin-RevId: 05025068f75f1012626359230952e252e941d675
2023-07-17 10:50:49 +00:00
Alf Eaton
1cfc1eb269 [cm6] Show "move" cursor when the selection is ready to be dragged (#13532)
GitOrigin-RevId: 1a89abceeadb6e1c53b4bc779df19b6723eab738
2023-07-17 10:50:40 +00:00
Domagoj Kriskovic
39bd64b0a4 [cm6] fix toolbar overflow button calculation (#13669)
GitOrigin-RevId: 11380a5661067a285e0c0de82a37e085fc395f03
2023-07-17 10:50:30 +00:00
Alf Eaton
7202d7413e [rich text] Cover the whole command when selecting end-to-end (#11683)
GitOrigin-RevId: c3559ce68798047e7001b2a9857f2c168633af6c
2023-07-17 10:50:12 +00:00
Alf Eaton
7e20d41c4c Remove list items when list is toggled off (#13580)
GitOrigin-RevId: 19c63b26798fcf3c8e631090c614f0a693d4f071
2023-07-17 10:50:02 +00:00
Alf Eaton
52d9ee79a3 [visual] Handle selections adjacent to lists and section headings (#13581)
GitOrigin-RevId: 35b289102110f88587679740eeed575e16f6788b
2023-07-17 10:49:53 +00:00
Alf Eaton
1d33231392 Merge pull request #13597 from overleaf/ae-request-measure-view
[visual] Call view.requestMeasure in updateDOM if height could change

GitOrigin-RevId: eac77962d3edffd3ce3220c7948373bc38e6d727
2023-07-17 10:49:43 +00:00
Alf Eaton
a716a500c5 Merge pull request #13607 from overleaf/ae-formatting-keymaps
[cm6] Use toggleRanges for bold/italic shortcuts in code editor

GitOrigin-RevId: 90f7344876e84b984469ca2daccb7bbe71d89aa9
2023-07-17 10:49:34 +00:00
Alf Eaton
e41bda3e61 Merge pull request #13664 from overleaf/mj-bibtex-match-brackets
Add bibtex match brackets highlighting

GitOrigin-RevId: d0ed07d9874f097dd8b59eff582eb23a59f46332
2023-07-17 10:49:05 +00:00
Alf Eaton
c16d2d5840 [visual] Avoid showing list environment markup when the selection is within list items (#13461)
GitOrigin-RevId: cadab83774d52dc6c4867fdd7300a1217423b837
2023-07-17 10:48:56 +00:00
Miguel Serrano
01e3409eb4 Merge pull request #13485 from overleaf/msm-share-modal-fetch-tokens
[web] Fetch share tokens instead of sending via websocket

GitOrigin-RevId: f97bb91ca3ceb410fe860bf1c7802d8157d9f8b4
2023-07-17 10:48:10 +00:00
Mathias Jakobsen
67e7621633 Merge pull request #13572 from overleaf/mj-bibtex-grammar
[cm6] Add support for bibtex

GitOrigin-RevId: 28bc8e47c53df1612c1e30cf690e893b0bbf500c
2023-07-17 10:47:59 +00:00
ilkin-overleaf
e5d6777211 Merge pull request #13628 from overleaf/ii-review-panel-migration-resolved-comments-entry
[web] Add resolved comments entries functionality

GitOrigin-RevId: f0a8365b00c0861be12347aeaf486f7c02faf8e5
2023-07-17 10:47:41 +00:00
Domagoj Kriskovic
86753c19e5 [cm6] fix old editor-switch to show code editor (#13645)
* [cm6] fix old editor-switch to show code editor

* prettier

GitOrigin-RevId: 2c40c249c649b2675963db37a2aaeb4f0c457f7a
2023-07-17 10:46:52 +00:00
Domagoj Kriskovic
17452b51d7 [cm6] Add toolbar to Source Mode for Beta users (#13429)
* [cm6] toolbar for source mode

* top:0 for new toolbar

* empty div for extensions

* fix legacy css top pos

* show source toolbar split test

* prettier

* show beta icon in source editor

* dropdown toolbar wip

* fix wrong conflict resolve

* math dropdown, chrome extension fixes

* math dropdown cleanup

* sort en.json

* fix sort en.json

* using isVisual

* getMeta in component, pug update

* using flex grow

* toolbar beta badge

* remove extra whitespace

* has-legacy-toolbar class

* Increase container size

* fix tests

* prettier

* styling fixes, using SplitTestBadge

* only show source toolbar if flag is set

* fix typo

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: 34b01a9421f4a0d6defc40925c5092901575946e
2023-07-17 10:46:26 +00:00
June Kelly
a14e2aecfb Merge pull request #13483 from overleaf/jk-managed-users-group-management-ui
[web] Managed Users: Update Group Member Management UI

GitOrigin-RevId: 6896951927f0e3220db59dda208d7cfe9c6c309e
2023-07-17 10:46:16 +00:00
Mathias Jakobsen
c3a2786d82 Merge pull request #13570 from overleaf/mj-twitter-login
[web] Deprecate twitter login

GitOrigin-RevId: a1e81463b652239b780587976a96b65a8c6827f1
2023-07-17 10:45:58 +00:00
ilkin-overleaf
9e8be31bdf Merge pull request #13573 from overleaf/ii-review-panel-migration-comment-entry
[web] Create comment entries

GitOrigin-RevId: 7f3fbe672d18d57a0f5e683e5456ea79ed295e2d
2023-07-17 10:45:32 +00:00
Alf Eaton
8402081d9b [visual] Add decoration for footnotes (#13428)
GitOrigin-RevId: b0c8e475e9d8b4a19977a48b615596b88ce65797
2023-07-17 10:44:55 +00:00
Alf Eaton
4d39c31acc Merge pull request #13520 from overleaf/ae-state-tree
[visual] Refactoring in the atomic decorations state field

GitOrigin-RevId: e3cfd945dd900b3d7527bc9249132213d2a0e1bc
2023-07-17 10:44:45 +00:00
Alf Eaton
c6d832d6d9 Merge pull request #13594 from overleaf/ae-starred-caption
[cm6] Allow an asterisk after CaptionCtrlSeq

GitOrigin-RevId: e76e15afb676f6eddb8f09d710b0d90408584e29
2023-07-17 10:44:36 +00:00
Alf Eaton
62533ace6d Use StringQuery and selectWord from @codemirror/search (#12828)
GitOrigin-RevId: 23b3e6a5db8583646f378cef52f41889a73a3672
2023-07-17 10:44:26 +00:00
Alf Eaton
db26446d76 [visual] Avoid showing braces around section headings when editing the section title (#13464)
GitOrigin-RevId: 050663e752720993ccf1ab745a8b4250d54198fc
2023-07-17 10:44:17 +00:00
Alf Eaton
adbccde085 [cm6] Move cursor over existing closing brace when inserting a required parameter (#13494)
* Move cursor over existing closing brace

* Update package-lock.json

* Update tests

GitOrigin-RevId: dd729e41c2174d9f4563f2f47efcc075c7453ced
2023-07-17 10:44:06 +00:00
Alf Eaton
29f67a3985 Merge pull request #13525 from overleaf/jpa-teardown-compile-domain-test
[web] start tear down of split test for new compile domain

GitOrigin-RevId: 405bba924a37f56614b0744f47914306f420a028
2023-07-17 10:43:01 +00:00
ilkin-overleaf
b61ee4c4d3 Merge pull request #13528 from overleaf/ii-review-panel-migration-current-file-view
[web] Create initial current file container

GitOrigin-RevId: 81635922bb10b97637af296d987f28d43cf61262
2023-07-17 10:42:51 +00:00
Alexandre Bourdin
2ef48be496 Merge pull request #13448 from overleaf/ab-sub-dash-wording-changes
[web] Wording changes on the subscription dashboard buttons

GitOrigin-RevId: 9b5be3a39b2a4c6f92041aab1478f8a87e3a74cf
2023-07-17 10:41:51 +00:00
Alexandre Bourdin
39bc601826 Merge pull request #13482 from overleaf/ab-group-settings-page
[web] Group settings button and page enabled based on env var

GitOrigin-RevId: 77574a3705b3f1301935b72010022af61f7fe552
2023-07-17 10:41:41 +00:00
Davinder Singh
65b83f2272 Merge pull request #13488 from overleaf/ds-user-tabs-page
Admin panel - Users Tabs page react migration

GitOrigin-RevId: c0de37bf6bc6b54b41b2865039247b8bf65720d0
2023-07-17 10:40:45 +00:00
Mathias Jakobsen
ddf62722b1 Merge pull request #13384 from overleaf/mj-unused-angular-settings
[web] Remove unused angular settings

GitOrigin-RevId: 84621044f83654c2290119f7203c8aa68e03392f
2023-07-17 10:40:19 +00:00
Mathias Jakobsen
af76768eb7 Merge pull request #13372 from overleaf/mj-captcha-add-email
[web] Add recaptcha to add-email

GitOrigin-RevId: 0540e0dbc3103dcaac87dd7fabeedbc5892c371c
2023-07-17 10:40:08 +00:00
ilkin-overleaf
15db0ce4e3 Merge pull request #13492 from overleaf/td-review-panel-sync-height
Add hook for synchronizing review panel height with editor content height

GitOrigin-RevId: ef0a96ef4e77e7858b28f6f65254a4b0c1e778ea
2023-07-17 10:39:29 +00:00
ilkin-overleaf
423f2604db Merge pull request #13500 from overleaf/ii-review-panel-migration-nav
[web] Create review panel navigation

GitOrigin-RevId: abed4171e9fd52de2f137a6cf7456791bc2ca161
2023-07-17 10:39:20 +00:00
Domagoj Kriskovic
2ab0779374 [cm6] rename to Code Editor | Visual Editor (#13513)
* [cm6] rename to Code Editor | Visual Editor

* showLegacySourceEditor change

* show info badge

* remove info badge

* display info badge

* use "Visual Editor" in example project

GitOrigin-RevId: 549e25aa4bcfe58522eadc70e35ca35f822317b1
2023-07-17 10:39:10 +00:00
Domagoj Kriskovic
98aa084089 [cm6+rt] getParentNode account for commands with arguments (#13345)
* [cm6+rt] getParentNode account for commands with arguments

* add explanation comment

* added test

* prettier

* check commandAncestor in same position

* using ancestorOfNodeWithToRange

* function rename

GitOrigin-RevId: bb837d956d029c1026dab03825634f24d5bc3905
2023-07-17 10:39:00 +00:00
Rebeka
1f5c4c1c9c do not deep clone project in the filetree
GitOrigin-RevId: 043bafdd1ee37cc48eefb56a0dbb164eab0f54f1
2023-07-17 10:38:51 +00:00
Jimmy Domagala-Tang
1f71e339fb Merge pull request #12802 from overleaf/jdt-parse-all-blg
fetch all blg files to report errors

GitOrigin-RevId: eea9b0809e6b2efcf5df20961e94197c583463ef
2023-07-17 10:36:21 +00:00
ilkin-overleaf
15f4e2e5cc Merge pull request #13487 from overleaf/ii-review-panel-migration-create-panel-toggler
[web] Create review panel toggler

GitOrigin-RevId: f50422b99dbd8bbc2f1fbf323419ee13403c9ba6
2023-07-17 10:36:11 +00:00
Alf Eaton
a4d1ac2f13 Merge pull request #13477 from overleaf/ae-bottom-padding
[cm6] Improve bottom padding calculations

GitOrigin-RevId: 91fff97ebf6675cddffdd89118fd06f003321143
2023-07-17 10:36:00 +00:00
Alf Eaton
374e525cde Merge pull request #13406 from overleaf/ae-unicode-char
Use a Unicode-aware method to get the first character of the user name

GitOrigin-RevId: 04beccb906f40a452f03795b0cd9046bd95c32ec
2023-07-17 10:35:51 +00:00
Alf Eaton
7bed264d16 Merge pull request #13455 from overleaf/ae-lint-tokens
Fix linting in lezer-latex tokens file

GitOrigin-RevId: 2a2b5e8a05455da5f1260710ed34ae605fa8d3c1
2023-07-17 10:35:30 +00:00
Jakob Ackermann
55c5330108 Merge pull request #13463 from overleaf/jpa-bootstrap-ws
[misc] automatically call joinProject as part of connecting to real-time

GitOrigin-RevId: 2466168e9cebb62dec07481273050efcd0478114
2023-07-17 10:34:25 +00:00
ilkin-overleaf
e514e97305 Merge pull request #13438 from overleaf/ii-review-panel-toolbar-shell
[web] Create review panel toolbar shell

GitOrigin-RevId: 561fb18e1239c9b96b52944716a83cf3b8606677
2023-07-17 10:34:04 +00:00
June Kelly
5e1700b97a Merge pull request #13383 from overleaf/jk-fix-error-handling-password-reset-form
[web] Form errors: fall back to rendering error message if custom message not found

GitOrigin-RevId: 66947bdf46c787d7888f15f1471da12fc7a5cd80
2023-07-17 10:33:18 +00:00
M Fahru
2e77d4ab65 Teardown onboarding video tour test (#13351)
GitOrigin-RevId: 215c26fe047ec037f8d1d878eac406c36dbb656b
2023-07-17 10:32:51 +00:00
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
2023-07-17 10:32:07 +00:00
Davinder Singh
88d0254dde Merge pull request #13390 from overleaf/ab-managers-page-styling
[web] Full-row links styling for group subscription links in dash

GitOrigin-RevId: f3b2dd67e9c14cf8fde1df41d74d380c06cc3d4c
2023-07-17 10:31:18 +00:00
Alf Eaton
480ec139ab Merge pull request #13408 from overleaf/ae-revert-resolve-comment
Revert "create context api for review panel"

GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767 Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api
[web] Create context api for review panel

GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
2023-07-17 10:29:53 +00:00
Alf Eaton
5382178309 Merge pull request #13223 from overleaf/ae-typescript-upgrade
Upgrade TypeScript to v5

GitOrigin-RevId: 55d98c0e8fdeb39c1297b4472f0d604e25af995b
2023-07-17 10:29:14 +00:00
Alf Eaton
e025088065 Merge pull request #13241 from overleaf/ae-extensions-documentation
Add documentation for CodeMirror extensions

GitOrigin-RevId: e5f07084173f201919272f9d46dcdaef4b817874
2023-07-17 10:28:53 +00:00
Miguel Serrano
7e6613a1a0 Merge pull request #13327 from overleaf/msm-web-track-changes-cleanup
[web] Cleanup track-changes from web

GitOrigin-RevId: 8cef709ec5e91e4ffe8cd06826038ed84f36ef67
2023-07-17 10:28:12 +00:00
Domagoj Kriskovic
b70d5faca5 [cm6] alt+click to generate snippet for figure modal (#13279)
GitOrigin-RevId: fa8c4105ace55d73447b3afc60772f275728994c
2023-07-17 10:27:42 +00:00
Domagoj Kriskovic
e0980d652d [cm6] swap replace options in figure modal (#13277)
GitOrigin-RevId: 600ad5e340b1bc182986283c9c6dcb2040d4009f
2023-07-17 10:27:32 +00:00
M Fahru
8120d52de1 Fix "For students" link in footer isn't working properly (#13296)
* Fix "For student" link in footer isn't working because of hash being placed before querystring

* add scroll to top behaviour if "For students" link is accessed on the plans page

* Add an extra delay to make sure computation is finished before performing scroll to top behaviour

GitOrigin-RevId: 46b906271223267bc47ffcd781c25dc03f23a8e7
2023-07-17 10:27:02 +00:00
M Fahru
ed42d0c9ca Make the switch to editor/pdf button to have the same height (#12110)
GitOrigin-RevId: 5ceaad73c6c6b74ce2b6e8bbc79563bfad6ab34b
2023-07-17 10:26:34 +00:00
ilkin-overleaf
2fceaa6085 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
2023-07-17 10:26:04 +00:00
Jakob Ackermann
a75cda5f2a Merge pull request #13361 from overleaf/jpa-pdf-download-err
[web] add original error to MissingPDFException info

GitOrigin-RevId: 06c040847c67cc148b1b9a0358fa652779f01c39
2023-07-17 10:25:54 +00:00
Jakob Ackermann
8546bbc814 Merge pull request #13184 from overleaf/jpa-spacing-email-confirmation
[web] ensure spacing between email confirmation message and button

GitOrigin-RevId: 09bd10f79620374b73a4cf5cb5c91c14f00118ed
2023-07-17 10:25:15 +00:00
Rebeka
a412f3d70e Add error boundary to the project dashboard list
GitOrigin-RevId: 0f4cc3b4db62efe25ceeff202f305d08ddd73968
2023-07-17 10:24:38 +00:00
Tim Down
9db3230e97 Merge pull request #13309 from overleaf/td-history-font-size-setting
History migration: use font size, font family and line height from user settings in document diff viewer

GitOrigin-RevId: 59a0bfe3fa0403a971b7a9b0d5aba2ce37d976c8
2023-07-17 10:23:52 +00:00
Tim Down
f57c87a2a8 Merge pull request #13227 from overleaf/td-history-keyboard-scroll-diff-viewer
History migration: Add tabindex to document diff viewer to allow keyboard scrolling

GitOrigin-RevId: 95a0be27fa710a4f81e5944432b6b108e529634f
2023-07-17 10:23:42 +00:00
Alexandre Bourdin
584f614656 Merge pull request #13252 from overleaf/mj-rcases
[lezer] Support rcases

GitOrigin-RevId: 0bc0650533508ea8fb7c5f5953a6b1dc779db4ef
2023-07-17 10:22:55 +00:00
Alexandre Bourdin
150cf21710 Merge pull request #13311 from overleaf/ab-tear-down-subscription-pages-react
[web] Tear down subscription-pages-react test and remove Angular code

GitOrigin-RevId: 3cf906e476ffa52a058ccb4e4acbb89a657bd021
2023-07-17 10:22:45 +00:00
M Fahru
899ec09b70 Add a missing dropdownMenu: "main-button" segmentation on new welcome page (#13294)
GitOrigin-RevId: 08e803f2ab2243d86b095cb5a7196c97cea5d276
2023-06-01 08:05:10 +00:00
M Fahru
8c549aa0fa Implement new welcome page UI with split test (#11677)
GitOrigin-RevId: 3028ee5e34802e4f9a29cb752fcfa8ca6d5c284c
2023-06-01 08:05:01 +00:00
Tim Down
a74eecd110 Merge pull request #13259 from overleaf/td-history-survey-link
History migration: Add beta badge to history toolbar

GitOrigin-RevId: e5c818953a7d41c31018a2d39c3937d70c057f8c
2023-06-01 08:04:24 +00:00
Mathias Jakobsen
a4c684e266 [cm6] Add toolbar event for figure modal trigger (#13168)
* [cm6] Add toolbar event for figure modal trigger

* [cm6] Add event to figure modal edit button

GitOrigin-RevId: 04add4f801647dfcc38a54e1969b03c4a31b2462
2023-06-01 08:04:16 +00:00
Domagoj Kriskovic
174761850b [cm6] snippet using the same label as in figure modal (#13239)
* [cm6] snippet using the same label as in figure modal

* remove ace editor change

GitOrigin-RevId: 076d8b09ebdf61f992e9d3ce37fab84df38524ee
2023-06-01 08:04:07 +00:00
Domagoj Kriskovic
61e7f6f3a8 hide tooltip when button menu is opened (#13247)
GitOrigin-RevId: 1b6c1b09477dc9435996f3e190a72eb1a6c1d5cf
2023-06-01 08:03:59 +00:00
Domagoj Kriskovic
a05c201652 [cm6] indent figure modal generated code (#13213)
* [cm6] indent figure modal generated code

* fix: prettier

* fix indenting issues

* add licence on top

* fix cypress tests

GitOrigin-RevId: 8f74be537f19c2a29de3c742a9bbabe43b1ce40d
2023-06-01 08:03:49 +00:00
June Kelly
d68ed0efdf Merge pull request #13140 from overleaf/jk-real-time-disconnect-link-sharing
[real-time] Disconnect relevant users when link-sharing is turned off

GitOrigin-RevId: cf44a30a235717b658a759e8a74ae4d0e5abae47
2023-05-31 08:05:07 +00:00
ilkin-overleaf
bb815268f2 Merge pull request #13146 from overleaf/ii-history-react-save-last-selected-file-in-local-storage
[web] Save lastly selected file in the file tree

GitOrigin-RevId: 4b4dcdcb1340e253d4cd2003280f67385975d664
2023-05-31 08:04:59 +00:00
Rebeka
9fd9e991a7 Update Recurly card style based on split test variants
GitOrigin-RevId: 6c5bd6dffb9254400e7e134da8334957b929d78e
2023-05-31 08:04:50 +00:00
Miguel Serrano
51223315e4 Merge pull request #13164 from overleaf/msm-email-limit
[web] limit user email addresses to 10

GitOrigin-RevId: 038214cc921d86a407391e6c82fa9cd16a7f9646
2023-05-29 08:04:04 +00:00
M Fahru
3e315eada1 Teardown old project list frontend code (#11950)
* Remove frontend project list angular code (pugfiles + controllers)

* Remove unused translation keys in every language

GitOrigin-RevId: e0514721d6a32ca2de7d1be9433da3476ba1680c
2023-05-26 08:05:02 +00:00
M Fahru
c7a80f9228 History migration: Wrap history version item texts in version history list (#12961)
Texts that need individual wrapping so they won't overflow the history item:

- long file name
- long label name
- long tooltip text
- long user email

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: 3f75c4173dd59524de1148b22bcbc1d856c021eb
2023-05-26 08:04:53 +00:00
Tim Down
66dc566752 Merge pull request #13039 from overleaf/td-history-auto-select-file-ignore-binary
History migration: Ignore binary files when auto-selecting file to display in history view

GitOrigin-RevId: 7d2a314cdb3d54e4e2292a95e7633e3829ea931f
2023-05-26 08:04:29 +00:00
Tim Down
9a273949fd Merge pull request #13154 from overleaf/dk-selectFile-per-project
[cm6] rerender SelectFile component on project change

GitOrigin-RevId: ac59bdd100df6704c357a6af08028137f610bb13
2023-05-26 08:04:21 +00:00
Tim Down
1336ff8196 Merge pull request #13169 from overleaf/dk-dropimg-handler
[cm6] added drop handler to rich text

GitOrigin-RevId: 9972b788d680645ee83c3bc9376b9446a2b068e9
2023-05-26 08:04:12 +00:00
Tim Down
80a5f4594e Merge pull request #13130 from overleaf/td-history-add-label-autofocus
History migration: Autofocus input in add label dialog

GitOrigin-RevId: b51187e735414cd4b027413dfe57a0ba332c7b1a
2023-05-26 08:04:04 +00:00
Alf Eaton
510e686b7b Upgrade ESLint plugins (#13153)
GitOrigin-RevId: 9cd0b4429a9c2b3df9c18957aef21ef021e5fdfd
2023-05-25 08:05:34 +00:00
Alf Eaton
ac19140362 Unmask the editor when changing editor theme (#12604)
GitOrigin-RevId: 633d12c748cfd615fa72698f886a452c5b2fd2bb
2023-05-25 08:04:57 +00:00
Alf Eaton
142cfb51d9 Merge pull request #13173 from overleaf/td-history-menu-jump
History migration: Remove initial jump on displaying menu and line up menu items nicely

GitOrigin-RevId: f04c01565aa9ea128e87543fa7108d7fb0ae8657
2023-05-25 08:04:23 +00:00
Tim Down
ccacd4cab7 History migration: Abort previous GET requests (#12893)
GitOrigin-RevId: ad72d526bf7cdfa91b00025b58205d9a5b4cc62f
2023-05-25 08:04:15 +00:00
ilkin-overleaf
454f8f80c2 Merge pull request #13117 from overleaf/ii-history-react-changes-list-tests
[web] Add changes list tests

GitOrigin-RevId: 5a4e1ea647d737dc761e4258002e6507c76e95a9
2023-05-23 08:05:27 +00:00
Tim Down
19dc830bc6 Merge pull request #13127 from overleaf/td-history-fix-menu-position
History migration: Fix regression with positioning of the history change list item menu

GitOrigin-RevId: feb02101f3ae09102a4986ceb3fe8261b884ab33
2023-05-23 08:04:29 +00:00
Tim Down
fd8557ef39 Merge pull request #13159 from overleaf/td-history-comparison-text-icon-tweaks
History migration: Icon and text changes to version comparison, switch order of from and to

GitOrigin-RevId: e31db255c55caf15481ed0237875e637c0ac0861
2023-05-23 08:04:15 +00:00
Mathias Jakobsen
a06118b96d Merge pull request #13142 from overleaf/mj-figure-modal-paste
[cm6] Add image paste handler to rich text

GitOrigin-RevId: 3c814bf64438b387b7b08b8bf89b917347371492
2023-05-22 08:04:42 +00:00
Mathias Jakobsen
948d56e809 Merge pull request #13136 from overleaf/mj-figure-modal-spacing
[cm6] Adjust spacing in figure modal

GitOrigin-RevId: dc18186ff422292648d58c6d99718cc33e4d0f84
2023-05-22 08:04:26 +00:00
Mathias Jakobsen
5c95c907ec Merge pull request #13135 from overleaf/mj-empty-optional-argument-figure-modal
[cm6] Allow empty and missing optional arguments for figure modal

GitOrigin-RevId: 64e1310de21bdb3ff7ba244690cc83489bbfed40
2023-05-22 08:04:18 +00:00
Mathias Jakobsen
480672bf7a Merge pull request #13133 from overleaf/mj-wait-upload
[cm6] Wait for file to be ready before inserting code from figure modal

GitOrigin-RevId: 5c4e8f243518bacc7b6ef4272eaf44995192efbc
2023-05-22 08:04:10 +00:00
Christopher Hoskin
5bbe427ed0 Merge branch 'main' of github.com:overleaf/internal
GitOrigin-RevId: b0a13b4b4f7ede46d5ac5478dd03642d59e11a98
2023-05-22 08:04:01 +00:00
Alf Eaton
b35db4827d Merge pull request #13120 from overleaf/dk-drawselection-cm-patch
[cm6] apply cm patch for drawSelection bug

GitOrigin-RevId: 3adfcdbea4cc18d2cc197c153323fc62bafc364f
2023-05-19 08:04:34 +00:00
Alf Eaton
40eac4bd67 Remove fontWeight: bold from matched completion text (#13078)
GitOrigin-RevId: c375765ce0ca14200ba11c54ae1ac2c99a09961f
2023-05-19 08:04:17 +00:00
Alf Eaton
1f7d317db9 Upgrade pdf.js to 3.6.172 (#13112)
GitOrigin-RevId: 030528343f271a1fc1e07c3bba358873173bec76
2023-05-18 08:04:03 +00:00
Tim Down
ebbb4fd6d0 Merge pull request #13093 from overleaf/td-history-cm6-translations
History migration: Use translatable strings in history diff highlight tooltips

GitOrigin-RevId: 90c127b792c116c5805ee191b80564eb763cee44
2023-05-17 12:05:12 +00:00
Tim Down
6b78c3025a Merge pull request #12884 from overleaf/td-history-diff-line-highlights
History migration: Add line and gutter highlights for changes in diff viewer

GitOrigin-RevId: 11d637647d147210f63e5111305adfe1d285ba3e
2023-05-17 12:05:05 +00:00
Tim Down
c870bd5f53 Merge pull request #13104 from overleaf/td-history-compare-to-from
History migration: Add "compare to" and "compare from" options

GitOrigin-RevId: f550ad06b1e812011ecb32e6772354eb0abc2163
2023-05-17 12:04:56 +00:00
Miguel Serrano
27c2d1c16e [web] Personal Access Token Settings UI (#13040)
* [web] Personal Access Token Settings UI

* [web] Add Personal Access Token Settings UI to settings page

* [web] Added `personal-access-token-settings` unit tests

GitOrigin-RevId: 353b2f1a2b57c3292554f129be6cbb4f8f8382f8
2023-05-17 09:28:01 +00:00
Mathias Jakobsen
47b1a731fb Merge pull request #13118 from overleaf/mj-fix-centering-editable-graphics
[web] Always update centering in editablegraphics updateDOM

GitOrigin-RevId: 366a109c2006dea3cd3660f7a380fbbc0e203cca
2023-05-17 09:27:43 +00:00
Mathias Jakobsen
988fc57574 Merge pull request #13077 from overleaf/mj-figure-modal-tests
[web] Add cypress tests for figure modal

GitOrigin-RevId: 4debae1c665a68fd7bfa9f0dcfc150bec38a7c64
2023-05-17 08:06:33 +00:00
Mathias Jakobsen
c754eaf5c5 Merge pull request #13108 from overleaf/mj-figure-modal-translations
[web] Translate figure modal

GitOrigin-RevId: b9f2c2e9ba3141dfee15c0af572a022a2b21fd47
2023-05-17 08:06:16 +00:00
Mathias Jakobsen
f747cb000f Merge pull request #13097 from overleaf/mj-figure-modal-alpha-changes
[cm6+rt] Figure Modal alpha rollout changes

GitOrigin-RevId: f7591893e8f74aa9c9b41f4b98babecaac4b3c8c
2023-05-17 08:06:08 +00:00
Alf Eaton
c7544531c1 Add needsRefresh to lint source config (#13050)
GitOrigin-RevId: bc6880f87bc81c7f0f022268a4d070c267421c46
2023-05-17 08:05:36 +00:00
Alf Eaton
c8a72e96d4 [cm6] Improve keyboard shortcuts for toggling line comments (#13067)
GitOrigin-RevId: dd08778ea3621eefa75f306b2dada3f2c484f76c
2023-05-17 08:05:28 +00:00
Alf Eaton
fefc8384fb Ensure unique ids for tooltips (#13079)
GitOrigin-RevId: 9b6e5c60dade356549bb1b3fd9c6254ab00ace56
2023-05-17 08:04:48 +00:00
Alf Eaton
60370d5227 [cm6] Consolidate loose extensions (#13086)
GitOrigin-RevId: ff937418be5092b2b5197435e9cd60bc61f41b2c
2023-05-17 08:04:40 +00:00
June Kelly
0346e32906 Merge pull request #12836 from overleaf/td-history-performance
History migration: Improve performance of selecting or comparing versions

GitOrigin-RevId: 2a18a93c246fb94ed8d8b9770449be83364177ea
2023-05-17 08:04:07 +00:00
June Kelly
6c2bc2fe8b Merge pull request #13068 from overleaf/td-history-renamed-file-auto-select
History migration: Fix bug that prevents renamed files being automatically selected

GitOrigin-RevId: ce127b218d1eb472fe7b35467a17549f3db4bfb7
2023-05-17 08:03:58 +00:00
June Kelly
0aefc76f79 Merge pull request #13059 from overleaf/ii-history-react-submit-create-label-modal-with-enter-key
[web] Submit the label creation modal data by pressing Enter

GitOrigin-RevId: 6319a7963daf11422d679d9620e400e6f9069fea
2023-05-17 08:03:49 +00:00
June Kelly
ff4ac0a803 Merge pull request #12851 from overleaf/jk-dashboard-filter-visibility
[web] Improve filter visibility on project dashboard

GitOrigin-RevId: de7a9f999d6d0164ab3c18c58e305c7c628f946c
2023-05-17 08:03:39 +00:00
Alexandre Bourdin
d95eeb097a Merge pull request #13096 from overleaf/ab-disable-paypal-checkout-inr
[web] Disable paypal as a payment option when INR is selected

GitOrigin-RevId: f12796ac23d0c7dce1a06c12b7c8cef5f7acae6d
2023-05-16 08:05:46 +00:00
Mathias Jakobsen
e306369b9a Merge pull request #13085 from overleaf/mj-figure-rt-flicker
[cm6+rt] Reduce flickering of rendered figure

GitOrigin-RevId: a88845621228fa3a78ced023d5b5480ed600256a
2023-05-16 08:04:28 +00:00
Mathias Jakobsen
0bfd1fc852 Merge pull request #13016 from overleaf/dk-syncToEntry-detached
fix: navigate to error location for detached PDF mode
GitOrigin-RevId: 238f163f961e23e57d170180f918d8106b05c23e
2023-05-16 08:04:20 +00:00
Mathias Jakobsen
5fd4504f51 Merge pull request #13061 from overleaf/mj-cm6-translations
[web] Make translations accessible to CM6

GitOrigin-RevId: ef617638419597548e6e0545bac3ac94216177de
2023-05-16 08:04:11 +00:00
Mathias Jakobsen
31190b967b [cm6] Add figure modal (#12751)
GitOrigin-RevId: 3043d1369ed85b38b1fec7479385b123a304c05b
2023-05-16 08:04:02 +00:00
ilkin-overleaf
a94f241dcb Merge pull request #13009 from overleaf/ii-history-react-sticky-date-headings
[web] Improve the sticky date headings

GitOrigin-RevId: 0ba4c4d589b01d250198ecf97f7937200d393fe2
2023-05-15 08:03:03 +00:00
ilkin-overleaf
32160a8c80 Merge pull request #13038 from overleaf/ii-history-react-dropdowns
[web] Adjust dropdowns placement in history list

GitOrigin-RevId: 050e16b97630eb37c890ad9a97a56ba882cca06b
2023-05-15 08:03:00 +00:00
Domagoj Kriskovic
47f541690f [cm6] fix spell check issue, use new document range (#13035)
GitOrigin-RevId: 01b642dc867705c5de828fce439f424d7816d175
2023-05-15 08:02:57 +00:00
Domagoj Kriskovic
8c12bce5b6 fix outline issue: allow Ref in Math in latex.grammar (#13054)
* added failing test

* latex.grammar update: allow Ref in Math

GitOrigin-RevId: 340bf40cf4804e7693965a29b16b869a54a467d7
2023-05-15 08:02:53 +00:00
Alf Eaton
cc47299f62 Merge pull request #13033 from overleaf/ae-autocomplete-description
[cm6] Style the completion info to match the autocomplete tooltip

GitOrigin-RevId: d1a4db49fb0fff93e2004521ba8837131d321550
2023-05-11 08:05:46 +00:00
Alf Eaton
ea996582bf [cm6] Improve begin environment autocompletion (#12982)
GitOrigin-RevId: 42731e6f2261f7ed9b85523a550c636968698fc3
2023-05-11 08:05:37 +00:00
Alf Eaton
a248da99c1 Merge pull request #13021 from overleaf/ae-writefull-promo-chrome
Only show the Writefull promo banner to Chromium browsers

GitOrigin-RevId: 8a8765d2d55d431fd91360a821d5f9f994005ebc
2023-05-11 08:05:29 +00:00
Alf Eaton
d445ddd410 Unset closeOnBlur
GitOrigin-RevId: 481c530c112f02562b7c01fad22cfe42ddfa62eb
2023-05-11 08:05:20 +00:00
Dom Kriskovic
eafa8589c5 Revert "[cm6] close autocomplete menu on blur"
This reverts commit d47648044ca15cf29cc0c87479ba2a204f232a86.

GitOrigin-RevId: dc6bbcc30126d46a3b602896bfc18477fd07ab34
2023-05-11 08:05:04 +00:00
Dom Kriskovic
4c2537a753 [cm6] close autocomplete menu on blur
GitOrigin-RevId: e1475e1a1b4a0f05ab2926cfc5612abb3b9f39e8
2023-05-11 08:04:56 +00:00
Alf Eaton
466011df86 [cm6] Account for line shifts when updating the spelling line tracker (#13015)
* Use lineShift

* Use fromA instead of fromB

* Only check the update doc

* Always use oldDoc

* Copy tests

GitOrigin-RevId: 05e5516b09ee4a25d8ac2b5f2994a034f35c9e82
2023-05-11 08:04:48 +00:00
Jakob Ackermann
b6877cb4dd Merge pull request #12994 from overleaf/jpa-pdf-caching-fallback
[web] bring back support for proxies without HTTP-Range request support

GitOrigin-RevId: f0a4863ee175c332c9dea7da28987f293a903e63
2023-05-11 08:04:16 +00:00
Alexandre Bourdin
caeceba28c [web] INR Geo pricing test (#12976)
* Implement INR geopricing test

* Show again the INR banner after 30 days

* Update INRBanner to direct users to the plans page and add tracking

* Remove local testing hack in GeoIpLookup

* Update formatter for subscription dashboard

* Flip assignment to assign all users and add event segmentations

* Fix linting

* Review suggestions - factorised recommended currency helper function

GitOrigin-RevId: b1616520f8c7ead689a840720057297e67d3f574
2023-05-11 08:03:59 +00:00
Alf Eaton
0ffa75979f Merge pull request #13001 from overleaf/td-history-version-hover-style
History migration: Use green selected style when hovering over selected version

GitOrigin-RevId: 7771ce64d719c3d0e5264dfd2fbbf52f5b519213
2023-05-10 08:05:45 +00:00
Alf Eaton
4e6749966e Add Writefull promo banner to project list (#12843)
GitOrigin-RevId: a41746a29dfba867ff60401cfce1478812358644
2023-05-10 08:05:37 +00:00
Tim Down
5078f8ab43 Merge pull request #12962 from overleaf/td-history-loading-state-fix
History migration: Split updates and file diff loading states, move file restore load state out of context

GitOrigin-RevId: a994a1bdc8168043f045aaa3b7708bfce994d505
2023-05-10 08:04:59 +00:00
ilkin-overleaf
74a8d6111a Merge pull request #12987 from overleaf/ii-history-react-fix-label-selection-when-entry-with-no-label-is-selected
[web] Fix and improve labels and history entries selection

GitOrigin-RevId: 92c0b463a4cb9db7a293699e35c28ce5331de43a
2023-05-10 08:04:42 +00:00
ilkin-overleaf
aea43cee29 Merge pull request #12999 from overleaf/ii-history-react-file-tree-optimisation
[web] History file tree list items optimisation

GitOrigin-RevId: b5e9b72b7df857479db3b2a276e6c064d8f9427a
2023-05-10 08:04:34 +00:00
Tim Down
cf05b4a3d1 Merge pull request #12969 from overleaf/td-history-prevent-flashes
History migration: Prevent flash of previous document in document diff viewer when switching document

GitOrigin-RevId: dae99c13779006b61eb018772295376320770d3b
2023-05-10 08:04:26 +00:00
Tim Down
f8a2d85126 Merge pull request #12917 from overleaf/td-history-highlight-tooltip-improvements
History migration: Rework change marker tooltips to match Angular version behaviour

GitOrigin-RevId: c34e42db6c310521d04690de41f3bb81c219bfbc
2023-05-10 08:04:18 +00:00
M Fahru
c19fa74aa4 In history react file tree, always show badge (stick to the right side) and truncate long filename with ellipsis (#12897)
GitOrigin-RevId: 2e982f03b7a60e506f061a2c5bf1ab3d93dfccf5
2023-05-09 08:05:08 +00:00
Miguel Serrano
92ade70601 Merge pull request #12933 from overleaf/ii-history-react-select-latest-version-when-all-labels-are-removed
[web] Fix history entries and labels selection issues

GitOrigin-RevId: 73b14ba15ab4f0d9ff5946b1159ae7d5912582dd
2023-05-09 08:04:00 +00:00
Miguel Serrano
385e91652a Merge pull request #12929 from overleaf/msm-fix-templates-sp
[web] Fix template rendering in Server Pro

GitOrigin-RevId: 01dad18d61eb5a0e524cc80ddfcb55d0140a14cb
2023-05-08 08:05:04 +00:00
Alf Eaton
f2f7f6b7d6 [cm6] Add beginEnvironmentCompletionSource (#12913)
GitOrigin-RevId: eb4582606103268f1f2c90da7d372a0a33926e36
2023-05-08 08:04:26 +00:00
Domagoj Kriskovic
27ffe1c814 [cm6] Display non-standard spaces as special chars (#12927)
* [cm6] Display non-standard spaces as special chars

* specialChar background color

* removed Ideographic Space

* fix: lint error

* added Ideographic Space

* display only for source editor

GitOrigin-RevId: d94942cdc6a0aa17045b1783ac95de601f6ae15a
2023-05-08 08:04:18 +00:00
Alf Eaton
b1929cf16d [cm6] Improve symbol completion ranking (#12902)
GitOrigin-RevId: 8ccc87c2b86636bd37a3472d36873ade9a190209
2023-05-08 08:04:09 +00:00
Alf Eaton
009a108c71 Wrap setCursorHighlights in setTimeout (#12951)
GitOrigin-RevId: 204bf073bc2f4a014d9498c6a802fe38e52b22c5
2023-05-08 08:04:00 +00:00
Alf Eaton
0fba9dc374 Add a $CtrlSym group to the latex language (#12919)
GitOrigin-RevId: 4ee8ba7fe85f37dbe4cab04dae699b2a66007a2d
2023-05-08 08:03:51 +00:00
Jessica Lawshe
44c2b6d2b2 Merge pull request #12958 from overleaf/jel-payment-change-currency
[web] Add currency as a dependency of effect and query price with current currency

GitOrigin-RevId: 1bbb2c5cd71a0dc23642e9af1eddc4a8a129b7ae
2023-05-05 08:05:27 +00:00
Tim Down
a0e3379c86 Merge pull request #12939 from overleaf/td-history-more-update-scroll-amount
History migration: More update button scrolls next change to the centre

GitOrigin-RevId: 29d41a046f7110c246a0b9c784dedf6b148ea298
2023-05-05 08:04:53 +00:00
Tim Down
27457133e4 Merge pull request #12873 from overleaf/td-history-loading-improvements
History migration: Improve loading logic and display for loading file diffs

GitOrigin-RevId: 9d20c4632e6a804cb21e6fffd52faa88bc03f01a
2023-05-05 08:04:45 +00:00
Tim Down
95646a1bd5 Merge pull request #12936 from overleaf/td-history-diff-viewer-fixed-font
History migration: Use fixed font, text size, line height and theme in document diff viewer

GitOrigin-RevId: 9f86be609e0fe72ca41429bae9db03e047952c08
2023-05-05 08:04:37 +00:00
June Kelly
7d1d34726e Merge pull request #12914 from overleaf/mf-sort-file-tree-history-react
Sort react history file tree items with the same rule as the angular history file tree

GitOrigin-RevId: da3d3195fff1f5b05b232b329fc3cf38a65743f6
2023-05-05 08:04:04 +00:00
Jakob Ackermann
b0633b3a47 Merge pull request #12842 from overleaf/jpa-logout
[web] remove GET /logout endpoints

GitOrigin-RevId: 93f9498fdb66ece5028d90941aac50cda2737604
2023-05-04 08:05:57 +00:00
Rebeka
0c54e6605b Remove deprecated uses of badge style
GitOrigin-RevId: 47234e95acd42d7e5d23de8e3b67edca2bdd98d1
2023-05-04 08:05:40 +00:00
Alf Eaton
680a02892c Duplicate the cloneSelectionVertically key mapping to re-allow Ctrl on macOS (#12918)
GitOrigin-RevId: 747e8889b5e3b34dd9ffef888f4a1d42fea1af74
2023-05-04 08:05:31 +00:00
Alf Eaton
2093d85a5f Exclude CtrlSym commands from completion (#12905)
GitOrigin-RevId: f6d1813eba6c17444d2371b024f538137c244963
2023-05-04 08:05:23 +00:00
Alf Eaton
b010d6a5d3 Handle unset editor theme (#12892)
GitOrigin-RevId: 0e3413c08c6fd0752cd90ee868fec9b0f9f77437
2023-05-04 08:05:14 +00:00
Alf Eaton
2796f750ee Rename TrackChangesToggleButton prop to match onMouseDown attribute (#12862)
GitOrigin-RevId: bf2a83c58298ee809f181d95beddec695d223922
2023-05-04 08:05:05 +00:00
Alf Eaton
09c5bf72d2 [cm6] Use Cmd on macOS for cloneSelectionVertically (#12855)
GitOrigin-RevId: ea72da47f2ebb377cf22af061ab616a021950502
2023-05-04 08:04:57 +00:00
Alf Eaton
8a12c34fce [cm6] Emacs: close search form when Enter is pressed in "Find" input (#12841)
GitOrigin-RevId: a4c974f45e0dbb13d96b9b424f056768449791fb
2023-05-04 08:04:49 +00:00
Alf Eaton
6c21f0821c [cm6] Handle multiple selection ranges when applying snippets (#12830)
* Use fork of @codemirror/autocomplete
* Handle multiple selection ranges when applying snippets

GitOrigin-RevId: 04afc087ac127206463ea3d4950284a50308364a
2023-05-04 08:04:39 +00:00
Alf Eaton
05582567b4 Improve performance of search match counting (#12808)
GitOrigin-RevId: 70cd1aaf5b079cbd540c4a9f92a04fcb2786b308
2023-05-04 08:04:30 +00:00
Tim Down
7f17992cbc Merge pull request #12870 from overleaf/td-history-prevent-diff-render-on-label-change
History migration: prevent unnecessary render when adding or deleting a label

GitOrigin-RevId: acabd581403f17f863e3bd0c06d1fbd77fe22228
2023-05-02 19:45:31 +00:00
Tim Down
76103eb77f Merge pull request #12874 from overleaf/td-history-binary-file
History migration: Show alert for binary file preview

GitOrigin-RevId: f30e4946ce9f873661055b8a096c6aba7ab08e2d
2023-05-02 19:45:22 +00:00
Tim Down
a19dffeac2 Merge pull request #12877 from overleaf/td-history-file-tree-keyboard
History migration: Only activate document in file tree for space and enter keys

GitOrigin-RevId: 166a9ba36b1f19cd4e50d0e6f63ce04b164512cf
2023-05-02 19:45:14 +00:00
Tim Down
91db36bc01 Merge pull request #12883 from overleaf/td-history-deletion-marker-fix
History migration: Fix deletion marker class in theme

GitOrigin-RevId: d84c97632f467b116024ffc0992970b9aa586294
2023-05-02 19:45:05 +00:00
M Fahru
9e5aabea33 Implement auto retry mechanism for deleted file restore in history react (#12866)
GitOrigin-RevId: b30895061ee6fdfb6488d27ce2f91d4e410735aa
2023-05-02 19:44:57 +00:00
Tim Down
1fb921de99 History migration: Add error handling for all history requests (#12872)
* Add error handling for all history requests

* Remove comment

GitOrigin-RevId: 528dc98a0fc4ab523f8536274996c4166be45064
2023-05-02 19:44:48 +00:00
Tim Down
70bae34bd8 Add paywall to React history view (#12849)
* Implement history view paywall

* Add tests and some CSS fallbacks

* Make additional faded version above paywall non-clickable

* Change isFaded to faded for consistency

* Remove unused import

* Add missing attribute

* SHow all labels in free tier

* Address review comments

* Change Boolean conversion

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* Make adding or deleting a label show up in version list again

* Refactor to use visibleUpdateCount rather than maintaining two separate update arrays

* Removed unused import

* Use data-testid instead on class

* Round gradient values

* Correct test selector

---------

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: a2b021f3f4d3b9eb1358edb2ee4aa7db1bc7240e
2023-05-02 19:44:39 +00:00
June Kelly
e89b4b4214 Merge pull request #12811 from overleaf/jk-plans-event-currency-segmentation
[web] Add currency/id segmentation to Recurly analytics events

GitOrigin-RevId: 56998f403358d5f6b3cece6835e16e65e06635b1
2023-05-02 19:44:24 +00:00
ilkin-overleaf
5480e1b371 Merge pull request #12850 from overleaf/ii-history-react-fix-disappeared-pseudo-labels
[web] Fix disappeared pseudo labels

GitOrigin-RevId: 4d33eb8888cadbccba29ac001e205db8fa717c49
2023-05-02 19:44:15 +00:00
Alf Eaton
e0d9069131 [cm6] Add "within selection" option to the search form (#12798)
* Use forked @codemirror/search
* Use getPanel to get the search panel
* Remove layer-based highlightSelectionMatches
* Add "within selection" option to the search form
* Add test for "replace all within selection"
* Fix tests

GitOrigin-RevId: 95ce76fd017f96278b04c16a1fd34f785f7504a3
2023-05-01 08:05:02 +00:00
Alf Eaton
2606c76aec Merge pull request #12805 from overleaf/ae-markdown-types
[cm6] Fix type for Markdown language loader

GitOrigin-RevId: 725e1b28dd73e9090638f5d682e48e658c957a04
2023-05-01 08:04:45 +00:00
Alf Eaton
1da94f029c [cm6] Avoid selecting a search match when re-opening the search panel (#12797)
GitOrigin-RevId: 32bb03b71ce56cc0dbe6f7c92cc6d85151ef1971
2023-05-01 08:04:36 +00:00
Alf Eaton
40cbfc451a [cm6] Improve search match scrolling into view (#12787)
GitOrigin-RevId: 6ce9b86253a9c3a2c6ff44c10f78204ff16bd6e2
2023-05-01 08:04:27 +00:00
Alf Eaton
c53411ff1d Merge pull request #12776 from overleaf/ae-search-close-tooltip
[cm6] Add tooltip to search panel close button

GitOrigin-RevId: ba7f4ca5d672580054cb6214be94497fd5141730
2023-05-01 08:04:17 +00:00
M Fahru
0648b8aa6c Implement deleted file restore for history react (#12753)
* Add strikethrough to deleted file tree item in history file tree

* Add "restore file" button on toolbar if the selected file have a `removed` operation.

* Implement "restore file" functionality on removed file:

- Refactor the `Selection` object in history context value since we need the `deletedAtV` data which currently is not passed through the state.
- Refactor and clean up file tree type system to support passing through the whole `FileDiff` object for getting the `deletedAtV` data which only appear on `removed` operation
- Implement `postJSON` with file restoration API and pass it on restore file onClick handler at toolbar

* Implement loading behaviour while restoring file is inflight:

- Add `loadingRestoreFile` to `LoadingState`
- Change restore file button to `Restoring...` when in loading state.

* Refactor:

- Rename `DiffOperation` to `FileOperation`
- Extract `isFileRemoved` and `isFileRenamed` to its own file
- Extract `Toolbar` components into small files

GitOrigin-RevId: 2e32ebd2165f73fc6533ff282a9c084162efd682
2023-04-28 08:04:59 +00:00
Jessica Lawshe
afb810c2a1 Merge pull request #12772 from overleaf/td-history-infinite-scroll-fix
Fix bug in infinite scrolling in history view

GitOrigin-RevId: ae71e96a17197451ae583e5614adbbd9dda93ee0
2023-04-28 08:04:42 +00:00
Domagoj Kriskovic
3d5e8c9877 add 'Ace removal' notification (#12800)
* add 'Ace removal' notification

* prettier

* add memo, window.clearTimeout

* remove warning for server pro

* added tracking events

* useCallback for onClick

* fix: event rename

GitOrigin-RevId: 70bce8b93bae233e7183a941abaf2ec7a70ddfb6
2023-04-28 08:04:19 +00:00
Brian Gough
426128554d Merge pull request #12813 from overleaf/bg-add-inr-currency
add Indian Rupee (INR) prices to plan and group settings

GitOrigin-RevId: 6c058ed034d1566cfda17e73a8ba23d8bd7b7ab0
2023-04-27 08:07:45 +00:00
Domagoj Kriskovic
cd689e4e1f [cm6] Show Regex errors in find & replace (#12720)
* [cm6] Show Regex errors in find & replace

* cleanup, isInvalidRegExp function

* no state variable, less color var

* use @brand-dager

* using var(--ol-cm-search-form-focus-shadow)

* using state-danger-border

GitOrigin-RevId: 844c9dfee5a56d2a7494cd86c266acbe9eacd033
2023-04-27 08:05:14 +00:00
Domagoj Kriskovic
e311a22686 Merge pull request #12765 from overleaf/dk-fix-create-folder-name
fix: Clear new folder input after closing modal
GitOrigin-RevId: cde804212ef966f211804afc6bec1b207befeedc
2023-04-27 08:05:00 +00:00
ilkin-overleaf
0895e33235 Merge pull request #12773 from overleaf/ii-history-react-changes-list-dropdown
[web] Actions dropdown history migration

GitOrigin-RevId: 6b7055501c5eb1529b1794db92bb9f5f3faa6648
2023-04-26 08:05:24 +00:00
June Kelly
724a8d6113 Merge pull request #12698 from overleaf/jk-full-stops
[web] Add full-stops after 'Please use a different password'

GitOrigin-RevId: 9cac7c70358db11a74858252001a2dee211c0325
2023-04-26 08:04:30 +00:00
June Kelly
f5740e6b17 Merge pull request #12593 from overleaf/jk-remove-plans-split-test
[web] Remove 'plans-page-layout-v3' split test

GitOrigin-RevId: 91e0d3d8bc40632df630131b2e872fa824015da5
2023-04-26 08:04:21 +00:00
Brian Gough
70072481f4 Merge pull request #12783 from overleaf/ae-dev-tools-localstorage
[cm6] Use customLocalStorage in CM6 dev tools

GitOrigin-RevId: df4c40868b5a7b24b30483d55d1fbe75b5703776
2023-04-26 08:04:12 +00:00
Tim Down
afd1195902 Add infinite scrolling to history versions list (#12752)
* Add infinite scrolling to change list, add spinner while doing initial updates load, refactor updates state

* Update type in tests

* Update types

* Using LoadingSpinner component

* Remove redundant imports

GitOrigin-RevId: 98c7eae8edbc4d10d7107d825045edfc4159494f
2023-04-25 08:06:22 +00:00
Tim Down
bf076a8c97 Merge pull request #12721 from overleaf/td-history-improve-diff-highlight
Add markers for addition and deletion on empty lines in history diff

GitOrigin-RevId: 62e329da8bc055ee922854b837fe9465d724402e
2023-04-25 08:06:14 +00:00
Mathias Jakobsen
17ca11fae0 [cm6] Add save command to emacs (recompiles doc) (#12742)
GitOrigin-RevId: 10cda3f14411147d0d900f688d9b5017f49d2db2
2023-04-25 08:05:35 +00:00
Alf Eaton
f409b96f00 Fix padding in emptyLineFiller and lineWrappingIndentation extensions (#12736)
GitOrigin-RevId: 8b6a2ad0beb802d917f3e998c378792c6156836a
2023-04-25 08:05:27 +00:00
Alf Eaton
8537a7a5d0 Handle mode: 'none' in keybindings (#12717)
GitOrigin-RevId: 77d040352b1de2311f663a8b33bd0d20d79a30ae
2023-04-25 08:05:18 +00:00
Alf Eaton
4bb582bdd8 [cm6] Improve Tab behaviour in read-only mode (#12715)
* Improve Tab behaviour in read-only mode
* Remove Tab shortcuts from Markdown configuration

GitOrigin-RevId: 9eb804fcf820b37b371b1c351cfbdf7bff1ced89
2023-04-25 08:05:10 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710)
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Alf Eaton
acf6abb0fb [cm6] Use a block widget for padding at the top of the editor (#12705)
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
2023-04-25 08:04:53 +00:00
M Fahru
4dec157e08 Implement history react toolbar UI (#12530)
There are two different UI in this PR: `comparing` and `viewing` mode.

- For `comparing`, the user would be shown two separate date. It uses the `UpdateRange` object and this PR adds a timestamp to both `fromV` and `toV` of the object type.
- For `viewing`, the user would only be shown one date since `viewing` mode means viewing a specific update version.

Some other notable changes:

- Move `diff` state to `diff-view.tsx`, which contains `main.tsx` (main editor history view) and `toolbar.tsx` as its children
- refactor `autoSelectFile` by passing `updateRange.toV` directly
- refactor `updateIsSelected` by passing an object that contains `fromV` and `toV` instead of passing `update

There's also a cypress test for both the `viewing` mode and `comparing` mode in this PR.

GitOrigin-RevId: ba54f073f3479c55a39eb6b2932ea7faff78dddc
2023-04-21 08:03:39 +00:00
M Fahru
08d2eea47a Decouple history-file-tree styling out of editor file tree:
- Extract/duplicate the style from editor file tree (only extract styling that's being used in history file tree)
- Change some of the class name to avoid duplicated class name from the editor file tree
- Revert change to editor file tree since it has been moved to history file tree

GitOrigin-RevId: 6c3b20080c9b428363024db622f60e3540d919e6
2023-04-21 08:03:36 +00:00
Ilkin Ismailov
dd5509b16f add sm size to badge
GitOrigin-RevId: 4e69d582ce770abcff10f3a6b34662f4873fc224
2023-04-21 08:03:33 +00:00
M Fahru
8212b686c6 Implement new style for history file tree badge
GitOrigin-RevId: 6221bc00e5aecf49fd3f2657128d1e9a2d4e648b
2023-04-21 08:03:30 +00:00
Mathias Jakobsen
81a8fa2ce3 Merge pull request #12672 from overleaf/ae-emacs-compile-keydown
[cm6] Stop propagation of Ctrl-s when Emacs keybindings are enabled

GitOrigin-RevId: 32bebefb583ad813931af221cce7498d40fdbaf1
2023-04-21 08:03:11 +00:00
Mathias Jakobsen
462837b44d Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space
[cm6] Add space after item autocomplete

GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
2023-04-21 08:03:08 +00:00
Mathias Jakobsen
29b056d5a3 Merge pull request #12682 from overleaf/mj-def-whitespace
[lezer] Allow whitespace before macro parameter

GitOrigin-RevId: 14bd8428f0a78fb71184bf300dac0b2b1e3abd3c
2023-04-21 08:03:02 +00:00
Mathias Jakobsen
3bd174631a Merge pull request #12696 from overleaf/mj-rt-skip-more-preamble
[cm6+rt] Update skip-preamble-cursor to skip \maketitle and abstract

GitOrigin-RevId: 3c54d8159bfdb431763872790a2b82ac4cffc09f
2023-04-21 08:02:59 +00:00
Mathias Jakobsen
59b3b9b933 Merge pull request #12631 from overleaf/ae-readonly-focus
[cm6] Prevent the editor being focused when read-only

GitOrigin-RevId: 7de9f2df2421b57b3315d59d640f7c8b46caf178
2023-04-21 08:02:56 +00:00
Mathias Jakobsen
c2292a8567 Merge pull request #12677 from overleaf/ae-codemirror-view-upgrade
[cm6] Upgrade CodeMirror dependencies

GitOrigin-RevId: cc973b1c5b23eca0fc93a9b3a970c832212e47af
2023-04-21 08:02:53 +00:00
Rebeka Dekany
df300b5f24 Fix: Chat messages deduplication (#12667)
* Prevent the duplicated message IDs by filtering them out

* fix: Prevent the duplicated message IDs by filtering them out

GitOrigin-RevId: 6d6c2821e6e29c9949fd323fa3a507016b51aff4
2023-04-19 08:03:31 +00:00
Tim Down
5f5e07a334 Merge pull request #12668 from overleaf/td-history-scroll-to-first-change
Scroll to first change in history document diff viewer

GitOrigin-RevId: e135877ca440c5eb2732890e8723d9098444727f
2023-04-19 08:03:28 +00:00
Tim Down
99e1ff0804 Merge pull request #12644 from overleaf/td-history-compare
Initial implementation of comparing history versions

GitOrigin-RevId: 890e270d6e41856a79689ab41ccfbde25c4703ba
2023-04-19 08:03:25 +00:00
Alf Eaton
924012e21f [cm6] Avoid overwriting themed syntax highlighting colours when editing Markdown (#12648)
GitOrigin-RevId: ed5d558544839978862004a8b7feb80806a2100d
2023-04-19 08:03:04 +00:00
Alf Eaton
5717f51042 Merge pull request #12643 from overleaf/ae-initial-active-line-highlight
[cm6] Fix initial active line highlight

GitOrigin-RevId: 54de6a176e826ed7d7f1016ba6cee7a8803f0be4
2023-04-19 08:02:53 +00:00
Alf Eaton
f205d1f31d Merge pull request #12621 from overleaf/ii-history-react-delete-labels
[web] Delete history tags

GitOrigin-RevId: 0a2846bbb3e99ef632b9192a9f8c04f702645506
2023-04-19 08:02:47 +00:00
Mathias Jakobsen
c8f7bc54bc [web] Add split test for testing editor switch naming (#12596)
Co-authored-by: Ieva Vaiginyte <95856891+ievaoverleaf@users.noreply.github.com>
GitOrigin-RevId: dafe07bda841dad962ebf2894718750fafe86373
2023-04-18 08:04:59 +00:00
Jimmy Domagala-Tang
77c2db38fc Merge pull request #12566 from overleaf/jdt-ghost-danger-buttons
feat: adding danger ghost buttons
GitOrigin-RevId: 2ee6ea1c395ba4a73fbe09b36acde3145c590a6b
2023-04-18 08:04:51 +00:00
Tim Down
b07535f15b Merge pull request #12641 from overleaf/td-source-editor-import-fix
Fix for incorrect import

GitOrigin-RevId: 5814fbf888446f7cbc9464565ab13f3b1db8b54f
2023-04-17 08:05:57 +00:00
Tim Down
23b9c078b8 Merge pull request #12636 from overleaf/td-history-autoselect-file
Simplify file autoselect in React history view

GitOrigin-RevId: 43f070b26ab0a75af13063712b5cf05778da4064
2023-04-17 08:05:49 +00:00
Tim Down
38998afa8e Implement history diff viewer buttons (#12439)
GitOrigin-RevId: 0ed8eb8568783b4938188a86c4ee75c767e6d713
2023-04-17 08:05:41 +00:00
Alf Eaton
63b2064420 [cm6] Add scrollIntoView when commands are dispatched (#11678)
GitOrigin-RevId: be005885330b9b29c7ddbfeacaec0a41d96e5e25
2023-04-17 08:05:33 +00:00
Mathias Jakobsen
7d237d0103 [cm6] Only swallow text in autocomplete insertion if node is well-formed (#12562)
* [cm6] Only swallow text in autocomplete insertion if node is well-formed

* [cm6] Use longest common prefix heuristic for autocompletion in ill-formed nodes

GitOrigin-RevId: 5adf3dc0314d86b267e2142a1250dece3ab29ef8
2023-04-17 08:05:24 +00:00
Mathias Jakobsen
73191f56e1 [cm6+rt] Make formatting commands work after UnknownCommands without arguments (#12625)
GitOrigin-RevId: 0eb59e6580d6f217c46424ede0fa6f79c8786940
2023-04-17 08:05:16 +00:00
Mathias Jakobsen
4b2cc907e2 [cm6] Change Emacs commands to visual-line-mode (#12523)
* [cm6] Change Emacs commands to visual-line-mode
* [cm6] Change line deletion commands to visual line mode

GitOrigin-RevId: 7a4f3d66bec611de410b6c1fbafbfe33b974e37b
2023-04-17 08:05:08 +00:00
Alf Eaton
6ca565fa90 Fix autocomplete hotkeys description (#12607)
GitOrigin-RevId: f7f80fdf56f97ee70accec0162e6b395cfd16584
2023-04-17 08:04:51 +00:00
Alf Eaton
359255b820 [cm6] Use a modified fork of the closeBrackets extension (#12573)
GitOrigin-RevId: a24020ed216cb10defff989f5876666c29889de2
2023-04-17 08:04:43 +00:00
Alf Eaton
dda9230c6c [rich text] Add "Insert Citation" and "Insert Cross-reference" buttons (#12529)
GitOrigin-RevId: fde2f1a281318afede138ccae12f73ade3fa9f65
2023-04-17 08:04:34 +00:00
Alf Eaton
39df55787c Improve handling of doc:saved events (#12522)
GitOrigin-RevId: 0ebf198548f6aeecb356405b0c582d3fd64db391
2023-04-17 08:04:26 +00:00
Alf Eaton
a8ed6b65e1 [cm6] Improve "vertical overflow" handling (#12405)
* Avoid setting style on the editor view whenever overflowPaddingState changes
* Round values in recalculateScreenPositions
* Refactor ignoreGeometryChangesUntil slightly
* Restore the original value

GitOrigin-RevId: 75c57be21dd16a748c0d9b14058386849a80b831
2023-04-17 08:04:18 +00:00
Alf Eaton
ab10fd99f5 Add CodeMirror dev tools extension (#12142)
GitOrigin-RevId: 148a0fba5faf6dc8f638fcb4666e2fda6c5c6c40
2023-04-17 08:04:09 +00:00
Alf Eaton
161decd67d Upgrade @codemirror/view (#12574)
* Upgrade @codemirror/view
* Disable emptyLineFiller extension

GitOrigin-RevId: 57ce4194ece0ea448e24184f0b3a3e13352cb014
2023-04-17 08:04:00 +00:00
Jakob Ackermann
1096c81f4a Merge pull request #12528 from overleaf/jpa-switch-dashboard-events-to-bq
[web] switch events on project dashboard to BQ

GitOrigin-RevId: 9326c19cc5663c4dc2919877eb8df91e312bb902
2023-04-14 08:03:12 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
M Fahru
3f992f9453 Ensure new data are fetched properly whenever history is opened (#12577)
GitOrigin-RevId: e0ae14cdc90c95dbd44b12bd8332bc982ea34a10
2023-04-13 08:04:45 +00:00
Alexandre Bourdin
f03b75e55f [web] Tags/color picker tweaks (#12595)
* Change wording of tags header and hide uncategorized when tags list is empty

* Add a tooltip on the colour picker more button

* Fix linting

GitOrigin-RevId: 07e1c411c2c9f6f66e0a00c1610af662b829c4e4
2023-04-13 08:04:37 +00:00
Alexandre Bourdin
376d9c43a3 Merge pull request #12374 from overleaf/ab-rename-folders-tags
[web] Rename folders to tags

GitOrigin-RevId: 05c34c515aeeb9230ed512c267f97bcb679767a8
2023-04-13 08:04:20 +00:00
Alexandre Bourdin
481cd14cb1 Merge pull request #12557 from overleaf/ii-history-react-labels-only
[web] History labels only list

GitOrigin-RevId: 58b8e5a5af0754e32841223f9c478c25900df526
2023-04-13 08:04:12 +00:00
Alexandre Bourdin
04c204f989 [web] Colour picker for tags (#12255)
* Base for color picker

* React color picker and updated modals

* Add tag color picker to mobile dashboard

* Update existing tests and fix disable save button condition

* CSS adaptations for desktop modal streched into mobile display

* Update TagsController tests

* Add aria-hidden label on color pickers

* Fix linting

* Fix project list test

* Select random color when creating tag

* Cleanup leftovers in project list context

* Test cleanup

* Pre-select custom color and store local color while picking

* Add type to preset colors

* Add css fix to override disabled button opacity

* Skip redundant check

* Fix linting

* Add back btn-secondary on manage tag modal after rebase

GitOrigin-RevId: a4cf24e85cc0ca01466f4bf9c77482be8360e68e
2023-04-13 08:04:03 +00:00
M Fahru
fb6746a887 Add default pathname logic on history react file tree (#12505)
On history react, when the initial screen has been loaded, no default pathname is selected. This PR adds logic for selecting default pathname and getting the diff for that pathname.

Also, add some other small changes, the notable ones are:

- Refactor some type naming and file structure related to the history file tree
- Refactor file tree selectable hooks (merge selectable context provider into the main provider)
- prevent clicking on the same file tree item by checking the current pathname before invoking the handler function

GitOrigin-RevId: 73c36e9ed918ae3d92dd47108fbe8542a7571bdd
2023-04-12 08:04:58 +00:00
June Kelly
17109393c5 Merge pull request #12387 from overleaf/jk-split-button-tweaks
[web] Split-menu style tweaks

GitOrigin-RevId: a04121981c4fe240c247cf03da5be7052c26f541
2023-04-12 08:04:28 +00:00
June Kelly
841df71a1d Merge pull request #12342 from overleaf/jk-password-ux-please-use-another-password
[web] Password UX: 'Please use another password'

GitOrigin-RevId: ca9b26cbcf2dabb27c716da314764ee40ffc83dd
2023-04-12 08:04:13 +00:00
ilkin-overleaf
8e0aa685ce Merge pull request #12549 from overleaf/ii-history-react-list-of-all-versions
[web] All versions of history entries

GitOrigin-RevId: 7365ac4913c115b3b2872a3713d893463719c15e
2023-04-12 08:03:47 +00:00
Miguel Serrano
ea0df8a7dd Merge pull request #12506 from overleaf/msm-check-github-module-frontend
[web] add checks for github and V1 being available

GitOrigin-RevId: 90ba19d41c28bbc96d07825086697d2f946eabcd
2023-04-05 09:05:27 +00:00
M Fahru
17a98d756e Add badges UI to history react file tree (#12479)
GitOrigin-RevId: 52c45b72110e01bb193139654fa9385cb9b9e489
2023-04-05 08:03:05 +00:00
Jessica Lawshe
a4586074d7 Merge pull request #12442 from overleaf/jel-bsStyle
[web] Add bsStyle to `react-bootstrap` buttons

GitOrigin-RevId: 0059a457cbd8b4c316aa3b34e4d77f1b92bd690e
2023-04-05 08:02:50 +00:00
Eric Mc Sween
6b110cf4d0 Merge pull request #12481 from overleaf/td-history-remove-source-editor-imports
Remove accidental imports from source-editor module in history

GitOrigin-RevId: 808597e113c3b1e74cacc712313af0e20b0e1786
2023-04-04 12:22:25 +00:00
M Fahru
9a55bbf325 Port editor react file tree to history file tree (#12453)
This new history file tree is mostly copied from the editor file tree, with some of the features stripped away:

1. Remove multiple selections
2. Remove drag and drop ability
3. Remove the ability to rename files & folders
4. No more right-click hijacking (context menu)
5. No more triple dots menu on a file tree item shown
6. No file references, since history doesn't have the data to differentiate between real files and linked file
7. etc (some other small changes that are not too important to be listed)

Other notable changes:

1. Simplify the selectable provider (the only context provider being copied from react file tree)
2. Convert to typescript

GitOrigin-RevId: 1017e545b2bd99775e01307a9b7eac2daf454014
2023-04-04 08:05:30 +00:00
ilkin-overleaf
dfda9d0677 Merge pull request #12434 from overleaf/ii-history-react-feature-flag
[web] Fix history view feature flag

GitOrigin-RevId: af2e76074ed43ec1ed1b877a6ffd403abab48ec8
2023-04-04 08:03:50 +00:00
Tim Down
11f8905be4 Connect up document diff viewer to history state
GitOrigin-RevId: 610a254ea77c194969033d0791ecf1129e02c4bf
2023-03-31 08:03:47 +00:00
ilkin-overleaf
867b37b76f Merge pull request #12417 from overleaf/ii-history-react-toggle-switch
[web] Toggle switch history migration

GitOrigin-RevId: c0812d03d576bc66dd8878fa80d4ac18dd8576d0
2023-03-30 08:04:22 +00:00
M Fahru
568092e16b Add react file tree UI to history view (#12357)
* Add react file tree UI to history view

* Use history data from API to render react file tree in history view

GitOrigin-RevId: 2b1eb5422f0c91fdf5e87e21d1e5d06defd45e98
2023-03-30 08:04:17 +00:00
ilkin-overleaf
8ee8f2ded3 Merge pull request #12370 from overleaf/td-history-basic-editor
Basic document diff viewer for history view

GitOrigin-RevId: a6919cc003f8f7fad24126e407313013cf489b63
2023-03-30 08:03:48 +00:00
ilkin-overleaf
95c8a1aeea Merge pull request #12366 from overleaf/ii-react-history-context
[web] Add context to history

GitOrigin-RevId: bc504994c50c0e7abe8181a671357d5db59a3343
2023-03-30 08:03:43 +00:00
Alf Eaton
4c9c0641b2 Avoid reading some variables directly from window (#12280)
GitOrigin-RevId: 93af19498470fd7903db9d55d7468f0298097cc4
2023-03-30 08:03:32 +00:00
Alf Eaton
9c78422efa Jump to line after the stored scroll position has been restored (#12324)
GitOrigin-RevId: 82265c6b0cab1ed3a34343efc5d47648e72dc41e
2023-03-30 08:03:25 +00:00
Tim Down
397fbd47c2 Merge pull request #12363 from overleaf/td-history-main-area-shell
Add CSS for main history view shell

GitOrigin-RevId: 9c455007bf8b177d59ea97cd73b608d48aba3907
2023-03-30 08:02:54 +00:00
ilkin-overleaf
d1d47b2767 Merge pull request #12339 from overleaf/ii-react-history-editor-and-change-list-init
[web] History editor and change list initialisation

GitOrigin-RevId: bb7800301d28c296bd524212cd27ddcd8defd149
2023-03-23 09:06:24 +00:00
Tim Down
e76bcbec8d Merge pull request #12316 from overleaf/td-history-view-shell-and-split-test
Add empty shell for React history view, viewable based on split test

GitOrigin-RevId: 97241d56a052648c7a0d293d323dad4b00ad4159
2023-03-23 09:04:38 +00:00
Miguel Serrano
aee777ca1d Merge pull request #12286 from overleaf/msm-fix-sp-react
[web] Fix Null Pointer Exception with `templateLinks` in CE/SP

GitOrigin-RevId: 3b5597e70e73bc605bece3d2f463f58c01acac8e
2023-03-21 09:05:54 +00:00
M Fahru
5ae698ec6c Migrate "Manage Template" in editor left menu to react (#10609)
This feature is only available on server pro

GitOrigin-RevId: 7fc508c8039c2e3afd1a5fca469fce411e9d913a
2023-03-21 09:05:29 +00:00
ilkin-overleaf
122d2310e6 Merge pull request #12278 from overleaf/ii-change-email-confirmation
[web] Show confirmation modal when making an email primary

GitOrigin-RevId: eb67fc37c18a5ecd59973baa27ee9ef8e4b67423
2023-03-21 09:04:23 +00:00
Jessica Lawshe
5ae4e68380 Merge pull request #12185 from overleaf/jpa-fix-segmentation
[web] old plans page: fix event segmentation for plans-page-click

GitOrigin-RevId: 9be23a9cf9d92b88d6fbe8c6e2b941cf3ac63344
2023-03-17 09:06:08 +00:00
Alf Eaton
f375362894 Always use mockable location methods (#11929)
* Always use mockable location methods
* Add eslint rules for window.location calls/assignment
* Add useLocation hook
* Update tests

GitOrigin-RevId: eafb846db89f884a7a9a8570cce7745be605152c
2023-03-17 09:05:21 +00:00
Jakob Ackermann
df3c7e48ab Merge pull request #12198 from overleaf/jpa-force-new-compile-domain
[web] changes for force-new-compile-domain test

GitOrigin-RevId: a4ceaf46fdcebed156d155385cbbc2f06405d31f
2023-03-17 09:04:49 +00:00
Jakob Ackermann
223b8aa9d8 Merge pull request #12250 from overleaf/ii-add-new-email-blocklist
[web] Prevent Blocklisted domains from appearing as suggestion

GitOrigin-RevId: b02bebe3e043cb264fbdbffce3f783b3af483e95
2023-03-17 09:04:33 +00:00
Jakob Ackermann
798df873c4 Merge pull request #12200 from overleaf/ii-pdf-view-moves-to-the-left
[web] Make pdf view consistent when recompiling

GitOrigin-RevId: 1c76a1c8e0b8b024c7d0d033f92ff900e70909a6
2023-03-17 09:04:25 +00:00
Eric Mc Sween
650fe7b662 Merge pull request #12199 from overleaf/em-revert-12066
Revert "Merge pull request #12066 from overleaf/em-multibib-errors"

GitOrigin-RevId: 8ba55849c54d61e62c80882fd53773ea3fd19948
2023-03-14 09:05:00 +00:00
Miguel Serrano
9ecc84f0b0 [web] download-pdf-button-click event tracking (#12059)
* [web] `download-pdf-button-click` event tracking

GitOrigin-RevId: 20baae4fff989b5120ae03f81cc47f7d6874dd7b
2023-03-14 09:04:44 +00:00
Eric Mc Sween
862276f8a1 Merge pull request #12066 from overleaf/em-multibib-errors
Parse all .blg files after a compile

GitOrigin-RevId: be84974c247fd7a476a12c47943ab54947146e4c
2023-03-14 09:04:22 +00:00
Jakob Ackermann
7ae5a9f060 Merge pull request #12160 from overleaf/mf-old-plans-page-annual-button
Fix annual buy button in old plans page is linked to the free trial check out page

GitOrigin-RevId: 7157b354a21e46f4eb194ae1ef741e90790b6071
2023-03-13 09:04:23 +00:00
Thomas
5dc15a19de Merge pull request #12083 from overleaf/tm-teardown-refreshed-payment-page
Tear down refreshed payment page test, keeping refreshed page

GitOrigin-RevId: 4f0d9a1f4bcd3b018b12372fbe86aad3c8e41fbd
2023-03-10 09:04:18 +00:00
Jessica Lawshe
b10b7b1f91 Merge pull request #12042 from overleaf/jel-change-plan
[web] Change plan UI now in a modal and update the style

GitOrigin-RevId: 1b501b4a972ca676cff32f531862c15c0c8f9e61
2023-03-09 09:05:05 +00:00
Jessica Lawshe
4380f20f08 Merge pull request #11996 from overleaf/jel-pdf-detach-download
[web] Add download attribute to download button in file view

GitOrigin-RevId: 7fdbd970d87bd3678863f23be993a34140a5726b
2023-03-09 09:04:49 +00:00
M Fahru
20f8fc2dc0 Revert "Refactor project list notification by using onDismiss on Alert instead of custom Close component (#12043)" (#12133)
This reverts commit 9a3f95c322a063b84094452c21cb734a379da978

GitOrigin-RevId: 31fb4b1d429e2e9c611178afc3dc3c662340be44
2023-03-07 09:06:25 +00:00
M Fahru
06b75ebee2 Refactor project list notification by using onDismiss on Alert instead of custom Close component (#12043)
* Refactor project list notification by using `onDismiss` on `Alert` and not using the custom `Close` component

* Add dismissible alerts to storybook

GitOrigin-RevId: 9a3f95c322a063b84094452c21cb734a379da978
2023-03-07 09:05:48 +00:00
Jakob Ackermann
3486cd0c91 Merge pull request #12054 from overleaf/ii-thank-you-page-add-missing-colon
[web] Add colon after translation in price exceptions

GitOrigin-RevId: 99dc7cb25373693edf4b06f5a2640ed7a1491777
2023-03-07 09:04:41 +00:00
M Fahru
f7131b720b Implement onboarding video tour split test (#11889)
* Implement onboarding video tour split test:

- Add split test infrastructure
- Create new `OnboardingVideoTourModal` component
- Place the component inside the editor pug template with a split test

* add event segmentation for `onboarding-video-tour-close-button-click` event:

1. video: `first` | `second`
2. firstVideoWatchingTimeInSecond: total time watching first video
2. secondVideoWatchingTimeInSecond: total time watching second video (0 if skipped)

* add event segmentation for:

1.  `onboarding-video-tour-dismiss-button-click`
2. `onboarding-video-tour-next-button-click`
3. `onboarding-video-tour-done-button-click`

with these key/value:

1. firstVideoWatchingTimeInSecond: total time watching first video
2. secondVideoWatchingTimeInSecond: total time watching second video (0 if skipped/not watched yet)

* Use contentful to host video assets

GitOrigin-RevId: 27a6f38d15d7a03b07455e216dda63d99983ca80
2023-03-02 09:05:43 +00:00
M Fahru
351ab1979b Prevent github menu in project list react to be included in SP/CE build (#11951)
GitOrigin-RevId: 58d0378d2307f5c38ea4446b684993aec29fa292
2023-03-02 09:05:25 +00:00
Tim Down
fec6b8e4f1 Merge pull request #11961 from overleaf/mj-helpful-graphics-error-alternatives
[web] Handle more types of undefined control sequence error messages

GitOrigin-RevId: c6fc0c4d87febcda2521e182df56dcebaed58293
2023-03-02 09:04:53 +00:00
ilkin-overleaf
8616c53839 Merge pull request #12031 from overleaf/ii-payment-page-migration-three-d-secure-currency-change
[web] 3DS currency change fix

GitOrigin-RevId: e88c773c6576e55803df3b2ec6a6acb1df80e8f2
2023-03-02 09:04:13 +00:00
ilkin-overleaf
48587a7a62 Merge pull request #12007 from overleaf/ii-react-subscription-dash-thank-you
[web] Successful subscription react migration

GitOrigin-RevId: 1d7d849415f4b7a7f60ddf8a4e18570ff5142196
2023-03-02 09:04:04 +00:00
ilkin-overleaf
076bc9b39c Merge pull request #11872 from overleaf/ii-payment-page-tests
[web] Payment page tests

GitOrigin-RevId: 0ab9a75c13f1833cbdf7aa71ffe3ab66174ca773
2023-03-01 09:03:22 +00:00
ilkin-overleaf
612728d300 Merge pull request #11963 from overleaf/ii-react-subscription-dash-reactivate-subscription
[web] Subscription dash reactivate button react migration

GitOrigin-RevId: dde8dd1abb8979bdf90d71ea07e1336e9af491b3
2023-03-01 09:03:17 +00:00
ilkin-overleaf
44b1f555f1 Merge pull request #12001 from overleaf/ae-backspace
Remove BackspaceHighjack

GitOrigin-RevId: 7b20bff7d52b20152c437ba8bc773c4f37ad1fc3
2023-03-01 09:03:11 +00:00
ilkin-overleaf
41a706108c Merge pull request #11941 from overleaf/ii-recompile-tooltip
[web] Recompile tooltip fix

GitOrigin-RevId: da3282b9da0133f5b6ec84c4453bd6ab19b739af
2023-03-01 09:02:53 +00:00
ilkin-overleaf
19688a020c Merge pull request #11985 from overleaf/ii-empty-trial-price-section
[web] Checkout page react migration hide empty trial price section

GitOrigin-RevId: a023a48b205e67778827b6a99fbe948c929549f5
2023-03-01 09:02:50 +00:00
ilkin-overleaf
9f95c7c2ab Merge pull request #11919 from overleaf/ii-react-subscription-dash-user-email-not-matching-recurly-email
[web] Subscription dash user email not matching recurly email section - react migration

GitOrigin-RevId: 8d89dbc804694afffea2a92cebdeb5d4e9389810
2023-03-01 09:02:47 +00:00
Thomas
16b2d27fde Update B2B Groups and Enterprise banners (#11989)
* Tear down B2B banner ad split test and implement updated ads

GitOrigin-RevId: 7d09d54bef7cb4e2b2b597d3834e0f58551b179e
2023-02-28 09:04:31 +00:00
Jessica Lawshe
1c3b05d4a8 Merge pull request #11977 from overleaf/jel-subscription-dash-alert
[web] Add aria-live="polite" to subscription dash alert

GitOrigin-RevId: 29ce9e3ab26ab21a7e86fdbe90fb228c68bb8d98
2023-02-28 09:04:15 +00:00
Jessica Lawshe
c67da92287 Merge pull request #11976 from overleaf/jel-subscription-canceled
[web] Only subscription canceled header within the header

GitOrigin-RevId: 7dba2f3c34fe98a5a5bd446f093c640794ebbbb6
2023-02-28 09:04:01 +00:00
Jessica Lawshe
7469f01acd Merge pull request #11981 from overleaf/jel-downgrade-when-cancel
[web] Migrate downgrade plan option when cancelling in React subscription dash

GitOrigin-RevId: 11a4b39deb58493f3f56e65e8760d71527a8e8fc
2023-02-28 09:03:54 +00:00
Davinder Singh
cc2d1a26e2 Merge pull request #11958 from overleaf/ds-td-documentation-btn-refactor
Styling and HTML structure of the documentation button

GitOrigin-RevId: e643edbe05579c037ca1ec27fab765974e74d2c5
2023-02-27 09:03:47 +00:00
Jessica Lawshe
68e61d7bb7 Merge pull request #11973 from overleaf/ii-react-canceled-subscription
[web] Subscription page canceled subscription react migration

GitOrigin-RevId: dd127d753e72c194cd6bbb90b1ca1557742896d9
2023-02-24 09:05:28 +00:00
Jessica Lawshe
0037e45740 Merge pull request #11970 from overleaf/ab-sub-dash-already-have-warning
[web] Display a warning on subscription dash when coming from plans page

GitOrigin-RevId: 6c6294fbf634a5dcd1a09b94538add6586ebd15b
2023-02-24 09:05:20 +00:00
Jessica Lawshe
ebc04e4a9d Merge pull request #11888 from overleaf/jel-subscription-dash-cancel-plan
[web] Migrate cancel subscription to React

GitOrigin-RevId: 8482fd61894c8011b4c980263ae1d41f396233c6
2023-02-24 09:05:12 +00:00
ilkin-overleaf
b52c151a6f Merge pull request #11937 from overleaf/ii-subscription-dash-coupons-ci-fixes
[web] Subscription dash fix CI issues

GitOrigin-RevId: 53e7a6ede9d0f07be1e0d1f1c6180bd1a5cecf84
2023-02-23 09:05:21 +00:00
Alexandre Bourdin
d2fb800174 Merge pull request #11885 from overleaf/ab-personal-sub-custom-react
[web] Display a message for custom personal subscriptions in React dash

GitOrigin-RevId: c70986ffacfdfdeccd3675385e2e5dba1a2ad61f
2023-02-23 09:05:13 +00:00
Alexandre Bourdin
8b00a496e7 Merge pull request #11881 from overleaf/ab-custom-subscription-react-dash
[web] Add a contact support message for custom subsbcriptions on React dash

GitOrigin-RevId: e2a2bb27b4f1e70cbbe62f4c837fe63d81a820c2
2023-02-23 09:05:05 +00:00
Alexandre Bourdin
f86eeac522 Merge pull request #11862 from overleaf/ab-group-subscription-memberships-dash-react
[web] Migrate group subscription memberships to React dash

GitOrigin-RevId: d5ff3ae4e5d8c422530502af22edda6c24c9a593
2023-02-23 09:04:49 +00:00
Alexandre Bourdin
a928fd20e6 Merge pull request #11906 from overleaf/ii-react-subscription-dash-active-coupons
[web] Subscription dash show active coupons react migration

GitOrigin-RevId: 7a63505b31d828491b6ea812482376882354b4ee
2023-02-23 09:04:13 +00:00
Alexandre Bourdin
d6e9508aed [web] Migrate managed publishers to React dash (#11749)
* Migrate managed publishers to React dash

* Decaf cleanup + async/await PublishersGetter

* Continue migration of managed publishers to react dash

* Fix linting

* Add tests

* Decaf cleanup PublishersGetterTests

* Update PublishersGetter tests

* Rename component files to kebab-case

GitOrigin-RevId: cb1fe14d120457c965a9d23a8ddb2c2c92e1d5da
2023-02-23 09:04:03 +00:00
Jessica Lawshe
89ef1681e8 Merge pull request #11844 from overleaf/jel-subscription-dash-change-to-group-submit
[web] Submit group plan change on subscription dash

GitOrigin-RevId: 5bc2644351c80189774ad3ac4cdcd622d354770f
2023-02-22 09:05:21 +00:00
Jessica Lawshe
124306d7ac Merge pull request #11819 from overleaf/jel-subscription-dash-change-to-group-prices
[web] Show price in change to group plan modal on React subscription dash

GitOrigin-RevId: 6a1a4be3a7d008cd9e26186c2d97bc0bdc2f82ed
2023-02-22 09:05:13 +00:00
Jessica Lawshe
cad3660f0b Merge pull request #11839 from overleaf/jel-subscription-dash-change-to-group-pt2
[web] Continue change to group plan via React subscription dash

GitOrigin-RevId: b7e743f18e40383ecc1dbf02914f663ff0bc1846
2023-02-22 09:05:05 +00:00
Jessica Lawshe
b2a10260be Merge pull request #11773 from overleaf/jel-subscription-dash-change-to-group
[web] Begin change to group plan via React subscription dash

GitOrigin-RevId: 3f0f2820ab18ecc8337746282295302d7951c56f
2023-02-22 09:04:56 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772)
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
2023-02-22 09:04:42 +00:00
Alf Eaton
31d0d10cfc Merge pull request #11877 from overleaf/mj-undefined-control-sequence-help
[web] Improve error messages around missing packages

GitOrigin-RevId: d6f59f452cdc8a5a7e59b9809f68bd18f629ba32
2023-02-21 09:05:04 +00:00
Jessica Lawshe
d539aaf226 Merge pull request #11681 from overleaf/jel-confirm-subscription-change
[web] Plan change request in subscription dash

GitOrigin-RevId: 9afe22b2da035f887c6fa9abe8129711d492108c
2023-02-17 09:05:51 +00:00
Alf Eaton
6175df9f95 Show preview for PDF image (#11793)
GitOrigin-RevId: 5c7dde42cdfcf9952e47487358f7e2b52658cc59
2023-02-17 09:04:35 +00:00
Alf Eaton
1807f18b7d Add a tooltip to the disabled Rich Text toggle (#11843)
GitOrigin-RevId: e7be96c68d87ab1f1ed40c8e9784160689ee8e96
2023-02-17 09:04:15 +00:00
M Fahru
47937c4073 Fix event "left-menu-documentation-click" not being fired properly (#11836)
GitOrigin-RevId: 5e9df12c699ff5c25389e8fb90fda73913e8c747
2023-02-16 09:05:00 +00:00
Davinder Singh
c524fee690 Merge pull request #11694 from overleaf/ab-managed-institutions-react
[web] Migrate managed institutions to React dash

GitOrigin-RevId: 535dfafe42d88189bb20e7bb3beac233221ee6ba
2023-02-15 09:04:55 +00:00
Davinder Singh
ba2d5db50c Merge pull request #11670 from overleaf/ab-manage-members-back-button
[web] Add a back button on the members/managers management pages

GitOrigin-RevId: 7a723853683438ebac91eb534f9fb9a445a306c9
2023-02-15 09:04:46 +00:00
Davinder Singh
de245c288a Merge pull request #11653 from overleaf/ds-documentation-btn-on-editor
Adding documentation button on the editor

GitOrigin-RevId: e03fd7b931eb0fe7273e6e9d0185c81c384df916
2023-02-15 09:04:37 +00:00
Jakob Ackermann
ce1c9713bd Merge pull request #11809 from overleaf/jpa-fix-is-old-domain-flag
[web] user-content-domain-access-check: fix isOldDomain flag

GitOrigin-RevId: 56332dbb414fcfb7e5833cb9af21bee6ef69253f
2023-02-14 09:04:41 +00:00
ilkin-overleaf
c09e29c040 Merge pull request #11751 from overleaf/ii-payment-page-stories
[web] Payment page stories

GitOrigin-RevId: 9f8aff0cf839bc811d8612e97bd627b577860cc8
2023-02-14 09:04:25 +00:00
Jakob Ackermann
9eff0140a9 Merge pull request #11761 from overleaf/jpa-access-check-noise-metric
[web] optionally run access check on old compile domain

GitOrigin-RevId: 02fba931726cdfe1dad763e73e6306b041ce8ea5
2023-02-14 09:04:17 +00:00
Jakob Ackermann
e525c4c58d Merge pull request #11758 from overleaf/jpa-metric-max-access-checks-hit
[web] add metric for hitting limit on new compile domain access checks

GitOrigin-RevId: 58df0911a411dd77698932e13d212cf15b4c8931
2023-02-14 09:04:09 +00:00
Jakob Ackermann
ed2b96276d Merge pull request #11770 from overleaf/jpa-flag-403
[web] catch unexpected response status codes from user content domain

GitOrigin-RevId: 654141e1be8721f92be271733aca70a7bc672973
2023-02-13 10:26:28 +00:00
Miguel Serrano
286cbc66a8 Merge pull request #11771 from overleaf/msm-force-ace-sp
[web] Force Ace editor in Server Pro

GitOrigin-RevId: 1ea5675ad1c64a15dc30566c02d694feb2aaed3c
2023-02-10 09:12:26 +00:00
M Fahru
9719b0439c Tear down recompile button text split test (#11637)
GitOrigin-RevId: 574ebeda9517cc54e04362395a90584703198d9f
2023-02-10 09:04:12 +00:00
ilkin-overleaf
b0841592c7 Merge pull request #11646 from overleaf/ii-payment-page-payment-preview-panel
[web] Payment page payment preview panel

GitOrigin-RevId: 35f2e11a9a80e8b240dc8485b8062cf33d5b40b4
2023-02-09 14:34:18 +00:00
Eric Mc Sween
204e7a0c87 Merge pull request #11719 from overleaf/em-survey-sidebar
Make survey notification the width of the dashboard sidebar

GitOrigin-RevId: 754ec21692505107e683369628a2b5481e7cef9a
2023-02-09 09:06:29 +00:00
June Kelly
035b5cd456 Merge pull request #11263 from overleaf/ae-rich-text-available
Only enable the Rich Text option for supported file extensions

GitOrigin-RevId: ae67435b50701bb5be71bab94d8c3c4da4129d88
2023-02-09 09:05:05 +00:00
ilkin-overleaf
f6ddb95ae5 Merge pull request #11573 from overleaf/ii-payment-page-migration-three-d-secure
[web] Payment page migration 3DS

GitOrigin-RevId: b1049882c0f9fd17af2d2974e3f59b01af353c8f
2023-02-09 09:04:13 +00:00
Thomas
ce79f03b87 Merge pull request #11706 from overleaf/jpa-fix-de-translations
[web] fix a few German translations

GitOrigin-RevId: a19713144a236e367a28bd443919bd81acbb4656
2023-02-09 09:03:57 +00:00
M Fahru
5f3ef71e43 Implement 'Add Affiliation' UI on the mobile version of the new react dashboard (#11606)
* Refactor & change `add-affiliation.tsx` file:
    * Change class from `user-profile` to `add-affiliation`
    * Add new optional `className` props for custom styling

* Show affiliation widget on mobile screen:

* Fix bug on use add affiliation hooks: return type should be `boolean`, not `boolean | 0`

GitOrigin-RevId: 800b951e2a012797266b1780993b4ed9a918d565
2023-02-08 09:07:23 +00:00
M Fahru
de97ef98c0 Make dropdown menu in welcome page in a center position (react dashboard)
GitOrigin-RevId: c9c68d41dd00208ddde3400ed04f9fe3425a5613
2023-02-08 09:07:15 +00:00
M Fahru
3fde2b7207 Remove unnecessary xs={12} props since it's the default
Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: 1b7139e7a8351da0417ba150cfdeec04441dcfe3
2023-02-08 09:07:08 +00:00
M Fahru
3ffb7dd7dc Reduce margin on welcome page react version
GitOrigin-RevId: 40aba2b6cb6b45a6d3d1b23b1d87f4ea8acc805d
2023-02-08 09:07:00 +00:00
Jessica Lawshe
ccbc0adc06 Merge pull request #11705 from overleaf/jel-free-plan-dash
[web] Fix displaying free plan React dash

GitOrigin-RevId: 5759ad3489bf43d2a7db57b050fd5cb4aa360140
2023-02-08 09:06:52 +00:00
Jessica Lawshe
f3d055af86 Merge pull request #11619 from overleaf/jel-react-personal-subscription-dash-change-plan
[web] Query display price data for change plan UI in React subscription dash

GitOrigin-RevId: e05779d1f289ee55a1b8be17b182905fca66e44f
2023-02-08 09:06:44 +00:00
Jessica Lawshe
d4057a7bcc Merge pull request #11602 from overleaf/jel-react-personal-subscription-dash-pt-6
[web] Continue migration of change plan UI to React

GitOrigin-RevId: 4f6176ac101ba3c57134cf5c86329e205f17ab23
2023-02-08 09:06:37 +00:00
Jessica Lawshe
c7d8e4867d Merge pull request #11560 from overleaf/jel-react-personal-subscription-dash-pt-5
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: fb327592ad5031bff20b2a95a83edee4735112e8
2023-02-08 09:06:29 +00:00
Jessica Lawshe
c36b872ae3 Merge pull request #11509 from overleaf/jel-react-personal-subscription-dash-pt-4
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: f2d913099d727725f04697003516c90616faf014
2023-02-08 09:06:21 +00:00
Jakob Ackermann
ffc9b63ab1 Merge pull request #11676 from overleaf/jpa-faster-access-check
[web] run all the user-content-domain-access-check probes in parallel

GitOrigin-RevId: 1b5a4756064053639e0dbc899d75ba8c0a5c5557
2023-02-08 09:06:13 +00:00
ilkin-overleaf
7f8d2e37d5 Merge pull request #11530 from overleaf/ii-payment-page-migration-checkout-panel
[web] Payment page migration checkout panel

GitOrigin-RevId: 04edf9961e0032d6fe3631c255e49dc1d4c3e0ca
2023-02-07 09:04:53 +00:00
Alf Eaton
85fbded781 Improve the Rich Text toolbar (#11616)
GitOrigin-RevId: d1999be629ac048058ffd82004865728796a3feb
2023-02-07 09:04:39 +00:00
Alexandre Bourdin
ed40a87cdc [web] Migrate group management to React (#11293)
* Rename manage group entry point

* Migrate group management root page to React

* Add cypress tests for the group management react page

* Fix linting

* Add checkbox labels for screen-readers + remove unused classes

* Await on add/remove members calls

* Display the export CSV link for a full group

* Display error message when group is full

* Sort locales

* Handle the managers management page in React version

* Fix missing type in GroupMemberRow

* Split members and managers React pages

* Build API paths on frontend side + add cypress tests for each page

* Fix linting

* Update unit tests

* Review improvements

* Type API errors

GitOrigin-RevId: d124a9d24cbf33de8aacc5d69e9d46e7bcda93c5
2023-02-07 09:04:18 +00:00
Alf Eaton
73395e008a Fix and run extract-translations (#11622)
GitOrigin-RevId: b36c70748da800979dbb7f8c11c1b555515cce7b
2023-02-06 09:04:42 +00:00