github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-05 02:46:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #12939 from overleaf/td-history-more-update-scroll-amount

Browse source 
History migration: More update button scrolls next change to the centre

GitOrigin-RevId: 29d41a046f7110c246a0b9c784dedf6b148ea298
This commit is contained in:
Tim Down 2023-05-04 10:57:48 +01:00 committed by Copybot
parent 27457133e4
commit a0e3379c86
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/frontend/js/features/history/extensions/highlight-locations.ts
View file

@ -125,7 +125,10 @@ export function highlightLocations() {
export function scrollToHighlight(view: EditorView, highlight: Highlight) {
view.dispatch({
effects: EditorView.scrollIntoView(
EditorSelection.range(highlight.range.from, highlight.range.to)
EditorSelection.range(highlight.range.from, highlight.range.to),
{
y: 'center',
}
),
})
}

4
services/web/test/frontend/features/history/components/document-diff-viewer.spec.tsx
View file

@ -203,8 +203,8 @@ End
// Click the "More updates above" button, which should scroll the editor up
// but not quite to the top, and check the new state
cy.get('.previous-highlight-button').first().click()
cy.get('@scroller').invoke('scrollTop').should('not.equal', 0)
cy.get('.previous-highlight-button').should('have.length', 1)
cy.get('@scroller').invoke('scrollTop').should('equal', 0)
cy.get('.previous-highlight-button').should('not.exist')
cy.get('.next-highlight-button').should('have.length', 1)
})