Commit graph

72 commits

Author SHA1 Message Date
Brian Gough
598eaf08fd Merge pull request #17816 from overleaf/bg-eslint-rule-for-find-with-await
add eslint rule for find with await

GitOrigin-RevId: 7e78104e610073ff3c151d7314753c8301a8c787
2024-05-17 08:04:58 +00:00
Jessica Lawshe
955c860b64 Merge pull request #17841 from overleaf/jel-lint-populate
[web] Add linting rule for mongoose `populate`

GitOrigin-RevId: 625b2b5f9db4e88ce0d629752f083b8be71c7766
2024-04-12 08:06:18 +00:00
Alf Eaton
1ad2be35b5 Merge pull request #17626 from overleaf/ae-eslint-window-localstorage
Add ESLint rule that prevents direct use of window.localStorage

GitOrigin-RevId: 30abcd96ef31690a482c5368ff2a6d11024f5126
2024-03-27 09:04:15 +00:00
Thomas
e1c58c2aaf Merge pull request #15710 from overleaf/tm-no-constant-binary-expressions
Add no-constant-binary-expression, fix existing expressions that have no effect

GitOrigin-RevId: 6691e87181331ecbb5dabfda0be89839a0a4884b
2024-01-16 09:04:09 +00:00
Mathias Jakobsen
c371732e6e Merge pull request #16186 from overleaf/mj-mongo-object-id
[web] Use constructor for ObjectId

GitOrigin-RevId: 9eb8b377ea599605b72af237d1ab12f4d8287162
2023-12-19 09:04:02 +00:00
Alf Eaton
9875e55a27 Remove Ace (#14299)
GitOrigin-RevId: ec8788fdbc8aea73ca33ec2810f4e588fe9476b5
2023-11-29 09:04:08 +00:00
Brian Gough
26db8ffa69 Merge pull request #15716 from overleaf/bg-eslint-console-log-in-web-tests
add console.log rule for tests in web eslintrc

GitOrigin-RevId: 166135e379309870fa4fe2d1797cb4c93cf2d877
2023-11-13 09:04:13 +00:00
Alf Eaton
221d16f4e4 Disable transSupportBasicHtmlNodes in react-i18next config (#15430)
* Set transSupportBasicHtmlNodes to false
* Update ESLint rule
* Convert Trans to t
* Convert shouldUnescape={true}
* Convert some arrays to objects
* Update translations

GitOrigin-RevId: 64a50318388abcada408f72d949de148129a9f63
2023-10-31 09:04:04 +00:00
Alf Eaton
7755203ff7 Enable ESLint rule that enforces t when preferable to Trans (#15253)
GitOrigin-RevId: d11b3f587b462d400a8d68128dc8be342415bf7d
2023-10-20 08:03:34 +00:00
Alf Eaton
0c81bccfca Ensure that translation values are correctly escaped (#15252)
GitOrigin-RevId: 5a38b4c01921fd4d95dbdb7b9e756443fdb00b80
2023-10-20 08:03:31 +00:00
Mathias Jakobsen
1a92e1b664 Merge pull request #15248 from overleaf/mj-eslint-angular-components
[web] Add eslint rules for angularjs components

GitOrigin-RevId: 1343d584368faeb912f04c5879228bcbd07a042a
2023-10-18 08:03:57 +00:00
Jakob Ackermann
6b3dac803d Merge pull request #15006 from overleaf/mj-bad-karma
[web] Remove karma tests and config

GitOrigin-RevId: a157f46d1ecf93fcbc99713a1c3aa11f82e5a619
2023-10-16 08:04:20 +00:00
Jakob Ackermann
9daa8f5d98 Merge pull request #15040 from overleaf/jpa-js-to-jsx
[web] rename all the JSX files to .jsx/.tsx

GitOrigin-RevId: 82056ae47e017523722cf258dcc83c8a925a28f7
2023-09-29 08:04:29 +00:00
Jakob Ackermann
1213709578 Merge pull request #14980 from overleaf/jpa-debug-console
[web] migrate frontend logging to debugConsole

GitOrigin-RevId: b03ff9030b03fff059738d2270bc4b4912e79f16
2023-09-28 08:04:12 +00:00
Brian Gough
b77f4f1379 Merge pull request #14727 from overleaf/bg-eslint-rule-for-node-fetch
restrict use of node-fetch using eslint rules

GitOrigin-RevId: 79fd41a7f69e68d2f9f9c55c5d46ffd7bf3c00fd
2023-09-11 08:05:10 +00:00
Mathias Jakobsen
608bca2610 [misc] Disallow regex lookbehind during linting
GitOrigin-RevId: e4f4d9ac1f9b0dcc6572cf1b32304575c9bb0ac4
2023-08-31 08:04:17 +00:00
Alf Eaton
510e686b7b Upgrade ESLint plugins (#13153)
GitOrigin-RevId: 9cd0b4429a9c2b3df9c18957aef21ef021e5fdfd
2023-05-25 08:05:34 +00:00
Alf Eaton
f375362894 Always use mockable location methods (#11929)
* Always use mockable location methods
* Add eslint rules for window.location calls/assignment
* Add useLocation hook
* Update tests

GitOrigin-RevId: eafb846db89f884a7a9a8570cce7745be605152c
2023-03-17 09:05:21 +00:00
Alf Eaton
910e07ca1c Add types (#8154)
GitOrigin-RevId: 41ee6b6873a01fbfedc41a884b9e3ebee47fc08f
2022-05-30 08:03:45 +00:00
Jakob Ackermann
f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Alf Eaton
5e9af2c15c Migrate worker tests to Cypress (#7359)
GitOrigin-RevId: f373f4215e5f25d14256008cf5f6582eb3124431
2022-04-07 08:03:52 +00:00
Alf Eaton
53324b0cd2 Add Cypress React component testing (#6974)
GitOrigin-RevId: 1260312a0644f3bc60e007a840045974336e264d
2022-04-05 12:17:30 +00:00
Alf Eaton
8b253b32f7 Add ts(x) file extensions to ESLint config for frontend-specific rules (#7139)
GitOrigin-RevId: 26389fb0ca9b3cd6545ada66a0f1dd31c5c33d9f
2022-03-22 09:03:04 +00:00
Alf Eaton
b72b2b9b75 Convert the source editor module to TypeScript (#6858)
GitOrigin-RevId: 37863a00b3af0823a404f42c0540cb4508c698b6
2022-03-16 09:03:29 +00:00
Alf Eaton
ac0e9d06c3 [web] Configure Babel + ESLint to handle TypeScript files (#5993)
GitOrigin-RevId: e8474274e60e5e0dcefa7263616fbaf04a9f3930
2022-03-16 09:03:07 +00:00
Jakob Ackermann
ae0c347f27 Merge pull request #6542 from overleaf/jpa-em-code-sharing-workspaces
[misc] npm workspaces

GitOrigin-RevId: 87aa72db6637fb238d7cd35b0a48ac3ed58ab3eb
2022-02-16 11:31:07 +00:00
Alf Eaton
1fd0a26d29 Merge pull request #6005 from overleaf/ae-fix-prop-types
[web] Fix some missing/incorrect props and propTypes

GitOrigin-RevId: 27aac8d6675e0070633d0d3d45b27746ebcf62a0
2021-12-08 09:03:20 +00:00
Jakob Ackermann
a6f05109a3 Merge pull request #5352 from overleaf/jpa-no-var
[misc] fix eslint violations for `no-var`

GitOrigin-RevId: c52e82f3a8a993b8662cc5aa56e7b95ca3c55832
2021-10-27 08:03:00 +00:00
Jakob Ackermann
358e8b7424 Merge pull request #5349 from overleaf/jpa-no-depreacted-api
[misc] fix eslint violations for node/no-depreacted-api

GitOrigin-RevId: 0f7d64984da9e789c4ab95381db34afb89fa1a94
2021-10-21 08:03:18 +00:00
Jakob Ackermann
12890edd14 Merge pull request #5344 from overleaf/jpa-no-callback-literal
[web] fix eslint violations for node/no-callback-literal

GitOrigin-RevId: 8d6bb1398b3db2794bf1b2f97cd6d2886f2b4b0a
2021-10-07 08:04:30 +00:00
Jakob Ackermann
cc8faa0535 Merge pull request #5343 from overleaf/jpa-faster-eslint
[web] faster eslint

GitOrigin-RevId: 1dff39acf9905355650bb41f3f42b206ea84f8d4
2021-10-07 08:04:23 +00:00
Hugh O'Brien
f7900b474b Merge pull request #4799 from overleaf/hb-eslint-rules
Re-enable some eslint rules

GitOrigin-RevId: 16153adb839bb61784bb40fbc8e43da281fe090d
2021-09-15 08:03:43 +00:00
Jakob Ackermann
9dccd6173a Merge pull request #4305 from overleaf/jpa-fix-undef
[misc] fix undefined references in all the places and enable lint rule

GitOrigin-RevId: 473dbab577b34f60d6a3fe567e29e13cb5b1cb24
2021-07-14 12:40:42 +00:00
Alf Eaton
7c97f8ab6e Switch to new JSX runtime (#4225)
* Use new JSX runtime and update Babel Node target
* Update .eslintrc
* Remove React imports

GitOrigin-RevId: 559de0267f8f2934c56a860ea8701bb522aa861a
2021-06-24 02:06:59 +00:00
Miguel Serrano
bb88af80cf Merge pull request #3947 from overleaf/msm-reenable-eslint-rules
Reenable `eslint` rules

GitOrigin-RevId: a0aa5f941ba1bc49ff758b5256f91d696f442c6d
2021-05-14 02:09:45 +00:00
Miguel Serrano
6c831e9a02 Merge pull request #3976 from overleaf/jpa-explicit-dependencies
[misc] add linting for missing explicit dependencies and fix any errors

GitOrigin-RevId: 813de53eafbbe1ffda37ce2832d1ed2538d5476b
2021-05-06 02:09:18 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Jakob Ackermann
adfde7d26b Merge pull request #3950 from overleaf/msm-reenable-lint-prefer-regex-literals
Reenable `prefer-regex-literals` eslint rule

GitOrigin-RevId: 3c576d92a08dfcb745d447b1bf8c7b828753010d
2021-04-29 02:09:10 +00:00
Alf Eaton
b04b8daf85 Merge pull request #3715 from overleaf/ae-eslint-config-prettier
Upgrade eslint-config-prettier

GitOrigin-RevId: 777ad57793e0ceff2d5dc913b13bbaa1e217367e
2021-03-04 03:04:17 +00:00
Eric Mc Sween
d5f6da6c25 Merge pull request #3573 from overleaf/em-prettier
Remove eslint-plugin-prettier

GitOrigin-RevId: a8b2c6cb2ff4b8ac9d0a216830690bfde7ac2e7b
2021-01-22 03:04:37 +00:00
Timothée Alby
4faa6dde0d Merge pull request #3505 from overleaf/as-reenable-lint-rules
Reenable some lint rules

GitOrigin-RevId: 42d891f24b7ab101308adcf8f31cccf7ac229a59
2021-01-06 03:07:40 +00:00
Alasdair Smith
7cbf2cdd9e Merge pull request #3496 from overleaf/ae-eslint-dot-notation
Enable the eslint dot-notation rule

GitOrigin-RevId: e11cbad3e8a77a4a60590d3674fbf34feccc5bc9
2020-12-17 03:07:31 +00:00
Alf Eaton
2ff1cf43d6 Merge pull request #3470 from overleaf/eslint
Upgrade and configure ESLint

GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Hugh O'Brien
88b9c371bc Merge pull request #3447 from overleaf/ae-eslint-braces-rule
Enable react/jsx-curly-brace-presence rule

GitOrigin-RevId: f3683cf7ae4566bcfa442fff2242370331209a54
2020-12-10 03:04:57 +00:00
Jakob Ackermann
fae53738f5 Merge pull request #3423 from overleaf/as-ta-sentry-fixes
Improve loading of Sentry reporter in frontend

GitOrigin-RevId: fc05aa48ad0e816b4ef0f5dafb6cf00525a28223
2020-12-04 03:05:43 +00:00
Alasdair Smith
0d78719320 Merge pull request #3224 from overleaf/ta-frontend-tests-lint
Run Lint Test Rules on Frontend Tests

GitOrigin-RevId: 03d3618eab2c6d2822233607da3ffa64ac132cd0
2020-09-27 02:05:27 +00:00
Eric Mc Sween
88b5a4534c Merge pull request #3022 from overleaf/as-react-linting
Add some more React linting

GitOrigin-RevId: 77ffa24d2c1ac68b547a0b5706287567bf5eda5d
2020-07-21 02:06:23 +00:00
Miguel Serrano
b573374d0e Merge pull request #2950 from overleaf/as-jsdom-tests
JSDOM tests

GitOrigin-RevId: d9e39c61fb2028c5b5577488d74720ef2985eebc
2020-07-11 02:04:35 +00:00
Jakob Ackermann
48b138f227 Merge pull request #2929 from overleaf/jpa-ci-3m30s-with-custom-cloudbuild
[misc] another batch of CI improvements

GitOrigin-RevId: 470fd762ba541d5dce92f0e99830fb2fd8fc4747
2020-07-03 02:04:13 +00:00
Alasdair Smith
2e0db2a472 Merge pull request #2940 from overleaf/as-cleanup-no-undef-disables
Clean up disabling of no-undef eslint rule in frontend

GitOrigin-RevId: 3fb19256b7dd9d41626355960dd9fbcc541e663f
2020-06-24 02:10:34 +00:00