github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-13 23:22:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3447 from overleaf/ae-eslint-braces-rule

Browse source 
Enable react/jsx-curly-brace-presence rule

GitOrigin-RevId: f3683cf7ae4566bcfa442fff2242370331209a54
This commit is contained in:
Hugh O'Brien 2020-12-09 11:56:24 +00:00 committed by Copybot
parent aa346e2da8
commit 88b9c371bc
5 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/.eslintrc
View file

@ -29,6 +29,10 @@
"rules": {
// Swap the no-unused-expressions rule with a more chai-friendly one
"no-unused-expressions": 0,
"react/jsx-curly-brace-presence": ["error", {
"props": "never",
"children": "never"
}],
"chai-friendly/no-unused-expressions": "error"
},
"overrides": [

2
services/web/frontend/js/features/file-tree/components/file-tree-context-menu.js
View file

@ -32,7 +32,7 @@ function FileTreeContextMenu() {
<Dropdown
onClick={handleClick}
open
id={'dropdown-file-tree-context-menu'}
id="dropdown-file-tree-context-menu"
onToggle={handleToggle}
>
<FakeDropDownToggle bsRole="toggle" />

2
services/web/test/frontend/features/file-tree/components/file-tree-root.test.js
View file

@ -32,7 +32,7 @@ describe('<FileTreeRoot/>', function() {
render(
<FileTreeRoot
rootFolder={rootFolder}
projectId={'123abc'}
projectId="123abc"
hasWritePermissions={false}
rootDocId="456def"
onSelect={onSelect}

4
services/web/test/frontend/features/file-tree/flows/delete-entity.test.js
View file

@ -37,7 +37,7 @@ describe('FileTree Delete Entity Flow', function() {
render(
<FileTreeRoot
rootFolder={rootFolder}
projectId={'123abc'}
projectId="123abc"
hasWritePermissions
onSelect={onSelect}
onInit={onInit}
@ -128,7 +128,7 @@ describe('FileTree Delete Entity Flow', function() {
render(
<FileTreeRoot
rootFolder={rootFolder}
projectId={'123abc'}
projectId="123abc"
hasWritePermissions
onSelect={onSelect}
onInit={onInit}

2
services/web/test/frontend/features/file-tree/flows/rename-entity.test.js
View file

@ -49,7 +49,7 @@ describe('FileTree Rename Entity Flow', function() {
render(
<FileTreeRoot
rootFolder={rootFolder}
projectId={'123abc'}
projectId="123abc"
hasWritePermissions
onSelect={onSelect}
onInit={onInit}