1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-22 12:52:02 +00:00
Commit graph

164 commits

Author SHA1 Message Date
Alasdair Smith
154943ba68 Don't check for linting errors if code check is disabled
There are a couple of reasons for this:

1. Some linting errors are returned from the server after a compile is run,
replacing client-side linting errors. If code check is disabled this does not
happen, and therefore linting errors persist until the next compile. This makes
it appear as though autocompile is not running

2. It is likely that if code check is disabled, the user is deliberately
ignoring linting errors and therefore the linting check is pointless
2017-11-17 16:38:44 +00:00
Alasdair Smith
15d3e5eb6e Fix triggering autocompile in rollout 2017-11-08 10:31:41 +00:00
Brian Gough
82b84fd5f4 hide logs when there are validation errors 2017-10-17 15:50:38 +01:00
Alasdair Smith
bd6bc42a9a Don't Show autocompile on load 2017-10-16 11:42:15 +01:00
Alasdair Smith
5d3371a52c Merge pull request from sharelatex/as-autocompile-rollout
Rollout for auto compile; Connects to 
2017-10-16 10:48:43 +01:00
Brian Gough
d5fba2cc71 enable incremental compiles for all users 2017-10-13 08:23:16 +01:00
Brian Gough
45ed090326 Merge pull request from sharelatex/bg-rate-limit-autocompile
rate limit autocompile (connects to )
2017-10-12 09:25:59 +01:00
Brian Gough
ea89638010 rename autocompile_disabled to autoCompileDisabled
for consistency
2017-10-09 15:21:01 +01:00
Brian Gough
15e2deed73 rename isAutoCompile and isBackgroundAutoCompile
changed to isAutoCompileOnLoad and isAutoCompileOnChange
2017-10-09 15:18:55 +01:00
Alasdair Smith
550e7d75ca Check if user is part of autocompile rollout when showing setting or running autocompile 2017-10-03 17:19:51 +01:00
Brian Gough
2723537f82 disable autocompile when rate limit is hit 2017-10-03 16:23:49 +01:00
Alasdair Smith
9386ddf4a9 Only show autocompile onboarding when first manual compile is run 2017-09-28 11:13:49 +01:00
Brian Gough
13628f82ec Merge pull request from sharelatex/bg-lock-compiles
show error for compile in progress
2017-09-27 13:54:16 +01:00
Brian Gough
0f855689a7 show error for compile in progress 2017-09-26 08:07:35 +01:00
Alasdair Smith
5b3c9f4033 Prevent autocompile if pdf preview is hidden 2017-09-25 15:46:43 +01:00
Alasdair Smith
4007fc682b Send JSON in autocompile setting event payload 2017-09-19 15:55:00 +01:00
Alasdair Smith
66bed67270 Merge pull request from sharelatex/as-client-auto-compile
Client-side auto compile
2017-09-19 15:20:07 +01:00
Alasdair Smith
963a14b33c Fix incorrectly named var and remove unneccessary semicolon 2017-09-19 14:25:30 +01:00
Alasdair Smith
38eaf82c65 Ensure that time is monotonic when running autocompile 2017-09-08 11:00:46 +01:00
Alasdair Smith
4a490aafbf Improve UX of triggering autocompile.
If a user is making infrequent edits (i.e. if reading and making small
changes), then waiting 5 seconds for a recompile is bad. Therefore we track
the time since the last recompile and use this to decide whether a recompile
should be run. This reduces the time to recompile, unless the user is typing
for a significant amount of time.
2017-09-08 10:42:54 +01:00
Brian Gough
c6d2f0f4e1 skip incremental compile after server error 2017-09-07 15:05:42 +01:00
Alasdair Smith
a8cdfb7ecc Track autocompile setting change 2017-09-07 11:13:38 +01:00
Alasdair Smith
11386eb817 Add option to autocompile, so can be identified in event tracking 2017-09-07 10:20:21 +01:00
Alasdair Smith
0c76b06a97 Increase timeout to 5 seconds 2017-09-07 10:02:48 +01:00
Alasdair Smith
ce630e4971 Extract timeout constant 2017-09-05 14:57:06 +01:00
Alasdair Smith
a9e94f6a6d Unsubscribe autocompile listener if disabled 2017-09-05 14:57:06 +01:00
Alasdair Smith
cca7f55322 Add autocompile setting 2017-09-05 14:57:06 +01:00
Alasdair Smith
64f70942d0 Ensure user is in beta program 2017-09-05 14:57:06 +01:00
Alasdair Smith
9f1adfd0c0 Replace separate autocompile ctrl with listener in PdfController 2017-09-05 14:57:06 +01:00
Alasdair Smith
53bb4fdde0 Use var in root scope instead of event to track linting error 2017-09-05 14:57:06 +01:00
Alasdair Smith
dab799a81b First pass at auto compile ctrl 2017-09-05 14:57:06 +01:00
Brian Gough
e2048e1ed5 use incrementalCompilesEnabled as option name 2017-08-09 16:25:57 +01:00
Brian Gough
97b129cbe3 enable incremental compilation for beta users 2017-08-09 10:57:24 +01:00
Paulo Reis
3dda383d70 Use promise method signatures, instead of old HTTP service ones. 2017-06-20 16:04:06 +01:00
Paulo Reis
155f515a50 Use standard promises with the http service. 2017-06-20 11:50:23 +01:00
Shane Kilkelly
ada614cc69 Check response exists before calling method 2017-05-16 09:20:12 +01:00
Henry Oswald
79bc4c1d3e = != == ;) 2017-04-24 16:16:02 +01:00
Henry Oswald
c733925a26 show rate limit message when compiled too much 2017-04-24 15:56:09 +01:00
Shane Kilkelly
d5a7514923 Add AB test for plans (+15 squashed commits)
Squashed commits:
[45c2237] Add a `subscription-form-switch-to-student` event
[1ad9b8f] change experiment name, and re-enable switch-to-student workflow
[f7cdb78] Remove debug
[4b9778a] Incorporate collaborator alternative plans
[701e80b] Add collaborator plans for heron and ibis
[287aa0f] AB test plans from editor page
[c74052e] Fix change-plan view for default plans
[1a947d6] Use correct plan codes
[1eecda7] Adjust prices
[69c4c7b] Introduce two plans
[8b8d5f8] Rename sixpack experiment
[c332002] Fix up the change-plan page
[c7af52d] Overhaul change-plan page, show only plans from current generation
[33d86bf] update plan
[5bbd946] Add a basic plans AB test
2016-10-21 16:17:37 +01:00
Brian Gough
afa910c32d turn on syntax check for all users 2016-09-06 11:19:32 +01:00
Brian Gough
7bf3b9daf9 add event tracking for syntax check 2016-08-26 15:54:01 +01:00
Brian Gough
092d7da479 use Syntax error for consistency in file check 2016-08-25 16:56:06 +01:00
Brian Gough
588be16255 handle try/turn off options for syntax check 2016-08-25 15:52:37 +01:00
Brian Gough
7f20415048 only set compileExited on compile errors 2016-08-24 16:48:45 +01:00
Brian Gough
74bc157e7c added force recompile option 2016-08-24 16:48:37 +01:00
Brian Gough
93f69ca0a2 run chktex silently for all users 2016-08-15 16:48:48 +01:00
Brian Gough
7bec656bc2 sort latex output files into order in dropdown 2016-08-15 16:45:33 +01:00
Paulo Reis
6a3372fcbf Use new event tracking methods. 2016-08-10 17:33:56 +01:00
Brian Gough
4d3b743e4d display validation errors only when doing validation 2016-07-29 14:59:48 +01:00
Brian Gough
a3c8202d0e support jumping to position with line and column from log entries 2016-07-29 14:59:48 +01:00