Alasdair Smith
e61b82c452
Remove unused link sharing rollout, but keep onboarding popup
2017-11-22 17:07:50 +00:00
Alasdair Smith
6f8b0c6e87
Revert "Remove old unused link sharing onboarding"
...
This reverts commit 66a0a7ff8b5b5081d86df333429cb0455221c81a.
2017-11-22 16:46:16 +00:00
Alasdair Smith
de3b9d6a49
Remove old unused link sharing onboarding
2017-11-22 16:09:32 +00:00
Alasdair Smith
f85880ba38
Remove old unused track changes notice
2017-11-22 15:03:46 +00:00
Alasdair Smith
8f32f0d65f
Remove old unused track changes onboarding
2017-11-22 14:48:22 +00:00
Brian Gough
69cb93fe64
Merge pull request #139 from sharelatex/bg-fix-spelling-cancel-request
...
fix the cancellation of spelling requests
2017-11-22 09:45:36 +00:00
Brian Gough
dc71a6a0a1
Merge pull request #113 from sharelatex/bg-prevent-editing-in-broken-ace-session
...
put ace in readonly mode when changing session
2017-11-22 09:45:19 +00:00
Alasdair Smith
1a8a915116
Merge pull request #77 from sharelatex/ns-autocomplete-insertion-bug
...
fix autocomplete insertion on single backslash; Fixes #55
2017-11-20 15:20:45 +00:00
Alasdair Smith
3c0c670b5f
Merge pull request #78 from sharelatex/ns-capital-letter-autocomplete-bug
...
allow for capital letters in commands; Fixes #56
2017-11-20 15:20:18 +00:00
Brian Gough
029e3b1557
fix the cancellation of spelling requests
2017-11-20 12:25:09 +00:00
Alasdair Smith
154943ba68
Don't check for linting errors if code check is disabled
...
There are a couple of reasons for this:
1. Some linting errors are returned from the server after a compile is run,
replacing client-side linting errors. If code check is disabled this does not
happen, and therefore linting errors persist until the next compile. This makes
it appear as though autocompile is not running
2. It is likely that if code check is disabled, the user is deliberately
ignoring linting errors and therefore the linting check is pointless
2017-11-17 16:38:44 +00:00
Brian Gough
bd09ef81f2
added comments
2017-11-16 15:41:16 +00:00
Brian Gough
dc6110db8d
put ace in readonly mode when changing session
...
if the session fails to attach successfully (e.g due to an exception in
the changeSession event handler) the editor will be left in a state
where the user will not be able to enter any text. This should at least
cause them to reload the editor.
2017-11-16 11:32:08 +00:00
Brian Gough
125a5ec606
temporarily avoid exception in ace event handler
...
full fix will be to use the angular $http cancellation mechanism
2017-11-15 16:28:31 +00:00
Shane Kilkelly
aea8e77f8a
Merge branch 'as-fix-rollout-2'
2017-11-13 09:50:46 +00:00
Shane Kilkelly
8ba9073606
Merge branch 'sk-link-sharing-onboarding'
2017-11-13 09:31:44 +00:00
Brian Gough
fe12a341e1
Merge pull request #89 from sharelatex/bg-slow-connection-fix
...
increase allowed op backlog and flush tolerance
2017-11-13 09:22:18 +00:00
Shane Kilkelly
42c0974671
Place the linksharing popover from the right, not the left.
...
This ensures the popover reflows properly with window resize.
2017-11-10 12:05:12 +00:00
Shane Kilkelly
666ee0669a
Alter position of link-sharing popover, and better image
2017-11-10 10:24:36 +00:00
Shane Kilkelly
44420b41d6
Remove stray console log
2017-11-09 15:13:58 +00:00
Shane Kilkelly
766c8d6f0f
Add a general 'ide:loaded' event, to init popover
2017-11-09 15:12:55 +00:00
Shane Kilkelly
470ad36218
Add onboarding popup for link-sharing
2017-11-09 14:28:11 +00:00
Alasdair Smith
8174a849a1
Reset to new analytics key
2017-11-08 11:01:36 +00:00
Alasdair Smith
15d3e5eb6e
Fix triggering autocompile in rollout
2017-11-08 10:31:41 +00:00
Shane Kilkelly
484cad2ef0
Render anonymous users as '?' in top bar
2017-11-07 14:20:08 +00:00
Shane Kilkelly
3cafd0ac8f
Refine deactivate logic, only if member via token and not otherwise
2017-11-03 11:46:00 +00:00
Shane Kilkelly
3360688752
Separate cases of setting Guest TC in general, and for this user
2017-11-03 11:11:04 +00:00
Shane Kilkelly
1cedfed1e4
Merge branch 'master' into sk-unlisted-projects
2017-11-02 10:10:09 +00:00
Brian Gough
15997ea782
increase allowed op backlog and flush tolerance
2017-11-01 14:20:07 +00:00
Shane Kilkelly
030ffbe231
Add event-tracking to the make-token-based action
2017-10-31 14:23:05 +00:00
Shane Kilkelly
a3e5788b97
Move the __enableTokenAccessUI state to top level
2017-10-30 13:58:22 +00:00
Shane Kilkelly
5fe5125a5c
Add ability to show/hide the new token-access ui
2017-10-30 13:48:25 +00:00
Shane Kilkelly
a57827458d
Fix guest state sync
2017-10-27 14:41:48 +01:00
Shane Kilkelly
8a2acd7138
Only turn on guest track-changes if available
2017-10-26 13:48:02 +01:00
Shane Kilkelly
f9d83c24ef
clean-up commented out code
2017-10-26 11:04:59 +01:00
Shane Kilkelly
62d170e7a0
Move the access-level sync out of the share controller.
...
This means sync will work even for clients which don't show the share
button in the menu bar.
2017-10-26 11:04:00 +01:00
Shane Kilkelly
5f6e191c5f
Automatically disable guest-track-changes when project made private
2017-10-25 14:48:32 +01:00
Shane Kilkelly
8561b69ee9
Remove tokenMembers sync to clients
2017-10-25 11:29:05 +01:00
Shane Kilkelly
74c231826d
WIP: track changes with token-access
2017-10-25 10:34:18 +01:00
Nate Stemen
e8731bc276
allow for capital letters in command name
2017-10-24 16:55:25 +01:00
Nate Stemen
829595777c
change regex to match single backslash and command fragment
2017-10-24 16:35:28 +01:00
Shane Kilkelly
b32088ee6b
Only add token member if they're not also a collaborator
2017-10-20 13:38:52 +01:00
Shane Kilkelly
0e44b319db
Change anonToken and such to anonymousAccessToken
2017-10-20 10:10:21 +01:00
Shane Kilkelly
d8717a06a2
Fix track-changes with token-access
2017-10-19 14:42:17 +01:00
Brian Gough
bf4404b60a
handle null values when saving rootDoc_id
2017-10-18 14:19:45 +01:00
Brian Gough
5d116e8ce9
Merge pull request #65 from sharelatex/bg-fix-main-doc-selection
...
fix main doc selection (connects to overleaf/sharelatex#222 )
2017-10-18 13:11:10 +01:00
Brian Gough
82b84fd5f4
hide logs when there are validation errors
2017-10-17 15:50:38 +01:00
Henry Oswald
aff5823a2d
Revert "Complete 'usepackage' with packages"
2017-10-17 13:30:47 +01:00
Alasdair Smith
bd6bc42a9a
Don't Show autocompile on load
2017-10-16 11:42:15 +01:00
Alasdair Smith
5d3371a52c
Merge pull request #38 from sharelatex/as-autocompile-rollout
...
Rollout for auto compile; Connects to #20
2017-10-16 10:48:43 +01:00
