Commit graph

23356 commits

Author SHA1 Message Date
andrew rumble
bb12dd33ee Capture more logging information for output.zip errors
GitOrigin-RevId: a2f15d05100dfdba06778a1a795c8eabefd2666d
2024-09-24 08:05:33 +00:00
andrew rumble
d4911ea246 Stop waiting for finalize
Finalize promise will only resolve when the archive is closed. We want
to stream as soon as we have the data so this does not suit us. We want
to log errors that are thrown due to finalize, these should be
propogated by archiver to the response already.

GitOrigin-RevId: 4f9d727a00ead1be3caee62e1e0adba069a545c7
2024-09-24 08:05:28 +00:00
andrew rumble
d4824b9c5f Get full path only when adding file to archive
This allows us to:
* Get files that are in subdirectories (not known to happen but might as
well support)
* Removes need to sanitise missing_files output

GitOrigin-RevId: 4b27b7f1b506578a6d713ea23979aa9370dfdcb0
2024-09-24 08:05:24 +00:00
andrew rumble
60a75d12b0 Rename files to reflect refactoring elsewhere
GitOrigin-RevId: 335f876913b7868cf69dcd55dd156261edd98945
2024-09-24 08:05:19 +00:00
andrew rumble
487d9125a2 Improve stream error safety
GitOrigin-RevId: de4c512a62d304b3eeb2a1521aac173fa93d8411
2024-09-24 08:05:15 +00:00
andrew rumble
1409e32010 Move logging into ArchiveManager
GitOrigin-RevId: 71a28a0215c5f1a6975c9e2fcdcd476513df1cbc
2024-09-24 08:05:10 +00:00
andrew rumble
c387e60a28 Remove unnecessary symlink check
GitOrigin-RevId: 08d7295403a258818276b9fbd7666a20fbc2e00f
2024-09-24 08:05:06 +00:00
andrew rumble
3fa35ef03a Share ignore logic between web and clsi
GitOrigin-RevId: c4ae306413efb71989d2db410c3859cb69b3d5de
2024-09-24 08:05:01 +00:00
andrew rumble
d627a0bee9 Remove files param from output.zip endpoint
GitOrigin-RevId: 300cd870578237ad8e61be4e9e41991f884aa754
2024-09-24 08:04:57 +00:00
andrew rumble
c764566148 Allow all files to be in zip (in same directory)
GitOrigin-RevId: 14645a0c3db88faf00e2718b9574b5892ac3efcb
2024-09-24 08:04:53 +00:00
Antoine Clausse
2179d62d74 Merge pull request #20549 from overleaf/revert-20165-ac-update-node-fetch
Revert "Upgrade node-fetch to 2.7.0"

GitOrigin-RevId: 928df97c6fbc81f21097aaf9c331b0c70eeac002
2024-09-24 08:04:44 +00:00
Antoine Clausse
da3553d800 Upgrade node-fetch to 2.7.0 (#20165)
* Set `node-fetch` to `^2.7.0`

* Update package-lock.json

```
# root
bin/npm update node-fetch
bin/npm update cross-fetch

# in other path in docker
npm update node-fetch
```

* Update node-fetch patch

* [fetch-utils] Skip the test: destroys the request body if it doesn't get consumed

```
  1) fetch-utils
       fetchJson
         destroys the request body if it doesn't get consumed:
     FetchError: Invalid response body while trying to fetch http://example.com:30001/json/ignore-request: write EPIPE
      at PassThrough.<anonymous> (/overleaf/node_modules/node-fetch/lib/index.js:400:12)
      at PassThrough.emit (node:events:529:35)
      at emitErrorNT (node:internal/streams/destroy:151:8)
      at emitErrorCloseNT (node:internal/streams/destroy:116:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
```

* [fetch-utils] Delete the test: destroys the request body if it doesn't get consumed

* Remove the `setTimeout` in the node-fetch patch

Fixes a test and doesn't break filestore acceptance tests

* Update node-fetch patch again: bring changes from https://github.com/node-fetch/node-fetch/blob/e87b093/src/index.js

* Update node-fetch patch again: bring changes from https://github.com/node-fetch/node-fetch/blob/e87b093/src/index.js

* Update node-fetch patches back to single lines

Per https://github.com/overleaf/internal/pull/20165#discussion_r1739035513

GitOrigin-RevId: 945e5a12e838673b7bc87b588b7aca1bcd9109e2
2024-09-24 08:04:39 +00:00
Alf Eaton
2976fd0b44 Fix Dockerfile FromAsCasing warnings (#20388)
GitOrigin-RevId: 6d6be3ba17eec695907dde25da2dbe98818fae10
2024-09-23 08:04:52 +00:00
Eric Mc Sween
250acbf33c Merge pull request #20520 from overleaf/em-ts-import
Use new import JSDoc syntax for Typescript annotations

GitOrigin-RevId: 782456d637fc8f2de6163b5d70fabf06c1d74964
2024-09-23 08:04:47 +00:00
Antoine Clausse
6972186161 [latexqc] Disable cross-origin-*-policy (#20529)
* [latexqc] Disable `crossOriginEmbedderPolicy`

* [latexqc] Disable `crossOriginOpenerPolicy` and `crossOriginResourcePolicy`

* [latexqc] Update to helmet v7

* [latexqc] Disable `xPermittedCrossDomainPolicies`

GitOrigin-RevId: 36e4138b4ecb29fb8692f174e4f192f6eb554dc9
2024-09-23 08:04:42 +00:00
Antoine Clausse
3c459e2032 [latexqc] Update frontend dependencies (#20310)
* Add `LaTeX Quality Control` to the readme

* Update dependencies

* Match `web` version
* Update to modern packages
* Update to modern versions

* Import `Link` from `react-router-dom`

* Import Helmet correctly

* Remove `react-router-redux`

It seems that we're not actually getting anything from it (?)

* Update component containers/App

* Revert unecessary changes to containers/App

* Update component containers/Upload

* Revert unnecessary changes to container/Upload

* Fix links

* Add `withNavigation` HOC
* Fix link to `/upload`
* Remove unneeded `navigate` props

* SSR: Use `StaticRouterProvider`

* CSR: Use `createBrowserRouter`

* SSR: Simplify since we don't need to perform queries

* Add `data-testid`s to components

* Update tests (`enzyme` -> `@testing-library`)

* Remove unneeded "before" in tests

* Revert "Remove unneeded "before" in tests"

(actually necessary)

* Rename `devToolsExtension` to `__REDUX_DEVTOOLS_EXTENSION__`

Per https://github.com/zalmoxisus/redux-devtools-extension/issues/220

* Return 404 on invalid paths

* Remove unuseds dependencies

* Re-implement react-router `onUpdate` with `RouteChangedHandler`

It appears that `onUpdate` was removed from react-router
https://github.com/remix-run/react-router/issues/4278

* Update package-lock

* Remove debug log

GitOrigin-RevId: 3244b4266b53ac57a92ed4adc7c0e00b93a6b361
2024-09-20 08:06:00 +00:00
MoxAmber
2c53687ea1 Merge pull request #20477 from overleaf/as-jel-cms-bs5-quotes
[web] Use Bootstrap 5 for CMS Quotes

GitOrigin-RevId: 9f3699cd4588412176466ebfea1ddfa160da1535
2024-09-20 08:05:55 +00:00
MoxAmber
4b281becdd Merge pull request #20468 from overleaf/jel-cms-bs5-top-padding
[web] Update top padding on CMS BS5 pages

GitOrigin-RevId: c663886a9f28992a7056ac3f568980d1a5603699
2024-09-20 08:05:50 +00:00
MoxAmber
68eaec6d8e Merge pull request #20485 from overleaf/jel-cms-bs5-mobile-breakpoint
[web] Update mobile breakpoint for CMS pages using BS5

GitOrigin-RevId: b855faf378b03788caff8574747d88b96706de2a
2024-09-20 08:05:46 +00:00
MoxAmber
d9e5411ef3 Merge pull request #20444 from overleaf/td-bs5-add-non-react-types
Add types for Bootstrap 5 vanilla JavaScript

GitOrigin-RevId: 94efb0ba8fb0cea65f8a0993940bf76cd197c61e
2024-09-20 08:05:41 +00:00
MoxAmber
2a2ba46fc6 Merge pull request #20291 from overleaf/as-update-favicons
Update favicons and improve PWA icon support

GitOrigin-RevId: 972aae6b3791ba61a58787414eb6507f95ee8744
2024-09-20 08:05:36 +00:00
MoxAmber
d7a482966f Merge pull request #20463 from overleaf/as-jel-cms-text-align
[web] Option on CMS pages to center text only on destkop or mobile devices

GitOrigin-RevId: fd5006e4b46c53627cdc39cc41ea75f016411003
2024-09-20 08:05:31 +00:00
Eric Mc Sween
889fa1a3c3 Merge pull request #20317 from overleaf/em-github-sync-errors
Replace alerts with notifications in the github-sync modal

GitOrigin-RevId: 772add41b2d525353dc0c0362ebc64c4a023e2c3
2024-09-20 08:05:26 +00:00
David
af6ffdcf7c Merge pull request #20409 from overleaf/dk-selectLineOnFocus-fix
Fix scroll issue when focusing a change in new review panel

GitOrigin-RevId: 55784de415f65935ad9b1a8cd3ad82ea3ddac3c1
2024-09-20 08:05:17 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
8a0bed71e1 Merge pull request #20475 from overleaf/dk-fix-positionItems
Change focused item index to be per docId in new review panel

GitOrigin-RevId: af4b91cdc7128302a75f25d11c2afc5a2861abdd
2024-09-20 08:05:08 +00:00
David
8685d87920 Merge pull request #20494 from overleaf/dp-zero-message-thread
Don't show comment threads with zero messages

GitOrigin-RevId: e9efdf4fc1119b8fdafdd8a93c7cd9caed91a276
2024-09-20 08:05:03 +00:00
David
08a6caab80 Merge pull request #20405 from overleaf/dp-fix-empty-state-position
Fix positioning of review panel empty state

GitOrigin-RevId: d1c93e1a8bef59ad68e9f3e62106a949b7f9efdd
2024-09-20 08:04:57 +00:00
Miguel Serrano
8ca24b104b Script to track ES Modules migration progress (#20448)
* Script to track ES Modules migration progress

GitOrigin-RevId: 8582f529313c40c26d27d7c2f1542b1828c5a7e4
2024-09-19 08:05:16 +00:00
Jessica Lawshe
f2d986feb8 Merge pull request #20431 from overleaf/jel-cms-bs5-card
[web] Update cards for CMS BS5 pages

GitOrigin-RevId: d398f534993c187c2010a69d8ae0e5a067ab2a40
2024-09-19 08:05:04 +00:00
Jessica Lawshe
7ca2e47d78 Merge pull request #20429 from overleaf/jel-cms-bs5-vertical-spacing
[web] Always set top padding on columns on mobile for BS5 CMS pages

GitOrigin-RevId: 1532d960686ad324216a414e44a45ad5479ab564
2024-09-19 08:04:55 +00:00
Jessica Lawshe
a066e96b92 Merge pull request #20428 from overleaf/jel-cms-bootstrap5
[web] Updates for CMS pages using BS5 and new site design

GitOrigin-RevId: 08b66d1bfb3062a229f16a44efe70527f6fa67a7
2024-09-19 08:04:51 +00:00
Mathias Jakobsen
edf2c68c51 Merge pull request #20326 from overleaf/mj-filetree-restore-importtime
[web] Use importedAt timestamp for linked files if present

GitOrigin-RevId: 2132dfede83778a018e02fdba3d40180838f37af
2024-09-19 08:04:38 +00:00
Mathias Jakobsen
9719b3376c Merge pull request #20399 from overleaf/mj-set-import-time
[web] Set importedAt when creating linked files

GitOrigin-RevId: 06a549a20620eee33f64608d17a91d2e893f8f8a
2024-09-19 08:04:33 +00:00
Eric Mc Sween
1061152c31 Merge pull request #20466 from overleaf/em-revert-history-limit
Revert #20421

GitOrigin-RevId: c2ab656214354e3927f0e56ee7c09a8d0a53fd73
2024-09-18 08:05:10 +00:00
Eric Mc Sween
7cd16a84e0 Merge pull request #20421 from overleaf/em-history-limit-tracked-deletes
Do not count tracked deletes towards size limit in history

GitOrigin-RevId: 0185e6df80d8f3433aa489a1c90f5a6499af5ef4
2024-09-18 08:05:05 +00:00
Jimmy Domagala-Tang
5b73f08703 Merge pull request #20435 from overleaf/jdt-hide-wf-promo-from-wf-commons
Hide Writefull Promo From Writefull Commons Users

GitOrigin-RevId: 7adcb8f6e71c9c5b27da248e025b14a51fab703b
2024-09-18 08:05:00 +00:00
Mathias Jakobsen
a807a810e6 Merge pull request #20297 from overleaf/mj-stream-bib-log
[web] Stream .blg files before parsing

GitOrigin-RevId: 2e7a16a19e62fc32bbcb7fe35bed745b938e6963
2024-09-18 08:04:51 +00:00
Jessica Lawshe
3b839dc885 Merge pull request #20382 from overleaf/jel-bs5-website-redesign
[web] Begin to migrate `website-redesign.less` to BS5

GitOrigin-RevId: e3cf2162e819f7c137bbc2715dcd9a9fe6d72f3f
2024-09-17 08:06:21 +00:00
Jessica Lawshe
0d1c9ce79d Merge pull request #20372 from overleaf/jel-content-page-css-bs5
[web]  Copy content page CSS for BS5 build

GitOrigin-RevId: b12bc6e187d2f2709129948604f29f1092cb6bd9
2024-09-17 08:06:16 +00:00
Jessica Lawshe
8fc888bc90 Merge pull request #20349 from overleaf/jel-cms-css-bs5
[web] Copy CMS CSS for BS5 build

GitOrigin-RevId: 014c7014a14e242acf6d1104c472ad6971b62880
2024-09-17 08:06:08 +00:00
Jessica Lawshe
42a6464866 Merge pull request #20343 from overleaf/jel-begin-cms-bs5
[web] Begin Bootstrap 5 on CMS pages

GitOrigin-RevId: 886dc0c3afb7b61577838de12bc60f22e09c1db8
2024-09-17 08:06:03 +00:00
Jessica Lawshe
3746abc640 Merge pull request #20346 from overleaf/jel-font-bs5
[web] Copy text rendering CSS from BS3 for BS5

GitOrigin-RevId: a07fdc70aa0da6096f349c61ea6d74546724844a
2024-09-17 08:05:58 +00:00
Jessica Lawshe
e3c9017a85 Merge pull request #20328 from overleaf/jel-plans-tooltip
[web] Fix opacity on tooltip on light touch redesign plans page

GitOrigin-RevId: 3254fec50356815e223dec8e13e1c6351d642a1e
2024-09-17 08:05:53 +00:00
Jimmy Domagala-Tang
d41e069c69 Merge pull request #20404 from overleaf/revert-20389-jdt-add-writefull-commons-to-v1
Revert "Add writefull commons to v1"

GitOrigin-RevId: 703e2873cb64059f6a3881d6fc7f3c475caf5abd
2024-09-17 08:05:41 +00:00
Jimmy Domagala-Tang
aca9466c49 Merge pull request #20389 from overleaf/jdt-add-writefull-commons-to-v1
Add writefull commons to v1

GitOrigin-RevId: 36d1022f41b4db3701c6b8fa2120b035b05b38ba
2024-09-17 08:05:37 +00:00
Jimmy Domagala-Tang
e039d020a3 Merge pull request #20202 from overleaf/jdt-labs-widget-button-markup
fixing button style for labs widgets

GitOrigin-RevId: d2e8ce9b1efe1bfc0c5a021470b38107d5f1b6b8
2024-09-17 08:05:32 +00:00
andrew rumble
e537835718 Remove request dep and move fetch-utils to main deps
GitOrigin-RevId: c11bb10ab753bc726332a924b3d13617a1fb3b40
2024-09-17 08:05:12 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
David
9cf94e57d3 Include \def, \let, \newenvironment and \renewenvironment commands in the math preview (#20197)
* Include \def commands in command definitions

* Allow command name to be in CtrlSym

* Pull nodeIntersectsChange check out of branches

* Fix \def handling

* Add handling for \newenvironment and \renewenvironment

* Allow \def to have optional arguments

* :x
Revert "Add handling for \newenvironment and \renewenvironment"

This reverts commit a70d3a0a13ed552daf3b761893e3f8609f0b0fc8.

* Add let commands to defintions

* Add environment names to math preview

* Ignore let command definitions in autocomplete

* Move nodeIntersectsChange check back into each block

* Add childOfNodeWithType utility and use to get command names

* commandNameText -> commandName

* Only include environment definitions

* Rename documentEnvironmentNames to documentEnvironments

* EnvironmentName -> Environment

* Format

GitOrigin-RevId: 9c5d701423ae786e5ff91960b4bcd94cd35d21c8
2024-09-17 08:04:53 +00:00