Alasdair Smith
b4dd047371
Fix unnecessary right marging being applied to review panel when rich text is open
2018-07-11 15:15:22 +01:00
Timothée Alby
05bc4cc9e9
Merge pull request #729 from sharelatex/as-cursor-position
...
Abstract cursor position tracking so that it is not bound to Ace
2018-07-11 10:21:42 +02:00
Alasdair Smith
5806101bd0
Trigger events instead of calling cursor manager
...
This improves readability and prevents race conditions in compat
between Ace/CM
2018-07-10 16:05:01 +01:00
Alasdair Smith
da77c06774
Refactor saving cursor position to not use Ace event
...
This is will help with triggering CM correctly
2018-07-10 16:05:01 +01:00
Alasdair Smith
ba9fa9a0be
Store first visible line instead of scrollTop
...
scrollTop is affected by changing viewport size and switching between
Ace and CM
2018-07-10 16:05:01 +01:00
Alasdair Smith
6c7e942470
Unbind unload listener when destroying editor
2018-07-10 16:05:01 +01:00
Alasdair Smith
e5ad2a8724
Abstract Ace-specific code to adapter
2018-07-10 16:05:01 +01:00
Alasdair Smith
2dc509f43d
Fix memory leak setting up spell check
...
Switching docs would set up event listeners on Ace without tearing down
any old listeners, which could lead to a memory leak. This tears down
old listeners when detaching from the "old" doc
2018-07-10 12:25:13 +01:00
Alasdair Smith
b2abcfc3f2
Extract debounced load to service, so can be injected
2018-07-04 15:14:29 +01:00
Alasdair Smith
1f9c1ca6c6
Extracts envs to separate file so they can be exported to rich text
2018-07-04 15:14:29 +01:00
Alasdair Smith
33742d447d
Move top hundred snippets to snippets directory
...
Allows for more snippets in future. Also makes file name consistent
2018-07-04 15:14:29 +01:00
Nate Stemen
e9f8cceabb
fix syntax error
2018-06-22 10:23:33 -04:00
Nate Stemen
e7038f0a57
remove trailing } for all commands rather than relying on Helpers module
2018-06-18 15:08:25 -04:00
Nate Stemen
9f309e22a7
refactor AutoCompleteManager
2018-06-18 12:26:45 -04:00
Nate Stemen
b1c0552214
add ref command to snippets
2018-06-15 16:59:35 -04:00
Nate Stemen
4b1bc291cb
misspelled variable completionAfterCursor
2018-06-15 10:31:51 -04:00
Nate Stemen
b8787e6e68
modify dropdown to trigger on command completion if possible
2018-06-15 08:56:03 -04:00
Nate Stemen
26385718e6
only suggest thebibliography once
2018-06-05 11:02:03 -04:00
Nate Stemen
863128a030
only suggest one document environment in project
2018-06-05 10:08:27 -04:00
Alasdair Smith
309792401f
Re-focus editor after clicking suggestion
2018-05-21 10:35:43 +01:00
Alasdair Smith
c2d7809e05
Add removeWord so that learning word removes all highlights for given word
2018-05-18 14:23:36 +01:00
Alasdair Smith
a719ac6e6e
IE11 doesn't support Array.find so use underscore instead
2018-05-18 13:33:06 +01:00
Alasdair Smith
681e67ecea
Be more consistent with naming
2018-05-18 11:29:27 +01:00
Alasdair Smith
846f27f0ad
Clear highlights that are "touching" the cursor on change
...
This means that correcting a mistake won't wait until the request has resolved and that only the word at the end of the line will have it's spelling
highlight removed instead of the entire row
2018-05-18 11:29:27 +01:00
Alasdair Smith
2be023c731
Prevent spell error marker adding newly typed characters
2018-05-18 11:29:27 +01:00
Alasdair Smith
9fa85400b3
HighlightedWordManager is more naive about tracking position
...
We are relying entirely on Ace's tracking of markers with the anchor trick.
This means that we don't have to apply changes to ensure that the word manager
data structure tracks which row the highlights are on. This is traded off
against slightly less efficient searching/removing
2018-05-18 11:29:27 +01:00
Alasdair Smith
ebf1b7c84c
Extract SpellCheckAdapter to separate file
2018-05-18 11:29:27 +01:00
Alasdair Smith
d2bba0eb60
Fix firefox not closing contextmenu correctly
2018-05-18 11:29:27 +01:00
Alasdair Smith
034531d323
Replace word with suggestion and learn word
2018-05-18 11:29:27 +01:00
Alasdair Smith
cf123ce857
Extract spellMenu component and use when showing spell suggestions
2018-05-18 11:29:27 +01:00
Alasdair Smith
e6ffaaa489
Handle contextmenu for spelling
2018-05-18 11:29:27 +01:00
Alasdair Smith
8de2267824
Adapt aceEditor to use new spell check manager with adapter
2018-05-18 11:29:27 +01:00
Alasdair Smith
22e41cdce7
Simplify word manager to use Range + Anchor to automatically keep marker positions up-to-date
...
Re-implement highlighted word manager to be simpler
2018-05-18 11:29:16 +01:00
Alasdair Smith
37ca7b54a6
Re-implement spell check manager with adapter to abstract away editor
2018-05-18 11:29:16 +01:00
James Allen
ed7b68169e
Revert accidental dev changes to UndoManager
2018-05-11 17:05:39 +01:00
James Allen
dee96920b0
Allow font family and line height to be user configurable
2018-05-10 18:03:54 +01:00
James Allen
78aefc2871
Merge pull request #542 from sharelatex/ja-match-front-to-v1
...
Update font and line spacing in Ace to match OL v1
2018-05-09 12:24:37 +01:00
James Allen
1aadd7d369
Configure line height and font family separately for v2
2018-05-04 14:05:20 +01:00
James Allen
b847638ed1
Clean up comments and callbacks
2018-05-04 13:31:26 +01:00
James Allen
7e250be66d
Update font and line spacing in Ace to match OL v1
2018-05-03 17:04:49 +01:00
James Allen
8ecd073efc
Support Ctrl-. to compile for v1 compabitility
2018-05-03 12:28:14 +01:00
James Allen
09486f2eea
Recompile on Cmd-S and :w
2018-05-03 12:20:53 +01:00
Alasdair Smith
4a12754d90
Mark visible toggle switch as hidden from screen readers
2018-04-16 10:07:46 +01:00
Alasdair Smith
591f341f5f
Add switch-toggle directive
2018-04-16 09:36:10 +01:00
Alasdair Smith
3f8eda2223
Extract rich text code to module
2018-03-23 12:37:16 +00:00
Alasdair Smith
85ceab5310
Tear down Ace session when aceEditor is destroyed
...
This cleans up the Ace worker that parses syntax, preventing a memory leak
2018-02-23 10:13:24 +00:00
Alasdair Smith
598837e17c
Use applyAsync to prevent issue when switching docs
2018-02-22 11:44:09 +00:00
Alasdair Smith
c85e9ba3b1
Instead of setting value of CM, swap Docs
...
This allows for tracking changes on individual docs (i.e. files), instead of
just changes to the editor. This is similar to how Ace works with sessions
2018-02-22 11:44:09 +00:00
James Allen
29d2b408ad
Don't error when detaching from history with no sharejsDoc
2018-02-13 08:43:00 +00:00
James Allen
5d3ecdb924
Add explicit editor init event
2018-02-13 08:27:48 +00:00
